[webkit-dev] Removing mac-leopard platform
Hi All, Mac Leopard buildslaves were removed by r97496: http://trac.webkit.org/changeset/97496/trunk/Tools/BuildSlaveSupport/build.webkit.org-config Shouldn't we remove the LayoutTests/platform/mac-leopard directory? ( ~150Mb, ~4800 files) br, Ossy ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Supporting w3c ref tests and changing our convention
On 11/4/11 7:20 PM, Ojan Vafai o...@chromium.org wrote: On Fri, Nov 4, 2011 at 7:16 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Nov 4, 2011 at 7:07 PM, Ojan Vafai o...@chromium.org wrote: On Fri, Nov 4, 2011 at 7:03 PM, Ryosuke Niwa rn...@webkit.org wrote: I am, but I'm particularly concerned about W3C tests. It'll be nice if we had exactly one way of running / writing ref tests. I think we can easily automate the process of generating manifest files. The work flow will be as follows: 1. Write new ref tests using link element 2. Run some tool (maybe we can teach run-webkit-tests to do it automatically) 3. Upload patch with auto-regenerated manifest file It's mainly step 2 that I have a problem with, although I also don't like that the test is not self-contained. Generating manifest file when we add a test is much more efficient than generating it every time we run tests because we tend to do the latter much more often than the former. I think we're at an empass here. I don't see that further technical arguments will sway either of us. I do, however, expect that the vast majority of webkit developers would prefer to avoid a manifest file given the way the project has been structured up to now. What if we defer some of the W3C metadata work until tests were actually submitted to the W3C? 1. Tests we pull from W3C can run from manifests, since they are provided. 2. Tests we develop ourselves just use a naming convention (refs are named *-ref.html, and there's one ref per test even if that's duplicative) 3. When we choose to share a set of tests with the W3C, we do the extra work of adding metadata to the tests and possibly refactoring to reduce the number of -ref files. Once the W3C approves the tests we pull their copies and delete ours. Alan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Removing mac-leopard platform
The Chromium Leopard bots still fallback to this directory. That said, if Apple doesn't need this directory anymore, I'm fine with deleting it and adding any new results we need into the chromium-mac-leopard directory. I'm not sure how other Chromium folk feel about that or how much longer Chromium intends to support Leopard. On Mon, Nov 7, 2011 at 3:50 AM, Osztrogonac Csaba o...@inf.u-szeged.huwrote: Hi All, Mac Leopard buildslaves were removed by r97496: http://trac.webkit.org/**changeset/97496/trunk/Tools/** BuildSlaveSupport/build.**webkit.org-confighttp://trac.webkit.org/changeset/97496/trunk/Tools/BuildSlaveSupport/build.webkit.org-config Shouldn't we remove the LayoutTests/platform/mac-**leopard directory? ( ~150Mb, ~4800 files) br, Ossy __**_ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/**mailman/listinfo.cgi/webkit-**devhttp://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Removing mac-leopard platform
IMHO, Chromium shouldn't cause us to keep the mac-leopard directory. Adam On Mon, Nov 7, 2011 at 9:10 AM, Ojan Vafai o...@chromium.org wrote: The Chromium Leopard bots still fallback to this directory. That said, if Apple doesn't need this directory anymore, I'm fine with deleting it and adding any new results we need into the chromium-mac-leopard directory. I'm not sure how other Chromium folk feel about that or how much longer Chromium intends to support Leopard. On Mon, Nov 7, 2011 at 3:50 AM, Osztrogonac Csaba o...@inf.u-szeged.hu wrote: Hi All, Mac Leopard buildslaves were removed by r97496: http://trac.webkit.org/changeset/97496/trunk/Tools/BuildSlaveSupport/build.webkit.org-config Shouldn't we remove the LayoutTests/platform/mac-leopard directory? ( ~150Mb, ~4800 files) br, Ossy ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Removing mac-leopard platform
I support merging mac-leopard into chromium-mac-leopard if Apple wants to remove mac-leopard directory. - Ryosuke On Mon, Nov 7, 2011 at 9:10 AM, Ojan Vafai o...@chromium.org wrote: The Chromium Leopard bots still fallback to this directory. That said, if Apple doesn't need this directory anymore, I'm fine with deleting it and adding any new results we need into the chromium-mac-leopard directory. I'm not sure how other Chromium folk feel about that or how much longer Chromium intends to support Leopard. On Mon, Nov 7, 2011 at 3:50 AM, Osztrogonac Csaba o...@inf.u-szeged.huwrote: Hi All, Mac Leopard buildslaves were removed by r97496: http://trac.webkit.org/**changeset/97496/trunk/Tools/** BuildSlaveSupport/build.**webkit.org-confighttp://trac.webkit.org/changeset/97496/trunk/Tools/BuildSlaveSupport/build.webkit.org-config Shouldn't we remove the LayoutTests/platform/mac-**leopard directory? ( ~150Mb, ~4800 files) br, Ossy __**_ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/**mailman/listinfo.cgi/webkit-**devhttp://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Removing Support for Python 2.5
Hello, I should have asked on this thread before, but just saw it now. But since it's in the same topic, what do you think about changing python scripts from using /usr/bin/python to /usr/bin/python2 ? I opened a bug for this some minutes ago: https://bugs.webkit.org/show_bug.cgi?id=71723 Regards, Rafael On Fri, Nov 4, 2011 at 9:45 PM, Eric Seidel e...@webkit.org wrote: Tony: I would recommend upgrading to at least 2.7 on those machines. http://www.python.org/download/releases/2.7.2/ I would love to switch us to require 2.7 but such would currently too much of a burden on SnowLeopard-based developers. -eric On Fri, Nov 4, 2011 at 4:03 PM, Adam Barth aba...@webkit.org wrote: I misremembered. Looking at depot_tools, it seems Chromium only does this on Windows. Looks like we might need to upgrade the Chromium bots to use 2.6. Python 2.5 is super old at this point. Adam On Fri, Nov 4, 2011 at 4:01 PM, Tony Chang t...@chromium.org wrote: Are you sure? This output has references to System/Library/Frameworks/Python.framework/Versions/2.5. I also thought that's why NRWT was slow on the Leopard bots: python 2.5 doesn't have the multiprocess module. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28dbg%29%281%29/builds/4090/steps/webkit_tests/logs/stdio It may just be a bug that these bots aren't using python2.6. On Fri, Nov 4, 2011 at 3:40 PM, Adam Barth aba...@webkit.org wrote: Yes, Chromium versions its Python independently from the OS. Adam On Fri, Nov 4, 2011 at 3:25 PM, Ojan Vafai o...@chromium.org wrote: I believe the chromium port always uses 2.6 though, no? On Fri, Nov 4, 2011 at 3:23 PM, Nico Weber tha...@chromium.org wrote: The chromium port still has a bot that runs tests (but doesn't build) on 10.5. Nico On Fri, Nov 4, 2011 at 3:20 PM, Eric Seidel e...@webkit.org wrote: Now that Apple has removed the Leopard build bot (and presumably stopped supporting WebKit on Leopard), all webkit platforms I know of have Python 2.6 or higher. My plan is to remove all of our 2.5 supporting code in the next week, requiring Python 2.6 or later for WebKit. Let me know if this will be an issue for you. Thanks! -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Removing Support for Python 2.5
$ /usr/bin/python2 -bash: /usr/bin/python2: No such file or directory I have a pretty standard setup, so it looks like that won't work for most developers. Adam On Mon, Nov 7, 2011 at 1:08 PM, Rafael Antognolli antogno...@profusion.mobi wrote: Hello, I should have asked on this thread before, but just saw it now. But since it's in the same topic, what do you think about changing python scripts from using /usr/bin/python to /usr/bin/python2 ? I opened a bug for this some minutes ago: https://bugs.webkit.org/show_bug.cgi?id=71723 Regards, Rafael On Fri, Nov 4, 2011 at 9:45 PM, Eric Seidel e...@webkit.org wrote: Tony: I would recommend upgrading to at least 2.7 on those machines. http://www.python.org/download/releases/2.7.2/ I would love to switch us to require 2.7 but such would currently too much of a burden on SnowLeopard-based developers. -eric On Fri, Nov 4, 2011 at 4:03 PM, Adam Barth aba...@webkit.org wrote: I misremembered. Looking at depot_tools, it seems Chromium only does this on Windows. Looks like we might need to upgrade the Chromium bots to use 2.6. Python 2.5 is super old at this point. Adam On Fri, Nov 4, 2011 at 4:01 PM, Tony Chang t...@chromium.org wrote: Are you sure? This output has references to System/Library/Frameworks/Python.framework/Versions/2.5. I also thought that's why NRWT was slow on the Leopard bots: python 2.5 doesn't have the multiprocess module. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28dbg%29%281%29/builds/4090/steps/webkit_tests/logs/stdio It may just be a bug that these bots aren't using python2.6. On Fri, Nov 4, 2011 at 3:40 PM, Adam Barth aba...@webkit.org wrote: Yes, Chromium versions its Python independently from the OS. Adam On Fri, Nov 4, 2011 at 3:25 PM, Ojan Vafai o...@chromium.org wrote: I believe the chromium port always uses 2.6 though, no? On Fri, Nov 4, 2011 at 3:23 PM, Nico Weber tha...@chromium.org wrote: The chromium port still has a bot that runs tests (but doesn't build) on 10.5. Nico On Fri, Nov 4, 2011 at 3:20 PM, Eric Seidel e...@webkit.org wrote: Now that Apple has removed the Leopard build bot (and presumably stopped supporting WebKit on Leopard), all webkit platforms I know of have Python 2.6 or higher. My plan is to remove all of our 2.5 supporting code in the next week, requiring Python 2.6 or later for WebKit. Let me know if this will be an issue for you. Thanks! -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Removing Support for Python 2.5
Has there been any thought of moving to /usr/bin/env python for systems with python installed in a different path? -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- boun...@lists.webkit.org] On Behalf Of Adam Barth Sent: Monday, November 07, 2011 4:36 PM To: Rafael Antognolli Cc: WebKit Development Subject: Re: [webkit-dev] Removing Support for Python 2.5 $ /usr/bin/python2 -bash: /usr/bin/python2: No such file or directory I have a pretty standard setup, so it looks like that won't work for most developers. Adam On Mon, Nov 7, 2011 at 1:08 PM, Rafael Antognolli antogno...@profusion.mobi wrote: Hello, I should have asked on this thread before, but just saw it now. But since it's in the same topic, what do you think about changing python scripts from using /usr/bin/python to /usr/bin/python2 ? I opened a bug for this some minutes ago: https://bugs.webkit.org/show_bug.cgi?id=71723 Regards, Rafael On Fri, Nov 4, 2011 at 9:45 PM, Eric Seidel e...@webkit.org wrote: Tony: I would recommend upgrading to at least 2.7 on those machines. http://www.python.org/download/releases/2.7.2/ I would love to switch us to require 2.7 but such would currently too much of a burden on SnowLeopard-based developers. -eric On Fri, Nov 4, 2011 at 4:03 PM, Adam Barth aba...@webkit.org wrote: I misremembered. Looking at depot_tools, it seems Chromium only does this on Windows. Looks like we might need to upgrade the Chromium bots to use 2.6. Python 2.5 is super old at this point. Adam On Fri, Nov 4, 2011 at 4:01 PM, Tony Chang t...@chromium.org wrote: Are you sure? This output has references to System/Library/Frameworks/Python.framework/Versions/2.5. I also thought that's why NRWT was slow on the Leopard bots: python 2.5 doesn't have the multiprocess module. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%2 0%28dbg%29%281%29/builds/4090/steps/webkit_tests/logs/stdio It may just be a bug that these bots aren't using python2.6. On Fri, Nov 4, 2011 at 3:40 PM, Adam Barth aba...@webkit.org wrote: Yes, Chromium versions its Python independently from the OS. Adam On Fri, Nov 4, 2011 at 3:25 PM, Ojan Vafai o...@chromium.org wrote: I believe the chromium port always uses 2.6 though, no? On Fri, Nov 4, 2011 at 3:23 PM, Nico Weber tha...@chromium.org wrote: The chromium port still has a bot that runs tests (but doesn't build) on 10.5. Nico On Fri, Nov 4, 2011 at 3:20 PM, Eric Seidel e...@webkit.org wrote: Now that Apple has removed the Leopard build bot (and presumably stopped supporting WebKit on Leopard), all webkit platforms I know of have Python 2.6 or higher. My plan is to remove all of our 2.5 supporting code in the next week, requiring Python 2.6 or later for WebKit. Let me know if this will be an issue for you. Thanks! -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev - This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
Re: [webkit-dev] Removing Support for Python 2.5
On Mon, Nov 7, 2011 at 2:41 PM, Joe Mason jma...@rim.com wrote: Has there been any thought of moving to /usr/bin/env python for systems with python installed in a different path? Yes. I'm happy to review any patches that change use to using /usr/bin/env python. Adam -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- boun...@lists.webkit.org] On Behalf Of Adam Barth Sent: Monday, November 07, 2011 4:36 PM To: Rafael Antognolli Cc: WebKit Development Subject: Re: [webkit-dev] Removing Support for Python 2.5 $ /usr/bin/python2 -bash: /usr/bin/python2: No such file or directory I have a pretty standard setup, so it looks like that won't work for most developers. Adam On Mon, Nov 7, 2011 at 1:08 PM, Rafael Antognolli antogno...@profusion.mobi wrote: Hello, I should have asked on this thread before, but just saw it now. But since it's in the same topic, what do you think about changing python scripts from using /usr/bin/python to /usr/bin/python2 ? I opened a bug for this some minutes ago: https://bugs.webkit.org/show_bug.cgi?id=71723 Regards, Rafael On Fri, Nov 4, 2011 at 9:45 PM, Eric Seidel e...@webkit.org wrote: Tony: I would recommend upgrading to at least 2.7 on those machines. http://www.python.org/download/releases/2.7.2/ I would love to switch us to require 2.7 but such would currently too much of a burden on SnowLeopard-based developers. -eric On Fri, Nov 4, 2011 at 4:03 PM, Adam Barth aba...@webkit.org wrote: I misremembered. Looking at depot_tools, it seems Chromium only does this on Windows. Looks like we might need to upgrade the Chromium bots to use 2.6. Python 2.5 is super old at this point. Adam On Fri, Nov 4, 2011 at 4:01 PM, Tony Chang t...@chromium.org wrote: Are you sure? This output has references to System/Library/Frameworks/Python.framework/Versions/2.5. I also thought that's why NRWT was slow on the Leopard bots: python 2.5 doesn't have the multiprocess module. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%2 0%28dbg%29%281%29/builds/4090/steps/webkit_tests/logs/stdio It may just be a bug that these bots aren't using python2.6. On Fri, Nov 4, 2011 at 3:40 PM, Adam Barth aba...@webkit.org wrote: Yes, Chromium versions its Python independently from the OS. Adam On Fri, Nov 4, 2011 at 3:25 PM, Ojan Vafai o...@chromium.org wrote: I believe the chromium port always uses 2.6 though, no? On Fri, Nov 4, 2011 at 3:23 PM, Nico Weber tha...@chromium.org wrote: The chromium port still has a bot that runs tests (but doesn't build) on 10.5. Nico On Fri, Nov 4, 2011 at 3:20 PM, Eric Seidel e...@webkit.org wrote: Now that Apple has removed the Leopard build bot (and presumably stopped supporting WebKit on Leopard), all webkit platforms I know of have Python 2.6 or higher. My plan is to remove all of our 2.5 supporting code in the next week, requiring Python 2.6 or later for WebKit. Let me know if this will be an issue for you. Thanks! -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev - This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use,
[webkit-dev] new-run-webkit-tests --gtk fails with AttributeError: GtkDriver instance has no attribute '_server_process'
I'm trying to run NRWT for gtk build revision 99472.
But script fails with exceptions:
AttributeError: GtkDriver instance has no attribute '_server_process'
worker/0 raised OSError('[Errno 2] No such file or directory'):
Traceback is available here: http://pastebin.com/B5pE8AJg
Is there a bug in script or I'm doing something wrong?
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] new-run-webkit-tests --gtk fails with AttributeError: GtkDriver instance has no attribute '_server_process'
Please file a bug at bugs.webkit.org and I will happily fix it.
-eric
On Mon, Nov 7, 2011 at 3:54 PM, Vanya Yani van...@gmail.com wrote:
I'm trying to run NRWT for gtk build revision 99472.
But script fails with exceptions:
AttributeError: GtkDriver instance has no attribute '_server_process'
worker/0 raised OSError('[Errno 2] No such file or directory'):
Traceback is available here: http://pastebin.com/B5pE8AJg
Is there a bug in script or I'm doing something wrong?
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] new-run-webkit-tests --gtk fails with AttributeError: GtkDriver instance has no attribute '_server_process'
On Mon, Nov 7, 2011 at 3:54 PM, Vanya Yani van...@gmail.com wrote:
I'm trying to run NRWT for gtk build revision 99472.
But script fails with exceptions:
AttributeError: GtkDriver instance has no attribute '_server_process'
worker/0 raised OSError('[Errno 2] No such file or directory'):
Traceback is available here: http://pastebin.com/B5pE8AJg
Is there a bug in script or I'm doing something wrong?
Have you installed all the dependencies listed here:
http://trac.webkit.org/wiki/WebKitGtkLayoutTests ?
--Martin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Putting layout tests on a separate repository (was Supporting w3c ref tests and changing our convention)
On Nov 4, 2011 4:59 PM, Dirk Pranke dpra...@chromium.org wrote: On Fri, Nov 4, 2011 at 3:21 PM, Alan Stearns stea...@adobe.com wrote: Once we figure out how to support imported reftests, we should be encouraging people to use reftests internally (even for tests we have no intention of pushing to the W3C) instead of dumprendertree or pixel tests (where possible - I assume reftests won't always work for visual tests). Actually, we should be encouraging people to use reftests now, since every port but two supports them, and we should be moving the last two over ASAP. I'd argue that we should not encourage people from writing reftests until we migrate those two ports to NRWT and https://bugs.webkit.org/show_bug.cgi?id=60605 is fixed given all but Chromium port's bots run pixel tests. In fact, I'd strongly discourage people from writing reftests for features that are enabled on all ports until the above two conditions are met. - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Putting layout tests on a separate repository (was Supporting w3c ref tests and changing our convention)
On Nov 7, 2011 8:00 PM, Ryosuke Niwa rn...@webkit.org wrote: I'd argue that we should not encourage people from writing reftests until we migrate those two ports to NRWT and https://bugs.webkit.org/show_bug.cgi?id=60605 is fixed given all but Chromium port's bots run pixel tests. I meant to say only Chromium port's bots run pixel tests. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Putting layout tests on a separate repository (was Supporting w3c ref tests and changing our convention)
On Mon, Nov 7, 2011 at 8:00 PM, Ryosuke Niwa rn...@webkit.org wrote: On Nov 4, 2011 4:59 PM, Dirk Pranke dpra...@chromium.org wrote: Actually, we should be encouraging people to use reftests now, since every port but two supports them, and we should be moving the last two over ASAP. I'd argue that we should not encourage people from writing reftests until we migrate those two ports to NRWT... It sounds like those last two port don't run pixel tests, so there wouldn't be a reduction in coverage by using reftests even before they are migrated, right? dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Putting layout tests on a separate repository (was Supporting w3c ref tests and changing our convention)
On Mon, Nov 7, 2011 at 8:47 PM, David Levin le...@chromium.org wrote: On Mon, Nov 7, 2011 at 8:00 PM, Ryosuke Niwa rn...@webkit.org wrote: On Nov 4, 2011 4:59 PM, Dirk Pranke dpra...@chromium.org wrote: Actually, we should be encouraging people to use reftests now, since every port but two supports them, and we should be moving the last two over ASAP. I'd argue that we should not encourage people from writing reftests until we migrate those two ports to NRWT... It sounds like those last two port don't run pixel tests, so there wouldn't be a reduction in coverage by using reftests even before they are migrated, right? They don't generate or compare ping images but they DO generate and compare render tree dump tests for non tests so converting the existing tests to reftests will reduce their test coverage. - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Supporting w3c ref tests and changing our convention
It appears that we're not reaching any consensus here, and I don't feel like continuing any more bikeshedding. If anyone's interested, my patch for https://bugs.webkit.org/show_bug.cgi?id=66837 and Hayato's patch for https://bugs.webkit.org/show_bug.cgi?id=71567 add a basic support for W3C style ref tests based on reftest.list parsing. - Ryouske ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
