Re: [webkit-dev] Double-Resolution (Retina) Images - Re: -webkit-image-set

2012-04-24 Thread Eric Seidel
Assuming I'm understanding Kalle correctly, it seems this could
already be accomplished with @media resolution?

http://www.w3.org/TR/css3-mediaqueries/#resolution

@media screen and (min-resolution: 264dpi) { … }

Which according to:
http://en.wikipedia.org/wiki/List_of_displays_by_pixel_density

Would match both the new iPad and the iPhone 4.

I don't know if webkit supports resolution in media queries yet?

On Mon, Apr 23, 2012 at 9:28 PM, Kalle Vahlman kalle.vahl...@gmail.com wrote:
 2012/4/24 Tom Penzer tpen...@mailcan.com:
 Hi Everybody!

        As a first-time poster, I am sorry ahead of time for any lapses in
 etiquette. I am seeking feedback for my (hopefully relatively painless in
 practice compared to the alternatives - i.e. -webkit-image-set and html5
 image) proposal to solve the problem of 2x-res (double-resolution) images
 with our current HTML and CSS standards for devices with high-resolution
 displays, such as 3rd Generation iPads and 4th generation iPhones and newer.

 This seems like a perfect use-case for the @media rule of CSS, does it not?

 It's obviously not up-to-date in its definition (eg. handheld devices
 are not typically small screen, limited bandwidth anymore), but on
 the other hand it allows undefined types as well so nothing prevents
 implementers to extend it beforehand (like is done with most CSS
 properties anyway).

 --
 Kalle Vahlman, z...@iki.fi
 Powered by http://movial.com
 Interesting stuff at http://sandbox.movial.com
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Double-Resolution (Retina) Images - Re: -webkit-image-set

2012-04-24 Thread Eric Seidel
To answer my own question:
http://trac.webkit.org/browser/trunk/Source/WebCore/css/MediaQueryEvaluator.cpp#L66

On Mon, Apr 23, 2012 at 11:11 PM, Eric Seidel e...@webkit.org wrote:
 Assuming I'm understanding Kalle correctly, it seems this could
 already be accomplished with @media resolution?

 http://www.w3.org/TR/css3-mediaqueries/#resolution

 @media screen and (min-resolution: 264dpi) { … }

 Which according to:
 http://en.wikipedia.org/wiki/List_of_displays_by_pixel_density

 Would match both the new iPad and the iPhone 4.

 I don't know if webkit supports resolution in media queries yet?

 On Mon, Apr 23, 2012 at 9:28 PM, Kalle Vahlman kalle.vahl...@gmail.com 
 wrote:
 2012/4/24 Tom Penzer tpen...@mailcan.com:
 Hi Everybody!

        As a first-time poster, I am sorry ahead of time for any lapses in
 etiquette. I am seeking feedback for my (hopefully relatively painless in
 practice compared to the alternatives - i.e. -webkit-image-set and html5
 image) proposal to solve the problem of 2x-res (double-resolution) images
 with our current HTML and CSS standards for devices with high-resolution
 displays, such as 3rd Generation iPads and 4th generation iPhones and newer.

 This seems like a perfect use-case for the @media rule of CSS, does it not?

 It's obviously not up-to-date in its definition (eg. handheld devices
 are not typically small screen, limited bandwidth anymore), but on
 the other hand it allows undefined types as well so nothing prevents
 implementers to extend it beforehand (like is done with most CSS
 properties anyway).

 --
 Kalle Vahlman, z...@iki.fi
 Powered by http://movial.com
 Interesting stuff at http://sandbox.movial.com
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Double-Resolution (Retina) Images - Re: -webkit-image-set

2012-04-24 Thread Maciej Stachowiak

It would be more readable to use:

@media screen and (min-device-pixel-ratio: 2) { … }

The -webkit-image-set proposal explains why it is a useful shorthand despite 
the existing device pixel ratio option.

Regards,
Maciej


On Apr 23, 2012, at 11:11 PM, Eric Seidel wrote:

 Assuming I'm understanding Kalle correctly, it seems this could
 already be accomplished with @media resolution?
 
 http://www.w3.org/TR/css3-mediaqueries/#resolution
 
 @media screen and (min-resolution: 264dpi) { … }
 
 Which according to:
 http://en.wikipedia.org/wiki/List_of_displays_by_pixel_density
 
 Would match both the new iPad and the iPhone 4.
 
 I don't know if webkit supports resolution in media queries yet?
 
 On Mon, Apr 23, 2012 at 9:28 PM, Kalle Vahlman kalle.vahl...@gmail.com 
 wrote:
 2012/4/24 Tom Penzer tpen...@mailcan.com:
 Hi Everybody!
 
As a first-time poster, I am sorry ahead of time for any lapses in
 etiquette. I am seeking feedback for my (hopefully relatively painless in
 practice compared to the alternatives - i.e. -webkit-image-set and html5
 image) proposal to solve the problem of 2x-res (double-resolution) images
 with our current HTML and CSS standards for devices with high-resolution
 displays, such as 3rd Generation iPads and 4th generation iPhones and newer.
 
 This seems like a perfect use-case for the @media rule of CSS, does it not?
 
 It's obviously not up-to-date in its definition (eg. handheld devices
 are not typically small screen, limited bandwidth anymore), but on
 the other hand it allows undefined types as well so nothing prevents
 implementers to extend it beforehand (like is done with most CSS
 properties anyway).
 
 --
 Kalle Vahlman, z...@iki.fi
 Powered by http://movial.com
 Interesting stuff at http://sandbox.movial.com
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Debugging With Xcode

2012-04-24 Thread Eric Seidel
I have updated to the latest Xcode.

My current hack for being able to build from the command line as well
as within Xcode is that I've manually added symlinks from
Source/WebCore/build - ../../WebKitBuild (since it no longer seems
possible to set a global build directory).  It seems to be working
mostly (it likes to re-link, but is at least not re-compiling when I
switch between build-webkit and Xcode).

I'm told that the Xcode4 way to share build directories is with
Workspaces? [1] Has anyone set up a workspace file for WebKit that I
could use?  I don't see one in the repository.

Thanks.

-eric

1. 
http://developer.apple.com/library/ios/#featuredarticles/XcodeConcepts/Concept-Workspace.html#//apple_ref/doc/uid/TP40009328-CH7-SW1

On Mon, Apr 23, 2012 at 7:30 PM, Ryosuke Niwa rn...@webkit.org wrote:
 Has anyone successfully setup DRT as a debug target (a.k.a. Scheme) on XCode
 4 (so that we don't have to manually attach dbg)?

 - Ryosuke

 On Mon, Apr 23, 2012 at 7:07 PM, Jarred Nicholls jar...@webkit.org wrote:

 On Apr 23, 2012, at 9:03 PM, Eric Seidel e...@webkit.org wrote:

  Does anyone still debug WebKit on Mac OS X with Xcode 4?
 
 
  1.  I don't know how to actually set up Xcode to point to WebKitBuild
  like it used to.
  http://www.webkit.org/building/debug.html
  Mentions a Legacy option which does not exist for me.
 
  Simon Fraser helped me set up WebKitBuild on one of my machines, but I
  don't really know how to repeat that process.
 
 
  2.  Xcode tries to Re-index WebCore, seemingly every time I open
  WebCore.xcodeproj.  This is a hour+ process on my 12-core Mac Pro!
 
  The re-indexing takes a lot of processing power, and seems to render
  both my machine, and Xcode largely unusable.
 
 
  I understand that Xcode isn't really designed for projects as large as
  WebCore, but we've made it work in the past, and I'm curious if anyone
  is still making it work?
 
 
  If the Apple folks have any suggestions or updates to
  http://www.webkit.org/building/debug.html, they would be most
  appreciated. :)
 
  Thanks!
 
  -eric
 
  Xcode 4.2.1
  Build version 4D502
  ___
  webkit-dev mailing list
  webkit-dev@lists.webkit.org
  http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

 I usually create an empty project, add the source files I care about, and
 then attach to the appropriate renderer process - but also use
 WebCore.xcodeproj directly on occasion.  I run the same version as you and
 once ran into an infinite indexing cycle, but after a swift kick from
 Activity Monitor, I haven't seen it again.  Xcode works great as a gdb front
 end for me.
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread Adam Roben
On Wed, Apr 18, 2012 at 11:02 AM, Simon Hausmann
simon.hausm...@nokia.com wrote:
 On Wednesday, April 18, 2012 06:53:46 AM ext Shezan Baig wrote:
 Hi WebKit,

 I've been using a fork of the following repo:
 https://github.com/WebKit/webkit

 However, yesterday there was discussion on #webkit that the SHA-1 checksums
 on this repo are different from repo at git.webkit.org, which means folks
 working on both need to have both versions checked out.

 I believe the reason for them being different is because in the github repo 
 the
 commit author fields are resolved.

That looks correct to me:


$ diff -u (GIT_DIR=WebKit/.git git cat-file -p
df242ce698c19b591e975d88c29f7411b2f2963d) (GIT_DIR=GitHubWebKit/.git
git cat-file -p 93f4255f7cb09996f0a9a354754c7902da87d1a3)
--- /dev/fd/63  2012-04-24 09:01:56.0 -0400
+++ /dev/fd/62  2012-04-24 09:01:56.0 -0400
@@ -1,7 +1,7 @@
 tree 492d5271473c516151a406aa02ebdbf1b494e758
-parent 1973d7515628dd8a4b3dd7559f0b0e2073096590
-author kl...@webkit.org
kl...@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc 1335221533
+
-committer kl...@webkit.org
kl...@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc 1335221533
+
+parent 9e00d90f6474a88108fe9d875d80ba2c04302733
+author Andreas Kling kl...@webkit.org 1335221533 +
+committer Andreas Kling kl...@webkit.org 1335221533 +

 [Mac] WebProcess should empty cache on a background thread/block.
 http://webkit.org/b/84619

You can see above that the tree and commit message are identical
between the two repositories. But the author and committer are
different, which causes the commit hash to be different (and since
this is true for older commits as well, the parent hash is different
too).

-Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread Adam Roben
Well that turned out ugly. Let's try again:

$ diff -u (GIT_DIR=WebKit/.git git cat-file -p
df242ce698c19b591e975d88c29f7411b2f2963d) (GIT_DIR=GitHubWebKit/.git git
cat-file -p 93f4255f7cb09996f0a9a354754c7902da87d1a3)
--- /dev/fd/63 2012-04-24 09:01:56.0 -0400
+++ /dev/fd/62 2012-04-24 09:01:56.0 -0400
@@ -1,7 +1,7 @@
 tree 492d5271473c516151a406aa02ebdbf1b494e758
-parent 1973d7515628dd8a4b3dd7559f0b0e2073096590
-author kl...@webkit.org
kl...@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc
1335221533 +
-committer kl...@webkit.org
kl...@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc
1335221533 +
+parent 9e00d90f6474a88108fe9d875d80ba2c04302733
+author Andreas Kling kl...@webkit.org 1335221533 +
+committer Andreas Kling kl...@webkit.org 1335221533 +

 [Mac] WebProcess should empty cache on a background thread/block.
 http://webkit.org/b/84619

-Adam

On Tue, Apr 24, 2012 at 9:03 AM, Adam Roben aro...@webkit.org wrote:
 On Wed, Apr 18, 2012 at 11:02 AM, Simon Hausmann
 simon.hausm...@nokia.com wrote:
 On Wednesday, April 18, 2012 06:53:46 AM ext Shezan Baig wrote:
 Hi WebKit,

 I've been using a fork of the following repo:
 https://github.com/WebKit/webkit

 However, yesterday there was discussion on #webkit that the SHA-1
checksums
 on this repo are different from repo at git.webkit.org, which means
folks
 working on both need to have both versions checked out.

 I believe the reason for them being different is because in the github
repo the
 commit author fields are resolved.

 That looks correct to me:


 $ diff -u (GIT_DIR=WebKit/.git git cat-file -p
 df242ce698c19b591e975d88c29f7411b2f2963d) (GIT_DIR=GitHubWebKit/.git
 git cat-file -p 93f4255f7cb09996f0a9a354754c7902da87d1a3)
 --- /dev/fd/63  2012-04-24 09:01:56.0 -0400
 +++ /dev/fd/62  2012-04-24 09:01:56.0 -0400
 @@ -1,7 +1,7 @@
  tree 492d5271473c516151a406aa02ebdbf1b494e758
 -parent 1973d7515628dd8a4b3dd7559f0b0e2073096590
 -author kl...@webkit.org
 kl...@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc 1335221533
 +
 -committer kl...@webkit.org
 kl...@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc 1335221533
 +
 +parent 9e00d90f6474a88108fe9d875d80ba2c04302733
 +author Andreas Kling kl...@webkit.org 1335221533 +
 +committer Andreas Kling kl...@webkit.org 1335221533 +

  [Mac] WebProcess should empty cache on a background thread/block.
  http://webkit.org/b/84619

 You can see above that the tree and commit message are identical
 between the two repositories. But the author and committer are
 different, which causes the commit hash to be different (and since
 this is true for older commits as well, the parent hash is different
 too).

 -Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread Adam Roben
On Wed, Apr 18, 2012 at 11:06 AM, Jarred Nicholls jar...@webkit.org wrote:

 (from correct address)

 On Wed, Apr 18, 2012 at 11:06 AM, Jarred Nicholls jar...@sencha.comwrote:

 On Wed, Apr 18, 2012 at 11:02 AM, Simon Hausmann 
 simon.hausm...@nokia.com wrote:

 On Wednesday, April 18, 2012 06:53:46 AM ext Shezan Baig wrote:
  Hi WebKit,
 
  I've been using a fork of the following repo:
  https://github.com/WebKit/webkit
 
  However, yesterday there was discussion on #webkit that the SHA-1
 checksums
  on this repo are different from repo at git.webkit.org, which means
 folks
  working on both need to have both versions checked out.

 I believe the reason for them being different is because in the github
 repo the
 commit author fields are resolved.


 Yeah that's totally it.  So svn.webkit.org = git.webkit.org = github
 would need to be the mirroring strategy.  Sounds dicey :)


I don't see what would be dicey about it. The svn.webkit.org -
git.webkit.org step is the fragile one; after that it's just a simple git
push to get things over to GitHub. This sounds like a pretty good approach
to me, though of course it will cause some havoc for people who have
already been doing work using the current GitHub repository.

-Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)

2012-04-24 Thread Adam Roben
On Fri, Mar 16, 2012 at 5:40 PM, Adam Barth aba...@webkit.org wrote:

 On Fri, Mar 16, 2012 at 2:32 PM, Ryosuke Niwa rn...@webkit.org wrote:
  Can we do some Bugzilla integration as Jarred suggested?

 If you're excited about using GitHub, you should feel free to do that work.

It sounds like there is already work going on on GitHub (e.g., the
iframe seamless support) even though this integration hasn't yet
been built. I echo Ariya and Ryosuke's concern that the reduced
visibility of that work makes it harder for WebKit contributors to
provide feedback, or even to realize that the work is going on. Is
there anyone working on improving the integration between GitHub and
our current tools so that work that occurs there can be as easily
discovered as work that goes on in bugs.webkit.org?

-Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread Jarred Nicholls
On Apr 24, 2012, at 9:07 AM, Adam Roben aro...@webkit.org wrote:

 On Wed, Apr 18, 2012 at 11:06 AM, Jarred Nicholls jar...@webkit.org wrote:
 (from correct address)
 
 On Wed, Apr 18, 2012 at 11:06 AM, Jarred Nicholls jar...@sencha.com wrote:
 On Wed, Apr 18, 2012 at 11:02 AM, Simon Hausmann simon.hausm...@nokia.com 
 wrote:
 On Wednesday, April 18, 2012 06:53:46 AM ext Shezan Baig wrote:
  Hi WebKit,
 
  I've been using a fork of the following repo:
  https://github.com/WebKit/webkit
 
  However, yesterday there was discussion on #webkit that the SHA-1 checksums
  on this repo are different from repo at git.webkit.org, which means folks
  working on both need to have both versions checked out.
 
 I believe the reason for them being different is because in the github repo 
 the
 commit author fields are resolved.
 
 Yeah that's totally it.  So svn.webkit.org = git.webkit.org = github would 
 need to be the mirroring strategy.  Sounds dicey :)
 
  
 I don't see what would be dicey about it. The svn.webkit.org - 
 git.webkit.org step is the fragile one; after that it's just a simple git 
 push to get things over to GitHub. This sounds like a pretty good approach 
 to me, though of course it will cause some havoc for people who have already 
 been doing work using the current GitHub repository.

I was being facetious.  The notion of chaining repos is always fun but 
technically you're right; it's as easy as a push, and that is more or less 
immune to errors i.e. if a push failed due to some network or server issue it 
would just push again the next commit and be back on track.

 
 -Adam
 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread Tor Arne Vestbø

On 18.04.12 17:02, Simon Hausmann wrote:

On Wednesday, April 18, 2012 06:53:46 AM ext Shezan Baig wrote:

Hi WebKit,

I've been using a fork of the following repo:
https://github.com/WebKit/webkit

However, yesterday there was discussion on #webkit that the SHA-1 checksums
on this repo are different from repo at git.webkit.org, which means folks
working on both need to have both versions checked out.


I believe the reason for them being different is because in the github repo the
commit author fields are resolved.


That's correct. I'm the one running that mirror (along with the one at 
gitorious.org/webkit), and the import is done using an author-script 
that resolves author names and emails for a nicer history. The commit 
objects will be different, hence the different sha1s, but the tree and 
blob objects are the same.


In what situation does this cause issues?

I'd like to keep the github/gitorious mirror with proper author names, 
so is it perhaps an alternative to move the webkit.org mirror to use the 
same author script? (which can also be cleaned up an improved to take 
into account names from changlogs vs commit-queue, etc).


tor arne
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread Adam Roben
On Tue, Apr 24, 2012 at 9:49 AM, Tor Arne Vestbø
tor.arne.ves...@nokia.com wrote:
 On 18.04.12 17:02, Simon Hausmann wrote:

 On Wednesday, April 18, 2012 06:53:46 AM ext Shezan Baig wrote:

 Hi WebKit,

 I've been using a fork of the following repo:
 https://github.com/WebKit/webkit

 However, yesterday there was discussion on #webkit that the SHA-1
 checksums
 on this repo are different from repo at git.webkit.org, which means folks
 working on both need to have both versions checked out.


 I believe the reason for them being different is because in the github
 repo the
 commit author fields are resolved.


 That's correct. I'm the one running that mirror (along with the one at
 gitorious.org/webkit), and the import is done using an author-script that
 resolves author names and emails for a nicer history. The commit objects
 will be different, hence the different sha1s, but the tree and blob objects
 are the same.

 In what situation does this cause issues?

Probably the biggest issue is for people who've been using
git.webkit.org and now want to try out GitHub. Since the commits are
distinct between the two repositories, they have to do a full clone to
make the switch.

-Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread Tor Arne Vestbø

On 24.04.12 15:55, ext Adam Roben wrote:

Probably the biggest issue is for people who've been using
git.webkit.org and now want to try out GitHub. Since the commits are
distinct between the two repositories, they have to do a full clone to
make the switch.


Any idea why git is not smarter when pulling down the objects?

tor arne
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread Shezan Baig
On Tue, Apr 24, 2012 at 9:55 AM, Adam Roben aro...@webkit.org wrote:
 In what situation does this cause issues?

 Probably the biggest issue is for people who've been using
 git.webkit.org and now want to try out GitHub. Since the commits are
 distinct between the two repositories, they have to do a full clone to
 make the switch.


In theory though, these users should be able to just add a remote to
their existing clone.  Then it will just sync the commit objects, and
not the trees and blobs.  Not ideal, they would have two different
'masters', but still doable, and not *that* much of an overhead.
Switching between the different masters should also be fast since the
trees will be the same.

But I agree these two repos should probably merge sooner rather than
later, just to avoid confusion for new users etc :)
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread Tor Arne Vestbø

On 24.04.12 16:04, ext Shezan Baig wrote:

On Tue, Apr 24, 2012 at 9:55 AM, Adam Robenaro...@webkit.org  wrote:

In what situation does this cause issues?


Probably the biggest issue is for people who've been using
git.webkit.org and now want to try out GitHub. Since the commits are
distinct between the two repositories, they have to do a full clone to
make the switch.



In theory though, these users should be able to just add a remote to
their existing clone.  Then it will just sync the commit objects, and
not the trees and blobs.  Not ideal, they would have two different
'masters', but still doable, and not *that* much of an overhead.
Switching between the different masters should also be fast since the
trees will be the same.


Right, a fetch should ideally just pull down the commit objects, but it 
appears git does not have this optimization. If it did, I don't think 
the issue of two remote masters would be that big, since you would at 
some point likely transition to use one of the mirrors anyways. And if 
not, having multiple mirrors/remotes should be fine -- I'm using both 
the github and gitorious mirror without any issues.



But I agree these two repos should probably merge sooner rather than
later, just to avoid confusion for new users etc :)


I would support that if it means cleaning up the author-script (which 
I'm happy to do), and using that on webkit.org.


tor arne

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread Simon Hausmann
On Tuesday, April 24, 2012 03:59:47 PM Tor Arne Vestbø wrote:
 On 24.04.12 15:55, ext Adam Roben wrote:
  Probably the biggest issue is for people who've been using
  git.webkit.org and now want to try out GitHub. Since the commits are
  distinct between the two repositories, they have to do a full clone to
  make the switch.
 
 Any idea why git is not smarter when pulling down the objects?

I think it's to minimize the traffic in the git protocol. If you just compare 
git commits, you can calculate the delta relatively quickly with fewer 
roundtrips. If server and client start to negotiate on the git object level 
itself it's going to take months to figure out which objects the client has and 
which ones are missing :)

Simon
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Where to call Codeblock::dump from within webcore

2012-04-24 Thread Paul Sery

On 04/20/2012 05:55 PM, Paul Sery wrote:

On 04/20/2012 08:25 AM, Andy Wingo wrote:

On Wed 18 Apr 2012 21:28, pgserypgs...@swcp.com  writes:


I want to call CodeBlock::dump from webcore in addition to the jsc
shell. I've compiled webkit-1.6.1 with the --enable-debug option,
modified dump to print to a file, instead of stdout, and set
options.dump=true. This works from the shell, but now I need to find
where to call dump from within webkit.

If I understand you correctly, call
ByteCompiler::setDumpsGeneratedCode(true).  Note that in the latest
nightlies, this is available in regular builds.

Andy
Yes, that's what I want to do. I'm calling setDumpsGeneratedCode(true) 
from main in jsc.cpp to force the dump from the shell without using 
the -d option. However, I also want to force webkit to use this 
option without having to set it in the shell. For instance, I'm using 
the python bindings in pywebkit to use webkit and would like (I think) 
to embed setDumpsGeneratedCode(true) in the appropriate fn in 
libjavascriptcoregtk or libwebkitgtk. Or perhaps I've missed a way of 
using an API call or some other way.

___
I rummaged around and found that placing setDumpsGeneratedCode(true) in 
Interpreter::execute (Interpreter.cpp) works for me.


I'd also like to dump the javascript source code being executed. Is the 
source available in CodeBlock::dump? If so, how can I access it.


Thanks!
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread Evan Martin
On Tue, Apr 24, 2012 at 7:04 AM, Shezan Baig shezbaig...@gmail.com wrote:
 Probably the biggest issue is for people who've been using
 git.webkit.org and now want to try out GitHub. Since the commits are
 distinct between the two repositories, they have to do a full clone to
 make the switch.

 In theory though, these users should be able to just add a remote to
 their existing clone.  Then it will just sync the commit objects, and
 not the trees and blobs.  Not ideal, they would have two different
 'masters', but still doable, and not *that* much of an overhead.
 Switching between the different masters should also be fast since the
 trees will be the same.

 But I agree these two repos should probably merge sooner rather than
 later, just to avoid confusion for new users etc :)

People who have existing branches can use git grafts to manually merge
the same commit in the old and new branches.  Then tools like git
merge of the master of the new branch will do the right thing
implicitly.

(http://evan-tech.livejournal.com/255341.html is an old post about
doing a similar sort of thing)
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread James Robinson
On Tue, Apr 24, 2012 at 7:15 AM, Tor Arne Vestbø
tor.arne.ves...@nokia.comwrote:

 On 24.04.12 16:04, ext Shezan Baig wrote:

 On Tue, Apr 24, 2012 at 9:55 AM, Adam Robenaro...@webkit.org  wrote:

 In what situation does this cause issues?


 Probably the biggest issue is for people who've been using
 git.webkit.org and now want to try out GitHub. Since the commits are
 distinct between the two repositories, they have to do a full clone to
 make the switch.



 In theory though, these users should be able to just add a remote to
 their existing clone.  Then it will just sync the commit objects, and
 not the trees and blobs.  Not ideal, they would have two different
 'masters', but still doable, and not *that* much of an overhead.
 Switching between the different masters should also be fast since the
 trees will be the same.


 Right, a fetch should ideally just pull down the commit objects, but it
 appears git does not have this optimization. If it did, I don't think the
 issue of two remote masters would be that big, since you would at some
 point likely transition to use one of the mirrors anyways. And if not,
 having multiple mirrors/remotes should be fine -- I'm using both the github
 and gitorious mirror without any issues.


  But I agree these two repos should probably merge sooner rather than
 later, just to avoid confusion for new users etc :)


 I would support that if it means cleaning up the author-script (which I'm
 happy to do), and using that on webkit.org.


Whatever we decide to do in the future, author rewriting seems like
extremely low value compared to having matching SHA1s.  I think we should
get a clone on github.com that matches the existing git.webkit.org SHA1s
and then make sure that they stay in sync (either with rewriting or not,
but whatever webkit.org does).

- James



 tor arne


 __**_
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/**mailman/listinfo.cgi/webkit-**devhttp://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Double-Resolution (Retina) Images - Re: -webkit-image-set

2012-04-24 Thread Edward O'Connor
Eric Seidel wrote:

 Assuming I'm understanding Kalle correctly, it seems this could
 already be accomplished with @media resolution?

 http://www.w3.org/TR/css3-mediaqueries/#resolution

 @media screen and (min-resolution: 264dpi) { … }

 Which according to:
 http://en.wikipedia.org/wiki/List_of_displays_by_pixel_density

 Would match both the new iPad and the iPhone 4.

As far as the resolution media query is concerned, the resolution of the
new iPad and the iPhone 4 (and anything else with a device-pixel-ratio
of 2) is exactly 192dpi.

This is because the CSS 'dpi' unit is defined to mean dots device pixels
per *CSS inch*, and CSS inches are hardcoded to be 96 CSS pixels.

This means that—without real physical units—the resolution media query
is always redundnant with device-pixel-ratio, which a) we already
implement, and b) is easier to explain to authors than explaining why
both the new iPad and the iPhone 4 are 192 dpi.


Ted
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] github mirror

2012-04-24 Thread David Barr
On Wed, Apr 25, 2012 at 12:49 AM, Simon Hausmann
simon.hausm...@nokia.com wrote:
 On Tuesday, April 24, 2012 03:59:47 PM Tor Arne Vestbø wrote:
 On 24.04.12 15:55, ext Adam Roben wrote:
  Probably the biggest issue is for people who've been using
  git.webkit.org and now want to try out GitHub. Since the commits are
  distinct between the two repositories, they have to do a full clone to
  make the switch.

 Any idea why git is not smarter when pulling down the objects?

 I think it's to minimize the traffic in the git protocol. If you just compare
 git commits, you can calculate the delta relatively quickly with fewer
 roundtrips. If server and client start to negotiate on the git object level
 itself it's going to take months to figure out which objects the client has 
 and
 which ones are missing :)

A relevant fact is that you may avoid clients having to re-fetch all
trees and blobs if the mirror hosts both histories on different heads,
eg. refs/heads/master and refs/heads/github.

--
David Barr
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev