Re: [webkit-dev] Proposed feature: Network Service Discovery
Hi Anders, The JS object extension hooks you are mentioning looks interesting. Do you know where I can get some more information about it? IHMO, this feature is not yet mature and stable enough to be added into WebKit right now. I hope it gets improved further so that the functionality can be actually brought into WebKit in the future. As a side information, there is a thread on the Blink mailing list on that particular topic: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/network$20service$20discovery/blink-dev/HT0KZKuTLxM/S3w-SdvjZfUJ Regards, Youenn 2013/9/6 Anders Carlsson ander...@apple.com I agree. This also seems like it’s something that could be implemented by a client application using our JS object extension hooks without touching WebKit at all. - Anders On Sep 6, 2013, at 10:30 AM, Simon Fraser simon.fra...@apple.com wrote: Perhaps before we spend any more time discussing the security implications of Network Service Discovery, we should decide whether it fits with the goals of the WebKit project: https://www.webkit.org/projects/goals.html It’s not at all clear to me that it does. Simon On Sep 6, 2013, at 9:59 AM, Oliver Hunt oli...@apple.com wrote: On Sep 6, 2013, at 9:44 AM, youenn fablet youe...@gmail.com wrote: Hi Ryosuke, The two points you are mentioning make sense to me. ** For starters, most of users wouldn't even know what a local network is; let alone what discovering media sources, etc... mean. Most users may not be able to understand what means “discover local network DACP servers”. But if a user is requested to grant/deny access to “Bob music library” service (the service being a DACP server), the situation seems getting better. The spec is a work in progress and may be improved. For the sake of argument let's say this discovery is allowed to occur. How do you talk to Bob music library without the web page sending raw data to/from the DACP server? --Oliver ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?
Hi, On 09/06/2013 10:12 PM, Ryosuke Niwa wrote: Thanks for the analysis! Perhaps we should merge two build flags and turn on the saturated arithmetic whenever subpixel is enabled. I think that would be the ideal solution, since it has been probed enabling SUPIXEL_LAYOUT only implies actual potential problems. I posted a patch to 118595 (the bug which spot this issue) to reduce the max-height value a bit without altering the purpose of the test. This issue could be tracked in the bug I filled specifically for this, 119273; I could implement a patch here to merge both flags, since it would solve the bug. However, I think some feedback from the maintainers of the affected ports would be really appreciated. For the case of the gtk+ port, I'm currently investigating 120583, but I think it won't be a problem. I'll try to gather feedback form the ports maintainers, tough. -- Javi ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Unable to create webview object through npapi pluins
Hey, This question is not appropriate for this list, since it looks like you're using webkitgtk, please use the webkit-gtk mailing list (on this same server). Cheers, Em Seg, 2013-09-09 às 11:04 +0530, prasadam kumar escreveu: Hi, I am trying to create web view object through npapi plugin. I am using webkit2 in this plugin will run as a separate process. When i am trying to run my plugin in my ubuntu pc i am getting below error message. When i call webkit_web_view_new() api getting below error (Plugin-container:2037): GLib-GObject-Warning **specified instance size for type 'WebKitWebView' is smaller than the parent type's 'GtkContainer' instance size (Plugin-container:2037): GLib-GObject-Critical **g_type_add_interface_static: assertion 'G_TYPE_IS_INSTANTIATABLE (instance_type)' is failed (Plugin-container:2037): GLib-CRITAL **g_once_init_level: assertion 'result != 0' failed. Please help me why i am getting above error message. Regards Prasadam ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- Gustavo Noronha Silva g...@gnome.org GNOME Project ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable CSS_FILTERS and FILTERS on more bots
Pretty late to the party, but: Em Seg, 2013-08-19 às 14:08 -0700, Dirk Schulze escreveu: When I worked on CSS filters, I start realizing after reading the build errors that most bots (all but Mac bots?) have either CSS_FILTERS, FILTERS or both flags disabled. It would be extremely useful to have more than just one platform building with filters enabled. Could we make this possible on Gtk or Qt bot? The reason we don't enable CSS_FILTERS on the bots, AFAIK, is we haven't been able to make 3D work reliably and in a reproducible way on the bots (which run on VMs using Xvfb). We work towards this goal as time allows, and with webkit2 becoming our main target it has become more important. As soon as we get that (or real hardware bot) we sure should enable css filters. Cheers, -- Gustavo Noronha Silva g...@gnome.org GNOME Project ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] No coverage of pixel tests
I'd love to see pixel tests being re-enabled on Mac port. However, we're currently experiencing some color profiling issues with reftests so we'll probably need to resolve that before we can re-enable pixel tests. - R. Niwa On Mon, Sep 9, 2013 at 2:41 PM, Robert Hogan robho...@gmail.com wrote: Hi there, Since Blink forked none of the build bots are running pixel tests. This means that we are not catching painting regressions where the rendertree text dump is unaffected by the regression. Given that in the vast majority of cases a rebaseline to the pixel result also entails a rebaseline to the rendertree result and vice versa the additional overhead of enabling pixel tests and keeping them up to date is not the 'current effort x 2'. In most cases the rebaselining needs to be done anyway, the rebaseliner just needs to update the png result while they're at it. So are we likely to see this situation change in the near future? If not, reviewers and patch authors take note I guess! Thanks, Robert ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] No coverage of pixel tests
Hi there, Since Blink forked none of the build bots are running pixel tests. This means that we are not catching painting regressions where the rendertree text dump is unaffected by the regression. Given that in the vast majority of cases a rebaseline to the pixel result also entails a rebaseline to the rendertree result and vice versa the additional overhead of enabling pixel tests and keeping them up to date is not the 'current effort x 2'. In most cases the rebaselining needs to be done anyway, the rebaseliner just needs to update the png result while they're at it. So are we likely to see this situation change in the near future? If not, reviewers and patch authors take note I guess! Thanks, Robert ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable CSS_FILTERS and FILTERS on more bots
On Sep 9, 2013, at 4:44 PM, Gustavo Noronha Silva g...@gnome.org wrote: Pretty late to the party, but: Em Seg, 2013-08-19 às 14:08 -0700, Dirk Schulze escreveu: When I worked on CSS filters, I start realizing after reading the build errors that most bots (all but Mac bots?) have either CSS_FILTERS, FILTERS or both flags disabled. It would be extremely useful to have more than just one platform building with filters enabled. Could we make this possible on Gtk or Qt bot? The reason we don't enable CSS_FILTERS on the bots, AFAIK, is we haven't been able to make 3D work reliably and in a reproducible way on the bots (which run on VMs using Xvfb). We work towards this goal as time allows, and with webkit2 becoming our main target it has become more important. As soon as we get that (or real hardware bot) we sure should enable css filters. Thank you for the update! Greetings, Dirk Cheers, -- Gustavo Noronha Silva g...@gnome.org GNOME Project ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
