Re: [webkit-dev] Windows Bots Are Green!
Over the past few weeks I’ve spent a considerable amount of time reviewing and correcting a number of problems with the Windows testing infrastructure. We were skipping thousands of tests, including Accessibility, http tests, and large sections of forms, css, and svg tests. Some tests were skipped because features were supposedly incomplete, but in the years since the skip entry was added to the file, the work had been completed and feature worked perfectly well. Some tests were skipped simply because feature flags had never been enabled on Windows. Happily, all of this is in the past. Now that this work is complete, we have much more test coverage of many areas of WebKit that had been previously ignored on this platform. Nice work! -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] WEBCORE_EXPORT
Last week I switched the iOS and Mac builds to use WEBCORE_EXPORT instead of WebCore.exp.in. This should make maintenance easier, but there are a few quirks everybody should be aware of: 1) Do not use WEBCORE_EXPORT before a function defined in a header. This will cause check-for-weak-vtables-and-externals to fail sometimes. See http://trac.webkit.org/changeset/179974/trunk/Source/WebCore/dom/Range.h http://trac.webkit.org/changeset/179974/trunk/Source/WebCore/dom/Range.h for an example fix. 2) If you need to export the vtable of a class, put WEBCORE_EXPORT between “class and the class name, but not before method and member variable declarations. Otherwise Visual Studio will not compile successfully after we get rid of WebKitExports.def.in. See http://trac.webkit.org/changeset/180301/trunk/Source/WebCore/bridge/runtime_method.h http://trac.webkit.org/changeset/180301/trunk/Source/WebCore/bridge/runtime_method.h for an example fix. Alex___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] WEBCORE_EXPORT
On Mon, Feb 23, 2015 at 4:48 PM, Alex Christensen achristen...@apple.com wrote: Does it matter the function is defined in a header file or that it's an inline? If a function is always inlined that would also cause a problem if the linker tried to export a symbol from an object file, but most of those are defined in headers. Okay. I think we should be precise here. The fact inline functions being marked as exported causes a problem makes sense to me because they may not create any exportable symbols in object files while whether a function being defined in a header file or not affecting the behavior of compilers/linkers would puzzle me because they're all combined into a single translation unit. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] WEBCORE_EXPORT
On Mon, Feb 23, 2015 at 2:43 PM, Alex Christensen achristen...@apple.com wrote: Last week I switched the iOS and Mac builds to use WEBCORE_EXPORT instead of WebCore.exp.in. This should make maintenance easier, but there are a few quirks everybody should be aware of: 1) Do not use WEBCORE_EXPORT before a function defined in a header. This will cause check-for-weak-vtables-and-externals to fail sometimes. See http://trac.webkit.org/changeset/179974/trunk/Source/WebCore/dom/Range.h for an example fix. Does it matter the function is defined in a header file or that it's an inline? - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] WEBCORE_EXPORT
Does it matter the function is defined in a header file or that it's an inline? If a function is always inlined that would also cause a problem if the linker tried to export a symbol from an object file, but most of those are defined in headers. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] WEBCORE_EXPORT
Hooray! Lets document these somewhere so people don’t have to read the webkit-dev archives to learn these rules. Maybe in the header that defines WEBCORE_EXPORT? Maybe in a webpage somewhere on webkit.org? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] WEBCORE_EXPORT
They also seem like prime candidates for stylebot rules. On Feb 23, 2015, at 3:31 PM, Darin Adler da...@apple.com wrote: Hooray! Lets document these somewhere so people don’t have to read the webkit-dev archives to learn these rules. Maybe in the header that defines WEBCORE_EXPORT? Maybe in a webpage somewhere on webkit.org? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
