Re: [webkit-dev] Enable MICRODATA feature by default
I have filed a bug to address W3C failed test-cases :
https://bugs.webkit.org/show_bug.cgi?id=92986
This issue will track all investigation related to Microdata test failures
and make sure that we pass as many test as possible.
Regards,
Arko
On Wed, Aug 1, 2012 at 12:16 AM, Ian Hickson i...@hixie.ch wrote:
On Tue, 31 Jul 2012, Arko Saha wrote:
test(function () {
assert_equals( makeEl('div',{itemtype:' '}).itemType[0],
window.undefined );
}, 'itemType[index] must be undefined for out-of-range index');
DOMSettableTokenList returns null for out-of-range index.
This is incorrect. While it is true that item() returns null when
called with an out-of-range index, item() is never invoked in the example
above. See Web IDL for details.
I highly doubt that the other 80+ failing tests are implementation-
specific either. If any of them _are_, then before ignoring them, you
should ask for them to be corrected in the test suite.
--
Ian Hickson U+1047E)\._.,--,'``.fL
http://ln.hixie.ch/ U+263A/, _.. \ _\ ;`._ ,.
Things that are impossible just take longer. `._.-(,_..'--(,_..'`-.;.'
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Enable MICRODATA feature by default
I am planning to enable MICRODATA feature by default in WebKit. Microdata master bug: https://bugs.webkit.org/show_bug.cgi?id=68609 Microdata spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html Currently we have support for Microdata DOM API's to interacting with microdata using microdata attributes like itemscope, itemtype, itemprop, itemref, itemid through JavaScript. Also we have added support for HTMLPropertiesCollection, PropertyNodeList interfaces to intract with microdata item-properties. As of now, WebKit EFL and Blackberry port has already enabled MICRODATA by default. Mozilla and Opera has also enabled the support for Microdata DOM API. Please let me know your thoughts on the same. Thanks and Regards, Arko ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable MICRODATA feature by default
I have tested the test : http://w3c-test.org/html/tests/submission/Opera/microdata/001.html 255 Pass 82 Fail Most of the failed cases are specific to their implementation and for others, I need to check. Regards, Arko On Tue, Jul 31, 2012 at 12:07 PM, Ryosuke Niwa rn...@webkit.org wrote: Do we pass tests W3C submitted by Opera Mozilla? - Ryosuke On Mon, Jul 30, 2012 at 11:35 PM, Arko Saha ngh...@motorola.com wrote: I am planning to enable MICRODATA feature by default in WebKit. Microdata master bug: https://bugs.webkit.org/show_bug.cgi?id=68609 Microdata spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html Currently we have support for Microdata DOM API's to interacting with microdata using microdata attributes like itemscope, itemtype, itemprop, itemref, itemid through JavaScript. Also we have added support for HTMLPropertiesCollection, PropertyNodeList interfaces to intract with microdata item-properties. As of now, WebKit EFL and Blackberry port has already enabled MICRODATA by default. Mozilla and Opera has also enabled the support for Microdata DOM API. Please let me know your thoughts on the same. Thanks and Regards, Arko ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable MICRODATA feature by default
For an example :
test(function () {
assert_equals( makeEl('div',{itemtype:' '}).itemType[0],
window.undefined );
}, 'itemType[index] must be undefined for out-of-range index');
makeEl method creates an element div with empty itemtype(0 tokens). Test
expects itemTpye[0] should return undefined, in our case it returns null.
According to the spec itemtpye attribute is a space-separated list.
http://www.whatwg.org/specs/web-apps/current-work/#attr-itemtype
We have defined itemtype attribute as :
readonly attribute [Conditional=MICRODATA] DOMSettableTokenList itemType;
DOMSettableTokenList returns null for out-of-range index.
So I thought it is specific to DOMSettableTokenList implementation. Or is
this the bug in our DOMSettableTokenList implementation? There are many
tests failing because of this.
Do you think, we should first resolve all these test issues and then think
of enabling feature by default? In that case I will raise a new bug and we
can then discuss the failed tests there.
Regards,
Arko
On Tue, Jul 31, 2012 at 12:51 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Mon, Jul 30, 2012 at 11:51 PM, Arko Saha ngh...@motorola.com wrote:
I have tested the test :
http://w3c-test.org/html/tests/submission/Opera/microdata/001.html
255 Pass
82 Fail
Most of the failed cases are specific to their implementation and for
others, I need to check.
What do you mean by specific to their implementation? I would expect any
test submitted to the W3C test suite to be cross browser. Tests shouldn't
include vendor prefixes for example.
- Ryosuke
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Microdata document.getItems()
I tried to run the mentioned test cases in my local machine, its working fine. I have tested the same in latest Webkit revision (Chromium/GTK port). Not sure what could be the issue. Can you please attach the test failure diff here? Thanks and regards, Arko On Thu, Mar 8, 2012 at 1:29 PM, Gurpreet Kaur gur.t...@gmail.com wrote: Dear Ryosuke, Thanks for the update. Dear Arko, Could you please help me with this? Thanks and Regards, Gurpreet On Thu, Mar 8, 2012 at 1:27 PM, Ryosuke Niwa rn...@webkit.org wrote: Your best bet is to talk with Arko :) - Ryosuke On Wed, Mar 7, 2012 at 11:26 PM, Gurpreet Kaur gur.t...@gmail.comwrote: Dear Webkit Team, I am working on Microdata for Android browser. After taking all the changes related to Microdata the following test case is failing for me. http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/MicroData/002.html This test case has call to document.getItems() (with no arguments). The call with arguments is working fine. Please update incase anyone have enabled the Microdata and tested these layout test cases. Thanks and Regards, Gurpreet ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Microdata document.getItems()
Hi Gurpreet, Yes, document.getItems() takes an optional string types as the argument. It should return all microdata items in the document if the types argument is missing. I could see its working as expected in todays revision. Are you using latest Webkit revision?? If you are just merging microdata patches on some old webkit revision then I cannot help. In older revisions please check the implementation of a existing method which allows optional argument. Thanks and Regards, Arko On Thu, Mar 8, 2012 at 1:49 PM, Gurpreet Kaur gur.t...@gmail.com wrote: Hi Arko, On running the test case http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/MicroData/002.html I get the result as below. This test ensures that document.getItems().length must return the correct number of MicroData Items in the Document. Also it tests that document.getItems must return a live NodeList. *FAIL - expected 4 elements but got 0 elements.* document.getItems() with empty string in the aurgument : PASS document.getItems() with 'http://example.com/foo' itemtype in the aurgument : PASS document.getItems() with 'http://example.com/bar' itemtype in the aurgument : PASS document.getItems() with 'http://example.com/f1' itemtype in the aurgument : PASS Created element of type : div Set attribute: itemscope, value: itemscope *FAIL - expected 5 elements but got 0 elements.* *FAIL - expected 4 elements but got 0 elements.* document.getItems() should return all items and document.getItems(arg) should return items which match the arg. Please correct me if I am wrong. Thanks and Regards, Gurpreet On Thu, Mar 8, 2012 at 1:36 PM, Arko Saha ngh...@motorola.com wrote: I tried to run the mentioned test cases in my local machine, its working fine. I have tested the same in latest Webkit revision (Chromium/GTK port). Not sure what could be the issue. Can you please attach the test failure diff here? Thanks and regards, Arko On Thu, Mar 8, 2012 at 1:29 PM, Gurpreet Kaur gur.t...@gmail.com wrote: Dear Ryosuke, Thanks for the update. Dear Arko, Could you please help me with this? Thanks and Regards, Gurpreet On Thu, Mar 8, 2012 at 1:27 PM, Ryosuke Niwa rn...@webkit.org wrote: Your best bet is to talk with Arko :) - Ryosuke On Wed, Mar 7, 2012 at 11:26 PM, Gurpreet Kaur gur.t...@gmail.comwrote: Dear Webkit Team, I am working on Microdata for Android browser. After taking all the changes related to Microdata the following test case is failing for me. http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/MicroData/002.html This test case has call to document.getItems() (with no arguments). The call with arguments is working fine. Please update incase anyone have enabled the Microdata and tested these layout test cases. Thanks and Regards, Gurpreet ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] New feature announcement - Implement HTML5 Microdata in WebKit
Hi All, Thanks for your valuable inputs regarding Microdata implementation. I have uploaded the patch for basic implementation of document.getItems() DOM API. Bug id: https://bugs.webkit.org/show_bug.cgi?id=68610 Could someone please review the patch, and let me know the review comments. Thanks and regards, Arko Saha On Fri, Sep 23, 2011 at 3:12 AM, James Robinson jam...@google.com wrote: On Thu, Sep 22, 2011 at 2:32 PM, Charles Pritchard ch...@jumis.comwrote: On 9/22/2011 2:13 PM, Ian Hickson wrote: On Fri, 23 Sep 2011, Dean Jackson wrote: However, isn't prefixing designed to avoid incompatibilities in spec changes, not incompatibilities between implementations? Ensuring no conflicts in implementations doesn't matter too much if the spec changes. It's designed to ensure that authors can reliably use a name and expect to get the same result in any UA that supports that name. I'm not going to change the spec in a way that conflicts with that -- if the spec has to change, it'll change either in a compatible way (e.g. to match what was actually implemented), or in a way that doesn't conflict (e.g. by changing the name in the spec). Note I'm not talking about Microdata in particular. I don't even know what that spec is :) I'm just talking about the general approach. If the world can guarantee that this spec will never change, then I guess your technique works. FWIW, there is an in-between approach, which is the one used by WebGL. It defines a prefix that all implementations share. canvas.getContext(**experimental-webgl); That'll just result in that name becoming the standard. I would like some kind of fast track method for these kind of issues. Something like a Request for dropping prefix RfDP protocol would be super. Please post this feedback to some thread where it's relevant, not on a WebKit development mailing list discussion about a specific feature. - James RfDP: Microdata. First the spec editor would have to vouch for it, then, if Moz, MS, Opera, Apple and Google reps can give a nod within a few weeks, we've got something. I'd really like to avoid repeats of the CSS -vnd-transform baggage, when possible. WebKit went back and forth on BlobBuilder. Now it's at: WebKitBlobBuilder. That was not so fun. That's another situation I'd like to avoid. For this particular method, the microdata section, I'm happy enough hearing that the spec editor will vouch for it. If that's the precedent, I'll take it. I'd like to learn how we can build on that precedent. Reps from the major vendors have been quite responsive this year. I know they can't commit to supporting an API in a short time frame (such as the File API), but they have been great about voicing issues. -Charles __**_ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/**mailman/listinfo.cgi/webkit-**devhttp://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] New feature announcement - Implement HTML5 Microdata in WebKit
Hi, I have been looking at HTML5 Microdata implementation in Webkit. Microdata is a specification used to nest semantics within existing content on web pages. Search engines, web crawlers, and browsers can extract and process Microdata from a web page and use it to provide a richer browsing experience for users. Microdata helps technologies such as search engines and web crawlers better understand what information is contained in a web page, providing better search results. Here is the spec : http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#microdata I have logged a bug for this and also attached a basic implementation patch for the same. Master bug: https://bugs.webkit.org/show_bug.cgi?id=68609 Please let me know your suggestions/views regarding this. Thanks in advance. Arko Saha ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
