Re: [webkit-dev] SH4, MIPS, and legacy-ARM assemblers in JavaScriptCore

2012-08-30 Thread Holger Freyther
On 08/30/2012 12:10 AM, Gergely Kis wrote:

 
 Would this be acceptable for you?

sure, an actively and publicly maintained MIPS build would be great. We have
some documentation on how to setup a build slave in the wiki[1] and the slave
configuration files are maintained in SVN[2]. The configuration file changes
follow the normal WebKit contribution procedure.

holger


[1] http://trac.webkit.org/wiki/BuildBot
[2]
http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Fwd: mipsel-uclibc-linux

2011-07-01 Thread Holger Freyther
On 07/01/2011 11:10 AM, kanhaiya yadav wrote:
 
 Hi All,
 
 I am porting webkit on MIPS for different devices, when I an using MIPS-LINUX
 it is working fine.
 
 But when I am using MIPSEL-UCLIBC-LINUX tool chain I am getting crash on
 signal 11 (SIG_SEGV) and launcher stopped at

please use the webkit-help or the webkit-gtk mailinglist, this one is for the
development of webkit.

holger
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-15 Thread Holger Freyther
On 06/15/2011 10:21 AM, 권기홍 wrote:
 Hi webkit-dev! 
 
  
 
 I wanted to let you know that I plan to add battery status event support to
 WebCore.
 
 The Battery Status Event is a new feature that is defined by W3C
 (http://www.w3.org/TR/battery-status http://www.w3.org/TR/battery-status/)

I am not participating in any W3C group so this might or might have been
discussed but this specification seems to be over simplified, specially if you
compare it what is provided by the power supply class of the Linux kernel[1].

What happens if you have more than one battery? Many modern devices have
backup batteries, e.g. to keep the RTC. What is the upgrade path for this
event to support applications that want to have a more detailed view (e.g. a
dashboard in a server farm that also wants to query the UPS)?

sorry for my two cents
holger


[1]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/power/power_supply_class.txt;h=9f16c5178b662b8f9ec67f3dd7eafd6f4c89e39a;hb=HEAD
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-15 Thread Holger Freyther
On 06/15/2011 06:11 PM, laszlo.1.gom...@nokia.com wrote:
 Hi,
 

 
 The use-case for us is to enable content developers to implement rudimentary 
 power management (e.g. to stop expensive operations on the page, perhaps 
 save state). I'm not sure if this API is really meant for accurately 
 reporting all the possible power management states of the system as Anssi 
 pointed out.

Okay, point on complexity taken. My question is what if you want to add
complexity, is there something in the event that prevents that (I have no idea
about DOM compatibility issues)? Don't get me wrong I think having more device
support is great.

My other complain was, it is too simple. E.g. 'isPlugged' has no guarantee
that the battery is getting charged. Is this a problem?
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-15 Thread Holger Freyther
On 06/15/2011 06:58 PM, Brett Wilson wrote:

 Why would a web page care about whether the battery is being charged
 when the device is plugged in?

Hi,

aeh, first of all my mind is playing tricks and I could swear that its
battery is being charged was not in the isPlugged description so my comment
is void.

To answer your question (and leaving aside I am wrong about the isPlugged), in
the example[1] one uses isPlugged + charge level to change the polling
interval. My point was that just because I have a charger attached, doesn't
mean that the device is not emptying the battery (be it I do not have enough
current on the USB outlet, a USB hub...).



[1] http://dev.w3.org/2009/dap/system-info/battery-status.html#examples


PS: If the device is current plugged in is needs probably a ly for the 
current.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Progressing on the Android port

2011-05-13 Thread Holger Freyther
On 05/12/2011 05:16 PM, Lucas De Marchi wrote:
 Hi Holger Freyther,
 

 I'm glad to hear you will use CMake as the build system. Take a look
 on the email I sent yesterday porting GTK to CMake, maybe it will help
 you.  Since Android and Chromium/Linux have overlaps, do you think
 it'd be easy to build the Chromium port as well?

I am not sure about Chromium. When one tries to build Chromium a lot of
external code will be downloaded, I don't have the things in my tree right now
but IIRC these external modules are all having Gyp files so one would need to
convert these dependencies and it will be quite some work.

I am having one specific issue with CMake right now, do you think it would be
possible to have defaults for WEBKIT_FEATURE(ENABLE_AS_IMAGE Enable SVG as
image DEFAULT ON SVG)? E.g. I need to define ENABLE_GLIB as otherwise I end
up having a '#define ENABLE_GLIB' in the cmakeconfig.h breaking the build.

regards
holger
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Progressing on the Android port

2011-05-13 Thread Holger Freyther
On 05/13/2011 10:48 PM, Lucas De Marchi wrote:


 This is exactly the reason why I committed r86370 when doing the GTK
 port. Now you can do as I did for GTK:
 
 WEBKIT_FEATURE(ENABLE_GLIB_SUPPORT Enable Glib support ALWAYS ON)
 
 or ALWAYS OFF if you meant to unconditionally disable it.

Is it a worthy goal to get the OptionsPort.txt file smaller (e.g. by having
the default defaults)?
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Progressing on the Android port

2011-05-12 Thread Holger Freyther
Hi WebKit-dev folks,

in the spirit of the mails describing new features I would like to talk about
my intention regarding the Android port.

== Aim ==
I want to build WebKit trunk for Android and use it on a phone. This means I
want to have build-webkit integration, will host a buildbot, will work towards
having LayoutTests for Android.

== Requirements ==
I am going to use the Native Development Kit (NDK), there is also the
requirement of having Skia and one of the two networking libraries. At this
point I am not sure if I want to go the Chromium way and pull the code into
the repository with a script or require these libraries to be built. I have a
preference for the later right now.

== How ==
I want to use CMake as the buildsystem. The main reason is that it is already
used by other ports and the CMake community provides an easy way to use the
Android NDK.

My aim is to use the existing SKIA (as used by Chromium/Linux) as there seems
to be a great overlap between Android and Chromium/Linux, I will also try to
merge existing Android files for other parts of the system.


== Conflict(s) ==
This port is not supported by Google/Android, this might or might not cause
problems. It all depends on how compatible my aim is with the plans of the
Android Unit.

Another issue might come from the fact that I want to build it with the
Android NDK, instead of having WebKit built as part of the Android system. I
hope Google will be able to use CMake to generate a Android.mk.

== When ==
I will try to spend one day a week on it. So it might take a while.

cheers
holger
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] WebKit blog post proposal: Remote debugging with Web Inspector.

2011-04-30 Thread Holger Freyther
On 04/30/2011 10:55 AM, Pavel Feldman wrote:
 An update.

Did you consider applying for a port number at IANA? Besides that really nice
work and a nice article.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Plans to fully merge the Android port

2011-04-28 Thread Holger Freyther
On 04/27/2011 11:53 AM, Steve Block wrote:
 Is there any plan to fully merge the code, have updated LayoutTests and
 build-webkit integration?
 The Android browser still uses the Android port, but as you point out,
 it's not fully upstreamed. We're continuing to work on this.


 Since then, WebCore/Android.mk has been modified 81 times, but only

 It's true that our progress has been rather slow of late. If the
 Android makefiles are considered too much of a burden on the
 community, I'm happy to remove them from the tree until the Android
 port is fully upstreamed.

From my point of view the question is if and when Android will upstream the
code, provide build-webkit --android, aim to have support for LayoutTests,
provide a buildbot and generally maintain it.

Right now there does not seem to be a clear story for the Android port and I
wonder if it would not be better for the WebKit project to remove the port and
handle it like the other ports being out of tree (e.g. Samsung's bada port).
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Plans to fully merge the Android port

2011-04-21 Thread Holger Freyther
Hi all,

I started to look into the state of the Android port/platform and the state in
WebKit. It appears to me that the Android team at Google has decided to use
the chromium tree as upstream (it might have changed with Android 3.0), it
appears to me that there are still things not merged to the WebKit tree, that
the LayoutTests were not updated in eight month, that the git repository
published by the Android team does not even include the LayoutTests.

Is there any plan to fully merge the code, have updated LayoutTests and
build-webkit integration?

regards
holger

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Query regarding handling of NPObjects in webkit

2011-03-03 Thread Holger Freyther
On 03/03/2011 09:25 AM, Chandan Apsangi wrote:
 Hi,
  
 I'm working on an issue related to NPAPI plugin on QT port of webkit on
 Symbian platform.


Hi,
I would assume this issue is not specific to Qt and Symbian so you could try
to debug it on a desktop build. In general we encourage you to create a bug
report and then create a LayoutTestCase. For plugin testing we do have an
example/test plugin[1], you could add a routine to the PluginObject.cpp and
call this routine from your LayoutTestCase.

holger

[1] http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/TestNetscapePlugIn
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] XPath Issues?

2010-11-10 Thread Holger Freyther
On 11/09/2010 09:00 PM, Eric Seidel wrote:
 This conversation is heading in a dangerous direction... :)
 
 Allowing QXML parser support to be added to WebKit was probably a
 mistake.  Adding custom QXPath or QXSLT support would be another.

I agree with the first statement but disagree with the second. One of the
strengths of WebKit is the integration into the base technology (or whatever
you want to pick), we don't have to find the least common denominator to make
everyone happy.

On the other hand it is a pity that Nokia is so behind in many ways, they
should have had the engineering force to assist you and Adam to fix the XML
support with your new parser work. They should have the resources to go
through the LayoutTests and make QtWebKit pass more...

sorry for sidetracking the discussion a bit.

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] WebKitGtk app memory leaks , please help

2010-11-03 Thread Holger Freyther
On 11/03/2010 03:52 PM, Fedor Kryukov wrote:
 
 After calling webkit_web_view_get_dom_document() and similar functions (
 webkit_dom... * ) memory is not freed, what am I doing wrong?


Can you provide us with a simple test application, open a bug, attach the test
case to that?

thanks
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Regarding cache memory leaks

2010-10-17 Thread Holger Freyther
On 10/13/2010 05:30 PM, sumanrap...@aim.com wrote:
  Hi Holger,
 
 When we use the default cache model i.e 8MB cache size in this case it is
 storing the images beyond the 8MB that is untill complete RAM memory. So we
 disabled the cache by using WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER  even though
 the images and JS are storing in the Cache. We observed this by printing
 dumpStats output.

Could you please create a test case and tell me how you determined that it is
leaking memory vs. going over the limit of the cache? The cache will go over
the limit for an active page. I once created a bug[1] to more aggressively
free resources.


[1] https://bugs.webkit.org/show_bug.cgi?id=30210




___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Odd Build Issue on Gtk Port

2010-10-16 Thread Holger Freyther
On 10/16/2010 12:13 AM, Alex Milowski wrote:
 I kept getting GDK_DISPLAY related errors on my Ubuntu-based development
 machine.  It turns on in Gtk 2.22.0 that GDK_DISPLAY just isn't defined
 (at least via Ubuntu 10.10).

In debug build we build with the various *_DISABLE_DEPRECATED flags. Due the
GNOME 3.0/GTK 3.0 thing, there is a lot more deprecation going on.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Regarding cache memory leaks

2010-10-10 Thread Holger Freyther
On 10/10/2010 06:37 PM, sumanrap...@aim.com wrote:
 Dear All,

 When I am printing the dumpStats I could able to see the Image count and live
  decoded image sizes. Even I disabled the cache it is storing on to cache.
 could you please suggest me is there any patch to avoid image related memory
 leaks with webkitGtk. Please help me on this.

How do you know it is leaked? If you are currently viewing these images you
will most likely have the encoded and decoded version around. Do you have a
test case to show the memory leak?
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] PSA: Don't try to hold onto temporaries with references

2010-10-03 Thread Holger Freyther
On 10/04/2010 01:31 AM, Darin Adler wrote:

 
 What you say here about object lifetime is not correct. I thought the same 
 thing a year or so back. But the C++ language keeps these objects alive until 
 the end of the block. Some other programmers on the project challenged me 
 when I made this assertion, and we found that I was wrong and they were right.

ah, I was not aware that it is until the end of the block, I thought it is
more local.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Use of Frame by ResourceHandle

2010-09-11 Thread Holger Freyther
On 09/11/2010 05:57 PM, Adam Barth wrote:


 Do we still believe this FIXME is accurate?  If so, I have some time
 next week to look at removing the dependency.  There's a patch that
 either recently landed or is about to land that furthers the use of
 Frame by ResourceHandle, so I wanted to check with folks more broadly
 about whether this is the right direction.  (Note that I haven't
 studied the code yet, so I'm not sure what would be required to remove
 the dependency.)

I'am afraid QtWebKit is using that for a layering violation. Each QWebPage
(wrapper around WebCore::Page + FrameView) can have a separate network engine
(QNetworkAccessManager) and we go from WebCore::Frame to WebKit to find out
which engine to use.

I wonder how/if we can migrate that to a bridge, but I am afraid we will still
need to have some access to Document/Frame/Page.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Number of pending commits

2010-09-07 Thread Holger Freyther
Hi,

I was just seeing that we have about 84 bugs which are in the pending-commit
state, on the Gtk+ bugs I clicked the patches need to be landed manually.

It would be nice to get a hand landing these patches, or asking the commit
queue to take care of them.

thanks
holger
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] WebKitTools/Script/generate-coverage-data

2010-08-29 Thread Holger Freyther
On 08/26/2010 11:56 PM, Holger Freyther wrote:

 Hi,
 the only change is to exclude the coverage option for ANGLE as libtool does
 not like these parameters. I have tested the scripts and they work, I will
 need to test the whole generate-coverage script tomorrow and will open a bug
 report...

Darin was nice enough to review and I have landed it, please try it and tell
me if you have any problems with the script.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] WebKitTools/Script/generate-coverage-data

2010-08-26 Thread Holger Freyther
On 08/24/2010 12:46 PM, Holger Freyther wrote:
 On 08/24/2010 01:38 AM, Eric Seidel wrote:
 Has anyone looked at our coverage-generating scripts in a while?
 
 Sorry, I didn't. You are trying to use them on OSX? I think I can find some
 time at the end of the week to make them work again. Can you wait that long?

Hi,
the only change is to exclude the coverage option for ANGLE as libtool does
not like these parameters. I have tested the scripts and they work, I will
need to test the whole generate-coverage script tomorrow and will open a bug
report...

http://paste.lisp.org/display/113900
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Git meeting notes

2010-04-12 Thread Holger Freyther
On Tuesday 13 April 2010 06:32:24 Alexey Proskuryakov wrote:
 I can't tell from documentation if git-bisect requires rebuilding each
 revision. This is something we don't currently have to do, given that
 there are nightlies to test with.
 
 But my question was somewhat different (Dave Kilzer told me about git
 bisect earlier today). How can I tell if a given nightly build includes
 changes made in a certain commit?

If Mark would add tags for the nightlies one could type git tag --
contains=COMMIT to figure out which tags include the version.

Regarding the monotonic number there are two things that I have used at 
different projects.

One is to use git describe which contains a mix of the commit-id, number of 
commits since the last tag. The example output from a different project would 
be on-waves/0.3.96-8-ga4ebb46. It tells me the tag name, that I've 8 commits 
more than in the tag and the commit id of the eights commit.

The other option is, when assuming to never rebase the master, we can type git 
log --pretty=oneline | wc -l and we will end up with an increasing number.






___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] parallel painting

2010-04-06 Thread Holger Freyther
On Tuesday 06 April 2010 13:42:30 Zoltan Herczeg wrote:
 Of course, I did a lot of profiling before (using oprofile), and painting
 was slow on my platform.

Can you use oparchive to make the profile available? Also when you say 
painting? Do you mean function (inclusive) spend below QWebFrame::render? or 
really the work on QPainter and the RenderTree doing the painting?

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] gdb archer and tracking live objects

2010-03-15 Thread Holger Freyther
Hi all,

one of the archer branches of gdb allows to turn gdb into a python interpreter 
and allow scripting.

My idea was to use this to track all refcounted objects in WebCore and answer 
questions like. How many objects are alive? How many objects changed from 
point a to b? What are the refcounts? Where was the ref count increased?

I have a slightly modified release build to turn RefCountedBase into a non 
inline class and only compile the RefCounted.cpp with -ggdb3 debug support to 
easily set a breakpoint there.

With the attached python script I'm able to keep track of RefCountedBase 
objects, have commands to print the python dictionary from a gdb cli. I have 
no other exploring functions in place.

I wonder if I could develop this tool inside a subdirectory 
WebKitTools/Scripts without the usual review process?




Due some limitations in the python support the workflow is currently like this:

gdb -P script GtKLauncher
(gdb) webkit-setup
... questions about pending breakpoints...
(gdb) r
CTRL+C
(gdb) webkit-objects 
WebCore has 2891 live objects of 0 kinds
0xb3e05784
0xb3d99378
0xb3e1e6ac




WebKit object tracking system. This 


import gdb
import sys


# all allocated and non freed objects
live_objects = {}

class live_object:

An object of WebCore with the RefCountedBase base class


def __init__(self, initial_backtrace, addr):
self.addr = addr
self.initial_backtrace = initial_backtrace
self.obj_type = live_object.determine_type(initial_backtrace)

@staticmethod
def determine_type(backtrace):

In general we are not building with RTTI so we can not determine
the WebCore type from the given pointer value. We will need to
look at the backtrace to determine the type of this object.

return None


def find_this_pointer(frame):
for sym in frame.block():
if not sym.is_argument:
continue
if sym.print_name == this:
return frame.read_var(sym)
return None

def hash_value(gdb_value):
return str(gdb_value)

# Functions for gdb as a replacement for callbacks
class WebKitObjectCreated(gdb.Function):

A new RefCountedBase object was created... keep track of it

def __init__(self):
super(WebKitObjectCreated, self).__init__(webkit_new_object)
def invoke(self):
ptr = find_this_pointer(gdb.selected_frame())
if ptr:
assert hash_value(ptr) not in live_objects
live_objects[hash_value(ptr)] = live_object(gdb.selected_frame, ptr)
return False

class WebKitObjectDeleted(gdb.Function):

A RefCountedBase object was destroyed, clear references to it.

def __init__(self):
super(WebKitObjectDeleted, self).__init__(webkit_delete_object)
def invoke(self):
ptr = find_this_pointer(gdb.selected_frame())
if ptr:
assert hash_value(ptr) in live_objects
del live_objects[hash_value(ptr)]

return False

class WebKitSetup(gdb.Command):

Setup breakpoints

def __init__(self):
super(WebKitSetup, self).__init__(webkit-setup,
gdb.COMMAND_SUPPORT, gdb.COMPLETE_NONE, True)

def invoke(self, arg, from_tty):
gdb.execute(break WTF::RefCountedBase::RefCountedBase() if $webkit_new_object())
gdb.execute(break WTF::RefCountedBase::~RefCountedBase() if $webkit_delete_object())

class WebKitLiveObjects(gdb.Command):

List the live objects in webkit...

def __init__(self):
super(WebKitLiveObjects, self).__init__(webkit-objects,
gdb.COMMAND_SUPPORT, gdb.COMPLETE_NONE, True)

def invoke(self, arg, from_tty):
# TODO have some param to filter for a given backtrace/type...
sys.stdout.write(WebCore has %d live objects of %d kinds\n % (len(live_objects), 0))
for live_object in live_objects.keys():
print live_object

def webkit_register():

Register commands for GDB to use.

WebKitObjectCreated()
WebKitObjectDeleted()
#WebKitObjectRef()
#WebKitObjectUnref()
WebKitSetup()
WebKitLiveObjects()

def webkit_setup():

Setup the

print sys.argv
gdb.execute(file %s % sys.argv[0])


webkit_register()
webkit_setup()

print The executable was loaded. Please invoke the webkit-setup command
gdb.cli()
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] gdb archer and tracking live objects

2010-03-15 Thread Holger Freyther
On Monday 15 March 2010 15:47:43 you wrote:
 On Mon, Mar 15, 2010 at 12:38 AM, Holger Freyther ze...@selfish.org wrote:
  I wonder if I could develop this tool inside a subdirectory
  WebKitTools/Scripts without the usual review process?
 
 See my recent mail to webkit-dev about gdb 7 -- there's now a
 WebKitTools/gdb directory.  I'm not sure what is different about your
 project that makes it so it would not benefit from code review.

There are two things. In one way I want to have version control, and if the 
script turns out to be useful it should live inside the webkit tree but 
currently on the other it is anything but mature, it is me playing around and 
see what I can do it, and which approach is going to work nicely.. so for the 
highly experimental stuff it is a bit weird to attempt to convince another 
reviewer when I'm not convinced myself.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] gdb archer and tracking live objects

2010-03-15 Thread Holger Freyther
On Monday 15 March 2010 22:11:44 Stephan Assmus wrote:

 
 It doesn't have to be about convincing, you may just get useful feedback.

Yep, that is why the code was attached to both emails. :)
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Holger Freyther
On Wednesday 10 March 2010 05:56:27 Holger Freyther wrote:
 HI All,
 
 I'm currently running the iexploder tests on GtkLauncher and I'm observing
 a growth in memory usage of that process. I have used the GNOME memprof
 utilitiy to look at it and the best candidate for the leak is
 SharedBuffer::append which will allocate memory.


Zoltan has mentioned gdb on irc and I started to wonder how far we can get 
with GDB's python support in 7.0. Maybe we could create a set of scripts to 
track lifetime using GDB? I'm going to explore this option maybe later today 
but within this week.

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Questions regarding memory debugging

2010-03-09 Thread Holger Freyther
HI All,

I'm currently running the iexploder tests on GtkLauncher and I'm observing a 
growth in memory usage of that process. I have used the GNOME memprof utilitiy 
to look at it and the best candidate for the leak is SharedBuffer::append 
which will allocate memory.

Now SharedBuffer is refcounted and can only leak if someone is holding a 
reference to it and this is where stuff gets tricky. Besides manually searching 
the tree and adding printf's all over has anyone found a better way of doing 
this?

At the OpenBSC GSM Project we are using this C library talloc. With talloc 
every allocation is happening inside a (hierachical) context and at runtime we 
can send a SIGUSR1 one to the application and the memstatistics are dumped
on the console. I have attached an example output so you guys can see it.

I wonder if such a thing would make sense in a debug build as well? I wonder
if we could change the common Class::create methods to take a context, or
at least an area (Render, Network, Platform) and if these get created in a 
special debug build we add these objects to a list for these contexts and we
can dump the information... e.g. # of allocated bytes, ref count and such? 
Does this sound crazy or too invasive?

comments?
talloc report on 'vty' (total  26810 bytes in 2351 blocks)
save_cwd   contains 37 bytes in   1 blocks (ref 0) 
0x92d18d0
vty_commandcontains  15093 bytes in 1180 blocks (ref 0) 
0x92d1898
vty_vector contains  11680 bytes in 1169 blocks (ref 0) 
0x92d1860
full talloc report on 'openbsc' (total  85562 bytes in  54 blocks)
struct ia_e1_handlecontains 60 bytes in   1 blocks (ref 0) 
0x92f74a8
telnet_connection  contains  1 bytes in   1 blocks (ref 0) 
0x92c50a0
struct gsm_network contains  84860 bytes in   5 blocks (ref 0) 
0x92c3830
struct gsm_bts contains  84604 bytes in   2 blocks (ref 
0) 0x92f7ad8
struct gsm_bts_trx contains  82092 bytes in   1 blocks 
(ref 0) 0x92f84e0
OpenBSCcontains  8 bytes in   1 blocks (ref 
0) 0x92c51f8
OpenBSCcontains  8 bytes in   1 blocks (ref 
0) 0x92c2cd0
countercontains500 bytes in  26 blocks (ref 0) 
0x92ac568
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92c6a78
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b2ae8
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b2aa0
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b2a58
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b2a10
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b29c8
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b2980
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b2938
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92c2c10
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92c2bc8
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92c2b80
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92c2b38
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92c2af0
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b3b48
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b3b00
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b3ab8
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b3a70
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92ae140
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92ae0f8
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92ae0b0
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b0250
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b0208
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92c5058
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92b0178
struct counter contains 20 bytes in   1 blocks (ref 
0) 0x92c5110
trau_upq_entry contains  0 bytes in   1 blocks (ref 0) 
0x92ac530
trau_map_entry contains  0 bytes in   1 blocks (ref 0) 
0x92ac4f8
transactioncontains  0 bytes in   1 blocks (ref 0) 

Re: [webkit-dev] parallel rendering in WebKit

2010-02-20 Thread Holger Freyther
On Friday 19 February 2010 23:36:26 Zoltan Herczeg wrote:
 Hi,
 
 as all of you probably know, smp based systems are getting widespread even
 in the embedded domain, and we hope we can speed up webkit on these
 systems. We did some profiling, and seemed the platform dependent
 rendering took 50% of the total runtime (at least on our test platforms).
 We are thinking about adding some parallel rendering support for WebKit,
 probably mostly platform dependent code, but the threading support could
 be reused by different ports.


Hi Zoltan,

two questions. I assume you have done all your profiling with QtWebKit? And you 
are measuring (looking at total cumulative) everything under the paintEvent of 
QWebView?

My initial reaction to multi threaded painting is, why don't we fix the obvious 
performance bottlenecks in Qt first? Would it be much work to verify your 
profiling results in WebKit/GTK+ or Chromium? My assumption/guess is that you 
will see quite some different numbers.

regards
holger

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] midori + webkit crash

2010-02-04 Thread Holger Freyther
On Thursday 04 February 2010 15:57:11 thouraya andolsi wrote:
 Hi,
 
 I'm using Midori with webkit1.1.19 and I have the following error  when
 running a test : GLib-GObject-CRITICAL **: g_type_set_qdata: assertion
  `node != NULL' failed

 Can any one help me?

Sadly I think one can not. Besides using the wrong mailing list or the right 
tool (mail vs. bugzilla) your bug report is also lacking crucial information.

What are you doing? How does your test look like? Can you share your test?

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Lots of “BREW” patches up for r eview

2010-01-13 Thread Holger Freyther
On Wednesday 13 January 2010 18:23:21 Darin Adler wrote:
 Someone is porting WebKit to Qualcomm’s BREW. And there are many patches
  for that port; now a significant fraction of the unreviewed WebKit
  patches. Who’s going to review these? Is this a one-time code drop or is
  there an intent to maintain this port ongoing? Does the test suite work on
  the BREW platform yet? Will someone maintain a buildbot?
 
 I won’t be reviewing these patches myself until I know the answers to some
  of those questions.

Last time I checked one needs to have a contract with Qualcomm (NDA) to get 
information (header files, documentation) that is beyond marketing bla bla.

I would be interested if we are allowed to host and distribute the sourcecode 
that has used information which is under a NDA.



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] performance improvement techniques for JSCORE

2010-01-05 Thread Holger Freyther
On Tuesday 05 January 2010 07:41:37 nagarjuna atluri wrote:
 Hi guys,
 
 Can anyone suggest performance improvement techniques for JSCORE .
 SFX is already implemeted...

What is your bottleneck?

regards
holger

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Qt Early Warning System intermittently online

2009-12-26 Thread Holger Freyther
On Saturday 26 December 2009 19:07:19 Adam Barth wrote:
 Some folks in the Qt community expressed interest in getting an early
 warning system up and running for Qt.  I brought up an instance of the
 Qt EWS on Amazon's EC2 yesterday, and everything worked great.
 
 The machine time costs about $130/month (for a high-CPU, medium-size
 instance), which I'm happy to pay in the short term.  In the long
 term, though, it might be better if someone with a more direct
 interest in the Qt port funded the bot.

The thing I could offer is a Jail on one of my FreeBSD servers or maybe the 
Szeged University has some more capacity as well?


regards
holger
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Style for Gtk/Qt code

2009-12-26 Thread Holger Freyther
On Monday 21 December 2009 08:46:59 Holger Freyther wrote:
 On Monday 21 December 2009 08:25:31 Eric Seidel wrote:
  The style-bot warns for style errors in all code in the webkit tree,
  but I'm not sure if that's correct.
 
  Are there sections of gtk/qt/whatever code which should be in a different
   style?
 
 For all of Qt (WebCore/platform/*/qt, WebKit/qt*) we are using the WebKit
 style. Historically this has not been the case for WebKit/qt but we agreed
  to change..

Hi,
I need to correct myself. The WebKit/qt/tests and WebKitTools/QtLauncher 
directory are using public API. So some rules like include config.h first do 
not apply there.

z.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Question about Heap::markConservatively.

2009-12-20 Thread Holger Freyther
On Monday 21 December 2009 07:31:12 pattin.shieh wrote:

 b. Cound somebody tell me the crash reason about?  I think maybe program
 access non-align(4bytes) memory address?


Hi,

this is this interesting. Normally we are interested in a reduction. This 
means the smallest possible test case that is showing the error? Could you 
come up with that?

Regarding your assumption on unaligned memory access. The Linux kernel has at 
least three different modes to handle the alignment trap. Which one do you have 
set? You could set the fixup+warn mode and then see in dmesg which PC was doing 
this operation and use addr2line to find the place...

For Linux please see Documentation/arm/mem_alignment in the linux tree.

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Style for Gtk/Qt code

2009-12-20 Thread Holger Freyther
On Monday 21 December 2009 08:25:31 Eric Seidel wrote:
 The style-bot warns for style errors in all code in the webkit tree,
 but I'm not sure if that's correct.
 
 Are there sections of gtk/qt/whatever code which should be in a different
  style?



For all of Qt (WebCore/platform/*/qt, WebKit/qt*) we are using the WebKit 
style. Historically this has not been the case for WebKit/qt but we agreed to 
change..

For Gtk+ I'm not really sure.. We tend to use NULL.. but I/we always forget 
the conclusion. I tend to allow NULL in cases where it is used with 
C/Glib/GObject code.



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Patch to use V8 engine with Gtk port

2009-12-12 Thread Holger Freyther
On Saturday 12 December 2009 22:42:34 Maciej Stachowiak wrote:
 I think questioning someone's priorities in an open source project is
 generally not polite, unless there is some direct relationship between
 different tasks. For example, if someone introduce a new feature
 (let's say support for parts of the FooML language) and it had lots of
 bugs, it might be reasonable to ask them to fix some of the bugs
 before implementing more FooML features. But that doesn't seem to be
 the case here.
 
 Ultimately, I think it's up to the Gtk port maintainers and the folks
 maintaining v8 bindings to decide whether they want to support and
 maintain this functionality, and to review the patch as they see fit.

Hello Mike, All,

I'm not questioning your priorities. I'm solely looking at this from a 
maintaining WebKit/GTK+ point of view. The problem with WebKit (or any big 
software project) is that we are not done when landing a fundamental new 
feature/configure option but it is really only the beginning.

The questions are around, who is running a buildbot with this configuration 
option, who will look at this buildbot, who will keep it building. In general 
it is better to have less options (as these could be actually checked prior to 
a release). So it is really not about me telling Mike what to do, but thinking 
about what is maintainable for WebKit/GTK+.

E.g. we have an experimental GLib Unicode implementation, and saving the 
storage size for ICU (12 mb when not statically linked) is a pretty good 
reason for some.

At the end of the day I feel responsible for the Gtk+ port and I would just 
like to know why it makes sense for us to maintain it.

regards
holger.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Patch to use V8 engine with Gtk port

2009-12-11 Thread Holger Freyther
On Friday 11 December 2009 23:55:06 Eric Seidel wrote:
 I don't see a patch on the bug, but I look forward to seeing it when
 it's posted.
 
 I'm surprised that having switch-able JS engines would bubble up on
 the list of things to do above things like passing the layout tests:
 http://trac.webkit.org/browser/trunk/LayoutTests/platform/gtk/Skipped

Dear Mike,

is JavaScript execution really the dominating cost in your (page loading 
tests)? When I profile on ARM (not WebKit/GTK+ though) I see various other 
areas of improvement?

holger
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] ruby annotation layout tests

2009-11-11 Thread Holger Freyther
On Thursday 12 November 2009 01:33:55 Roland Steiner wrote:
 Yes, that was the reasoning why I used Japanese for those tests.

Which font do you propose to use for japanese?

holger
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Questions to the Android and WebOS team...

2009-10-18 Thread Holger Freyther
Hello Android Team, WebOS Team,

I hope you are lurking or can be poked by your friends that read this. I spent 
some of my Friday and Sunday going through the git repository/patch.

I would like to encourage you to put some of your patches up to review as I 
think anyone can benefit from the great work you have done on some areas.

While looking at the Android tree:

 - Please send the alignment fix for WebCore::StringHash::equal
 - Please elaborate on the removal of current-decodedSize() in
   WebCore::Cache::pruneDeadResources
 - I didn't look deeper as the history is quite hard to navigate and
   rebasing would be very nice.


While looking at the WebOS patch:

 - Nice change with the JDCT_IFAST for jpeg decoding
 - Nice change to get rid of floating point calculation in RGBA32Buffer
   for pre-multiplied alpha and figuring out the difference of division
   of 256 and 255 for the 0..256 range. Please propose to merge this
- Do you have numbers for your CSSParser change to not go through
   fastMalloc for various sizes of the CSS?
- Did you have problems with pruneLiveResources or why are you
  throwing away the raw CSS text after having parsed it in 
  CachedCSSStyleSheet.cpp?


I would like to encourage all of you to file bug reports for these small
changes and flag your patches for review.


love
holger


PS: Dear Android team, could you please produce a nice and clean patch against 
the base revision of WebKit. The perforce imports, the lack of new ChangeLogs 
make it really tough to figure out what was taken from ToT and what was added 
by Google.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] webkit apocrypha + benchmarking

2009-10-07 Thread Holger Freyther
On Wednesday 07 October 2009 12:36:24 Akos Kiss wrote:
 Hi All,
 
 I hope that a lot of you are regularly visiting our benchmarking site at
 http://www.sed.hu/webkit :) . As you might know, the performance and
 memory consumption of JavaScriptCore is measured on x86 Linux and Mac
 platforms, on several benchmark suites, on a regular basis, and
 visualized in the form of nice charts.

Do you think you could use HTML5/Canvas for the charts like the Chromium folks 
do? And do you think it would be possible to document the setup? Specially how 
the memory usage is determined and last would be the question if you would be 
willing to run some webkit tests as well?

The reason I ask is that I have recently started building a page loading test 
for the poor[1] and a script/application to mirror content.

holger


[1] http://trac.webkit.org/wiki/QtWebKitPerformanceWork

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Building Webkit on Linux

2009-08-11 Thread Holger Freyther
On Tuesday 11 August 2009 12:30:25 Jilu Oommen wrote:
 Hi,

sending the same mail twice to the wrong mailinglist is not very helpful. You 
can see here[1] to pick the right mailinglist. If you search for support you 
will need to provide enough information to allow people to actually help you..

The minimum is at least:
- What version of WebKit do you have?
- What version do your dependencies have?
- Is the same revision building on the buildbots?
- What are you trying to do (the command you used to configure and 
build)?

z.

[1] http://webkit.org/contact.html

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Memory leak or should I clear content of QWebPage?

2009-07-29 Thread Holger Freyther
On Wednesday 29 July 2009 17:40:59 Zongheng Zhou wrote:
 After I load www.cnn.com for 800 times consecutively, the virtual memory
 size of my little program has reached 1600M; while the resident memory is
 1500M
 This is horribleIs this kind of memory leak expected?

It would be a great sign of respect if you read http://webkit.org/contact.html 
and start using webkit-help for these kind of questions.

holger
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Memory leak or should I clear content of QWebPage?

2009-07-29 Thread Holger Freyther
On Thursday 30 July 2009 02:52:11 Holger Freyther wrote:
 On Wednesday 29 July 2009 17:40:59 Zongheng Zhou wrote:
  After I load www.cnn.com for 800 times consecutively, the virtual
  memory size of my little program has reached 1600M; while the resident
  memory is 1500M
  This is horribleIs this kind of memory leak expected?

 It would be a great sign of respect if you read
 http://webkit.org/contact.html and start using webkit-help for these kind
 of questions.


And a good request for help includes the following information (and send it to 
webkit-help):

- What you are using. QWebPage doesn't really tell much. Which version 
of 
WebKit, which version of Qt do you use?

- What you are doing. E.g. do you use QtLauncher -r load.these.urls 
with 800 
entries for cnn. Or do you have custom code? If you have custom code you 
should post it to make sure you don't have a memleak in your code.


kind regards
holger
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] incompatibility between DOM spec (IDL) and c-based (gobject) language bindings

2009-07-23 Thread Holger Freyther
On Thursday 23 July 2009 18:31:32 Luke Kenneth Casson Leighton wrote:

 i trust that this comprehensive answer illustrates to you that it was,
 although extremely quick, not without sound reasons that i chose to
 raise this matter on the lists, and i trust that you will in future do
 myself and others on this list the courtesy of not make it necessary
 for me to spend considerable time explaining and justifying my actions
 and decisions.

Okay, it is the n-th time you will receive a mail like this, from n different 
people. This might indicate that it has to do something with you and not the n 
people sending you such kind of mail.

webkit.org is no poetry club, keep your mails short. You could have answered 
the mail in two sentences instead you are watering your message with useless 
information to a point nobody even cares to read it.

love
z.



Example below:

maciej's: Point was: Normally we respond to comments in a bug in the bug 
itself.

you could have said: Well, in this case I believe it is important to have a 
broader audience...

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] onfocus signal

2009-07-18 Thread Holger Freyther
On Saturday 18 July 2009 13:02:43 Dan Antebi wrote:
 Lo,
 Can anyone direct me to an onfocus signal?

 Basically, I would like to pop up a virtual keyboard when in input field
 (very much like iphone) for a touch screen kiosk deployment (linux, GTK).

Please use webkit-h...@lists.webkit.org to ask for help, this mailinglist is 
for the actual development of webkit.

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] slowing down flash games, how?

2009-07-18 Thread Holger Freyther
On Saturday 18 July 2009 23:55:52 Shi Yan wrote:
 hi guys,

 i posted this on qtcenter, but i thought maybe i can get some help here.

This is for WebCore/JavaScriptCore development, you might get help here: 
https://lists.webkit.org/pipermail/webkit-help.

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Patch process - let's make it better

2009-07-13 Thread Holger Freyther
On Monday 13 July 2009 13:47:13 Luke Kenneth Casson Leighton wrote:
 On 7/13/09, Luke Kenneth Casson Leighton luke.leigh...@googlemail.com 
wrote:
   I concur with Maciej.
  
 Luke, in some other culture your posts are already considered
derogatory and insulting.

  also  - (i apologise for not thinking of this earlier) - it's worth
 emphasising that
  early on in the #16401 development process, when things were going well,
 the development was progressing rapidly, and i was collecting valuable
 contributions,
  advice and input from several sources, including apple employees as well
 as free software sources, i felt absolutely no need to swear.

  then, as the sheer scale of the work began to become clear to the
 reviewers, they began to feel overwhelmed, and, in an effort to reduce
 stress levels, began
  to throw up barriers.

Dear Luke,

webkit-dev is really no place for your paranoia.

greetings from your unpaid volunteer that feels well treated by the apple 
engineers working on webkit.org[1].

z.

[1] I can not speak for all of apple, because I didn't meet every single 
person of currently employed by apple...
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Porting WebKit On OMAP 3530 evm

2009-06-18 Thread Holger Freyther
On Thursday 18 June 2009 15:35:23 jagadeesh k wrote:
 Hi,

 Thanks Holger,Zoltan for your solutions.
  
 Actually task has changed,i need to port webkit on OMAP 3530 running with
 open-embedded Linux(Angstrom). 

Still the same task, there is no porting necessary...

  bitbake webkit-gtk

wait, wait, wait, have an installable package... or alternatively download the 
existing package[1] (you want arm7a for your beagleboard...) and sorry this is 
still the wrong place to ask.

z.

[1] http://www.angstrom-distribution.org/repo/?pkgname=libwebkit-1.0-2
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Building WebKit on ARM

2009-06-17 Thread Holger Freyther
On Wednesday 17 June 2009 15:50:32 jagadeesh k wrote:
 Hi,

 I want to built WebKit on OMAP 3530(ARM cortex A8)with Open embedded
 Linux distribution. 1.Want to know the build instructions for building
 WebKit on OMAP 3530?

 2.Does the WebKit source need to be changed(makefile) so that it builds for
 OMAP 3530?

No,

koen from Angstrom/OpenEmbedded is maintaining the build recipe. All you need 
would be something like bitbake webkitgtk and you will get a webkit with the 
Armv7 JIT enabled for your OMAP3.

I think it would be best if you ask further questions in an OpenEmbedded 
channel.

regards
holger
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] NPAPI Plugin on openembedded

2009-06-11 Thread Holger Freyther
On Thursday 11 June 2009 12:09:37 Graffine wrote:
 Hi all:

 I port webkit/Gtk+ to openembedded and try to test flash plugin on
 GtkLauncher. I take qemu to simulate the embedded environment, incluing
 arm linux and x86 linux platform. I found that webkit cannot load any
 plugins on x86 linux, but it can work well on arm linux.

 The following is my testing steps:

 1. Cross-compile WebKit r44125 and flash plugins (Only for arm linux)
 2. Put flash plugin on ~/.mozilla/plugins
 3. Launch GtkLauncher and browse YouTube.

 In addition, I also test it on desktop linux(OS is Ubuntu 8.10), and it
 works well. This looks very strange. Does any one know what I miss or
 NPAPI plugins need any extra packages?

I don't understand... you say it does not work x86 linux but then you mention 
it works on Ubuntu 08.10 (which is likely) x86...

anyway use strace and search for faile dlopen, stats, and such that could 
indicate loading the plugin

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] webkit #16401

2009-06-09 Thread Holger Freyther
On Tuesday 09 June 2009 10:39:41 Luke Kenneth Casson Leighton wrote:
 [hiya sean, moving this to webkit-dev as other people may benefit from
 it, hope you don't mind]

sorry, I don't understand at all... copying stuff over in the middle of thread 
is not helping anyone. Subject and content just confuse me...

z.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] arm jit

2009-06-09 Thread Holger Freyther
On Tuesday 09 June 2009 23:38:43 Akos Kiss wrote:
 Dear Community,

 Today, we realized that there is a new ARM JIT port for WebKit.
 (http://trac.webkit.org/changeset/44514) Congratulations on getting this
 working!, great job.

 I cannot conceal how disappointed I am, as is the whole team at Szeged.

I can understand how bad you feel and I agree that Apple does not comment on 
future products.-mantra can suck at times. When you look at the ARM JIT of 
Apple you will see they mostly target Cortex-A8 (thumb2, vfp) and IIRC your 
JIT is much wider (supporting many more existing devices).

So my bottom line is something like please don't give up, and contributing to 
the JIT should be more easy now. E.g. pick a topic/theme for your work and try 
to get it in.

I can not share that WebKit is not a open community. Of course there are 
vendor interests and Apple, Nokia and Torchmobile don't share some of them. 
E.g. Apple probably does not see the value of XHTML MP, ECMA MP and WML and 
still these changes go on...

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] #16401 webkit glib / gobject bindings

2009-06-08 Thread Holger Freyther
On Monday 08 June 2009 01:44:18 Peter Kasting wrote:
 This was a long message.  I couldn't figure out what it was saying (the
 length discouraged me from trying too hard).  Perhaps you could summarize
 in a sentence or two?  It seemed like something about DOM bindings for
 other languages and whether or not people care?
 I also tried to look at bug 16401, and even just comment 200, but both were
 also incredibly long and I gave up.  Sorry.

Hey Luke,

I have the same problem as Peter. Could you please summarize what you are 
trying to say in a sentence or two?

z.

PS: Have you looked at the way QtWebKit is providing access to the DOM?
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to disable webkit image loading

2009-06-08 Thread Holger Freyther
On Monday 08 June 2009 18:46:07 Zongheng Zhou wrote:
 I have the same issue, and I am using Solaris. Do you know how to disable
 the image loading? Thanks.

Qt or Gtk+. But in both cases there is a *Settings class... and you can 
consult the API documentation... for Qt[1] for Gtk+[2].

z.

[1] http://doc.trolltech.com/4.6-snapshot/qwebsettings.htm
[2] http://webkitgtk.org/reference/webkitgtk-WebKitWebSettings.html
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Fwd: [GTK]Scroll deficiency

2009-06-02 Thread Holger Freyther
On Tuesday 02 June 2009 09:41:38 Srinivas Rao M Hamse wrote:

 I wish to know if this fix is working, why is it not landed yet. What is
 the plan for this bug.
 What is the bug number for Gtk+Directfb platform.

Please see http://webkit.org/coding/contributing.html and 
http://webkit.org/quality/reporting.html. From what I know no bug report has 
been filed, and no patch has been posted for review.

If you experience an issue, please file a bug report, if you have a patch, 
please see the contributing guidelines and post a patch, I'm happy to review 
it then.

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] RFC: Creating header include policy for Gtk+

2009-05-31 Thread Holger Freyther
Hey fellow reviewers,

I would like to establish a new policy for the Gtk+ port and use mail to get 
comments and agreement on it.

The problem:
Our header files (*.h) have a lot of include statements. This is a problem 
(specially without using precompiled headers, we don't on Gtk+) because we 
instruct the preprocessor to search for these header files and our compiler 
needs to parse through these. One specific problem we face in the Gtk+ side of 
things are innocently looking includes like cairo.h. cairo-ft.h, gtk/gtk.h. 
They will resolve to a load of other includes... In the case of gtk it is all 
glib headers, all glib-object headers (the two/three), each and every 
GtkWidget, or in the case of cairo-ft we get the whole set of freetype 
headers. This can easily increase the list of to be included files... by one 
third.

The proposed solution and policy:
Ban cairo.h, gtk.h, gdk.h, glib.h, glib-object.h, soup.h from header files and 
replace the structures and inlined calls with forward declaration.

I have created a bug/patch[1] to look at the impact of this new policy and I 
probably still need to show that this approach is any faster.

kind regards
holger


[1] https://bugs.webkit.org/show_bug.cgi?id=26103
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Does anyone encounter this problem on NY times while using QWebKit?

2009-05-25 Thread Holger Freyther
On Monday 25 May 2009 05:29:37 TianShijun wrote:
 The website is shown correctly  in IE8(with JavaScript error), Safari 4
 beta, Firefox 3.0.10 too.

 I have tried other ports, but encountered many building problems. I think
 it may be  a problem of Qt because the official safari works well. The
 signal mechanism of Qt makes it difficult to debug the problem. I cannot
 find out who send FinishLoading signal to QWebpage.

What we do in general is we try to come up with a simple HTML page that is 
illustrating the problem (reduction). Do you think you could come up with such 
a reduction?

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to let webkit to be able to load local image file in html content?

2009-05-14 Thread Holger Freyther
On Thursday 14 May 2009 07:14:18 Jan Alonzo wrote:
 Hi  james,

 can you please file a bug against the WebKitGtk component at
 http://bugs.webkit.org. I don't think that's correct.

It is correct. You define the SecurityOrigin (we have a class with that name) 
and you want to load something from a different context. Think of a WebPage 
trying to get file:///etc/passwd. This is only allowed if the page itself has 
been loaded from file...



z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Hi, how can I know the whole architecture of webkit?

2009-05-14 Thread Holger Freyther
On Thursday 14 May 2009 12:05:29 JIN Wei wrote:
 Hi, guys:

 As a newbie to open source software , I wonder where can I find the
 docs of the architecture of webkit.
 And how can I get start?

As hard it might sound. There is no architecture documentation available at 
this moment, the code is all we have.

Regarding starting, the question is what do you want to learn? There are blog 
posts by Dave Hyatt on the surfin safari blog how the render tree is working, 
there is a video by Lars Knoll and George Staikos on Yahoo explaining the 
history and ideas of KHTML/WebKit.

Do you have any specific interest? CSS? Layout? Painting? DOM? Networking? 
Editing?

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Error building Webkit Gtk on MacOSX

2009-05-09 Thread Holger Freyther
On Saturday 09 May 2009 13:58:34 Zhe Su wrote:

 './'`WebCore/plugins/gtk/PluginViewGtk.cpp
 /opt/local/include/X11/Intrinsic.h:158: error: conflicting declaration
 ‘typedef char Boolean’
 /System/Library/Frameworks/CoreServices.framework/Headers/../Frameworks/Car
bonCore.framework/Headers/MacTypes.h:279: error: ‘Boolean’ has a previous
 declaration as ‘typedef unsigned char Boolean’
 make[1]: *** [WebCore/plugins/gtk/libWebCore_la-PluginViewGtk.lo] Error 1
 make: *** [all] Error 2

Yeah, I saw that too but didn't come around making a proper patch. The thing 
is that something should be included with PLATFORM(MAC) but not 
PLATFORM(DARWIN) (or such).

Please see http://webkit.org/coding/contributing.html on how to contribute a 
patch.


thanks
z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Problem with building WebKit

2009-05-09 Thread Holger Freyther
On Saturday 09 May 2009 14:57:05 David wrote:
 I'm planning to port webkit to Windows, and just make a little change, such
 as change its graphics backend. At the present, I pick Skia.

 How could I achieve this, any clue?

this is rather rude. You have asked this question in  [webkit-dev] About 
graphics backend changing and now you ask again at least some more specific...

You could start with building the cairo port and then replacing this with skia 
routines... much like the original windows port started with CG and 
implemented it with cairo

z.



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] About graphics backend changing

2009-05-08 Thread Holger Freyther
On Friday 08 May 2009 10:18:09 David wrote:
 hi.
 Now I'm working on testing webkit's portability. For example, I am planning
 to change webkit's graphics backend to Skia, just like chrome does.

 But I'm new to webkit, is there any docs about how to do that in detail?

No,

there is not. which port do you try to change?

z.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Is it possible to block webkit_web_view_load_html_string() until the content is actually loaded?

2009-05-04 Thread Holger Freyther
On Monday 04 May 2009 06:36:46 Zhe Su wrote:
 Hi,
   I'm writing an application which uses webkit to display some html
 content. webkit_web_view_load_html_string() is used to set content into
 webkit. I found this function will return before the content is actually
 loaded, then webkit will load the content in background. However my
 application needs block until the content is actually loaded. I know that
 webkit has a signal load-finished, which will be emitted when the content
 is fully loaded. But because of some limitation, my application can only
 block at somewhere until the content is fully loaded. Because it's a single
 thread application, I don't know how to do it. Any suggestions to solve
 this problem?

Run your own event loop and leave it once load-finished got called or your 
timeout is reached...


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to make the size of QtWebKit4.dll or libQtWetKit.so smaller?

2009-04-23 Thread Holger Freyther
On Thursday 23 April 2009 04:00:24 alex wrote:


 Anyone know how to get smaller WebKit library? We want to use it in a
 Embedded environment.

情用 您的本名如果您需要我們的幫忙,謝謝、

kind regards

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] how to instead of ..... in the password editor

2009-04-06 Thread Holger Freyther
On Tuesday 07 April 2009 02:45:50 zhenghe zhang wrote:
 Hi all
 I have a problem, and I don't understand it ,could you tell me ?
 input type=password id=text name=text1 value=Hello 
 In the input-element, . takes the place of Hello, but I don't know
 how to do it through C++ functions.
 Thank you  best regards

Hey Zhenghe,

you have written more than 30 mails starting from December, Have you 
contributed anything during this time to WebKit.org project (filed a bug, send 
a patch?)? Where is your interest coming from?

z..
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to compile WebKit GTK+ port from ARM processor?

2009-03-11 Thread Holger Freyther
On Wednesday 11 March 2009 10:16:07 arati wrote:
 Hi,

 Can anyone give me any pointer to compile WebKit GTK+ port for ARM
 processor?

Which operating system?

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Quick Look at Gtk+ test failures

2009-02-17 Thread Holger Freyther
On Tuesday 17 February 2009 15:08:15 Gustavo Noronha wrote:
 Yo!

 On Tue, 2009-02-17 at 01:05 +0100, Holger Freyther wrote:
  I just had a quick look at the dom/svg test failures (actually one
  result) and my first idea is that we transmit the wrong mimetype for the
  GIO based local file handling.
 
  I plan to find some time to tomorrow...

 Thought it might help:


Okay, some more work today...

void ResourceHandle::loadResourceSynchronously(const ResourceRequest, 
ResourceError, ResourceResponse, Vectorchar, Frame*)
{
notImplemented();
}   


:)
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Quick Look at Gtk+ test failures

2009-02-16 Thread Holger Freyther
Hey,

I just had a quick look at the dom/svg test failures (actually one result) and 
my first idea is that we transmit the wrong mimetype for the GIO based local 
file handling.

I plan to find some time to tomorrow...



z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Create widgets with WebKit/Gtk

2009-02-06 Thread Holger Freyther
On Thursday 05 February 2009 17:35:11 Massimo wrote:


 Does WebKit implement some custom architecture to build widgets and/or
 support some feature from W3C Widgets working draft?

./configure --help | grep dash

and then google for whatever comes out.

z.


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Getting more buildbots green

2009-01-27 Thread Holger Freyther
On Sunday 04 January 2009 03:31:43 you wrote:
 On Jan 3, 2009, at 3:42 PM, Holger Freyther wrote:
  I'm not sure if we would win anything by making the buildbot green.

 Here’s my opinion on this:

 It’s a huge win to make a buildbot green. Once it's green, someone who
 breaks something and makes it red can see they've done something
 wrong. That's really what buildbots are for. We've gotten way too
 accustomed to having lots of them red and so we're not getting the
 full value out of them.


may I read this as a rs=darin?

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Segmentation fault when exit GtkLauncher

2009-01-13 Thread Holger Freyther
On Tuesday 13 January 2009 23:07:23 ying lcs wrote:
 Hi,

 I always get a Segmentation fault when I exit GtkLauncher (click the
 close bottom of the application window).

 Attached is the stack trace.

 Has anyone see the same issue?

Seen and spend fixing (Company and Company)

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Fail to build WebKit r37132 with GTK on Fedora core 10

2009-01-09 Thread Holger Freyther
On Friday 09 January 2009 10:11:43 ferrety ferrety wrote:

 HTTPHeaderMap::const_iterator end = req.httpHeaderFields().end();
 for (HTTPHeaderMap::const_iterator it =
 req.httpHeaderFields().begin(); it != end; ++it) {
 fprintf( pf , %s:%s\r\n , it-first.latin1().data() ,
 it-second.latin1().data() );
  

HTTPHeaderMap (IIRC) was changed from String to AtomicString, you will need to 
call AtomicString::string() to get the string. See 
WebCore/platform/text/AtomicString.h



z

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Fail to build WebKit r37132 with GTK on Fedora core 10

2009-01-08 Thread Holger Freyther
On Thursday 08 January 2009 15:25:56 ferrety ferrety wrote:

 WebCore/warc/recordout.cpp: In function 'void
 WebCore::recordoutrequest(WebCore::String, WebCore::String,
 WebCore::ResourceRequest)':
 WebCore/warc/recordout.cpp:79: erreur: 'const class
 WebCore::AtomicString' has no member named 'latin1'
 WebCore/warc/recordout.cpp: In function 'void
 WebCore::recordoutresponse(WebCore::String, WebCore::String,
 WebCore::ResourceRequest, const WebCore::ResourceResponse)':
 WebCore/warc/recordout.cpp:114: erreur: 'const class
 WebCore::AtomicString' has no member named 'latin1'

Could you point us to the code?

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Getting more buildbots green

2009-01-03 Thread Holger Freyther

 I'd love to set up the skipped lists properly and fix enough bugs so
 that all our bots are green. Can you help? Maybe there are already bug
 reports about some of these.

Regarding the skipped list on Gtk+. There are some tests that work on my 
machine that are failing on the buildbot. I would like to understand the 
difference before adding them to the skipped list. On the other hand we end up 
in mess when skipping some of the tests from within fast. To me it seems like 
the result of some tests have impact on the others. E.g. when starting to Skip 
one dom test we might need to add ~5 more and could unskip some others.

I'm committed to find the difference and get it green but time is the issue as 
I 
have university stuff first, then paid work with varying degree of load and 
then 
webkit... I'm not sure if we would win anything by making the buildbot 
green...


The JavaScript tests are a mystery to me, it looks like we fail 6 jscore tests 
and I have no idea why (and the TZ on the buildbot is set to Cupertino time 
and the LC_ALL to C).

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] add new functions to WebCore

2008-12-28 Thread Holger Freyther
On Sunday 28 December 2008 12:04:13 houda hocine wrote:
 hi,

 I added new functions to WebCore , i add a folder that contains two files .
 cpp and two headers .h
 But in compilation it show me this errors:

Showing the patch would make things more easy for us.


z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] WebKitGtk network backend

2008-12-28 Thread Holger Freyther
On Monday 29 December 2008 08:14:02 Paul Pedriana wrote:
  FWIW, I rewrote our version of the networking back-end support to use a
 generic pure-virtual interface. That way all those #ifdefs in the code went
 away and the back-end requirements became clearer and easier to provide. We
 are using our own http/ftp/file support that is different from libsoup,
 curl, etc. An interesting result of this is that multiple back-ends can be
 simultaneously active; this allows one library to support ftp while another
 supports http in the case that you (like us) don't have a single library
 that does both. It also allows for a clean implementation of a disk cache,
 as a disk cache is merely an http handler that gets first shot at
 http-provided data. Another result is that custom URI schemes (e.g.
 blah://) can be transparently supported by applications, which is useful
 for custom platforms and uses such as ours.

  Somebody a few weeks ago was talking about pure-virtual interfaces in
 WebKit, and while my response to him was one of caution in getting carried
 away with such interfaces, IMO this is a case where they are beneficial.


Everything right, but we talk about API design and the fundamental question is 
if we wrap a generic interface and make it more generic or if we just expose a 
handle to the library

z. 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Moving methods from Frame to various other classes

2008-12-26 Thread Holger Freyther
On Friday 26 December 2008 00:25:35 Maciej Stachowiak wrote:

  Meanwhile I would like to start some discussion on how this patch
  should be
  put into the bugtracker and comments on the moving.
 
  I wonder if I should put each move up for separate review and then
  land it in
  one go? Should I create a bug report for that?

 It would be better to break the changes down instead of submitting as
 one big patch. Perhaps breaking things up by target class being moved
 to would be best.

Okay, I have moved a lot of out Frame, Gtk+ and Qt are compiling, next thing 
is reviewing what I did, regression testing on Mac and then I will create one 
bug report and attach the patches?


z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Moving methods from Frame to various other classes

2008-12-26 Thread Holger Freyther
On Friday 26 December 2008 21:34:49 you wrote:
 On Dec 26, 2008, at 10:34 AM, Darin Adler wrote:
  On Dec 26, 2008, at 8:41 AM, Holger Freyther wrote:
  Okay, I have moved a lot of out Frame, Gtk+ and Qt are compiling,
  next thing is reviewing what I did, regression testing on Mac and
  then I will create one bug report and attach the patches?
 
  Sounds fine. The smaller and more non-controversial you can make
  each individual patch, the better. Using a single bug report is OK,
  but might get a bit confusing over time.

 Yeah, bug reports that live for a long time and have many separate
 patches attached can get confusing for people who look at the review
 and commit queues. Better to use one bug report per patch or per small
 set of related patches if at all possible.


Right, on the other hand one might forget about the big picture. Anyway, I 
will upload patches to several bugs soon.

z.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Moving methods from Frame to various other classes

2008-12-25 Thread Holger Freyther
Hey,

there are some comments in Frame.h regarding moving functionality to different 
classes and on IRC it was confirmed that the comments are old but current. I 
have decided to do something about it.

I have created a git branch[1] on George's server that will contain the work 
in progress of the moving. I'm currently moving stuff around, it will be 
followed by build fixes and speculative changes for Qt, Mac and then regression 
testing on the mac. I hope to be finished with this by the start of the yearly 
CCC event.

Meanwhile I would like to start some discussion on how this patch should be 
put into the bugtracker and comments on the moving.

I wonder if I should put each move up for separate review and then land it in 
one go? Should I create a bug report for that?


Moving comments:


Zoom and FrameView:
- Currently on history navigation (back/forward) we create a new 
FrameView. 
When storing the Zoom information in the FrameView instead of the Frame the 
Kit parts need to properly restore the Zoom Information? Is that wanted? 
should we leave this functionality in the frame?


Status and Chrome:
- For statusBarText and defaultStatusBarText? Do we really need to 
store the 
defaults? If yes should we do it in Chrome? Would the DOMWindow be a better 
place to store them? What I have difficulties with is that the information is 
set on the Chrome/Kit but that we can have a per frame default...

Editing:
- I have killed Frame::removeEditingStyleFromElement and 
Frame::removeEditingStyleFromBodyElement they have been no-ops since the end 
of 2006.


z.


[1] http://code.staikos.net/cgi-
bin/gitweb.cgi?p=webkit;a=shortlog;h=holger/frame-refactor
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] SquirrelFish Extreme for non x-86 platforms

2008-12-24 Thread Holger Freyther
On Wednesday 24 December 2008 14:00:19 Javed Rabbani wrote:
  I want to know whether WebKit JavaScript Engine SquirrelFish Extreme (SFX)
 has been reported to work on any embedded, non-x86 platform?

No, the extreme variant is only working on x86 and work on progress on the 
amd64...

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] I have problem in display jpeg in webkit

2008-12-24 Thread Holger Freyther
On Wednesday 24 December 2008 02:34:34 RyanYee/叶晔 wrote:
 I build webkit base on gtk-dfb (intel Olo platform),
 webkit-r35289, gtk+-2.10.14,cairo-1.4.2, jpeg-6b
 run Gtklauncher ok,but when jpeg was in html file,jpeg only display left
 part (maybe 1/4 size)
 I tried many jpeg file,same result,so I don't think it's jpeg file format
 problems.
 I found webkit use own jpeg plugin,not gtk's jpeg display,(my gtk-demo can
 display jpeg ok)
 cause my gdbserver not work,so I can only add printf to observe code go
 where.
 in JPEGImageReader::decode() ,i can only got m_state JPEG_HEADER 
 JPEG_START_DECOMPRESS
 and m_info.jpeg_color_space=3, I can only got these infomation now, can
 anybody had even same problem?
 next I want to build same version on X86 to debug,if no other infomation
 got.

Create your reduction. Most simple webpage one pretty easy picture (e.g. only 
a green rect). Load that from file and see if that works..


z.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How webkit on android implements magnifying glass?

2008-12-18 Thread Holger Freyther
On Thursday 18 December 2008 07:50:00 ying lcs wrote:
 Hi,

 In webkit on android, it has a 'magnifying glass' feature: in the zoom
 out view, it has a viewing rectangle which shows the content in 100%.

 Can you please point to me where is the code how webkit on android
 implements magnifying glass?  or what possible function it needs to
 call in order to implement that feature?

You will have to ask Google and specially the Android people. There was no 
attempt at all to bring any patch from Android to WebKit.

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to run GtkLauncher in a debugger

2008-12-14 Thread Holger Freyther
On Sunday 14 December 2008 12:29:13 ying lcs wrote:
 Zoltan,

 Thank you for your help. Yes, GtkLauncher does start (loads www.google.com)

Welcome to libtool. The executable is within the .libs/ directory...

./libtool --mode=execute gdb ./Programs/GtkLauncher from within the build 
directory will setup the paths and launch gdb...

z.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Caught signal 11 (at 0x83d2250, invalid permissions) --

2008-12-02 Thread Holger Freyther
On Tuesday 02 December 2008 10:56:24 Bn, Sharath wrote:
 Dear All,

 I further traced the problem , this problem is happening from release
 WebKit-r38064 onwards. I suspect that this problem happens whenever Webkit
 tries to run JavaScript. Pls see the callstack backtrace attached.

how do you make that happen? Do you have a test case for that?

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] is WebKit leaking or caching memory?

2008-12-01 Thread Holger Freyther
On Monday 01 December 2008 13:22:08 Luka Napotnik wrote:


 Now I'm asking if the memory increment is a result of WebKit caching
 subsystem or could that be a leak? Keep in mind that I click/refresh the
 same page over and over again.

Leak, Cache, Memory fragmentation are all possible. I think by default we do 
not cache so leaking and fragmentation are more likely. Someone found a 
leak in the Font handling of Gtk+ [1] (first bit) which might apply to the 
stock Gtk+ as well.

z.

[1] https://bugs.webkit.org/show_bug.cgi?id=15914#c45
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to enable Inspector in Webkit/GTK

2008-11-30 Thread Holger Freyther
On Sunday 30 November 2008 06:58:27 ying lcs wrote:

Ni-Hao Ying,

why do you want to apply the patch? If you go to the related bug report [1] 
you see that the bug is closed and if you look at the last comment you also 
see the revision it was applied at.

You need a patch to GtkLauncher[2] (referenced from the bug report) or can 
consult the API documentation on how to enable and embed the inspector[3]

z.

[1] https://bugs.webkit.org/show_bug.cgi?id=19392
[2] https://bugs.webkit.org/attachment.cgi?id=22365
[3] http://oe.linuxtogo.org/~zecke/webkit-gtk-api/webkitgtk-
WebKitWebInspector.html


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Full Page Zoom Issue

2008-11-27 Thread Holger Freyther
On Thursday 27 November 2008 11:36:51 mwas wrote:
 Hi Alp,

 I have used the comments mentioned in
 https://bugs.webkit.org/show_bug.cgi?id=14998, Comment #37 you provided for
 Zooming Using CSS in the following way

 I am new to WebKit, Kindly Guide!

Hey,

the bug you mention is marked as resolved. This means that a solution was put 
into the WebKit svn repository and that intermediate comments (like the one 
you mention) might or might not have lead to the solution that was put into 
svn.


In this case the WebKit/Gtk+ port is even offering API:
See http://oe.linuxtogo.org/~zecke/webkit-gtk-api/webkitgtk-
WebKitWebView.html and search for zoom.

have fun

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Cairo Port

2008-11-22 Thread Holger Freyther
On Sunday 23 November 2008 00:32:04 Arvid Ephraim Picciani wrote:
 Hi,
 When googling I found references to a cairo port of webkit.  I checked svn
 but only could find a gtk port.  Am i missing something?
 Cairo is fairly portable, while GTK  is not.

Oh well, Gtk+ is working everywhere where Cairo is working. I think the term 
Cairo port is referring to the Windows Platform where the usage of 
CoreGraphics is replaced with Cairo.

 If there is no pure cairo
 port and there are no plans to make one either,  how time consuming is
 writing a new port? I read webkit is supposed to be very portable.  Is the
 port API stable or does it require constant maintainance?

Constant maintainance is required. On the other hand you can reuse a lot of 
what was created and is maintained for the Gtk+ port (Cairo graphics, 
Curl/Soup networking..). On the other hand the Gtk+ API will gain the ability 
to draw to a cairo_surface sooner or later.  Things like the clutter webkit[1] 
show what is necessary.

z.

[1]http://git.o-hand.com/cgit.cgi?url=webkit/tree/WebKit/clutter/webkit

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Unable to load www.ovam.com on GtkLauncher

2008-11-20 Thread Holger Freyther
On Thursday 20 November 2008 21:24:51 bournwebkit wrote:

 * HTTP 1.0, assume close after body
  HTTP/1.0 302 Moved Temporarily

I get that on the console:

Curl ERROR for url='http://zutex.com', error: 'Number of redirects hit maximum 
amount'


z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] We are porting WebKit to UIQ (Symbian based platform)

2008-11-19 Thread Holger Freyther
On Wednesday 19 November 2008 22:16:21 Zalan Bujtas wrote:
 Hi,
 Ozone team has been porting WebKit to UIQ platform and the first, alpha
 version is available at http://www.o3mobi.com It is based on r34485
 (06/10/08).

wasn't the development of the UIQ platform stopped recently? Or at least most 
of their developers laid off?

So how relevant is UIQ after this?

z.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Handling upload progresses

2008-11-11 Thread Holger Freyther
On Tuesday 11 November 2008 14:46:12 André Pedralho wrote:
 Hi all,

 I'm just wondering if there is a way to get upload progresses the same
 way we can do with download ones.


Not out of the box. Are you talking about PUSH/PUT. You might want to look at 
this[1]. So basicly we know how big this QIODevice is but we do not export 
that in anyway. I don't know how Thiago planned to do this, maybe the Nokia 
guys can help you.

[1] 
http://trac.webkit.org/browser/trunk/WebCore/platform/network/qt/QNetworkReplyHandler.cpp#L46
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Handling upload progresses

2008-11-11 Thread Holger Freyther
On Wednesday 12 November 2008 02:16:03 André Pedralho wrote:

 A network reply handler might be good, but if could not get a network
 reply when one upload starts I guess I will not be able to get a
 handler for it...

 Did I miss something?

Well, you can set the QNetworkAccessManager or such. QNetworkReplyHandler.cpp 
is asking that class for the post job.


you could build something like this (proxy, fascade whatever you want to call 
it):

class MyNetworkAccessManager : public QNetworkAccessManager {

QNetworkReply* post(const QUrl url) {
   QNetworkReply* reply = QNetworkAccessManager::post(url);
   doSomething(reply);
   return reply;
}
};

and set your class on the QWebPage (or a bit more complex if you want to wrap 
any existing QNetworkAccessManager...)

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] [Fwd: Fwd: Re: Moving forward with WebKit/GTK+]

2008-11-07 Thread Holger Freyther
On Tuesday 04 November 2008 10:08:27 Pierre-Luc Beaudoin wrote:
 On Mon, 2008-11-03 at 10:35 -0800, Maciej Stachowiak wrote:
  I would suggest setting up a mailing list, post proposed API
  changes there, and let them be official after a week if there was no
  objection. If bugs are tagged as being API reviewed (by whatever
  process), then others could focus on technical and style issues during
  review.

 I think this could be a very efficient way to make the API stuff
 progressing quickly - at all cost lol (since time is the ultimate dead
 line).

In general I like your idea, specially with Gtk+ 3.0 in sight we know we can 
break API soon so it seems like a good idea to gain experience in that area 
and it would not hurt us too much to add something stupid.

One minor issue, I would prefer a mailinglist (maybe I'm just too old):
- With a mailinglist it is really easy to participate
- I can filter using X-MalingList and get notifications
- We can detach implementation and API.

So yes, I'm happy to review patches adding API that has been discussed and not 
been vetoed. I think I can be happy with such a scheme. So it depends on how 
Alp and others feel about. If we see that this is ending in a disaster we can 
adjust the process and Gtk+ 3.0 is there to rescue..



z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] GeolocationService::startUpdating question

2008-11-01 Thread Holger Freyther
Hey,

I have another GeolocationService question and wonder if someone could shed 
some light into the situation.

Geolocation.cpp is invoking GeolocationService::startUpdating, if the 
GeolocationService implementation is returning false it is treated as 
Permission denied.

The questions I have are:
- Can lastError be checked as well? E.g. there might be no provider and 
the 
service just returned false because of that?

- Should the error message move to LocalizedStrings?

- If one looks at the mozilla mockup/implementation the permission 
check 
might go through the userinterface. Which means we might want to do something 
like we do in the FrameLoaderClient for policy checks?


I'm happy to prepare patches if it makes sense
z.


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Geolocation questions

2008-10-31 Thread Holger Freyther
Hey,
I have started implementing  a GeoLocation service for Gtk+ using the Gypsy 
interface. I have some comments and questions:

1.) Could we remove GeolocationService::create from GeolocationService.cpp? 
Any platform that intends to implement this can have this factory in their 
GeolocationServiceFoo.cpp? This makes it possible to add and remove platforms 
without touching this file.

2.) Geoposition is RefCounted but we pass Geoposition* all over the place? Can 
we decide on of the two? This would also make the ownership more clear.

should I send patches for the above?

comments welcome
z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Geolocation questions

2008-10-31 Thread Holger Freyther
On Friday 31 October 2008 23:41:46 you wrote:

 In regard to geolocalisation, Geoclue seems to be a better choice: it
 can try many methods to determine your position like Host IP, GSM
 networks and not only GPS like Gypsy.

 Have a look! http://www.freedesktop.org/wiki/Software/GeoClue

Good point. Let me throw away my current implementation :)

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Moving forward with WebKit/GTK+

2008-10-29 Thread Holger Freyther
On Tuesday 28 October 2008 20:04:06 Gustavo Noronha Silva wrote:
 Hello there,

 For some time now I've been worried by the lack of progress of
 WebKit/GTK+ where API is concerned. I am aware that loads of work have
 been going into improving the engine backends and frontends, including
 many bug fixes, but real-world adoption for many applications is
 hindered by lack of features being accessible through a public API.

 While using Epiphany/Devhelp/Liferea, for instance, which already have
 semi-functional WebKit/GTK+ ports one isn't able to middle-click links
 to open them in new tabs, which is the kind of feature a user would
 quickly perceive as basic, and missing. Some other features are
 currently being implemented by hacks (mis-)using the already exposed
 API, or the JavaScriptCore API.

The other part is, it is really hard to judge what is Gtk'ish. E.g. our 
current settings API is using GObject properties. Now we have a patch to add a 
thousand getters and setters as shortcut[1].

I think this is weird, e.g. one setter/getter and enum would be enough, or 
even the gobject properites are good enough... so some sort of API feedback of 
key people would be good.


[1] https://bugs.webkit.org/attachment.cgi?id=24541action=edit
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] ScrollbarPart and the way it is used

2008-09-20 Thread Holger Freyther
On Saturday 20 September 2008 18:16:27 David Hyatt wrote:
 I looked at your patch and it was fine.  Your theme APIs on Qt are so
 good that your theme is actually much simpler than the other
 platforms. :)

thanks darin and dave.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


  1   2   >