[webkit-dev] Bug system: Platform and OS fields don't quite align
Hi, I tend to hit code which is often chromium-platform specific. It's hard to know the appropriate Platform and OS fields for such a bug. For instance, I am working on a small change to WebKit/chromium/src/WebKit.cpp. It's not a Mac bug, its not a PC bug, its a Chromium bug. Chromium is a platform of sorts. Chromium bugs could be OS-specific (like Windows, MacOS, etc). So I think the platform field would be the right place to surface such a thing. Should the bug system surface a platform for Chromium? If so- perhaps there are other platforms to surface as well. I'm not sure when a particular flavor of webkit warrants a field in the bug system. If we aren't willing to reflect this through the bug system, what are the right values for these fields? I'm guessing the apple guys want to filter out these bugs - how do you do it today? Thanks, Mike ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Bug system: Platform and OS fields don't quite align
We're not very good at using these fields in Bugzilla. In this situation, folks will usually prefix the summary of the bug with [Chromium]. This is a signal to reviewers that they might be more or less interested in reviewing the patch depending on whether they like/feel comfortably with reviewing patches to WebKit/chromium. Adam On Tue, Sep 14, 2010 at 10:20 AM, Mike Belshe m...@belshe.com wrote: Hi, I tend to hit code which is often chromium-platform specific. It's hard to know the appropriate Platform and OS fields for such a bug. For instance, I am working on a small change to WebKit/chromium/src/WebKit.cpp. It's not a Mac bug, its not a PC bug, its a Chromium bug. Chromium is a platform of sorts. Chromium bugs could be OS-specific (like Windows, MacOS, etc). So I think the platform field would be the right place to surface such a thing. Should the bug system surface a platform for Chromium? If so- perhaps there are other platforms to surface as well. I'm not sure when a particular flavor of webkit warrants a field in the bug system. If we aren't willing to reflect this through the bug system, what are the right values for these fields? I'm guessing the apple guys want to filter out these bugs - how do you do it today? Thanks, Mike ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Bug system: Platform and OS fields don't quite align
On Tue, Sep 14, 2010 at 10:28 AM, Adam Barth aba...@webkit.org wrote: We're not very good at using these fields in Bugzilla. In this situation, folks will usually prefix the summary of the bug with [Chromium]. This is a signal to reviewers that they might be more or less interested in reviewing the patch depending on whether they like/feel comfortably with reviewing patches to WebKit/chromium. Note that bugs should only have [Chromium] in the title if the patch *only* touches Chromium specific files. (Right now, I consider this to be skia related files, v8 related files, and then the files that are obviously chromium due to name or directory structure -- I say right now because I see there are efforts to make skia useful outside of Chromium.) Adam On Tue, Sep 14, 2010 at 10:20 AM, Mike Belshe m...@belshe.com wrote: Hi, I tend to hit code which is often chromium-platform specific. It's hard to know the appropriate Platform and OS fields for such a bug. For instance, I am working on a small change to WebKit/chromium/src/WebKit.cpp. It's not a Mac bug, its not a PC bug, its a Chromium bug. Chromium is a platform of sorts. Chromium bugs could be OS-specific (like Windows, MacOS, etc). So I think the platform field would be the right place to surface such a thing. Should the bug system surface a platform for Chromium? If so- perhaps there are other platforms to surface as well. I'm not sure when a particular flavor of webkit warrants a field in the bug system. If we aren't willing to reflect this through the bug system, what are the right values for these fields? I'm guessing the apple guys want to filter out these bugs - how do you do it today? Thanks, Mike ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Bug system: Platform and OS fields don't quite align
On Tue, Sep 14, 2010 at 6:32 PM, David Levin le...@chromium.org wrote: On Tue, Sep 14, 2010 at 10:28 AM, Adam Barth aba...@webkit.org wrote: We're not very good at using these fields in Bugzilla. In this situation, folks will usually prefix the summary of the bug with [Chromium]. This is a signal to reviewers that they might be more or less interested in reviewing the patch depending on whether they like/feel comfortably with reviewing patches to WebKit/chromium. Note that bugs should only have [Chromium] in the title if the patch *only* touches Chromium specific files. (Right now, I consider this to be skia related files, v8 related files, and then the files that are obviously chromium due to name or directory structure -- I say right now because I see there are efforts to make skia useful outside of Chromium.) It's worth noting that Android also uses v8 and skia. They only have one reviewer at the moment, but it still might be best to not associate Chromium with skia/v8 changes. As for the original questions: does anyone actually use any of those categories in bugs? If not, is there any way to get rid of them? As far as I'm aware, they're just noise at the moment. Adam On Tue, Sep 14, 2010 at 10:20 AM, Mike Belshe m...@belshe.com wrote: Hi, I tend to hit code which is often chromium-platform specific. It's hard to know the appropriate Platform and OS fields for such a bug. For instance, I am working on a small change to WebKit/chromium/src/WebKit.cpp. It's not a Mac bug, its not a PC bug, its a Chromium bug. Chromium is a platform of sorts. Chromium bugs could be OS-specific (like Windows, MacOS, etc). So I think the platform field would be the right place to surface such a thing. Should the bug system surface a platform for Chromium? If so- perhaps there are other platforms to surface as well. I'm not sure when a particular flavor of webkit warrants a field in the bug system. If we aren't willing to reflect this through the bug system, what are the right values for these fields? I'm guessing the apple guys want to filter out these bugs - how do you do it today? Thanks, Mike ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Bug system: Platform and OS fields don't quite align
On Tue, Sep 14, 2010 at 10:38 AM, Jeremy Orlow jor...@chromium.org wrote: It's worth noting that Android also uses v8 and skia. They only have one reviewer at the moment, but it still might be best to not associate Chromium with skia/v8 changes. As for the original questions: does anyone actually use any of those categories in bugs? If not, is there any way to get rid of them? As far as I'm aware, they're just noise at the moment. You mean Platform OS? I've seen dozens editing bugs that are associated with Windows or Mac since some behaviors need to be platform-specific or there are platform-specific quirks. I've never really seen a good use of Platform because platform is usually determined by OS. I'd like to see qt, gtk, chromium, etc... on platform (or better be called as ports?) instead. - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
