Re: [webkit-dev] Having trouble building

2019-10-06 Thread Maciej Stachowiak


> On Oct 5, 2019, at 9:36 PM, Ken Russell  wrote:
> 
> On Sat, Oct 5, 2019 at 1:11 AM Tim Horton  > wrote:
> 
> 
> > On Oct 4, 2019, at 8:55 PM, Ken Russell  > > wrote:
> > 
> > Hi,
> > 
> > Recently I upgraded to Xcode 11.0 and re-synced to top-of-tree WebKit. With 
> > a clean WebKitBuild directory I'm seeing the following build error:
> 
> What OS are you on?
> 
> You might want to peek at https://bugs.webkit.org/show_bug.cgi?id=199705 
> 
> 
> macOS 10.14.6, Xcode 11.0 from the App Store.
> 
> Looks like the same problem. Could anyone from Apple please try to help fix 
> this? I posted a hack workaround on the bug but don't know enough Objective-C 
> to guess at a correct fix.

Does the new patch from Mitz fix the build for you?

 - Maciej

> 
> Thanks,
> 
> -Ken
> 
>  
> > $ ./Tools/Scripts/build-webkit --release > build-log.txt
> > 
> > ...
> > 
> > In file included from 
> > /Users/kbr/src/WebKit/WebKitBuild/Release/DerivedSources/WebKitLegacy/unified-sources/UnifiedSource20-mm.mm:4:
> > /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:5: 
> > error: use of undeclared identifier '_subviews'; did you mean 'subviews'?
> > _subviews = subviews;
> > ^
> > subviews
> > /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:220:63:
> >  note: 'subviews' declared here
> > - (void)_setSubviewsIvar:(NSMutableArray<__kindof NSView *> *)subviews {
> >   ^
> > /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:15:
> >  error: explicitly assigning value of variable of type 
> > 'NSMutableArray<__kindof NSView *> *' to itself [-Werror,-Wself-assign]
> > _subviews = subviews;
> > ~ ^ 
> > /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:228:30:
> >  error: use of undeclared identifier '_subviews'
> > return (NSMutableArray *)_subviews;
> >  ^
> > 3 errors generated.
> > 
> > 
> > 
> > Has anyone else run into this?
> > 
> > Thanks,
> > 
> > -Ken
> > 
> > ___
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org 
> > https://lists.webkit.org/mailman/listinfo/webkit-dev 
> > 
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Having trouble building

2019-10-05 Thread Tim Horton



> On Oct 4, 2019, at 8:55 PM, Ken Russell  wrote:
> 
> Hi,
> 
> Recently I upgraded to Xcode 11.0 and re-synced to top-of-tree WebKit. With a 
> clean WebKitBuild directory I'm seeing the following build error:

What OS are you on?

You might want to peek at https://bugs.webkit.org/show_bug.cgi?id=199705

> $ ./Tools/Scripts/build-webkit --release > build-log.txt
> 
> ...
> 
> In file included from 
> /Users/kbr/src/WebKit/WebKitBuild/Release/DerivedSources/WebKitLegacy/unified-sources/UnifiedSource20-mm.mm:4:
> /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:5: 
> error: use of undeclared identifier '_subviews'; did you mean 'subviews'?
> _subviews = subviews;
> ^
> subviews
> /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:220:63: 
> note: 'subviews' declared here
> - (void)_setSubviewsIvar:(NSMutableArray<__kindof NSView *> *)subviews {
>   ^
> /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:222:15: 
> error: explicitly assigning value of variable of type 
> 'NSMutableArray<__kindof NSView *> *' to itself [-Werror,-Wself-assign]
> _subviews = subviews;
> ~ ^ 
> /Users/kbr/src/WebKit/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:228:30: 
> error: use of undeclared identifier '_subviews'
> return (NSMutableArray *)_subviews;
>  ^
> 3 errors generated.
> 
> 
> 
> Has anyone else run into this?
> 
> Thanks,
> 
> -Ken
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev