Re: [webkit-dev] Remove underscore check in check-webkit-style?
On Thursday 14. January 2010 12.49.40 ext Kenneth Christiansen wrote: In Qt we only allow underscored in methods that start with qt_ and they are used for private API, such as for the DRT and for API that we havent had the time to API review, but are still needed by some other software products. Hi, In general it is true, but you have forgotten about q_ptr, d_ptr and *_data in Qt's autotest suite. Jędrek ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Remove underscore check in check-webkit-style?
In Qt we only allow underscored in methods that start with qt_ and they are used for private API, such as for the DRT and for API that we havent had the time to API review, but are still needed by some other software products. Kenneth On Wed, Jan 13, 2010 at 9:32 PM, Darin Fisher da...@chromium.org wrote: On Wed, Jan 13, 2010 at 4:17 PM, Evan Martin e...@chromium.org wrote: On Wed, Jan 13, 2010 at 3:43 PM, Adam Barth aba...@webkit.org wrote: Current check-webkit-style and the style bot complain if code uses identifiers with underscores in their names. It turns out our code does this fairly often, especially in Qt and Gtk specific code, for example to interface with unit testing frameworks. We could either: 1) Teach check-webkit-style about these cases 2) Remove the underscore check entirely My inclination is to do (2) because I haven't seen this check find many actual style problems. However, if we think that (1) is the better road, I'll be happy to make that happen. I frequently forget the underscore rule (since all the other code I work on prefers underscores). As a beneficiary of the style checker, I'd prefer to avoid (2) if possible. ditto. this is a problem for many folks who work in both the chromium and webkit repositories. levin's idea sounds best :) -darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Kenneth Rohde Christiansen Technical Lead / Senior Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Remove underscore check in check-webkit-style?
Date: Wed, 13 Jan 2010 15:49:05 -0800 From: David Levin le...@google.com 3) Stop checking code in gtk/qt platform directories for underscores? I think there are several other checks that code in some of these directories typically fail due to various issues (public api that should follow the standard public api format for that platform, etc.) I made a bug report for this issue: https://bugs.webkit.org/show_bug.cgi?id=33684 (This is distinct from the qt_ underscore issue, which has its own report: https://bugs.webkit.org/show_bug.cgi?id=33663 ) --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Remove underscore check in check-webkit-style?
Current check-webkit-style and the style bot complain if code uses identifiers with underscores in their names. It turns out our code does this fairly often, especially in Qt and Gtk specific code, for example to interface with unit testing frameworks. We could either: 1) Teach check-webkit-style about these cases 2) Remove the underscore check entirely My inclination is to do (2) because I haven't seen this check find many actual style problems. However, if we think that (1) is the better road, I'll be happy to make that happen. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Remove underscore check in check-webkit-style?
On Wed, Jan 13, 2010 at 3:43 PM, Adam Barth aba...@webkit.org wrote: Current check-webkit-style and the style bot complain if code uses identifiers with underscores in their names. It turns out our code does this fairly often, especially in Qt and Gtk specific code, for example to interface with unit testing frameworks. We could either: 1) Teach check-webkit-style about these cases 2) Remove the underscore check entirely My inclination is to do (2) because I haven't seen this check find many actual style problems. However, if we think that (1) is the better road, I'll be happy to make that happen. I frequently forget the underscore rule (since all the other code I work on prefers underscores). As a beneficiary of the style checker, I'd prefer to avoid (2) if possible. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Remove underscore check in check-webkit-style?
On Wed, Jan 13, 2010 at 4:17 PM, Evan Martin e...@chromium.org wrote: On Wed, Jan 13, 2010 at 3:43 PM, Adam Barth aba...@webkit.org wrote: Current check-webkit-style and the style bot complain if code uses identifiers with underscores in their names. It turns out our code does this fairly often, especially in Qt and Gtk specific code, for example to interface with unit testing frameworks. We could either: 1) Teach check-webkit-style about these cases 2) Remove the underscore check entirely My inclination is to do (2) because I haven't seen this check find many actual style problems. However, if we think that (1) is the better road, I'll be happy to make that happen. I frequently forget the underscore rule (since all the other code I work on prefers underscores). As a beneficiary of the style checker, I'd prefer to avoid (2) if possible. ditto. this is a problem for many folks who work in both the chromium and webkit repositories. levin's idea sounds best :) -darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
