Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?
Oh, I didn't see your second post either. Sounds like porting everything into Python would speed up new-run-webkit-tests? Then I'm all for it. I think other folks would be equally convinced as well if you could kindly measure the time difference between Ruby + Python + shell script implementation vs Python implementation. - Ryosuke On Wed, Sep 1, 2010 at 9:28 PM, Dirk Pranke dpra...@chromium.org wrote: Hi Sam, Did you see the reply I sent on this thread? There are actually decent reasons to rewrite the code into Python, to simplify and speed up the new-run-webkit-tests implementation. Given that, do you still object to the patch landing (since the work has already been done)? -- Dirk On Wed, Sep 1, 2010 at 7:40 PM, Sam Weinig sam.wei...@gmail.com wrote: Sorry, I seemed to have missed this thread. Please do not rewrite scripts just to rewrite them in a language you like. WebKit's dependency on Ruby is here to stay. Just because python is common at Google does not make it universal. -Sam On Wed, Sep 1, 2010 at 4:48 PM, TAMURA, Kent tk...@chromium.org wrote: Thanks. So porting PrettyPatch to Python will make good benefit and should have no drawbacks. I should go ahead. On Wed, Sep 1, 2010 at 09:21, William Siegrist wsiegr...@apple.com wrote: On Aug 31, 2010, at 4:43 PM, TAMURA, Kent wrote: Can we run python scripts on bugs.webkit.org server? Yes. -Bill -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?
Thanks. So porting PrettyPatch to Python will make good benefit and should have no drawbacks. I should go ahead. On Wed, Sep 1, 2010 at 09:21, William Siegrist wsiegr...@apple.com wrote: On Aug 31, 2010, at 4:43 PM, TAMURA, Kent wrote: Can we run python scripts on bugs.webkit.org server? Yes. -Bill -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?
Sorry, I seemed to have missed this thread. Please do not rewrite scripts just to rewrite them in a language you like. WebKit's dependency on Ruby is here to stay. Just because python is common at Google does not make it universal. -Sam On Wed, Sep 1, 2010 at 4:48 PM, TAMURA, Kent tk...@chromium.org wrote: Thanks. So porting PrettyPatch to Python will make good benefit and should have no drawbacks. I should go ahead. On Wed, Sep 1, 2010 at 09:21, William Siegrist wsiegr...@apple.comwrote: On Aug 31, 2010, at 4:43 PM, TAMURA, Kent wrote: Can we run python scripts on bugs.webkit.org server? Yes. -Bill -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?
Here are the list of files in the project which use ruby: Scripts/check-for-inappropriate-files-in-framework:#!/usr/bin/env ruby Scripts/check-for-webkit-framework-include-consistency:#!/usr/bin/env ruby Scripts/clean-header-guards:#!/usr/bin/ruby Scripts/roll-over-ChangeLogs:#!/usr/bin/env ruby iExploder/htdocs/iexploder.cgi:#!/usr/bin/ruby iExploder/htdocs/iexploder.rb:# These if statements are so that mod_ruby doesn't have to reload the files iExploder/htdocs/webserver.rb:#!/usr/bin/ruby iExploder/tools/lasthit.rb:#!/usr/bin/ruby iExploder/tools/osx_last_crash.rb:#!/usr/bin/ruby iExploder/tools/showtest.rb:#!/usr/bin/ruby -eric On Wed, Sep 1, 2010 at 7:40 PM, Sam Weinig sam.wei...@gmail.com wrote: Sorry, I seemed to have missed this thread. Please do not rewrite scripts just to rewrite them in a language you like. WebKit's dependency on Ruby is here to stay. Just because python is common at Google does not make it universal. -Sam On Wed, Sep 1, 2010 at 4:48 PM, TAMURA, Kent tk...@chromium.org wrote: Thanks. So porting PrettyPatch to Python will make good benefit and should have no drawbacks. I should go ahead. On Wed, Sep 1, 2010 at 09:21, William Siegrist wsiegr...@apple.com wrote: On Aug 31, 2010, at 4:43 PM, TAMURA, Kent wrote: Can we run python scripts on bugs.webkit.org server? Yes. -Bill -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?
Hi, On Tue, Aug 31, 2010 at 7:56 AM, TAMURA, Kent tk...@chromium.org wrote: Do we have any recommendation of programming language for scripts such as WebKitTools/Scripts? It seems new scripts are written by Python and Ruby code is very rare. Is it reasonable to port a Ruby script to Python? I tried to port PrettyPatch.rb to Python in https://bugs.webkit.org/show_bug.cgi?id=43617 in order to remove Ruby dependency for many developers and buildbots. However bdash objected it. Why Ruby to Python? There are also Perl scripts in WebKitTools/Scripts. Could you explain the benefits of converting Ruby scripts to Python? I agree that having to install Ruby, Python, and Perl is a burden for many Windows developers but most of us use Mac / Linux for WebKit development anyways. - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?
Hi Sam, Did you see the reply I sent on this thread? There are actually decent reasons to rewrite the code into Python, to simplify and speed up the new-run-webkit-tests implementation. Given that, do you still object to the patch landing (since the work has already been done)? -- Dirk On Wed, Sep 1, 2010 at 7:40 PM, Sam Weinig sam.wei...@gmail.com wrote: Sorry, I seemed to have missed this thread. Please do not rewrite scripts just to rewrite them in a language you like. WebKit's dependency on Ruby is here to stay. Just because python is common at Google does not make it universal. -Sam On Wed, Sep 1, 2010 at 4:48 PM, TAMURA, Kent tk...@chromium.org wrote: Thanks. So porting PrettyPatch to Python will make good benefit and should have no drawbacks. I should go ahead. On Wed, Sep 1, 2010 at 09:21, William Siegrist wsiegr...@apple.com wrote: On Aug 31, 2010, at 4:43 PM, TAMURA, Kent wrote: Can we run python scripts on bugs.webkit.org server? Yes. -Bill -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?
From reading this thread and the bug, it sounds like there is one key issue installing something new on build machines. As discussed before in regards to python, there was a desire not to go above a certain version so that the tiger build machine could run a script. That seemed reasonable to me. Similarly there is a desire in this case to avoid Ruby because it means installing something new on other build machines. This also seems reasonable to me. There are other issues that seem tangential which are being brought up and only confuse the subject for me: - Speed -- without numbers this is meaningless to me. - A hang that might be reduced -- since it will remain, it sounds like there is a deeper issue to fix. - People like python -- me too, but perhaps not a deciding factor. It probably didn't help that the subject of the email focuses on languages in a highlander smack down style as if there can be only one. Focusing again, given the build machine issue: - Is it best to have a separate script that is similar to PrettyPatch solve the issue? - Or replace the script? - Or can the dependency on PrettyPatch be controlled via a commandline option and just turned off on build machines? - Or have folks explain why they don't want to install more on their build machine? dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Script programming language: Perl, Python, or Ruby?
Do we have any recommendation of programming language for scripts such as WebKitTools/Scripts? It seems new scripts are written by Python and Ruby code is very rare. Is it reasonable to port a Ruby script to Python? I tried to port PrettyPatch.rb to Python in https://bugs.webkit.org/show_bug.cgi?id=43617 in order to remove Ruby dependency for many developers and buildbots. However bdash objected it. -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?
Oh, I should have mentioned that there is actually a compelling reason to port PrettyPatch over, namely that if we can port it to a Python library than we can avoid having to shell out to it from new-run-webkit-tests. Shelling out, in addition to being slower, seems to contribute to the Python multithreading deadlocking issues we've seen. -- Dirk On Tue, Aug 31, 2010 at 12:26 PM, Dirk Pranke dpra...@chromium.org wrote: I think generally most scripts are written in Python nowadays, and we have a large legacy of perl scripts that are getting ported over. bdash mentions in the bug that there are other scripts written in Ruby besides PrettyPatch, but that's news to me. What are they, and what are they used for? Is there a particular reason that they're in Ruby? I agree with Jeremy that, all other things being equal, fewer languages is better, and I'm not sure that Ruby offers many compelling advantages over Python (disclaimer: I personally like Ruby the language better than Python, although I have a lot more experience w/ Python than I do w/ Ruby). On Tue, Aug 31, 2010 at 7:56 AM, TAMURA, Kent tk...@chromium.org wrote: Do we have any recommendation of programming language for scripts such as WebKitTools/Scripts? It seems new scripts are written by Python and Ruby code is very rare. Is it reasonable to port a Ruby script to Python? I tried to port PrettyPatch.rb to Python in https://bugs.webkit.org/show_bug.cgi?id=43617 in order to remove Ruby dependency for many developers and buildbots. However bdash objected it. -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?
WebKitTools/iExploder has some ruby scripts. LayoutTests/platform/mac/fast/loader/resources/mimeTypeExamples/example-rb.rb is an empty file. I don't know others. PrettyPatch on Python would remove Ruby dependency from new-run-webkit-tests and webkit-patch. But I'm not sure if we can remove BugsSite/PrettyPatch. Can we run python scripts on bugs.webkit.org server? On Wed, Sep 1, 2010 at 04:26, Dirk Pranke dpra...@chromium.org wrote: I think generally most scripts are written in Python nowadays, and we have a large legacy of perl scripts that are getting ported over. bdash mentions in the bug that there are other scripts written in Ruby besides PrettyPatch, but that's news to me. What are they, and what are they used for? Is there a particular reason that they're in Ruby? I agree with Jeremy that, all other things being equal, fewer languages is better, and I'm not sure that Ruby offers many compelling advantages over Python (disclaimer: I personally like Ruby the language better than Python, although I have a lot more experience w/ Python than I do w/ Ruby). On Tue, Aug 31, 2010 at 7:56 AM, TAMURA, Kent tk...@chromium.org wrote: Do we have any recommendation of programming language for scripts such as WebKitTools/Scripts? It seems new scripts are written by Python and Ruby code is very rare. Is it reasonable to port a Ruby script to Python? I tried to port PrettyPatch.rb to Python in https://bugs.webkit.org/show_bug.cgi?id=43617 in order to remove Ruby dependency for many developers and buildbots. However bdash objected it. -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Script programming language: Perl, Python, or Ruby?
On Aug 31, 2010, at 4:43 PM, TAMURA, Kent wrote: Can we run python scripts on bugs.webkit.org server? Yes. -Bill ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
