[webkit-dev] SnowLeopard debug buildbot not there
tL;dr Why isn't there a SnowLeopard debug buildbot? Related: Why does the commit queue (appear) to only run release builds through tests? Details: Yesterday, I did a build of WebKit on SnowLeopard and hit ~12 crashes (mostly in inspector tests). Then I realized that we don't have such a bot, so perhaps that's why these crashes aren't getting noticed by people. It also looks like the commit queue only runs release builds. I have a concern that not having this allows the code to become less stable than it should be. thanks, dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] SnowLeopard debug buildbot not there
On 2011-03-10, at 12:08, David Levin wrote: tL;dr Why isn't there a SnowLeopard debug buildbot? Related: Why does the commit queue (appear) to only run release builds through tests? Details: Yesterday, I did a build of WebKit on SnowLeopard and hit ~12 crashes (mostly in inspector tests). Then I realized that we don't have such a bot, so perhaps that's why these crashes aren't getting noticed by people. It also looks like the commit queue only runs release builds. I have a concern that not having this allows the code to become less stable than it should be. The SnowLeopard Leaks bot builds and tests the debug configuration. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] SnowLeopard debug buildbot not there
On Thu, Mar 10, 2011 at 12:11 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-10, at 12:08, David Levin wrote: tL;dr Why isn't there a SnowLeopard debug buildbot? Related: Why does the commit queue (appear) to only run release builds through tests? Details: Yesterday, I did a build of WebKit on SnowLeopard and hit ~12 crashes (mostly in inspector tests). Then I realized that we don't have such a bot, so perhaps that's why these crashes aren't getting noticed by people. It also looks like the commit queue only runs release builds. I have a concern that not having this allows the code to become less stable than it should be. The SnowLeopard Leaks bot builds and tests the debug configuration. The problem with the leaks bot is that it's always red. At the moment it has 10792 leaks. Would it be possible to report the leaks in a separate column than the test failures/crashes? That way I could look at the failures/crashes column and see at-a-glance whether I'd broken the Debug build. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] SnowLeopard debug buildbot not there
On 2011-03-10, at 12:27, Adam Barth wrote: On Thu, Mar 10, 2011 at 12:11 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-10, at 12:08, David Levin wrote: tL;dr Why isn't there a SnowLeopard debug buildbot? Related: Why does the commit queue (appear) to only run release builds through tests? Details: Yesterday, I did a build of WebKit on SnowLeopard and hit ~12 crashes (mostly in inspector tests). Then I realized that we don't have such a bot, so perhaps that's why these crashes aren't getting noticed by people. It also looks like the commit queue only runs release builds. I have a concern that not having this allows the code to become less stable than it should be. The SnowLeopard Leaks bot builds and tests the debug configuration. The problem with the leaks bot is that it's always red. At the moment it has 10792 leaks. Fixing the leaks would help address this, and is obviously beneficial in itself. It certainly didn't have anywhere near this number of leaks last week. Would it be possible to report the leaks in a separate column than the test failures/crashes? That way I could look at the failures/crashes column and see at-a-glance whether I'd broken the Debug build. Like most things, it's possible but not particularly easy. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] SnowLeopard debug buildbot not there
On Thu, Mar 10, 2011 at 12:33 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-10, at 12:27, Adam Barth wrote: On Thu, Mar 10, 2011 at 12:11 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-10, at 12:08, David Levin wrote: tL;dr Why isn't there a SnowLeopard debug buildbot? Related: Why does the commit queue (appear) to only run release builds through tests? Details: Yesterday, I did a build of WebKit on SnowLeopard and hit ~12 crashes (mostly in inspector tests). Then I realized that we don't have such a bot, so perhaps that's why these crashes aren't getting noticed by people. It also looks like the commit queue only runs release builds. I have a concern that not having this allows the code to become less stable than it should be. The SnowLeopard Leaks bot builds and tests the debug configuration. The problem with the leaks bot is that it's always red. At the moment it has 10792 leaks. Fixing the leaks would help address this, and is obviously beneficial in itself. It certainly didn't have anywhere near this number of leaks last week. What's the best way to tack down when that regression occurred? I scrolled to the end of the waterfall for that builder http://build.webkit.org/waterfall?last_time=1299183958show=SnowLeopard%20Intel%20Leaks and the earliest build I could find had 10344 leaks. Would it be possible to report the leaks in a separate column than the test failures/crashes? That way I could look at the failures/crashes column and see at-a-glance whether I'd broken the Debug build. Like most things, it's possible but not particularly easy. Oh, I see that the bot turns golden when there are only leaks but no test failures. Can it turn green instead? (Or maybe have the column turn green but the leaks box turn gold?) I'm showing my buildbox ignorance. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] SnowLeopard debug buildbot not there
On 2011-03-10, at 12:40, Adam Barth wrote: On Thu, Mar 10, 2011 at 12:33 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-10, at 12:27, Adam Barth wrote: On Thu, Mar 10, 2011 at 12:11 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-10, at 12:08, David Levin wrote: tL;dr Why isn't there a SnowLeopard debug buildbot? Related: Why does the commit queue (appear) to only run release builds through tests? Details: Yesterday, I did a build of WebKit on SnowLeopard and hit ~12 crashes (mostly in inspector tests). Then I realized that we don't have such a bot, so perhaps that's why these crashes aren't getting noticed by people. It also looks like the commit queue only runs release builds. I have a concern that not having this allows the code to become less stable than it should be. The SnowLeopard Leaks bot builds and tests the debug configuration. The problem with the leaks bot is that it's always red. At the moment it has 10792 leaks. Fixing the leaks would help address this, and is obviously beneficial in itself. It certainly didn't have anywhere near this number of leaks last week. What's the best way to tack down when that regression occurred? I scrolled to the end of the waterfall for that builder http://build.webkit.org/waterfall?last_time=1299183958show=SnowLeopard%20Intel%20Leaks and the earliest build I could find had 10344 leaks. Hrm. It used to be possible to track things down by looking at the historical results at http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/, but we don't appear to keep the results for very long any more. It would be possible to build and bisect locally to track down when they were introduced. However, given the sheer volume of leaks I suspect it would be relatively easy for someone familiar with whatever code is leaking most prominently to track down the leak. Would it be possible to report the leaks in a separate column than the test failures/crashes? That way I could look at the failures/crashes column and see at-a-glance whether I'd broken the Debug build. Like most things, it's possible but not particularly easy. Oh, I see that the bot turns golden when there are only leaks but no test failures. Can it turn green instead? (Or maybe have the column turn green but the leaks box turn gold?) I'm showing my buildbox ignorance. I don't recall whether this is possible. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] SnowLeopard debug buildbot not there
On Mar 10, 2011, at 3:40 PM, Adam Barth wrote: On Thu, Mar 10, 2011 at 12:33 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-10, at 12:27, Adam Barth wrote: On Thu, Mar 10, 2011 at 12:11 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-10, at 12:08, David Levin wrote: tL;dr Why isn't there a SnowLeopard debug buildbot? Related: Why does the commit queue (appear) to only run release builds through tests? Details: Yesterday, I did a build of WebKit on SnowLeopard and hit ~12 crashes (mostly in inspector tests). Then I realized that we don't have such a bot, so perhaps that's why these crashes aren't getting noticed by people. It also looks like the commit queue only runs release builds. I have a concern that not having this allows the code to become less stable than it should be. The SnowLeopard Leaks bot builds and tests the debug configuration. The problem with the leaks bot is that it's always red. At the moment it has 10792 leaks. Fixing the leaks would help address this, and is obviously beneficial in itself. It certainly didn't have anywhere near this number of leaks last week. What's the best way to tack down when that regression occurred? I scrolled to the end of the waterfall for that builder http://build.webkit.org/waterfall?last_time=1299183958show=SnowLeopard%20Intel%20Leaks and the earliest build I could find had 10344 leaks. You can look at a page like: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks?numbuilds=500 And then you can start manually decreasing the build number on pages like: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15273 -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] SnowLeopard debug buildbot not there
On Thu, Mar 10, 2011 at 12:48 PM, Adam Roben aro...@apple.com wrote: On Mar 10, 2011, at 3:40 PM, Adam Barth wrote: On Thu, Mar 10, 2011 at 12:33 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-10, at 12:27, Adam Barth wrote: On Thu, Mar 10, 2011 at 12:11 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-10, at 12:08, David Levin wrote: tL;dr Why isn't there a SnowLeopard debug buildbot? Related: Why does the commit queue (appear) to only run release builds through tests? Details: Yesterday, I did a build of WebKit on SnowLeopard and hit ~12 crashes (mostly in inspector tests). Then I realized that we don't have such a bot, so perhaps that's why these crashes aren't getting noticed by people. It also looks like the commit queue only runs release builds. I have a concern that not having this allows the code to become less stable than it should be. The SnowLeopard Leaks bot builds and tests the debug configuration. The problem with the leaks bot is that it's always red. At the moment it has 10792 leaks. Fixing the leaks would help address this, and is obviously beneficial in itself. It certainly didn't have anywhere near this number of leaks last week. What's the best way to tack down when that regression occurred? I scrolled to the end of the waterfall for that builder http://build.webkit.org/waterfall?last_time=1299183958show=SnowLeopard%20Intel%20Leaks and the earliest build I could find had 10344 leaks. You can look at a page like: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks?numbuilds=500 And then you can start manually decreasing the build number on pages like: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15273 I feel like I should write a webkit-patch command to do this. Looks like http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15164 was (relatively) clean. Starting at http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15165, there's a fog of tons of crashes. When we finally emerge from the fog at http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15220, we have 14437 leaks. So, that's a regression range of 79781--79968. :-( Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] SnowLeopard debug buildbot not there
On Mar 10, 2011, at 3:51 PM, Adam Roben wrote: I'm also planning to file a bug about CoreText-related leaks beneath GlyphPage::fill. http://webkit.org/b/56136 CoreText-related leaks seen beneath GlyphPage::fill -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] SnowLeopard debug buildbot not there
All these inspector's crashes were introduced at r80478 They were not detected immediately because: 1) the noncore Intel Leopard Debug Test box are constantly red; 2) most of the time it has a problem with svn; 3) the box was offline? for a week from mar 1 to mar 8. (~800 patches) Patch was rolled out today. Regards, Tim. On Thu, Mar 10, 2011 at 11:08 PM, David Levin le...@google.com wrote: tL;dr Why isn't there a SnowLeopard debug buildbot? Related: Why does the commit queue (appear) to only run release builds through tests? Details: Yesterday, I did a build of WebKit on SnowLeopard and hit ~12 crashes (mostly in inspector tests). Then I realized that we don't have such a bot, so perhaps that's why these crashes aren't getting noticed by people. It also looks like the commit queue only runs release builds. I have a concern that not having this allows the code to become less stable than it should be. thanks, dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
