[webkit-dev] Tips on why run-webkit-tests is not working for me?
I’m trying to test some changes on my Mountain Lion Mac, using the Mac port. When I call run-webkit-tests it fails with file not found. Using port 'mac-mountainlion' Test configuration: mountainlion, x86_64, debug Placing test results in /Users/darin/Build/Debug/layout-test-results Baseline search path: mac - generic Using Debug build Pixel tests disabled Regular timeout: 35000, slow test timeout: 175000 Command line: /Users/darin/Build/Debug/DumpRenderTree - Found 31448 tests; running 29263, skipping 2185. Checking build ... OSError raised: [Errno 2] No such file or directory File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py, line 110, in run unexpected_result_count = manager.run(args) File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py, line 404, in run if not self._set_up_run(): File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py, line 355, in _set_up_run if not self._port.check_build(self.needs_servers()): File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/port/base.py, line 240, in check_build if not self._check_port_build(): File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/port/mac.py, line 162, in _check_port_build return self._build_java_test_support() File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/port/mac.py, line 136, in _build_java_test_support if self._executive.run_command(build_java, return_exit_code=True): # Paths are absolute, so we don't need to set a cwd. File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/common/system/executive.py, line 402, in run_command close_fds=self._should_close_fds()) File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/common/system/executive.py, line 458, in popen return subprocess.Popen(*args, **kwargs) File /System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py, line 679, in __init__ errread, errwrite) File /System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py, line 1228, in _execute_child raise child_exception Failed to execute Tools/Scripts/new-run-webkit-tests at /Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/Tools/Scripts/run-webkit-tests line 126. Anyone know why? -- Darin___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?
That stack is confusing. It looks like it's in Mac._build_java_test_support: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py#L133 But that shouldn't be trying to execute run-webkit-tests? Perhaps make is missing? or the java directory its trying to build is missing and it's just printing the wrong path? On Wed, Oct 3, 2012 at 9:05 AM, Darin Adler da...@apple.com wrote: I’m trying to test some changes on my Mountain Lion Mac, using the Mac port. When I call run-webkit-tests it fails with file not found. Using port 'mac-mountainlion' Test configuration: mountainlion, x86_64, debug Placing test results in /Users/darin/Build/Debug/layout-test-results Baseline search path: mac - generic Using Debug build Pixel tests disabled Regular timeout: 35000, slow test timeout: 175000 Command line: /Users/darin/Build/Debug/DumpRenderTree - Found 31448 tests; running 29263, skipping 2185. Checking build ... OSError raised: [Errno 2] No such file or directory File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py, line 110, in run unexpected_result_count = manager.run(args) File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py, line 404, in run if not self._set_up_run(): File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py, line 355, in _set_up_run if not self._port.check_build(self.needs_servers()): File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/port/base.py, line 240, in check_build if not self._check_port_build(): File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/port/mac.py, line 162, in _check_port_build return self._build_java_test_support() File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/port/mac.py, line 136, in _build_java_test_support if self._executive.run_command(build_java, return_exit_code=True): # Paths are absolute, so we don't need to set a cwd. File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/common/system/executive.py, line 402, in run_command close_fds=self._should_close_fds()) File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/common/system/executive.py, line 458, in popen return subprocess.Popen(*args, **kwargs) File /System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py, line 679, in __init__ errread, errwrite) File /System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py, line 1228, in _execute_child raise child_exception Failed to execute Tools/Scripts/new-run-webkit-tests at /Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/Tools/Scripts/run-webkit-tests line 126. Anyone know why? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?
This is Executive.run_command: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/executive.py#L378 I would suggest running test-webkitpy (which will go through and delete any orphaned .pyc files which could be confusing things). -eric On Wed, Oct 3, 2012 at 9:19 AM, Eric Seidel e...@webkit.org wrote: That stack is confusing. It looks like it's in Mac._build_java_test_support: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py#L133 But that shouldn't be trying to execute run-webkit-tests? Perhaps make is missing? or the java directory its trying to build is missing and it's just printing the wrong path? On Wed, Oct 3, 2012 at 9:05 AM, Darin Adler da...@apple.com wrote: I’m trying to test some changes on my Mountain Lion Mac, using the Mac port. When I call run-webkit-tests it fails with file not found. Using port 'mac-mountainlion' Test configuration: mountainlion, x86_64, debug Placing test results in /Users/darin/Build/Debug/layout-test-results Baseline search path: mac - generic Using Debug build Pixel tests disabled Regular timeout: 35000, slow test timeout: 175000 Command line: /Users/darin/Build/Debug/DumpRenderTree - Found 31448 tests; running 29263, skipping 2185. Checking build ... OSError raised: [Errno 2] No such file or directory File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py, line 110, in run unexpected_result_count = manager.run(args) File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py, line 404, in run if not self._set_up_run(): File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py, line 355, in _set_up_run if not self._port.check_build(self.needs_servers()): File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/port/base.py, line 240, in check_build if not self._check_port_build(): File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/port/mac.py, line 162, in _check_port_build return self._build_java_test_support() File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/layout_tests/port/mac.py, line 136, in _build_java_test_support if self._executive.run_command(build_java, return_exit_code=True): # Paths are absolute, so we don't need to set a cwd. File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/common/system/executive.py, line 402, in run_command close_fds=self._should_close_fds()) File /Users/darin/Safari/OpenSource/Tools/Scripts/webkitpy/common/system/executive.py, line 458, in popen return subprocess.Popen(*args, **kwargs) File /System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py, line 679, in __init__ errread, errwrite) File /System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py, line 1228, in _execute_child raise child_exception Failed to execute Tools/Scripts/new-run-webkit-tests at /Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/Tools/Scripts/run-webkit-tests line 126. Anyone know why? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?
03.10.2012, в 9:19, Eric Seidel e...@webkit.org написал(а): Perhaps make is missing? or the java directory its trying to build is missing and it's just printing the wrong path? Isn't make part of Xcode command line utilities? If that's the issue indeed, the fix is to change the script to use xcrun make here, and installing command line utilities is a workaround. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?
Think Eric and Alexey identified the problem here ... -- Dirk On Wed, Oct 3, 2012 at 9:44 AM, Alexey Proskuryakov a...@webkit.org wrote: 03.10.2012, в 9:19, Eric Seidel e...@webkit.org написал(а): Perhaps make is missing? or the java directory its trying to build is missing and it's just printing the wrong path? Isn't make part of Xcode command line utilities? If that's the issue indeed, the fix is to change the script to use xcrun make here, and installing command line utilities is a workaround. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?
On Oct 3, 2012, at 9:10 AM, Ryosuke Niwa rn...@webkit.org wrote: Could you tell us what your directory structure look like and where you're executing that command? Looks like a path confusion. My WebKit source tree is in ~/Safari/OpenSource and my build products are in ~/Builds. I am running the script inside the ~/Safari/OpenSource directory. On Oct 3, 2012, at 9:11 AM, Ojan Vafai o...@chromium.org wrote: I'm guessing there's something about your checkout that is confusing the code that finds the path to run-webkit-tests. Does /Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/Tools/Scripts/run-webkit-tests actually exist or is that path incorrect? That path is correct, although I don’t know where it’s coming from. Maybe related to how I originally checked out my tree from Subversion. On Oct 3, 2012, at 9:19 AM, Eric Seidel e...@webkit.org wrote: It looks like it's in Mac._build_java_test_support: I don’t think I have Java installed on this computer. Maybe that’s somehow related to the problem. I would suggest running test-webkitpy (which will go through and delete any orphaned .pyc files which could be confusing things). OK, I’ll do that when I get a chance. Perhaps make is missing? I often use make from the command line to build, so it’s in my path. I wish the error message made it clearer what file couldn’t be found. The thing that changed most recently on my machine is how Xcode is installed, so I’m guessing the problem is somehow related to that, since I’ve run the tests many times in the past. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?
I should note that webkit-patch does do some magic to find it's checkout. Its possible it's somehow confused by your svn setup? I don't personally use the svn codepaths very often. In case this is useful, here is some more context on what webkitpy is trying to do: Most webkitpy clients, including webkit-patch, create a Host object: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/host.py#L128 which includes an SCM object, which is created by looking for your checkout_root via the SCMDetector: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/scm/detection.py#L44 In your case it likely decides it's SVN: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py#L85 and then walks up to find the root of the checkout: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py#L112 It has some fancy logic to handle nested SVN checkouts. This is designed to emulate the wkdirs.pm behavior from all the perl-scripts of yor. (I really like that I can run build-webkit from any command-prompt and have it do the right thing. webkit-patch tries to behave the same.) On Wed, Oct 3, 2012 at 3:39 PM, Darin Adler da...@apple.com wrote: On Oct 3, 2012, at 9:10 AM, Ryosuke Niwa rn...@webkit.org wrote: Could you tell us what your directory structure look like and where you're executing that command? Looks like a path confusion. My WebKit source tree is in ~/Safari/OpenSource and my build products are in ~/Builds. I am running the script inside the ~/Safari/OpenSource directory. On Oct 3, 2012, at 9:11 AM, Ojan Vafai o...@chromium.org wrote: I'm guessing there's something about your checkout that is confusing the code that finds the path to run-webkit-tests. Does /Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/Tools/Scripts/run-webkit-tests actually exist or is that path incorrect? That path is correct, although I don’t know where it’s coming from. Maybe related to how I originally checked out my tree from Subversion. On Oct 3, 2012, at 9:19 AM, Eric Seidel e...@webkit.org wrote: It looks like it's in Mac._build_java_test_support: I don’t think I have Java installed on this computer. Maybe that’s somehow related to the problem. I would suggest running test-webkitpy (which will go through and delete any orphaned .pyc files which could be confusing things). OK, I’ll do that when I get a chance. Perhaps make is missing? I often use make from the command line to build, so it’s in my path. I wish the error message made it clearer what file couldn’t be found. The thing that changed most recently on my machine is how Xcode is installed, so I’m guessing the problem is somehow related to that, since I’ve run the tests many times in the past. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?
On Wed, Oct 3, 2012 at 3:39 PM, Darin Adler da...@apple.com wrote: On Oct 3, 2012, at 9:10 AM, Ryosuke Niwa rn...@webkit.org wrote: Could you tell us what your directory structure look like and where you're executing that command? Looks like a path confusion. My WebKit source tree is in ~/Safari/OpenSource and my build products are in ~/Builds. I am running the script inside the ~/Safari/OpenSource directory. On Oct 3, 2012, at 9:11 AM, Ojan Vafai o...@chromium.org wrote: I'm guessing there's something about your checkout that is confusing the code that finds the path to run-webkit-tests. Does /Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/Tools/Scripts/run-webkit-tests actually exist or is that path incorrect? That path is correct, although I don’t know where it’s coming from. Maybe related to how I originally checked out my tree from Subversion. On Oct 3, 2012, at 9:19 AM, Eric Seidel e...@webkit.org wrote: It looks like it's in Mac._build_java_test_support: I don’t think I have Java installed on this computer. Maybe that’s somehow related to the problem. I would suggest running test-webkitpy (which will go through and delete any orphaned .pyc files which could be confusing things). OK, I’ll do that when I get a chance. Perhaps make is missing? I often use make from the command line to build, so it’s in my path. I wish the error message made it clearer what file couldn’t be found. The thing that changed most recently on my machine is how Xcode is installed, so I’m guessing the problem is somehow related to that, since I’ve run the tests many times in the past. I can look into making the error clearer, but it's trying to run /usr/bin/make, -C /Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/LayoutTests/java] (approximately). It's probably bad that it's hardcoded to look in /usr/bin; is that your problem? Try changing the lines of code Eric linked to ... -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?
On Wed, Oct 3, 2012 at 4:18 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Oct 3, 2012 at 3:39 PM, Darin Adler da...@apple.com wrote: On Oct 3, 2012, at 9:10 AM, Ryosuke Niwa rn...@webkit.org wrote: Could you tell us what your directory structure look like and where you're executing that command? Looks like a path confusion. My WebKit source tree is in ~/Safari/OpenSource and my build products are in ~/Builds. I am running the script inside the ~/Safari/OpenSource directory. On Oct 3, 2012, at 9:11 AM, Ojan Vafai o...@chromium.org wrote: I'm guessing there's something about your checkout that is confusing the code that finds the path to run-webkit-tests. Does /Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/Tools/Scripts/run-webkit-tests actually exist or is that path incorrect? That path is correct, although I don’t know where it’s coming from. Maybe related to how I originally checked out my tree from Subversion. On Oct 3, 2012, at 9:19 AM, Eric Seidel e...@webkit.org wrote: It looks like it's in Mac._build_java_test_support: I don’t think I have Java installed on this computer. Maybe that’s somehow related to the problem. I would suggest running test-webkitpy (which will go through and delete any orphaned .pyc files which could be confusing things). OK, I’ll do that when I get a chance. Perhaps make is missing? I often use make from the command line to build, so it’s in my path. I wish the error message made it clearer what file couldn’t be found. The thing that changed most recently on my machine is how Xcode is installed, so I’m guessing the problem is somehow related to that, since I’ve run the tests many times in the past. I can look into making the error clearer, but it's trying to run /usr/bin/make, -C /Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/LayoutTests/java] (approximately). It's probably bad that it's hardcoded to look in /usr/bin; is that your problem? Try changing the lines of code Eric linked to ... And if you're still having problems feel free to contact me off-list (on #irc or whatever). -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?
On Oct 3, 2012, at 4:18 PM, Dirk Pranke dpra...@chromium.org wrote: it's trying to run /usr/bin/make, -C /Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/LayoutTests/java] (approximately). It's probably bad that it's hardcoded to look in /usr/bin; is that your problem? I’ll check. I think it is. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
