Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
On Tue, Apr 24, 2012 at 6:14 AM, Adam Roben aro...@webkit.org wrote: On Fri, Mar 16, 2012 at 5:40 PM, Adam Barth aba...@webkit.org wrote: On Fri, Mar 16, 2012 at 2:32 PM, Ryosuke Niwa rn...@webkit.org wrote: Can we do some Bugzilla integration as Jarred suggested? If you're excited about using GitHub, you should feel free to do that work. It sounds like there is already work going on on GitHub (e.g., the iframe seamless support) even though this integration hasn't yet been built. I echo Ariya and Ryosuke's concern that the reduced visibility of that work makes it harder for WebKit contributors to provide feedback, or even to realize that the work is going on. Is there anyone working on improving the integration between GitHub and our current tools so that work that occurs there can be as easily discovered as work that goes on in bugs.webkit.org? I don't believe so. The iframe seamless work, in particular, was announced on webkit-dev, so folks shouldn't have trouble finding it. Some (small) parts of the branch have landed in trunk, but we put them through the normal bugs.webkit.org review process. My sense is that we're still experimenting with GitHub, so investing in integration still seems a bit premature. GitHub certainly made it easy for me to contribute the navigation part of seamless to Eric's branch, which seems like a win over him using SVN, patch files, or even git locally. I'll update the wiki after seamless lands to reflect what we've learned. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
On Fri, Mar 16, 2012 at 5:40 PM, Adam Barth aba...@webkit.org wrote: On Fri, Mar 16, 2012 at 2:32 PM, Ryosuke Niwa rn...@webkit.org wrote: Can we do some Bugzilla integration as Jarred suggested? If you're excited about using GitHub, you should feel free to do that work. It sounds like there is already work going on on GitHub (e.g., the iframe seamless support) even though this integration hasn't yet been built. I echo Ariya and Ryosuke's concern that the reduced visibility of that work makes it harder for WebKit contributors to provide feedback, or even to realize that the work is going on. Is there anyone working on improving the integration between GitHub and our current tools so that work that occurs there can be as easily discovered as work that goes on in bugs.webkit.org? -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
16.03.2012, 04:41, Adam Barth aba...@webkit.org: Hi webkit-dev, After reading last week's discussion about switching the project to git, I wondered if it would be possible to get some of the benefits of git-style development without forcing everyone to switch to git. One of the benefits of git-style development is the ability to review a series of patches at once. GitHub has some nice tools to reviewing pull requests, so I wrote up a short wiki page describing how someone might use GitHub to contribute to WebKit: https://trac.webkit.org/wiki/UsingGitHub I'm not sure we'll want to switch the whole project over to GitHub any time soon, but it might be something that folks who like git might want to experiment with. Don't you consider using Gerrit[1]? It's more effective review tool for git. [1] http://code.google.com/p/gerrit/ -- Regards, Konstantin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
On Fri, Mar 16, 2012 at 6:50 PM, Konstantin Tokarev annu...@yandex.ru wrote: 16.03.2012, 04:41, Adam Barth aba...@webkit.org: Hi webkit-dev, After reading last week's discussion about switching the project to git, I wondered if it would be possible to get some of the benefits of git-style development without forcing everyone to switch to git. One of the benefits of git-style development is the ability to review a series of patches at once. GitHub has some nice tools to reviewing pull requests, so I wrote up a short wiki page describing how someone might use GitHub to contribute to WebKit: https://trac.webkit.org/wiki/UsingGitHub I'm not sure we'll want to switch the whole project over to GitHub any time soon, but it might be something that folks who like git might want to experiment with. Don't you consider using Gerrit[1]? It's more effective review tool for git. The hardest part would be finishing the setup and making it up and running. Unlike the build slaves which can go down and lost sometimes, The code review records need to be more permanent since people want to read the conversation and see how decisions were made. That's being said, I personally agree that Gerrit can be a great choice. Starting from an experiment like Adam is suggesting to GitHub won't hurt, if someone does setup the server. -- morrita [1] http://code.google.com/p/gerrit/ -- Regards, Konstantin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
On 16 March 2012 18:34, Ryosuke Niwa rn...@webkit.org wrote: If some reviewer and committer decide to use this process, where can I see review comments and other discussions? See point 3 of Landing your code. Reviewer adds a link to pull request in changelog. Would they still be on Bugzilla? I suppose, they'll be only on github. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
On Fri, Mar 16, 2012 at 12:20 PM, John Yani van...@gmail.com wrote: On 16 March 2012 18:34, Ryosuke Niwa rn...@webkit.org wrote: If some reviewer and committer decide to use this process, where can I see review comments and other discussions? See point 3 of Landing your code. Reviewer adds a link to pull request in changelog. If you're not familiar with GitHub, a pull request is something like a code review. Here's an example WebKit pull request that Eric and I did to experiment with the process: https://github.com/eseidel/webkit/pull/1 It's got all the usual code review features, including line-by-line comments: https://github.com/abarth/webkit/commit/d1ade93003a6c4d83a9ce3fda0d643785a171a8d Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
On Fri, Mar 16, 2012 at 12:41 PM, Ariya Hidayat ariya.hida...@gmail.com wrote: See point 3 of Landing your code. Reviewer adds a link to pull request in changelog. But now it means I have to search in two places: Bugzilla and Github, in case I want to look up some past issues/problems. GitHub does have an issue tracker, but I'm not suggesting we use that. All issues/problems should still be filed in bugs.webkit.org. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
On Fri, Mar 16, 2012 at 3:41 PM, Ariya Hidayat ariya.hida...@gmail.comwrote: See point 3 of Landing your code. Reviewer adds a link to pull request in changelog. But now it means I have to search in two places: Bugzilla and Github, in case I want to look up some past issues/problems. In fact, Github does not a way to search for review comments. GitHub's API has hooks/events for comments on issues PRs to where it would be possible to integrate WebKit's GitHub mirror with Bugzilla so that all comments on PRs could post back to the related Bugzilla bug. Some convention would be necessary in the PR title or description to figure out which bug # it relates to, and a little work would be necessary to write out the comment into Bugzilla with some code for context (by taking the diff that's sitting on GitHub). Definitely work involved, but doable. -- Ariya Hidayat, http://ariya.ofilabs.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
Bugs.webkit.org has an integrated bug tracking and code review tool. I find this integration is good as it stands. I use git for development and don't think there's anything wrong with the current tools. Konrad Sent from my BlackBerry on the Rogers Wireless Network From: Jarred Nicholls [mailto:jar...@webkit.org] Sent: Friday, March 16, 2012 03:50 PM To: Ariya Hidayat ariya.hida...@gmail.com Cc: webkit-dev@lists.webkit.org webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental) On Fri, Mar 16, 2012 at 3:41 PM, Ariya Hidayat ariya.hida...@gmail.commailto:ariya.hida...@gmail.com wrote: See point 3 of Landing your code. Reviewer adds a link to pull request in changelog. But now it means I have to search in two places: Bugzilla and Github, in case I want to look up some past issues/problems. In fact, Github does not a way to search for review comments. GitHub's API has hooks/events for comments on issues PRs to where it would be possible to integrate WebKit's GitHub mirror with Bugzilla so that all comments on PRs could post back to the related Bugzilla bug. Some convention would be necessary in the PR title or description to figure out which bug # it relates to, and a little work would be necessary to write out the comment into Bugzilla with some code for context (by taking the diff that's sitting on GitHub). Definitely work involved, but doable. -- Ariya Hidayat, http://ariya.ofilabs.com ___ webkit-dev mailing list webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev - This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
GitHub's API has hooks/events for comments on issues PRs to where it would be possible to integrate WebKit's GitHub mirror with Bugzilla so that all comments on PRs could post back to the related Bugzilla bug. Some convention would be necessary in the PR title or description to figure out which bug # it relates to, and a little work would be necessary to write out the comment into Bugzilla with some code for context (by taking the diff that's sitting on GitHub). Found the API: http://developer.github.com/v3/pulls/comments/ (in case someone interested in building the cross-ref/integration with Bugzilla). -- Ariya Hidayat, http://ariya.ofilabs.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
On Mar 16, 2012 12:47 PM, Adam Barth aba...@webkit.org wrote: On Fri, Mar 16, 2012 at 12:41 PM, Ariya Hidayat ariya.hida...@gmail.com wrote: See point 3 of Landing your code. Reviewer adds a link to pull request in changelog. But now it means I have to search in two places: Bugzilla and Github, in case I want to look up some past issues/problems. GitHub does have an issue tracker, but I'm not suggesting we use that. All issues/problems should still be filed in bugs.webkit.org. I'm more concerned about the visibility of review comments. Right now, all review comments are pushed to me by emails as long as I'm cc'ed on the bug. In fact, that's the way I realize problems with some patches. But it seems like that isn't the case for patches that go through this process. Can we do some Bugzilla integration as Jarred suggested? - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
On Fri, Mar 16, 2012 at 2:32 PM, Ryosuke Niwa rn...@webkit.org wrote: Can we do some Bugzilla integration as Jarred suggested? If you're excited about using GitHub, you should feel free to do that work. Note: I'm not advocating for the use of GitHub. I'm just documenting a way that contributors can experiment with using GitHub to contribute to WebKit that's consistent with the current guidelines on contributing code to the project. (I tried to be clear in my initial email that I'm not advocating for this approach.) Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
Okay, thanks for the clarification. I'm not particularly interested in using this approach myself. I just wanted to make sure that I can see review comments for bugs I'm cc'ed on before patches are landed if some contrinutors do decide to experiment with this approach. - Ryosuke On Mar 16, 2012 2:40 PM, Adam Barth aba...@webkit.org wrote: On Fri, Mar 16, 2012 at 2:32 PM, Ryosuke Niwa rn...@webkit.org wrote: Can we do some Bugzilla integration as Jarred suggested? If you're excited about using GitHub, you should feel free to do that work. Note: I'm not advocating for the use of GitHub. I'm just documenting a way that contributors can experiment with using GitHub to contribute to WebKit that's consistent with the current guidelines on contributing code to the project. (I tried to be clear in my initial email that I'm not advocating for this approach.) Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Using GitHub to Contribute to WebKit (Experimental)
Hi webkit-dev, After reading last week's discussion about switching the project to git, I wondered if it would be possible to get some of the benefits of git-style development without forcing everyone to switch to git. One of the benefits of git-style development is the ability to review a series of patches at once. GitHub has some nice tools to reviewing pull requests, so I wrote up a short wiki page describing how someone might use GitHub to contribute to WebKit: https://trac.webkit.org/wiki/UsingGitHub I'm not sure we'll want to switch the whole project over to GitHub any time soon, but it might be something that folks who like git might want to experiment with. Happy hacking, Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
