[webkit-dev] Waiting time for patch with commit? status.
Hello, If I flag a patch with commit?, do I need to notify some commiters? Or are those commit? patches get periodically processed by someone, I just need to wait. If the latter is the case, what's the average waiting time. Thanks. Jia___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Waiting time for patch with commit? status.
Sometimes some individuals take it upon themselves to process all the commit-queue? patches, but I don't think we have a formal process like we do with reviews. Pinging on the bug and/or on the #webkit IRC channel are both acceptable. On Tue, Nov 30, 2010 at 8:40 AM, Jia Pu j...@apple.com wrote: Hello, If I flag a patch with commit?, do I need to notify some commiters? Or are those commit? patches get periodically processed by someone, I just need to wait. If the latter is the case, what's the average waiting time. Thanks. Jia ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Waiting time for patch with commit? status.
Marking commit-queue? is just like marking review?. Mails get sent, but you often have to bug people to get your review+ or commit-queue+. -eric On Tue, Nov 30, 2010 at 8:40 AM, Jia Pu j...@apple.com wrote: Hello, If I flag a patch with commit?, do I need to notify some commiters? Or are those commit? patches get periodically processed by someone, I just need to wait. If the latter is the case, what's the average waiting time. Thanks. Jia ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Waiting time for patch with commit? status.
I don't know if my behavior is typical but I almost never scan the commit queue. I occasionally scan the review queue. So changing an already r+'ed bug to have cq? may not get noticed. I'd ping someone to be sure (and there are more committers than reviewers so you have more options even). dave On Tue, Nov 30, 2010 at 10:58 AM, Eric Seidel e...@webkit.org wrote: Marking commit-queue? is just like marking review?. Mails get sent, but you often have to bug people to get your review+ or commit-queue+. -eric On Tue, Nov 30, 2010 at 8:40 AM, Jia Pu j...@apple.com wrote: Hello, If I flag a patch with commit?, do I need to notify some commiters? Or are those commit? patches get periodically processed by someone, I just need to wait. If the latter is the case, what's the average waiting time. Thanks. Jia ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
