Re: [webkit-dev] questions about allow-tabs
On Thu, Jan 14, 2010 at 9:05 PM, David Kilzer ddkil...@webkit.org wrote: On Thu, January 14, 2010 at 6:59:17 PM, Chris Jerdonek wrote: While I'm asking, I might as well also ask -- what other subversion properties do we use? In the past, svn:eol-style has been applied so that when files are checked out on Windows, they have the proper line endings. There is also a concerted effort to keep svn:mime-type set correctly on *-expected.png results for pixel tests committed via git. Thanks a lot for the response, David. To add to the list, svn:executable is another one. --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] questions about allow-tabs
On Fri, January 15, 2010 1:52:19 PM, Chris Jerdonek wrote: On Thu, Jan 14, 2010 at 9:05 PM, David Kilzer wrote: On Thu, January 14, 2010 at 6:59:17 PM, Chris Jerdonek wrote: While I'm asking, I might as well also ask -- what other subversion properties do we use? In the past, svn:eol-style has been applied so that when files are checked out on Windows, they have the proper line endings. There is also a concerted effort to keep svn:mime-type set correctly on *-expected.png results for pixel tests committed via git. Thanks a lot for the response, David. To add to the list, svn:executable is another one. Yes, scripts don't work very well without execute permissions. :) However, the git-svn script is smart enough to set that one, though. The others you don't get for free when using git to push patches to an svn repository. Dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] questions about allow-tabs
On Fri, Jan 15, 2010 at 2:01 PM, David Kilzer ddkil...@webkit.org wrote: On Fri, January 15, 2010 1:52:19 PM, Chris Jerdonek wrote: Thanks a lot for the response, David. To add to the list, svn:executable is another one. Yes, scripts don't work very well without execute permissions. :) However, the git-svn script is smart enough to set that one, though. The others you don't get for free when using git to push patches to an svn repository. And svn-apply is not smart enough. :) I was also asking to find out what subversion properties svn-apply might be likely to encounter -- for the purpose of adding property support to svn-apply and svn-unapply. --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] questions about allow-tabs
I have some background questions about the allow-tabs property. I imagine it pre-dates check-webkit-style by quite a while. (1) What's the reason and history behind our use of the property? (2) What component actually does the pre-commit check? I didn't find a reference to allow-tabs in WebKitTools/, but maybe I searched incorrectly. (3) Roughly speaking, how many and what types of files have the property set? (4) Are there any issues to be aware of with it when using a Git repository for development? While I'm asking, I might as well also ask -- what other subversion properties do we use? Thanks, --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] questions about allow-tabs
On Thu, January 14, 2010 at 6:59:17 PM, Chris Jerdonek wrote: I have some background questions about the allow-tabs property. I imagine it pre-dates check-webkit-style by quite a while. (1) What's the reason and history behind our use of the property? The allow-tabs property (and the svn commit pre-hook) are the ultimate in style enforcement. The project didn't want tabs in source files (or ChangeLog files) committed accidentally, so any file with tabs needs the special allow-tabs svn property set. (2) What component actually does the pre-commit check? I didn't find a reference to allow-tabs in WebKitTools/, but maybe I searched incorrectly. It's on the server itself. I don't think it's available from the repository. (3) Roughly speaking, how many and what types of files have the property set? Mostly test files and (potentially) legacy source files are the only ones with the property set. (4) Are there any issues to be aware of with it when using a Git repository for development? No, just that you won't be able to use git svn dcommit when committing new files with tabs (or adding tabs to existing files). While I'm asking, I might as well also ask -- what other subversion properties do we use? In the past, svn:eol-style has been applied so that when files are checked out on Windows, they have the proper line endings. There is also a concerted effort to keep svn:mime-type set correctly on *-expected.png results for pixel tests committed via git. Dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
