Re: [webkit-dev] webkit.org/pending-review
On Jan 14, 2010, at 12:25 AM, Eric Seidel wrote: Oliver Hunt mentioned this evening that he found the webkit.org/pending-review page confusing because it lists both commit-queue? patches and review? patches. I agreed. I filed https://bugs.webkit.org/show_bug.cgi?id=33656 to track updating /pending-review to more modern review URL and made some possible suggestions as to better URLs. Maciej is the man with the real URL magic though. :) I'm not sure how /pending-review is managed, it does not seem to be stored in WebKitSite/, perhaps someone on this list would know how to change it? Or would maybe folks have their own suggestions as to what URL we should use for /pending-review (if so please update the bug). /pending-review is used by http://nightly.webkit.org/start and may be linked to from other places in the site, I don't know. The page that pending-review points to actually has some nice properties in the way it lays things out, but in other ways its harder to read. I'd really like it if we could make a review queue page that's combines their best features and is nicer than either. This may be hard. The queries I personally like to use these days are: http://tinyurl.com/y98qfjs (general patches, no bracket) http://tinyurl.com/yjr2xru (patches needing port-specific review, [bracket] prefix) Their main downside is that they do not sort by date of review request. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit.org/pending-review
I'm pretty sure it's set up as a redirect in the Apache config for webkit.org. $ curl -I http://webkit.org/pending-review HTTP/1.1 301 Moved Permanently Date: Thu, 14 Jan 2010 17:19:39 GMT Server: Apache/2.2.14 (Unix) mod_ssl/2.2.14 OpenSSL/0.9.8l DAV/2 mod_python/3.3.1 Python/2.5.4 Location: https://bugs.webkit.org/request.cgi?action=queuerequester=product=type=reviewrequestee=component=group=requestee Vary: Accept-Encoding Content-Type: text/html; charset=iso-8859-1 Based on the web form, I don't see a way to filter out commit-queue? attachments while keeping request? flagged attachments, though. Dave - Original Message From: Eric Seidel e...@webkit.org To: WebKit Development webkit-dev@lists.webkit.org Sent: Thu, January 14, 2010 12:25:15 AM Subject: [webkit-dev] webkit.org/pending-review Oliver Hunt mentioned this evening that he found the webkit.org/pending-review page confusing because it lists both commit-queue? patches and review? patches. I agreed. I filed https://bugs.webkit.org/show_bug.cgi?id=33656 to track updating /pending-review to more modern review URL and made some possible suggestions as to better URLs. Maciej is the man with the real URL magic though. :) I'm not sure how /pending-review is managed, it does not seem to be stored in WebKitSite/, perhaps someone on this list would know how to change it? Or would maybe folks have their own suggestions as to what URL we should use for /pending-review (if so please update the bug). /pending-review is used by http://nightly.webkit.org/start and may be linked to from other places in the site, I don't know. -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit.org/pending-review
Yes, it is in the apache configs. Just email me or assign the bug to me when you've figured out where you want it to go. -Bill On Jan 14, 2010, at 9:23 AM, David Kilzer wrote: I'm pretty sure it's set up as a redirect in the Apache config for webkit.org. $ curl -I http://webkit.org/pending-review HTTP/1.1 301 Moved Permanently Date: Thu, 14 Jan 2010 17:19:39 GMT Server: Apache/2.2.14 (Unix) mod_ssl/2.2.14 OpenSSL/0.9.8l DAV/2 mod_python/3.3.1 Python/2.5.4 Location: https://bugs.webkit.org/request.cgi?action=queuerequester=product=type=reviewrequestee=component=group=requestee Vary: Accept-Encoding Content-Type: text/html; charset=iso-8859-1 Based on the web form, I don't see a way to filter out commit-queue? attachments while keeping request? flagged attachments, though. Dave - Original Message From: Eric Seidel e...@webkit.org To: WebKit Development webkit-dev@lists.webkit.org Sent: Thu, January 14, 2010 12:25:15 AM Subject: [webkit-dev] webkit.org/pending-review Oliver Hunt mentioned this evening that he found the webkit.org/pending-review page confusing because it lists both commit-queue? patches and review? patches. I agreed. I filed https://bugs.webkit.org/show_bug.cgi?id=33656 to track updating /pending-review to more modern review URL and made some possible suggestions as to better URLs. Maciej is the man with the real URL magic though. :) I'm not sure how /pending-review is managed, it does not seem to be stored in WebKitSite/, perhaps someone on this list would know how to change it? Or would maybe folks have their own suggestions as to what URL we should use for /pending-review (if so please update the bug). /pending-review is used by http://nightly.webkit.org/start and may be linked to from other places in the site, I don't know. -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
