[Wesnoth-bugs] [bug #25639] [remove_object] heals units with amla

[Celtic Minstrel]

Follow-up Comment #1, bug #25639 (project wesnoth):

I doubt this is a bug with [remove_object]. If the situation is as you
suggest, it should also affect objects with an expiry, such as the "stun"
weapon special. I don't know of any good way to fix this.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25639] [remove_object] heals units with amla

[Daniel]

URL:
  

 Summary: [remove_object] heals units with amla
 Project: Battle for Wesnoth
Submitted by: gfgtdf
Submitted on: Sa 08 Apr 2017 21:39:16 UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: WML
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.13.7
Operating System:  

___

Details:

to reprocue:
1) Let unit1 be a unit with id=unit1,x=1,y=1,hitpoints=1 and it has already
got one default amla.
2) add a dummy object (:lua wesnoth.get_unit(1,1):add_modification("object",
{id = "a"}))
3) remove the object (:lua lua wesnoth.wml_actions.remove_object { object_id =
"a"})

observed behaviour: the unit was fully healed
expected behviour: the unit shoudl still have one hp.

The reason why it fully heals is that the default amla has a heal_full=yes in
it, and remove_object reapplies all modifications.

Proposed solution: the engine shodul somehow know that we are just reapplying
the effect and skip the healing then.




___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs