RE: GNU Coding Standard compliance
Eric - Why are you trying to package Wget for cygwin when there is a *native* win32 exe? Seems like a whole *lot* of work for something that really doesn't gain you anything. I'm quite interested in your response. Chris Christopher G. Lewis http://www.ChristopherLewis.com -Original Message- From: Eric Blake [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 04, 2008 7:52 AM To: [EMAIL PROTECTED] Subject: GNU Coding Standard compliance -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm trying to package wget-1.11.3 for cygwin. But you have several GNU Coding Standard compliance problems that is making this task more difficult than it should be. GCS requires that your testsuite be run by 'make check', but yours is a no-op. Instead, you provide 'make test', but that fails to compile if you use a VPATH build. And even when using an in-tree build, it fails as follows: ./Test-proxied-https-auth.px echo echo /bin/sh: ./Test-proxied-https-auth.px: No such file or directory After commenting that line out, the following tests are also missing: ./Test-proxy-auth-basic.px ./Test-N-current-HTTP-CD.px Test-N-HTTP-Content-Disposition.px fails, since it didn't add the - --content-disposition flag to the wget invocation. Several Test--spider-* tests fail, because an expected error code of 256 is impossible (exit status is truncated to 8 bits). Also, your hand-rolled Makefile.in don't support --datarootdir. I'm not sure whether you are interested in migrating to using Automake, which would solve a number of these issues; let me know if you would be interested in such a patch. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkhGkA0ACgkQ84KuGfSFAYAyvgCffHFFioWeTT+8sTn8O6YzdfM1 y7MAn12XTpxo1PiMtIwALxm1KrqsKROS =xKOZ -END PGP SIGNATURE-
Re: GNU Coding Standard compliance
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Christopher G. Lewis on 6/5/2008 7:55 AM: | Eric - | | Why are you trying to package Wget for cygwin when there is a *native* | win32 exe? Seems like a whole *lot* of work for something that really | doesn't gain you anything. That's where you're wrong. Using a cygwin version of wget DOES gain things. For example, the native win32 doesn't understand cygwin paths, so it doesn't integrate seamlessly with the rest of cygwin applications. Also, the cygwin wget (via cygwin managed mounts) can wget files named nul, aux, index.html vs. Index.html, etc which the native wget cannot. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkhIM2wACgkQ84KuGfSFAYDe5wCffi/X6JB3OaDaZ3zraMkB7osz 5NEAn1y6ZUhF7l88we4mo+KYFgLMf/XD =tZUf -END PGP SIGNATURE-
Re: GNU Coding Standard compliance
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Eric Blake wrote: I'm trying to package wget-1.11.3 for cygwin. But you have several GNU Coding Standard compliance problems that is making this task more difficult than it should be. GCS requires that your testsuite be run by 'make check', but yours is a no-op. Instead, you provide 'make test', but that fails to compile if you use a VPATH build. And even when using an in-tree build, it fails as follows: ./Test-proxied-https-auth.px echo echo /bin/sh: ./Test-proxied-https-auth.px: No such file or directory After commenting that line out, the following tests are also missing: ./Test-proxy-auth-basic.px ./Test-N-current-HTTP-CD.px Test-N-HTTP-Content-Disposition.px fails, since it didn't add the --content-disposition flag to the wget invocation. Several Test--spider-* tests fail, because an expected error code of 256 is impossible (exit status is truncated to 8 bits). Also, your hand-rolled Makefile.in don't support --datarootdir. I'm not sure whether you are interested in migrating to using Automake, which would solve a number of these issues; let me know if you would be interested in such a patch. We actually have already migrated to Automake in the mainline revision, which we forked some time ago. 1.11.x development has focused on important bugfixes only. The issues with the tests are known, and documented (see tests/README). They are provided as-is; a work-in-progress, and not really expected to be terribly useful. I'm actually working on improving this process right now (and in fact, the current mainline is already much-improved in this regard, thanks to some recent commits). In the mainline repository, make check works as expected (modulo some remaining issues with the tests, such as intermittent failures due to the fact that all the tests use the same web-server port for testing, and don't always wait quite long enough for reuse; I'll have that fixed soon). I would definitely recommend that make test be abandoned altogether; alternatively, you could probably modify tests/Makefile.in to match current mainline, which now runs a run-px script, rather than all those hideous ./Test-foo.px echo echo lines in Makefile.in proper (the tests from mainline should run fine on 1.11.3, I believe). It would still need some work, as I mention, to really be reliable, but at least there aren't glaring issues with broken and missing tests (and it runs via the expected make target). Good luck with the packaging. - -- HTH, Micah J. Cowan Programmer, musician, typesetting enthusiast, gamer, and GNU Wget Project Maintainer. http://micah.cowan.name/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIRsTS7M8hyUobTrERApudAJ9ugo0WsAL/gkJud1fK4Ip3+vDFSgCeMGvQ XFuwWhMOlGdeOx90BGoWyOA= =q4wa -END PGP SIGNATURE-
