[MediaWiki-CodeReview] [MediaWiki r88014]: Revision status changed
User Trevor Parscal changed the status of MediaWiki.r88014. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88014#c0 Commit summary: Followup to r87987: Remove tablesorter from mw.util dependencies ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] search=steven+tyler gets Steven_tyler
On 14 May 2011 04:33, Andrew Dunbar hippytr...@gmail.com wrote: On 14 May 2011 01:48, Aryeh Gregor simetrical+wikil...@gmail.com wrote: On Fri, May 13, 2011 at 3:31 AM, M. Williamson node...@gmail.com wrote: I still don't think page titles should be case sensitive. Last time I asked how useful this really was, back in 2005 or so, I got a tersely-worded response that we need it to disambiguate certain pages. OK, but how many cases does that actually apply to? I would think that the increased usability from removing case sensitivity would far outweigh the benefit of natural disambiguation that only applies to a tiny minority of pages, and which could easily be replaced with disambiguation pages. From a software perspective, the way to do this would be to store a canonicalized version of each page's title, and require that to be unique instead of the title itself. This would be nice because we could allow underscores in page titles, for instance, in addition to being able to do case-folding. Note that Unicode capitalization is locale-dependent, but case-folding is not. Thus we could use the same case-folding on all projects, including international projects like Commons. There's only one exception -- Turkish, with its dotless and dotted i's. But that's minor enough that we should be able to work around it without too much pain. I'm almost positive Azeri has the same dotless i issue and perhaps some of the other Turkic languages of Central Asia. One solution is to do accent/diacritic normalization too as part of the canonicalization. This is getting into nirvana fallacy territory - we can't have case-folding until every edge case works? Instead, I would ask first: What does it take in English? Then work out from there. - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] search=steven+tyler gets Steven_tyler
On Sat, May 14, 2011 at 6:00 PM, David Gerard dger...@gmail.com wrote: This is getting into nirvana fallacy territory - we can't have case-folding until every edge case works? Instead, I would ask first: What does it take in English? Then work out from there. Nobody's saying it can't be done. I get the feeling we need to feel out what issues might come up, and plan for them. I think there was a Title class rewrite with pluggable canonicalisation of page titles somewhere, perhaps by Dan Friesen? It would probably need to be reimplemented from scratch though, I think I last heard of it a couple of years ago. -- Andrew Garrett Wikimedia Foundation agarr...@wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87978]: Revision status changed
User Krinkle changed the status of MediaWiki.r87978. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87978#c0 Commit summary: Expanded the contents of a function that was immediately called. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87808]: Revision status changed
User Krinkle changed the status of MediaWiki.r87808. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87808#c0 Commit summary: Prevent user from trying to move a page to a title longer than 255 bytes. This just puts a maxlength on the field (+ byte counter js) which is much nicer and clearer feedback to the user if they went over the limit then: The requested page title was invalid, empty, or an incorrectly linked inter-language or inter-wiki title. It may contain one or more characters which cannot be used in titles Which doesn't exactly indicate a length error. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88029]: Revision status changed
User Hashar changed the status of MediaWiki.r88029. Old Status: new New Status: deferred Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88029#c0 Commit summary: Localisation updates for magic word aliases for extensions from http://translatewiki.net. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88028]: Revision status changed
User Hashar changed the status of MediaWiki.r88028. Old Status: new New Status: deferred Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88028#c0 Commit summary: Localisation updates for special page aliases for extensions from http://translatewiki.net. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88020]: Revision status changed
User Hashar changed the status of MediaWiki.r88020. Old Status: new New Status: deferred Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88020#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-05-13 21:15:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88018]: Revision status changed
User Hashar changed the status of MediaWiki.r88018. Old Status: new New Status: deferred Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88018#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-13 21:00:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87322]: New comment added
User Krinkle posted a comment on MediaWiki.r87322. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87322#c16845 Commit summary: Tablesorter: Add a title attribute to sort arrows ( Bug 21453 ) Comment: pre + concurrent = 0; /pre What is that for ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88024]: New comment added
User Nikerabbit posted a comment on MediaWiki.r88024. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88024#c16846 Commit summary: * partial revert of r88019. Left the messages in for now ... don't know ... those mesages seem logical to me, i know domas might not like it, but they are still displayed. Comment: Where are they displayed? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88016]: Revision status changed
User Hashar changed the status of MediaWiki.r88016. Old Status: new New Status: deferred Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88016#c0 Commit summary: Rewrite importUseModWiki to subclass maintenance, general cleanup, etc. Also fixing bug 22287, change default field separator ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88004]: New comment added
User Hashar posted a comment on MediaWiki.r88004. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88004#c16848 Commit summary: (bug 10154) Don't allow user to specify days beyond $wgRCMaxAge Comment: Doesn't it mean mean this r88004 should be reverted? :b ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88003]: Revision status changed
User Hashar changed the status of MediaWiki.r88003. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88003#c0 Commit summary: Fix unused variables Decapitalise False ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88002]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r88002. Old Status: new New Status: fixme User Hashar also posted a comment on MediaWiki.r88002. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88002#c16849 Commit summary: Improve variable naming Comment: You forgot to update the documentation block! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88000]: Revision status changed
User Hashar changed the status of MediaWiki.r88000. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88000#c0 Commit summary: removing unused message ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87994]: Revision status changed
User Hashar changed the status of MediaWiki.r87994. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87994#c0 Commit summary: Testing again... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] search=steven+tyler gets Steven_tyler
On 14 May 2011 06:33, Andrew Dunbar hippytr...@gmail.com wrote: I'm almost positive Azeri has the same dotless i issue and perhaps some of the other Turkic languages of Central Asia. One solution is to do accent/diacritic normalization too as part of the canonicalization. It's a good thing to think about these beforehand. But we already do enough mindless killing of diacritics. It doesn't work across all languages. In Finnish saa and sää are different words and ä is not a letter a with something added to it. -Niklas -- Niklas Laxström ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r88024]: New comment added
User Freakolowsky posted a comment on MediaWiki.r88024. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88024#c16850 Commit summary: * partial revert of r88019. Left the messages in for now ... don't know ... those mesages seem logical to me, i know domas might not like it, but they are still displayed. Comment: /me hides ... was looking at some other comments ... was reverted in next rev ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] search=steven+tyler gets Steven_tyler
On 13 May 2011 09:09, Jay Ashworth j...@baylink.com wrote: And having it available as an option's a great idea. But forcing it *absolutely* rules out some potential use-cases, which is rarely a good idea in software design; especially in the case of *tools* design, which is what Mediawiki is: it's a tool as much as it's an application. Ah, OK, we agree :-) I wouldn't make it the *default* unless and until it proved to be massively the actual desired use case. I think it'd be a great feature and I'd really like it for real-world use (intranet wikis in particular - it's amazing how many people who use a computer all day every day get away with claiming to be unable to use them). - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87952]: Revision status changed
User Bryan changed the status of MediaWiki.r87952. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87952#c0 Commit summary: Article::updateArticle() doesn't exist anymore ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87899]: New comment added
User Hashar posted a comment on MediaWiki.r87899. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87899#c16852 Commit summary: Follow-up r87898: Using real path Comment: Can't it be made relative to the current wiki? Something like src=./resources/js/inject.js ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87305]: New comment added
User Kaldari posted a comment on MediaWiki.r87305.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87305#c16853
Commit summary:
fix issues from r86927, user language and years over
Comment:
I reverted that part in r87308. Plantonides suggested the magic language
switching might be problematic, so we'll just let people use
nowiki{{int:lang}}/nowiki as the language parameter instead if they need
that functionality.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87848]: Revision status changed
User Hashar changed the status of MediaWiki.r87848. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87848#c0 Commit summary: Step 1 of QUnit/TestSwarm support (bug 26908) * Add jQuery QUnit module * Add a return value to mw.Map.prototype.set * Add fallback to 'body' for options.parent in a new $.messageBox (this is a re-do of r87830, but without breaking mw.config, see r87830 CR) -- * Small whitespace fix (spaces to tabs) in Resources.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88033]: Revision status changed
User Hashar changed the status of MediaWiki.r88033. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88033#c0 Commit summary: Followup r88002, fix naming on param documentation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88002]: Revision status changed
User Reedy changed the status of MediaWiki.r88002. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88002#c0 Commit summary: Improve variable naming ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88002]: Revision status changed
User Hashar changed the status of MediaWiki.r88002. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88002#c0 Commit summary: Improve variable naming ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87920]: Revision status changed
User Catrope changed the status of MediaWiki.r87920. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87920#c0 Commit summary: Removed dead code path since r27312: $revision cannot be null if $restored is non-zero ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88025]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r88025. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r88025. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88025#c16854 Commit summary: * removed unused messages because of previous revert. * hidden namespace select box if in wgMiserMode(requested by domas) Comment: This is a really great regression for authors's usability. Please add an index before this revision goes live on WMF ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87322]: New comment added
User DieBuche posted a comment on MediaWiki.r87322. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87322#c16855 Commit summary: Tablesorter: Add a title attribute to sort arrows ( Bug 21453 ) Comment: That's a mini followup to r87243 . We walk trough multiple cells to find the parser that matches best. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88025]: New comment added
User Catrope posted a comment on MediaWiki.r88025. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88025#c16856 Commit summary: * removed unused messages because of previous revert. * hidden namespace select box if in wgMiserMode(requested by domas) Comment: This isn't really indexable. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86577]: New comment added
User Mdale posted a comment on MediaWiki.r86577. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86577#c16857 Commit summary: Added generic bucketing feature to the user object, which handles bucketing users, invalidating bucketing on version changes, tracking and and persistence. Comment: Well to load subsequent modules we need the loader code in there. Basic message code is also kind of core in the sense the when you load modules they have associated messages. Extended message parsing is already a separate module ( presently hosted in upload wizard and MwEmbedSupport extensions, but would be good to move them into a module in core resources but not copy it into mediawiki.js ;). This way interface modules that need extended message parsing can set it as a dependency. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81536]: New comment added, and revision status changed
User Platonides changed the status of MediaWiki.r81536. Old Status: new New Status: fixme User Platonides also posted a comment on MediaWiki.r81536. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/81536#c16858 Commit summary: (bug 19751) Filesystem is now checked during image undeletion * FSRepo::storeBatch() now does an sha1 check unless SKIP_VALIDATION flag is set * Introduced Status::$success in addition to Status::$successcount ** FSRepo::storeBatch() now logs success/failure in this variable * LocalFileRestoreBatch now aborts on failure in FSRepo::storeBatch() and cleans up the already copied files ** Introduced FSRepo::cleanupBatch() for this purpose * SpecialUndelete now aborts if LocalFile::restore() gives a fatal Comment: An array called $success to indicate which items of the batch operations ''failed''? Also, you're storing it whether it's actually good or not. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88035]: New comment added
User Krinkle posted a comment on MediaWiki.r88035. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88035#c16859 Commit summary: * (bug 28945) Keyboard shortcuts on history page no longer work in 1.18 The link replacements for the button were dropping title accesskey attributes, losing the shortcut key. Now copying these and replacing the buttons in-place, makes em work. Comment: It doesn't appear to work on the history page. The js-button created (nor the original input[type=submit]) has a title or accesskey attribute. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88035]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r88035. Old Status: new New Status: ok User Krinkle also posted a comment on MediaWiki.r88035. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88035#c16860 Commit summary: * (bug 28945) Keyboard shortcuts on history page no longer work in 1.18 The link replacements for the button were dropping title accesskey attributes, losing the shortcut key. Now copying these and replacing the buttons in-place, makes em work. Comment: Hm... There are two input[type=submit] on the page (on top and on the bottom), looks like PHP only outputs title/accesskey on the bottom one. I guess that makes sense since accesskeys need to be unique... Nevermind :) Marking ok, works good for the one that do have title/accesskey. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88035]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r88035. Old Status: ok New Status: new User Brion VIBBER also posted a comment on MediaWiki.r88035. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88035#c16861 Commit summary: * (bug 28945) Keyboard shortcuts on history page no longer work in 1.18 The link replacements for the button were dropping title accesskey attributes, losing the shortcut key. Now copying these and replacing the buttons in-place, makes em work. Comment: There are two buttons -- the bottom one has the access key + title. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88023]: New comment added
User Duplicatebug posted a comment on MediaWiki.r88023. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88023#c16862 Commit summary: * bug 28571 * Not sure about this one: the index i changed is defined as ar_usertext_timestamp in tables.sql, but created and used as usertext_timestamp. Comment: ar_len contains the size of the archived revision, so it is bad to use ChangesList::showCharacterDifference, because there is no difference. You can use Linker::formatRevisionSize to show the size of that revision. There are also many ' . . '. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88008]: New comment added, and revision status changed
User Bryan changed the status of MediaWiki.r88008. Old Status: new New Status: fixme User Bryan also posted a comment on MediaWiki.r88008. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88008#c16863 Commit summary: * bug 24037 Comment: Special:Contributions now only shows edits that are in recentchanges. I don't think there is a way to fix this without a schema change, so it should be reverted. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88008]: New comment added
User Bryan posted a comment on MediaWiki.r88008. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88008#c16864 Commit summary: * bug 24037 Comment: Also, bug 24037 is insufficient for a commit summary. Please try to at least include the bug title into it, so that we don't need to click through to bugzilla to find out what the commit is supposed to do. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81536]: New comment added
User Bryan posted a comment on MediaWiki.r81536. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/81536#c16866 Commit summary: (bug 19751) Filesystem is now checked during image undeletion * FSRepo::storeBatch() now does an sha1 check unless SKIP_VALIDATION flag is set * Introduced Status::$success in addition to Status::$successcount ** FSRepo::storeBatch() now logs success/failure in this variable * LocalFileRestoreBatch now aborts on failure in FSRepo::storeBatch() and cleans up the already copied files ** Introduced FSRepo::cleanupBatch() for this purpose * SpecialUndelete now aborts if LocalFile::restore() gives a fatal Comment: Well, something is wrong here. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] search=steven+tyler gets Steven_tyler
OK, then why can't http://en.wikipedia.org/wiki/Steven_tyler just do a browser redirect to http://en.wikipedia.org/wiki/Steven_Tyler As the URL you leave in the user's browser location bar is the one he will tell all his friends to use. You can't expect him to be smart enough to dig the canonical one we would rather he use out of all those links on the page, even if it is right there linked to 'Article'. $ lynx -dump -listonly http://en.wikipedia.org/wiki/Steven_tyler |grep http://en.wikipedia.org/wiki/Steven_Tyler 737. http://en.wikipedia.org/wiki/Steven_Tyler 771. http://en.wikipedia.org/wiki/Steven_Tyler 774. http://en.wikipedia.org/wiki/Steven_Tyler ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] search=steven+tyler gets Steven_tyler
On Sat, May 14, 2011 at 8:33 PM, jida...@jidanni.org wrote: OK, then why can't http://en.wikipedia.org/wiki/Steven_tyler just do a browser redirect to http://en.wikipedia.org/wiki/Steven_Tyler Because then we can't show the (Redirected from X) bar that accompanies the redirects ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] search=steven+tyler gets Steven_tyler
On 14 May 2011 20:37, K. Peachey p858sn...@gmail.com wrote: On Sat, May 14, 2011 at 8:33 PM, jida...@jidanni.org wrote: OK, then why can't http://en.wikipedia.org/wiki/Steven_tyler just do a browser redirect to http://en.wikipedia.org/wiki/Steven_Tyler Because then we can't show the (Redirected from X) bar that accompanies the redirects The JavaScript we use on the English Wiktionary also makes a slightly different (Automaticaly redirected from X) bar, or something very similar. Andrew Dunbar (hippietrail) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85635]: New comment added
User Bryan posted a comment on MediaWiki.r85635. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85635#c16867 Commit summary: First part of bug 22881: Allow uploading directly into the archive to support importing files. Based on a patch by Vitaliy Filippov with some major rewrites by me. * LocalFile::publish() supports an extra parameter to support publishing into the archive * Added OldLocalFile::uploadOld(), which is the OldImage equivalent to LocalFile::upload(), but does not override it because it has an entirely different function signature. Comment: I don't see how it belongs in the File base class, because File does not know about the distinction between new and old files. The hierarchy which associates old files with new files is made in LocalFile and its descendants. I originally had the idea to put publish() directly into OldLocalFile, but that doesn't play nice with declaration compatibility either. Any ideas? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88023]: New comment added
User Freakolowsky posted a comment on MediaWiki.r88023. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88023#c16868 Commit summary: * bug 28571 * Not sure about this one: the index i changed is defined as ar_usertext_timestamp in tables.sql, but created and used as usertext_timestamp. Comment: But it would be nice for page and SpecialContributions to have somewhat consistent output ... the thing is formatRevisionSize outputs (X bytes) whereas showCharacterDifference outputs (+/-X) ... would be nice if both would use either the same function or add the bytes keyword to the diff function. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88008]: New comment added
User Freakolowsky posted a comment on MediaWiki.r88008. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88008#c16869 Commit summary: * bug 24037 Comment: One way to do it without the schema change would be to add an option for this field to the page and inform the user that/if wgRCMaxAge is in effect, to expect limited results (perhaps respecting the wgMiserMode setting to avoid aditional join). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88046]: New comment added, and revision status changed
User Platonides changed the status of MediaWiki.r88046. Old Status: new New Status: ok User Platonides also posted a comment on MediaWiki.r88046. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88046#c16870 Commit summary: Followup r88043: Add new message keys to maintenance file Comment: Thanks! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88043]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r88043. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r88043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88043#c16871 Commit summary: (Bug 28960) add message when email copy is sent to user Also added an error message when the mails were not sent. Documented the new messages plus some older ones. Note: $successCount and $failCount fields of Status are ugly to use. Comment: Seen on Translatewiki: PHP Notice: Trying to get property of non-object in /www/w/includes/specials/SpecialEmailuser.php on line 151 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88056]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r88056. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r88056. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88056#c16872 Commit summary: Special pages don't have talk page. Fixes exception in feeds when using revision deletion feature: Exception: MWNamespace::getTalk does not make any sense for given namespace -1 Comment: This is exactly why I made it to throw an exception : to make better code. Thanks for fixing it NikeRabbit! (this fix comes from a pair programming session between NikeRabbit Hashar) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88008]: New comment added
User Bryan posted a comment on MediaWiki.r88008. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88008#c16873 Commit summary: * bug 24037 Comment: That could work, yes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88057]: New comment added
User Siebrand posted a comment on MediaWiki.r88057. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88057#c16876 Commit summary: Reorganizing directories Comment: Is this really necessary? Almost all extensions with just a few files have no subfolders, and for translatewiki.net this requires additional configuration. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88063]: Revision status changed
User Siebrand changed the status of MediaWiki.r88063. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88063#c0 Commit summary: Followup r88057 for Translatewiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88036]: Revision status changed
User Siebrand changed the status of MediaWiki.r88036. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88036#c0 Commit summary: Tweak messages for consistency with core Add extenension to Translatewiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88054]: New comment added, and revision status changed
User Siebrand changed the status of MediaWiki.r88054. Old Status: new New Status: fixme User Siebrand also posted a comment on MediaWiki.r88054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88054#c16877 Commit summary: (bug 23002) Imagelinks table not updated after imagemove. The actual bug was inconsistent behaviour between imagelinks and pagelinks for redirects. * Parser now only adds the redirect source to imagelinks, like it does in pagelinks * ImagePage now shows the file redirects in-line with the normal The following pages link to this file: ** Added message linkstoimage-redirect ** Removed the separate file redirects section and removed associated message redirectstofile ** ImagePage::imageLinks will first fetch image links to the file, determine which are redirects, and if there are fewer links than the limit, fetch the redirect target links. Comment: Please update maintenance/language/messages.inc. Old key needs to be removed, new needs to be added. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88073]: Revision status changed
User Catrope changed the status of MediaWiki.r88073. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88073#c0 Commit summary: Improves on r88053 - added code basically lifted from jQuery.getScript which ensures that onreadystatechange is handled properly - only executing the callback when the state is changed to the correct state, and only calling it one time. Thanks John Resig! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87497]: Revision status changed
User Catrope changed the status of MediaWiki.r87497. Old Status: fixme New Status: new Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87497#c0 Commit summary: Per bug 28738 comment 4, pack ResourceLoader URLs by encoding foo.bar|foo.baz|bar.baz|bar.quux as foo.bar,baz|bar.baz,quux * Expand these URLs in ResourceLoaderContext * Build and emit these URLs in OutputPage::makeResourceLoaderLink() and in mw.loader * Throw an exception in ResourceLoader::register() for module names that contain pipe characters or commas. Commas need to be forbidden for this packing feature to work. Pipes were already forbidden but weren't checked for ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85432]: Revision status changed
User Siebrand changed the status of MediaWiki.r85432. Old Status: deferred New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85432#c0 Commit summary: Sigh ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki Development IDE
On 10 May 2011 16:24, Paul Houle p...@ontology2.com wrote: My take is that there are three cultures. Just posted to Reddit, with some interesting discussion: http://www.reddit.com/r/programming/comments/hb7cs/the_three_types_of_ide/ I do believe you've come up with something good here. - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r88077]: Revision status changed
User Trevor Parscal changed the status of MediaWiki.r88077. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88077#c0 Commit summary: Put jQuery UI modules in their own group ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88068]: Revision status changed
User Trevor Parscal changed the status of MediaWiki.r88068. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88068#c0 Commit summary: Adding a small test to verify that the regex worked. Apparently it's failing in IE8. Thanks TestSwarm ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88065]: Revision status changed
User Trevor Parscal changed the status of MediaWiki.r88065. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88065#c0 Commit summary: Adding files missing in r88061 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88035]: Revision status changed
User Krinkle changed the status of MediaWiki.r88035. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88035#c0 Commit summary: * (bug 28945) Keyboard shortcuts on history page no longer work in 1.18 The link replacements for the button were dropping title accesskey attributes, losing the shortcut key. Now copying these and replacing the buttons in-place, makes em work. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88061]: Revision status changed
User Trevor Parscal changed the status of MediaWiki.r88061. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88061#c0 Commit summary: Adding QUnit tests for mw.loader (Follow-up r88053) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87988]: Revision status changed
User Trevor Parscal changed the status of MediaWiki.r87988. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87988#c0 Commit summary: Looks like even margin-top isn't save due to box model differences (ie. becomes 6px in WebKit browser...?). Using visibility insteawd. (Follow-up to r87938, r87970) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87970]: Revision status changed
User Trevor Parscal changed the status of MediaWiki.r87970. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87970#c0 Commit summary: comparing colors cross-browser is Aweful. Turns out Opera normalizes to hexidecimal.. Using anoter property instead (margin-top). Thanks TestSwarm ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87938]: Revision status changed
User Trevor Parscal changed the status of MediaWiki.r87938. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87938#c0 Commit summary: Remove unneeded parens in $.compareObject; Fix addCSS QUnit test for IE6 which puts spaces between commas.. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87514]: Revision status changed
User Catrope changed the status of MediaWiki.r87514. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87514#c0 Commit summary: 5.2.3, like we do everywhere else ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87487]: Revision status changed
User Catrope changed the status of MediaWiki.r87487. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87487#c0 Commit summary: Kill $wgSkinExtensionFunctions. Way back in r4934 when it was introduced, it was near the beginning of Setup.php, and $wgExtensionFunctions was near the end. Thus, they served two different purposes for doing extension setup. Refactoring over time has brought these processes side-by-side and thus the unused (and less-featured) one is getting the axe. -1 more awful global \o/ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87481]: Revision status changed
User Catrope changed the status of MediaWiki.r87481. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87481#c0 Commit summary: (bug 28641) Doc fix for wfEmptyMsg() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87503]: Revision status changed
User Catrope changed the status of MediaWiki.r87503. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87503#c0 Commit summary: Followup r87487: drop unused message ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87480]: Revision status changed
User Catrope changed the status of MediaWiki.r87480. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87480#c0 Commit summary: (bug 23495) Allow createAndPromote.php to create non-sysop users ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87461]: Revision status changed
User Catrope changed the status of MediaWiki.r87461. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87461#c0 Commit summary: Revert r81542 for now, too lazy to fix this properly ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87455]: Revision status changed
User Catrope changed the status of MediaWiki.r87455. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87455#c0 Commit summary: Documentation Remove unused variables ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87261]: Revision status changed
User Catrope changed the status of MediaWiki.r87261. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87261#c0 Commit summary: A few minor RSD changes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87150]: Revision status changed
User Catrope changed the status of MediaWiki.r87150. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87150#c0 Commit summary: * Get a list of all subscribed hooks, and those subscribers Essentially what SpecialVersion will give you if wgSpecialVersionShowHooks is true ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86086]: Revision status changed
User Catrope changed the status of MediaWiki.r86086. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86086#c0 Commit summary: Follow-up r83302: Check permissions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86582]: Revision status changed
User Catrope changed the status of MediaWiki.r86582. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86582#c0 Commit summary: Remove @static from all over the place. That's what the static keyword is for, this being PHP5 and all ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85585]: Revision status changed
User Catrope changed the status of MediaWiki.r85585. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85585#c0 Commit summary: * (bug 28368) add hint for multipart/form-data to api information of action=importxml= ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85747]: Revision status changed
User Catrope changed the status of MediaWiki.r85747. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85747#c0 Commit summary: Quick fix to categoriesHtml() given new skin changes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85757]: Revision status changed
User Catrope changed the status of MediaWiki.r85757. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85757#c0 Commit summary: * (bug 28364) add registration date to meta=userinfo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85756]: Revision status changed
User Catrope changed the status of MediaWiki.r85756. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85756#c0 Commit summary: * (bug 28368) add hint for multipart/form-data to api information of action=importxml= Add RELEASE-NOTES for r85585 too ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85758]: Revision status changed
User Catrope changed the status of MediaWiki.r85758. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85758#c0 Commit summary: * (bug 28254) action=paraminfo: Extract type from PARAM_DFLT if PARAM_TYPE is not set Patch by Umherirrender ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85770]: Revision status changed
User Catrope changed the status of MediaWiki.r85770. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85770#c0 Commit summary: * (bug 27712) add parent_id to list=deletedrevs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85771]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r85771. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r85771. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85771#c16881 Commit summary: * (bug 28455) Add 'toponly' to recentchanges API module Comment: pre - $this-addFields( 'page_is_redirect' ); /pre Where did this go? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85772]: Revision status changed
User Catrope changed the status of MediaWiki.r85772. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85772#c0 Commit summary: * (bug 26873) API: Add 'toponly' filter in usercontribs module ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85771]: Revision status changed
User Reedy changed the status of MediaWiki.r85771. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85771#c0 Commit summary: * (bug 28455) Add 'toponly' to recentchanges API module ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85138]: Revision status changed
User Catrope changed the status of MediaWiki.r85138. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85138#c0 Commit summary: Followup r84825 Allow obtaining of an import token if users have the importupload right ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84825]: Revision status changed
User Catrope changed the status of MediaWiki.r84825. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84825#c0 Commit summary: * (bug 28263) cannot import xml with the api, when have not import user right, but importupload Normalised api user right checking to that of SpecialImport, by moving permission checks into specified code paths Some documentation and explicit variables added while inspecting other code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84811]: Revision status changed
User Catrope changed the status of MediaWiki.r84811. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84811#c0 Commit summary: * (bug 28249) allow dupes in meta=allmessagesamargs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84380]: Revision status changed
User Catrope changed the status of MediaWiki.r84380. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84380#c0 Commit summary: Addition of 'APIQuerySiteInfoGeneralInfo' hook for usage in bug 16288 API: consider making closure status of wikis more clear with meta=siteinfo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84433]: Revision status changed
User Catrope changed the status of MediaWiki.r84433. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84433#c0 Commit summary: Start of bug 27586/bug 27589 Turn properties into a filterable key/value pair, but leave exisiting wrapper methods in place for the moment Will finish it off later ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84504]: Revision status changed
User Catrope changed the status of MediaWiki.r84504. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84504#c0 Commit summary: * (bug 27586) Remove duplication of props in ApiQueryStashImageInfo by using ApiQueryImageInfo Programatically do properties and descriptions. Reduces text duplication, and hence normalises descriptions! :) Follows up r84502, r84433 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] search=steven+tyler gets Steven_tyler
- Original Message - From: David Gerard dger...@gmail.com This is getting into nirvana fallacy territory - we can't have case-folding until every edge case works? Instead, I would ask first: What does it take in English? Then work out from there. You appear to be suggesting, David, that giving thought to the problem space before working up an architectural design for the solution is a *bad* thing. Especially when putting fundamentally changing code into a giant, widely used, architecture like Mediawiki. I'm sure you can't mean that. Cheers, -- jra -- Jay R. Ashworth Baylink j...@baylink.com Designer The Things I Think RFC 2100 Ashworth Associates http://baylink.pitas.com 2000 Land Rover DII St Petersburg FL USA http://photo.imageinc.us +1 727 647 1274 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] search=steven+tyler gets Steven_tyler
- Original Message - From: David Gerard dger...@gmail.com On 13 May 2011 09:09, Jay Ashworth j...@baylink.com wrote: And having it available as an option's a great idea. But forcing it *absolutely* rules out some potential use-cases, which is rarely a good idea in software design; especially in the case of *tools* design, which is what Mediawiki is: it's a tool as much as it's an application. Ah, OK, we agree :-) Wait'll you see my next reply. :-) I wouldn't make it the *default* unless and until it proved to be massively the actual desired use case. I think it'd be a great feature and I'd really like it for real-world use (intranet wikis in particular - it's amazing how many people who use a computer all day every day get away with claiming to be unable to use them). Who the hell would be typing internal URLs into an Intranet wiki? Cheers, -- jra -- Jay R. Ashworth Baylink j...@baylink.com Designer The Things I Think RFC 2100 Ashworth Associates http://baylink.pitas.com 2000 Land Rover DII St Petersburg FL USA http://photo.imageinc.us +1 727 647 1274 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] search=steven+tyler gets Steven_tyler
- Original Message - From: K. Peachey p858sn...@gmail.com On Sat, May 14, 2011 at 8:33 PM, jida...@jidanni.org wrote: OK, then why can't http://en.wikipedia.org/wiki/Steven_tyler just do a browser redirect to http://en.wikipedia.org/wiki/Steven_Tyler Because then we can't show the (Redirected from X) bar that accompanies the redirects I *did* say we shouldn't restart this argument, right? :-) Cheers, -- jra -- Jay R. Ashworth Baylink j...@baylink.com Designer The Things I Think RFC 2100 Ashworth Associates http://baylink.pitas.com 2000 Land Rover DII St Petersburg FL USA http://photo.imageinc.us +1 727 647 1274 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r88004]: New comment added
User ^demon posted a comment on MediaWiki.r88004. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88004#c16882 Commit summary: (bug 10154) Don't allow user to specify days beyond $wgRCMaxAge Comment: No, I mean killing $wgAjaxExportList in general, not this specific one. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88101]: Revision status changed
User Jeroen De Dauw changed the status of MediaWiki.r88101. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88101#c0 Commit summary: minor fixes in documentation and layout ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Hackathon parser session initial notes
We had a whole bunch of folks who've had their hands in the world of MediaWiki parsing rich text editing here at the Berlin Hackathon, and made some great progress on setting out some ideas for how to start actually working on it. Tomorrow I'll distill our session notes into a clearer description of the core ideas next steps (dare I say... a manifesto? :) In the meantime, if you're brave you can peek at the raw session notes: http://etherpad.wikimedia.org/mwhack11Sat-Parser We're reviving the wikitext-l mailing list for people interested in the project; it's gotten some traffic about interesting projects but we'll be making it an active working group. I'll also be making regular posts here on wikitech-l, on the Wikimedia tech blog, and on the wikis -- but I don't want to clutter wikitech-l *too* much with the nitty-gritty details. ;) Project hub pages will go up tomorrow at http://www.mediawiki.org/wiki/Future -- brion vibber (brion @ wikimedia.org / brion @ pobox.com) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r88111]: New comment added
User Duplicatebug posted a comment on MediaWiki.r88111. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88111#c16883 Commit summary: * added an option to toggle the display of diff size with a warning message. * in misermode this option is disabled Comment: Can you add the database field rev_len with Linker::formatRevisionSize() like done with r88048 for DeletedContributes, when not showing the byte difference? Thanks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88023]: New comment added
User Duplicatebug posted a comment on MediaWiki.r88023. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88023#c16884 Commit summary: * bug 28571 * Not sure about this one: the index i changed is defined as ar_usertext_timestamp in tables.sql, but created and used as usertext_timestamp. Comment: In my opinion is that another issue, which can you fix, if you think that is necessary. But showing the bytes as always a negative number is bad. Thanks for r88048. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
