[MediaWiki-CodeReview] [MediaWiki r89598]: Revision status changed
User MaxSem changed the status of MediaWiki.r89598. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89598#c0 Commit summary: ; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] DOMAS THE GIANT HAS A POSSE
You will obey: http://commons.wikimedia.org/wiki/File:Domas-the-Giant-has-a-Posse.png ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] DOMAS THE GIANT HAS A POSSE
Some of you guys need to work on your gang signs, hahah. - Chris 2011/6/7 Brandon Harris bhar...@wikimedia.org You will obey: http://commons.wikimedia.org/wiki/File:Domas-the-Giant-has-a-Posse.png ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89263]: New comment added
User MaxSem posted a comment on MediaWiki.r89263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89263#c17710 Commit summary: * suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater * could also generate default code for LocalSettingsGenerator * revert if silly :D Comment: To elaborate on Brion's revert of this revision: LoadExtensionSchemaUpdates hook works both for installation and upgrades. If it does not work, fix the extension and/or the core updater, but not introduce an alternative update infrastructure. As of adding stuff to LocalSettings, just use sane defaults. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89263]: New comment added
User Freakolowsky posted a comment on MediaWiki.r89263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89263#c17711 Commit summary: * suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater * could also generate default code for LocalSettingsGenerator * revert if silly :D Comment: No need for elaboration i totally understand your (and Brion's) logic. If it works why change it. What i fail to understand is your resistance to a simple let's make this ugly thing nicer idea. It doesn't break anything ... But hey ... i'll let it be ... got other things to do :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89623]: New comment added
User Hashar posted a comment on MediaWiki.r89623. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89623#c17712 Commit summary: * fixed table duplication for unit tests * fixed sequence handling when using DB prefix * deferring constraints on transaction, switching back to immediate on commit/rollback * hardcoded NLS_NUMERIC_CHARACTERS as it breaks using floats in sql if connection is in a non-US-like NLS_LANG (all vars are bound as chars) Comment: To get it reviewed, we need an oracle user :) I personally trust freakolowsky enough :b ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89576]: New comment added
User Bryan posted a comment on MediaWiki.r89576. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89576#c17713 Commit summary: Followup r89542, validate hashes Comment: ApiQueryAllimages seems to be a rather arbitrary place for validateSha1Base36Hash(). Isn't ApiQueryBase or ApiBase a better location? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89576]: New comment added
User Reedy posted a comment on MediaWiki.r89576. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89576#c17714 Commit summary: Followup r89542, validate hashes Comment: Indeed Well, tbh, we should probably move the whole validation bit up a level or 2, and move the actual validation routines to somewhere in the file/similar classes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User Happy-melon posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17715 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: Certainly pretty much ''all'' errors should be triggered by raising an exception. The use of wfDie() is to define what ''the exception'' should do with it. Before, IIRC, exceptions triggered in load.php outputted HTML into what should be a CSS/JS environment, for instance, because Exception.php didn't know what context it was echoing into (still doesn't, for that matter). The uses of wfDie() in Exception.php are not old junk, they're ''brand new'' in this revision. How does wfDie() have different meanings depending on the context? wfDie() means I can't handle this any more, get me out of here; in a fashion which is entry-point-dependent, doesn't require access to the autoloader, and preferably which works on as many environments as possible, such as PHP4. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89576]: New comment added
User Reedy posted a comment on MediaWiki.r89576. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89576#c17716 Commit summary: Followup r89542, validate hashes Comment: But of course, they were put there originally, as that was the only place using them at the time ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User Happy-melon posted a comment on MediaWiki.r85918.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17717
Commit summary:
Improvements to handling of 'catastrophic' errors, like unsupported PHP
versions, no MySQL functions, no LocalSettings, etc.
* Fix parsing of the three major entry points (index.php, api.php, load.php)
back to PHP 4.4.9. We don't care what happens if you actually try to run these
files on old versions, but the entry files need to parse correctly.
* consign /includes/templates/PHP4.php and
/includes/templates/NoLocalSettings.php to the fiery pit of hell where they
belong.
* Prevent loading of any other files for PHP 5. WebStart.php was rendered
unparseable in PHP 4 by the introduction of try/catch blocks in r85327.
* Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4.
All versions of PHP below that throw parse errors of various sorts.
* Reimplement wfDie() to provide an entry-point-dependent
die-with-readable-error-message function (for instance, we want a pretty
human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment
block in load.php, etc).
* Standardise the appearance of the catastrophic errors thrown at the top of
the stack with the ones lower down (exception-within-exception, etc). There
isn't really a way to do this without duplication, AFAICT.
Comment:
It would be helpful if this, like the other issues affecting HipHop support,
could be documented at [[HipHop]] or somesuch. What ''is'' the way to achieve
this? Would a structure like
source lang=php
// load.php
define( 'MW_ENTRY_POINT', 'LOAD' );
...
if( MW_ENTRY_POINT == 'LOAD' ) {
function wfDie( $msg ){ ... }
}
/source
Work?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r84475. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c17718 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as getTarget(), getBlockers(), isAutoblocking(), getId(). * This required editing AbuseFilter and CheckUser backwards-incompatibly, so push the rest of the changes out to those extensions. * Attack the evil 14-parameter constructor and gratuitously-confusing newFromDB( $notVeryImportantParameter, $moreImportantParameter) * Reimplement the hack for bug 13611 in a slightly less fragile fashion; could still do with further cleanup, but then again the login frontend is its own can of worms... :S * Remove transitionary getTargetAndType() and newFromTargetAndType() methods * Some optimisation in parseTarget() * Fix the broken phpunit test mentioned in r84251 Comment: I'll assume so since the bug is marked FIXED. Resetting to new. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89637]: New comment added
User Peachey88 posted a comment on MediaWiki.r89637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89637#c17719 Commit summary: Initial commit of new extension Notificator Comment: I believe you need to set up your svn autoprops for svn:eol style ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r86041. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c17720 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night. Comment: Was fixed as part of r89547. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added
User Happy-melon posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c17721 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night. Comment: Removing revert1.18; as this is now the foundation on which the token-needed-for-watch breaking change is implemented. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89637]: New comment added
User Patrick Nagel posted a comment on MediaWiki.r89637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89637#c17722 Commit summary: Initial commit of new extension Notificator Comment: Oh, right! I did that on the other box, but forgot to do it here. Hope I fixed that correctly now... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89640]: Revision status changed
User Reedy changed the status of MediaWiki.r89640. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89640#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89641]: Revision status changed
User Reedy changed the status of MediaWiki.r89641. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89641#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89637]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r89637. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r89637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89637#c17723 Commit summary: Initial commit of new extension Notificator Comment: You need to do a lot more escaping of things you output into html. I also think we already have a function for validating email address. +global $wgPasswordSender, $ngFromAddress; +if(! $ngFromAddress) $ngFromAddress = $wgPasswordSender; Don't do that, it is security vulnerability. I assume this extension was written a long time ago? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User Tim Starling posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17725 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: I suggest restoring wfDie() back to how it was before, and thinking of a new name for what you want to do. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89594]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r89594. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r89594. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89594#c17726 Commit summary: Followup r89588, adding the DISTINCT keyword is somewhat helpful Comment: IIRC, DISTINCT does not use index on MySQL 4 and does a full scan. Since live use some MySQL 5 version ... We should be fine :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89594]: New comment added
User Reedy posted a comment on MediaWiki.r89594. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89594#c17727 Commit summary: Followup r89588, adding the DISTINCT keyword is somewhat helpful Comment: Don't computers suck? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89594]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r89594. Old Status: ok New Status: new User Hashar also posted a comment on MediaWiki.r89594. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89594#c17728 Commit summary: Followup r89588, adding the DISTINCT keyword is somewhat helpful Comment: Resetting to new, you might want to force the index use. In bug 29287, the query does not seem to use repo_path index. See comment 7 : https://bugzilla.wikimedia.org/show_bug.cgi?id=29287#c7 Follow up on bug report :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Update Gadgets extension on WMF wikis
Hi all, I would like to ask for deployment of new version of Gadgets extension. It would be great to get rid of MediaWiki:Common.js by splitting it into separate gadgets, enabled for everyone by default. Any registered user will be able to disable functionality he/she does not like. What is more, it will simplify loading additional dependencies - now it is done by importScript etc. and allow to take advantage of Resource Loader. Regards, Ildefons Stułbia ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89549]: Revision status changed
User Reedy changed the status of MediaWiki.r89549. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89549#c0 Commit summary: follow up r89513: avoid internal error when only invalid revids/pageids are passed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Update Gadgets extension on WMF wikis
2011/6/7 Ildefons Stułbia ildefons.stul...@gmail.com: Hi all, I would like to ask for deployment of new version of Gadgets extension. It would be great to get rid of MediaWiki:Common.js by splitting it into separate gadgets, enabled for everyone by default. Any registered user will be able to disable functionality he/she does not like. What is more, it will simplify loading additional dependencies - now it is done by importScript etc. and allow to take advantage of Resource Loader. As far as I know, some version of Gadgets with ResourceLoader support is already live, although more recent fixes may not be included. Max or Krinkle can probably shed more light on this. Roan Kattouw (Catrope) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Update Gadgets extension on WMF wikis
On 07.06.2011, 17:52 Roan wrote: 2011/6/7 Ildefons Stułbia ildefons.stul...@gmail.com: Hi all, I would like to ask for deployment of new version of Gadgets extension. It would be great to get rid of MediaWiki:Common.js by splitting it into separate gadgets, enabled for everyone by default. Any registered user will be able to disable functionality he/she does not like. What is more, it will simplify loading additional dependencies - now it is done by importScript etc. and allow to take advantage of Resource Loader. As far as I know, some version of Gadgets with ResourceLoader support is already live, although more recent fixes may not be included. Max or Krinkle can probably shed more light on this. Restrictions by permission, gadgets by default and API module aren't deployed yet. There is some unreviewed stuff at [1], I believe that trunk is sane enough for deployment once someone reviewed it. [1] http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWikipath=%2Ftrunk%2Fextensions%2FGadgets -- Best regards, Max Semenik ([[User:MaxSem]]) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r75486]: New comment added
User Helder.wiki posted a comment on MediaWiki.r75486. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/75486#c17729 Commit summary: Introducing mediaWiki.language, and mediaWiki.message which are modeled after their PHP counterparts Language and wfMessage respectively. Comment: ''how often are the plural rules really changed?'' Not very often, I think, but take a look at bug 29299. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88512]: Revision status changed
User MaxSem changed the status of MediaWiki.r88512. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88512#c0 Commit summary: Fix up test so they can run from trunk ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User ^demon posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17730 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: The other option is forgetting about PHP4. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89650]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r89650. Old Status: new New Status: fixme User Reedy also posted a comment on MediaWiki.r89650. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89650#c17731 Commit summary: Comment: Username linked, but this file is missing svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89649]: Revision status changed
User Reedy changed the status of MediaWiki.r89649. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89649#c0 Commit summary: Adding my USERINFO file ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89650]: New comment added
User Reedy posted a comment on MediaWiki.r89650. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89650#c17732 Commit summary: Comment: Oh, and a commit summary! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89650]: New comment added
User Reedy posted a comment on MediaWiki.r89650. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89650#c17733 Commit summary: Comment: Make sure your [[Subversion/auto-props]] are set, even thought they won't have helped for this file ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89558]: Revision status changed
User Catrope changed the status of MediaWiki.r89558. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89558#c0 Commit summary: * Added a REQUEST_URI check to the bug 28235 handling. * Moved most of the bug 28235 code out to a separate library class, since I was running out of distinct function names. * Merged the QUERY_STRING and PATH_INFO security checks, since they are dealing with the exact same problem. Removed WebRequest::isQueryStringBad(). * Deal with img_auth.php by having it specify what extension it expects to be streaming out. This extension can then be compared with the extension that IE might detect. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89559]: Revision status changed
User Catrope changed the status of MediaWiki.r89559. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89559#c0 Commit summary: Test filename updates for r89558. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89651]: Revision status changed
User Reedy changed the status of MediaWiki.r89651. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89651#c0 Commit summary: ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89654]: Revision status changed
User Reedy changed the status of MediaWiki.r89654. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89654#c0 Commit summary: modifying email ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81536]: New comment added
User Catrope posted a comment on MediaWiki.r81536. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/81536#c17734 Commit summary: (bug 19751) Filesystem is now checked during image undeletion * FSRepo::storeBatch() now does an sha1 check unless SKIP_VALIDATION flag is set * Introduced Status::$success in addition to Status::$successcount ** FSRepo::storeBatch() now logs success/failure in this variable * LocalFileRestoreBatch now aborts on failure in FSRepo::storeBatch() and cleans up the already copied files ** Introduced FSRepo::cleanupBatch() for this purpose * SpecialUndelete now aborts if LocalFile::restore() gives a fatal Comment: pre + $cleanupBatch[] = array( $storeBatch[$i][1], $storeBatch[$i][1] ); /pre This looks wrong to me. Won't this end up as something like codearray( array( 'public', 'public' ), array( 'public', 'public' ), ... )/code ? Shouldn't the second element be code$storeBatch[$i][0]/code instead? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89653]: Revision status changed
User ^demon changed the status of MediaWiki.r89653. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89653#c0 Commit summary: Fix r85021: extension tables weren't created in some cases ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88492]: Revision status changed
User Catrope changed the status of MediaWiki.r88492. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88492#c0 Commit summary: Do not block the installer (through an unhandled exception) when we can't connect to ourself. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89650]: Revision status changed
User Reedy changed the status of MediaWiki.r89650. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89650#c0 Commit summary: ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85021]: New comment added
User ^demon posted a comment on MediaWiki.r85021. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85021#c17735 Commit summary: (bug 28237) Installer doesn't create extension tables Comment: MaxSem: The more I think about it, DatabaseUpdater::addNewExtension() (r81266) is really an unnecessary interface, given this rev. Given that only 3 extensions (CR, ConfirmAccount, Math) have started using it...maybe we should just kill it :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88871]: New comment added
User Catrope posted a comment on MediaWiki.r88871. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88871#c17736 Commit summary: * (bug 27465) Fix metadata extraction for SVG files using unusual namespace names The previous fix (in r82307) only checked explicitly for a namespace given the 'svg' prefix; this fix use XML namespacing support on XMLReader to check for the actual namespace URI correctly. Fixed up a test case (for RDF extraction) and added trimming on the whitespace. Also added another test case file that doesn't use a namespace name on the root. Comment: Combine with itself?!? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Update Gadgets extension on WMF wikis
2011/6/7 Ildefons Stułbia ildefons.stul...@gmail.com: I would like to ask for deployment of new version of Gadgets extension. It would be great to get rid of MediaWiki:Common.js by splitting it into separate gadgets, enabled for everyone by default. Well I'm not sure getting rid of Common.js is a good idea. But moving optional features to Gadgets isn't a bad idea. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89003]: Revision status changed
User Catrope changed the status of MediaWiki.r89003. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89003#c0 Commit summary: * (bug 29174) Fix regression in upload-by-URL: files larger than PHP memory limit work again r65152 switched upload-by-URL ($wgAllowCopyUploads) to use Http / MwHttpRequest class instead of CURL directly. While this is mostly nice, it switched from saving large files directly to a temp file to buffering them in memory, causing large files to fail when they hit the PHP memory limit. Fix uses MwHttpRequest's callback capability to override the read handler; now appending it to the temporary file as we go, and can confirm that largish files work again; was able to upload a 64mb .ogv that previously didn't work for me: http://prototype.wikimedia.org/tmh/images/b/b2/File-Arborophila_brunneopectus_pair_feeding_-_Kaeng_Krachan.ogv Also expanded the documentation on MwHttpRequest::setCallback to clarify the function parameters and return value for the callback (which currently matches the low-level CURL handler's callback directly). Note that the non-CURL implementation doesn't abort the read if the callback doesn't return the expected number of bytes, but this is an immediate fatal end of request on the Curl backend. May want further cleanup. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89529]: New comment added
User ^demon posted a comment on MediaWiki.r89529. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89529#c17737 Commit summary: Follow-up r89254 and r89481: re-did loading extension updates properly, now upgrading extension tables from web interface really works, and without notices Comment: This seems to duplicate some of the logic in Installer::includeExtensions(). Perhaps they could be refactored? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87494]: Revision status changed
User ^demon changed the status of MediaWiki.r87494. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87494#c0 Commit summary: For bug 28738, have the installer check for the Suhosin GET variable length limit and set $wgResourceLoaderMaxQueryLength correspondingly in LocalSettings.php . Of course this only works for new installs, no idea if this can be handled cleanly for upgrades ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85021]: New comment added
User MaxSem posted a comment on MediaWiki.r85021. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85021#c17738 Commit summary: (bug 28237) Installer doesn't create extension tables Comment: Yeah, makes sense. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added
User ^demon posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c17739 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night. Comment: We don't need it for core, and there's already MediaWikiPerformAction and UnknownAction hooks to handle things in extensions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89648]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r89648. Old Status: new New Status: reverted User Brion VIBBER also posted a comment on MediaWiki.r89648. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89648#c17740 Commit summary: Another try at fixing bug 93 tilde signatures inside nowiki tags sometimes get expanded (includeonlynowiki/nowiki/includeonly) * Change the preprocessor to insert strip items for ignore nodes during pre-save-transform, just like comment nodes are handled already. This effectively disables all pre-save-transform steps inside includeonly tags. * Adapt parser tests to the new behavior. Comment: Reverted in r89662; this disables PST on 'noinclude' sections in their entirety, rather than 'nowiki' sections within 'noinclude' as requested by the bug. A parser test case caught the regression but was changed to hide it... Commit also failed to update all the preprocessor classes; there's also now Preprocessor_HipHop.hphp. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89662]: Revision status changed
User MaxSem changed the status of MediaWiki.r89662. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89662#c0 Commit summary: Provisional revert of r89648: Another try at fixing bug 93 tilde signatures inside nowiki tags sometimes get expanded (includeonlynowiki/nowiki/includeonly) This seems to disable PST for includeonly.../includeonly in addition to the includeonlynowiki.../nowiki/includeonly that the bug is about. This was caught by a parser test case, but the test case was changed to match... seems like the wrong change? Also failed to update Preprocessor_HipHop.hphp to match the other two preprocessor classes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87512]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87512. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87512#c0 Commit summary: Fix for r87278: if we're installing with the same user we're going to use, skip creation grants since there's no point. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88076]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r88076. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88076#c0 Commit summary: Fix bug in r87497, reported in CR: modules=foo,bar,baz would look for '.foo', '.ar' and '.az' . Now handling prefixless modules correctly ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87497]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87497. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87497#c0 Commit summary: Per bug 28738 comment 4, pack ResourceLoader URLs by encoding foo.bar|foo.baz|bar.baz|bar.quux as foo.bar,baz|bar.baz,quux * Expand these URLs in ResourceLoaderContext * Build and emit these URLs in OutputPage::makeResourceLoaderLink() and in mw.loader * Throw an exception in ResourceLoader::register() for module names that contain pipe characters or commas. Commas need to be forbidden for this packing feature to work. Pipes were already forbidden but weren't checked for ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87411]: Revision status changed
User Platonides changed the status of MediaWiki.r87411. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87411#c0 Commit summary: Follow-up r87394: Add reference back to MediaWiki::performRequestForTitle per IAlex' comment. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89665]: New comment added
User Reedy posted a comment on MediaWiki.r89665. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89665#c17741 Commit summary: INITIAL COMMIT OF PAGE SCHEMAS. Comment: YOU NEED TO FIX YOUR SVN AUTOPROPS ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89665]: Revision status changed
User Reedy changed the status of MediaWiki.r89665. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89665#c0 Commit summary: INITIAL COMMIT OF PAGE SCHEMAS. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] DOMAS THE GIANT HAS A POSSE
Brandon Harris wrote: You will obey: http://commons.wikimedia.org/wiki/File:Domas-the-Giant-has-a-Posse.png OMG that's cool. But that Wikipedia book should have been about MySQL :) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r88076]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r88076. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88076#c17742 Commit summary: Fix bug in r87497, reported in CR: modules=foo,bar,baz would look for '.foo', '.ar' and '.az' . Now handling prefixless modules correctly Comment: phpunit test case added in r89666. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87497]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r87497. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87497#c17743 Commit summary: Per bug 28738 comment 4, pack ResourceLoader URLs by encoding foo.bar|foo.baz|bar.baz|bar.quux as foo.bar,baz|bar.baz,quux * Expand these URLs in ResourceLoaderContext * Build and emit these URLs in OutputPage::makeResourceLoaderLink() and in mw.loader * Throw an exception in ResourceLoader::register() for module names that contain pipe characters or commas. Commas need to be forbidden for this packing feature to work. Pipes were already forbidden but weren't checked for Comment: phpunit test case added in r89666. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89667]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r89667. Old Status: new New Status: ok User Reedy also posted a comment on MediaWiki.r89667. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89667#c17744 Commit summary: Comment: Please try and use commit summaries! ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89665]: Revision status changed
User Reedy changed the status of MediaWiki.r89665. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89665#c0 Commit summary: INITIAL COMMIT OF PAGE SCHEMAS. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r87482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87482#c17745 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak. Comment: IE6 bits are follow-up to r85844. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89668]: Revision status changed
User MaxSem changed the status of MediaWiki.r89668. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89668#c0 Commit summary: Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning null for user blocks, which was then happily inserted into a NOT NULL column. The IGNORE was just masking the real error. Thanks Brion and MaxSem. Oh, and ping r84475 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87498]: New comment added
User Catrope posted a comment on MediaWiki.r87498. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87498#c17746 Commit summary: Fixes ForeignDBRepo SQL server connection. Fixes bug #28836. Comment: Untagging 1.17. Fixes a regression introduced after the 1.17 branch point ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87468]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87468. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87468#c0 Commit summary: Move CleanUpTest, fixes in next commit ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87468]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87468. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87468#c0 Commit summary: Move CleanUpTest, fixes in next commit ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88798]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r88798. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88798#c0 Commit summary: Followup r87468: remove refs to CleanUpTest from Makefile ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87428]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87428. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87428#c0 Commit summary: No current need for an alias to getPath() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87414]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87414. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87414#c0 Commit summary: Partial revert of r87345. Causing unreadable buttons in ArticleFeedback (http://i.imgur.com/PyxOw.png ), likely breaks other things as well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87395]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87395. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87395#c0 Commit summary: Follow-up r87326: Add regression test. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89652]: Revision status changed
User Hashar changed the status of MediaWiki.r89652. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89652#c0 Commit summary: Followup r89651 Fix props ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89668]: New comment added
User Hashar posted a comment on MediaWiki.r89668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89668#c17747 Commit summary: Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning null for user blocks, which was then happily inserted into a NOT NULL column. The IGNORE was just masking the real error. Thanks Brion and MaxSem. Oh, and ping r84475 Comment: awesome! now we have to add a PHPUnit test suite to test the Block class :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89668]: New comment added
User ^demon posted a comment on MediaWiki.r89668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89668#c17748 Commit summary: Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning null for user blocks, which was then happily inserted into a NOT NULL column. The IGNORE was just masking the real error. Thanks Brion and MaxSem. Oh, and ping r84475 Comment: We do have (some) block tests. That's what led me to tracking this down. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87326]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87326. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r87326. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87326#c17749 Commit summary: Fix Bug 28354: Edit tab is shown as view source for blocked users, which breaks squid caching * Skip user block checks for Title::quickUserCan(). This restores the behavior from 1.16 rsp. before r65504. * Remove unnecessary check for $short count($errors), this is already handled by getUserPermissionsErrorsInternal(). Comment: This removes handling of the $short parameter. Is this intended? What differences in behavior are expected with this parameter on/off? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87400]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87400. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87400#c0 Commit summary: Tag names can't contain template parameters (thanksfully) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87394]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87394. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87394#c0 Commit summary: Remove references from function parameters in Wiki.php. They aren't needed for objects and sometimes cause warnings when called with non-vars. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89668]: New comment added
User Happy-melon posted a comment on MediaWiki.r89668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89668#c17750 Commit summary: Fix (Api)BlockTest for Sqlite. getRangeStart()/getRangeEnd() were returning null for user blocks, which was then happily inserted into a NOT NULL column. The IGNORE was just masking the real error. Thanks Brion and MaxSem. Oh, and ping r84475 Comment: Block rewrite isn't in 1.17, it's 1.18. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89660]: New comment added
User Hashar posted a comment on MediaWiki.r89660. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89660#c17751 Commit summary: Get rid of addNewExtension()/getNewExtensions() method of adding new extensions (added in r81266). Since r85021, this isn't necessary because we run old updates like we should. Fix the 3 extensions using it. Reverts most of r81266, all of r84868, tiny part of r86741. Also ping r89653 which is what caused me to look at this again. Comment: looks like the whole stuff need a backport to 1.18 isn't it? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89660]: New comment added
User ^demon posted a comment on MediaWiki.r89660. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89660#c17752 Commit summary: Get rid of addNewExtension()/getNewExtensions() method of adding new extensions (added in r81266). Since r85021, this isn't necessary because we run old updates like we should. Fix the 3 extensions using it. Reverts most of r81266, all of r84868, tiny part of r86741. Also ping r89653 which is what caused me to look at this again. Comment: And 1.17, if it'll go cleanly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87389]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87389. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87389#c0 Commit summary: Drop the $out params I added before I added context to Skin, as well deprecate some of the $out params in other methods. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87388]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87388. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87388#c0 Commit summary: * fixed tableName handling for internal purposes (bug if using sharedDB as i need raw table name) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87382]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87382. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87382. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87382#c17753 Commit summary: Add proper $out setting to Skin::getCategories which is present in the other similar methods. Replaces r87380. Comment: This was actually removed by further cleanup on r87389 :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87380]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87380. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87380. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87380#c17754 Commit summary: Add hack to shut up fatals when getCategories() is called without an actual OutputPage Comment: Further cleaned up in r87389 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87349]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87349. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87349#c0 Commit summary: Only one extension was using getThumbnail ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87349]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87349. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87349#c0 Commit summary: Only one extension was using getThumbnail ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87220]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87220. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87220#c0 Commit summary: Convert r86795 tests into a dataProvider ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87348]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87348. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87348#c0 Commit summary: Follow up r87220. r86795 tests are now embedded into PreprocessorTest.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87347]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87347. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r87347. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87347#c17755 Commit summary: (bug 7) Special:Listfiles no longer throws an error on bogus file entries Comment: Title::makeTitle does not validate input and cannot return something resolving to false. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89671]: Revision status changed
User Reedy changed the status of MediaWiki.r89671. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89671#c0 Commit summary: 1.17wmf1: Revert r89670, merged revs were intended for REL1_17 instead. This unmerges r87423, r88118, r88124, r88211, r88498, r89099, r89401, r89451 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89670]: Revision status changed
User Reedy changed the status of MediaWiki.r89670. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89670#c0 Commit summary: 1.17wmf1: MFT r87423, r88118, r88124, r88211, r88498, r89099, r89401, r89451 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87347]: New comment added
User Catrope posted a comment on MediaWiki.r87347. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87347#c17756 Commit summary: (bug 7) Special:Listfiles no longer throws an error on bogus file entries Comment: You may want makeTitleSafe() instead, if the input can possibly be invalid. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87347]: New comment added
User ^demon posted a comment on MediaWiki.r87347. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87347#c17757 Commit summary: (bug 7) Special:Listfiles no longer throws an error on bogus file entries Comment: Yeah, makeTitleSafe(), whoops. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code
Currently working (mostly backwards) to fill in the Code Review holes from before 1.18 branch point: http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWikioffset=87519path=%2Ftrunk%2Fphase3 Roadmap provisionally says July for 1.18 deployment: http://www.mediawiki.org/wiki/MediaWiki_roadmap -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89675]: Revision status changed
User Reedy changed the status of MediaWiki.r89675. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89675#c0 Commit summary: Forgot to press save on the comment ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87346]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87346. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87346#c0 Commit summary: We can't check if it's a parentNode-type == name_node so early, since it may be just a single } and end up being a literal. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87339]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r87339. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r87339. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87339#c17758 Commit summary: Fixes bug #28694: Set maxlength of revisiondelete comment to 100. Comment: Should indeed be more generalized. 100 chars is also pretty short! Marking as a todo rather than a fixme though. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89529]: Revision status changed
User ^demon changed the status of MediaWiki.r89529. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89529#c0 Commit summary: Follow-up r89254 and r89481: re-did loading extension updates properly, now upgrading extension tables from web interface really works, and without notices ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89677]: New comment added, and revision status changed
User MaxSem changed the status of MediaWiki.r89677. Old Status: new New Status: fixme User MaxSem also posted a comment on MediaWiki.r89677. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89677#c17759 Commit summary: 1.17: MFT r88492, r88870, r88871, r89003, r89108, r89114, r89115, r89129, r89532, r89653 Comment: r89532 depends on r89529. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
