[MediaWiki-CodeReview] [MediaWiki r90191]: New comment added
User MZMcBride posted a comment on MediaWiki.r90191. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90191#c18222 Commit summary: make it so that images always work regardless of whether they include the prefix or not Comment: Yeah, it's probably fine to put a FIXME in the code and/or file a bug to track the issue. Inconsistency between the behavior in English and in other languages can make other parts of the code (like localized input instructions) different, though, so it does need to be noted, in my opinion. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83405]: New comment added
User IAlex posted a comment on MediaWiki.r83405. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/83405#c18223 Commit summary: * Added UserGetLanguageObject hook to change the language used in $wgLang Comment: [[Extension:LanguageSelector]] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] wikistream: displays wikipedia updates in realtime
Very cool. In presentations I usually show the RC, and the click again after few seconds, to show the amount of edits: but this is far better. Thank you. Aubrey 2011/6/16 Ed Summers e...@pobox.com: I've been looking to experiment with node.js lately and created a little toy webapp that displays updates from the major language wikipedias in real time: http://wikistream.inkdroid.org Perhaps like you, I've often tried to convey to folks in the GLAM sector (Galleries, Libraries, Archives and Museums) just how much Wikipedia is actively edited. GLAM institutions are increasingly interested in digital curation and I've sometimes displayed the IRC activity at workshops to demonstrate the sheer number of people (and bots) that are actively engaged in improving the content there...with the hopes of making the Wikipedia platform part of their curation strategy. Anyhow, I'd be interested in any feedback you might have about wikistream. //Ed ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How can I get data to map our linguistic interconnectedness?
Alec Conroy wrote: I think I can build you something if you give me appropiate values for the above definition. Cheers Excellent-- so striking while the iron is hot-- I see that [[Special:Statistics]] defines active as edited within the last 30 days.I'm open to whoever many users we can realistically get info on-- the more the merrier, at least until I run out of ram. :) My initial query my go something like Select users where lasttouched was within the last month and total edit counts are greater than 500. And then, adding in the requirement of second project will narrow that pool. And then adding the constraint of a second project with a second language will narrow the pool even more. We're looking for the orphan community who have a lot of editors but little connection to English and Meta. I have added a small script at http://www.toolserver.org/~platonides/activeusers/activeusers.php to show active users per project and language. Requisites for appearing there are more than 500 edits (total) and at least one action (usually an edit) in the last month (since May 16, data is cached). Bots appear in the list. I'm still populating the data, but it should be completed by the time you read this. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] wikistream: displays wikipedia updates in realtime
On Thu, Jun 16, 2011 at 6:40 AM, Ed Summers e...@pobox.com wrote:
I've been looking to experiment with node.js lately and created a
little toy webapp that displays updates from the major language
wikipedias in real time:
http://wikistream.inkdroid.org
Visiting that URL yields:
An error has occurred: {stack:Error: ECONNREFUSED, Connection
refused\nat Socket._onConnect (net.js:602:18)\nat
IOWatcher.onWritable [as callback]
(net.js:186:12),message:ECONNREFUSED, Connection
refused,errno:111,code:ECONNREFUSED,syscall:connect}
Roan Kattouw (Catrope)
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90191]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r90191. Old Status: new New Status: ok User Catrope also posted a comment on MediaWiki.r90191. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90191#c18224 Commit summary: make it so that images always work regardless of whether they include the prefix or not Comment: Like MZ says, this should pull the localized file ns names and check against those. I think Krinkle is working on a problem that needs something similar, so you could hit him up about how to get that data. Fine otherwise, marking OK. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89919]: New comment added
User Devayon posted a comment on MediaWiki.r89919. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89919#c18225 Commit summary: Creating a Query Creator interface to seperate use cases of Special:Ask Comment: Thanks for pointing that out! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90182]: Revision status changed
User ^demon changed the status of MediaWiki.r90182. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90182#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90193]: New comment added
User Platonides posted a comment on MediaWiki.r90193. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90193#c18226 Commit summary: Removed $wgProto. Previously, setting this undocumented global variable to anything other than the part of $wgServer before the first colon would cause various things to subtly screw up. Similarly, forgetting to set it when you override $wgServer in LocalSettings.php would break things too. Exposing it in the default LocalSettings.php as I did in r90105 was not a good solution, really the only way to avoid breakage is to just get the protocol from $wgServer whenever you need the protocol. Fixed $wgCookieSecure so that it will be enabled automatically if the user sets $wgServer to an https URL in LocalSettings.php. Added documentation for other cookie-related globals. Grep indicates that $wgProto is not used by any extensions. $wgCookieSecure is used, hence the need for the Setup.php patch. Comment: $wgProto needs to be removed from extensions/Configure ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90195]: Revision status changed
User ^demon changed the status of MediaWiki.r90195. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90195#c0 Commit summary: new dump processors. ready for testing ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90205]: Revision status changed
User ^demon changed the status of MediaWiki.r90205. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90205#c0 Commit summary: fix bug 29421 and increment version nr ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90206]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90206. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90206#c0 Commit summary: follow up to r90202 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90207]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90207. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90207#c0 Commit summary: address chads comment on bug 29433 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] How can I get data to map our linguistic interconnectedness?
Dear Alec, Maybe the Community Department can help you out with your question. We are doing a number of research sprints this summer to map out different aspects of the Wikipedia communities and this sounds like a great question and we have some researchers available to help write the queries. So please contact me and I'll hook you up with the right people. Best, Diederik On Thu, Jun 16, 2011 at 4:40 AM, Platonides platoni...@gmail.com wrote: Alec Conroy wrote: I think I can build you something if you give me appropiate values for the above definition. Cheers Excellent-- so striking while the iron is hot-- I see that [[Special:Statistics]] defines active as edited within the last 30 days. I'm open to whoever many users we can realistically get info on-- the more the merrier, at least until I run out of ram. :) My initial query my go something like Select users where lasttouched was within the last month and total edit counts are greater than 500. And then, adding in the requirement of second project will narrow that pool. And then adding the constraint of a second project with a second language will narrow the pool even more. We're looking for the orphan community who have a lot of editors but little connection to English and Meta. I have added a small script at http://www.toolserver.org/~platonides/activeusers/activeusers.php to show active users per project and language. Requisites for appearing there are more than 500 edits (total) and at least one action (usually an edit) in the last month (since May 16, data is cached). Bots appear in the list. I'm still populating the data, but it should be completed by the time you read this. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- a href=http://about.me/diederik;Check out my about.me profile!/a ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r83141]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83141. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83141#c0 Commit summary: Reduce usage of $wgOut inside Skin. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83229]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83229. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83229#c0 Commit summary: (bug 27825) Make the raw watchlist edit messages use formatNum. Hopefully i added to the right section of RELEASE-NOTES. Wasn't sure. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83280]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r83280.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83280#c18227
Commit summary:
Follow-up r83183, r83202:
* Update SpecialCheckUser.php to new location of IP functions
* Spin out the 'hide-other-field-if-select-box-not-on-other' function as one
which should apply to all such fields, especially those created via HTMLForm.
SpecialBlockip and SpecialGlobalBlock should ultimately be converted to use
HTMLForm anyway.
Comment:
- if( $showblockoptions ) {
Why was that check shifted down?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83285]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r83285. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83285#c18228 Commit summary: Follow-up r83282: Re-add the lost $this-getNamespace() == NS_FILE, forgot to test the code for normal pages. Comment: Why was the 'nonfile-cannot-move-to-file' bit moved out? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83308]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83308. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83308#c0 Commit summary: Rewritten getSQLForCollection: faster query ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83381]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83381. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83381#c0 Commit summary: Fix bug where Commentbox was only displayed on purged pages, not on normal page view This is a workaround for the changed contents of $action since r78512. Before that change, $action was set to 'view' on normal page views. Now $action is empty if no action is given in the URL. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83405]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83405. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83405#c0 Commit summary: * Added UserGetLanguageObject hook to change the language used in $wgLang ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83434]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83434. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83434#c0 Commit summary: (follow-up r63291). *head* - *wall*. Add forgotten variable that caused invalid html with extra /li (not noticable with tidy on). Also fixes one of the two broken tests I added in r83433. The other one will have to wait for another day. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83435]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83435. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83435#c0 Commit summary: (follow-up r83434) Didn't mean to commit so fast. Fix the test for this extension I just committed that my last commit fixed. I think this is a sign I should go to bed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87338]: New comment added
User Mormegil posted a comment on MediaWiki.r87338.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87338#c18229
Commit summary:
(bug 28723) Email confirmation interface messages are not up to date
Comment:
This commit introduced nonuniformity in the terminology (''confirmation'' vs.
''verification'', ''confirm/verify'' etc.), which was fixed only partially in
the subsequent commits. Cf. [[MediaWiki:Emailcapture-success]] vs.
[[MediaWiki:Emailcapture-failure]], [[MediaWiki:Emailcapture-verify]], …
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83454]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83454. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83454#c0 Commit summary: Don't try to sleep for a negative amount of time, it causes an exception ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83466]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83466. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83466#c0 Commit summary: * Make Skin::formatDebugHTML() work with $wgDebugTimestamps = true * Removed escaping of ' since the string is defined with ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83476]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83476. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83476#c0 Commit summary: Merge corrected r81741 and resolve the TODO. Keep disabled with a class constant. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] How can I get data to map our linguistic interconnectedness?
I have added a small script at http://www.toolserver.org/~platonides/activeusers/activeusers.php to show active users per project and language. Requisites for appearing there are more than 500 edits (total) and at least one action (usually an edit) in the last month (since May 16, data is cached). Bots appear in the list. I'm still populating the data, but it should be completed by the time you read this. I have done the intersection part http://toolserver.org/~platonides/activeusers/intersection.php I find the results to be quite useless for the original goal. Almost all entries are bots. Even intersecting big wikis like de-en [1] or en-es [2], where many people is able to speak both languages, only shows one user. So my conclusion is that people stays on its home wiki, and it is very strange that someone passes 500 edits *both* on its wiki and in a foreign one. For the record, going through the whole list to get the active users took 30m26.207s. Not bad for 797 wikis. Actually doing the intersection took 3m47.916s. The app doesn't check sul accounts, instead it naively takes equal usernames as being the same person. All wikis were compared for actions after 20110516081337. The drift between that epoch and the point where the query was done was not compensated. 1-http://wolfsbane.toolserver.org/~platonides/activeusers/intersection.php?project=wikipediapairs=de|en 2-http://wolfsbane.toolserver.org/~platonides/activeusers/intersection.php?project=wikipediapairs=en|es ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r83656]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83656. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83656#c0 Commit summary: Fixing minor issues in mw.htmlform * jQuery should be mapped to $ before using it. $ should not be implied as global in-core. (return $(this).show() was using $ as global) ** added wrapper and replaced jQuery with $. * Missing semicolon ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83820]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r83820. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83820#c18230 Commit summary: Fix for r83698: pass the Title object to the skin so that we are sure to show the correct context Comment: Not sure why that broke. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83698]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83698. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83698#c0 Commit summary: Only call User::getSkin() when necessary. (With this, a parser cache hit on action=render may not load the skin at all) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83733]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83733. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83733#c0 Commit summary: First little bit of cleaning out the Augean stables of SpecialBlockip.php: spin out the suppressUserName/unsuppressUserName functions into their own file, to keep them with the rest of the RevDel stuff. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88988]: Revision status changed
User Platonides changed the status of MediaWiki.r88988. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88988#c0 Commit summary: bug 29123: record use of the editsection option so that users who can't edit (or have section edit links disabled) get a different cache key; also simplify freaky code layout (briefly tested, seem to work) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83785]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83785. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83785#c0 Commit summary: Fix switch fail in r83778: add missing break. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90214]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90214. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90214#c0 Commit summary: Revert r88988 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83786]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r83786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83786#c18231 Commit summary: Divert a river through the Augean Stables that is SpecialBlockip.php. * Move to SpecialBlock.php, and rename class appropriately * Complete refactor * Use HTMLForm in block form. This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM). * Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still) * Invert some of the block options so that every checkbox makes the block more severe (so check to disable email is fine, but check to allow usertalk edit (default true) is inverted to check to disable usertalk edit (default false). * revert r40359 (move doMassUserBlock() to core). No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere. Comment: Should have used svn move for the specialblockip rename (for easier diffs). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89948]: New comment added, and revision status changed
User Platonides changed the status of MediaWiki.r89948. Old Status: new New Status: ok User Platonides also posted a comment on MediaWiki.r89948. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89948#c18232 Commit summary: * Fix I18nTags #languagename to use ParserOptions::getUserLang() * Fix ParserOptions::getUserLang() to return code as documented Comment: Actually, I think there was some code down at wfMsg* so that both may have worked. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83790]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83790. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83790#c0 Commit summary: Follow-up r83786, try to keep the svn history of SpecialBlockip. This rev will be broken. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83282]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83282. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83282#c0 Commit summary: Move the file related parts of Title::isValidMoveOperation to its own function, Title::validateFileMoveOperation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83285]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83285. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83285#c0 Commit summary: Follow-up r83282: Re-add the lost $this-getNamespace() == NS_FILE, forgot to test the code for normal pages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84028]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84028. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84028#c0 Commit summary: Fix notice from TWN, reported in r83786 CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84269]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84269. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84269#c0 Commit summary: Follow-up r83909, r83825: update special page aliases for all languages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] wikistream: displays wikipedia updates in realtime
On Wed, Jun 15, 2011 at 9:40 PM, Ed Summers e...@pobox.com wrote: I've been looking to experiment with node.js lately and created a little toy webapp that displays updates from the major language wikipedias in real time: http://wikistream.inkdroid.org That's pretty cool -- and having the source all ready to be shared on github is *super* cool. :D Having good starting points for other people to build real-time displays and visualizations on can be a big help in jumpstarting some really cool innovation. I'd love to see some more active visualization that also include images, and if it's possible to show interactions between multiple people working on the same pages that could be super killer. :) As noted in this thread already, use of flags to represent languages can be problematic -- there's a nice overview of the issues here: http://www.cs.tut.fi/~jkorpela/flags.html On the other hand, flags can be a fine way to represent 'country of origin' in visualizations/reports that estimate where edits are being made from based on IP address etc -- so keep em in mind! -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How can I get data to map our linguistic interconnectedness?
On Thu, Jun 16, 2011 at 9:44 AM, Platonides platoni...@gmail.com wrote: So my conclusion is that people stays on its home wiki, and it is very strange that someone passes 500 edits *both* on its wiki and in a foreign one. Agreed, I don't think this is a surprising result. If we can filter out bots and contribs that have been imported/exported (maybe via the logs?) then I think it would be more useful to lower the bar. Perhaps at least 100 edits on their home wiki, and 10 edits on another? Steven ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90127]: New comment added
User Salvatore Ingala posted a comment on MediaWiki.r90127. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90127#c18233 Commit summary: Replaced static methods to get/set preferences and preference descriptions with member functions. Comment: Dofinitely true; done in r90216, thank you. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87338]: New comment added
User Krinkle posted a comment on MediaWiki.r87338. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87338#c18234 Commit summary: (bug 28723) Email confirmation interface messages are not up to date Comment: I suggest switching to 'confirm' as that's also used in MediaWiki core for similar action. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83786]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r83786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83786#c18235 Commit summary: Divert a river through the Augean Stables that is SpecialBlockip.php. * Move to SpecialBlock.php, and rename class appropriately * Complete refactor * Use HTMLForm in block form. This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM). * Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still) * Invert some of the block options so that every checkbox makes the block more severe (so check to disable email is fine, but check to allow usertalk edit (default true) is inverted to check to disable usertalk edit (default false). * revert r40359 (move doMassUserBlock() to core). No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere. Comment: + # Should be unreachable; Can this just throw an exception? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83786]: New comment added
User Krinkle posted a comment on MediaWiki.r83786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83786#c18236 Commit summary: Divert a river through the Augean Stables that is SpecialBlockip.php. * Move to SpecialBlock.php, and rename class appropriately * Complete refactor * Use HTMLForm in block form. This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM). * Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still) * Invert some of the block options so that every checkbox makes the block more severe (so check to disable email is fine, but check to allow usertalk edit (default true) is inverted to check to disable usertalk edit (default false). * revert r40359 (move doMassUserBlock() to core). No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere. Comment: Not just diffing, what about svn history ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90217]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r90217. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90217#c18237 Commit summary: * (bug 29091) Fix form of native name for Ossetic language (Иронау - Ирон) Comment: Needs merge to 1.17, 1.18, and deployment branch. One-line localization fix for grammatical form of language name. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83786]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r83786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83786#c18238 Commit summary: Divert a river through the Augean Stables that is SpecialBlockip.php. * Move to SpecialBlock.php, and rename class appropriately * Complete refactor * Use HTMLForm in block form. This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM). * Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still) * Invert some of the block options so that every checkbox makes the block more severe (so check to disable email is fine, but check to allow usertalk edit (default true) is inverted to check to disable usertalk edit (default false). * revert r40359 (move doMassUserBlock() to core). No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere. Comment: Looks like some follow-ups handled this. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83786]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r83786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83786#c18239 Commit summary: Divert a river through the Augean Stables that is SpecialBlockip.php. * Move to SpecialBlock.php, and rename class appropriately * Complete refactor * Use HTMLForm in block form. This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM). * Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still) * Invert some of the block options so that every checkbox makes the block more severe (so check to disable email is fine, but check to allow usertalk edit (default true) is inverted to check to disable usertalk edit (default false). * revert r40359 (move doMassUserBlock() to core). No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere. Comment: Perhaps checkUnblockSelf() could be optimized a tad to check $wgUser-isBlocked() before the newFromName/newFromId stuff. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83786]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83786. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83786#c0 Commit summary: Divert a river through the Augean Stables that is SpecialBlockip.php. * Move to SpecialBlock.php, and rename class appropriately * Complete refactor * Use HTMLForm in block form. This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM). * Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still) * Invert some of the block options so that every checkbox makes the block more severe (so check to disable email is fine, but check to allow usertalk edit (default true) is inverted to check to disable usertalk edit (default false). * revert r40359 (move doMassUserBlock() to core). No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83795]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83795. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83795#c0 Commit summary: Follow-up r83794, r83792: restore new SpecialBlock.php code from r83786. This revision should *not* be broken :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83788]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83788. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83788#c0 Commit summary: Make this extension use $wgContLang, not $wgLang, since its a parser hook, so the result gets stored in the parserCache, so it shouldn't vary by user language. Change the wfMsg - wfMsgForContent for same reason. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90191]: New comment added
User Kaldari posted a comment on MediaWiki.r90191. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90191#c18240 Commit summary: make it so that images always work regardless of whether they include the prefix or not Comment: Fixed in r90220. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90219]: New comment added
User Hashar posted a comment on MediaWiki.r90219.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90219#c18241
Commit summary:
* (bug 29426) Fix wrong use of Block::load's second parameter in BlockTest
It was accidentally passing a username where it should have passed a user ID,
causing PostgreSQL's stricter comparisons to fail, while MySQL's allowed it to
run without complaint but returned bad results.
Of course that bug got hidden by the test testing the wrong thing... :)
Now correctly loads using the user id instead of name, checks the proper return
values, and actually compares the right object.
Comment:
Maybe block::load() should throw an exception if the second parameter ($user)
is not an integer?
I don't think PHP allow type hinting in functions or we could have wrotten
something like:
function /*block - */ load( string $address = nowiki''/nowiki, int $user
= 0 ) { .. }
^^^^^
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r71412]: New comment added
User Platonides posted a comment on MediaWiki.r71412. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71412#c18242 Commit summary: Added $wgAdaptiveMessageCache to avoid caching huge pile of never used messages at twn. Comment: Does TWN still need it? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90218]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90218. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90218#c0 Commit summary: Removed usage of error suppression operator ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90219]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90219. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90219#c0 Commit summary: * (bug 29426) Fix wrong use of Block::load's second parameter in BlockTest It was accidentally passing a username where it should have passed a user ID, causing PostgreSQL's stricter comparisons to fail, while MySQL's allowed it to run without complaint but returned bad results. Of course that bug got hidden by the test testing the wrong thing... :) Now correctly loads using the user id instead of name, checks the proper return values, and actually compares the right object. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83824]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83824. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83824#c0 Commit summary: Fix totally-broken r83810. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83810]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83810. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83810#c0 Commit summary: * Moved Target field validation into a field validation callback to show erros next to the field * Some changes to comments and one addHtml - addWikiMsg ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83811]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83811. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83811#c0 Commit summary: Follow-up r83809 r83810: improved documentation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90010]: Revision status changed
User NeilK changed the status of MediaWiki.r90010. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90010#c0 Commit summary: Use standard relative path for load.php (requires, as the rest of the bits do, that $wgExtensionAssetsPath be the default or equivalent) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89933]: Revision status changed
User NeilK changed the status of MediaWiki.r89933. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89933#c0 Commit summary: Revert r89917 for now. Message keys conlicts with core messages w/exception of 'size-terabytes' = '$1 TB'. If this is needed I suggest to add it in core and fix Language::formatSize(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83827]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83827. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83827#c0 Commit summary: Follow-up r83825: fix Block::parseTarget to recognise autoblocks separately, and change Block::getRedactedName() to run the string through a system message for localisation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83825]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83825. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83825#c0 Commit summary: Some refactoring in Block.php and SpecialBlock.php: move backend stuff into Block.php, and expand the parseTargetAndType() functions to recognise blocks referenced by their block id. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83849]: New comment added, and revision status changed
User Aaron Schulz changed the status of MediaWiki.r83849. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r83849. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83849#c18244 Commit summary: * (bug 26630) Add api for Special:ActiveUsers Not sure if this would be better having been done as list=activeusers or something... Meh, done! :P Comment: + showHiddenUsersAddBlockInfo Is adding that filter a serious bug fix (mergable)? Also, I that function has a confusing name. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83855]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r83855. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83855#c18245 Commit summary: Further massive rewrite of the blocking frontend: spin out unblocking into a new SpecialUnblock.php. This leaves IPBlockList as, astonishingly enough, a list of blocks... :D Comment: + $res['id'] = $block-mId; Are there accessors for this stuff? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84006]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84006. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84006#c0 Commit summary: Fix exception on TWN raised in r83855 CR. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] BlockTest bugs resolved -- test board is clear!
On 16/06/11 02:54, MZMcBride wrote: Brion Vibber wrote: Full story if you like. :D - http://etherpad.wikimedia.org/Block-test-bug Pasting below from the pad. Sorry, I trust the mailing list archives more than I trust Etherpad. (Do Etherpads have a license for contributions to them? Is it assumed to be the same as wiki contributions?) MZMcBride Go ahead and copy/paste it to mw.org ? :-) -- Ashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Unit testing now working - break it and be reverted
On 15/06/11 23:02, Chad wrote: Hi everyone, Painstakingly, all of the unit tests are now passing on cruise control (Sqlite) and my local install (Sqlite Mysql). This is as of r90150 [0]. Thank you immensely to Brion for finally tracking down and eliminating that pesky BlockTest bug. Congratulations to everyone involved in solving this long standing issue! This means? We know that according to what we have covered by PHPUnit (barring things marked incomplete/skipped), everything is currently working. Please note the 1.18 build target does not include tests in the 'database' group (cause they are heavily slow). So one could break REL1_18 without noticing. I'd like for Max to turn IRC annoyances back on with the codurr bot for CC failures. From here on out, I'm going to take the stance that if you break a test, it must be fixed or reverted on sight. The REL1_18 build is published in a file named irc-publish-REL1_18.txt :) -- Ashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r71412]: New comment added
User Nikerabbit posted a comment on MediaWiki.r71412. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71412#c18246 Commit summary: Added $wgAdaptiveMessageCache to avoid caching huge pile of never used messages at twn. Comment: Yes, we haven't moved translations away from NS_MEDIAWIKI yet. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Unit testing now working - break it and be reverted
On Thu, Jun 16, 2011 at 3:44 PM, Ashar Voultoiz hashar+...@free.fr wrote: Please note the 1.18 build target does not include tests in the 'database' group (cause they are heavily slow). So one could break REL1_18 without noticing. Well none of this phpunit work since the branch point has been backported, so I imagine REL1_18 is still pretty broken too. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89948]: New comment added
User Nikerabbit posted a comment on MediaWiki.r89948. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89948#c18247 Commit summary: * Fix I18nTags #languagename to use ParserOptions::getUserLang() * Fix ParserOptions::getUserLang() to return code as documented Comment: What both would have worked? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83855]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83855. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83855#c0 Commit summary: Further massive rewrite of the blocking frontend: spin out unblocking into a new SpecialUnblock.php. This leaves IPBlockList as, astonishingly enough, a list of blocks... :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83872]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83872. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83872#c0 Commit summary: Added test for bug 27993 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83886]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83886. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83886#c0 Commit summary: * Fixed bug 27993: in Wikidiff2::explodeWords(), the iterator pBrk is invalidated by breaks.insert(). So move the breaks.insert() calls before the pBrk initialisation. Updated some minor details in Nikerabbit's test file. * Updated tests for r80621 and r82906. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] How can I get data to map our linguistic interconnectedness?
You might also get better results when you don't limit yourself to recent contributions. For example, I contributed heavily to the Dutch Wikipedia a few years ago, and now contribute heavily to the English. I don't appear in Platonides's list, because I hardly edit nl: at all any more. There may be more people like that. Jelle Zijlstra 2011/6/16 Steven Walling steven.wall...@gmail.com On Thu, Jun 16, 2011 at 9:44 AM, Platonides platoni...@gmail.com wrote: So my conclusion is that people stays on its home wiki, and it is very strange that someone passes 500 edits *both* on its wiki and in a foreign one. Agreed, I don't think this is a surprising result. If we can filter out bots and contribs that have been imported/exported (maybe via the logs?) then I think it would be more useful to lower the bar. Perhaps at least 100 edits on their home wiki, and 10 edits on another? Steven ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r83909]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r83909. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83909#c18248 Commit summary: Complete the trinity of blocking frontend interfaces by rewriting SpecialIpblocklist: * Move and rename to SpecialBlockList * Use an HTMLForm in GET mode for the options form * Use TablePager to organise the results more nicely * Standardise the filtration for IPs and IP ranges, so looking at blocks for a range will now also show rangeblocks which contain the range * General tidy up Comment: Can TWN handle the renaming of the 'ipblocklist' messages? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83966]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83966. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83966#c0 Commit summary: Follow-up r83909, fix errors seen on TWN reported in CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83973]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83973. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83973#c0 Commit summary: Follow-up r83909: fix error on TWN ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89948]: New comment added
User Platonides posted a comment on MediaWiki.r89948. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89948#c18249 Commit summary: * Fix I18nTags #languagename to use ParserOptions::getUserLang() * Fix ParserOptions::getUserLang() to return code as documented Comment: Passing either a language code or a language object. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86714]: New comment added
User Nikerabbit posted a comment on MediaWiki.r86714. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86714#c18252 Commit summary: Allow extensions to customize the search forms. This required some cleanup and refactoring to special:search and search engine. Should be fully backwards compatible. Lightly tested, but only with MySQL search backend. Introduces concept of search profiles, which replace long list of namespaces in the url. Comment: What would be a good place to add that documentation? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86705]: New comment added
User Reedy posted a comment on MediaWiki.r86705.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86705#c18253
Commit summary:
* Remove manual query building in search mysql
* Remove reference to mysql3, no longer supported
* Changed method signatures, I found no class extending this class in extensions
* Tested lightly and returns same results
Comment:
I can see why it seems to be failing, but it seems like SearchEngineTest is
being wrongly called, This class is not directly tested. Instead it is
extended by SearchDbTest.
So it should work if started from the other file?
Can't actually test, my tests look teh broken
pre
reedy@ubuntu64-esxi:~/mediawiki/trunk/phase3/tests/phpunit$ php phpunit.php
includes/search/SearchDbTest.php
Warning: require_once(PHP/CodeCoverage/Filter.php): failed to open stream: No
such file or directory in /usr/share/php/PHPUnit/Autoload.php on line 46
Call Stack:
0.0003 657328 1. {main}()
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:0
0.5454 17283808 2. require_once('/usr/share/php/PHPUnit/Autoload.php')
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:57
Fatal error: require_once(): Failed opening required
'PHP/CodeCoverage/Filter.php' (include_path='.:/usr/share/php:/usr/share/pear')
in /usr/share/php/PHPUnit/Autoload.php on line 46
Call Stack:
0.0003 657328 1. {main}()
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:0
0.5454 17283808 2. require_once('/usr/share/php/PHPUnit/Autoload.php')
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:57
reedy@ubuntu64-esxi:~/mediawiki/trunk/phase3/tests/phpunit$ php phpunit.php
includes/search/SearchEngineTest.php
Warning: require_once(PHP/CodeCoverage/Filter.php): failed to open stream: No
such file or directory in /usr/share/php/PHPUnit/Autoload.php on line 46
Call Stack:
0.0003 657328 1. {main}()
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:0
0.5430 17283808 2. require_once('/usr/share/php/PHPUnit/Autoload.php')
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:57
Fatal error: require_once(): Failed opening required
'PHP/CodeCoverage/Filter.php' (include_path='.:/usr/share/php:/usr/share/pear')
in /usr/share/php/PHPUnit/Autoload.php on line 46
Call Stack:
0.0003 657328 1. {main}()
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:0
0.5430 17283808 2. require_once('/usr/share/php/PHPUnit/Autoload.php')
/home/reedy/mediawiki/trunk/phase3/tests/phpunit/phpunit.php:57
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Unit testing now working - break it and be reverted
Can somebody on Windows/SQLite try running the tests? I'm consistently getting two failures in XmlTest, which Chad apparently is not getting: 1) XmlSelectTest::testSetDefault Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ selectoption value=foo1foo1/option option value=bar1 selected=selectedbar1/option option value=foo2foo2/option/select D:\Bryan\workspace\phase3\tests\phpunit\includes\XmlSelectTest.php:84 D:\Bryan\workspace\phase3\tests\phpunit\MediaWikiTestCase.php:64 D:\Bryan\workspace\phase3\tests\phpunit\MediaWikiPHPUnitCommand.php:20 D:\Bryan\workspace\phase3\tests\phpunit\phpunit.php:60 2) XmlTest::testDateMenu Date menu for february 2011 Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ label for=yearFrom year (and earlier):/label input name=year size=4 value=2011 id=year maxlength=4 / label for=monthFrom month (and earlier):/label select id=month name=month class=mw-month-selectoroption v alue=-1all/option option value=1January/option option value=2 selected=selectedFebruary/option option value=3March/option option value=4April/option option value=5May/option option value=6June/option option value=7July/option option value=8August/option option value=9September/option option value=10October/option option value=11November/option option value=12December/option/select D:\Bryan\workspace\phase3\tests\phpunit\includes\XmlTest.php:118 D:\Bryan\workspace\phase3\tests\phpunit\MediaWikiTestCase.php:64 D:\Bryan\workspace\phase3\tests\phpunit\MediaWikiPHPUnitCommand.php:20 D:\Bryan\workspace\phase3\tests\phpunit\phpunit.php:60 -- ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r83909]: New comment added, and revision status changed
User Aaron Schulz changed the status of MediaWiki.r83909.
Old Status: new
New Status: fixme
User Aaron Schulz also posted a comment on MediaWiki.r83909.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83909#c18254
Commit summary:
Complete the trinity of blocking frontend interfaces by rewriting
SpecialIpblocklist:
* Move and rename to SpecialBlockList
* Use an HTMLForm in GET mode for the options form
* Use TablePager to organise the results more nicely
* Standardise the filtration for IPs and IP ranges, so looking at blocks for a
range will now also show rangeblocks which contain the range
* General tidy up
Comment:
pre+ $formatted = wfMessage( 'autoblockid', $row-ipb_id );/pre
How does that work? Should it return HTML?
pre+ static $headers = null;/pre
Why does getFieldNames() use a static var? Is it called often or something?
preline 123 if ( !$wgUser-isAllowed( 'hideuser' ) ){/pre
This check is already there in the Pager class.
pre
+ protected static function getIpFragment( $ip ){
+ global $wgBlockCIDRLimit;
+ if( IP::isIPv4( $ip ) ){
+ $hexAddress = IP::toHex( $ip );
+ return substr( $hexAddress, 0, wfBaseconvert(
$wgBlockCIDRLimit['IPv4'], 10, 16 ) );
+ } elseif( IP::isIPv6( $ip ) ) {
+ $hexAddress = substr( IP::toHex( $ip ), 2 );
+ return 'v6-' . substr( $hexAddress, 0, wfBaseconvert(
$wgBlockCIDRLimit['IPv6'], 10, 16 ) );
/pre
I don't think this works like you think. Try:
pre
$hexAddress = IP::toHex( '122.114.14.5' );
var_dump( $hexAddress );
var_dump( wfBaseconvert( 16, 10, 16 ) );
var_dump( $hexAddress, 0, wfBaseconvert( 16, 10, 16 ) );
/pre
Which gives...
pre
string(8) 7A720E05
string(2) 10
string(8) 7A720E05
/pre
If the min prefix is 16 bits, and each hex char is 4 bits, you'd want
floor(16/4) = 4. Maybe use ($wgBlockCIDRLimit['IPv4']/4) in place of
wfBaseconvert( $wgBlockCIDRLimit['IPv4'], 10, 16 ) and likewise for v6?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83909]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r83909. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83909#c18255 Commit summary: Complete the trinity of blocking frontend interfaces by rewriting SpecialIpblocklist: * Move and rename to SpecialBlockList * Use an HTMLForm in GET mode for the options form * Use TablePager to organise the results more nicely * Standardise the filtration for IPs and IP ranges, so looking at blocks for a range will now also show rangeblocks which contain the range * General tidy up Comment: Gah, for the test code, I meant: pre $hexAddress = IP::toHex( '122.114.14.5' ); var_dump( $hexAddress ); var_dump( wfBaseconvert( 16, 10, 16 ) ); var_dump( substr( $hexAddress, 0, wfBaseconvert( 16, 10, 16 ) ) ); /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90232]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r90232. Old Status: new New Status: reverted User Krinkle also posted a comment on MediaWiki.r90232. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90232#c18256 Commit summary: Implement mw.Title in core * Based on UploadWizard/resources/mw.Title.js * Refactored to use local scope and prototypes instead of per-instance private scope (less references, faster instantiation) * Fix potential ReferenceError in the check for wgArticlePath (inline if statements will fail to evaluate for undeclared variables). Using mw.config instead * The following were not ported because they are or were already redundant and/or merged with another method: -- setNameText (redundant with the improved setName) -- setPrefix (redundant wit the improved setNamespace) * Ported all jasmine tests to QUnit. Left them exactly the same to make sure it's compatible with UploadWizard. Perhaps I'll expand or adjust the suite later to be less file-specific, but for now make sure it's compatible and the same. @todo FIXME * Removed assumption that every title has a namespace prefix in it by creating a separate RegExp when there is a namespace given ** Fixes strip-bug in cases where a namespace appears to be part of a title when the namespace is also given: Project:User:Foobar new mw.Title( 'User:Foobar', 4 ).toString() 'Project:Foobar' ** Fixes a thrown exception in case a colon is part of the title (colons are valid in MediaWiki pagenames!) new mw.Title( 'Just some:Random page') Error: mw.Title Unrecognized canonical namespace: just_some * Added check for capitalLinks et (wasn't possible before due to bug X) ** Prevents breakages on wiktionary and other wikis with case sensitivity. Comment: Self-reverting r90233. I messed up horribly in svn. Git *dun dun dun* ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Unit testing now working - break it and be reverted
On Thu, Jun 16, 2011 at 4:08 PM, Bryan Tong Minh bryan.tongm...@gmail.com wrote: Can somebody on Windows/SQLite try running the tests? I'm consistently getting two failures in XmlTest, which Chad apparently is not getting: To hijack, what output from the unit tests should be reported, Errors and failures? From Linux/Pg (possibly caused by LocalSettings config?): There was 1 error: 1) BlockTest::testInitializerFunctionsReturnCorrectBlock Argument 1 passed to Block::equals() must be an instance of Block, null given, called in /var/www/thedarkcitadel.com/w/tests/phpunit/includes/BlockTest.php on line 72 and defined /var/www/thedarkcitadel.com/w/includes/Block.php:133 /var/www/thedarkcitadel.com/w/tests/phpunit/includes/BlockTest.php:72 /var/www/thedarkcitadel.com/w/tests/phpunit/MediaWikiTestCase.php:61 /var/www/thedarkcitadel.com/w/tests/phpunit/MediaWikiPHPUnitCommand.php:20 /var/www/thedarkcitadel.com/w/tests/phpunit/phpunit.php:60 There were 4 failures: 1) ApiUploadTest::testUpload Failed asserting that boolean:false is true. /var/www/thedarkcitadel.com/w/tests/phpunit/includes/api/ApiUploadTest.php:144 /var/www/thedarkcitadel.com/w/tests/phpunit/MediaWikiTestCase.php:61 /var/www/thedarkcitadel.com/w/tests/phpunit/MediaWikiPHPUnitCommand.php:20 /var/www/thedarkcitadel.com/w/tests/phpunit/phpunit.php:60 2) ApiUploadTest::testUploadSameFileName Failed asserting that boolean:false is true. /var/www/thedarkcitadel.com/w/tests/phpunit/includes/api/ApiUploadTest.php:242 /var/www/thedarkcitadel.com/w/tests/phpunit/MediaWikiTestCase.php:61 /var/www/thedarkcitadel.com/w/tests/phpunit/MediaWikiPHPUnitCommand.php:20 /var/www/thedarkcitadel.com/w/tests/phpunit/phpunit.php:60 3) ApiUploadTest::testUploadSameContent Failed asserting that boolean:false is true. /var/www/thedarkcitadel.com/w/tests/phpunit/includes/api/ApiUploadTest.php:316 /var/www/thedarkcitadel.com/w/tests/phpunit/MediaWikiTestCase.php:61 /var/www/thedarkcitadel.com/w/tests/phpunit/MediaWikiPHPUnitCommand.php:20 /var/www/thedarkcitadel.com/w/tests/phpunit/phpunit.php:60 4) ApiUploadTest::testUploadStash Failed asserting that boolean:true is false. /var/www/thedarkcitadel.com/w/tests/phpunit/includes/api/ApiUploadTest.php:398 /var/www/thedarkcitadel.com/w/tests/phpunit/MediaWikiTestCase.php:61 /var/www/thedarkcitadel.com/w/tests/phpunit/MediaWikiPHPUnitCommand.php:20 /var/www/thedarkcitadel.com/w/tests/phpunit/phpunit.php:60 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How can I get data to map our linguistic interconnectedness?
Jelle Zijlstra wrote: You might also get better results when you don't limit yourself to recent contributions. For example, I contributed heavily to the Dutch Wikipedia a few years ago, and now contribute heavily to the English. I don't appear in Platonides's list, because I hardly edit nl: at all any more. There may be more people like that. Jelle Zijlstra Maybe we should broad the span for being active. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How can I get data to map our linguistic interconnectedness?
I would say broaden the span and lower the number of contribs required just a little (maybe 300?). 2011/6/16 Platonides platoni...@gmail.com: Jelle Zijlstra wrote: You might also get better results when you don't limit yourself to recent contributions. For example, I contributed heavily to the Dutch Wikipedia a few years ago, and now contribute heavily to the English. I don't appear in Platonides's list, because I hardly edit nl: at all any more. There may be more people like that. Jelle Zijlstra Maybe we should broad the span for being active. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How can I get data to map our linguistic interconnectedness?
Or look for actives on one wiki.. and then cross check those names with all the other wikis for the same names with over, say, 300 edits (at any time). Tom On 16 June 2011 22:34, M. Williamson node...@gmail.com wrote: I would say broaden the span and lower the number of contribs required just a little (maybe 300?). 2011/6/16 Platonides platoni...@gmail.com: Jelle Zijlstra wrote: You might also get better results when you don't limit yourself to recent contributions. For example, I contributed heavily to the Dutch Wikipedia a few years ago, and now contribute heavily to the English. I don't appear in Platonides's list, because I hardly edit nl: at all any more. There may be more people like that. Jelle Zijlstra Maybe we should broad the span for being active. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How can I get data to map our linguistic interconnectedness?
Thomas Morton wrote: Or look for actives on one wiki.. and then cross check those names with all the other wikis for the same names with over, say, 300 edits (at any time). Tom The edit count is are already looking at the full count, in the last month only one is needed. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90234]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r90234. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r90234. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90234#c18257 Commit summary: (bug 29441) Expose CapitalLinks config in JS to allow modules to properly handle titles on case-sensitive wikis. This brings us one step closer towards: (bug 29397) Implement mw.Title module in core Comment: Looks good; should be able to do a simple $.inArray() on the NS id to get the setting. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84035]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84035. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84035#c0 Commit summary: $wgTitle - $this-getTitle() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90233]: Revision status changed
User Reedy changed the status of MediaWiki.r90233. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90233#c0 Commit summary: Revert r90232. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84083]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84083. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84083#c0 Commit summary: Removed usage of extract() in LinkHolderArray::doVariants() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90236]: Revision status changed
User Reedy changed the status of MediaWiki.r90236. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90236#c0 Commit summary: added missing semicolon ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84120]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r84120. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84120#c18258 Commit summary: changed CamelCase to lowercasecrammedtogether Comment: This is OK as a breaking change? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84120]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r84120. Old Status: new New Status: ok User Reedy also posted a comment on MediaWiki.r84120. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84120#c18259 Commit summary: changed CamelCase to lowercasecrammedtogether Comment: It was changed on the same day as creation. r84119, so it's not really a breaking change ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
