[MediaWiki-CodeReview] [MediaWiki r84251]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r84251. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84251#c18274 Commit summary: First forays into the swamp of the Block.php backend: * Move Block::parseExpiryInput() to the frontend SpecialBlock::parseExpiryInput() * consolidate the several implementations of the MediaWiki:Ipblockoptions parsing into SpecialBlock::getSuggestedDurations() Comment: pre+ $user-isAllowed( 'ipblock-exempt', 'globalblock-exempt' )/pre Wasn't the OR behavior of isAllowed() changed reverted? Also, I'm not sure I like the move of Block::parseExpiryInput(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84268]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84268. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84268#c0 Commit summary: Fix borked r84266. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84266]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84266. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84266#c0 Commit summary: Follow-up r84249: reimplement isAllowedAny(), and restore isAllowed() to only-accepting-one-parameter mode for the time being. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84249]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84249. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84249#c0 Commit summary: Allow User::isAllowed() to take varargs. is allowed X or Y is by far the more common multiple permission check in core, so this is now the behaviour of isAllowed( X, Y ); also add isAllowedAll(...) for testing is allowed X and Y. Has the nice side effect of adding visibility to a very old function. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84254]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r84254. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84254#c18276 Commit summary: documentation for BacklinkCache class - still need examples - could use peer review - no functional changes Comment: pre+ * Returns an array giving the start and end of each range. The firsti/pre Typo there. pre+ // 1) try this per process cache first/pre I don't get that comment. Aren't both the cache variables per process? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84255]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84255. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84255#c0 Commit summary: BacklinkCache: explicit properties visibility ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90259]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90259. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90259#c0 Commit summary: Remove useless check for wfFindFile() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84660]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r84660. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84660#c18277 Commit summary: (follow-up 79778) Make $wgLang-truncate function consider the length of the ... (ellipsis message) in the truncation length. The length of this message varries by localization, so the previous solution of telling truncate to truncate 5 bytes less than needed is not good since this will be too little or too much. Updated places where its used. Some places I left as is, as it looked like the new behaviour would work fine for them to. (for example, the autosummary feature - it was cutting off at 200 bytes, which is no where near 250 limit, so I presume that was for asethic reasons rather then to fit as much in before the db limit). Will do another commit for extension callers in a moment. Comment: I've seen brion use it before...not sure if we have protocol for that. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84660]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84660. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84660#c0 Commit summary: (follow-up 79778) Make $wgLang-truncate function consider the length of the ... (ellipsis message) in the truncation length. The length of this message varries by localization, so the previous solution of telling truncate to truncate 5 bytes less than needed is not good since this will be too little or too much. Updated places where its used. Some places I left as is, as it looked like the new behaviour would work fine for them to. (for example, the autosummary feature - it was cutting off at 200 bytes, which is no where near 250 limit, so I presume that was for asethic reasons rather then to fit as much in before the db limit). Will do another commit for extension callers in a moment. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r75343]: New comment added, and revision status changed
User Tim Starling changed the status of MediaWiki.r75343. Old Status: resolved New Status: fixme User Tim Starling also posted a comment on MediaWiki.r75343. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75343#c18278 Commit summary: (bug 24853) Kill failFunction - Fixed! :D Comment: This broke failover in LoadBalancer and caused 15 minutes of downtime on the English Wikipedia (bug 29233). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r75343]: New comment added
User Reedy posted a comment on MediaWiki.r75343.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75343#c18279
Commit summary:
(bug 24853) Kill failFunction - Fixed! :D
Comment:
Surely it's more likely to have actually been r75341?
source lang=php
- if ( $this-mFailFunction ) {
- $conn-failFunction( $this-mFailFunction );
- $conn-reportConnectionError( $this-mLastError
);
- } else {
- // If all servers were busy, mLastError will
contain something sensible
- throw new DBConnectionError( $conn,
$this-mLastError );
- }
+ // If all servers were busy, mLastError will contain
something sensible
+ throw new DBConnectionError( $conn, $this-mLastError );
/source
And unless I'm missing something, it seems rare/I'm struggling to see where it
wasn't set to false, and hence, would have actually have been called
somewhere...
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90230]: Revision status changed
User MaxSem changed the status of MediaWiki.r90230. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90230#c0 Commit summary: Mark as needing a db. Remove double data insertion ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added
User Nikerabbit posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c18280 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while... Comment: Wiki.php is full of __get __set abuse. pre tail -n 5000 logs/error_php | grep Notice | cut -d -f 3- | sort | uniq -c | sort -n | grep deprecated 83 PHP Notice: Use of RequestContext::__set() is deprecated; use $context-setFoo() instead is deprecated. [Called from MediaWiki::initializeArticle in /www/w/includes/Wiki.php at line 304] in /www/w/includes/GlobalFunctions.php on line 3342 170 PHP Notice: Use of RequestContext::__get() is deprecated; use $context-getFoo() instead is deprecated. [Called from MediaWiki::parseTitle in /www/w/includes/Wiki.php at line 36] in /www/w/includes/GlobalFunctions.php on line 3342 /pre First one already reported almost two weeks ago. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90240]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90240. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90240#c18281 Commit summary: CodeEditor ext: basic ability to toggle the syntax-highlighting editor on/off. When off, we restore the regular textarea and its behavior. State is saved as a cookie, like other WikiEditor settings. Comment: Toggle is difficult to translate in some languages. Can we make it a so that it changes text depending on the state? + 'codeeditor-toolbar-toggle' = 'Toggle syntax highlighting', ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r75343]: New comment added
User Tim Starling posted a comment on MediaWiki.r75343. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75343#c18282 Commit summary: (bug 24853) Kill failFunction - Fixed! :D Comment: I guess so, I'll mark that one fixme as well. The one place where it wasn't false was the place where almost all database objects are constructed: - $db = new $class( $host, $user, $password, $dbname, 1, $flags ); + $db = new $class( $host, $user, $password, $dbname, $flags ); ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r75341]: New comment added, and revision status changed
User Tim Starling changed the status of MediaWiki.r75341. Old Status: ok New Status: fixme User Tim Starling also posted a comment on MediaWiki.r75341. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75341#c18283 Commit summary: Start of bug 24853, killing off 'functional' parts of failfunction code. Seems when the constructors start getting changed, it starts borking. Using this as a point of reversion/stashing Comment: Fixme as per CR r75343. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90253]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90253. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90253#c0 Commit summary: Added 2nd parameter, '0', to 'new Article()' - I'm told that this is recommended ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r75341]: New comment added
User Reedy posted a comment on MediaWiki.r75341. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75341#c18284 Commit summary: Start of bug 24853, killing off 'functional' parts of failfunction code. Seems when the constructors start getting changed, it starts borking. Using this as a point of reversion/stashing Comment: bug 29233 What exactly is needed to be done to fix this...? It seems there isn't much of the code that obviously does something, so it's something subtle. There is the removal of the reportConnectionError call, which only just did the throwing of a new DBConnectionError, just from a different place, so the same behaviour occurs... The $conn-failFunction calls were essentially no-ops, just propagating the value of mFailFunction from the load balancer stuff, out to the connection, which was defaulted to false. There is the one setting of failFunction to 1 in the LoadBalancer Constructor ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Wikimedia Foundation hiring for several positions
I know this might be offtopic, but people on this list seem likely to be interested or know people who are. The Wikimedia Foundation has an open call for independent contractors for the position Networking Contractor Amsterdam and just added two more calls: Internationalization and Localization Outreach and Internationalization and Localization Feature Development. The tech team is also currently looking to hire for the following positions (and the following list will of course change): * Operations Engineer * Software Developer (Features) * Systems Engineer - Data Analytics * Product Manager (Features) * Software Developer Rich Text Editing (Features) * Software Developer Frontend * Software Developer Backend * Quality Assurance Lead * Product Manager (Analytics) All the job descriptions, required and desired qualifications, and application instructions are on the Job Openings page: http://wikimediafoundation.org/wiki/Job_openings (and there are also job openings there for other Foundation departments, like Global Development). As the job openings page says: The positions listed here are based in our San Francisco headquarters, but in some cases we may be open to the possibility of people working remotely, unless otherwise noted in the job posting itself. If you are not currently living in the San Francisco Bay Area, and are not willing to relocate there, please make that clear in your cover letter. -Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added
User Nikerabbit posted a comment on MediaWiki.r85302. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c18285 Commit summary: Instead of creating an OutputPage and then setting a context start initializing OutputPages 'with' a context and send depreciated calls to extensions directly creating OutputPage instances. Now that we've taken care of the mess of mTitle inside OutputPage and Skin and made RequestContext track Skin instead of $wgUser we don't need the hack in SpecialPage anymore. Comment: PHP Notice: Use of OutputPage::__construct is deprecated. [Called from LqtView::getInlineEditForm in /www/w/extensions/LiquidThreads/classes/View.php at line 362] in /www/w/includes/GlobalFunctions.php on line 3342 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85302]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r85302. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c0 Commit summary: Instead of creating an OutputPage and then setting a context start initializing OutputPages 'with' a context and send depreciated calls to extensions directly creating OutputPage instances. Now that we've taken care of the mess of mTitle inside OutputPage and Skin and made RequestContext track Skin instead of $wgUser we don't need the hack in SpecialPage anymore. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90263]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90263#c18286 Commit summary: Code cleanup for Query Creator Comment: Could you use Xml:: or Html:: functions (depending in which version of MediaWiki you need to support). Currently it is very difficult to review if the code does enough escaping on html output. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90264]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90264. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90264#c18287 Commit summary: (part of bug 6100) Set the directionality based on user language instead of content language (as in r81622, but only when $wgBetterDirectionality is enabled) Comment: Does this affect CSS ltr/rtl flipping? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90265]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90265. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90265#c18288 Commit summary: Improve lang and dir of content div (when $wgBetterDirectionality is enabled): * Do not set lang and dir for special pages (those are in the user language) * Set lang and dir of content of pages in MediaWiki namespace based on the current page instead of site language, e.g. MediaWiki:Message/ar is lang=ar and dir=rtl Comment: It's just not Mediawiki namespace pages. For example translated pages need this too. Is it possible to make this more general? For example dig the values out of ParserOutput? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added
User Nikerabbit posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c18289 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while... Comment: Seems like Reedy fixed them. Thanks! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90264]: New comment added
User SPQRobin posted a comment on MediaWiki.r90264. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90264#c18290 Commit summary: (part of bug 6100) Set the directionality based on user language instead of content language (as in r81622, but only when $wgBetterDirectionality is enabled) Comment: If you set an RTL language as user language on an LTR wiki, the LTR layout is flipped to RTL (as wanted on bug 6100). (you can see what it does here: http://robinpepermans.be/mw-dev/index.php?title=Main_Pageuselang=ar - I enabled $wgBetterDirectionality there) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90265]: New comment added
User SPQRobin posted a comment on MediaWiki.r90265. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90265#c18291 Commit summary: Improve lang and dir of content div (when $wgBetterDirectionality is enabled): * Do not set lang and dir for special pages (those are in the user language) * Set lang and dir of content of pages in MediaWiki namespace based on the current page instead of site language, e.g. MediaWiki:Message/ar is lang=ar and dir=rtl Comment: You mean all page titles that are a translated subpage, i.e. ending on /xx ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added
User Werdna posted a comment on MediaWiki.r85302. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c18292 Commit summary: Instead of creating an OutputPage and then setting a context start initializing OutputPages 'with' a context and send depreciated calls to extensions directly creating OutputPage instances. Now that we've taken care of the mess of mTitle inside OutputPage and Skin and made RequestContext track Skin instead of $wgUser we don't need the hack in SpecialPage anymore. Comment: Please update (or at least email) callers before you do stuff like this. It's very frustrating for you to expect extension authors to notice that their sites are suddenly throwing endless PHP notices and to change their calling conventions. In general you should support old calling conventions as much as possible. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90265]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90265. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90265#c18293 Commit summary: Improve lang and dir of content div (when $wgBetterDirectionality is enabled): * Do not set lang and dir for special pages (those are in the user language) * Set lang and dir of content of pages in MediaWiki namespace based on the current page instead of site language, e.g. MediaWiki:Message/ar is lang=ar and dir=rtl Comment: Well currently the titles in Translate extension are in that format, but I don't think that is a good way to detect it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90265]: New comment added
User SPQRobin posted a comment on MediaWiki.r90265. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90265#c18294 Commit summary: Improve lang and dir of content div (when $wgBetterDirectionality is enabled): * Do not set lang and dir for special pages (those are in the user language) * Set lang and dir of content of pages in MediaWiki namespace based on the current page instead of site language, e.g. MediaWiki:Message/ar is lang=ar and dir=rtl Comment: I know, but I'm not sure how else this could be made more general. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90265]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90265. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90265#c18295 Commit summary: Improve lang and dir of content div (when $wgBetterDirectionality is enabled): * Do not set lang and dir for special pages (those are in the user language) * Set lang and dir of content of pages in MediaWiki namespace based on the current page instead of site language, e.g. MediaWiki:Message/ar is lang=ar and dir=rtl Comment: Like I said, ParserOutput should have this information. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added
User Nikerabbit posted a comment on MediaWiki.r85302. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c18296 Commit summary: Instead of creating an OutputPage and then setting a context start initializing OutputPages 'with' a context and send depreciated calls to extensions directly creating OutputPage instances. Now that we've taken care of the mess of mTitle inside OutputPage and Skin and made RequestContext track Skin instead of $wgUser we don't need the hack in SpecialPage anymore. Comment: Normal sites don't have $wgDevelopmentWarnings enabled, or at least shouldn't. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90263]: New comment added
User Devayon posted a comment on MediaWiki.r90263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90263#c18297 Commit summary: Code cleanup for Query Creator Comment: Sure, I'll have a chat with Markus Krötzsch regarding this and see if we can reduce escaped html in the next commit. Right now the code you see is mostly a scaled down version of that in Special:Ask ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90265]: New comment added
User SPQRobin posted a comment on MediaWiki.r90265. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90265#c18298 Commit summary: Improve lang and dir of content div (when $wgBetterDirectionality is enabled): * Do not set lang and dir for special pages (those are in the user language) * Set lang and dir of content of pages in MediaWiki namespace based on the current page instead of site language, e.g. MediaWiki:Message/ar is lang=ar and dir=rtl Comment: Sorry, but I don't see how to do that... How can the parser know in which language a page is written? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90265]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90265. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90265#c18299 Commit summary: Improve lang and dir of content div (when $wgBetterDirectionality is enabled): * Do not set lang and dir for special pages (those are in the user language) * Set lang and dir of content of pages in MediaWiki namespace based on the current page instead of site language, e.g. MediaWiki:Message/ar is lang=ar and dir=rtl Comment: Parser doesn't decide that, but we can tell the parser that. Translate extension already does it: $parser-getOptions()-setTargetLanguage( Language::factory( $code ) ); Someday we will probably have magic words that can be used to set the language of the page. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] statistics about skin usage
Are there any statistics about skin usage on Wikimedia projects? For example: * How many people use each skin on each project? * How many accounts that edited before and after the Vector switch have Monobook? * How many accounts that were created after the Vector switch use Monobook? -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com We're living in pieces, I want to live in peace. - T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87808]: New comment added
User Krinkle posted a comment on MediaWiki.r87808. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87808#c18300 Commit summary: Prevent user from trying to move a page to a title longer than 255 bytes. This just puts a maxlength on the field (+ byte counter js) which is much nicer and clearer feedback to the user if they went over the limit then: The requested page title was invalid, empty, or an incorrectly linked inter-language or inter-wiki title. It may contain one or more characters which cannot be used in titles Which doesn't exactly indicate a length error. Comment: The pagename length is not a static number (ie. not 255, per Platonides), but the title (as in page_title) length is set to 255. So what we want is to get only the title portion. Although extracting the title part from a string is complex to do ad-hoc (localization, aliases, canonical namespaces, lower/uppercase, trimming of whitespace), it's rather easy with mw.Title: var title = new mw.Title( inputValue ); text.getMain(); // returns db-like version of the title, without namespace, ie. Foo_bar.jpg) Although in order to be able to actually filter the inputValue, byteLimit needs the ability to pass a callback/filter function. It's a little overhead to do now, but I think in a few days/weeks when the convenience dependancies are solved, this would be easy. Recorded in BugZilla: * ([[bugzilla:29454|bug 29454]]) Enforce byteLimit on wpNewTitle on Special:Move ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90272]: New comment added
User Reedy posted a comment on MediaWiki.r90272. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90272#c18301 Commit summary: - Moved the gadget preference info to a private member; had to use a hack, though. - Minor changes. Comment: Don't just through exceptions in the API, use dieUsage/dieUsageMsg That way it will fail somewhat gracefully ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90272]: Revision status changed
User Reedy changed the status of MediaWiki.r90272. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90272#c0 Commit summary: - Moved the gadget preference info to a private member; had to use a hack, though. - Minor changes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90272]: New comment added
User Salvatore Ingala posted a comment on MediaWiki.r90272. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90272#c18302 Commit summary: - Moved the gadget preference info to a private member; had to use a hack, though. - Minor changes. Comment: I thought an exception was better because that's a condition that should never happen (even if params are wrong); that is, if it happens, that's a bug elsewhere. Should I use dieUsage for these cases? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] wikistream: displays wikipedia updates in realtime
Ok, I've switched to using the character language code, and increased the number of language channels it is monitoring to 36. This is great! Can you please put titles of articles in right-to-left languages (ar, fa, ur, he) in span dir=rtlTITLE/span? Thank you! -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com We're living in pieces, I want to live in peace. - T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] statistics about skin usage
On Fri, Jun 17, 2011 at 10:42 AM, Amir E. Aharoni amir.ahar...@mail.huji.ac.il wrote: Are there any statistics about skin usage on Wikimedia projects? For example: * How many people use each skin on each project? I've been digging to get some numbers on this, especially accounting for active accounts. There's a couple of old legacy skins I'd love to send the way of the dodo if we can prove nobody's using them anymore. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r88904]: Revision status changed
User Bryan changed the status of MediaWiki.r88904. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88904#c0 Commit summary: (bug 27891) Follow-up r72475: destroy the LBFactory singleton before doing any jobs so that jobs do not access the current session while still preserving ChronologyProtector. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90265]: New comment added
User SPQRobin posted a comment on MediaWiki.r90265.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90265#c18303
Commit summary:
Improve lang and dir of content div (when $wgBetterDirectionality is enabled):
* Do not set lang and dir for special pages (those are in the user language)
* Set lang and dir of content of pages in MediaWiki namespace based on the
current page instead of site language, e.g. MediaWiki:Message/ar is lang=ar
and dir=rtl
Comment:
Something like this?
pre
if ( $wgBetterDirectionality $this-getTitle()-getNamespace() != NS_SPECIAL
) {
if( $this-getTitle()-getNamespace() == NS_MEDIAWIKI ) {
$nsMWTitle = $wgContLang-lcfirst( $this-getTitle()-getText()
);
list( , $nsMWLang ) = MessageCache::singleton()-figureMessage(
$nsMWTitle );
$out-parserOptions()-setTargetLanguage( $nsMWLang );
} else {
$out-parserOptions()-setTargetLanguage( $wgLanguageCode );
}
$getPageLang = $out-parserOptions()-getTargetLanguage();
if( isset( $getPageLang ) ) {
$pageLangDir = Language::factory( $getPageLang )-getDir();
$realBodyAttribs = array( 'lang' = $getPageLang, 'dir' =
$pageLangDir );
$out-mBodytext = Html::rawElement( 'div', $realBodyAttribs,
$out-mBodytext );
}
}
/pre
It should actually only do this on page view, edit preview and edit form. (Not
on the whole edit page as there are interface messages etc.)
And I found code$parserOptions-setTargetLanguage( $obj );/code (under if
NS = MediaWiki) in EditPage.php but getTargetLanguage() wouldn't return that
value when editing a MediaWiki namespace page.
Also, codesetTargetLanguage( Language::factory( $nsMWLang ) )/code didn't
work but codesetTargetLanguage( $nsMWLang )/code did.
Anyway, I think it would be better if you or someone else improved this. I am
not a very experienced MediaWiki programmer :-)
And indeed... I was thinking about a magic word as well. That would be useful
for multilingual wikis.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88145]: New comment added, and revision status changed
User Bryan changed the status of MediaWiki.r88145. Old Status: fixme New Status: new User Bryan also posted a comment on MediaWiki.r88145. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88145#c18304 Commit summary: Follow-up r87176: Make importDump.php import files * Fixes for Import.php: Check sha1 of the file; only delete source files if they are temporary * importDump.php now imports embedded files if --uploads is set; if they are not present it will try to get them from --image-base-path Comment: Fixed in r90294. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90272]: Revision status changed
User Reedy changed the status of MediaWiki.r90272. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90272#c0 Commit summary: - Moved the gadget preference info to a private member; had to use a hack, though. - Minor changes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90292]: Revision status changed
User Reedy changed the status of MediaWiki.r90292. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90292#c0 Commit summary: Removed useless check for existence of wfWaitForSlaves() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90265]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90265. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90265#c18305 Commit summary: Improve lang and dir of content div (when $wgBetterDirectionality is enabled): * Do not set lang and dir for special pages (those are in the user language) * Set lang and dir of content of pages in MediaWiki namespace based on the current page instead of site language, e.g. MediaWiki:Message/ar is lang=ar and dir=rtl Comment: You should read the value here, not set it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90295]: Revision status changed
User Reedy changed the status of MediaWiki.r90295. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90295#c0 Commit summary: Added info on possible errors to API modules ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90264]: New comment added
User MarkAHershberger posted a comment on MediaWiki.r90264. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90264#c18306 Commit summary: (part of bug 6100) Set the directionality based on user language instead of content language (as in r81622, but only when $wgBetterDirectionality is enabled) Comment: NICE! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85635]: New comment added, and revision status changed
User Bryan changed the status of MediaWiki.r85635. Old Status: fixme New Status: new User Bryan also posted a comment on MediaWiki.r85635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85635#c18307 Commit summary: First part of bug 22881: Allow uploading directly into the archive to support importing files. Based on a patch by Vitaliy Filippov with some major rewrites by me. * LocalFile::publish() supports an extra parameter to support publishing into the archive * Added OldLocalFile::uploadOld(), which is the OldImage equivalent to LocalFile::upload(), but does not override it because it has an entirely different function signature. Comment: Fixed in r90296 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90283]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r90283. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r90283. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90283#c18308 Commit summary: Using dieUsage instead of MWException. Fixes r90272. Comment: Exceptions can be logged, dieUsage is not logged. And sites usually don't have developers, and even if they have they are clueless because they have no idea what the user is reporting. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90283]: New comment added
User Reedy posted a comment on MediaWiki.r90283. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90283#c18309 Commit summary: Using dieUsage instead of MWException. Fixes r90272. Comment: wfDebug() ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90289]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90289. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90289#c18310 Commit summary: Swap else if for elseif Trimming trailing whitespace also last one! ;) Comment: This file is not maintained by us: trunk/extensions/Translate/spyc/spyc.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90300]: Revision status changed
User MaxSem changed the status of MediaWiki.r90300. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90300#c0 Commit summary: Fix for r84240: comment back ArticleSaveComplete hook ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90283]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90283. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90283#c18311 Commit summary: Using dieUsage instead of MWException. Fixes r90272. Comment: Not logged either. trigger_error perhaps? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90283]: New comment added
User ^demon posted a comment on MediaWiki.r90283. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90283#c18312 Commit summary: Using dieUsage instead of MWException. Fixes r90272. Comment: Errors are annoying, exceptions can be caught. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90283]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90283. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90283#c18313 Commit summary: Using dieUsage instead of MWException. Fixes r90272. Comment: Errors are supposed to be fixed. If this is caused by a bug, failing fast with full details it preferable. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90283]: New comment added
User ^demon posted a comment on MediaWiki.r90283. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90283#c18314 Commit summary: Using dieUsage instead of MWException. Fixes r90272. Comment: Exceptions fail fast and with a full stack trace unless you explicitly handle them at a particular level and do something different. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90283]: New comment added
User ^demon posted a comment on MediaWiki.r90283. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90283#c18315 Commit summary: Using dieUsage instead of MWException. Fixes r90272. Comment: Errors due to incorrect input should die with an error message (like dieUsage). Errors due to broken edge cases or DB inconsistency should throw exceptions--think of it like: this shouldn't happen, but it might. Exceptions will back out of MediaWiki gracefully and show a decent error to the end user. Throwing an error just logs it to the server and only possibly shows an error to the user. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] statistics about skin usage
On 17.06.2011, 20:20 Chad wrote: On Fri, Jun 17, 2011 at 10:42 AM, Amir E. Aharoni amir.ahar...@mail.huji.ac.il wrote: Are there any statistics about skin usage on Wikimedia projects? For example: * How many people use each skin on each project? I've been digging to get some numbers on this, especially accounting for active accounts. There's a couple of old legacy skins I'd love to send the way of the dodo if we can prove nobody's using them anymore. From mw.org: mysql select count(*), up_value from user_properties where up_property='skin' group by up_value; +--+-+ | count(*) | up_value| +--+-+ | 150489 | | | 15 | amethyst| | 229 | chick | | 610 | cologneblue | | 894 | modern | |15072 | monobook| | 126 | myskin | | 140 | nostalgia | | 114 | simple | | 257 | standard| | 3661 | vector | +--+-+ 11 rows in set (11.64 sec) user_touched is unavailable on Toolserver, so can't make a more detailed query. -- Best regards, Max Semenik ([[User:MaxSem]]) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90283]: New comment added
User Reedy posted a comment on MediaWiki.r90283. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90283#c18316 Commit summary: Using dieUsage instead of MWException. Fixes r90272. Comment: My example for this was... source lang=php case EditPage::AS_HOOK_ERROR: case EditPage::AS_HOOK_ERROR_EXPECTED: $this-dieUsageMsg( 'hookaborted' ); /source ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84240]: Revision status changed
User Reedy changed the status of MediaWiki.r84240. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84240#c0 Commit summary: extension function - ParserFirstCallInit hook to register parser hooks and functions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84240]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84240. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84240#c0 Commit summary: extension function - ParserFirstCallInit hook to register parser hooks and functions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] statistics about skin usage
I could have sworn that the Usability team had some stats on this when they were active on the project. --tomasz On Fri, Jun 17, 2011 at 7:42 AM, Amir E. Aharoni amir.ahar...@mail.huji.ac.il wrote: Are there any statistics about skin usage on Wikimedia projects? For example: * How many people use each skin on each project? * How many accounts that edited before and after the Vector switch have Monobook? * How many accounts that were created after the Vector switch use Monobook? -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com We're living in pieces, I want to live in peace. - T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] statistics about skin usage
We also used this to keep track of specific preferences, some interesting info there.. http://en.wikipedia.org/wiki/Special:PrefStats - Trevor On Fri, Jun 17, 2011 at 10:37 AM, Max Semenik maxsem.w...@gmail.com wrote: On 17.06.2011, 20:20 Chad wrote: On Fri, Jun 17, 2011 at 10:42 AM, Amir E. Aharoni amir.ahar...@mail.huji.ac.il wrote: Are there any statistics about skin usage on Wikimedia projects? For example: * How many people use each skin on each project? I've been digging to get some numbers on this, especially accounting for active accounts. There's a couple of old legacy skins I'd love to send the way of the dodo if we can prove nobody's using them anymore. From mw.org: mysql select count(*), up_value from user_properties where up_property='skin' group by up_value; +--+-+ | count(*) | up_value| +--+-+ | 150489 | | | 15 | amethyst| | 229 | chick | | 610 | cologneblue | | 894 | modern | |15072 | monobook| | 126 | myskin | | 140 | nostalgia | | 114 | simple | | 257 | standard| | 3661 | vector | +--+-+ 11 rows in set (11.64 sec) user_touched is unavailable on Toolserver, so can't make a more detailed query. -- Best regards, Max Semenik ([[User:MaxSem]]) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] statistics about skin usage
On Fri, Jun 17, 2011 at 1:37 PM, Max Semenik maxsem.w...@gmail.com wrote: From mw.org: mysql select count(*), up_value from user_properties where up_property='skin' group by up_value; [snip results] Cool, and I've already looked up these stats on a few wikis on an ad-hoc basis. What I really want is WMF-wide stats :) user_touched is unavailable on Toolserver, so can't make a more detailed query. Yeah, that's a problem. Ideally I'd love results in the form of (user_touched,up_value), that'd be the most useful. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] statistics about skin usage
On Fri, Jun 17, 2011 at 1:46 PM, Trevor Parscal tpars...@wikimedia.org wrote: We also used this to keep track of specific preferences, some interesting info there.. http://en.wikipedia.org/wiki/Special:PrefStats Cool stuff, but doesn't quite get the big picture I'm going for. The most useful data here (as I said elsewhere) would be joining skin choice on user_touched as an indicator of activity, and aggregating those totals per-wiki--maybe in per-year buckets. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90283]: New comment added
User ^demon posted a comment on MediaWiki.r90283. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90283#c18317 Commit summary: Using dieUsage instead of MWException. Fixes r90272. Comment: Right that's a good example of a dieUsageMsg(), since the various EditPage error conditions are all possible and (somewhat) expected. However, something like DB or internal inconsistency like I outlined above should throw an exception. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84435]: Revision status changed
User ^demon changed the status of MediaWiki.r84435. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84435#c0 Commit summary: Timeout/locking fixes for r84383 (these don't do anything yet though anyway) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84390]: Revision status changed
User ^demon changed the status of MediaWiki.r84390. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84390#c0 Commit summary: Replaced array( 'parsemag' ) with 'parsemag' in some cases ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84391]: Revision status changed
User ^demon changed the status of MediaWiki.r84391. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84391#c0 Commit summary: Removed special case Opera code from updateRatingFormColors(); the css updates are needed for newer Opera versions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84407]: Revision status changed
User ^demon changed the status of MediaWiki.r84407. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84407#c0 Commit summary: Minor HTML cleanups ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84446]: Revision status changed
User ^demon changed the status of MediaWiki.r84446. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84446#c0 Commit summary: * Pass pager-getNumRows() into explanatory message * Use link() function for links (some pages now use linkbatch for this) * Use HTML functions a bit more * Don't call purgeExpiredConfigurations() so much * Other random cleanups ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84469]: Revision status changed
User ^demon changed the status of MediaWiki.r84469. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84469#c0 Commit summary: * Make use of log_search table for review log * Renamed updateLog - updateReviewLog ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90052]: Revision status changed
User ^demon changed the status of MediaWiki.r90052. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90052#c0 Commit summary: Tweaked r90033: Improved API param names. Also decreased deadvertiseReviewing() JS timeout a bit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90100]: Revision status changed
User ^demon changed the status of MediaWiki.r90100. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90100#c0 Commit summary: * Reduce the amount of reviewactivity API hits * Removed useless hidden action input * Added some newlines to the html ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90143]: Revision status changed
User ^demon changed the status of MediaWiki.r90143. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90143#c0 Commit summary: FRUserActivity (r90033) improvements: * Keep track of instance counter for people with multiple (same) diff windows open * Reduced cache setting code duplication * Use class constants and tweaked function return style * Fixed doc typos ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90033]: Revision status changed
User ^demon changed the status of MediaWiki.r90033. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90033#c0 Commit summary: *Added API to set currently reviewing flag for pages and diffs *(bug 25295) Added You are being advertised as reviewing message to review form. Currently removes flag when user leaves the page or it times out. A [stop] button and/or heartbeats could also be used with the API (with minor tweaks). *Added JS TODO note ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84569]: Revision status changed
User ^demon changed the status of MediaWiki.r84569. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84569#c0 Commit summary: Cast $revIdStable to an int like the others ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84632]: Revision status changed
User ^demon changed the status of MediaWiki.r84632. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84632#c0 Commit summary: * Follow-up r84610: don't assume a Parser object is attached * Removed unused $i var ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85202]: Revision status changed
User ^demon changed the status of MediaWiki.r85202. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85202#c0 Commit summary: Added bug 28348 cleanup script ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85223]: Revision status changed
User ^demon changed the status of MediaWiki.r85223. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85223#c0 Commit summary: * Removed $wgFlaggedRevsComments; not used by WMF * Minor cleanups * Added SQL comments ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85209]: Revision status changed
User ^demon changed the status of MediaWiki.r85209. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85209#c0 Commit summary: * Added doFlaggedImagesTimestampNULL() update * Re-organized updater stuff ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86018]: Revision status changed
User ^demon changed the status of MediaWiki.r86018. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86018#c0 Commit summary: * Renamed /updater to /schema and moved main sql files there * Also fixes r85209 patch dirs for the updater ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85206]: Revision status changed
User ^demon changed the status of MediaWiki.r85206. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85206#c0 Commit summary: Added function to clean up garbage in fi_img_timestamp values (which is properly NULLable now) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] statistics about skin usage
On Fri, Jun 17, 2011 at 10:50 AM, Chad innocentkil...@gmail.com wrote: On Fri, Jun 17, 2011 at 1:46 PM, Trevor Parscal tpars...@wikimedia.org wrote: We also used this to keep track of specific preferences, some interesting info there.. http://en.wikipedia.org/wiki/Special:PrefStats Cool stuff, but doesn't quite get the big picture I'm going for. The most useful data here (as I said elsewhere) would be joining skin choice on user_touched as an indicator of activity, and aggregating those totals per-wiki--maybe in per-year buckets. Beware of user_touched; it's also triggered when _other_ people do things, like editing your talk page, or bulk operations like a batch change of some other user preference. user_touched could be current on an account that hasn't logged in in years. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] statistics about skin usage
On Fri, Jun 17, 2011 at 2:11 PM, Brion Vibber br...@pobox.com wrote: Beware of user_touched; it's also triggered when _other_ people do things, like editing your talk page, or bulk operations like a batch change of some other user preference. user_touched could be current on an account that hasn't logged in in years. Right, I know user_touched will definitely overstate our active users. I was choosing it as a metric because I don't really find the active users report in MediaWiki to have any merit. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r80466]: Revision status changed
User Reedy changed the status of MediaWiki.r80466. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80466#c0 Commit summary: preprocessDump.php maintenance script. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85225]: Revision status changed
User ^demon changed the status of MediaWiki.r85225. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85225#c0 Commit summary: Make use of clean NULL in fi_img_timestamp for non-existing files ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85266]: Revision status changed
User ^demon changed the status of MediaWiki.r85266. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85266#c0 Commit summary: Avoid using skin-mTitle ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85300]: Revision status changed
User ^demon changed the status of MediaWiki.r85300. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85300#c0 Commit summary: Removed ampersand in overrideRedirect ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80494]: Revision status changed
User Reedy changed the status of MediaWiki.r80494. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80494#c0 Commit summary: Use the normal way of constructing links instead of hard coded trickery which breaks up randomly ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80508]: Revision status changed
User Reedy changed the status of MediaWiki.r80508. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80508#c0 Commit summary: Fix bug in XML data dump processing by guarding against missing title objects (database corruption) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85230]: Revision status changed
User ^demon changed the status of MediaWiki.r85230. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85230#c0 Commit summary: * Removed isset() checks - redundant given Parser::version * For sanity in insertOn(), if the template/file version arrays are null, don't hit the DB - just assume they are empty * Refactored mFlags handling in FlaggedRevision * Use accessors for ParserOutput template/file versions * Added OutputPage accessors for template/file versions * Changed instance of NS_IMAGE - NS_FILE ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80252]: Revision status changed
User Reedy changed the status of MediaWiki.r80252. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80252#c0 Commit summary: Fix remainder of the accidental -empty() calls I used when converting wfEmptyMsg into Message::exists() calls. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80248]: Revision status changed
User Reedy changed the status of MediaWiki.r80248. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80248#c0 Commit summary: Implement Message::isBlank and Message::isDisabled. And while we're at it... update a random assortment of code using wfEmptyMsg to use the new wfMessage class and our exists/isBlank/isDisabled methods. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85307]: Revision status changed
User ^demon changed the status of MediaWiki.r85307. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85307#c0 Commit summary: * Cleanup and fixes to template/file version arrays * Updated related tests ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81034]: Revision status changed
User Reedy changed the status of MediaWiki.r81034. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81034#c0 Commit summary: First round of $wgArticle removals ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84383]: Revision status changed
User ^demon changed the status of MediaWiki.r84383. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84383#c0 Commit summary: * Moved users watching/user currently reviewing functions to FRUserActivity and rewrote it * (bug 25295) Track *who* is reviewing pages and when they started; warn users of this on review forms * Got rid of revreview-text msg * Fixed fr-under-review css use at unreviewedpages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
