[MediaWiki-CodeReview] [MediaWiki r91087]: New comment added
User Hashar posted a comment on MediaWiki.r91087. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91087#c18996 Commit summary: Move global functions tests to their own directory. Will let us create a test file for each functions which is easier to handle in the long time. Comment: I dont see the point in marking this fixme anyway. Seriously, just change the directory name to something better. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84428]: New comment added
User Hashar posted a comment on MediaWiki.r84428. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84428#c18997 Commit summary: branch trunk@r84386 to play with the pretty URL feature Comment: cleaning fixme ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84428]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r84428. Old Status: fixme New Status: resolved User Hashar also posted a comment on MediaWiki.r84428. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84428#c18998 Commit summary: branch trunk@r84386 to play with the pretty URL feature Comment: seriously ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Wikimedia repository gets CodeReview tool and a fancy 'commits' mailing list
On 30/06/11 03:51, Arthur Richards wrote: Hi everyone, A while back we set up a 'Wikimedia' SVN repository [1] (as opposed to the 'Mediawiki' SVN repository [2]) to hold Wikimedia-related yet non-MediaWiki related code. This has been great particularly for miscellaneous fundraising-related code as well as our instance of CiviCRM and associated modules. Welcome in Code Review madness 8-) -- Ashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91123]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r91123. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r91123. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91123#c18999 Commit summary: * Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiCategoryPage from CategoryPage. * WikiPage functions/fields are magically part of Article when accessed for b/c. Magic is kind of ugly but there are too many callers to make breaking changes atm. Some functions are just wrappers for WikiPage ones (were magic won't work). * Added newFromID() to each WikiPage subclass (works around pre-existing inheritance problem). * Added Page class for convenient type hinting and changed hints from Article - Page. This lets things use WikiPage objects without getting type errors. * Updated FlaggedPage to extend WikiPage. Worked around getOldIdFromRequest(). * Added setTimestamp() to WikiPage and moved some timestamp setting code from ParserCache to Article. * Removed ampersands from $dbw arguments. * @TODO: dependency inject user objects for WikiPage The idea is to migrate things to use WikiPage, as the run-of-the-mill new Article() call doesn't care about $oldid and $wgRequest. After that, Article, ImagePage, and CategoryPage can be rewritten as an Action class or something sane (a Viewer class of sorts). Comment: Seen on Translatewiki: PHP Fatal error: Call to protected method WikiPage::pageDataFromId() from context 'Article' in /www/w/includes/Article.php on line 289 PHP Fatal error: Call to undefined method WikiPage::getOutputFromWikitext() in /www/w/includes/WikiPage.php on line 2438 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91106]: New comment added, and revision status changed
User Bryan changed the status of MediaWiki.r91106. Old Status: fixme New Status: new User Bryan also posted a comment on MediaWiki.r91106. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91106#c19000 Commit summary: Add wfUnserialize() wrapper around unserialize to prevent E_NOTICE and use it in ExifBitmap.php. There are probably many more places that could use this. This should fix Platonides' problem at r90421, but also added a check for $wgShowExif to prevent the test from failing. Comment: Follow-up by Brian in r91127. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90872]: New comment added
User Krinkle posted a comment on MediaWiki.r90872.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90872#c19001
Commit summary:
LiquidThreads: better support for different directionality (LTR/RTL): make
everything in user language direction except the header (the actual wikitext)
and the text of the individual posts
Comment:
This breaks on pages that are not Talk but have
codenowiki{{#useliquidthreads:1}}/nowiki/code, namely the fact that the
div isn't closed properly and the footer becomes part of the mw-content.
http://i.imgur.com/vp90N.png
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90872]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r90872. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r90872. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90872#c19002 Commit summary: LiquidThreads: better support for different directionality (LTR/RTL): make everything in user language direction except the header (the actual wikitext) and the text of the individual posts Comment: If I uncomment the 'wgBetterDirectionality' part it is fixed on those pages, but then it's off on Talk-pages. Closing tags opened in a different context, looks scary. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91123]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91123. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91123#c0 Commit summary: * Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiCategoryPage from CategoryPage. * WikiPage functions/fields are magically part of Article when accessed for b/c. Magic is kind of ugly but there are too many callers to make breaking changes atm. Some functions are just wrappers for WikiPage ones (were magic won't work). * Added newFromID() to each WikiPage subclass (works around pre-existing inheritance problem). * Added Page class for convenient type hinting and changed hints from Article - Page. This lets things use WikiPage objects without getting type errors. * Updated FlaggedPage to extend WikiPage. Worked around getOldIdFromRequest(). * Added setTimestamp() to WikiPage and moved some timestamp setting code from ParserCache to Article. * Removed ampersands from $dbw arguments. * @TODO: dependency inject user objects for WikiPage The idea is to migrate things to use WikiPage, as the run-of-the-mill new Article() call doesn't care about $oldid and $wgRequest. After that, Article, ImagePage, and CategoryPage can be rewritten as an Action class or something sane (a Viewer class of sorts). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Google Chrome
On Thu, Jun 30, 2011 at 12:07 AM, Brion Vibber br...@pobox.com wrote: Do you have any custom settings, JS or gadgets set up that might change editing behavior? More specifically, do you have WikiEditor enabled? If so, disable all of the WikiEditor features/modules (see $wgWikiEditorModules or $wgWikiEditorFeatures , depending on your version) except for 'toolbar', 'dialogs' and, if available in your version, 'hidesig'. Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Report from yesterday's IRC Bug Triage
On Thu, Jun 30, 2011 at 1:15 AM, Mark A. Hershberger mhershber...@wikimedia.org wrote: Roan suggested that the page may have been deleted and undeleted, thus removing the edit protection. Credit where credit is due: this was Platonides. Roan Kattouw (Catrope) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91123]: New comment added
User Happy-melon posted a comment on MediaWiki.r91123. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91123#c19003 Commit summary: * Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiCategoryPage from CategoryPage. * WikiPage functions/fields are magically part of Article when accessed for b/c. Magic is kind of ugly but there are too many callers to make breaking changes atm. Some functions are just wrappers for WikiPage ones (were magic won't work). * Added newFromID() to each WikiPage subclass (works around pre-existing inheritance problem). * Added Page class for convenient type hinting and changed hints from Article - Page. This lets things use WikiPage objects without getting type errors. * Updated FlaggedPage to extend WikiPage. Worked around getOldIdFromRequest(). * Added setTimestamp() to WikiPage and moved some timestamp setting code from ParserCache to Article. * Removed ampersands from $dbw arguments. * @TODO: dependency inject user objects for WikiPage The idea is to migrate things to use WikiPage, as the run-of-the-mill new Article() call doesn't care about $oldid and $wgRequest. After that, Article, ImagePage, and CategoryPage can be rewritten as an Action class or something sane (a Viewer class of sorts). Comment: (empty post for now to join the CC list) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91159]: New comment added
User Happy-melon posted a comment on MediaWiki.r91159. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91159#c19004 Commit summary: Expand on r91123 Article refactoring: * Added $user param to relevant WikiPage functions (with b/c) * Cleaned up editUpdates() signature and tweaked three other WikiPage functions signatures (with b/c) * Added fixme to prepareTextForEdit() Comment: (empty post for now to join the CC list) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91065]: New comment added
User Catrope posted a comment on MediaWiki.r91065. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91065#c19005 Commit summary: Vector: Add maintenance script to switch a preference for users with the noexperiments preference enabled. This is needed for the upcoming WikiLove deployment Comment: That's not really expected to happen, no, I'm just being paranoid. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91065]: New comment added
User Nikerabbit posted a comment on MediaWiki.r91065. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91065#c19006 Commit summary: Vector: Add maintenance script to switch a preference for users with the noexperiments preference enabled. This is needed for the upcoming WikiLove deployment Comment: Being paranoid helps sometimes. I had throw MWException( Should never happen ) in my extension and it caught a bug in my refactoring :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91032]: Revision status changed
User Catrope changed the status of MediaWiki.r91032. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91032#c0 Commit summary: adding functionality for custom image use logging ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91083]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r91083.
Old Status: new
New Status: fixme
User Catrope also posted a comment on MediaWiki.r91083.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91083#c19007
Commit summary:
WikiLove minor fixes:
* Trailing comma's in object literals brakes IE (in rememberInputData and
currentRememberData), unlike PHP.
* Using fast strict comparison to undefined instead of typeof + string
comparison
* Whitespace (space before opening parenthesis after if)
* Fix reference to deprecated global ('skin' and 'wgFormattedNamespaces')
* Fix missing case in addFilePrefix (NS_FILE has File and Image as alias, a
certain localization as primary one but also a localiztion of Image exists as
alias (a total of four)). The latter case was still missing. Fixing by using
wgNamespaceIds. Also made it case- and whitespace-insensitive (like the Parser
is)
* Removed redundant IIFE wrapper and used the closure we already have.
Local configuration BREAKING CHANGE
I made an attempt to re-implement a local config that doesn't require declaring
all of the options, and doesn't require the init-call to be part of the local
config (which is dangerous. one syntax error and it wont init at all).
Solution:
- Making it into an object literal (instead of a function)
- Always loading the default configuration
- Moving init into init-module
- Loading local config with mw.loader.using instead of a dependancy in the
module definition.
Result:
- Local config can be a copy-paste of defaultOptions.js and it will work
- But (here's the nice part) one can also just do this in MediaWiki:WikiLove.js:
$.wikiLoveOptions.types.barnstar.name='Awesome Originals';
And have it work!
Tested in Safari 5, Firefox 3.6 + 4, Opera 11
Comment:
pre
+ var prefix = filename.split( ':' )[0] || '',
+ normalized = $.trim( prefix ).toLowerCase().replace(
/\s/g, '_' );
+ // wgNamespaceIds is missing 'file' in 1.17 on non-English wikis
+ if ( mw.config.get( 'wgNamespaceIds' )[normalized] !== 6
normalized !== 'file' ) {
/pre
This is broken for the (unlikely, I admit) case that codefilename ===
'File'/code (or code'Image'/code or a local alias).
OK otherwise.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91156]: Revision status changed
User Catrope changed the status of MediaWiki.r91156. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91156#c0 Commit summary: adding in code to pre-select first image as requested, this may be confusing to user, however, since then nothing happens if they try to click on the first image to select it - commenting out until further discussion ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91160]: Revision status changed
User Catrope changed the status of MediaWiki.r91160. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91160#c0 Commit summary: adding descriptions for food and drink items ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91160]: New comment added
User Catrope posted a comment on MediaWiki.r91160. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91160#c19008 Commit summary: adding descriptions for food and drink items Comment: Are these descriptions localizable, e.g. as messages? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91161]: New comment added
User Catrope posted a comment on MediaWiki.r91161. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91161#c19009 Commit summary: adding image previewing for subtypes with single images Comment: Tagging krinkle for CSSJS review. I've looked over the JS and it looks good to me. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91122]: Revision status changed
User Catrope changed the status of MediaWiki.r91122. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91122#c0 Commit summary: Implementing tooltips for ArticleFeedback * Rating container needed 1em more height to avoid text going through the form options * Messages swapped on-hover based on context of the rating-star-hover, then shown on hover-in and hidden on hover-out ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90872]: New comment added
User SPQRobin posted a comment on MediaWiki.r90872. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90872#c19010 Commit summary: LiquidThreads: better support for different directionality (LTR/RTL): make everything in user language direction except the header (the actual wikitext) and the text of the individual posts Comment: Fixed in r91165. I was going to fix this but forgot to.. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91124]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r91124.
Old Status: new
New Status: fixme
User Hashar also posted a comment on MediaWiki.r91124.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91124#c19011
Commit summary:
Add the rest of the example metrics
Comment:
In MetricsReporting.php you really want to automatically detect metrics by
looking for PHP files ending with 'Metric.php'. Would make things way easier to
handle. Something like:
source lang=php
$metricsDir = $dir . 'metrics/';
$names = preg_match_all( (\w+)Metric\.php,
scandir( $metricsDir )
);
/source
Then iterates over the $names array:
source lang=php
foreach( $names as $name ) {
$metric = {$name}Metric;
$wgAutoloadClasses[$metric] = $metricsDir . {$metric}.php;
$wgMetricAPIModules[strtolower($metric)] = $metric;
}
/source
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90864]: New comment added
User SPQRobin posted a comment on MediaWiki.r90864. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90864#c19012 Commit summary: Babel CSS: follow the content direction instead of the user language direction (support for $wgBetterDirectionality) Comment: I agree. (However, then it would need a different solution, because left/right depends on the content language.) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91159]: New comment added
User Nikerabbit posted a comment on MediaWiki.r91159.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91159#c19013
Commit summary:
Expand on r91123 Article refactoring:
* Added $user param to relevant WikiPage functions (with b/c)
* Cleaned up editUpdates() signature and tweaked three other WikiPage functions
signatures (with b/c)
* Added fixme to prepareTextForEdit()
Comment:
pre
+ public function commitRollback( $fromP, $summary, $bot,
$resultDetails, User $guser = null ) {
global $wgUseRCPatrol, $wgUser, $wgContLang;
+ $guser = is_null( $guser ) ? $wgUser : $guser;
/pre
I don't think adding automatic use of global $wgUser is good idea for new
params.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91159]: New comment added
User Nikerabbit posted a comment on MediaWiki.r91159. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91159#c19014 Commit summary: Expand on r91123 Article refactoring: * Added $user param to relevant WikiPage functions (with b/c) * Cleaned up editUpdates() signature and tweaked three other WikiPage functions signatures (with b/c) * Added fixme to prepareTextForEdit() Comment: How stupid of me, it is needed to keep BC with callers. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91166]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r91166. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91166#c0 Commit summary: Fix typo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91123]: New comment added
User Jack Phoenix posted a comment on MediaWiki.r91123. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91123#c19015 Commit summary: * Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiCategoryPage from CategoryPage. * WikiPage functions/fields are magically part of Article when accessed for b/c. Magic is kind of ugly but there are too many callers to make breaking changes atm. Some functions are just wrappers for WikiPage ones (were magic won't work). * Added newFromID() to each WikiPage subclass (works around pre-existing inheritance problem). * Added Page class for convenient type hinting and changed hints from Article - Page. This lets things use WikiPage objects without getting type errors. * Updated FlaggedPage to extend WikiPage. Worked around getOldIdFromRequest(). * Added setTimestamp() to WikiPage and moved some timestamp setting code from ParserCache to Article. * Removed ampersands from $dbw arguments. * @TODO: dependency inject user objects for WikiPage The idea is to migrate things to use WikiPage, as the run-of-the-mill new Article() call doesn't care about $oldid and $wgRequest. After that, Article, ImagePage, and CategoryPage can be rewritten as an Action class or something sane (a Viewer class of sorts). Comment: prenowiki --- trunk/phase3/includes/AutoLoader.php2011/06/29 22:08:12 91122 +++ trunk/phase3/includes/AutoLoader.php2011/06/29 22:09:51 91123 @@ -159,6 +159,7 @@ 'MWNamespace' = 'includes/Namespace.php', 'OldChangesList' = 'includes/ChangesList.php', 'OutputPage' = 'includes/OutputPage.php', +'Page' = 'includes/WikiPage.php', 'PageHistory' = 'includes/HistoryPage.php', 'PageHistoryPager' = 'includes/HistoryPage.php', 'PageQueryPage' = 'includes/PageQueryPage.php', @@ -233,10 +234,13 @@ 'WebRequest' = 'includes/WebRequest.php', 'WebRequestUpload' = 'includes/WebRequest.php', 'WebResponse' = 'includes/WebResponse.php', +'WikiCategoryPage' = 'includes/WikiCategoryPage.php', 'WikiError' = 'includes/WikiError.php', 'WikiErrorMsg' = 'includes/WikiError.php', 'WikiExporter' = 'includes/Export.php', +'WikiFilePage' = 'includes/WikiFilePage.php', 'WikiImporter' = 'includes/Import.php', +'WikiPage' = 'includes/WikiPage.php', 'WikiRevision' = 'includes/Import.php', 'WikiMap' = 'includes/WikiMap.php', 'WikiReference' = 'includes/WikiMap.php', /nowiki/pre Should be indented with a tab character instead of four spaces. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88113]: New comment added
User IAlex posted a comment on MediaWiki.r88113. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88113#c19016 Commit summary: Rewrote the article counting code and related: * (bug 26033, bug 24754) Added $wgArticleCountMethod to have a more flexible way to define which method to use to define if a page is an article or not and deprecated $wgUseCommaCount. There is now a new 'any' method to count any article that is in a content namespace and not a redirect. * (bug 11868) If using links to count articles, Article::isCountable() will now use the ParserOutput to check if there's a link instead of checking for the [[ string. Changed Article::isCountable() to take a stdObject or false for the first parameters. If false is passed, the result will be based on the current article's state (i.e. database). The only call outside of the Article class is in DeleteAction (including extensions). * Removed this horror of Article::$mGoodAdjustment and Article::$mTotalAdjustment, replaced by the new $created parameter on Article::editUpdates(); simplified Article::createUpdates() * Updated Import.php to take advantage of the new parameter and make a single call to Article::editUpdates() Comment: Done in r91180. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88053]: New comment added
User MarkAHershberger posted a comment on MediaWiki.r88053. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88053#c19017 Commit summary: Added direct file loading functionality to debug mode for both scripts and styles, with callbacks for module state changes (changing to ready) and executing of jobs and modules awaiting dependency resolutions. These changes also provide a way to used mw.loader.implement with arrays of URLs for the scripts and styles arguments, which will make it possible to implement modules using user scripts. This probably solves bug #27023 - tests to verify that will be coming soon. Comment: When this is fixed, could you check that Bug #29606 is also fixed? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91077]: New comment added
User Amire80 posted a comment on MediaWiki.r91077. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91077#c19018 Commit summary: Fixed the z-index of webfonts menu, broken in r90972. Comment: Just curious - isn't there anything better than writing an arbitrary large number like 9? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91124]: Revision status changed
User Reedy changed the status of MediaWiki.r91124. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91124#c0 Commit summary: Add the rest of the example metrics ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91124]: New comment added
User Reedy posted a comment on MediaWiki.r91124. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91124#c19019 Commit summary: Add the rest of the example metrics Comment: Maybe, maybe not, but it didn't need a fixme for that. I don't think there's anywhere in MW that does dynamic loading like that. Doing it explicitally is easier for testing works for me, it might be changed later, but repeated scans of directories etc I'm guessing would be slower, and by the time I've put the effort in for the above, and I know it'll work. There will be others added later. Simiarily, a wrapper function passed an array of files could've been done ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91175]: Revision status changed
User Reedy changed the status of MediaWiki.r91175. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91175#c0 Commit summary: Fix fatal in r77354 (!!), discovered this when purgeList.php fataled on me on the WMF cluster ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91077]: New comment added
User Santhosh.thottingal posted a comment on MediaWiki.r91077. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91077#c19020 Commit summary: Fixed the z-index of webfonts menu, broken in r90972. Comment: We just wanted to ensure that it comes on top of everything. https://developer.mozilla.org/en/Understanding_CSS_z-index/Adding_z-index Any number will do, as far as it stays on top of the stack. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91087]: Revision status changed
User Reedy changed the status of MediaWiki.r91087. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91087#c0 Commit summary: Move global functions tests to their own directory. Will let us create a test file for each functions which is easier to handle in the long time. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91159]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r91159. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91159#c19021 Commit summary: Expand on r91123 Article refactoring: * Added $user param to relevant WikiPage functions (with b/c) * Cleaned up editUpdates() signature and tweaked three other WikiPage functions signatures (with b/c) * Added fixme to prepareTextForEdit() Comment: Yeah, kind of stuck with it. I avoided mentioning the default in the docs to discourage reliance on it. Next version it should give warnings when it's not given. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91083]: New comment added
User Krinkle posted a comment on MediaWiki.r91083.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91083#c19022
Commit summary:
WikiLove minor fixes:
* Trailing comma's in object literals brakes IE (in rememberInputData and
currentRememberData), unlike PHP.
* Using fast strict comparison to undefined instead of typeof + string
comparison
* Whitespace (space before opening parenthesis after if)
* Fix reference to deprecated global ('skin' and 'wgFormattedNamespaces')
* Fix missing case in addFilePrefix (NS_FILE has File and Image as alias, a
certain localization as primary one but also a localiztion of Image exists as
alias (a total of four)). The latter case was still missing. Fixing by using
wgNamespaceIds. Also made it case- and whitespace-insensitive (like the Parser
is)
* Removed redundant IIFE wrapper and used the closure we already have.
Local configuration BREAKING CHANGE
I made an attempt to re-implement a local config that doesn't require declaring
all of the options, and doesn't require the init-call to be part of the local
config (which is dangerous. one syntax error and it wont init at all).
Solution:
- Making it into an object literal (instead of a function)
- Always loading the default configuration
- Moving init into init-module
- Loading local config with mw.loader.using instead of a dependancy in the
module definition.
Result:
- Local config can be a copy-paste of defaultOptions.js and it will work
- But (here's the nice part) one can also just do this in MediaWiki:WikiLove.js:
$.wikiLoveOptions.types.barnstar.name='Awesome Originals';
And have it work!
Tested in Safari 5, Firefox 3.6 + 4, Opera 11
Comment:
Yeah, checking length of the array is probably a good thing after splitting it.
There are other edgecases though, which is why mw.Title was created.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91127]: Revision status changed
User Bryan changed the status of MediaWiki.r91127. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91127#c0 Commit summary: (follow-up r91106) Explicitly compare against the self::BROKEN_FILE constants. Before was doing if !$metadata, which used to work when self::BROKEN_FILE was 0, now it's -1 and that works less. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88053]: New comment added
User Krinkle posted a comment on MediaWiki.r88053. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88053#c19023 Commit summary: Added direct file loading functionality to debug mode for both scripts and styles, with callbacks for module state changes (changing to ready) and executing of jobs and modules awaiting dependency resolutions. These changes also provide a way to used mw.loader.implement with arrays of URLs for the scripts and styles arguments, which will make it possible to implement modules using user scripts. This probably solves bug #27023 - tests to verify that will be coming soon. Comment: Hm.. I'm not sure I see the link here ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91123]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r91123. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91123#c19024 Commit summary: * Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiCategoryPage from CategoryPage. * WikiPage functions/fields are magically part of Article when accessed for b/c. Magic is kind of ugly but there are too many callers to make breaking changes atm. Some functions are just wrappers for WikiPage ones (were magic won't work). * Added newFromID() to each WikiPage subclass (works around pre-existing inheritance problem). * Added Page class for convenient type hinting and changed hints from Article - Page. This lets things use WikiPage objects without getting type errors. * Updated FlaggedPage to extend WikiPage. Worked around getOldIdFromRequest(). * Added setTimestamp() to WikiPage and moved some timestamp setting code from ParserCache to Article. * Removed ampersands from $dbw arguments. * @TODO: dependency inject user objects for WikiPage The idea is to migrate things to use WikiPage, as the run-of-the-mill new Article() call doesn't care about $oldid and $wgRequest. After that, Article, ImagePage, and CategoryPage can be rewritten as an Action class or something sane (a Viewer class of sorts). Comment: r91183 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91123]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r91123. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91123#c19025 Commit summary: * Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiCategoryPage from CategoryPage. * WikiPage functions/fields are magically part of Article when accessed for b/c. Magic is kind of ugly but there are too many callers to make breaking changes atm. Some functions are just wrappers for WikiPage ones (were magic won't work). * Added newFromID() to each WikiPage subclass (works around pre-existing inheritance problem). * Added Page class for convenient type hinting and changed hints from Article - Page. This lets things use WikiPage objects without getting type errors. * Updated FlaggedPage to extend WikiPage. Worked around getOldIdFromRequest(). * Added setTimestamp() to WikiPage and moved some timestamp setting code from ParserCache to Article. * Removed ampersands from $dbw arguments. * @TODO: dependency inject user objects for WikiPage The idea is to migrate things to use WikiPage, as the run-of-the-mill new Article() call doesn't care about $oldid and $wgRequest. After that, Article, ImagePage, and CategoryPage can be rewritten as an Action class or something sane (a Viewer class of sorts). Comment: Fixed in r91162. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Domain name for cruisecontrol
Can we have a proper domain name for cruisecontrol? Something like testing.mediawiki.org. That is much easier to remember than ci.usability.tesla.wikimedia.org or whatever. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Domain name for cruisecontrol
On Thu, Jun 30, 2011 at 1:23 PM, Bryan Tong Minh bryan.tongm...@gmail.com wrote: Can we have a proper domain name for cruisecontrol? Something like testing.mediawiki.org. That is much easier to remember than ci.usability.tesla.wikimedia.org or whatever. That's because it was set up on the Tesla VMs. I'd like to put both CruiseControl and TestSwarm on the same box (so the latter can get off Krinkle's TS account). testing.mediawiki.org would be nice and generic for something like this :) -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91161]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r91161. Old Status: new New Status: ok User Krinkle also posted a comment on MediaWiki.r91161. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91161#c19026 Commit summary: adding image previewing for subtypes with single images Comment: Confirmed functionality on localhost, style rules look okay too. Marking ok. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91183]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r91183. Old Status: new New Status: ok User ^demon also posted a comment on MediaWiki.r91183. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91183#c19027 Commit summary: Tab w/s fixes Comment: Not sure why there's 2 spaces instead of 1 between = and ', but I'm just being pedantic. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r75341]: New comment added
User Bryan posted a comment on MediaWiki.r75341. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75341#c19029 Commit summary: Start of bug 24853, killing off 'functional' parts of failfunction code. Seems when the constructors start getting changed, it starts borking. Using this as a point of reversion/stashing Comment: Can't we just revert this? It doesn't hurt to have failFunction around, and killing it appears to give more trouble than it's worth. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r75341]: New comment added
User ^demon posted a comment on MediaWiki.r75341. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75341#c19030 Commit summary: Start of bug 24853, killing off 'functional' parts of failfunction code. Seems when the constructors start getting changed, it starts borking. Using this as a point of reversion/stashing Comment: Well it's completely useless and clutters the DB constructors. What problems still exist as of HEAD? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80988]: New comment added
User Bryan posted a comment on MediaWiki.r80988. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80988#c19031 Commit summary: HTMLForm: All section headers and footers. Added an optional second $section parameter to addHeaderText and addFooterText. Comment: Yes, you want to add the section heading to the top of the section. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80988]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r80988. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80988#c19032 Commit summary: HTMLForm: All section headers and footers. Added an optional second $section parameter to addHeaderText and addFooterText. Comment: Haha, I didn't see the code . $section/code bit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80988]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r80988. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80988#c0 Commit summary: HTMLForm: All section headers and footers. Added an optional second $section parameter to addHeaderText and addFooterText. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91185]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91185. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91185#c0 Commit summary: Follow-up r80988: fix function documentation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81536]: New comment added
User Bryan posted a comment on MediaWiki.r81536. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81536#c19033 Commit summary: (bug 19751) Filesystem is now checked during image undeletion * FSRepo::storeBatch() now does an sha1 check unless SKIP_VALIDATION flag is set * Introduced Status::$success in addition to Status::$successcount ** FSRepo::storeBatch() now logs success/failure in this variable * LocalFileRestoreBatch now aborts on failure in FSRepo::storeBatch() and cleans up the already copied files ** Introduced FSRepo::cleanupBatch() for this purpose * SpecialUndelete now aborts if LocalFile::restore() gives a fatal Comment: Thanks for the review. Fixed in r91188. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91189]: Revision status changed
User Catrope changed the status of MediaWiki.r91189. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91189#c0 Commit summary: slight tweaks to food descriptions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90996]: New comment added
User Jack Phoenix posted a comment on MediaWiki.r90996. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90996#c19034 Commit summary: Comment: I'd prefer if you used tabs instead of spaces consistently across the code. Right now, the first two lines and the last line of wfGetHistory use tabs, while the rest of the function uses spaces. Depending on your text editor, it should be relatively easy to set it to convert four spaces to one tab character. The JS should be (re)written to be object-oriented, just to avoid any problems with [[ResourceLoader]] (even though SocialProfile doesn't really support RL yet). See r91173 for an example where I converted UserBoard's BoardBlast.js to be more object-oriented. In UserStatusClass.php, you're adding a CSS file that does not (yet?) exist to the page output. I assume that you're planning to add the file eventually, so it's not such a big deal. As Nikerabbit mentioned above, messages should be prefixed with a key (I'd suggest codeuserstatus-/code) to prevent conflict with core MediaWiki message. If you later on decide to change UserStatus' edit message from Edit to Edit this status (for example), it won't change the text of the edit tab on [[Sandbox|normal wiki pages]]. :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r75341]: New comment added
User Reedy posted a comment on MediaWiki.r75341. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75341#c19035 Commit summary: Start of bug 24853, killing off 'functional' parts of failfunction code. Seems when the constructors start getting changed, it starts borking. Using this as a point of reversion/stashing Comment: It's been removed in the released 1.17 from the start Per the CR on this and r75343, it causes some failover issues with slave DB servers ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r222]: Revision status changed
User Awjrichards changed the status of Wikimedia.r222. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/222#c0 Commit summary: cosmetic update, cleaned up the import definitions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r209]: Revision status changed
User Awjrichards changed the status of Wikimedia.r209. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/209#c0 Commit summary: Initial import. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91163]: Revision status changed
User ^demon changed the status of MediaWiki.r91163. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91163#c0 Commit summary: Fixes for r91065 per CR: drop stray begin() call and use RUN_MAINTENANCE_IF_MAIN ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r211]: Revision status changed
User Awjrichards changed the status of Wikimedia.r211. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/211#c0 Commit summary: Removed redundant references to javascript libraries in base.html. removed local settings files added generalized versions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r212]: Revision status changed
User Awjrichards changed the status of Wikimedia.r212. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/212#c0 Commit summary: updates to general settings files ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r213]: Revision status changed
User Awjrichards changed the status of Wikimedia.r213. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/213#c0 Commit summary: removed redundant import sys statement ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r214]: Revision status changed
User Awjrichards changed the status of Wikimedia.r214. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/214#c0 Commit summary: removed hard coded references to db connection ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r215]: Revision status changed
User Awjrichards changed the status of Wikimedia.r215. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/215#c0 Commit summary: added statement to put the home projects directory on the classpath ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r216]: Revision status changed
User Awjrichards changed the status of Wikimedia.r216. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/216#c0 Commit summary: Escaped vulnerable template variables to prevent XSS (Cross Site Scripting) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r217]: Revision status changed
User Awjrichards changed the status of Wikimedia.r217. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/217#c0 Commit summary: cleaned up import statements ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r218]: Revision status changed
User Awjrichards changed the status of Wikimedia.r218. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/218#c0 Commit summary: Fixed potential unhandled ZeroDivisionError exception. Ensured that only the relevant files on the filesystem are being read for executed queries in HypothesisTestLoader - this will be refactored to use similar methods to other DataLoader classes in future. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] RL dynamic parameters
Hello, How do I pass parameters dynamically to an RL module? I need to pass a FileRepo object to the RL module when I call $wgOut-addModuleStyle(). Bryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [Wikimedia r197]: New comment added, and revision status changed
User Awjrichards changed the status of Wikimedia.r197.
Old Status: new
New Status: fixme
User Awjrichards also posted a comment on Wikimedia.r197.
Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/197#c19036
Commit summary:
Adding my first PHPUnit test to the repo.
This begins to address story 149 in the 2011 fundraiser. (Most of this won't
quite work until I also commit my updates to stompPFPPendingProcessorSA.php).
Comment:
pre
+ $this-refreshConfig(array('activemq_stomp_uri' = 'CompleteNonsense'));
/pre
:D
pre
+protected function setUp() {
+// $this-object = new StompPFPPendingProcessorSA;
+ // set some configuration variables (for more info, check in
PaypalIPNListener.php
+ $this-config_base = array (
+ 'pfp_url' = 'https://payflowpro.paypal.com',
+ 'pfp_partner_id' = '',
+ 'pfp_vendor_id' = '',
+ 'pfp_user_id' = '',
+ 'pfp_password' = '',
+ 'activemq_stomp_uri' = 'tcp://localhost:61613',
+ 'activemq_pending_queue' = '/queue/test_donations',
+ 'activemq_confirmed_queue' = '/queue/test_confirmed',
+ 'batch_size' = 20,
+ 'log_level' = 2,
+ 'stomp_path' =
'/var/www/civicrm/sites/all/modules/queue2civicrm/Stomp.php');
+
+ // instantaite the processor with our config options
+ $this-processor = new testPPPlogging($this-config_base);
+}
/pre
$this-config_base should not have hardcoded values where the values may not be
the same from machine to machine (eg stomp_path, activemq_stomp_uri, etc)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r197]: New comment added
User Awjrichards posted a comment on Wikimedia.r197. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/197#c19037 Commit summary: Adding my first PHPUnit test to the repo. This begins to address story 149 in the 2011 fundraiser. (Most of this won't quite work until I also commit my updates to stompPFPPendingProcessorSA.php). Comment: hahahah for some reason my :D didn't come through... perhaps because i forgot to type ':' :( ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91195]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91195. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91195#c0 Commit summary: Added normalizeSubpageLink() to DummyLinker. __call doesn't handle static function call attempts, __callStatic__ is PHP = 5.3, and both clobber references anyway. Just added a wrapper function instead. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89542]: Revision status changed
User Bryan changed the status of MediaWiki.r89542. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89542#c0 Commit summary: * (bug 21346) Make deleted images searchable by hash (disabled in Miser Mode) Effectively reverts r83411, but with the addition of it only works in !$wgMiserMode ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89544]: New comment added, and revision status changed
User Bryan changed the status of MediaWiki.r89544. Old Status: new New Status: ok User Bryan also posted a comment on MediaWiki.r89544. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89544#c19038 Commit summary: * (bug 27595) sha1 search of list=filearchive does not work Still disabled in misermode, but switched for LIKE rather than = Comment: Could be done, but doesn't really matter imho. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89544]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r89544. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89544#c19039 Commit summary: * (bug 27595) sha1 search of list=filearchive does not work Still disabled in misermode, but switched for LIKE rather than = Comment: What if you have abaf3d3.png and abaf3d3bagg.png rows (yes, rare)? LIKE abaf3d3% seems problematic. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r197]: New comment added, and revision status changed
User Awjrichards changed the status of Wikimedia.r197. Old Status: fixme New Status: ok User Awjrichards also posted a comment on Wikimedia.r197. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/197#c19040 Commit summary: Adding my first PHPUnit test to the repo. This begins to address story 149 in the 2011 fundraiser. (Most of this won't quite work until I also commit my updates to stompPFPPendingProcessorSA.php). Comment: Looks fixed in r198 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90273]: Revision status changed
User Bryan changed the status of MediaWiki.r90273. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90273#c0 Commit summary: Followup r89539, per CR, we don't need to append iw string as it already exists in rawTitleStr ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User TheDJ posted a comment on MediaWiki.r86088.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c19041
Commit summary:
Completely rewritten table sorting script.
Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732
1. Sites can specify custom collations.
The script accepts an object tableSorterCollation which contains a lookup
table, how specific characters should be treated.
For example, after setting tableSorterCollation={'ä':'ae', 'ß':'ss'}; in the
site's common.js any string containing an ä or Ä will be sorted as if it were a
'ae'.
2. Table rows can be forced to use a specific data type.
By setting class=sort-{Parsername}, the row will be parsed with the specified
algorithm. class=sort-date would force date sorting etc.
The following parsers are available: text, IPAddress, number, url, currency,
date, isoDate, usLongDate, time
3. Execution time is reduced by half or more.
Sorting a 935 row * 8 columns table:
Browser Before After
-- -
Chrome 10 90ms42ms
Safari 5115ms 48ms
Firefox 4 412ms 87ms
IE8 720ms 115ms
4. Based on the content language and the mdy vs dmy preference, the parser can
understand dates such as 17. März '11. wgMonthNames=[] and
wgMonthNamesShort=[]
in the content language and the mdy vs dmy preference are exported to js; A
table containing the following dates would be sorted correctly:
17. Jan. 01
23 Feb 1992
9.02.05
13 November 2001
14 Oktober '76
Was tested in ie6-8, chrome, safari 5, ff3 ff4
Comment:
I was incorrect, we do have tfoot support apparently in 1.18 (r85922), but all
content in Wikipedia currently assumes 'sortbottom'. I've been testing a few
tables that use sortbottom, and i think that about 50% will break when we
deploy this, because they don't use ! on all cells in their tablerow to
indicate that this 'sortbottom' row is a footer.
- We now have better syntax
- The old syntax is broken
So the question is:
- Should we also support the old syntax in order to prevent drama ?
- Should we explain up front to people what they need to fix in the articles in
order to make it working again ?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89539]: Revision status changed
User Bryan changed the status of MediaWiki.r89539. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89539#c0 Commit summary: * (bug 29237) add interwiki target url attribute to api/query/interwiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88053]: New comment added
User MarkAHershberger posted a comment on MediaWiki.r88053. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88053#c19042 Commit summary: Added direct file loading functionality to debug mode for both scripts and styles, with callbacks for module state changes (changing to ready) and executing of jobs and modules awaiting dependency resolutions. These changes also provide a way to used mw.loader.implement with arrays of URLs for the scripts and styles arguments, which will make it possible to implement modules using user scripts. This probably solves bug #27023 - tests to verify that will be coming soon. Comment: Sorry, I meant Bug #29608 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91193]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91193. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91193#c0 Commit summary: Linker::titleAttrib() didn't obey $wgEnableTooltipsAndAccesskeys ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89544]: New comment added
User Bryan posted a comment on MediaWiki.r89544. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89544#c19044 Commit summary: * (bug 27595) sha1 search of list=filearchive does not work Still disabled in misermode, but switched for LIKE rather than = Comment: The sha string is forced to be 31 characters long, so that should not be problematic. Fixed nevertheless in r91198. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r86088.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c19045
Commit summary:
Completely rewritten table sorting script.
Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732
1. Sites can specify custom collations.
The script accepts an object tableSorterCollation which contains a lookup
table, how specific characters should be treated.
For example, after setting tableSorterCollation={'ä':'ae', 'ß':'ss'}; in the
site's common.js any string containing an ä or Ä will be sorted as if it were a
'ae'.
2. Table rows can be forced to use a specific data type.
By setting class=sort-{Parsername}, the row will be parsed with the specified
algorithm. class=sort-date would force date sorting etc.
The following parsers are available: text, IPAddress, number, url, currency,
date, isoDate, usLongDate, time
3. Execution time is reduced by half or more.
Sorting a 935 row * 8 columns table:
Browser Before After
-- -
Chrome 10 90ms42ms
Safari 5115ms 48ms
Firefox 4 412ms 87ms
IE8 720ms 115ms
4. Based on the content language and the mdy vs dmy preference, the parser can
understand dates such as 17. März '11. wgMonthNames=[] and
wgMonthNamesShort=[]
in the content language and the mdy vs dmy preference are exported to js; A
table containing the following dates would be sorted correctly:
17. Jan. 01
23 Feb 1992
9.02.05
13 November 2001
14 Oktober '76
Was tested in ie6-8, chrome, safari 5, ff3 ff4
Comment:
* ''Should we also support the old syntax in order to prevent drama ?''
** Yes we should.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86527]: New comment added, and revision status changed
User Aaron Schulz changed the status of MediaWiki.r86527. Old Status: new New Status: fixme User Aaron Schulz also posted a comment on MediaWiki.r86527. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86527#c19046 Commit summary: Follow-up r86485: SQL error in patch, and also add the index to tables.sql. Comment: The 'user_name' part of the INDEX won't be useful here due to the nature of the 'user_email' portion. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91198]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91198. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91198#c0 Commit summary: Follow-up r89544: add dot per CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91181]: Revision status changed
User Hashar changed the status of MediaWiki.r91181. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91181#c0 Commit summary: Followup r91087, rename directory ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87420]: Revision status changed
User Bryan changed the status of MediaWiki.r87420. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87420#c0 Commit summary: Fix canonical special page names, was throwing notices about case mismatch ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91181]: New comment added
User Hashar posted a comment on MediaWiki.r91181. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91181#c19047 Commit summary: Followup r91087, rename directory Comment: Thanks for the rename. I was too lazy to find a correct directory name 8-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87391]: Revision status changed
User Bryan changed the status of MediaWiki.r87391. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87391#c0 Commit summary: Make sure video sizes are int's. Follow up to r65927 and fixes bug 28769 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91124]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r91124. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r91124. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91124#c19048 Commit summary: Add the rest of the example metrics Comment: The fixme was merely to attract your attention :))) I agree a wrapper array is a better idea, would save the scandir(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87386]: Revision status changed
User Bryan changed the status of MediaWiki.r87386. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87386#c0 Commit summary: (bug 28800) charinsert+/charinsert tries to insert the empty string instead of a literal +. The code assumed explode( +, + ) gave an empty array, where really it gave an array with 2 elements both of which are the empty string. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85706]: New comment added
User Bryan posted a comment on MediaWiki.r85706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85706#c19049 Commit summary: Initial stab at breaking math/texvc out to Math extension. * (bug 14202) $wgUseTeX has been superseded by the Math extension. To re-enable math conversion after upgrading, obtain the Math extension from SVN or from http://www.mediawiki.org/wiki/Extension:Math and add to LocalSettings.php: require_once $IP/extensions/Math/Math.php; This is an initial stab, and a few things remain to be cleaned up: * messages need to be moved from core to extension * MW_MATH_* constants should be moved to the extension from core * old back-compat math names interfaces using those constants should be removed from message files * classic edit toolbar's math button should be added from the extension (or else dropped) -- currently there's not a clean hook, but could do it by JS * couple of things like the 'armourMath' function on Language LanguageConverter may want to be redone just as an unconditional, if that's simpler. Setting $wgUseTeX alone will no longer have any affect. The var's still there for the moment as a few bits still need to be fully moved out from core. Comment: We should really ship this extension with the tarball to avoid breaking existing installations imho. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91122]: New comment added
User Helder.wiki posted a comment on MediaWiki.r91122. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91122#c19050 Commit summary: Implementing tooltips for ArticleFeedback * Rating container needed 1em more height to avoid text going through the form options * Messages swapped on-hover based on context of the rating-star-hover, then shown on hover-in and hidden on hover-out Comment: This fix Bug 29386 but the increase of the rating container height goes against fixing Bug 29303. On [[Thread:Talk:Article feedback/Please stop/reply (39)]], I suggested the following: :''the bottom half of the box could stay invisible until the user interacts with the tool clicking in some of stars (note: this saves ~50% of its current height). This wouldn't require any extra control (the first click made would serve both to define a rating and to display the remaining of the interface).'' I think the same solution is still possible after the addition of these tooltips. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84395]: New comment added
User Bryan posted a comment on MediaWiki.r84395. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84395#c19051 Commit summary: (bug 27641) purgeThumbnails should support exclusion of expensive files. Add $wgExcludeFromThumbnailPurge and don't purge thumbnails whose extension is in that array when the files they belong to are purged with action=purge. Committing patch by Michael Dale with small coding style tweaks Comment: I concur. purgeThumbnails() could be made to accept a list of extensions to exclude, and let the entry point determine to set that. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Domain name for cruisecontrol
On 30/06/11 19:26, Chad wrote: testing.mediawiki.org would be nice and generic for something like this :) Sounds good to me since CruiseControl, Testswarm and all are testing MediaWiki. The scheme could be: testing.mediawiki.org : welcome page \-- /cruisecontrol/ \-- /testswarm/ testing.wikimedia.org should only be for WMF. -- Ashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [Wikimedia r198]: New comment added, and revision status changed
User Awjrichards changed the status of Wikimedia.r198.
Old Status: new
New Status: fixme
User Awjrichards also posted a comment on Wikimedia.r198.
Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/198#c19052
Commit summary:
Fixing my unit test, adding a config.ini-dist, and fixing the thing it was
testing as well.
Story 149 in the 2011 fundraiser.
Comment:
I see these getting used in a few places in
trunk/fundraising-misc/queue_handling/payflowpro/tests/StompPFPPendingProcessorSATest.php:
pre
+ foreach ($logdata as $line_no = $line_data) {
+ if (strpos($line_data, Handling transaction ) 0) {
+ $resultLines[$line_no] = $line_data;
+ }
+ }
+
+ //at this point, the key and value of each $transactions is the
same.
+ foreach ($transactions as $id = $transaction) {
+ foreach ($resultLines as $line_no = $line_data) {
+ if (strpos($line_data, $id) 0) {
+ $transactions[$id] = $line_no;
+ }
+ break;
+ }
+ if (array_key_exists($transactions[$id], $resultLines))
{
+ unset($resultLines[$transactions[$id]]);
+ }
+ }
/pre
You might consider functionizing these for cleaner reuse.
pre
+ $payflow_query = implode('', $query);
/pre
This should probably be wrapped in rawurlencode() or something.
pre
+ if(array_key_exists('HTTP_USER_AGENT', $_SERVER)){
+ $user_agent = $_SERVER['HTTP_USER_AGENT'];
+ } else {
+ $user_agent = blargh?;
+ }
/pre
Heh - the 'else' statement should perhaps set the user agent to something more
clear/obvious as to what's going on - in this case, if no user agent exists in
the $_SERVER var we're probably runing this from the cli and/or as a test, so
perhaps a useful user agent would identify the script/owner/version/whatever
(eg 'WMF PayflowPro Pending Processor')
in the handle_pending_transaction() method of the processing class, why do we
pass it an expclicitly json encoded object only to decode immediately in the
method? This might be something silly I initially wrote in the class... is
this totally necessary?
there is an exit(1) in fetch_payflow_transaction_status() - we should probably
have this method return false and have the executing script handle exit stuff
like you did in set_stomp_connection().
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r200]: Revision status changed
User Awjrichards changed the status of Wikimedia.r200. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/200#c0 Commit summary: Adding a boostrap for phpUnit, so we can get nicer logs, test selection, and... anything else we might want to customize about the way phpUnit tests get executed everywhere. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91180]: New comment added
User IAlex posted a comment on MediaWiki.r91180. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91180#c19053 Commit summary: Fixes for r88113 and some realted changes: * Modified sArticle::editUpdates()/s WikiPage::doEditUpdates() arguments to take a Revision object, an User object and options (much more readable that those boolean parameters) * Call isCountable() on the old content and pass it to WikiPage::doEditUpdates() with the 'oldcountable' option so that it really reflects the old state of the page * Updated all calls (no one in extensions) and removed the wrapper WikiPage::editUpdates() * Call onArticleEdit() and onArticleCreate() (the one that is of course) from doEditUpdates() * Removed $wgTitle hack from Import.php Comment: Done in r91203. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User DieBuche posted a comment on MediaWiki.r86088.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86088#c19054
Commit summary:
Completely rewritten table sorting script.
Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732
1. Sites can specify custom collations.
The script accepts an object tableSorterCollation which contains a lookup
table, how specific characters should be treated.
For example, after setting tableSorterCollation={'ä':'ae', 'ß':'ss'}; in the
site's common.js any string containing an ä or Ä will be sorted as if it were a
'ae'.
2. Table rows can be forced to use a specific data type.
By setting class=sort-{Parsername}, the row will be parsed with the specified
algorithm. class=sort-date would force date sorting etc.
The following parsers are available: text, IPAddress, number, url, currency,
date, isoDate, usLongDate, time
3. Execution time is reduced by half or more.
Sorting a 935 row * 8 columns table:
Browser Before After
-- -
Chrome 10 90ms42ms
Safari 5115ms 48ms
Firefox 4 412ms 87ms
IE8 720ms 115ms
4. Based on the content language and the mdy vs dmy preference, the parser can
understand dates such as 17. März '11. wgMonthNames=[] and
wgMonthNamesShort=[]
in the content language and the mdy vs dmy preference are exported to js; A
table containing the following dates would be sorted correctly:
17. Jan. 01
23 Feb 1992
9.02.05
13 November 2001
14 Oktober '76
Was tested in ie6-8, chrome, safari 5, ff3 ff4
Comment:
It's wrapping sortbottoms inside tfoot's as of r91207
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91203]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91203. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91203#c0 Commit summary: Per Aaron, fix for r91180: pass false to second parameter of User::newFromName() to allow anonymous users ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
