[MediaWiki-CodeReview] [MediaWiki r98740]: New comment added
User Petrb posted a comment on MediaWiki.r98740. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98740#c23857 Commit summary: Fixed missing = in ApiDelete.php Comment: resolved ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Preliminary git module splitup notes (MediaWiki core extensions)
On 6 October 2011 00:12, Siebrand Mazeland s.mazel...@xs4all.nl wrote: Is that ssh session share thingy also available for Windows users? As Windows users generally use putty (although I'm not 100% sure about git-mingw, in this respect, but it works at least with tortoisesvn, and probably also with tortoisegit): pageant is what you're looking for. It's available from the putty website [1]. Best, Merlijn [1] http://www.chiark.greenend.org.uk/~sgtatham/putty/download.html ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Preliminary git module splitup notes (MediaWiki core extensions)
On 11-10-05 03:07 PM, Happy Melon wrote: On 5 October 2011 22:30, Brion Vibber br...@pobox.com wrote: On Wed, Oct 5, 2011 at 1:59 PM, Brion Vibber br...@pobox.com wrote: This could still end up pulling from 600+ repos -- if there are actually changes in them all! -- but should make typical cases a *lot* faster. Pushed localisation updates from translatewiki would produce precisely this effect (minor but nonzero changes to hundreds of repos) on a daily or at least weekly basis. :-( --HM I wish we could stop pushing TWN updates as code commits. I'm getting tired of trying to look through an extension's log for changes and having to sort through it where 3/4 of the commits are TWN updates. Someone mentioned an idea at one point of having only English in core (as the source for translations) and then pulling localization updates in with some script, part of building the tarballs would be pulling in the localizations and bundling them. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r98669]: New comment added
User TheDJ posted a comment on MediaWiki.r98669. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98669#c23859 Commit summary: Add tfoot emulation to tablesorter. Fixes part of the complaints in bug 31060 Comment: We should check a table with an emulated tfoot, AND separate sortbottom... They both add tfoots, and I think that will fail with this change... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94627]: New comment added
User BotInc posted a comment on MediaWiki.r94627. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94627#c23860 Commit summary: Add FormData upload transport. If enabled this is used in Browsers that support FormData. Larger files are uploaded in chunks. Comment: r99013 refines FormData upload * use $j.parseJSON and set response.error if it fails * move function to detect slice api support into mw.fileApi * rename wait to chunsRemaining ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99067]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r99067. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99067#c23861 Commit summary: * (bug 31374) Pass relevant additional parameters for action=raw on Special:Mypage redirects Found that Special:MyPage was sometimes being used in importScript() calls to make references to the owner's other user subpages, such as loading a User:Blah/monobook.js from User:Blah/vector.js. The importScript() correctly included action=raw and ctype=text/javascript parameters, but Special:MyPage was redirecting to the actual URL and dropped the ctype parameter. IE 9 actually now validates content-type for scripts loaded into script -- if and only if you send X-Content-Type-Options: nosniff. Since we now do that (since bug 15461 / r87997) this created a break for IE9 users when upgrading from MW 1.17 (without the nosniff) to MW 1.18 (with it). Can also work around by replacing the Special:MyPage reference with a direct one. No other browsers I tested (Firefox 8, Chrome 14, Opera 11.5) rejected a script load for text/x-wiki but it's a legit thing to do (Firefox does check for CSS) Comment: delete tag 1.18wmf1, is already applied ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99067]: New comment added
User Catrope posted a comment on MediaWiki.r99067. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99067#c23863 Commit summary: * (bug 31374) Pass relevant additional parameters for action=raw on Special:Mypage redirects Found that Special:MyPage was sometimes being used in importScript() calls to make references to the owner's other user subpages, such as loading a User:Blah/monobook.js from User:Blah/vector.js. The importScript() correctly included action=raw and ctype=text/javascript parameters, but Special:MyPage was redirecting to the actual URL and dropped the ctype parameter. IE 9 actually now validates content-type for scripts loaded into script -- if and only if you send X-Content-Type-Options: nosniff. Since we now do that (since bug 15461 / r87997) this created a break for IE9 users when upgrading from MW 1.17 (without the nosniff) to MW 1.18 (with it). Can also work around by replacing the Special:MyPage reference with a direct one. No other browsers I tested (Firefox 8, Chrome 14, Opera 11.5) rejected a script load for text/x-wiki but it's a legit thing to do (Firefox does check for CSS) Comment: It's bug 31401 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99067]: New comment added
User Catrope posted a comment on MediaWiki.r99067. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99067#c23864 Commit summary: * (bug 31374) Pass relevant additional parameters for action=raw on Special:Mypage redirects Found that Special:MyPage was sometimes being used in importScript() calls to make references to the owner's other user subpages, such as loading a User:Blah/monobook.js from User:Blah/vector.js. The importScript() correctly included action=raw and ctype=text/javascript parameters, but Special:MyPage was redirecting to the actual URL and dropped the ctype parameter. IE 9 actually now validates content-type for scripts loaded into script -- if and only if you send X-Content-Type-Options: nosniff. Since we now do that (since bug 15461 / r87997) this created a break for IE9 users when upgrading from MW 1.17 (without the nosniff) to MW 1.18 (with it). Can also work around by replacing the Special:MyPage reference with a direct one. No other browsers I tested (Firefox 8, Chrome 14, Opera 11.5) rejected a script load for text/x-wiki but it's a legit thing to do (Firefox does check for CSS) Comment: Ahm, I meant bug 31400 of course. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88025]: New comment added
User Optimist on the run posted a comment on MediaWiki.r88025. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88025#c23865 Commit summary: * removed unused messages because of previous revert. * hidden namespace select box if in wgMiserMode(requested by domas) Comment: Definitely not a good move - please restore the functionality, or revert back to previous version (which would solve all the other bugs that seem to have been introduced - see WP:VPT on enwiki). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98669]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r98669. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r98669. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98669#c23866 Commit summary: Add tfoot emulation to tablesorter. Fixes part of the complaints in bug 31060 Comment: Also, the tfoot emulation is in an if(thead present) block, that doesn't look good. Marking fixme for this and the previous comment. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98235]: Revision status changed
User Catrope changed the status of MediaWiki.r98235. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98235 Commit summary: (bug 31088) [Regression] Create account/log in should use the current title and query in returnto ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98773]: Revision status changed
User Catrope changed the status of MediaWiki.r98773. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98773 Commit summary: fix Bug #31317 - LiquidThreads arrow icon disappears upon collapsing a thread Thanks to p858snake for the hint. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99082]: Revision status changed
User Catrope changed the status of MediaWiki.r99082. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99082 Commit summary: Fix a regression from 1.17: Show date/times in user preference timezone. Ping r84258. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99061]: New comment added
User Catrope posted a comment on MediaWiki.r99061. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99061#c23867 Commit summary: MFT r94199 Comment: Maybe you could tell me why the 1e9 was there? Maybe you could have even put this in a comment when you committed the change in the first place so we wouldn't have to guess and/or ask? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99012]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r99012. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99012 Commit summary: Remove support for unused Wikimedia specific extension. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99061]: New comment added
User Midom posted a comment on MediaWiki.r99061. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99061#c23868 Commit summary: MFT r94199 Comment: avoid not caching data because of stupid memcached heuristics on ttl value see, heuristics doesn't mean handling very high TTL values very well, Wikipedia defines it as: Heuristic ( /hjʉˈrɪstɨk/; or heuristics; Greek: Εὑρίσκω, find or discover) refers to experience-based techniques for problem solving, learning, and discovery. Heuristic methods are used to speed up the process of finding a satisfactory solution, where an exhaustive search is impractical. Examples of this method include using a rule of thumb, an educated guess, an intuitive judgment, or common sense. What it means here, is that I'm overwriting some kind of rule of thumb and deliberately want to leave a high value by establishing another boundary in the check. Why would I want that? Because heuristics decide whether TTL is relative or absolute, and we still allow that. I was trying to make the change without enforcing bad behavior. When you dropped the range check, you potentially broke something, without thinking much, and blaming that you were not informed enough. You were informed, you had the check in the code, which was based on whatever I was contemplating on at that time. Cheers! ;-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88025]: Revision status changed
User Catrope changed the status of MediaWiki.r88025. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88025 Commit summary: * removed unused messages because of previous revert. * hidden namespace select box if in wgMiserMode(requested by domas) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88026]: Revision status changed
User Catrope changed the status of MediaWiki.r88026. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88026 Commit summary: * addon to previous ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99105]: New comment added
User Midom posted a comment on MediaWiki.r99105. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99105#c23869 Commit summary: 1.18wmf1: MFT r99104 Comment: ... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98405]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r98405.
Old Status: new
New Status: fixme
User Reedy also posted a comment on MediaWiki.r98405.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98405#c23870
Commit summary:
HTMLFileCache refactoring:
* Rewrote class and split into three classes: a base class, and html cache and
a more generic cache to be used later.
* The new classes now use RequestContext.
* Renamed fetchPageText() - fetchText().
* Split out new saveText() function from saveToFileCache().
* Various other cleanups and fixes.
Also fixed backwards setting of $wgDisableCounters in rebuildFileCache.php.
Comment:
pre
public static function newFromKey( $key, $type ) {
$cache = new self();
$cache-mKey = (string)$key;
$cache-mType = (string)$type;
$cache-mExt = 'cache';
return $cache;
}
/pre
new self(); in an abstract class isn't valid:
pre
abstract class foo {
static function create() {
return new self();
}
}
class foo2 extends foo {
}
var_dump( foo::create() );
/pre
pre
PHP Fatal error: Cannot instantiate abstract class foo in /home/reedy/test.php
on line 5
PHP Stack trace:
PHP 1. {main}() /home/reedy/test.php:0
PHP 2. foo::create() /home/reedy/test.php:13
/pre
pre
abstract class foo {
static function create() {
return new self();
}
}
class foo2 extends foo {
}
var_dump( foo1::create() );
/pre
pre
reedy@ubuntu64-web-esxi:~$ php test.php
PHP Fatal error: Cannot instantiate abstract class foo in /home/reedy/test.php
on line 5
PHP Stack trace:
PHP 1. {main}() /home/reedy/test.php:0
PHP 2. foo::create() /home/reedy/test.php:13
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99104]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r99104. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99104#c23871 Commit summary: Followup r99102: revert r88026 too, otherwise the dropdown is visible but not functional Comment: was added to 1.18wmf1, please consider tagging for 1.18 as well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99102]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r99102. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99102#c23872 Commit summary: Revert r88025 (put Special:Contributions namespace filter behind $wgMiserMode). People on-wiki really hate this, and Domas gave the green light (see https://bugzilla.wikimedia.org/show_bug.cgi?id=31197#c34 ) Comment: was added to 1.18wmf1, please consider tagging for 1.18 as well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99097]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r99097. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99097#c23873 Commit summary: (bug 31411) Remove stray comma introduced in r86853, broke WikiEditor in IE Comment: was added to 1.18wmf1, please consider tagging for 1.18 as well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99097]: New comment added
User ^demon posted a comment on MediaWiki.r99097. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99097#c23874 Commit summary: (bug 31411) Remove stray comma introduced in r86853, broke WikiEditor in IE Comment: Let's also tag for 1.4-1.17 :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99097]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r99097. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99097#c23875 Commit summary: (bug 31411) Remove stray comma introduced in r86853, broke WikiEditor in IE Comment: Not really, but as someone who has struggled with an unusable 1.17, I try to convince you to fix both 1.18 and 1.18wmf1 version :-) Is there a good reason the WikiEditor should continue to fail to work in IE in 1.18, while working in 1.18wmf1? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99097]: New comment added
User ^demon posted a comment on MediaWiki.r99097. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99097#c23876 Commit summary: (bug 31411) Remove stray comma introduced in r86853, broke WikiEditor in IE Comment: No, I was being sarcastic :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Preliminary git module splitup notes (MediaWiki core extensions)
On 06.10.2011, 2:12 Conrad Irwin wrote: What's the use-case for checking out all of the extensions? Presumably that would only be needed if you wanted to do some global clean-up, so this won't affect the majority of people too extremely. Actually, it's pretty common, most if not all active core devs do that because every change to core APIs must be accompanied with a grep through extensions to check if it's OK or something will need to be fixed. -- Best regards, Max Semenik ([[User:MaxSem]]) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r99082]: New comment added
User Nikerabbit posted a comment on MediaWiki.r99082. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99082#c23878 Commit summary: Fix a regression from 1.17: Show date/times in user preference timezone. Ping r84258. Comment: Timezome? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99097]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r99097. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99097 Commit summary: (bug 31411) Remove stray comma introduced in r86853, broke WikiEditor in IE ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99103]: Revision status changed
User Krinkle changed the status of MediaWiki.r99103. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99103 Commit summary: 1.18wmf1: MFT r99102 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99102]: Revision status changed
User Krinkle changed the status of MediaWiki.r99102. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99102 Commit summary: Revert r88025 (put Special:Contributions namespace filter behind $wgMiserMode). People on-wiki really hate this, and Domas gave the green light (see https://bugzilla.wikimedia.org/show_bug.cgi?id=31197#c34 ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99104]: Revision status changed
User Krinkle changed the status of MediaWiki.r99104. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99104 Commit summary: Followup r99102: revert r88026 too, otherwise the dropdown is visible but not functional ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99105]: Revision status changed
User Krinkle changed the status of MediaWiki.r99105. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99105 Commit summary: 1.18wmf1: MFT r99104 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98669]: New comment added
User TheDJ posted a comment on MediaWiki.r98669. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98669#c23879 Commit summary: Add tfoot emulation to tablesorter. Fixes part of the complaints in bug 31060 Comment: Actually, that's no problem. The reasoning is that only there where thead emulation is only needed where thead's cannot be defined (1.18 wikicode See also: Special:Code/MediaWiki/85922#c22569). In those situation, thead's need emulation or you cannot have tableheaders at all. If you are able to define theads, you should be able to define tfoots and probably should be doing that then as well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99101]: New comment added
User Nikerabbit posted a comment on MediaWiki.r99101.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99101#c23880
Commit summary:
More documentation
Added 1 TODO
Comment:
pre
+ /**
+* @return MediaWikiMessageChecker
+*/
public function getChecker() {
/pre
I'd argue it's implementation detail what kind of MessageChecker it returns.
pre
+* @param $tables array|stromg
/pre
omg?
I don't see the point of documenting params of hook functions.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97020]: New comment added, and revision status changed
User Khorn (WMF) changed the status of MediaWiki.r97020. Old Status: new New Status: ok User Khorn (WMF) also posted a comment on MediaWiki.r97020. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97020#c23881 Commit summary: Corrected incorrect token names and hidden form field values in webitects_1 rapid html form Comment: These values do, in fact, match up with what I've got in Donation Interface. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99108]: New comment added
User Nikerabbit posted a comment on MediaWiki.r99108.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99108#c23882
Commit summary:
Kill weird leading semi colon from jquery.form.js
More documentation stuff
Comment:
pre
/**
* @todo Very long code block; split up.
+*
+* @param $group MessageGroup
*/
public function importForm( $group, $code ) {
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r9547]: Revision status changed
User Xqt changed the status of pywikipedia.r9547. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9547 Commit summary: Fix script loading the wrong message name ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r9559]: Revision status changed
User Xqt changed the status of pywikipedia.r9559. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9559 Commit summary: Localisation updates from http://translatewiki.net. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r9562]: Revision status changed
User Xqt changed the status of pywikipedia.r9562. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9562 Commit summary: Change title format to: File:title - project - username.jpg ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99111]: New comment added
User Nikerabbit posted a comment on MediaWiki.r99111. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99111#c23883 Commit summary: Fix usage of @ Documentation Comment: pre -* @param $groupId string \Message group id -* @param $code string \Language code +* @param $groupId string Message group id +* @param $code string Language code /pre I think I meant %Message and %Language here. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99112]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r99112.
Old Status: new
New Status: fixme
User Nikerabbit also posted a comment on MediaWiki.r99112.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99112#c23884
Commit summary:
More documentation updates and additions
Added TODO to UserToggles.php
Comment:
pre+* @param null $type
/pre
pre
/**
* Adds one tests for this checker.
* @see setChecks()
+* @param $check
*/
public function addCheck( $check ) {
/pre
I really don't see the point of these types of additions either. It doesn't add
anything, but increases code maintenance cost, less code visible on screen etc.
pre+ * @param null $channel
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98154]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r98154. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98154 Commit summary: Cleanup unneeded translations. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98155]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r98155. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98155 Commit summary: Update tags and put 4 keys on each line. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98323]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r98323. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98323 Commit summary: Started taking PHP code out of the groups/ folder anticipating Wikimedia review. Later we will move all content of the groups folder elsewhere to reduce the number of changes of changes to the Translate extension considerably. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98395]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r98395. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98395 Commit summary: Update codeMap. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99095]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r99095. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99095 Commit summary: Even though we're not giving a continue (though, it all should fit in), if we get a no from addValue(), we might aswell stop iterating over the results and attempting to push them in ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99112]: New comment added
User Reedy posted a comment on MediaWiki.r99112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99112#c23886 Commit summary: More documentation updates and additions Added TODO to UserToggles.php Comment: I can't see the whitespace issues either in my IDE or just in a text browser, so I'm presuming I've fixed them in a subsequent commit ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99112]: New comment added
User Nikerabbit posted a comment on MediaWiki.r99112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99112#c23888 Commit summary: More documentation updates and additions Added TODO to UserToggles.php Comment: Whitespace? Should be @param $foo type and not type $foo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91770]: New comment added, and revision status changed
User MaxSem changed the status of MediaWiki.r91770. Old Status: resolved New Status: fixme User MaxSem also posted a comment on MediaWiki.r91770. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91770#c23889 Commit summary: Translate the block expiry date I wonder why this hasn't been done yet... Comment: After this revision and followups: * Block a user for 1 second * Look at that user's block log * You'll see current date time as expiry date time ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98669]: New comment added
User Catrope posted a comment on MediaWiki.r98669. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98669#c23890 Commit summary: Add tfoot emulation to tablesorter. Fixes part of the complaints in bug 31060 Comment: Right. So does the double tfoot thing happen? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Git migration planning
We also want to move over the generic Wikimedia repot. --tomasz On Wed, Oct 5, 2011 at 7:41 AM, Rob Lanphier ro...@wikimedia.org wrote: On Tue, Oct 4, 2011 at 9:21 AM, Merlijn van Deen valhall...@arctus.nl wrote: Currently, svn.wikimedia.org also hosts other repositories, most notably the pywikipedia repository. Is the plan to keep svn.wikimedia.org and svn-based code review online after the switch, or will the pywikipedia repository also have to switch? We're not in a big hurry to shut down our svn services, and pywikipedia is not really tangled up in the MediaWiki codebase, so I don't imagine we'll be rushing to convert it to git. I imagine there will come a day when we want to get out of the svn business, but we have a few months (at least) to figure out our strategy there. In the short term, pywikipedia in svn can peacefully coexist with MediaWiki + extensions in git. Rob ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Help setting up mysql.cnf for local WIki mirror
Hi, I am hoping that someone here can help me - I realize there is an xmlwikidumps mailing list but it is pretty low volume and expertise relative to this one. THere is a lot of conflicting advice on the mirroring wikipedia page. C I am setting up a local mirror of english Wikipedia pages-articles...xml and I have been stopped by repeated failures in mySQL configuration. I have downloaded the .gz data from the dumped and run it through mwdumper to create an SQL file without problems, but things keep breaking down on the way into mysql. I have had a lot of agony with inno_db log files, etc. and have learned how to make them bigger, but I'm still apaprently missing some pieces. my target machine is an AWS instance 32 bit Ubuntu 1.7GB RAM, 1 Core, 200 GB, which is only for this project. I can make it bigger if necessary. Can someone take a look at this my.cnf file and tell me what I need to change to get this to work? this is what my.cnf file looks like: [mysqladmin] user= [mysqld] basedir=/opt/bitnami/mysql datadir=/opt/bitnami/mysql/data port=3306 socket=/opt/bitnami/mysql/tmp/mysql.sock tmpdir=/opt/bitnami/mysql/tmp character-set-server=UTF8 collation-server=utf8_general_ci max_allowed_packet=128M wait_timeout = 120 long_query_time = 1 log_slow_queries log_queries_not_using_indexes query_cache_limit=2M query_cache_type=1 query_cache_size=128M innodb_additional_mem_pool_size=8M innodb_buffer_pool_size=256M innodb_log_file_size=128M #tmp_table_size=64M #max_connections = 2500 #max_user_connections = 2500 innodb_flush_method=O_DIRECT #key_buffer_size=64M [mysqld_safe] mysqld=mysqld.bin [client] default-character-set=UTF8 port=3306 socket=/opt/bitnami/mysql/tmp/mysql.sock [manager] port=3306 socket=/opt/bitnami/mysql/tmp/mysql.sock pid-file=/opt/bitnami/mysql/tmp/manager.pid default-mysqld-path=/opt/bitnami/mysql/bin/mysqld.bin ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Google's cached pages are much faster than wiki*edia's
From the wmf office in San Francisco, webcache.googleusercontent.comresolves to something geographically close and network RT time is around 25ms versus 86ms for en.wikipedia.org, 61ms in googles favor. From chrome in incognito mode to avoid sending wikipedia cookies, it takes me 391ms to fetch just the html for http://webcache.googleusercontent.com/search?q=cache:FXQPcAQ_2WIJ:en.wikipedia.org/wiki/Devo+wikipedia+devoamp;cd=1amp;hl=enamp;ct=clnkamp;gl=us vs 503ms for http://en.wikipedia.org/wiki/Devo. That difference of 112ms is less than the latency difference from two round trips, but the request depends on more, meaning that our squids are serving the content faster than google is. Pulling http://en.wikipedia.org/wiki/Devo from a host in our tampa datacenter takes an average of 3ms. If we had a west coast caching presence, I think we'd beat google's cache from our office, but I doubt we'll ever be able to compete with google on global points of caching presence, or network connectivity. Note that if you're using wikipedia from a browser that has been logged in within the last month, it is likely still sending cookies that bypass our squid caches even when logged out. On Fri, Sep 30, 2011 at 3:48 PM, jida...@jidanni.org wrote: Fellows, This is Google's cache of http://en.wikipedia.org/wiki/Devo. It is a snapshot of the page as it appeared on 28 Sep 2011 09:22:50 GMT. The current page could have changed in the meantime. Learn more ... Like why is it so much faster than the real thing? Even when not logged in. Nope, you may be one of the top ranked websites, but no by speed. So if you can't beat 'em join 'em. Somehow use Google's caches instead of your own. Something, anything, for a little more speed. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r99100]: New comment added
User Happy-melon posted a comment on MediaWiki.r99100. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99100#c23892 Commit summary: FU r83909: restore preprocessing stage to cache link existence using LinkBatch; otherwise a separate DB query is done on every link. Since the ipb_by_text field is no longer in use we still have to do a cross-cast to get the usernames from the ids stored in ipb_by, but we can do that with one query via a UserArray, so it's not significantly worse than before. Comment: I'm still working on that tt:D/tt ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99138]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r99138. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99138#c23894 Commit summary: (bug 29392) Setting the start or end parameter now works with lists blocks, categorymembers, deletedrevs, logevents, protectedtitles, usercontributions and watchlist in Postgres. Since all those used ApiQueryBase::addWhereRange, added ApiQueryBase::addTimestampWhereRange, which does automagic timestamp conversion. Not tested whether this actually fixes problems in Postgres, but at least the API modules are still functional in SQLite Comment: REL 1.18 yes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Help setting up mysql.cnf for local WIki mirror
On Thu, Oct 6, 2011 at 12:54 PM, Fred Zimmerman zimzaz@gmail.comwrote: Hi, I am hoping that someone here can help me - I realize there is an xmlwikidumps mailing list but it is pretty low volume and expertise relative to this one. THere is a lot of conflicting advice on the mirroring wikipedia page. C I am setting up a local mirror of english Wikipedia pages-articles...xml and I have been stopped by repeated failures in mySQL configuration. I have downloaded the .gz data from the dumped and run it through mwdumper to create an SQL file without problems, but things keep breaking down on the way into mysql. I have had a lot of agony with inno_db log files, etc. and have learned how to make them bigger, but I'm still apaprently missing some pieces. What fails, exactly? Do you get error messages of some kind? Without knowing what's going wrong, there's little advice that can be given. my target machine is an AWS instance 32 bit Ubuntu 1.7GB RAM, 1 Core, 200 GB, which is only for this project. I can make it bigger if necessary. Can someone take a look at this my.cnf file and tell me what I need to change to get this to work? this is what my.cnf file looks like: The only requirement I can think of is making sure max_packet_size is biggish so all the pages import; you appear to have set it to 128M which should be more than big enough. Other settings I would assume should depend on your available memory, workload, etc. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r98583]: New comment added
User Enomil posted a comment on MediaWiki.r98583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98583#c23895 Commit summary: * (bug 26028) Preserve initial newlines in ProofreadPage customized edit interface. Same basic problem as bug 12130, but not fixed by that fix because ProofreadPage creates its own textareas as HTML strings in JavaScript, where fixes to Html::textarea() in PHP-land have no effect. :) Comment: It adds useless lines beetwen the noinclude from the footer and the footer text itself, see http://de.wikisource.org/wiki/Wikisource:Skriptorium#zus.C3.A4tzliche_Leerzeilen_im_Footer with difflinks ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98405]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r98405. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98405 Commit summary: HTMLFileCache refactoring: * Rewrote class and split into three classes: a base class, and html cache and a more generic cache to be used later. * The new classes now use RequestContext. * Renamed fetchPageText() - fetchText(). * Split out new saveText() function from saveToFileCache(). * Various other cleanups and fixes. Also fixed backwards setting of $wgDisableCounters in rebuildFileCache.php. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98583]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r98583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98583#c23896 Commit summary: * (bug 26028) Preserve initial newlines in ProofreadPage customized edit interface. Same basic problem as bug 12130, but not fixed by that fix because ProofreadPage creates its own textareas as HTML strings in JavaScript, where fixes to Html::textarea() in PHP-land have no effect. :) Comment: My German's a bit rusty, can you provide the steps to reproduce the bug? (exact page to hit, exact things to do while editing, exact browser version used) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98583]: New comment added
User Enomil posted a comment on MediaWiki.r98583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98583#c23897 Commit summary: * (bug 26028) Preserve initial newlines in ProofreadPage customized edit interface. Same basic problem as bug 12130, but not fixed by that fix because ProofreadPage creates its own textareas as HTML strings in JavaScript, where fixes to Html::textarea() in PHP-land have no effect. :) Comment: If you edit, preview or let you show the changes at any Page: page (on german ws Seite:) it adds every time a linebreak in the footer. The page is with the scheme noincludeheader/noincludetextnoincludefooter/noinclude. The linebreaks from the footer and textbox are stripped away if the extension rebuild the complete page by JS (does not know if it is on oldwikisource or now in the extension itself) but not the linebreak from the footer. It effects all wikisource which uses Proofread Page, example pages (the also last history diffs): http://de.wikisource.org/wiki/Seite:De_DZfG_1889_01_173.jpg http://en.wikisource.org/wiki/Page:Southern_Historical_Society_Papers_volume_03.djvu/216 http://fr.wikisource.org/wiki/Page:Aventures_merveilleuses_de_Huon_de_Bordeaux.djvu/35 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98583]: New comment added
User Enomil posted a comment on MediaWiki.r98583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98583#c23898 Commit summary: * (bug 26028) Preserve initial newlines in ProofreadPage customized edit interface. Same basic problem as bug 12130, but not fixed by that fix because ProofreadPage creates its own textareas as HTML strings in JavaScript, where fixes to Html::textarea() in PHP-land have no effect. :) Comment: sorry, it strips the noinclude tags in the scheme: [noinclude]header[/noinclude]text[noinclude]footer[/noinclude] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99152]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r99152. Old Status: new New Status: fixme User ^demon also posted a comment on MediaWiki.r99152. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99152#c23899 Commit summary: === 2011-10-06 === * Added CHANGELOG * Added support for older versions of MW that do not have a resource loader * Spark sometimes needs additional JavaScript. It can be given in LocalSettings.php using the variable $wgResourceModules Comment: Needs eol-style. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91770]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r91770. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91770#c23900 Commit summary: Translate the block expiry date I wonder why this hasn't been done yet... Comment: This appears to be bug 31352. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91770]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r91770. Old Status: fixme New Status: reverted User Brion VIBBER also posted a comment on MediaWiki.r91770. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91770#c23901 Commit summary: Translate the block expiry date I wonder why this hasn't been done yet... Comment: Reverted in r99155. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91786]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r91786. Old Status: ok New Status: reverted User Brion VIBBER also posted a comment on MediaWiki.r91786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91786#c23902 Commit summary: Follow-up r91770: only translate when possible Comment: Reverted in r99155. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91786]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r91786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91786#c23903 Commit summary: Follow-up r91770: only translate when possible Comment: r99154. blh ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84534]: New comment added
User Happy-melon posted a comment on MediaWiki.r84534. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84534#c23904 Commit summary: (hopefully) last bit of heavy lifting in Block.php: now that we've internalised most of the variables, untangle their twisted connections to the database layer and remove various now-unused protected methods and variables. Comment: Does that patch actually work? My IDE complains about User::setItemLoaded() being private... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Some post-1.18 issues found on Meta
On 06/10/11 07:25, Platonides wrote: Arthur Richards wrote: 2) Another user was attempting to move a page on Meta when she saw this: PHP fatal error in /usr/local/apache/common-local/php-1.18/includes/GlobalFunctions.php line 1197: Object of class AFPData could not be converted to string AFPData is a class used by the AbuseFilter Line 1197 is wfMsgReplaceArgs. Somewhere in AbuseFilter extension there is a wrong call to a wfMsg() function. The best way to debug this is with a full backtrace. I fixed this in r99059. -- Tim Starling ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Help setting up mysql.cnf for local WIki mirror
I don't have all the log files with me at the moment. I am gathering myself for a fresh start. How about a .cnf file that demonstrably works? What fails, exactly? Do you get error messages of some kind? Without knowing what's going wrong, there's little advice that can be given. my target machine is an AWS instance 32 bit Ubuntu 1.7GB RAM, 1 Core, 200 GB, which is only for this project. I can make it bigger if necessary. Can someone take a look at this my.cnf file and tell me what I need to change to get this to work? this is what my.cnf file looks like: The only requirement I can think of is making sure max_packet_size is biggish so all the pages import; you appear to have set it to 128M which should be more than big enough. Other settings I would assume should depend on your available memory, workload, etc. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97122]: Revision status changed
User Khorn (WMF) changed the status of MediaWiki.r97122. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97122 Commit summary: Adding DonationInterface API js to RapidHtml forms when _cache_=true in the request. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98583]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r98583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98583#c23905 Commit summary: * (bug 26028) Preserve initial newlines in ProofreadPage customized edit interface. Same basic problem as bug 12130, but not fixed by that fix because ProofreadPage creates its own textareas as HTML strings in JavaScript, where fixes to Html::textarea() in PHP-land have no effect. :) Comment: r99164 should fix this up. ProofreadPage was adding a newline inside the footer on every save, which was only visible on the first edit because on subsequent edits the newline got silently eaten in the textarea and then re-inserted again on save. Moved the inserted newline from inside the footer's lt;noinclude to outside it, so we still make sure there's a newline before the header but it's in a place where extra newlines get trimmed (end of body area) so it won't grow forever. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97942]: Revision status changed
User Khorn (WMF) changed the status of MediaWiki.r97942. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97942 Commit summary: Reverting r97940, clobbers fix from r97928 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98582]: Revision status changed
User Khorn (WMF) changed the status of MediaWiki.r98582. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98582 Commit summary: ResourceLoader-ifying RapidHtml webitects forms ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Help setting up mysql.cnf for local WIki mirror
You can see the one used live on our sites: https://gerrit.wikimedia.org/r/gitweb?p=operations/puppet.git;a=blob;f=templates/mysql/prod.my.cnf.erb;h=734009a4c170ffc2f525c4e18fc4c72352cffe45;hb=HEAD https://gerrit.wikimedia.org/r/gitweb?p=operations/puppet.git;a=blob;f=manifests/mysql.pp;h=c9eef470a2e33559e011f49474642b7752e0f793;hb=HEAD Unfortunately, it's a puppet template, but you can substitute the variables with their values in the related puppet manifest. - Ryan On Thu, Oct 6, 2011 at 6:55 PM, Fred Zimmerman zimzaz@gmail.com wrote: I don't have all the log files with me at the moment. I am gathering myself for a fresh start. How about a .cnf file that demonstrably works? What fails, exactly? Do you get error messages of some kind? Without knowing what's going wrong, there's little advice that can be given. my target machine is an AWS instance 32 bit Ubuntu 1.7GB RAM, 1 Core, 200 GB, which is only for this project. I can make it bigger if necessary. Can someone take a look at this my.cnf file and tell me what I need to change to get this to work? this is what my.cnf file looks like: The only requirement I can think of is making sure max_packet_size is biggish so all the pages import; you appear to have set it to 128M which should be more than big enough. Other settings I would assume should depend on your available memory, workload, etc. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r98589]: Revision status changed
User Khorn (WMF) changed the status of MediaWiki.r98589. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98589 Commit summary: ResourceLoader-ifying lightbox rapidhtml form ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99077]: Revision status changed
User Khorn (WMF) changed the status of MediaWiki.r99077. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99077 Commit summary: ResourceLoader-ifying globalcollect_test forms, core CSS for forms and input validation js ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99154]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r99154. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99154 Commit summary: * (bug 31352) Fix regression causing relative block times in log display to resolve against current time Revert r91770, r91786: strtotime() to resolve relative times is unsafe when the base of that relative time might have been days, months, or years ago and isn't provided to the function. :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99156]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r99156. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99156 Commit summary: MFT r99154 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99162]: New comment added, and revision status changed
User Khorn (WMF) changed the status of MediaWiki.r99162. Old Status: new New Status: ok User Khorn (WMF) also posted a comment on MediaWiki.r99162. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99162#c23907 Commit summary: Removing no longer needed jquery files now that we're using 1.17; Adding separate resources file for defining rapidhtml resrouces for resource loader; removed inline jquery from Form.php and TwoStepTwoColumn.php; moved placeholder js as well as globalcollect_test js into their own files Comment: I have but one comment: We'll need to do an additional round of search-and-destroy to make sure all the new globals are handled properly when we merge the fundraiser dev branch back in with this bad boy, or RapidHTML won't be universally available to all the gateways. Clearly that won't stop anything from working in trunk, though. :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99159]: New comment added
User Leinad posted a comment on MediaWiki.r99159. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99159#c23909 Commit summary: Removed cancel link. Needs work to be non-confusing and isn't needed due to de-advertise link. Comment: Hmmm - is it intentional that this revision is not copied to trunk? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99182]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r99182. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99182 Commit summary: Remove confusing Cancel button from the diff page altogether. i18n: Remove no longer necesssary 'revreview-cancel' message. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99179]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r99179. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99179 Commit summary: Followup to r99177: Restore previous ID of the comment box node ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Help us develop the Wikipedia Android app
Awesome! Haven't had a reason to fire up my Android environment recently. I'll give it a shot. -Chad On Oct 6, 2011 9:26 PM, Tomasz Finc tf...@wikimedia.org wrote: One good question that Brion just asked me was when we plan to release this app to the Android market. We'd like to get the baseline app in the android market two weeks from now. To track what we need to fix check out our tracker bug https://bugzilla.wikimedia.org/show_bug.cgi?id=31447 We need your help to make it happen. --tomasz On Thu, Oct 6, 2011 at 6:19 PM, Tomasz Finc tf...@wikimedia.org wrote: Greetings All, Over the last couple of weeks a group of devs from Nitobi have been putting together an Android Wikipedia App for us. They've been using the PhoneGap framework to build the app and now it mostly has the same features as our iOS app. I think it's finally gotten to a good state for people to start hacking on it. For those just wanting to get started here are the links code: https://github.com/nitobi/Wikipedia bugs: http://bit.ly/q1B9Bj feature ideas: http://meta.wikimedia.org/wiki/Mobile_Projects/App_Features__Roadmap#Features_committed Right now the code is sitting in github but the plan is to move it into our own git repo, alongside MediaWiki. How can you help? * Fork the code and help us with open bug requests * Critique the code and suggest cleanup * Port the app to iOS, Symbian, BlackBerry, Windows, WebOS, Bada — first get it running, then customize to each platform's look and feel * Start to hack on new features like image uploads, starting a new article, offline article saving, openZIM support, etc ... * Localization for the user interface * ... and whatever else you can come up with Don't worry if you don't know Objective C, Java, etc .. All you need to know is HTML5, CSS3, and JS. It's really simple to write these apps. Lots of pretty screen shots and a user flow diagram here : http://meta.wikimedia.org/wiki/Mobile_Projects/WikipediaAndroidApp Come join us on #wikimedia-mobile and let us know how it goes. --tomasz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Google's cached pages are much faster than wiki*edia's
Isn't that the same thing Facebook just caught Congressional shit for? Not even close. We don't track you from site to site, you just happen to have a cookie that didn't get deleted that also happens to cause you to bypass cache. We should likely find out why these aren't getting deleted. - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r99187]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r99187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99187#c23911 Commit summary: * Added script to manually clear out old data (per $wgCUDMaxAge) * Cleaned up DELETE statement to use database wrapper more Comment: More to come on this. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99172]: Revision status changed
User Tim Starling changed the status of MediaWiki.r99172. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99172 Commit summary: Redact IP address when unblocking autoblocks ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Google's cached pages are much faster than wiki*edia's
On Thu, Oct 6, 2011 at 10:53 PM, Ryan Lane rlan...@gmail.com wrote: Isn't that the same thing Facebook just caught Congressional shit for? Not even close. We don't track you from site to site, you just happen to have a cookie that didn't get deleted that also happens to cause you to bypass cache. We should likely find out why these aren't getting deleted. Well we do serve the logged out cookie. What real purpose that serves, I don't know :) It certainly isn't for tracking users, that's for sure. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r99189]: New comment added
User Kaldari posted a comment on MediaWiki.r99189. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99189#c23912 Commit summary: quick and dirty resourceloaderification - should move all js functions out of global scope at some point Comment: BTW, I fixed the two super long lines in r99191. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Google's cached pages are much faster than wiki*edia's
Le 7 oct. 2011 à 06:21, Chad a écrit : On Thu, Oct 6, 2011 at 10:53 PM, Ryan Lane rlan...@gmail.com wrote: Isn't that the same thing Facebook just caught Congressional shit for? Not even close. We don't track you from site to site, you just happen to have a cookie that didn't get deleted that also happens to cause you to bypass cache. We should likely find out why these aren't getting deleted. Well we do serve the logged out cookie. What real purpose that serves, I don't know :) It's to bypass the browser cache, and to not let the user see a page with it's user name at the top when he just logged out. Alexandre Emsenhuber ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r99187]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r99187. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99187#c23913 Commit summary: * Added script to manually clear out old data (per $wgCUDMaxAge) * Cleaned up DELETE statement to use database wrapper more Comment: r99193. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Preliminary git module splitup notes (MediaWiki core extensions)
Max Semenik wrote: On 06.10.2011, 2:12 Conrad Irwin wrote: What's the use-case for checking out all of the extensions? Presumably that would only be needed if you wanted to do some global clean-up, so this won't affect the majority of people too extremely. Actually, it's pretty common, most if not all active core devs do that because every change to core APIs must be accompanied with a grep through extensions to check if it's OK or something will need to be fixed. s/grep/ack-grep/ ;-) MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r83757]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r83757. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83757 Commit summary: Follow-up r83755: Message 'ipaddress' is unused now, in core and extensions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
