[MediaWiki-CodeReview] [MediaWiki r106502]: New comment added
Santhosh.thottingal posted a comment on MediaWiki.r106502. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106502#c27935 Commit summary for MediaWiki.r106502: Remove Meera and Raghu Malayalam fonts from the options for Malayalam. To be reenabled when upstream release new versions with latest unicode support. Ref Bug 29005 Santhosh.thottingal's comment: The fonts were not deleted to enable testing Malayalam in various fonts using font-family:Fontname style in spans or divs. We just removed the font options from menu as we did for disabling other fonts. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106527]: Revision status changed
SVG changed the status of MediaWiki.r106527 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106527 Old status: new New status: resolved Commit summary for MediaWiki.r106527: * Removed usage of $wgTitle where possible * Use Title::getDBkey() instead of Title::getText() and replacing spaces with underscores * Use DatabaseBase::selectRow() instead of select() with a single call to fetchObject() * Fixed return value of hooks * Fixed fnProtectHelpCommons() to correctly handle $wgHelpCommonsProtect and $wgHelpCommonsProtectAll ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106535]: Revision status changed
SVG changed the status of MediaWiki.r106535 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106535 Old status: new New status: ok Commit summary for MediaWiki.r106535: follow-up r106534 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106412]: Revision status changed
SVG changed the status of MediaWiki.r106412 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106412 Old status: new New status: ok Commit summary for MediaWiki.r106412: Add right- i18n. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106383]: Revision status changed
SVG changed the status of MediaWiki.r106383 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106383 Old status: new New status: ok Commit summary for MediaWiki.r106383: Commit my old NoBogusUserpages extension as-is. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] New committer
2011/12/16 Sumana Harihareswara suma...@wikimedia.org Toni Hermoso Pulido (toniher) now has commit access and aims to work on extensions FollowButton, PopUpFile, CheckGroup, ImageRefer. És una polla en vinagre!! In case anybody didn't know, Toni is one of the most diligent and dedicated software localizer on the planet. -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r106533]: Revision status changed
Catrope changed the status of MediaWiki.r106533 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106533 Old status: new New status: ok Commit summary for MediaWiki.r106533: Kill some useless code in r106514 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106514]: New comment added, and revision status changed
Catrope changed the status of MediaWiki.r106514 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106514#c27936 Old Status: new New Status: fixme Commit summary for MediaWiki.r106514: Expose rev_sha1/ar_sha1 to API (bug 21860) Catrope's comment: pre + $rev['sha1'] = $row-ar_sha1; /pre This outputs the SHA1 hash in base 36, matching your parameter documentation. However, imageinfo outputs it in hex: pre $vals['sha1'] = wfBaseConvert( $file-getSha1(), 36, 16, 40 ); /pre For consistency, we should use hex everywhere. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106559]: New comment added
SPQRobin posted a comment on MediaWiki.r106559.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106559#c27937
Commit summary for MediaWiki.r106559:
Make the output consistent when no second parameter is given and second
parameter equals first parameter. This gives preference to names defined in
MediaWiki, but when it is not in MediaWiki, it also sees whether there is one
defined in the translated language names.
SPQRobin's comment:
Examples:
* nowiki{{#language:nl-be}}/nowiki gave nl-be,
nowiki{{#language:nl-be|nl-be}}/nowiki gave Vlaams with CLDR enabled
* When nl-be was added in MediaWiki through wgExtraLanguageNames,
nowiki{{#language:nl-be}}/nowiki was that value, but
nowiki{{#language:nl-be|nl-be}}/nowiki was still the CLDR value
With this change, both are the MediaWiki value (including
wgExtraLanguageNames), and fall back to the CLDR when not in MediaWiki
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Visual editor collaboration
On 18 December 2011 02:45, Maciej Jaros e...@wp.pl wrote:
Mihály Héder (2011-12-17 14:46):
Hello,
Congratulations on LocalWiki, that is really great!
In HTML5 editor category you should check out Aloha Editor as well:
http://aloha-editor.org
My favorite demos:
http://aloha-editor.org/demos/css3/ (*everyone* should check out this
one!
Of course its useless but fun :)
http://aloha-editor.org/demos/wordpress-demo/
http://aloha-editor.org/demos/960-fluid-demo/
I've just started to study their plugin system, which looks promising. My
painful experience with TinyMCE and other RTE-s and also with the old
wiki
editor is that if you cannot make your custom stuff fit in a standard
plugin (which is too often the case), it will be very hard to upgrade
later. So IMO if you go for future-proofness you should check the
customization options.
Not a good editor for wide colaboration:
if(...||jQuery.browser.opera){alert(Sorry, your browser is not
supported at the moment.);return}
True, they had problems with contentEditable support in Opera 10 with the
current stable aloha 0.9.3.
But with Opera 11 and the latest aloha RC it seems to work now, thanks to
their collaboration with Opera. At least the editor field at the main page
http://aloha-editor.org/ works without issues in my Opera 11 but the other
demos don't. Some info: http://news.ycombinator.com/item?id=2836981
Cheers,
Mihály
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r106519]: Revision status changed
SVG changed the status of MediaWiki.r106519 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106519 Old status: new New status: ok Commit summary for MediaWiki.r106519: followup r106235 - Add message documentation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105792]: Revision status changed
SVG changed the status of MediaWiki.r105792 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105792 Old status: new New status: deferred Commit summary for MediaWiki.r105792: Adding ReassignEdits extension ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Image uploading social workflow
The improvements to the Upload Wizard are very welcome, but socially, I think it is still broken. Please correct me if I overlook something or overlook another extension. Socially, I believe many mediawiki extensions need a way to ask for images on a topic page, provide an upload wizard AND display the results on the topic page. Presently, even if the image is added to the wiki or a commons repository, it simply disappears in a black hole from the perspective of the contributing image author. I believe it is possible to have a wizard option which does the following: * store the page context from which it was called. * upload images to local wiki or a repository * open the page context in edit mode * search for some form of new-images-section ** a possible implementation of this could be a div with id=newimages containing a gallery tag * if new-images-section exists: add images, if not create with new images. * Save context page. Presently, WMF is possibly the biggest driver of open content (CC BY/CC BY-SA) but is able to collect images only from the small population that is the intersection of the population or people able to edit mediawiki and the huge population able to provide quality images. The new-images-section solution would probably not directly work for wikipedia itself; here some more complex review mechanism (new images gallery would be shown only to some users, including image uploader, or so) would be needed, perhaps in combination with flagged rev. I view this feature however potentially as a two step process: implement with direct addition to page, modify to optimize for flagged revs. However, I think something the described feature would be needed; presently all these crowdsourcing images are mostly collected by projects that either use no open content license at all, or the NC license at best. WMF is not able to exert its potential pull towards open content in this area. Also reported as https://bugzilla.wikimedia.org/show_bug.cgi?id=33234 Gregor ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r106560]: Revision status changed
SVG changed the status of MediaWiki.r106560 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106560 Old status: new New status: ok Commit summary for MediaWiki.r106560: Clarify documentation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97829]: New comment added, and revision status changed
SPQRobin changed the status of MediaWiki.r97829 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97829#c27938 Old Status: fixme New Status: resolved Commit summary for MediaWiki.r97829: * + XHTML necessities accidentally lost in r97778 SPQRobin's comment: MediaWiki uses by default HTML5. It's the other way around: no need to stick with old stuff. - r106562 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106545]: Revision status changed
IAlex changed the status of MediaWiki.r106545 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106545 Old status: new New status: reverted Commit summary for MediaWiki.r106545: followup r88898 -- move BeforeInitialize hook to where it can be called in a way that matches the documented parameters As it was, when an extension tried to use BeforeInitialize with the documented parameters this resulted in an exception: Detected bug in an extension! Hook HookFunctionName has invalid call signature; Parameter 2 to HookFunctionName() expected to be a reference, value given ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97829]: New comment added
Danny B. posted a comment on MediaWiki.r97829. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97829#c27939 Commit summary for MediaWiki.r97829: * + XHTML necessities accidentally lost in r97778 Danny B.'s comment: However, this is not MediaWiki, but just server stuff. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Missing wiki redirect script
Hi, Danny B. and I adapted the script used for non-existing wikis (trunk/tools/web-scripts/missing.php) so it redirects to the respective test wiki at Wikimedia Incubator. This would be a huge usability improvement (however, only for languages configured in Wikimedia). For Wikiversity Wikisource, the wiki does not exist message remains, because BetaWV and OldWikisource don't have a logical page naming system to redirect to. So I would like to ask if someone can review deploy this (Commits are here: https://www.mediawiki.org/wiki/Special:Code/MediaWiki?path=/trunk/tools/web-scripts/missing.phpbut it may be easier to just review current trunk version). That would be great :) The relevant bug report is https://bugzilla.wikimedia.org/show_bug.cgi?id=30206 (the initial idea was to do it via DNS/Apache config) Thank you, SPQRobin ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] VisualEditor link-activating/following
Kaseluris-Nikos-1959 (2011-12-18 05:19): The processes|actions on links we deal-with are: 1) in a browser: a) link activating. 2) in a source-editor: a) link-text editing, b) link-target editing. 3) in a wysiwyg-editor: a) link-text editing, b) link-target editing c) link activating|following. In VisualEditor (wysiwyg) link-activation is not yet implemented. So far I have seen 3 methods for this: i) double clicking ii) ctrl + clicking iii) popup the target, where you can activate the link. I am using everyday a local hypertext wysiwyg editor for 20 years now (yes before html!!!) which uses the double-click method. I vote for this as the fastest and using only one hand. I would like to here the VisualEditor's team opinions. I think you should add this to bugzilla, but I would vote for CTRL+click. I feel this is the most common way now (Open/MS office apps and CK editor use this). In any case hoverning a link should display information on how you can go to the link. Regards, Nux. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r106546]: New comment added, and revision status changed
IAlex changed the status of MediaWiki.r106546 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106546#c27940 Old Status: new New Status: fixme Commit summary for MediaWiki.r106546: Bug 30047 - Language selection does not change the Content-language Patch from Author: Harald Stowasser IAlex's comment: I don't see what this has to do in the LanguageSelector extension, since this extension is meant to allow anonymous users to select their interface language (or even have it directly set from the Accept-Language header), but not to alter the Title object, this is more for [[Extension:Polyglot]] or similar. Some other notes: * code$wgLanguageSelectorRequestedLanguage/code doesn't exist anymore * code$wgLanguageSelectorAdjustContent/code is not defined when including the file (in other words this is a register_globals vulnerability) and it would be better to be a boolean * Altering those members variables of the Title object is really not a good since other member variable may depend on the page title (restrictions, etc.); it would much better to create a new Title object; also altering it in the BeforeInitialize hook is too late, if file cache is enabled, it will be loaded based on the older title from codeMediaWiki::main()/code. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106514]: New comment added, and revision status changed
Aaron Schulz changed the status of MediaWiki.r106514 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106514#c27941 Old Status: fixme New Status: new Commit summary for MediaWiki.r106514: Expose rev_sha1/ar_sha1 to API (bug 21860) Aaron Schulz's comment: Ahh, so this how things like len vs size happen :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106570]: New comment added
Johnduhart posted a comment on MediaWiki.r106570. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106570#c27942 Commit summary for MediaWiki.r106570: FU r106514: use base 16 SHA-1 to be consistent with image info Johnduhart's comment: This should get a RELEASE-NOTES entry imo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106570]: New comment added
Aaron Schulz posted a comment on MediaWiki.r106570. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106570#c27943 Commit summary for MediaWiki.r106570: FU r106514: use base 16 SHA-1 to be consistent with image info Aaron Schulz's comment: That a new SHA-1 field was added to the output? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106570]: New comment added
Johnduhart posted a comment on MediaWiki.r106570. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106570#c27944 Commit summary for MediaWiki.r106570: FU r106514: use base 16 SHA-1 to be consistent with image info Johnduhart's comment: Oops, forgot sha1 for revisions is a 1.19 feature. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Image uploading social workflow
There was the Add Media Wizard project from a while back ( that sounds similar to what you describe ) http://www.mediawiki.org/wiki/Extension:Add_Media_Wizard I wanted to take a look at integrating upload wizard into it post TMH deployment, and or something new could be built as a gadget as well. --michael On 12/18/2011 07:22 AM, Gregor Hagedorn wrote: The improvements to the Upload Wizard are very welcome, but socially, I think it is still broken. Please correct me if I overlook something or overlook another extension. Socially, I believe many mediawiki extensions need a way to ask for images on a topic page, provide an upload wizard AND display the results on the topic page. Presently, even if the image is added to the wiki or a commons repository, it simply disappears in a black hole from the perspective of the contributing image author. I believe it is possible to have a wizard option which does the following: * store the page context from which it was called. * upload images to local wiki or a repository * open the page context in edit mode * search for some form of new-images-section ** a possible implementation of this could be a div with id=newimages containing a gallery tag * if new-images-section exists: add images, if not create with new images. * Save context page. Presently, WMF is possibly the biggest driver of open content (CC BY/CC BY-SA) but is able to collect images only from the small population that is the intersection of the population or people able to edit mediawiki and the huge population able to provide quality images. The new-images-section solution would probably not directly work for wikipedia itself; here some more complex review mechanism (new images gallery would be shown only to some users, including image uploader, or so) would be needed, perhaps in combination with flagged rev. I view this feature however potentially as a two step process: implement with direct addition to page, modify to optimize for flagged revs. However, I think something the described feature would be needed; presently all these crowdsourcing images are mostly collected by projects that either use no open content license at all, or the NC license at best. WMF is not able to exert its potential pull towards open content in this area. Also reported as https://bugzilla.wikimedia.org/show_bug.cgi?id=33234 Gregor ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r106571]: Revision status changed
SVG changed the status of MediaWiki.r106571 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106571 Old status: new New status: ok Commit summary for MediaWiki.r106571: r106430: Make message optional for translation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106569]: Revision status changed
SVG changed the status of MediaWiki.r106569 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106569 Old status: new New status: ok Commit summary for MediaWiki.r106569: Remove ltr class (see r89466), it should not be used at all, because 1) the name is too general, 2) it is automatically added to the body element (colliding class names) and 3) it is better to use HTML dir=ltr as in r105929. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106574]: Revision status changed
SVG changed the status of MediaWiki.r106574 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106574 Old status: new New status: ok Commit summary for MediaWiki.r106574: r106556: Register new alias file ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106458]: New comment added
Elitre posted a comment on MediaWiki.r106458. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106458#c27945 Commit summary for MediaWiki.r106458: Added blog per request on meta Elitre's comment: Please fix it, my Tumblr belongs to the Italian version, not the English one! Thanks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106458]: Revision status changed
Johnduhart changed the status of MediaWiki.r106458 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106458 Old status: ok New status: fixme Commit summary for MediaWiki.r106458: Added blog per request on meta ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106458]: New comment added, and revision status changed
IAlex changed the status of MediaWiki.r106458 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106458#c27946 Old Status: fixme New Status: new Commit summary for MediaWiki.r106458: Added blog per request on meta IAlex's comment: Fixed in r106586. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106458]: Revision status changed
Johnduhart changed the status of MediaWiki.r106458 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106458 Old status: new New status: ok Commit summary for MediaWiki.r106458: Added blog per request on meta ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106586]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r106586 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106586 Old status: new New status: ok Commit summary for MediaWiki.r106586: Fix for r106458: move to the correct planet ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106440]: New comment added
Raymond posted a comment on MediaWiki.r106440.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106440#c27947
Commit summary for MediaWiki.r106440:
Add extensions/TranslateSvg
Raymond's comment:
{{messagedocumentation}}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106534]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r106534 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106534#c27948 Old Status: new New Status: ok Commit summary for MediaWiki.r106534: Use the directionality defined in MediaWiki, instead of a message. This avoids duplication or inconsistency, plus it was used literally which gave dir=any message text in HTML. The only reason why a message might be useful is for languages not defined in MediaWiki, but that didn't work (and the text would not be translated anyway). Nikerabbit's comment: You should be able to use Language::factory instead of wfGetLangObj here. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106547]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106547 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106547 Old status: new New status: deferred Commit summary for MediaWiki.r106547: Remove strict warnings ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106548]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106548 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106548 Old status: new New status: ok Commit summary for MediaWiki.r106548: w/s ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106440]: New comment added
Jarry1250 posted a comment on MediaWiki.r106440. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106440#c27949 Commit summary for MediaWiki.r106440: Add extensions/TranslateSvg Jarry1250's comment: Yeah. I was waiting for TranslateWiki.net to pick it up before doing that (because I like the interface), but should I not do so? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106549]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106549 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106549 Old status: new New status: ok Commit summary for MediaWiki.r106549: fix js error ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106550]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106550 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106550 Old status: new New status: ok Commit summary for MediaWiki.r106550: w/s changes and update INSTALL doc to reflect the fact that an API key is no longer needed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106440]: New comment added
Johnduhart posted a comment on MediaWiki.r106440. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106440#c27950 Commit summary for MediaWiki.r106440: Add extensions/TranslateSvg Johnduhart's comment: It's needed before going to TranslateWiki. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106551]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106551 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106551 Old status: new New status: ok Commit summary for MediaWiki.r106551: follow-up to r106491 and r106496 - fixing for 1.19, moving embargo filter out of CLDR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106552]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106552 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106552 Old status: new New status: ok Commit summary for MediaWiki.r106552: updating for new cldr code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106440]: New comment added
Jarry1250 posted a comment on MediaWiki.r106440. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106440#c27951 Commit summary for MediaWiki.r106440: Add extensions/TranslateSvg Jarry1250's comment: Ah, I see, thanks. Will commit over the next couple of hours. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106553]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106553 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106553 Old status: new New status: ok Commit summary for MediaWiki.r106553: w/s ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106426]: New comment added
Raymond posted a comment on MediaWiki.r106426.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106426#c27952
Commit summary for MediaWiki.r106426:
Initial release of the SolrStore Extension
Raymond's comment:
{{messagedocumentation}}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Image uploading social workflow
Socially, the Add Media Wizard is right direction, but it handles the workflow of inserting already available resources, it does not involve the scope of people able to contribute images. What I describe is like combining this directly with the upload, i.e. add the newly contributed media directly to a page in a preliminary fashion. From a user view, uploading an image suddenly breaks context, and it takes a lot of mediawiki mastery to put the uploaded image into context. Doing half of this work lets the media contributing user have success, and distributes work better according to abilities (all collaborators knowing mediawiki markup or project rules can review contributed images and put them into place or even remove again). Providing an extension that seamlessly integrates with upload wizard would be a huge achievement! Gregor ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r106534]: New comment added
SPQRobin posted a comment on MediaWiki.r106534. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106534#c27953 Commit summary for MediaWiki.r106534: Use the directionality defined in MediaWiki, instead of a message. This avoids duplication or inconsistency, plus it was used literally which gave dir=any message text in HTML. The only reason why a message might be useful is for languages not defined in MediaWiki, but that didn't work (and the text would not be translated anyway). SPQRobin's comment: True. Done in r106591 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104338]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r104338 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104338#c27954 Old Status: deferred New Status: fixme Commit summary for MediaWiki.r104338: Adding SharedHelpNamespace extension Nikerabbit's comment: pre +$sharedHelpRedirectTalk = Title::newFromText( $url . '/index.php?title=' . str_replace( ' ', '_', $wgOut-getTitle() ) ); /pre You are not supposed to pass a url to Title::newFromText(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106556]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r106556 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106556#c27955 Old Status: new New Status: fixme Commit summary for MediaWiki.r106556: Replacing by in a few of most used extensions and renaming Specialphp to ..._body.php Nikerabbit's comment: I oppose to the FooExtension_body.php naming convention. It is better if the filename matches the class name. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106404]: New comment added
Nikerabbit posted a comment on MediaWiki.r106404. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106404#c27956 Commit summary for MediaWiki.r106404: unfinished code, will follow up soonish, from other device Nikerabbit's comment: $this-setListed( true ) in the constructor? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106557]: New comment added
Nikerabbit posted a comment on MediaWiki.r106557.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106557#c27957
Commit summary for MediaWiki.r106557:
Follow-up r106412
Nikerabbit's comment:
pre
+ 'badaccess-bogususerpage' = 'Error message:
{{msg-mw|badaccess-bogususerpage}}',
/pre
Why are you including he message contents in the description?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106558]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106558 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106558 Old status: deferred New status: ok Commit summary for MediaWiki.r106558: fix formatting issue ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106573]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r106573 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106573#c27958 Old Status: new New Status: fixme Commit summary for MediaWiki.r106573: Follow-up r106559: it's better to set the preference for own MediaWiki names in Language::getTranslatedLanguageNames. More consistent and saves some code :) Also update Babel to use that function. Nikerabbit's comment: There is a problem with preferring MediaWiki names. For example in Finnish you get a value which do not fit into the pattern: englanti, ranska, '''S'''uomi, ruotsi, viro. Imho it should only be used as fallback if CLDR does not have it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106560]: New comment added
Nikerabbit posted a comment on MediaWiki.r106560. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106560#c27959 Commit summary for MediaWiki.r106560: Clarify documentation Nikerabbit's comment: pre +* Only if defined in MediaWiki, no other data like CLDR. /pre What happens only if that? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106563]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106563 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106563 Old status: new New status: ok Commit summary for MediaWiki.r106563: Revert r106545 and pass a null variable by ref (also updated the documentation) so that the hook is called at the correct moment and after everything is executed. This is *exactly* the same behaviour as before r88898 since $article was an out parameter to fill $wgArticle correctly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106566]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106566 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106566 Old status: deferred New status: ok Commit summary for MediaWiki.r106566: fix escaping issue and some code cleanup ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106572]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106572 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106572
Old status: new
New status: ok
Commit summary for MediaWiki.r106572:
formatting { }
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106575]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106575 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106575 Old status: new New status: ok Commit summary for MediaWiki.r106575: added toniher ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106576]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106576 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106576 Old status: deferred New status: ok Commit summary for MediaWiki.r106576: 1.7 rc1 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106577]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106577 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106577 Old status: deferred New status: ok Commit summary for MediaWiki.r106577: kill dead code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106580]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r106580 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106580#c27961 Old Status: new New Status: ok Commit summary for MediaWiki.r106580: Make the messages labels for the input Nikerabbit's comment: There is also Xml::inputLabelSep() that could reduce code here. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106581]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106581 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106581 Old status: new New status: ok Commit summary for MediaWiki.r106581: * Only get the LinkCache instance when really necessary * Do not assign a variable inside a condition check ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106582]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r106582 to ok and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106582#c27962
Old Status: new
New Status: ok
Commit summary for MediaWiki.r106582:
* Use local context to get messages
* Use Language::userTimeAndDate(), Language::userTime() and
Language::userDate() instead of Language::timeAndDate(), Language::time(),
Language::date() to not depend on $wgUser
* Replaced empty() check by check against explicit values
Nikerabbit's comment:
How about:
pre
-if ( $code === null || $code === '' ) {
+if ( strval( $code ) === '' ) {
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106588]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106588 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106588 Old status: new New status: ok Commit summary for MediaWiki.r106588: r106459: Consistency tweaks in preparation for adding extension to translatewiki.net: ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106589]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106589 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106589 Old status: new New status: ok Commit summary for MediaWiki.r106589: r106459: Adding extension to translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106404]: New comment added
Jeroen De Dauw posted a comment on MediaWiki.r106404. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106404#c27963 Commit summary for MediaWiki.r106404: unfinished code, will follow up soonish, from other device Jeroen De Dauw's comment: I actually dislike that quite a bit. Passing such arguments to the constructor seems a lot nicer. PHP just fails for not being able to have named args such as Python or a sane dictionary syntax such as JS. Then again, if you got a decent editor, it ought to just show what the stuff means by looking at the function definition and it's corresponding comments. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106590]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106590 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106590 Old status: deferred New status: ok Commit summary for MediaWiki.r106590: Tag for version 1.7rc1. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106591]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106591 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106591 Old status: new New status: ok Commit summary for MediaWiki.r106591: r106534: use Language::factory() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106404]: New comment added
Nikerabbit posted a comment on MediaWiki.r106404. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106404#c27964 Commit summary for MediaWiki.r106404: unfinished code, will follow up soonish, from other device Nikerabbit's comment: If you dislike that, how about doing: pre parent::__construct( 'EditInstitution', 'epadmin', /*listed*/false ); /pre or pre $listed = false; parent::__construct( 'EditInstitution', 'epadmin', $listed ); /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106593]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106593 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106593 Old status: new New status: ok Commit summary for MediaWiki.r106593: r106260: Consistency tweaks in preparation for adding extension to translatewiki.net: Prefix message key with the extension name to avoid key conflicts with core and/or other extensions FU r106592: Prefix this one too ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106592]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106592 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106592 Old status: new New status: resolved Commit summary for MediaWiki.r106592: r106260: Consistency tweaks in preparation for adding extension to translatewiki.net: Prefix message key with the extension name to avoid key conflicts with core and/or other extensions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106594]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106594 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106594 Old status: new New status: ok Commit summary for MediaWiki.r106594: r106260: Adding extension to translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106522]: Revision status changed
Krinkle changed the status of MediaWiki.r106522 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106522 Old status: new New status: ok Commit summary for MediaWiki.r106522: [RL2] Clarify message docs added in r103276 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106404]: New comment added
Jeroen De Dauw posted a comment on MediaWiki.r106404. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106404#c27965 Commit summary for MediaWiki.r106404: unfinished code, will follow up soonish, from other device Jeroen De Dauw's comment: /*str*/ $arg is used for type hinting, so doing it with a constant and using it as meaning indicator would probably be confusing. Using separate vars just makes the code messy. There is no need to do this. And this argument does not only apply to constructors, it applies to all functions where it's not obvious what some argument might be, which are pretty much all those that are not setFoo and have only a single argument. Seriously, such documentation should go with the definition of the function and be inferred from that by your editor. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106404]: New comment added
Nikerabbit posted a comment on MediaWiki.r106404. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106404#c27966 Commit summary for MediaWiki.r106404: unfinished code, will follow up soonish, from other device Nikerabbit's comment: Very few of us are using more than text editor with syntax highlighting to program. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106404]: New comment added
Jeroen De Dauw posted a comment on MediaWiki.r106404. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106404#c27967 Commit summary for MediaWiki.r106404: unfinished code, will follow up soonish, from other device Jeroen De Dauw's comment: Sure. wfMessage( /* message key */ 'bunny', /* argument $1 */ $toy, /* argument $2 */ $car ) Html::element( /* tag type */ 'div', /* attributes */ array(), /* tag content */ 'meh' ) If everyone does that through all core code and extensions, I'll happily do it as well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104684]: New comment added, and revision status changed
Raymond changed the status of MediaWiki.r104684 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104684#c27968 Old Status: resolved New Status: fixme Commit summary for MediaWiki.r104684: )bug 15521) Use new section summary when the action of adding a new section also happens to create the page. Patch by Harry Burt Raymond's comment: PHP Notice: Undefined index: sectionanchor in /www/w/includes/EditPage.php on line 1118 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104398]: New comment added, and revision status changed
Johnduhart changed the status of MediaWiki.r104398 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104398#c27969 Old Status: deferred New Status: new Commit summary for MediaWiki.r104398: Refactored AddThis to use a single function for generating links Johnduhart's comment: ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104398]: Revision status changed
Johnduhart changed the status of MediaWiki.r104398 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104398 Old status: new New status: deferred Commit summary for MediaWiki.r104398: Refactored AddThis to use a single function for generating links ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100797]: New comment added
Werdna posted a comment on MediaWiki.r100797. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100797#c27970 Commit summary for MediaWiki.r100797: Commit ReferenceTooltips extension. It gives the content of a reference as a tooltip Werdna's comment: What's the FIXME for this? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106601]: Revision status changed
^demon changed the status of MediaWiki.r106601 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106601 Old status: new New status: ok Commit summary for MediaWiki.r106601: doc++ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106598]: Revision status changed
^demon changed the status of MediaWiki.r106598 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106598 Old status: new New status: deferred Commit summary for MediaWiki.r106598: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106597]: New comment added, and revision status changed
Johnduhart changed the status of MediaWiki.r106597 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106597#c27971 Old Status: new New Status: fixme Commit summary for MediaWiki.r106597: added UserFunction Johnduhart's comment: Please setup [[Subversion/auto-props|auto-props]] and [[Subversion/auto-props#Fixing_a_broken_file|fix the eol-style]] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] LocalWiki released
{%%} syntax looks really wiki-like. That's a kind of reverse logic,
comparing to MediaWiki, where parser functions are converted to HTML
output, not opposite. What's really important, parser functions can be
nested (and by using proper parser frame parser tags probably can be
nested as well - I haven't tried that yet but might try soon). Can
LocalWiki template tags be nested as well?
The template tags can be nested, yeah. Chaining in templates is
usually achived using template filters, though, a'la
https://docs.djangoproject.com/en/dev/ref/templates/builtins/?from=olddocs#safeseq.
Our goal with the template representation stuff was to leverage as
much of the existing Django ecosystem as possible. For instance, we
were able to use a common thumbnailing template tag library without
modification. But in general, if you want dynamic bits in pieces
inside of a serializable/cachable mostly-HTML document, a Django
template kinda makes sense.
We'll likely kill off the explicit {% .. %} syntax and build the
template tree manually in order to simplify the process of writing
page plugins.
--Philip
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] New committer
El 18/12/11 12:02, Amir E. Aharoni escribió: 2011/12/16 Sumana Harihareswara suma...@wikimedia.org Toni Hermoso Pulido (toniher) now has commit access and aims to work on extensions FollowButton, PopUpFile, CheckGroup, ImageRefer. És una polla en vinagre!! Lol Amir, I had to look up that expression! [1] Welcome Toni. This doubles the number of committers from Spain :) 1- http://www.elotrolado.net/hilo_que-significado-tiene-la-expresion-quot-pollas-en-vinagre-quot_1199843_s20 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Bugzilla Weekly Report
MediaWiki Bugzilla Report for December 12, 2011 - December 19, 2011 Status changes this week Bugs NEW : 515 Bugs ASSIGNED : 21 Bugs REOPENED : 72 Bugs RESOLVED : 188 Total bugs still open: 6821 Resolutions for the week: Bugs marked FIXED : 128 Bugs marked REMIND : 0 Bugs marked INVALID: 12 Bugs marked DUPLICATE : 31 Bugs marked WONTFIX: 8 Bugs marked WORKSFORME : 8 Bugs marked LATER : 4 Bugs marked MOVED : 0 Specific Product/Component Resolutions User Metrics New Bugs Per Component VisualEditor58 android 19 WebFonts12 Site requests 9 ArticleFeedbackv5 9 New Bugs Per Product MediaWiki 41 Wikimedia 12 MediaWiki extensions108 Wikimedia Mobile22 Security1 Top 5 Bug Resolvers brion [AT] wikimedia.org32 yoni [AT] omniti.com18 mah [AT] everybody.org 13 tfinc [AT] wikimedia.org10 sam [AT] reedyboy.net 8 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r106617]: New comment added
Bawolff posted a comment on MediaWiki.r106617. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106617#c27972 Commit summary for MediaWiki.r106617: Fix function name typo date_defaulttimezone_get() to date_default_timezone_get() from r105459 Bawolff's comment: that's embarrassing. It looks like that particular code path is never executed because $wgLocalTimezone gets set in Setup.php, which is probably why i missed it during testing r105459. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r101245]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r101245 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101245 Old status: new New status: ok Commit summary for MediaWiki.r101245: improve function documentation; move from %2F to - in container names; move to current version of php-cloudfiles. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106414]: Revision status changed
Tim Starling changed the status of MediaWiki.r106414 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106414 Old status: new New status: ok Commit summary for MediaWiki.r106414: MFT 105153-106411 (manual merge for FileRepo.php/FSRepo.php) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106455]: Revision status changed
Tim Starling changed the status of MediaWiki.r106455 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106455 Old status: new New status: ok Commit summary for MediaWiki.r106455: Removed deprecated append functions (FileRepo no longer has the functions for this) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106104]: New comment added
Tim Starling posted a comment on MediaWiki.r106104. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106104#c27973 Commit summary for MediaWiki.r106104: In DBLockManger: * Added 'dbServers' config option and made the manager skip LB and use the DB factory() function. This assures that the lock queries are in their own session and don't break (or get broken by) other transactions, especially wrt begin/commit/rollback. * Merged 'webTimeout' and 'cliTimeout' into one 'lockExpiry' setting. No need to encourage high values for CLI scripts, as they should be batched anyway. * Removed 'safeDelay' as a config option (determined by other settings now). * Only set $this-statusCache when it might be useful. * Tweaked lock table names (file_locks = filelocks), removed DEFAULT CHARSET (everthing is binary), and set CHECKSUM=0 since it's not useful. * More documentation cleanups and fixes to outdated comments. In MySqlLockManager: * Simplified SET SESSION code and reduced queries. * Made EX locks non-blocking (EX-EX was blocking before). Tim Starling's comment: It would be nice to have the option to be able to use the main DB configuration and not have to configure DBLockManager separately. SqlBagOStuff::getDB() creates DB connections for a very similar reason to this class, and it allows either separate or shared configuration. You could use similar code. If it didn't require any configuration, then we could think about using it by default. A lot of shared hosts use NFS fairly extensively, so a lot of small MediaWiki installations probably have non-functional file locking. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106595]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106595 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106595 Old status: new New status: ok Commit summary for MediaWiki.r106595: follow up to r106404, use wfMessage and Message class as Nikerabbit suggested ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106481]: Revision status changed
Bawolff changed the status of MediaWiki.r106481 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106481 Old status: new New status: ok Commit summary for MediaWiki.r106481: followup r106459, Use wfMkdirParents(), add a missing message. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106603]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106603 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106603 Old status: new New status: ok Commit summary for MediaWiki.r106603: restore compat w/ mw 1.18 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106603]: New comment added
Nikerabbit posted a comment on MediaWiki.r106603. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106603#c27974 Commit summary for MediaWiki.r106603: restore compat w/ mw 1.18 Nikerabbit's comment: I thought someone merged the getLanguage change into 1.18... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106604]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106604 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106604 Old status: new New status: ok Commit summary for MediaWiki.r106604: compat w/ mw 1.18 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106609]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106609 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106609 Old status: new New status: ok Commit summary for MediaWiki.r106609: Follow up r106579 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106610]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106610 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106610 Old status: deferred New status: ok Commit summary for MediaWiki.r106610: Replaced hardcoded colon in display with 'colon-separator' message ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106613]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106613 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106613 Old status: new New status: ok Commit summary for MediaWiki.r106613: Fix whitespace Fix code duplication Documentation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
