[Wikitech-l] tests for branches (was: Code review process)
[Forking thread Code review process] On 01/06/11 09:58, Max Semenik wrote: To make this reasonable, we would also need to run tests for branches on the central server, too - CruiseControl doesn't look flexible enough for this. Hello, I am planning to add the REL1_18 branch to the CruiseControl system as a new project The prerequisite being to make it works for trunk :-) REL1_17 does not have the test suite. I think it was broken beyond repair at the point we branched. -- Ashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] tests for branches (was: Code review process)
On 01.06.2011, 20:56 Ashar wrote: [Forking thread Code review process] On 01/06/11 09:58, Max Semenik wrote: To make this reasonable, we would also need to run tests for branches on the central server, too - CruiseControl doesn't look flexible enough for this. Hello, I am planning to add the REL1_18 branch to the CruiseControl system as a new project The prerequisite being to make it works for trunk :-) REL1_17 does not have the test suite. I think it was broken beyond repair at the point we branched. Would be great! Though even greater would be to ditch CruiseControl completely and find something that allows us to add/remove branches via web interface so that every private branch can be easily tested *before* being merged into trunk. -- Best regards, Max Semenik ([[User:MaxSem]]) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] tests for branches (was: Code review process)
On Wed, Jun 1, 2011 at 10:28 AM, Max Semenik maxsem.w...@gmail.com wrote: On 01.06.2011, 20:56 Ashar wrote: I am planning to add the REL1_18 branch to the CruiseControl system as a new project The prerequisite being to make it works for trunk :-) Would be great! Though even greater would be to ditch CruiseControl completely and find something that allows us to add/remove branches via web interface so that every private branch can be easily tested *before* being merged into trunk. That'll be especially handy in a future git world, which will be a lot friendlier to private and shared work branches. (SVN branches are hard to re-merge, which has led to us mainly using them for version branching -- which never have to merge back upstream -- and have used so few work branches.) -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] tests for branches (was: Code review process)
On 01/06/11 19:28, Max Semenik wrote: every private branch can be easily tested *before* being merged into trunk. You can test the private branch by running the test suite locally before and after merging. Private branch requiring continuous integration would probably big projects, and adding it manually is probably not that long :-) -- Ashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] tests for branches (was: Code review process)
On 01.06.2011, 21:34 Ashar wrote: On 01/06/11 19:28, Max Semenik wrote: every private branch can be easily tested *before* being merged into trunk. You can test the private branch by running the test suite locally before and after merging. Private branch requiring continuous integration would probably big projects, and adding it manually is probably not that long :-) Big may be any branch with more than one developer working on it. And even for single-developer branches it could make sense to try running tests on the same server they'll run on once integrated into trunk ;) -- Best regards, Max Semenik ([[User:MaxSem]]) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
