Re: [1/1] kernel32: Implemented basic NUMA functions to replace the stubs
Hi Chris. Welcome to Wine. Main changes from HEAD: 1) Implements GetNumaHighestNodeNumber which simulates a typical single node system. 2) Implements GetNumaNodeProcessorMask which returns the global processor affinity mask for node 0, otherwise returns an error. 3) Implements GetNumaAvailableMemoryNode which returns available physical memory for node 0, otherwise returns an error. The hacks from the codeweavers Wine tree are not in the main tree, because they are hacks. Wine has either a stub or proper implementation with tests. For your changes: - SetLastError(0) is wrong. lasterror is only valid on a failure. (Exceptions are very very rare) - Most implementations in kernel32.dll use functions provides by ntdll.dll With grep, you will find numa support in dlls/ntdll/nt.c - Make the patches as small as possible: Only one implementation per Patch. - Please add tests and run them on Windows. Ask here, if you need help. (Wine has a testbot for approved developer) Thanks for improving Wine. -- By by ... Detlef
Re: mscms: Use lcms2, when available [try 2]
Hans wrote on Monday, 3. June 2013 at 10:30 On Sun, 2013-06-02 at 22:49 +0200, Detlef Riekenberg wrote: try2: import the unchanged icc34.h from the lcms (v1) dev. package. (Do we need to add a Wine LGPL licence header for icc34.h?) The plan is to remove this include, when changing Wine to use the new getter/setter functions of lcms2 (After the release of Wine-1.6) My plan was to switch to lcms2 soon *after* the release of Wine 1.6. My plan was to find a way to increase the user experience and provide lcms2 support out of the box for the stable Wine release. Alexandre, do you see a chance for lcms2 support for Wine-1.6 (out of the box)? I studied the API some more and my conclusion is that while it doesn't have all we need (specifically cmsReadRawTag and cmsWriteRawTag don't do what we want), rc1 for lcms2 v2.5 was just released: http://www.littlecms.com/lcms2-2.5rc1.tar.gz What does Wine need from lcms / for cmsReadRawTag and cmsWriteRawTag? I added lcms-u...@lists.sourceforge.net for this mail. we can avoid importing the icc34.h header. Hans, you found a way to change Wine to use getter/setter functions while still linking to lcms v1 and than switch to lcms2? Great! Please confirm, that you think, that this is a working transition variant. (I must admit, that I didn't studied the lcms2 API deep enough). I'm not in favor of adding temporary workarounds. If distributions want to drop support for lcms1 in 1.6 I'd suggest that they backport the patches. Adding icc34.h is a variant for a transition to lcms2 without much effort, while knowing, that this work, but doesn't look beautiful. Fletching out our mscms header (similar to a stripped down icc34.h), to allow our current code to compile without icc34.h and link to lcms2 is another possible transition variant. Should we spend that time/effort, when we expect, that the added code is no longer needed after updating Wine to use the lcms2 getter/setter functions? -- By by ... Detlef
Re: [PATCH] slc: Fix return type
Christian wrote at Wednesday, 29. Mai 2013 at 23:12 Uhr
+ */
+HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD *pvalue)
+{
-SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName,
LPDWORD pdwValue);
+SLCAPI HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR, DWORD *);
I think s/PCWSTR/const WCHAR */ and s/pvalue/value/ would be better. :)
I disagree for const WCHAR *, which is really rare used in Wine
(Please grep the headers yourself)
pvalue is a matter of taste.
I will send an updated version
--
By by ... Detlef
Re: [PATCH] mscms: Use lcms2, when available
Hi Hans. For most apps it will be a matter of adding a configure check for lcms2 and then recompiling. This is not the case for Wine as you have pointed out. - cmsCreateLabProfile was renamed to cmsCreateLab2Profile cmsvirt.c (1.19: 570) / (2.4: 458 and 497) - cmsSetLogErrorHandler can be used as replacement for cmsSetErrorHandler At this point there's probably still a substantial number of users on distributions that don't include lcms2, and trying to support both doesn't make the source any prettier. The changes to support both versions are resonable small. Missing support for lcms2 in the next stable Wine release is bad. So it doesn't seem unreasonable to wait a little longer. gnome-settings-daemon / gnome-color-manager / openjdk and some other depend at least since Ubuntu 1110 on lcms2. (lcms2: 8 Packages, lcms1: 47 Packages) In current distributions, the package list include libreoffice, gtk3, libraw, libkdcraw, poppler, ImageMagik, inkscape, scribus, calligra, cups-filters ... more than 50 packages. (That's for Ubuntu 1304 and Suse 1203) I see no reason to wait any longer. -- By by ... Detlef
IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) test failure
Hi Alexandre.I have a test failure on my win7 Machine, while a valid cd was in the dvd drive.volume.c:785: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 1785Example result:http://test.winehq.org/data/209b58c64e6181c9bf448cb4f3130d3ba705c5d2/win7_dr-w7sp1-wow-p6100/kernel32:volume.html(The same failure is present, when running the 64bit test)Other machines are also affected.Example:http://test.winehq.org/data/4a685ebea343efdcb433f8d710b0c9f902e471fa/win7_matt/kernel32:volume.htmlYou wrote the tests, which where comitted on 12. July 2012:http://source.winehq.org/git/wine.git/commitdiff/a3b5dd2dff0d04fe317f00282ccb0488e4803015What media did you use, to test your code?Data-DVD, Video-DVD, Empty DVD, Data-CD, Video-CD, Audio-CD, Empty CD, No Disc in DriveWhat results did you get on Windows and Unix?On Linux, mounting the example CD works perfect, but your test fails:volume.c:785: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87Your test only read the DVD descriptor.To fix your test, I suggest, that you add a trace to dump the *_READ_STRUCTURE IoControl result and add similar tests for the other media formats.I also tested with a different Data-CD and got the same failure on linux (last error = 87).You can check the image yourself:http://www.memtest86.com/downloads/memtest86-4.1.0-iso.zip(Burned on a CD)That all winetest vm are missing optical media is a different issue:http://bugs.winehq.org/show_bug.cgi?id=31780-- By by ... Detlef
IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) test failure [text only]
Hi Alexandre. I have a test failure on my win7 Machine, while a valid cd was in the dvd drive. volume.c:785: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 1785 Example result: http://test.winehq.org/data/209b58c64e6181c9bf448cb4f3130d3ba705c5d2/win7_dr-w7sp1-wow-p6100/kernel32:volume.html (The same failure is present, when running the 64bit test) Other machines are also affected. Example: http://test.winehq.org/data/4a685ebea343efdcb433f8d710b0c9f902e471fa/win7_matt/kernel32:volume.html You wrote the tests, which was comitted on 12. July 2012: http://source.winehq.org/git/wine.git/commitdiff/a3b5dd2dff0d04fe317f00282ccb0488e4803015 What media did you use, to test your code? Data-DVD, Video-DVD, Empty DVD, Data-CD, Video-CD, Audio-CD, Empty CD, No Disc in Drive What results did you get on Windows and Unix? On Linux, mounting the example CD works perfect, but your test fails: volume.c:785: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87 Your test only read the DVD descriptor. To fix your test, I suggest, that you add a trace to dump the *_READ_STRUCTURE IoControl result and add similar tests for the other media formats. I also tested with a different Data-CD and got the same failure on linux (last error = 87). You can check the image yourself: http://www.memtest86.com/downloads/memtest86-4.1.0-iso.zip (Burned on a CD) Your broken test was not detected by winetest, but that is a different issue http://bugs.winehq.org/show_bug.cgi?id=31780 sorry for the prev. html mail -- By by ... Detlef
Aw: Re: [PATCH 1/2] shell32: Add a basic implementation for SHGetStockIconInfo
Dimitry wrote:
+/
+ * helper for SHGetStockIconInfo
+ */
+typedef struct stockiconentry_t {
+ SHSTOCKICONID id;
+ DWORD iconid;
+} stockiconentry;
Why bother with a typedef?
I prefer typedef to reduce a bit of typing.
Changed here, to make you happy and to feel the difference.
+static stockiconentry stockicontable[] = {
+ {SIID_DOCNOASSOC, IDI_SHELL_DOCUMENT},
Please don't forget to add 'const'.
Done. Thanks
+static int cmp_stockiconentry(const void *entry1, const void *entry2)
+{
+ stockiconentry *p1 = (stockiconentry *) entry1;
+ stockiconentry *p2 = (stockiconentry *) entry2;
+
+ return p1-id - p2-id;
+}
Don't cast away 'const'.
Fixed. Thanks
+HRESULT WINAPI SHGetStockIconInfo(SHSTOCKICONID id, UINT flags,
SHSTOCKICONINFO *sii)
...
+ GetModuleFileNameW(shell32_hInstance, sii-szPath, MAX_PATH);
GetModuleFileNameW can fail, so filling 'sii' may be a bit premature.
What is the failure case???
The module-handle, the target buffer pointer and the buffer size are valid.
A path longer as MAX_PATH for shell32.dll is not supported in windows.
--
By by ... Detlef
Patches for winspool.drv and other locations
Hi Tatyana
Welcome to Wine.
Wine has a test suite to make sure, that new code is correct.
Example, what you never tested:
-if(!pDeviceName) {
+if(!pDeviceName !*pDeviceName) {
Your code will crash, when pDeviceName is NULL.
I expect, you want to use a logical OR, but i did not test such a code change.
--
By by ... Detlef
Mail problems for wine-patches
I send several patches the last days with git and with the webmail interface from web.de, but nothing arrived at the wine-patches archive or the patches queue page. I also unsubscribed and subscribed again to the wine-patches list. Any ideas? Has wine-patches a whitelist? -- By by ... Detlef
Re: testbot failures in advapi32 (security)
-- By by ... Detlef Gesendet:Samstag, 01. Dezember 2012 um 18:16 Uhr Von:Erich E. Hoover ehoo...@mymail.mines.edu An:Detlef Riekenberg wine@web.de Cc:wine-devel wine-devel@winehq.org Betreff:Re: testbot failures in advapi32 (security) On Sat, Dec 1, 2012 at 4:28 AM, Detlef Riekenberg wine@web.de wrote: Hi Erich.We somewhere missed us on #winehackers.Testbot works with your patch:http://testbot.winehq.org/JobDetails.pl?Key=23165 For an account, testbot has a menu item named Register:https://testbot.winehq.org/Register.pl That testbot worked with the old version (http://testbot.winehq.org/JobDetails.pl?Key=23107), testbot did not detect the crash. see the last line.It does not end in: security done (0)I created a bug for this issue:http://bugs.winehq.org/show_bug.cgi?id=32354-- By by ... Detlef
testbot failures in advapi32 (security)
Hi Erich.We somewhere missed us on #winehackers.Testbot works with your patch:http://testbot.winehq.org/JobDetails.pl?Key=23165For an account, testbot has a menu item named Register:https://testbot.winehq.org/Register.pl-- By by ... Detlef
Judge rules: APIs can not be copyrighted.
HiThe result from the Oracle = Google battle is good to know:http://tech.slashdot.org/story/12/05/31/237208/judge-rules-apis-can-not-be-copyrighted-- By by ... DetlefIhr WEB.DE Postfach immer dabei: die kostenlose WEB.DE Mail App fr iPhone und Android.https://produkte.web.de/freemail_mobile_startseite/
RE: localspl: Only store the file part of the filenames in the registry
Hi Huw. We have only filenames in the registry. The current code works fine with the adobe postscript driver and various other driver for PDF printers. Which native driver makes problems? Why do you add spaces before and after the the function args and change idention, bracket style and variable names everywhere in the patch? HP is using a subdirectory for some driver files, but i can't remember the driver name at the moment. -- By by ... Detlef
Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game
On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote:
On 22 January 2012 19:44, Detlef Riekenberg wine@web.de wrote:
-if (usage ~handled)
+static DWORD reported_once;
+
+if (usage ~(handled | reported_once))
+{
+reported_once |= (usage ~handled);
FIXME(Unhandled usage flags %#x.\n, usage ~handled);
+}
I don't think so.
Sorry, I have no Idea, what objections do you have.
The code works.
Without my Patch, the console is flooded with:
0024:fixme:d3d:resource_check_usage Unhandled usage flags 0x8.
With my Patch, the message is printed only once.
(The app is using native d3dcompiler_42 and d3dx9_42)
--
By by ... Detlef
Re: [PATCH 5/5] jscript/tests: Add tests with values related to INT_MAX
On Mo, 2011-06-27 at 11:59 +0200, Jacek Caban wrote: How can we force tests to use VT_UI4? It's not JScript builtin type, you need to extend tests host object for that. Sorry, no clue. Which host object? +/* 0x7fff is 2147483647 is INT_MAX */ +tmp = 2147483647*-1; 0x... is correct jscript syntax, why not use it? Didn't know that. Thanks for the hint -- By by ... Detlef
Re: user32: Partially implement FlashWindowEx with tests
On So, 2011-05-22, André Hentschel wrote Thanks, will get into try 2 pfwi-cbSize sizeof(FLASHWINFO) || pfwi-cbSize sizeof(FLASHWINFO) That code can be reduced to: pfwi-cbSize != sizeof(FLASHWINFO) -- By by ... Detlef
Re: Ubuntu likely to abandon HAL next cycle -- is this workable?
Am Donnerstag, den 12.05.2011, 12:28 +0200 schrieb Scott Ritchie: Consensus here seems to be to try and remove HAL from the archive. Wine still uses it, so this means we'll either need to lobby for keeping HAL or to migrate to udisks. I expect for Wine: udisk (current linux) | hal (for older linux and other os) http://bugs.winehq.org/show_bug.cgi?id=21713 -- By by ... Detlef
Testmail
Hi Just a test, as my patches do not show up in the mail archive. Detlef ___ WEB.DE DSL Doppel-Flat ab 19,99 euro;/mtl.! Jetzt mit gratis Handy-Flat! http://produkte.web.de/go/DSL_Doppel_Flatrate/2
Re: msvcrt: Partially implement _set_abort_behavior
On Mi, 2011-01-12 at 00:48 +0300, Nikolay Sivov wrote:
Date: Wed, 12 Jan 2011 00:46:26 +0300
Subject: [PATCH 1/1] Partially implement _set_abort_behavior
Please search the patches queue first.
try 2: http://source.winehq.org/patches/data/70231
try 1: http://source.winehq.org/patches/data/70136
+static int MSVCRT_abort_behavior = MSVCRT__WRITE_ABORT_MSG |
MSVCRT__WRITE_CALL_REPORTFAULT;
- _set_abort_behavior get unsigned int, but you use an int. Why?
- mingw header have the same name as msdn.
Why are you using different names?
/*
+ * _set_abort_behavior (MSVCRT.@)
+ *
+ * Not exported by native msvcrt, added in msvcr80
+ */
+int CDECL MSVCRT__set_abort_behavior(int flags, int mask)
+{
- need unsigned int
diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h
+/* _set_abort_behavior codes */
+#define MSVCRT__WRITE_ABORT_MSG1
+#define MSVCRT__WRITE_CALL_REPORTFAULT 2
+
+int __cdecl MSVCRT__set_abort_behavior(int,int);
- correct location is stdlib.h
- names are wrong
- need unsigned int
--
By by ... Detlef
Re: wine's configure says gst/gstpad.h usability... No
On Sa, 2010-12-11 at 13:09 +0100, Paul Vriens wrote: On 12/11/2010 08:26 AM, wy...@volny.cz wrote: Hi guys, gstreamer-0.10 development files not found, gstreamer support disabled I'm on Fedora 13 and had to install gstreamer-plugins-base-devel. So I guess you need libgstreamer-plugins-base0.10-dev. Detlef has sent a patch that wasn't applied however: http://www.winehq.org/pipermail/wine-patches/2010-November/096133.html I send an updated patch. http://source.winehq.org/patches/data/69363 -- By by ... Detlef
kernel32: Add a stub for SetProcessDEPPolicy
Any comments available for this Patch? http://source.winehq.org/patches/data/68113 -- By by ... Detlef
Apps for Wine on ARM
Here is a free compiler to create apps on ARM: http://www.smorgasbordet.com/pellesc/ (Untested, how this app works in Wine) -- By by ... Detlef
Re: [PATCH] Compiling Wine at Ubuntu 10.10
On Sa, 2010-10-16 at 13:29 +0200, Alexandre Julliard wrote: Gerold Jens Wucherpfennig gjwucherpfen...@gmx.net writes: You will need this patch to compile Wine at Ubuntu 10.10, because of the new Xorg Server 1.9. If you still get a compilation error in dlls/winex11.drv you will need to add the flag -lXxf86vm. We can't do that. What did they change that breaks the build? No Idea. I'm doing a clean build on Ubuntu 10.10 now, but it need ~1h. Nothing special from configure: checking for -lXxf86vm... libXxf86vm.so.1 -- By by ... Detlef
Re: [PATCH] Compiling Wine at Ubuntu 10.10
On Sa, 2010-10-16 at 10:02 +0200, Gerold Jens Wucherpfennig wrote: You will need this patch to compile Wine at Ubuntu 10.10, because of the new Xorg Server 1.9. You can't do that. Your patch will break the build on many systems. Are you missing libxxf86vm1 or libxxf86vm-dev? If you still get a compilation error in dlls/winex11.drv you will need to add the flag -lXxf86vm. cd dlls/winex11.drv/ make = works here on a clean 32bit build (ubuntu 10.10 / x86_64) -- By by ... Detlef
Re: [PATCH] problem with color management with mscms and gdi
Hi Tomasz.
Welcome to Wine.
You already fixed your missing real name in your first patch.
That is good, but there are more suggestions.
For applications which uses EnumICMProfiles to detect monitor icc profile,
there should be a copy of monitor profile in
windows\system32\spool\drivers\color\monitor.icc. If there is no monitor.icc
in this directory, application works the same as if there were no color
management enabled (but image is displayed ok).
A description for the issue is a good idea.
INT WINAPI EnumICMProfilesA(HDC hdc, ICMENUMPROCA func, LPARAM
lparam)
{
FIXME(%p, %p, 0x%08lx stub\n, hdc, func, lparam);
- return -1;
+ (*func)(C:
\\windows\\system32\\spool\\drivers\\color\\monitor.icc,lparam);
+ FIXME(partially fixed: force C:
\\windows\\system32\\spool\\drivers\\color\\monitor.icc\n);
+ return 1;
}
What you wrote in your patch is a hack and hacks are missing the code
quality to be accepted in Wine.
Wine development is test driven.
You should add some tests for this function and try to invent a real
implementation, which match the tests.
- Does this function handle a NULL parameter for hdc and/or for func?
(If a NULL produce a crash on Windows, there is no need to check for
a NULL in the implementation in Wine)
- What does the function return, when the directory does not exist
or when there are no icc profiles in the directory?
- A HDC for a window on the monitor is not the only type for an HDC.
(memory, printers, metafiles)
Implementing all possible types is not a requirement (as long, as
an app does not need it), but the usual way in Wine is at least
printing a FIXME for the unimplemented part of the API.
- There are usable API functions, to get the icc profile path.
- Reading the directory and calling the user func for every file
is not very difficult, as wine has examples in the source.
You can ask for help for the implementation or for the tests on
wine-devel or use #winehackers on freenode.
There is has also http://testbot.winehq.org and later
http://tests.winehq.org
INT WINAPI EnumICMProfilesW(HDC hdc, ICMENUMPROCW func, LPARAM
...
+ (*func)(C:
\\windows\\system32\\spool\\drivers\\color\\monitor.icc,lparam);
Providing an ANSI Path to a UNICODE callback will never work.
/**
diff --git a/dlls/mscms/transform.c b/dlls/mscms/transform.c
This is a separate Patch
I know, that the starting step is not easy, but once you contributed
successfully to Wine, your Development results (patches) are much
better.
Did you read http://wiki.winehq.org/DeveloperFaq and
http://wiki.winehq.org/SubmittingPatches ?
Overview: http://wiki.winehq.org/Developers
--
By by ... Detlef
Packagers: cups-bsd/cupsys-bsd (lpr and friends) no longer needed
Hi Wine packing Team. Cups has a compatibility package for the BSD style printing system (lpr, lpq, lprm, lpc and related files). The package is named cups-bsd on ubuntu and cupsys-bsd on debian. This compatibility package is no longer needed since Wine-1.3.5, when cups is installed: http://source.winehq.org/git/wine.git/?a=commit;h=f69a4ef07f7b1b0017e1bf335db27751c59b6d85 Thanks for updating the Wine dependency. -- By by ... Detlef
Re: LLVM compilation
On Mon, 2010-10-11 at 08:54 -0600, Jeff Cook wrote: Just wondering if anyone has experimented building WINE with LLVM instead of GCC. Yes, several people used LLVM/CLANG for Wine and send patches. From the commits: http://source.winehq.org/git/wine.git/?a=searchst=commits=CLANGsr=1 You are welcome to Help. -- By by ... Detlef
Re: winspool.drv: Support pDevMode field in {Get/Set}Job
Hi Vitaly. Thanks for fixing printing issues. You use sizeof(DEVMODEW) in you patch, but the correct size is: devmodeW-dmSize + devmodeW-dmDriverExtra You should change the FIXME in the comment of get_job_info_2 to a real FIXME, when unicode is FALSE I'm fine with the unicode - only patch for now, as the related code has to move to localspl later (localspl is unicode only). Thanks -- By by ... Detlef
Re: user32: Implement support for getting class data GCLP_HBRBACKGROUND on other process window
On Fri, 2010-09-17 at 22:30 +0400, Aleksey Bragin wrote: So this patch implements required GetClassLong functionality of getting background brush handle of another process window's class. You introduce unneeded padding in various struct. How can anybody use such strange names? -- By by ... Detlef
Re: inetcpl: Implement LaunchSiteCertDialog on top of cryptui.CryptUIDlgCertMgr
On Fri, 2010-09-17 at 10:32 -0700, Juan Lang wrote: Hi Detlef, I have no issue with the patch, just a question: are you sure native does this? Or does it call wintrust.OpenPersonalTrustDBDialog? I followed your mail from 25. Aug, where you mentioned cryptui.CryptUICertMgr That was a typo and i found cryptui.CryptUIDlgCertMgr to be a usable match. The resulting dialog from rundll32 inetcpl.cpl,LaunchSiteCertDialog looks the same for builtin and native (tested with IE8 for XP) resulted in a call to wintrust.OpenPersonalTrustDBDialog, which in turn calls crypui.CryptUIDlgCertMgr. This is the same dialog as you get for the Publisher... button on the content page in inetcpl.cpl -- By by ... Detlef
Re: [PATCH] inetcpl: Add initial applet
Am Dienstag, den 24.08.2010, 17:56 -0700 schrieb Juan Lang: Hi Detlef, were you planning to resubmit this patch? [1] Yes, after the next release but as a more complete Patchset. Using our own inetcpl.cpl would allow us to avoid that, by exposing cryptui.CryptUICertMgr without using any native DLLs. Good Idea. -- By by ... Detlef
Re: [2/7] shlwapi/tests: Add tests for StrStrA.
Hi Andrew. While reading your Patches, i stumble over deadbeef. We use the value 0xdeadbeef almost everywhere in the tests to initialize a variable to an unusual value. Using deadbeef as a variable name looks strange and make the code harder to read and understand. Please change the name in your Patchset. -- By by ... Detlef ___ Neu: GMX De-Mail - Einfach wie E-Mail, sicher wie ein Brief! Jetzt De-Mail-Adresse reservieren: http://portal.gmx.net/de/go/demail
Re: Anotated 'make test' log
Hi Max Welcome to Wine. Your Patch [Add '_ONCE' variants of DPRINTF, FIXME, WARN.] ( http://source.winehq.org/patches/data/63503 ) has a typo near the end: #define ERR_ONCE WINE_ERR_ONCEE -- By by ... Detlef ___ Neu: GMX De-Mail - Einfach wie E-Mail, sicher wie ein Brief! Jetzt De-Mail-Adresse reservieren: http://portal.gmx.net/de/go/demail
Internet Explorer in Wine
I test sometimes native IE in Wine with the least
possible changes.
With my implementation of shlwapi,SHCreateThreadRef
this week, the native IE UI came up in Wine,
using our shell replacement, mshtml with gecko
and all that low level stuff:
http://www.myimg.de/?img=ieinwineef89e.png
The related COM interfaces for the IE Style UI are
implemented in shdocvw (IWebBrowser and IInternetExplorer)
and browseui (for user elements: Menu, Addressbar)
You need to copy shdocvw.dll, browseui.dll and browselc.dll
to ~/.wine_drive_c/windows/system32/
and override shdocvw and browseui to native.
(native browseui.dll needs browselc.dll)
It works, but it's unstable and the Menu as well as the
Addressbar are absend (not registered in Wine).
register browseui.dll (or use regedit for minimal changes)
Menu Band CLSID: {5b4dae26-b807-11d0-9815-00c04fd91972}
InProcServer32 is %systemroot%\system32\browseui.dll and
ThreadingModel is Apartment
Address has CLSID {01E04581-4EEE-11D0-BFE9-00AA005B4383}
InProcServer32 is %systemroot%\system32\browseui.dll,
ThreadingModel is Apartment and Implemented Categories need
the subkey {00021492---C000-0046}
(IE8 has still the full IE6 style UI available)
Happy testing, and don't forget to fill bugzilla.
--
By by ... Detlef
Re: [PATCH 2/8] urlmon/tests: CoInternetCreateZoneManager not present on W95B
On Fr, 2010-04-16 at 08:57 +0200, Paul Vriens wrote: Wouldn't it be better to just check for one (or all) and bail out with a (only one) win_skip()? I guess if one is not present, none are? The checks are in different test files and some tests work on W95B (IE 4) I prefer to have a complete winetest run for urlmon on various machines (from winetestbot, francois and other), before we shrink the skips. Thanks for the idea -- By by ... Detlef
Re: [PATCH] msvcr90/tests: Add tests for _initterm_e [try 2]
On Sa, 2010-03-20 at 01:08 +0100, Piotr Caban wrote: You forgot to attach changes to configure.ac. Nope. That part is auto-generated, when Makefile.in is in the git tree: tools/make_makefiles Never add auto-generated changes to a patch -- By by ... Detlef
Re: [PATCH] attrib.exe: Add stubbed command
On Mi, 2010-03-17 at 12:22 +0100, Christian Costa wrote: +printf(attrib.exe is currently only a stub command\n); +printf(cmdline:); UNICODE would be better, even for a stub. -- By by ... Detlef
Re: cmd: fix buffer overflow in WCMD_run_program
On Do, 2010-03-04 at 09:20 -0800, Eric Ho wrote: Hi Eric. Welcome to Wine. Fixes http://bugs.winehq.org/show_bug.cgi?id=21344. Overflows fixed: 1. overflow due to long path name (unchecked memcpy,strcpy to thisDir) 2. overflow due to long file name (unchecked strcpy into stemofsearch) 3. overflow due to concatenating thisDir into stemofsearch (strcat) 4. added early breaks when getFullPathName returns an error 5. fixed incorrect errorlevel code (needs to be 9023 and it was 9009) Only fix one problem in a patch please. This list is a good indicator, how to split your patch. Use wine-patc...@winehq.org for the updated patchset. Thanks for helping WIne -- By by ... Detlef
Re: tools/wine.inf: Add a symlink for WindowsNT.CurrentVersion.Print.Printers
On Mi, 2010-02-17 at 11:15 +0100, Alexandre Julliard wrote: Detlef Riekenberg wine@web.de writes: @@ -905,6 +905,7 @@ HKLM,%CurrentVersionNT%\Ports,COM1:,2,9600,n,8,1 HKLM,%CurrentVersionNT%\Ports,COM2:,2,9600,n,8,1 HKLM,%CurrentVersionNT%\Ports,COM3:,2,9600,n,8,1 HKLM,%CurrentVersionNT%\Ports,COM4:,2,9600,n,8,1 +HKLM,%CurrentVersionNT%\Print\Printers,SymbolicLinkValue,0x6,\Registry\Machine\%Control%\Print\Printers It looks like it should be the other way around. All current Code read and write to HKLM\System\CurrentControlSet\Control\Print\* When creating the registry symlink the other way around, how does it work with existing installations? I tested the other symlink: HKLM\System\CurrentControlSet\Control\Print\Printers has the magic entry (SymbolicLinkValue with REG_LINK) with (cannot display value) as data, but the link doesn't work. Creating the link target (HKLM\Software\Microsoft\Windows NT \CurrentVersion\Print\Printer) doesn't help. Deleting the current data followed by a wineboot -u doesn't help. -- By by ... Detlef
Re: oldconfig.c: produce DEVICEMAP//SERIALCOMM entries
On Fr, 2010-02-12 at 13:00 +0100, Alexandre Julliard wrote: A C Hurst a.hu...@sheffield.ac.uk writes: Fixes bug 11811 [http://bugs.winehq.org/show_bug.cgi?id=11811] and its duplicates. This patch sent some time back (over a year) was ignored/lost in noise. Could someone review please? this belongs in mountmgr, and should be based on the actual devices as reported by HAL. - HAL is deprecated / in maintenance mode http://www.freedesktop.org/wiki/Software/hal - DeviceKit is a set of projects to replace HAL http://www.freedesktop.org/wiki/Software/DeviceKit The daemon is libudev and the userspace tools where renamed to udisks: http://lists.freedesktop.org/archives/devkit-devel/2009-December/000567.html Today, the updates for Ubuntu 10.04 replaced devicekit-disks-doc with udisks-doc. - HAL Migration path: http://wiki.ubuntu.com/Halsectomy http://wiki.debian.org/HALRemoval -- By by ... Detlef
New Icon set
Hi Joel When I read your preview page in Firefox, the lens for print preview in idb_std_small.bmp is to large. You can't detect the printer behind the lens. (LCD Resolution here is 1400x1050) As an Idea for an improvement, the print preview menu icon in Firefox is readable: The lens is a bit smaller but more important, the inner circle of the lens is transparent. Thanks for your artwork. -- By by ... Detlef ___ Preisknaller: WEB.DE DSL Flatrate für nur 16,99 Euro/mtl.! http://produkte.web.de/go/02/
kein Betreff
___ Preisknaller: WEB.DE DSL Flatrate für nur 16,99 Euro/mtl.! http://produkte.web.de/go/02/
Re: [winspool 2/6] Move the dlopen of libcups to a sep =?iso-8859-15?Q?arate_function, _allowing_CUPS_to_be_used_prior_to_the_?= full on loading of CUPS printers.
Hi Jeremy What is your reason for your work in winspool.drv? What are your plans? Even if the Patchset changes some things, it's not the correct location to do that. winspool.drv must not do anything with the registry or the driver files. winspool.drv must not use cups at all wineps.drv must not use cups at all That all belong to a print provider, together with a print monitor. To make our live easy, the printprovider and printmonitor for CUPS and LPR will be integrated into localspl.dll (windows is using seperate provider/monitor: See inetpp.dll and lprmon.dll with friends) I have a Patch here for moving AddPrinter to localspl, that address most of your changes, but a small peace of code is only in my test app and not in the Patch yet (get default DEVMODEW from the Driver) An important issue is, that we store DEVMODEA in the registry. Code is there to handle that, bu it failed on julliards machine. My localspl.dll has a cups.c, but that need more work(i can't continue before mid januar). And IMHO, using wine_get_unix_file_name in High-level dlls is wrong by design. W2k pro and XP pro have driver directories only for supported environments. (Servers are different) When you think, that you need the driver directories, they can be created with wine.inf Please avoid ANSI strings in new code. (strdupWtoA should go away) -- By by ... Detlef ___ Preisknaller: WEB.DE DSL Flatrate für nur 16,99 Euro/mtl.! http://produkte.web.de/go/02/
Re: [PATCH 3/4] jscript: Added Function constructor tests.
On Do, 2009-12-10 at 01:15 +0100, Jacek Caban wrote: +func = new Function(); +tmp = func(); +ok(tmp === undefined, func(1,3,2) = + tmp) Greetings from Copy Paste -- By by ... Detlef
Re: [PATCH 2/7] dsound: Clean up DSPROPERTY_DescriptionW, try 2
On Mi, 2009-12-09 at 16:57 +0100, Maarten Lankhorst wrote:
+{
+/* FIXME: Still a memory leak.. */
This should be fixed before sending to wine-patches
--
By by ... Detlef
Re: Very long printernames and test failures
On So, 2009-12-06 at 19:28 +0100, Paul Vriens wrote: Some test failures are shown on boxes with long printernames, for example: http://test.winehq.org/data/17b7ee13fb55e872902be3156610e583e4cd324b/vista_test-on-vista/winspool.drv:info.html http://test.winehq.org/data/17b7ee13fb55e872902be3156610e583e4cd324b/win7_153/winspool.drv:info.html And indeed if I create a local printer with a very long name the cutoff is one bigger than what the test is currently doing. The attached patch fixes that. I cant find a reason, why Windows is using 2 character for the terminating zero. This looks like an Windows bug. I expect a different behavior on older Windows versions. The best test would probably to add a printer in the tests An addprinter-test with a medium sized name is in my tree, but it needs some fixes in our Implementation. I'm testing with AddPrinter in localspl, but the 16Bit separation got a higher priority. Any thoughts? Manual creating printers with the specific length (CCHDEVICENAME -2 / -1 / +0 / +1) on older OS and run the tests is easy, but I cant do that before the next weekend. -- By by ... Detlef
Re: winspool.drv: Acroread 9.2 relies on the buffer sizes returned by GetPrinterA and GetPrinterDriverA being large enough to hold their respective unicode versions' data.
On Do, 2009-11-19 at 13:18 +, Huw Davies wrote: --- dlls/winspool.drv/info.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) ANSI functions in winspool.drv have this behavior since w2k. We have already a test for EnumPrintersA/W [required by Outlook2003) I prefer to make such buffer size requirements also the default in Wine. We are able to simplify a lot of ANSI Functions, when we use this way. Alexandre, is this acceptable for you? -- By by ... Detlef
Re: d3d8/tests: Avoid a crash, when CreateTexture failed
On Mi, 2009-11-11 at 15:16 +0100, Henri Verbeet wrote: I.e., does the attached patch work for you? yes, with 0 failures :-) d3d9 has the same code (but i cant test d3d9 on my machine). Thanks. Do you want to send the patches yourself? -- By by ... Detlef
Re: avifile bugfixes
On Di, 2009-11-10 at 00:43 +0100, Julius Schwartzenberg wrote: I will add tests to show this and submit the patches then. I created a test for avifil32 in June 2008, but it was not comitted. ( http://www.winehq.org/pipermail/wine-patches/2008-June/056310.html ) The bug 14085 was created to document the required feature: http://bugs.winehq.org/show_bug.cgi?id=14085 an importlib for multiple dlls is not supported (avicap32 + avifil32 + msvfw32 = vfw32) You can and should create tests (crosscompile them to check the Windows results and to verify the implementation changes) and send them as a seperate patch, but the patche can't be comitted before bug 14085 is fixed. -- By by ... Detlef
Re: Another virus-in-wine story
On Sa, 2009-10-24 at 22:07 -0700, Dan Kegel wrote: This is about the fifth article of this sort, so it's not really news anymore, but it's still fun to read about. http://linux.slashdot.org/story/09/10/24/1759213/Now-Linux-Can-Get-Viruses-Via-Wine The blogger mention the bad website, but the malware file change to often. Yesterday, you will get a fake Adobe Flash Player.exe (crash early in Wine) after redirection to a different Website (looks like facebook.com): http://www.virustotal.com/analisis/a7c8ccfd07652f8622edb3f7ea2bbb975ddb3a74df90feca794e71d2001bbe24-1256993159 Today, you will receive surprise.exe (crash early in Wine) from the Website: http://www.virustotal.com/analisis/8f753cbb1ddc3edda4a0b4ec0ce14475c2ed5e5890864f1d31ea8eefa28d01b2-1256994557 -- By by ... Detlef
Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)
On Do, 2009-10-01 at 16:59 -0700, Dan Kegel wrote: +/*** + * wrap_getxattr + * Retrieve extended attribute of posix file into given buffer. + * Use fd if given, else use fname; caller only sets one or the other. + */ +static int wrap_getxattr(int fd, const char *fname, const char *attrname, char *attrbuf, int attrbuflen) Code, which is called very often, should produce as less overhead as possible. I suggest to use static inline. Seperate implementations for fd and fname should also make a difference. Your code handle different parameter for the attr functions. Is it possible, that code, which is compiled for one ABI version can call the implementation of the other ABI version? When Wine depends on libattr and libattr-dev after you Patch, all packagers should get this information. -- By by ... Detlef
Re: help with dwBackBufferCount in backbuffer surfaces needed
On Di, 2009-09-29 at 13:27 +0200, Markus Stockhausen wrote: The test will fail in Windows and Wine to get the results in both cases. The result will show like this: dsurface.c:1264: Test failed: backbuffer surface has dwBackBufferCount==2 This is 0 here with ATI Radeon R100 on Win98se, w2k sp4 and XP sp3 Win98se has an old, but acellerated driver The R100 is no longer supported by ATI on w2k / XP -- By by ... Detlef
Re: wininet: Handle finding ftp files in subdirectories and using wildcards.
On Sa, 2009-09-26 at 22:15 -0500, Mike Ruprecht wrote: +if (lpszSearchPath) +HeapFree(GetProcessHeap(), 0, lpszSearchPath); + Please remove the unneeded if(lpszSearchPath) before HeapFree. -- By by ... Detlef
Re: sti: test behavior of creation with the A/W functions versus STI_VERSION_FLAG_UNICODE
On Fr, 2009-09-25 at 16:35 +0200, Damjan Jovanovic wrote: * sti: test behavior of creation with the A/W functions versus STI_VERSION_FLAG_UNICODE Using the name sti_tests is bad. The short sti is enough. You forgot the license notice We usually cast the result of GetProcAddress() as (void *). That is not perfect, but much better to read. -- By by ... Detlef
Re: [PATCH 2/4] mshtml: Add test suite for IHTMLLocation
On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote:
+todo_wine ok(SUCCEEDED(hres), get_hash failed: 0x%08x\n,
hres);
+if(SUCCEEDED(hres)){
+if(str_pass)
+ok(strcmp_wa_null(str, exp) == 0, expected retrieved
hash to be L\%s\, was: %s\n, exp, wine_dbgstr_w(str));
+else
+todo_wine ok(strcmp_wa_null(str, exp) == 0, expected
retrieved hash to be L\%s\, was: %s\n, exp, wine_dbgstr_w(str));
+}
+}
+
Your Patch is hard to read.
Please split the long lines (3 parts are easy)
The whole patch can be split in smaller patches.
+static void perform_test(const struct location_test* test)
In the case of a test failure or a crash, there is no chance to know,
which test-set failed.
A suffix (protocol name or line number) at the start of every
ok() can be used to make the normal output as silent as possible.
Using a trace before you call perform_tests() works also.
That produce a bit noise in the result file, but the test binary is
smaller.
--
By by ... Detlef
Re: [(try 3) 3/3] opengl32/tests: Improve test for wglMakeCurrent.
On Sa, 2009-09-19 at 13:15 +0200, Rico Schüller wrote: +ret = wglMakeCurrent( NULL, NULL ); +ok( !ret, wglMakeCurrent failed\n ); shouldn't that message read wglMakeCurrent succeeded ? Yes, probably something like wglMakeCurrent succeeded, but should fail! is really a better solution Please remenber, that all failures have the prefix: filename:__LINE__: Test failed: My style for the ok message is to print the returned result followed by the expected result in round brackets. -- By by ... Detlef
Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt
On Do, 2009-08-20 at 17:58 +0200, Alexandre Julliard wrote:
Juan Lang juan.l...@gmail.com writes:
@@ -1779,6 +1779,8 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level,
TRACE(socket: %04lx, level 0x%x, name 0x%x, ptr %p, len %d\n,
s, level, optname, optval, *optlen);
+/* Some apps sign-extend the level, so mask off the higher-order bits
*/
+level = 0x;
There can be several other ways to handle this, it needs test cases to
determine which way Windows is using.
When reading the log in the bug, the WSAAsyncGetHostByName16 is the
indicator for an 16bit app.
Attached is my diff from last year for that code.
--
By by ... Detlef
diff --git a/dlls/ws2_32/socket16.c b/dlls/ws2_32/socket16.c
index b4b3fe8..c2bb444 100644
--- a/dlls/ws2_32/socket16.c
+++ b/dlls/ws2_32/socket16.c
@@ -294,8 +294,9 @@ INT16 WINAPI getsockopt16(SOCKET16 s, INT16 level, INT16 optname, char *optval,
INT optlen32;
INT *p = optlen32;
INT retVal;
+
if( optlen ) optlen32 = *optlen; else p = NULL;
-retVal = WS_getsockopt( s, level, optname, optval, p );
+retVal = WS_getsockopt( s, level 0x, optname, optval, p );
if( optlen ) *optlen = optlen32;
return retVal;
}
@@ -397,7 +398,7 @@ INT16 WINAPI setsockopt16(SOCKET16 s, INT16 level, INT16 optname,
char *optval, INT16 optlen)
{
if( !optval ) return SOCKET_ERROR;
-return WS_setsockopt( s, level, optname, optval, optlen );
+return WS_setsockopt( s, level 0x, optname, optval, optlen );
}
/***
diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c
index e2d2162..782204d 100644
--- a/dlls/ws2_32/tests/sock.c
+++ b/dlls/ws2_32/tests/sock.c
@@ -1807,12 +1807,21 @@ static void test_extendedSocketOptions(void)
return;
}
+optval = 0xdeadbeef;
ret = getsockopt(sock, SOL_SOCKET, SO_MAX_MSG_SIZE, (char *)optval, optlen);
+trace(got %d with optval: 0x%x/%d\n, ret, optval, optval);
ok(ret == 0, getsockopt failed to query SO_MAX_MSG_SIZE, return value is 0x%08x\n, ret);
ok((optval == 65507) || (optval == 65527),
SO_MAX_MSG_SIZE reported %d, expected 65507 or 65527\n, optval);
+/* IE 3 use 0x instead of SOL_SOCKET (0x) */
+optval = 0xdeadbeef;
+ret = getsockopt(sock, 0x, SO_MAX_MSG_SIZE, (char *)optval, optlen);
+trace(got %d with optval: 0x%x/%d\n, ret, optval, optval);
+
+
+
optlen = sizeof(LINGER);
ret = getsockopt(sock, SOL_SOCKET, SO_LINGER, (char *)linger_val, optlen);
todo_wine{
Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt
On Do, 2009-08-20 at 18:22 +0200, Alexandre Julliard wrote: Juan Lang juan.l...@gmail.com writes: There can be several other ways to handle this, it needs test cases to determine which way Windows is using. Sorry for my lack of imagination: could you suggest at least one other way so I can make sure the tests are representative? It may check for just 0x as a special case, or check for high word being 0 or 0x and rejecting others, etc. Some values to test would be things like 0x1234, 0x1234, 0x, etc. Jeff did a patch in the bug, which check for SOCKET_ERROR, when setsockopt was called with 0x as level: http://bugs2.winehq.org/attachment.cgi?id=20211 I'm offline tomorrow, otherwise i woud add more tests to my old patch. -- By by ... Detlef
Wine icon refresh
On Sa, 2009-08-08 at 20:42 +0100, Joel Holdsworth wrote: If you want, I can draw a Tango-style icon for it, as part of my work in progress wine icon refresh: http://www.airwebreathe.org.uk/wine-icon/ They look nice, but I have some comments: idb_std_large.bmp and idb_std_small.bmp: The print preview icon looks like a printer and has a lens in on size. The printing icon looks like a printer and has a lens in on size The search icon looks like the print preview icon on Windows You should use seperate icons and properly use the lens. For printing, use a printer icon (Windows also use a printer icon here) For the print preview, use something different. (Windows is using a full paper sheet with a lens) You can test your icons with: wine wordpad programs: The Wine glass do not have a consistent size. I prefer using the smaller Wine glass, but then the small icons (16/22) are hard to merge. winetest: The icons for all other programs have the Wine glass on the other side. -- By by ... Detlef
Re: [8/21] comctl32: Add basic structure for IImageList interface
On Mi, 2009-08-12 at 23:31 +0100, Owen Rudge wrote: You can't do that. HIMAGELIST should be the same thing as IImageList. Hmm. Looking at the HIMAGELIST/IImageList internals in a debugger on Windows, the layout appears to be ... :-( Disassembling Windows Code is not allowed for Wine. You should have know that and you should know the result. -- By by ... Detlef
Re: New winetricks 20090716: new verbs droid, wenquanyi, dinput8
On Fr, 2009-07-17 at 02:01 +0200, Matijn Woudt wrote: (to the list this time) On Fri, Jul 17, 2009 at 1:54 AM, Ben Kleinshackl...@gmail.com wrote: 2009/7/16 Hin-Tak Leung hintak_le...@yahoo.co.uk: I have decided against responding to the chinese thread (so much mis-information, ignorance and wrongful entitlement in it, and little substance), but I like to point out that the wenquanyi fonts are shipped with fedora 11. Not sure about fedora 10, but he just needs to upgrade his OS (apparently he is on fedora 10?) to get it, no need to badger the wine people or winetricks. Ubuntu/suse people please comment. On Debian unstable (amd64): $ apt-cache search wenquanyi ttf-wqy-microhei - A droid derived Sans-Seri style CJK font ttf-wqy-zenhei - WenQuanYi Zen Hei A Hei-Ti Style (sans-serif) Chinese font xfonts-wqy - WenQuanYi Bitmap Song CJK font for X Same on latest (K)unbuntu: $ apt-cache search wenquanyi ttf-wqy-zenhei - WenQuanYi Zen Hei A Hei-Ti Style (sans-serif) Chinese font xfonts-wqy - WenQuanYi Bitmap Song CJK font for X ttf-wqy-microhei - A droid derived Sans-Seri style CJK font Though, only ttf-wgy-zenhei was installed by default on my machine. On Ubuntu 8.04: $ apt-cache search wenquanyi ttf-wqy-zenhei - WenQuanYi Zen Hei A Hei Ti Style (sans-serif) Chinese font xfonts-wqy - WenQuanYi Bitmap Song CJK font for X -- By by ... Detlef
Re: XInput [1/4]: Implement XInputGetState
On Do, 2009-07-09 at 12:50 +0200, Michael Gruber wrote: On Thu, Jul 9, 2009 at 09:50, Stefan Dösingerstefandoesin...@gmx.at wrote: Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. I actually wrote an implementation on top of DirectInput earlier, but I ditched it since I couldn't get the features to work that I wanted. Can it work the opposite way (DirectInput on top of XInput)? -- By by ... Detlef
Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte
On Mo, 2009-06-29 at 16:49 +0900, Dmitry Timoshkov wrote: Christoph von Wittich christ...@apiviewer.de wrote: + if (*pcbProvName INT_MAX) + *pcbProvName = INT_MAX; In which way WideCharToMultiByte is broken? It always helps to provide an explanation and if possible a test case. While working on the tests for shlwapi/SHUnicodeToAnsiCP, i stumbled also over the broken handling of a negative dstlen in WideCharToMultiByte. We already have a test for this case, marked with todo_wine. Fixing kernel32 was easy, so i send a Patch: http://www.winehq.org/pipermail/wine-patches/2009-June/075165.html Unfortunately, WideCharToMultiByte is called with a negative dstlen from the Wine source. (convert_PCREDENTIALW_to_PCREDENTIALA, but there might be more locations.) Christoph, are you working on this issue? Otherwise i will take a look on the weekend, as I want to get my tests for SHUnicodeToAnsiCP in the tree. -- By by ... Detlef
Re: configure.ac: make sure we can run cmdlgtst and view from outside wine tree
On Mo, 2009-06-29 at 12:50 -0500, Austin English wrote: With this patch, they are treated like other programs, e.g., winhlp32, and installed, so one can use: $ wine view and get the same effect. That parts of configure.ac are created by tools/make_makefiles tools/make_makefiles-50-# Programs that we don't want to install at all tools/make_makefiles-51-my %dont_install = tools/make_makefiles-52-( tools/make_makefiles:53: cmdlgtst = 1, tools/make_makefiles-54- view = 1, tools/make_makefiles-55- winetest = 1, tools/make_makefiles-56-); -- By by ... Detlef
Re: Wine translation statistics sources
On Sa, 2009-06-20 at 19:19 +0200, Alexandre Julliard wrote: Mikołaj Zalewski miko...@zalewski.pl writes: It's online again. Having it on WineHQ would probably give a better uptime It's now online at http://source.winehq.org/transl/ and will be updated every time there's a git push. Please let me know if you find any problems. T Thanks! The results for Wone 1.0.x ( http://pf128.krakow.sdi.tpnet.pl/wine-transl/ ) won't open (tryied several times yesterday and today) Is is possible to host a copy of the results on winehq.org ( http://source.winehq.org/transl-1.0/ ) to remove the load and bandwidth from Mikołaj's server or remove the Link to the Results from winehq.org? -- By by ... Detlef
Re: W-related helper functions for our tests
On Fr, 2009-06-19 at 12:44 +0200, Paul Vriens wrote: I was wondering if it would make sense to introduce several helper functions that could be used by all our tests. The main ones needed are the ones to cope with Win9x missing several W-functions. Another one used quite often in the tests is something like wine_dbgstr_w. Yet another one compares a W with an A-string. Ideas, remarks, suggestions? +1 debugstr_w is used often. With lstrcpyW, the results can be stored in UNICODE without loosing informations (CP_ACP) / without stumble over unsupported Codepages (CP_UTF8) -- By by ... Detlef
Re: Wine translation statistics sources
On Mo, 2009-06-08 at 23:24 +0200, Michael Stefaniuc wrote: And we of course need something to cope with the change to the clock resource files as mentioned by Michael Stefaniuc. Or we should change our clock resources to fit in the rest of wine? You mean reverting Alexandre's patch? Doubt it. Alexandre and I talked on irc about that. The --verify-translation functionality needs to move out wrc and into a separate tool that parses the .res files or the binary. When using the *.rc files, we could add --import and --export for *.po -- By by ... Detlef
Crash in the mlang test
Hi Ge The mlang tests where reordered and now it crashed on on your Win98 machine with mlang.dll 4.72.3110.0. http://test.winehq.org/data/675e6e93b1d2b4555d05e311764510abf763d21d/98_gvg-w98/mlang:mlang.html Please send me the results for the test with: set WINETEST_REPORT_SUCCESS=1 Thanks -- By by ... Detlef
Re: advpack: Implement ExtractFilesW [try 2]
On Do, 2009-06-11 at 15:04 -0700, James Hawkins wrote: 2009/6/11 Vladimir Pankratov script...@mail.ru: Hello all. Implemented ExtractFilesW Changed files: advpack/files.c You're converting A - W - A. This happens because cabinet.Extract is (as far as we know) ansi-only. In this case, I think it's ok to make ExtractFilesW call into ExtractFilesA, with an appropriate comment as to why this is happening. The crosscall should be avoided, when possible. As example, move the implementation to extract_filesAW(..., BOOL is_unicode) and made the API entry points a wrapper around this. -- By by ... Detlef
Re: PATCH - enhance the help message in expand
On Do, 2009-06-11 at 11:16 -0400, Steven Edwards wrote: +expand [-r] source destination\n +expand -r source [destination]\n +expand -D source.cab [-F:Files]\n +expand source.cab -F:files destination\n +\n + -rRename expanded files.\n +If the -r option is given to a cabinet containing multiple\n +files, the call will fail.\n + -DDisplay list of files in source.\n +(This option is currently unimplemented)\n + sourceSource file specification. Wildcards may be used.\n + -F:Files Name of files to expand from a .CAB.\n +(This option is currently unimplemented)\n + Destination Destination file | path specification.\n +Destination may be a directory.\n +If Source is multiple files and -r is not specified,\n +Destination must be a directory.\n Mixing the case looks strange. (Files/files, Destination/destination) Please move the helpmsg to a resource, to make translations possible. -- By by ... Detlef
Re: shell32: update file type associations when requested
On Do, 2009-06-11 at 20:52 +0200, Damjan Jovanovic wrote:
+
+if (wEventId SHCNE_ASSOCCHANGED)
+{
+TRACE(refreshing file type associations);
+RefreshFileTypeAssociations();
+}
\n is missing in the TRACE.
The helper function looks like an API call.
Please use lcase.
--
By by ... Detlef
Re: opengl32: get rid of glext.h
On Mi, 2009-06-10 at 21:56 +0200, Roderick Colenbrander wrote: -#ifdef HAVE_GL_GLEXT_H -# include GL/glext.h -#endif The same code is used in winex11.drv/opengl.c Can this also be removed? When that's the case, then GL/glext.h can be removed from AC_CHECK_HEADERS in configure.ac -- By by ... Detlef
Re: kernel32/tests: Add tests for GetLocaleInfo with SUBLANG_NEUTRAL
This one introduces failures on NT4 and below and on some boxes with a non-English locale. Argh .. Could you have a look? Yes. Thanks for the fast report. -- By by ... Detlef
Re: PowerPC MacOSX work...
On Mo, 2009-05-25 at 22:06 +0200, Stefan Dösinger wrote: they won't work because WinPPC uses little endian while MacOS uses big endian. I am wondering how that would be possible though, can PPCs switch modes? Yes, a PowerPC can switch endian. -- By by ... Detlef
Re: Entry point not found for GetDiskInfoA (wininet_crosstest.exe)
On Do, 2009-05-21 at 12:05 +0200, Alexandre Julliard wrote: Using that executable on Windows or Wine is not possible (Entry point not found for GetDiskInfoA) The wininet_test.exe on winehq has an ordinal Import of 102 in that place. How can we fix that? You have to use the Wine import libs, not the Mingw ones. From IRC: julliard you haven't run make crosstest from the top level winspool make -C dlls/wininet/tests crosstest is different julliard yes it's different julliard you need to build the import libs if you want them to be used winspool Where is the rule to create all import libs? julliard just do a make crosstest at the top level, it takes care of everything Example for building an import-lib for mingw on demand: make -C dlls/wininet/ libwininet.a -- By by ... Detlef
Entry point not found for GetDiskInfoA (wininet_crosstest.exe)
In dlls/wininet/tests/urlcache.c, GetDiskInfoA is called, but wininet.dll (native and wine) export this function only by ordinal. When I build the crosstest, my mingw [i586-mingw32msvc-gcc (GCC) 4.2.1-sjlj (mingw32-2)] creates a named Import for GetDiskInfoA with an ordinal hint of 65. Using that executable on Windows or Wine is not possible (Entry point not found for GetDiskInfoA) The wininet_test.exe on winehq has an ordinal Import of 102 in that place. How can we fix that? (My patch to use an ordinal import in the test was dropped: http://www.winehq.org/pipermail/wine-patches/2009-May/073130.html ) -- By by ... Detlef
Re: [1/4] ws2_32/tests: Resend: IPv6 tests for WSAAddressToStringA
On Mo, 2009-04-27 at 20:48 +1000, Jeff Latimer wrote:
-ok( len == sizeof( expect4 ), Got size %d\n, len);
+ok( len == sizeof( expect4 ), Expected size to be %d, got %d\n,
sizeof( expect4 ), len);
Do not use sizeof() in a test.
+/*check to see it IPv6 is available */
+v6 = socket(AF_INET6, SOCK_STREAM, IPPROTO_TCP);
+if (v6 == INVALID_SOCKET) {
+skip(Could not create IPv6 socket (LastError: %d; %d
expected if IPv6 not available).\n,
+WSAGetLastError(), WSAEAFNOSUPPORT);
+goto end;
There is no reason, that the reader must guess from the log, if the
result
is a failure or an expected behavior.
You should detect, that IPv6 is not available and handle that case nice.
if ((v6 == INVALID_SOCKET) (WSAGetLastError() == WSAEAFNOSUPPORT)) {
skip(IPv6 not supported on this system\n);
goto end;
}
ok(v6 !== INVALID_SOCKET,
create an IPv6 socket failed with %d\n,
WSAGetLastError());
if (v6 == INVALID_SOCKET) {
skip(No IPv6 socket\n);
goto end;
}
I know, that the same message is already in the current logs.
That should be handled the same way.
Thanks for pick up IPv6
--
By by ... Detlef
Re: Reparse point unit tests patches
On So, 2009-04-26 at 13:18 +1000, Paul TBBle Hampson wrote: [PATCH 2/2] Add unit tests for junction points using reparse point interface http://www.winehq.org/pipermail/wine-patches/2009-January/067227.html I didn't test the patches, but from the quick lock: The test must compile with the Microsoft VC toolchain. That might break, when you define a struct in your source without a guard #ifndef. Much better is the use of the correct header for that. + /* Stuff that lives in ntifs.h, according to MSDN */ It's in ddk/ntifs.h in OpenWatcom. + buf[bytes] = '\0'; Your debugstrn_w is broken. Your Code writes to unallocated memory, when WideCharToMultiByte need more bytes as you provided. + (WCHAR*)(((char*) That looks really ugly. + static void InitFunctionPointers(void) A private function with mixed case can be mixed up with an Windows API function, when used. Please use lowcase here. Please avoid to use the current Directory. I suggest to use a temporary directory below GetTempPath and create your test directories there + skip(kernel32 does not export required functions.\n); Please use win_skip here -- By by ... Detlef
Re: Need help writing test
Hi Igor I've found few visual glitches in comctl32/toolbar, and now try to write this all down as conformance tests, Thanks for your work on comctl32 TB_SETBITMAPSIZE 20,20 TB_SETBUTTONSIZE 30,30 TB_SETBITMAPSIZE 10,10 Now, if you do TB_SETBUTTONSIZE, you'll see the difference. builtin comctl will return 17,16. Native - 30,16. Did you mean TB_GETBUTTONSIZE? Native comctl32 in Wine or native on Windows? Did you test your used size in Windows with different UI settings? ( dpi, Theme) I expect, that you will get a different result. (I will try your code, when I'm back at home) This test fails, when I test it with native comctl32 (the size is 17,16). Why could this happen or what am I doing wrong? It's possibele, that Wine can resize the Height (shink to 16) but fail to resize the Width (shrink to 17) When native comctl32 in returns 30,16 in Wine, but 17,16 in Windows, then something outside comctl32 is expected by native comctl32, but missing/wrong in Wine. -- By by ... Detlef Pt! Schon vom neuen WEB.DE MultiMessenger gehört? Der kann`s mit allen: http://www.produkte.web.de/messenger/?did=3123
Re: dsound: Allow a special cbSize case in CreateSoundBuffer (updated)
On Mo, 2009-04-20 at 21:51 -0700, Jesse Allen wrote: In CreateSoundBuffer, some apps pass sizeof(WAVEFORMATEXTENSIBLE) for the cbSize and we have to allow it, but only when the SubFormat is KSDATAFORMAT_SUBTYPE_PCM. This updated patch is simpler... at the expense of being less clear ;) Includes test cases which were verified on WinXP. Fixes bug #11716 Hi Jesse. Your patch introduced failures for the dsound-test on some systems with win98, w2k and w2k3. ( http://test.winehq.org/data/tests/dsound:dsound8.html ) Can you please take a look? Thanks -- By by ... Detlef
Re: Changing the language that wine runs in (testing language versions of dialogs)
On Di, 2009-04-21 at 21:06 +0100, Reece Dunn wrote: LANG=es_ES.UTF-8 ./wine winecfg works for me. The language code is es_ES and not just es. That works. I have started a page on the wiki (http://wiki.winehq.org/TestingLanguages) to document how to launch Wine in the different languages. It's not complete yet. I did the attached script a while ago for dialog testing before Wine-1.0, but it works also for the programs. The given command is run in every translated language on seperate virtual Desktops. Examples: WINETEST_INTERACTIVE=1 winetest_rc dlls/localui/tests/localui_test.exe.so winetest_rc programs/winecfg/winecfg.exe.so -- By by ... Detlef winetest_rc Description: application/shellscript
Re: Janitor: list.h functions defined but not used
On Mo, 2009-04-20 at 10:01 +0200, Henri Verbeet wrote: More specifically, you need to protect this with an #ifdef. #ifdef __GNUC__ #define __WINE_ATTR_UNUSED __attribute__((unused)) #else #define __WINE_ATTR_UNUSED #endif Support for compiler specific features should be tested during configure. -- By by ... Detlef
Re: [2/2] ntdll: Implement NtQueryInformationToken(TokenDefaultDacl).
On Fr, 2009-04-17 at 12:53 +0200, Hans Leidekker wrote: +Dacl = HeapAlloc(GetProcessHeap(), 0, Size); +ret = GetTokenInformation(Token, TokenDefaultDacl, Dacl, Size, Size); +ok(ret, GetTokenInformation(TokenDefaultDacl) failed with error %u\n, GetLastError()); + CloseHandle(Token); Please cleanup properly: HeapFree(GetProcessHeap(), 0, Dacl); -- By by ... Detlef
Re: oleaut32: [Patch 1/2] VarCat must use localized names for VT_BOOL
On Mi, 2009-04-15 at 13:37 +0200, Paul Vriens wrote:
The lstrcpyW and lstrcatW additions to init() in the tests don't work on
Win95. I guess that's where the new failures come from:
I removed a broken(hres == VARCMP_GT), and that's what
VarCmp on your w95 machine returned.
My second Patch for oleaut32/tests/vartest.c was not applied, otherwise
we
would have seen the reason in the log.
Can you please use the attached diff and post the result?
Thanks
--
By by ... Detlef
diff --git a/dlls/oleaut32/tests/vartest.c b/dlls/oleaut32/tests/vartest.c
index 24ef171..f1abae7 100644
--- a/dlls/oleaut32/tests/vartest.c
+++ b/dlls/oleaut32/tests/vartest.c
@@ -257,6 +257,25 @@ static const char *variantstr( const VARIANT *var )
sprintf( vtstr_buffer[vtstr_current], VT_CY(%x%08x), S(V_CY(var)).Hi, S(V_CY(var)).Lo ); break;
case VT_DATE:
sprintf( vtstr_buffer[vtstr_current], VT_DATE(%g), V_DATE(var) ); break;
+case VT_BOOL:
+sprintf( vtstr_buffer[vtstr_current], VT_BOOL(%d), V_BOOL(var)); break;
+case VT_BSTR:
+if (HIWORD(V_BSTR(var))) {
+LPSTR data;
+DWORD len;
+
+len = WideCharToMultiByte(CP_ACP, 0, V_BSTR(var), -1, NULL, 0, NULL, NULL);
+data = HeapAlloc(GetProcessHeap(), 0, len);
+WideCharToMultiByte(CP_ACP, 0, V_BSTR(var), -1, data, len, NULL, NULL);
+sprintf( vtstr_buffer[vtstr_current], VT_BSTR(%s), data);
+HeapFree(GetProcessHeap(), 0, data);
+}
+else
+{
+sprintf( vtstr_buffer[vtstr_current], VT_BSTR(0x%x), LOWORD(V_BSTR(var)));
+}
+break;
+
default:
return vtstr(V_VT(var));
}
@@ -5430,8 +5449,10 @@ static void test_VarCat(void)
V_BOOL(right) = TRUE;
V_BSTR(expected) = SysAllocString(sz12_true);
hres = VarCat(left,right,result);
+trace(got 0x%x and %s for %s, %s\n, hres, variantstr(result), variantstr(left), variantstr(right));
ok(hres == S_OK, VarCat failed with error 0x%08x\n, hres);
hres = VarCmp(result,expected,lcid,0);
+trace(got 0x%x for %s, %s\n, hres, variantstr(result), variantstr(expected));
ok(hres == VARCMP_EQ, Expected VARCMP_EQ, got %08x for %s, %s\n,
hres, variantstr(result), variantstr(expected));
@@ -5447,8 +5468,10 @@ static void test_VarCat(void)
V_BOOL(right) = FALSE;
V_BSTR(expected) = SysAllocString(sz12_false);
hres = VarCat(left,right,result);
+trace(got 0x%x and %s for %s, %s\n, hres, variantstr(result), variantstr(left), variantstr(right));
ok(hres == S_OK, VarCat failed with error 0x%08x\n, hres);
hres = VarCmp(result,expected,lcid,0);
+trace(got 0x%x for %s, %s\n, hres, variantstr(result), variantstr(expected));
ok(hres == VARCMP_EQ, Expected VARCMP_EQ, got %08x for %s, %s\n,
hres, variantstr(result), variantstr(expected));
Re: Winprinfo tool
On Mi, 2009-04-15 at 10:13 +0300, Saulius Krasuckas wrote: I just have struck one tool related to Windows printer drivers [*]: [*] http://unixwiz.net/tools/winprinfo.html Thanks for your Post. I know that tool, but i wrote my own API test tool before I found winprinfo. My tool allows me to call common needed function (A and W) for winspool.drv, any printprovider and any printmonitor with the flags/sizes/names, that I want for most parameters. -- By by ... Detlef
Re: FYI -- Dragon Naturally Speaking running a bit better today.
On Do, 2009-04-09 at 16:05 -0400, Susan Cragin wrote: Dragon Naturally Speaking ... the amount of time one can use it before it crashes crept up about 2 minutes, ... Today I dictated for about 14 minutes until it crashed. That's progress. Susan, thanks a lot for your sedulous testing of DNS in Wine! -- By by ... Detlef
Re: SoC: DirectShow/Gstreamer
On Di, 2009-03-17 at 15:56 +0100, Maarten Lankhorst wrote: You will probably find graphedt.exe from the microsoft sdk useful, A GPL alternative exists, but does not work in Wine yet: http://blog.monogram.sk/janos/tools/monogram-graphstudio/ -- By by ... Detlef
Re: urlmon/misc test and the use of URLZONEREG_DEFAULT
On Fr, 2009-04-03 at 20:49 +0200, Paul Vriens wrote: urlmon:misc misc.c:884: Test failed: (1400) policy=3, expected 0 misc.c:884: Test failed: (1e05) policy=1, expected 2 So the question is, does somebody now what URLZONEREG_DEFAULT defaults to? HKCR or HKLM and is this always the same or are there circumstances that make the default different. I guess I could write a test that checks both HKLM and HKCR and directly modifies the registry values in both hives to see what IInternetZoneManager_GetZoneActionPolicy() is using. Ok, I see on test.winehq.org that I'm not the only one: http://test.winehq.org/data/30041c283a77903a1439bef65f96eebbdf90e461/2000_dr-asus/urlmon:misc.html http://test.winehq.org/data/6b6d18d766893ff10a38a4efbbe5ef4ef8e9828b/xp_dr-asus/urlmon:misc.html When I install a system, I change some IE security settings with the internet control panel. Independant from this thread, I found this description yesterday; http://support.microsoft.com/kb/182569 From the kb page, the settings are stored in HKCU and read from there, unless forced to HKLM by Group Policy or the DWORD Security_HKLM_only -- By by ... Detlef
Re: gdi32: don't compile printdtv16 on 64-bit
On Di, 2009-03-24 at 22:19 -0500, Austin English wrote: +@ stdcall -i386 WriteSpool16(long ptr long) You disable Printing in Wine with that. -- By by ... Detlef
Re: Implement [Un]RegisterHotKey with test
On Mo, 2009-03-30 at 18:17 +0500, Vladimir Pankratov wrote:
+return DefWindowProcW (hWnd, msg, wParam, lParam);
+WCHAR className[] = {'T','e','s','t','H','o','t','K','e','y',0};
+WCHAR winName[] = {'H','o','t','K','e','y','T','e','s','t',0};
+ATOM classatom;
+WNDCLASSW cls;
+cls.hIcon = LoadIconW (0, (LPWSTR)IDI_APPLICATION);
+cls.hCursor = LoadCursorW (0, (LPWSTR)IDC_ARROW);
Next to the other comments, beware that UNICODE Functions are missing
or not implemented in win9x.
Please use ANSI Functions in the tests.
--
By by ... Detlef
Re: mciqtz32: Implement driver messages
On So, 2009-03-29 at 18:12 +0200, Christian Costa wrote: That said, I don't understand then why we don't just convert wine's code (in several steps off course) and avoid troubles particularity switch from one style to another depending on the dll we are working on. Changing only the indention is not desired, as the history is falsified (Original Author and date/time of the the last code-change). Expect patches with unrelated indention changes to be rejected. I recently implemented d3dxof using a 2 spaces indentation style. I don't know either how this code could have gone into git. :-| Parts of the old code use 4 SPACE, other parts use 2 SPACE, but the Styple was not enforced tha hard in the old days. So next time I will convert d3dxof to 4 spaces and see what happens to the patch. ;-) I suggest to ask Julliard before you start with that. He might exceptional accept that style changes only Patch, as you did the major part of the code in that dll. -- By by ... Detlef
Re: mciqtz32: Implement driver messages
On Sa, 2009-03-28 at 11:48 +0100, Christian Costa wrote:
Thanks for working on this part of Wine.
+/**
+ * MCIAVI_drvClose [internal]
+ */
+static DWORD MCIQTZ_drvClose(DWORD dwDevID)
+{
With greetings from copy paste:
There is no need to fix the MCIAVI != MCIQTZ mismatch in a second Patch.
Fix it here, when you add the code.
You use TAB in the comments and also in the Code.
Don't do that.
--
By by ... Detlef
Re: mciqtz32: Add basic play capability
On Sa, 2009-03-28 at 16:36 +0100, Christian Costa wrote:
+hr = CoCreateInstance(CLSID_FilterGraph, NULL,
CLSCTX_INPROC_SERVER, IID_IGraphBuilder, (LPVOID*)wma-pgraph);
+if (FAILED(hr)) {
+TRACE(Cannot create filtergraph (hr = %x)\n, hr);
+ return MCIERR_INTERNAL;
+}
Again TABs in the Code.
+
+hr = IGraphBuilder_QueryInterface(wma-pgraph,
IID_IMediaControl, (LPVOID*)wma-pmctrl);
+if (FAILED(hr)) {
+ TRACE(Cannot get IMediaControl interface (hr = %x)\n, hr);
+return MCIERR_INTERNAL;
TAB again.
And while i read this quote: You leak wma-pmctrl here.
--
By by ... Detlef
Re: mciqtz32: Implement driver messages
On So, 2009-03-29 at 12:50 +0200, Christian Costa wrote: There are some discrepancies in the indentation and I don't mind removing tabs but what's wrong with them, they are commonly use in wine depending on one's taste. Wine use 4 SPACE for indention. There is old code that use 2 or 3 SPACE, some old locations use TAB (width 8) and also some locations with TAB and SPACE mixed can be found. The rule is to stay with the same style as used in the file before (2, 3 or 4 SPACE), but never mix SPACE and TAB in touched lines. For new files, there is no old style to cover with, so 4 SPACE indention is expected. -- By by ... Detlef
Re: Vacations
On Fr, 2009-03-13 at 20:05 +0100, Alexandre Julliard wrote: Folks, There won't be any commits next week, as I'll be skiing... Have fun and take care -- By by ... Detlef
Re: [imaadp32 2/3] fixed adpcm_FormatSuggest
On Fr, 2009-02-27 at 20:07 +0100, Stefano Guidoni wrote: case WAVE_FORMAT_IMA_ADPCM: -adfs-pwfxDst-nBlockAlign = 1024; + init_wfx_ima_adpcm((IMAADPCMWAVEFORMAT*)adfs-pwfxDst); /* FIXME: not handling header overhead */ TRACE(setting spb=%u\n, ((IMAADPCMWAVEFORMAT*)adfs-pwfxDst)-wSamplesPerBlock); + /* check if result is ok */ +if (ADPCM_GetFormatIndex(adfs-pwfxDst) == 0x) return ACMERR_NOTPOSSIBLE; break; While reading the diff, it's visible, that you screw the indention up. (Mix SPACE and TAB) -- By by ... Detlef
Re: msi: Add reinstall tests.
On Do, 2009-02-26 at 10:50 +0100, Hans Leidekker wrote: +state = 0xdeadbee; +action = 0xdeadbee; +r = MsiGetFeatureState(hpkg, one, state, action); +ok( r == ERROR_UNKNOWN_FEATURE, Expected ERROR_UNKNOWN_FEATURE, got %d\n, r ); +ok( state == 0xdeadbee, Expected 0xdeadbee, got %d\n, state); +ok( action == 0xdeadbee, Expected 0xdeadbee, got %d\n, action); + +state = 0xdeadbee; +action = 0xdeadbee; +r = MsiGetFeatureState(hpkg, two, state, action); +ok( r == ERROR_UNKNOWN_FEATURE, Expected ERROR_UNKNOWN_FEATURE, got %d\n, r ); +ok( state == 0xdeadbee, Expected 0xdeadbee, got %d\n, state); +ok( action == 0xdeadbee, Expected 0xdeadbee, got %d\n, action); + +state = 0xdeadbee; +action = 0xdeadbee; +r = MsiGetFeatureState(hpkg, three, state, action); +ok( r == ERROR_UNKNOWN_FEATURE, Expected ERROR_UNKNOWN_FEATURE, got %d\n, r ); +ok( state == 0xdeadbee, Expected 0xdeadbee, got %d\n, state); +ok( action == 0xdeadbee, Expected 0xdeadbee, got %d\n, action); This is huge amount of almost the same code in that test. Please use tables. -- By by ... Detlef
Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.
On Mo, 2009-02-23 at 13:38 +0100, Paul Vriens wrote: Is .NET installed (any version)? My w2k test box has the popup about the missing gdiplus and dotnet is installed. From the dllinfo: gdiplus load error 1359 http://test.winehq.org/data/79cc4163fa4867ce0b28ce83111dc6bc18d3df15/2000_dr-asus/dllinfo.html -- By by ... Detlef
fusion/tests: [Patch 1/2] Do not use an hardcoded path for the windows directory
On Do, 2009-02-19 at 16:21 -0800, James Hawkins wrote: On Thu, Feb 19, 2009 at 4:14 PM, Detlef Riekenberg wine@web.de wrote: James: A fixed path is broken by design. A Thanks for spending weeks of your time laboriously testing and implementing fusion would have sufficed. James, I have no Idea, what fusion is supposed to do, but thanks for working on that part of Wine. Nicolas, i missed your Patch. Thanks for working on Wine. Attached is a Patch for the other use of c:\windows in that file. To All: Hardcoding c:\windows is broken by design, since that path can be changed during installation of Windows and even the default path is different in some Windows versions. (c:\WinNT on w2k as example) -- By by ... Detlef 0001-fusion-tests-Do-not-use-an-hardcoded-path-for-the-w.patch Description: application/mbox
Re: WINEGATE.DLL: Wine gateway to native Unix libraries
On So, 2009-02-15 at 01:02 +0100, Martin Hinner wrote: - It's already present in Wine: libwine.dll has exports for wine_dlopen/wine_dlclose/wine_dlsym please read: libs/wine/loader.c I saw it, but I don't understand how is it exported to the Win32 world, i.e. how do I import these using GetProcAddress() Win32 API ? As I already mentioned: libwine.dll has exports for wine_dlopen/wine_dlclose/wine_dlsym Just use this infos: hdll = LoadLibraryA(libwine.dll); wine_dlopen = GetProcAdress(hdll, wine_dlopen); wine_dlsym = GetProcAdress(hdll, wine_dlsym); wine_dlclose = GetProcAdress(hdll, wine_dlclose); Keep attention on the calling convention. find /usr/src/wine* -name '*.spec' | xargs -n 10 grep dlopen did not reveal anything except winegate.dll :-). A *.spec is used as input for winebuild to build a *.def. Keep it as simple as possible and use only grep: grep -r dlopen wine-source/libs/ You find the exported functions in libs/wine/wine.def -- By by ... Detlef
