[wp-testers] Missing ? tag in wp-config.sample.php
I found a minor glitch in the in the WP 3.0 nightlies in that the ? tag is missing from the bottom of the wp-config.sample.php file. Although it doesn't seem to affect functionality (I ran like that for several days on a test install) it really should be there. Unless something I don't understand has changed? Just FYI. ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
the closing ? tag at the end of a PHP file isn't necessary. By leaving it out, you also get the added benefit of not accidentally putting a space or linebread after it, causing the headers already sent error. -- Nathan Rice WordPress and Web Development www.nathanrice.net | twitter.com/nathanrice On Tue, Apr 13, 2010 at 10:10 AM, Kirk M kmb4...@gmail.com wrote: I found a minor glitch in the in the WP 3.0 nightlies in that the ? tag is missing from the bottom of the wp-config.sample.php file. Although it doesn't seem to affect functionality (I ran like that for several days on a test install) it really should be there. Unless something I don't understand has changed? Just FYI. ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
On Tue, Apr 13, 2010 at 9:10 AM, Kirk M kmb4...@gmail.com wrote: I found a minor glitch in the in the WP 3.0 nightlies in that the ? tag is missing from the bottom of the wp-config.sample.php file. Although it doesn't seem to affect functionality (I ran like that for several days on a test install) it really should be there. Unless something I don't understand has changed? It is not required and intentionally left out. We try to leave it off of files that users will be editing so that they do not create extra blank lines after the ? and cause 'headers already sent' notices to occur. -- Matt Martz m...@sivel.net http://sivel.net/ ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
Thanks for the reply. Just for my own info, I distinctly remember the closing tag being there before and I tend to update the wp-config.php file every time a new WP version changes it. Was there a time when the closing tag was present? Just to make sure I'm not losing my mind. :D On 04/13/2010 10:13 AM, Nathan Rice wrote: the closing ? tag at the end of a PHP file isn't necessary. By leaving it out, you also get the added benefit of not accidentally putting a space or linebread after it, causing the headers already sent error. -- Nathan Rice WordPress and Web Development www.nathanrice.net | twitter.com/nathanrice On Tue, Apr 13, 2010 at 10:10 AM, Kirk Mkmb4...@gmail.com wrote: I found a minor glitch in the in the WP 3.0 nightlies in that the ? tag is missing from the bottom of the wp-config.sample.php file. Although it doesn't seem to affect functionality (I ran like that for several days on a test install) it really should be there. Unless something I don't understand has changed? Just FYI. ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
I don't think WordPress changes the wp-config.php file on update. Anyway, I wouldn't pay so much attention to it. -- http://scribu.net ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
Nope, they don't change the wp-config.php file but they do occasionally update the wp-config.sample.php file as needed (security, new functions, changes in absolute paths, etc--not many changes but some) and it's up to the website owner to manually update their wp-config.php file accordingly. On 04/13/2010 02:36 PM, scribu wrote: I don't think WordPress changes the wp-config.php file on update. Anyway, I wouldn't pay so much attention to it. ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
How do we know when to manually update? AndrewJohnson and...@aequ.com 580.302.0931 On Apr 13, 2010, at 1:43 PM, Kirk M wrote: Nope, they don't change the wp-config.php file but they do occasionally update the wp-config.sample.php file as needed (security, new functions, changes in absolute paths, etc--not many changes but some) and it's up to the website owner to manually update their wp-config.php file accordingly. On 04/13/2010 02:36 PM, scribu wrote: I don't think WordPress changes the wp-config.php file on update. Anyway, I wouldn't pay so much attention to it. ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
On Tue, Apr 13, 2010 at 2:43 PM, Kirk M kmb4...@gmail.com wrote: it's up to the website owner to manually update their wp-config.php file accordingly. I'd rather not say it like that, though, because then you get questions like How do we know when to manually update? :-) We've added new default constants such as keys and salts (there are eight in all) over the years, so that's one thing to check. (We also highly publicized those when we released the versions they were first included in.) Beyond that, there have been no real changes. It's still just the DB constants, language, table prefix, and the conditional ABSPATH define (which is actually only there for backwards compatibility). In 3.0, we also added a reference to WP_DEBUG, simply to raise its profile among plugin developers. There are also scores of other optional constants that control other deeper aspects of WordPress such as moving the wp-content, uploads or plugins directories or various cookie constants. If you installed your blog before 2.6 or so, I'd check to see if you ever added the salt and key constants. Otherwise, just upgrade everything around it. ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
i run am running 3.0b1 on a debian server that was installed using apt-get. its install architecture is considerably different from the 5min install. the latest version of wordpress in my debian repository is 2.0.12. my debian wp-config.php is debian specific and warns against changes to it. if wp-config were to be update by and upgrade it would most likely break my install. subsequent to my wp-config being off limits to alter changes normally made there are made in a file called wp-settings.php which is called by wp-config.php. so far the only change i have made in wp-settings is when i wanted to activate the mu functions for 3.0b1. despite lack of clarity on when wp-config.php should be updated. its better for me that it is never updated. a corollary given by andrew is that i will continue to be able to upgrade my wp install as long as wp-config.php continues to be untouched by updates. On Tue, Apr 13, 2010 at 12:12 PM, Andrew Nacin w...@andrewnacin.com wrote: On Tue, Apr 13, 2010 at 2:43 PM, Kirk M kmb4...@gmail.com wrote: it's up to the website owner to manually update their wp-config.php file accordingly. I'd rather not say it like that, though, because then you get questions like How do we know when to manually update? :-) We've added new default constants such as keys and salts (there are eight in all) over the years, so that's one thing to check. (We also highly publicized those when we released the versions they were first included in.) Beyond that, there have been no real changes. It's still just the DB constants, language, table prefix, and the conditional ABSPATH define (which is actually only there for backwards compatibility). In 3.0, we also added a reference to WP_DEBUG, simply to raise its profile among plugin developers. There are also scores of other optional constants that control other deeper aspects of WordPress such as moving the wp-content, uploads or plugins directories or various cookie constants. If you installed your blog before 2.6 or so, I'd check to see if you ever added the salt and key constants. Otherwise, just upgrade everything around it. ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers -- -af http://alonzofretwell.com http://twitter.com/alonzofretwell ,___, [O.o] /)__) ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
On Tue, Apr 13, 2010 at 3:33 PM, alonzo fretwell alonzofretw...@gmail.com wrote: so far the only change i have made in wp-settings is when i wanted to activate the mu functions for 3.0b1. I imagine you mean wp-config there? wp-settings is a core file and should never [need to] be modified. You should be activating multisite in wp-config. a corollary given by andrew is that i will continue to be able to upgrade my wp install as long as wp-config.php continues to be untouched by updates. It can be safely said that we'll never touch wp-config.php by updates. ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
On Tue, Apr 13, 2010 at 9:13 AM, Nathan Rice ncr...@gmail.com wrote: the closing ? tag at the end of a PHP file isn't necessary. Yes, it is best to leave it out UNLESS it causes bug reports. However, people new to PHP often assume that PHP tags must be balanced. Instead of verifying their assumption they call attention to the issue. This is understandable (we've all been there) so I have another solution: You can add a comment to the end of the file: /* PHP does not require a closing tag (?) at the end of a script. Actually it's safer this way, as you are less likely to break your site. You see, blank lines after the closing tag cause PHP to send the headers. It has to send them before the first byte of the response can be sent. Later, WordPress tries to send headers and PHP throws a warning. So the omitted ? is not a bug; don't email anybody about it. However, it is necessary to close this comment to avoid an even worse error so we'll do that now. */ Andy ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
on my debian etch install wp-config.php contains the following warning at the top of the file... /** WordPress's Debianised default master config file Please do NOT edit and read about how the configuration works in the README.Debi an **/ wp-settings does not. On Tue, Apr 13, 2010 at 12:39 PM, Andrew Nacin w...@andrewnacin.com wrote: On Tue, Apr 13, 2010 at 3:33 PM, alonzo fretwell alonzofretw...@gmail.com wrote: so far the only change i have made in wp-settings is when i wanted to activate the mu functions for 3.0b1. I imagine you mean wp-config there? wp-settings is a core file and should never [need to] be modified. You should be activating multisite in wp-config. a corollary given by andrew is that i will continue to be able to upgrade my wp install as long as wp-config.php continues to be untouched by updates. It can be safely said that we'll never touch wp-config.php by updates. ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers -- -af http://alonzofretwell.com http://twitter.com/alonzofretwell ,___, [O.o] /)__) ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
Whoops, didn't mean to start something. :-) Of course, I started way back when manual installing/upgrading was the only way to get things done so old habits die hard and all that. On 04/13/2010 03:12 PM, Andrew Nacin wrote: On Tue, Apr 13, 2010 at 2:43 PM, Kirk Mkmb4...@gmail.com wrote: it's up to the website owner to manually update their wp-config.php file accordingly. I'd rather not say it like that, though, because then you get questions like How do we know when to manually update? :-) We've added new default constants such as keys and salts (there are eight in all) over the years, so that's one thing to check. (We also highly publicized those when we released the versions they were first included in.) Beyond that, there have been no real changes. It's still just the DB constants, language, table prefix, and the conditional ABSPATH define (which is actually only there for backwards compatibility). In 3.0, we also added a reference to WP_DEBUG, simply to raise its profile among plugin developers. There are also scores of other optional constants that control other deeper aspects of WordPress such as moving the wp-content, uploads or plugins directories or various cookie constants. If you installed your blog before 2.6 or so, I'd check to see if you ever added the salt and key constants. Otherwise, just upgrade everything around it. ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
i like michael jackson's work too. On Tue, Apr 13, 2010 at 12:56 PM, Kirk M kmb4...@gmail.com wrote: Whoops, didn't mean to start something. :-) Of course, I started way back when manual installing/upgrading was the only way to get things done so old habits die hard and all that. On 04/13/2010 03:12 PM, Andrew Nacin wrote: On Tue, Apr 13, 2010 at 2:43 PM, Kirk Mkmb4...@gmail.com wrote: it's up to the website owner to manually update their wp-config.php file accordingly. I'd rather not say it like that, though, because then you get questions like How do we know when to manually update? :-) We've added new default constants such as keys and salts (there are eight in all) over the years, so that's one thing to check. (We also highly publicized those when we released the versions they were first included in.) Beyond that, there have been no real changes. It's still just the DB constants, language, table prefix, and the conditional ABSPATH define (which is actually only there for backwards compatibility). In 3.0, we also added a reference to WP_DEBUG, simply to raise its profile among plugin developers. There are also scores of other optional constants that control other deeper aspects of WordPress such as moving the wp-content, uploads or plugins directories or various cookie constants. If you installed your blog before 2.6 or so, I'd check to see if you ever added the salt and key constants. Otherwise, just upgrade everything around it. ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers -- -af http://alonzofretwell.com http://twitter.com/alonzofretwell ,___, [O.o] /)__) ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
Re: [wp-testers] Missing ? tag in wp-config.sample.php
An excellent explanation, Andy...thanks! Obviously I've been one of those PHP must be balanced type folks. Didn't know about the blank lines under the closing tag either. I need to mark this particular message in my email for reference for when my old(er) brain fails to recall this correctly. Happens more and more often these days. :P I'll also add the comment in my wp-config.php file like you suggested. On 04/13/2010 03:48 PM, Andy Skelton wrote: On Tue, Apr 13, 2010 at 9:13 AM, Nathan Ricencr...@gmail.com wrote: the closing ? tag at the end of a PHP file isn't necessary. Yes, it is best to leave it out UNLESS it causes bug reports. However, people new to PHP often assume that PHP tags must be balanced. Instead of verifying their assumption they call attention to the issue. This is understandable (we've all been there) so I have another solution: You can add a comment to the end of the file: /* PHP does not require a closing tag (?) at the end of a script. Actually it's safer this way, as you are less likely to break your site. You see, blank lines after the closing tag cause PHP to send the headers. It has to send them before the first byte of the response can be sent. Later, WordPress tries to send headers and PHP throws a warning. So the omitted ? is not a bug; don't email anybody about it. However, it is necessary to close this comment to avoid an even worse error so we'll do that now. */ Andy ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers ___ wp-testers mailing list wp-testers@lists.automattic.com http://lists.automattic.com/mailman/listinfo/wp-testers
