Re: [wxlua-users] Superfluous condition in scribble.wx.lua?
On Tue, Aug 13, 2013 at 9:01 AM, Andreas Falkenhahn andr...@falkenhahn.comwrote: Hi, there is the following code in scribble.wx.lua: if colourWin:GetToolTip() ~= s then colourWin:SetToolTip(s) end But AFAICS, wxWindow::GetToolTip() will never return a string, but will always push a value of type userdata on the stack. Thus, the condition check is superfluous because it is always TRUE and SetToolTip() will always be called. Good eye, you're right, fixed in SVN, thanks. John -- Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with 2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk___ wxlua-users mailing list wxlua-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wxlua-users
Re: [wxlua-users] Bug in wxImage::SetAlphaData()?
On Tue, Aug 13, 2013 at 11:26 AM, Andreas Falkenhahn andr...@falkenhahn.com wrote: Hi, in the override function for wxImage::SetAlpha() in wxcore_override.hpp there is the following code: size_t size = 3*self-GetWidth()*self-GetHeight(); memcpy(self-GetData(), data, wxMin(len, size)); I think this is wrong because alpha channel data is only one byte per pixel. Fixed in SVN, thanks! John -- Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with 2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk___ wxlua-users mailing list wxlua-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wxlua-users
