[X2Go-Dev] Bug#1000: [PATCH 1/1] sshmasterconnection.cpp: invalid proxy socket
Package: x2goclient
Version: 4.0.5.1
x2goclient shows proxy socket -1 (invalid).
http://doc.qt.io/qt-4.8/qabstractsocket.html#socketDescriptor:
The socket descriptor is not available when QAbstractSocket is in
UnconnectedState.
So we have first to connect to the proxy server before retrieving the
native socket.
Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
---
src/sshmasterconnection.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sshmasterconnection.cpp b/src/sshmasterconnection.cpp
index 5b3cff5..bb69047 100644
--- a/src/sshmasterconnection.cpp
+++ b/src/sshmasterconnection.cpp
@@ -548,7 +548,6 @@ void SshMasterConnection::run()
tcpProxySocket = new QTcpSocket();
tcpProxySocket->setProxy( *tcpNetworkProxy );
tcpProxySocket->connectToHost(host, port);
-proxysocket = tcpProxySocket->socketDescriptor();
if (!tcpProxySocket->waitForConnected(3))
{
QString message=tr ( "Cannot connect to proxy server." );
@@ -560,6 +559,7 @@ void SshMasterConnection::run()
quit();
return;
}
+proxysocket = tcpProxySocket->socketDescriptor();
#ifdef DEBUG
x2goDebug << "Created HTTP proxy socket: " << proxysocket << endl;
#endif
--
2.1.4
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#924: Performance x2golistsession
Package: x2goserver Severity: normal I am running x2goserver 4.0.1.9 on an EdgeRouter Lite with a dual core 500 MHz dual Octeon CPU. I looked at the CPU time consumption while no x2go session was active. ps -A shows the following processes. 609 ?00:00:02 x2gocleansessio 11923 ?00:00:01 x2golistsession 11930 ?00:00:01 x2gosqlitewrapp 609 is the parent 11923, 11930 are children with varying PID. These 3 processes are shown in program top often as major CPU consumers. After 4700 s uptime x2gocleansession has used 2041 s CPU time spent in user code, including time from children 538 s CPU time spent in kernel code, including time from children Why is x2golistsession eating up 25% of the available CPU? Best regards Heinrich Schuchardt Debian Jessie mips Kernel 4.1.3 #10 SMP PREEMPT mips64 GNU/Linux ./libnx-mesa-extras-dev_3.5.0.32-0x2go1.1_mips.deb ./libnx-x11_3.5.0.32-0x2go1.1_mips.deb ./libnx-x11-6_3.5.0.32-0x2go1.1_mips.deb ./libnx-x11-6-dbg_3.5.0.32-0x2go1.1_mips.deb ./libnx-x11-dev_3.5.0.32-0x2go1.1_mips.deb ./libnx-xau6_3.5.0.32-0x2go1.1_mips.deb ./libnx-xau6-dbg_3.5.0.32-0x2go1.1_mips.deb ./libnx-xau-dev_3.5.0.32-0x2go1.1_mips.deb ./libnx-xcomposite1_3.5.0.32-0x2go1.1_mips.deb ./libnx-xcomposite1-dbg_3.5.0.32-0x2go1.1_mips.deb ./libnx-xcomposite-dev_3.5.0.32-0x2go1.1_mips.deb ./libnx-xdamage1_3.5.0.32-0x2go1.1_mips.deb ./libnx-xdamage1-dbg_3.5.0.32-0x2go1.1_mips.deb ./libnx-xdamage-dev_3.5.0.32-0x2go1.1_mips.deb ./libnx-xdmcp6_3.5.0.32-0x2go1.1_mips.deb ./libnx-xdmcp6-dbg_3.5.0.32-0x2go1.1_mips.deb ./libnx-xdmcp-dev_3.5.0.32-0x2go1.1_mips.deb ./libnx-xext6_3.5.0.32-0x2go1.1_mips.deb ./libnx-xext6-dbg_3.5.0.32-0x2go1.1_mips.deb ./libnx-xext-dev_3.5.0.32-0x2go1.1_mips.deb ./libnx-xfixes3_3.5.0.32-0x2go1.1_mips.deb ./libnx-xfixes3-dbg_3.5.0.32-0x2go1.1_mips.deb ./libnx-xfixes-dev_3.5.0.32-0x2go1.1_mips.deb ./libnx-xinerama1_3.5.0.32-0x2go1.1_mips.deb ./libnx-xinerama1-dbg_3.5.0.32-0x2go1.1_mips.deb ./libnx-xinerama-dev_3.5.0.32-0x2go1.1_mips.deb ./libnx-xpm4_3.5.0.32-0x2go1.1_mips.deb ./libnx-xpm4-dbg_3.5.0.32-0x2go1.1_mips.deb ./libnx-xpm-dev_3.5.0.32-0x2go1.1_mips.deb ./libnx-xrandr2_3.5.0.32-0x2go1.1_mips.deb ./libnx-xrandr2-dbg_3.5.0.32-0x2go1.1_mips.deb ./libnx-xrandr-dev_3.5.0.32-0x2go1.1_mips.deb ./libnx-xrender1_3.5.0.32-0x2go1.1_mips.deb ./libnx-xrender1-dbg_3.5.0.32-0x2go1.1_mips.deb ./libnx-xrender-dev_3.5.0.32-0x2go1.1_mips.deb ./libnx-xtst6_3.5.0.32-0x2go1.1_mips.deb ./libnx-xtst6-dbg_3.5.0.32-0x2go1.1_mips.deb ./libnx-xtst-dev_3.5.0.32-0x2go1.1_mips.deb ./libxcomp3_3.5.0.32-0x2go1.1_mips.deb ./libxcomp3-dbg_3.5.0.32-0x2go1.1_mips.deb ./libxcomp-dev_3.5.0.32-0x2go1.1_mips.deb ./libxcompext3_3.5.0.32-0x2go1.1_mips.deb ./libxcompext3-dbg_3.5.0.32-0x2go1.1_mips.deb ./libxcompext-dev_3.5.0.32-0x2go1.1_mips.deb ./libxcompshad3_3.5.0.32-0x2go1.1_mips.deb ./libxcompshad3-dbg_3.5.0.32-0x2go1.1_mips.deb ./libxcompshad-dev_3.5.0.32-0x2go1.1_mips.deb ./nxagent_3.5.0.32-0x2go1.1_mips.deb ./nxagent-dbg_3.5.0.32-0x2go1.1_mips.deb ./nxauth_3.5.0.32-0x2go1.1_mips.deb ./nxauth-dbg_3.5.0.32-0x2go1.1_mips.deb ./nxproxy_3.5.0.32-0x2go1.1_mips.deb ./nxproxy-dbg_3.5.0.32-0x2go1.1_mips.deb ./nx-x11-common_3.5.0.32-0x2go1.1_all.deb ./nx-x11proto-composite-dev_3.5.0.32-0x2go1.1_mips.deb ./nx-x11proto-core-dev_3.5.0.32-0x2go1.1_mips.deb ./nx-x11proto-damage-dev_3.5.0.32-0x2go1.1_mips.deb ./nx-x11proto-randr-dev_3.5.0.32-0x2go1.1_mips.deb ./nx-x11proto-render-dev_3.5.0.32-0x2go1.1_mips.deb ./nx-x11proto-xext-dev_3.5.0.32-0x2go1.1_mips.deb ./nx-x11proto-xfixes-dev_3.5.0.32-0x2go1.1_mips.deb ./nx-x11proto-xinerama-dev_3.5.0.32-0x2go1.1_mips.deb ./x2goagent_3.5.0.32-0x2go1.1_all.deb ./x2goserver_4.0.1.9-0x2go1.1_mips.deb ./x2goserver-compat_4.0.1.9-0x2go1.1_all.deb ./x2goserver-extensions_4.0.1.9-0x2go1.1_all.deb ./x2goserver-fmbindings_4.0.1.9-0x2go1.1_all.deb ./x2goserver-printing_4.0.1.9-0x2go1.1_all.deb ./x2goserver-pyhoca_4.0.1.9-0x2go1.1_all.deb ./x2goserver-xsession_4.0.1.9-0x2go1.1_all.deb ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#777: Bug#777: nx-libs: incorrect usage of scanf
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Squeeze reached end of life.
Package libc6 in wheezy is patched against the bug.
Package libc6 in jessie is not vulnerable as it uses a newer libc6
release.
So I think we should close this bug and concentrate on updating our
mesa code to the newest version instead of patching some old version.
Best regards
Heinrich
On 31.01.2015 16:04, Mike Gabriel wrote:
Hi Heinrich,
On Fr 30 Jan 2015 20:35:53 CET, Heinrich Schuchardt wrote:
package: nx-libs version: head
In different parts of the nx-libs library you can find usages of
scanf like
/* check for MESA_GAMMA environment variable */ gamma =
_mesa_getenv(MESA_GAMMA); if (gamma) { v-RedGamma =
v-GreenGamma = v-BlueGamma = 0.0; sscanf( gamma, %f %f %f,
v-RedGamma, v-GreenGamma, v-BlueGamma );
According to cppcheck:
scanf without field width limits can crash with huge input data
on libc versions older than 2.13-25. Add a field width specifier
to fix this problem: %i = %3i
Any chance you could also provide a patch for this?
Mike
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
iQIcBAEBAgAGBQJUz+CVAAoJEMSB27wsBRrE4mUP/j3JjSvGQ6chMdlCaQd94Ar6
LIBJvEeS9ZiR/rgFFaXdqUMzZVzYs2bm4Vvp0LlY9iUVFbhCgKQimRhLVq26A1iT
5EtJOFRu51Fzrd1y6Nk00PBKCqbsWSJwI81TUKnckjaCo3QyobWyMqqI75eXjMSf
RSWIGWgtLznPMqvByoKEnndDQjrCBBeMPBF7sinBw5ZM994Ff9VobHv7vXUYwvrY
mXlIgiuVf/6ztFTnwCsDD1hRreOk4BBTgp4tPsVqwB/06l8OvnaeBfD35BOSJ8Ns
AKwbxeRSNFOS4UP01zAgAsTMblzabyKnzS57lGomYQp3RB8c3K9DyUnk6CVSlBlN
AI7fjnaQEW9qL4d8UBRsQlZ7b9vryavNtUY7UyPtVMuXXA0WaewZIGUUpI5odtvd
WAoe0DEY2i+dW3ByIuGC1mH7ujgSLZGuke1gGdODlaLiExDsmm5P6hmIv+xE9gNQ
RBk5pYSx3H75Hckm2yTxhNx/9NcwJbjHa1pwa8Lz6r63/Ssa6TQhxuGsFH2l49iZ
YYbLHEP1s0FKQWxtE1B3NOYLeOwiCP4l7+qJ/KUZnmGCep2L4xC88OP1WMPn4+t6
vfoGkAHr9x0Ii7eP7fFaBEpImlx6dWI9mtZcSRfKfq/OhjAQPMspv7rl149i+1Iu
8OfiW4rp02zs54r92ejJ
=2gk9
-END PGP SIGNATURE-
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#776: nx-X11: Size of pointer 'server_support' used instead of size of its data
The appended patch
From: Ian Romanick i...@us.ibm.com
Date: Thu, 13 Jul 2006 15:27:37 +
Subject: [PATCH] Move initialization of server_support from
__glXProcessServerString to __glXCalcualteUsableExtensions.
should solve the problem. I adjusted the file path to make it applicable
to x2go.
Cf.
https://bugs.freedesktop.org/show_bug.cgi?id=7353
The patch dates from *** 2006 ***. We definitely should rebase the mesa
code.
Best regards
Heinrich Schuchardt
From 7ef4a07165d49e671f6f569ee87bfe893b1e7fcf Mon Sep 17 00:00:00 2001
From: Ian Romanick i...@us.ibm.com
Date: Thu, 13 Jul 2006 15:27:37 +
Subject: [PATCH] Move initialization of server_support from
__glXProcessServerString to __glXCalcualteUsableExtensions. By having both
callers of __glXProcessServerString initialize the bit-fields passed in, we
guarantee that the correct amount of data is initialized:
This fixes bugzilla #7353.
---
nx-X11/extras/Mesa/src/glx/x11/glxextensions.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/nx-X11/extras/Mesa/src/glx/x11/glxextensions.c b/nx-X11/extras/Mesa/src/glx/x11/glxextensions.c
index c3bc930..d00bdbb 100644
--- a/nx-X11/extras/Mesa/src/glx/x11/glxextensions.c
+++ b/nx-X11/extras/Mesa/src/glx/x11/glxextensions.c
@@ -319,6 +319,11 @@ set_glx_extension( const struct extension_info * ext,
*
* \param server_string GLX extension string from the server.
* \param server_support Bit-field of supported extensions.
+ *
+ * \note
+ * This function is used to process both GLX and GL extension strings. The
+ * bit-fields used to track each of these have different sizes. Therefore,
+ * the data pointed by \c server_support must be preinitialized to zero.
*/
static void
__glXProcessServerString( const struct extension_info * ext,
@@ -328,8 +333,6 @@ __glXProcessServerString( const struct extension_info * ext,
unsigned base;
unsigned len;
- (void) memset( server_support, 0, sizeof( server_support ) );
-
for ( base = 0 ; server_string[ base ] != NUL ; /* empty */ ) {
/* Determine the length of the next extension name.
*/
@@ -580,6 +583,8 @@ __glXCalculateUsableExtensions( __GLXscreenConfigs *psc,
__glXExtensionsCtr();
__glXExtensionsCtrScreen( psc );
+
+ (void) memset( server_support, 0, sizeof( server_support ) );
__glXProcessServerString( known_glx_extensions,
psc-serverGLXexts, server_support );
--
2.1.4
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#777: nx-libs: incorrect usage of scanf
package: nx-libs
version: head
In different parts of the nx-libs library you can find usages of scanf like
/* check for MESA_GAMMA environment variable */
gamma = _mesa_getenv(MESA_GAMMA);
if (gamma) {
v-RedGamma = v-GreenGamma = v-BlueGamma = 0.0;
sscanf( gamma, %f %f %f, v-RedGamma, v-GreenGamma,
v-BlueGamma );
According to cppcheck:
scanf without field width limits can crash with huge input data on libc
versions older than 2.13-25. Add a field width specifier to fix this
problem:
%i = %3i
Best regards
Heinrich Schuchardt
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#776: nx-X11: Size of pointer 'server_support' used instead of size of its data
package: nx-libs
version: head
In nx-libs/nx-X11/extras/Mesa/src/glx/x11/glxextensions.c
the length of the zeroed memory is the length of the pointer (4 bytes in
case of a 32bit system) not the length of the data the pointer points to
(8 byte).
static void
__glXProcessServerString( const struct extension_info * ext,
const char * server_string,
unsigned char * server_support )
{
unsigned base;
unsigned len;
(void) memset( server_support, 0, sizeof( server_support ) );
Furthermore the length of the memory area pointed to by server_support
is defined in varying ways in the coding:
#define __GL_EXT_BYTES ((__NUM_GL_EXTS + 7) / 8)
unsigned char server_support[ __GL_EXT_BYTES ];
unsigned char server_support[8];
Currently __NUM_GL_EXTS = 123, so __GL_EXT_BYTES = 8.
What is expected to happen if __GL_EXT_BYTES 8 after defining six more
values in the unamed (sic!) enum with the different bits?
This questionable code was identified with cppcheck.
http://cppcheck.sourceforge.net/
Best regards
Heinrich Schuchardt
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#644: x2goserver : The $SSH_CLIENT environment variable is not set
Hello Franz, In #628 you wrote But when I say # apt-get download x2goclient I get x2goclient_3.99.2.1-5_armhf.deb And this version makes a lot of problems with an X2goserver 4.0.1.16. It remains unclear in #644 if you are still trying to use client 3.99.2.1-5_armhf.deb. Please, provide both for x2goserver and x2goclient the version, the architecture, the Linux distribution, and the apt repository you are using. Best regards Heinrich Schuchardt ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Build infrastructure for armhf
On 10.01.2015 00:52, Mike Gabriel wrote: Hi Heinrich, On Fr 09 Jan 2015 21:59:06 CET, Heinrich Schuchardt wrote: Henning Heinold and I are currently setting up an armhf task force. Would you be willing to join in? Mike Yes, I would like to contribute to the armhf task force. The idea is to use our X2Go buildscripts [1] (i.e. build-deb-package) for building armhf packages. Could you, please, consider the patch in http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=712 This is a prerequisite for building on armhf. Packages should be built every night, cf. http://wiki.x2go.org/doku.php/wiki:development:nightly-builds There are more than 20 distributions for which the build has to occur. How do you handle this plethora. Do you use one machine per distribution or do you use multiple chroots on the same machine? Question to you, can you contribute amd64 hardware (for qemubuilder) where those build processes can run on (as Jenkins slaves)? Alternatively, can you provide physical hardware? My experience with emulating mips and arm64 using qemu is that it is much slower than physical hardware. I expect the same for armhf. Is is necessary to use qemu or could also armhf servers be integrated as Jenkins slaves? Depending on your answers, we should set up such a box at your place or extend the build env on japsand.x2go.org. If I would host build servers I would not be able to provide external access. If I donate hardware, should it be prepared for 19 rack mounting? Cf. http://cubieboard.org/2014/02/18/cubieboard-colocation-service-named-cubiebox-first-launched-in-france/ Typically an armhf machine cost less than a hard disk. Should build machines have their own disk or would iSCSI be an option? I understand that you are interested in Ubuntu builds (whereas others are interested in Debian or Raspian builds). My main focus is on Debian. Maybe we should put up a wiki page or something for collecting the demands and the options/possibilities we have. Wiki would be fine. Could could provide an account for me (preferred user name Xypron). Will you set up an armhf list on lists.x2go.org? Or shall we use x2go-dev? If we go the amd64 + qemubuilder approach, does anyone have a recent armhf kernel that runs in qemu and can handle a Debian sid, or latest Ubuntu? I will setup a Debian image and describe the procedure. I would love to avoid stuffing non-native build jobs on japsand.x2go.org, as the machine also acts as our webserver (in a chroot). To many build load will block our wiki from being responsive (which we want to avoid). Best regards Heinrich Schuchardt ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#713: [PATCH 1/1] Bug 713: layout of status dialogue
On KDE setting the screen resolution to values above 96 dpi leads to an incorrect layout of the status dialogue. With a value of 160 dpi some textboxes overlap. The appended patch resolves the issue. Signed-off-by: Heinrich Schuchardt xypron.g...@gmx.de --- onmainwindow.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/onmainwindow.cpp b/onmainwindow.cpp index b707d84..db9a21b 100644 --- a/onmainwindow.cpp +++ b/onmainwindow.cpp @@ -10525,6 +10525,7 @@ void ONMainWindow::initStatusDlg() layout-addWidget ( sbAdv ); layout-addStretch(); layout-addLayout ( bl ); +layout-setSizeConstraint( QLayout::SetFixedSize ); slName-show(); -- 2.1.4 ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#712: Bug#711: x2goserver: trusty armhf no package available
Henning Heinold and I are currently setting up an armhf task force. Would you be willing to join in? Mike Yes, I would like to contribute to the armhf task force. #711 is partly duplicate to #560. http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=560 Best regards Heinrich Schuchardt ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#712: Bug#711: x2goserver: trusty armhf no package available
Hello Mike, I built the missing packages and put them on repository http://debian.xypron/trusty/ (all and armhf). As build system I used a Wandboard Quad. The system used as x2go server is a Banana Pi. I did not experience any problems using the software. Best regards Heinrich Schuchardt http://www.xypron.de Am 09.01.15 um 00:06 schrieb Mike Gabriel Control: tag -1 wontfix not-a-bug Hi Heinrich, On Do 25 Dez 2014 15:10:29 CET, Heinrich Schuchardt wrote: Package: x2goserver Version: 4.0.1.9 I am running Lubuntu trusty on an armhf server. I tried to install x2goserver as described on http://wiki.x2go.org/doku.php/wiki:repositories:ubuntu I found at least the following packages are missing: x2goserver nxagent Could you, please, upload the missing packages. The X2Go upstream team does not support the armhf architecture. There currently is no build infrastructure for X2Go package for armhf. If you you have time or priority to help out, please contact me (sunweaver on IRC) and Michael DePaulo (aka Mike#2, mikedep on IRC) via #x2go on Freenode. Tagging this issue as wontfix for now... Thanks, Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#711: x2goserver: trusty armhf no package available
Package: x2goserver Version: 4.0.1.9 I am running Lubuntu trusty on an armhf server. I tried to install x2goserver as described on http://wiki.x2go.org/doku.php/wiki:repositories:ubuntu I found at least the following packages are missing: x2goserver nxagent Could you, please, upload the missing packages. Best regards Heinrich Schuchardt ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#713: x2goclient: overlapping display
Package: x2goclient Version: 4.0.3.1 My monitor is 160 dpi. I have entered this value in the KDE Systems Settings - Fonts dialogue. The layout dialogue Sitzungs ID (Session ID) which shows up when starting a connection seems to be based on pixels instead of typographic points. Some elements overlap. See appendix. The problem does not occur with 90 dpi. Please, do not use pixels for layout. Best regards Heinrich Schuchardt ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
