Re: [XeTeX] I want to commit to xetex, how to make a pull request?

2022-12-13 Thread Joseph Wright 

Ah, right.

This looks like cross-engine work, which mainly happens in the TL repo. 
It will need to be ported back to the SourceForge repo at some stage I 
guess.


Personally, I'd just use the TL repo and leave that sort of admin to 
Karl or the people with write access on the SourceForge repo.


Joseph

On 13/12/2022 11:18, Tuff Contender wrote:

Ummm stupid of me. The correct url is
https://www.tug.org/svn/texlive/trunk/Build/source/texk/web2c/xetexdir/xetex.ch?r1=55885=57724
, a commit on 2021-02-13.

On Tue, Dec 13, 2022 at 7:06 PM Joseph Wright <
joseph.wri...@morningstar2.co.uk> wrote:


On 13/12/2022 11:03, Tuff Contender wrote:

On Sat, Dec 10, 2022 at 6:22 PM Joseph Wright <
joseph.wri...@morningstar2.co.uk> wrote:


On 09/12/2022 19:07, Tuff Contender wrote:


On 08/12/2022 09:22, Tuff Contender wrote:

The code on XeTeX - Unicode-based TeX / Code / [bc89c7] (

sourceforge.net)

 seems not up

to

date, since the last modification is on 2020-01-20.
[image: image.png]
Where should I submit a merge request to?


What makes you think it's not up-to-date? (Other than some TL version
strings, I imagine this is the same code as in TL, etc.) That said,

I'd

likely look to send a patch in the first instance to TL, as it tends

to

be the place that any changes actually happen.

I viewed the page https://sourceforge.net/p/xetex/code/ci/master/tree/
and found the last change is on 2020-01-20, here's the snapshot




https://tug.org/pipermail/xetex/attachments/20221208/db8bad7f/attachment-0001.png


Sure: I only meant that as far as I know, there have been no changes in
XeTeX since them. I was wondering why you thought there might be.

Joseph

Sorry for not getting the idea.


The last significant commit in `xetex.ch` is


https://www.tug.org/svn/texlive/trunk/Build/source/texk/web2c/tex.ch?r1=63916=64547

on 2022-09-29, which is much later than the one on sf.




That's tex.ch, not xetex?

Joseph

Re: [XeTeX] I want to commit to xetex, how to make a pull request?

2022-12-13 Thread Tuff Contender 
Ummm stupid of me. The correct url is
https://www.tug.org/svn/texlive/trunk/Build/source/texk/web2c/xetexdir/xetex.ch?r1=55885=57724
, a commit on 2021-02-13.

On Tue, Dec 13, 2022 at 7:06 PM Joseph Wright <
joseph.wri...@morningstar2.co.uk> wrote:

> On 13/12/2022 11:03, Tuff Contender wrote:
> > On Sat, Dec 10, 2022 at 6:22 PM Joseph Wright <
> > joseph.wri...@morningstar2.co.uk> wrote:
> >
> >> On 09/12/2022 19:07, Tuff Contender wrote:
> 
>  On 08/12/2022 09:22, Tuff Contender wrote:
> > The code on XeTeX - Unicode-based TeX / Code / [bc89c7] (
> >> sourceforge.net)
> >  seems not up
> to
> > date, since the last modification is on 2020-01-20.
> > [image: image.png]
> > Where should I submit a merge request to?
> 
>  What makes you think it's not up-to-date? (Other than some TL version
>  strings, I imagine this is the same code as in TL, etc.) That said,
> I'd
>  likely look to send a patch in the first instance to TL, as it tends
> to
>  be the place that any changes actually happen.
> >>> I viewed the page https://sourceforge.net/p/xetex/code/ci/master/tree/
> >>> and found the last change is on 2020-01-20, here's the snapshot
> >>>
> >>
> https://tug.org/pipermail/xetex/attachments/20221208/db8bad7f/attachment-0001.png
> >>
> >> Sure: I only meant that as far as I know, there have been no changes in
> >> XeTeX since them. I was wondering why you thought there might be.
> >>
> >> Joseph
> >>
> >> Sorry for not getting the idea.
> >
> > The last significant commit in `xetex.ch` is
> >
> https://www.tug.org/svn/texlive/trunk/Build/source/texk/web2c/tex.ch?r1=63916=64547
> > on 2022-09-29, which is much later than the one on sf.
> >
> >
>
> That's tex.ch, not xetex?
>
> Joseph
>


-- 
Srik Wanar

Re: [XeTeX] I want to commit to xetex, how to make a pull request?

2022-12-13 Thread Joseph Wright 

On 13/12/2022 11:03, Tuff Contender wrote:

On Sat, Dec 10, 2022 at 6:22 PM Joseph Wright <
joseph.wri...@morningstar2.co.uk> wrote:


On 09/12/2022 19:07, Tuff Contender wrote:


On 08/12/2022 09:22, Tuff Contender wrote:

The code on XeTeX - Unicode-based TeX / Code / [bc89c7] (

sourceforge.net)

 seems not up to
date, since the last modification is on 2020-01-20.
[image: image.png]
Where should I submit a merge request to?


What makes you think it's not up-to-date? (Other than some TL version
strings, I imagine this is the same code as in TL, etc.) That said, I'd
likely look to send a patch in the first instance to TL, as it tends to
be the place that any changes actually happen.

I viewed the page https://sourceforge.net/p/xetex/code/ci/master/tree/
and found the last change is on 2020-01-20, here's the snapshot


https://tug.org/pipermail/xetex/attachments/20221208/db8bad7f/attachment-0001.png

Sure: I only meant that as far as I know, there have been no changes in
XeTeX since them. I was wondering why you thought there might be.

Joseph

Sorry for not getting the idea.


The last significant commit in `xetex.ch` is
https://www.tug.org/svn/texlive/trunk/Build/source/texk/web2c/tex.ch?r1=63916=64547
on 2022-09-29, which is much later than the one on sf.




That's tex.ch, not xetex?

Joseph

Re: [XeTeX] I want to commit to xetex, how to make a pull request?

2022-12-13 Thread Tuff Contender 
On Sat, Dec 10, 2022 at 6:22 PM Joseph Wright <
joseph.wri...@morningstar2.co.uk> wrote:

> On 09/12/2022 19:07, Tuff Contender wrote:
> >>
> >> On 08/12/2022 09:22, Tuff Contender wrote:
> >>> The code on XeTeX - Unicode-based TeX / Code / [bc89c7] (
> sourceforge.net)
> >>>  seems not up to
> >>> date, since the last modification is on 2020-01-20.
> >>> [image: image.png]
> >>> Where should I submit a merge request to?
> >>
> >> What makes you think it's not up-to-date? (Other than some TL version
> >> strings, I imagine this is the same code as in TL, etc.) That said, I'd
> >> likely look to send a patch in the first instance to TL, as it tends to
> >> be the place that any changes actually happen.
> > I viewed the page https://sourceforge.net/p/xetex/code/ci/master/tree/
> > and found the last change is on 2020-01-20, here's the snapshot
> >
> https://tug.org/pipermail/xetex/attachments/20221208/db8bad7f/attachment-0001.png
>
> Sure: I only meant that as far as I know, there have been no changes in
> XeTeX since them. I was wondering why you thought there might be.
>
> Joseph
>
> Sorry for not getting the idea.

The last significant commit in `xetex.ch` is
https://www.tug.org/svn/texlive/trunk/Build/source/texk/web2c/tex.ch?r1=63916=64547
on 2022-09-29, which is much later than the one on sf.


-- 
Srik Wanar

Re: [XeTeX] I want to commit to xetex, how to make a pull request?

2022-12-10 Thread Joseph Wright 

On 09/12/2022 19:07, Tuff Contender wrote:


On 08/12/2022 09:22, Tuff Contender wrote:

The code on XeTeX - Unicode-based TeX / Code / [bc89c7] (sourceforge.net)
 seems not up to
date, since the last modification is on 2020-01-20.
[image: image.png]
Where should I submit a merge request to?


What makes you think it's not up-to-date? (Other than some TL version
strings, I imagine this is the same code as in TL, etc.) That said, I'd
likely look to send a patch in the first instance to TL, as it tends to
be the place that any changes actually happen.

I viewed the page https://sourceforge.net/p/xetex/code/ci/master/tree/
and found the last change is on 2020-01-20, here's the snapshot
https://tug.org/pipermail/xetex/attachments/20221208/db8bad7f/attachment-0001.png


Sure: I only meant that as far as I know, there have been no changes in 
XeTeX since them. I was wondering why you thought there might be.


Joseph

Re: [XeTeX] I want to commit to xetex, how to make a pull request?

2022-12-09 Thread Tuff Contender 
>
> On 08/12/2022 09:22, Tuff Contender wrote:
> > The code on XeTeX - Unicode-based TeX / Code / [bc89c7] (sourceforge.net)
> >  seems not up to
> > date, since the last modification is on 2020-01-20.
> > [image: image.png]
> > Where should I submit a merge request to?
>
> What makes you think it's not up-to-date? (Other than some TL version
> strings, I imagine this is the same code as in TL, etc.) That said, I'd
> likely look to send a patch in the first instance to TL, as it tends to
> be the place that any changes actually happen.
I viewed the page https://sourceforge.net/p/xetex/code/ci/master/tree/
and found the last change is on 2020-01-20, here's the snapshot
https://tug.org/pipermail/xetex/attachments/20221208/db8bad7f/attachment-0001.png

>
> > Still there are some other problems related to commits to the project.
> > 1. It is advised to make patches in the `xetex.ch` file, not `xetex.web`.
> > But I can find changes in both `*tex.web` and `*tex.ch`. So which one am I
> > supposed to modify?
>
> I think both to keep them in line with each other.
>
> > 2. In `.ch` files, what's those after "@x" and "@y", are they comments? How
> > do I write them?
>
> Yes, they are there for humans to understand what's going on.
>
> What changes are you considering suggesting?
>
> Joseph

I'm fixing a `map_char_to_glyph' error, as shown in
https://tex.stackexchange.com/questions/578372

-- 
Srik Wanar

Re: [XeTeX] I want to commit to xetex, how to make a pull request?

2022-12-08 Thread Joseph Wright 

On 08/12/2022 09:22, Tuff Contender wrote:

The code on XeTeX - Unicode-based TeX / Code / [bc89c7] (sourceforge.net)
 seems not up to
date, since the last modification is on 2020-01-20.
[image: image.png]
Where should I submit a merge request to?


What makes you think it's not up-to-date? (Other than some TL version 
strings, I imagine this is the same code as in TL, etc.) That said, I'd 
likely look to send a patch in the first instance to TL, as it tends to 
be the place that any changes actually happen.



Still there are some other problems related to commits to the project.
1. It is advised to make patches in the `xetex.ch` file, not `xetex.web`.
But I can find changes in both `*tex.web` and `*tex.ch`. So which one am I
supposed to modify?


I think both to keep them in line with each other.


2. In `.ch` files, what's those after "@x" and "@y", are they comments? How
do I write them?


Yes, they are there for humans to understand what's going on.

What changes are you considering suggesting?

Joseph