Re: [XFree86] [XFree86(TM) Bug Report] overlapping strcpy in imake.c

[Marc Aurele La France]

On Sun, 23 Mar 2003, Dan Nelson wrote:

 Regarding: overlapping strcpy in imake.c
 Email: [EMAIL PROTECTED]
 
 XFree86 Version: XFree86 Version 4.3.0

 OS: FreeBSD -current

 Area: imake

 Server: not server related

 Description:

 xc/config/imake/imake.c line 1841:

 strcpy(pend+1, pend+5);

 is not a legal function call.  strcpy does not reliably handle
 overlapping arguments.  See
 http://www.opengroup.org/onlinepubs/007904975/functions/strcpy.html.
 Fix:

 memmove(pend+1, pend+5, strlen(pend+5));

Ummm.  You're right.  But the fix I'll commit is

  memmove(pend+1, pend+5, strlen(pend+5)+1);

Thanks for reporting the problem.

Marc.

+--+---+
|  Marc Aurele La France   |  work:   1-780-492-9310   |
|  Computing and Network Services  |  fax:1-780-492-1729   |
|  352 General Services Building   |  email:  [EMAIL PROTECTED]  |
|  University of Alberta   +---+
|  Edmonton, Alberta   |   |
|  T6G 2H1 | Standard disclaimers apply|
|  CANADA  |   |
+--+---+
XFree86 Core Team member.  ATI driver and X server internals.

___
XFree86 mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xfree86

[XFree86] [XFree86(TM) Bug Report] overlapping strcpy in imake.c

[Dan Nelson]

Regarding: overlapping strcpy in imake.c
Email: [EMAIL PROTECTED]

XFree86 Version: XFree86 Version 4.3.0

OS: FreeBSD -current

Area: imake

Server: not server related

Description:

xc/config/imake/imake.c line 1841:

strcpy(pend+1, pend+5);

is not a legal function call.  strcpy does not reliably handle overlapping arguments.  
See http://www.opengroup.org/onlinepubs/007904975/functions/strcpy.html.  Fix:

memmove(pend+1, pend+5, strlen(pend+5));


Repeat By:

Build imake on a system that implements strcpy by copying backwards and watch it die 
on a makefile with XCOMM comments



___
XFree86 mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xfree86