RE: zookeeper patch builds.
Hi Patrick, I've restarted the patch builds for zookeeper as the space issue seem to be resolved. Thanks, Giri -Original Message- From: Patrick Hunt [mailto:ph...@apache.org] Sent: Thursday, July 30, 2009 11:03 AM To: zookeeper-dev@hadoop.apache.org Cc: Nigel Daley Subject: Re: zookeeper patch builds. Hi Giri, any update on this? Has infra been able to resolve the space issue? Thanks! Parick Giridharan Kesavan wrote: Zookeeper patch admin jobs running on hudson.zones are failing, as hudson.zones is running out of space. I 've sent an email to the apache infrastructure team. Once I get an update I would restart the zookeeper-patch builds. Thanks, Giri
[jira] Commented: (ZOOKEEPER-479) QuorumHierarchical does not count groups correctly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737039#action_12737039 ] Hadoop QA commented on ZOOKEEPER-479: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12414004/ZOOKEEPER-479.patch against trunk revision 798038. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/158/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/158/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/158/console This message is automatically generated. QuorumHierarchical does not count groups correctly -- Key: ZOOKEEPER-479 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479 Project: Zookeeper Issue Type: Bug Components: quorum Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.2.1, 3.3.0 Attachments: ZOOKEEPER-479.patch QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower
[ https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737072#action_12737072 ] Hadoop QA commented on ZOOKEEPER-480: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12414159/ZOOKEEPER-480.patch against trunk revision 798038. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/159/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/159/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/159/console This message is automatically generated. FLE should perform leader check when node is not leading and add vote of follower - Key: ZOOKEEPER-480 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.0 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.2.1, 3.3.0 Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch As a server may join leader election while others have already elected a leader, it is necessary that a server handles some special cases of leader election when notifications are from servers that are either LEADING or FOLLOWING. In such special cases, we check if we have received a message from the leader to declare a leader elected. This check does not consider the case that the process performing the check might be a recently elected leader, and consequently the check fails. This patch also adds a new case, which corresponds to adding a vote to recvset when the notification is from a process LEADING or FOLLOWING. This fixes the case raised in ZOOKEEPER-475. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-311) handle small path lengths in zoo_create()
[
https://issues.apache.org/jira/browse/ZOOKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737148#action_12737148
]
Hadoop QA commented on ZOOKEEPER-311:
-
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12413380/ZOOKEEPER-311.patch
against trunk revision 798038.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/160/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/160/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/160/console
This message is automatically generated.
handle small path lengths in zoo_create()
-
Key: ZOOKEEPER-311
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-311
Project: Zookeeper
Issue Type: Improvement
Components: c client
Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.2.0
Reporter: Chris Darroch
Assignee: Chris Darroch
Priority: Minor
Fix For: 3.2.1, 3.3.0
Attachments: ZOOKEEPER-311.patch, ZOOKEEPER-311.patch
The synchronous completion for zoo_create() contains the following code:\\
{noformat}
if (sc-u.str.str_len strlen(res.path)) {
len = strlen(res.path);
} else {
len = sc-u.str.str_len-1;
}
if (len 0) {
memcpy(sc-u.str.str, res.path, len);
sc-u.str.str[len] = '\0';
}
{noformat}
In the case where the max_realpath_len argument to zoo_create() is 0, none of
this code executes, which is OK. In the case where max_realpath_len is 1, a
user might expect their buffer to be filled with a null terminator, but
again, nothing will happen (even if strlen(res.path) is 0, which is unlikely
since new node's will have paths longer than /).
The name of the argument to zoo_create() is also a little misleading, as is
its description (the maximum length of real path you would want) in
zookeeper.h, and the example usage in the Programmer's Guide:
{noformat}
int rc = zoo_create(zh,/xyz,value, 5, CREATE_ONLY, ZOO_EPHEMERAL,
buffer, sizeof(buffer)-1);
{noformat}
In fact this value should be the actual length of the buffer, including space
for the null terminator. If the user supplies a max_realpath_len of 10 and a
buffer of 11 bytes, and strlen(res.path) is 10, the code will truncate the
returned value to 9 bytes and put the null terminator in the second-last
byte, leaving the final byte of the buffer unused.
It would be better, I think, to rename the realpath and max_realpath_len
arguments to something like path_buffer and path_buffer_len, akin to
zoo_set(). The path_buffer_len would be treated as the full length of the
buffer (as the code does now, in fact, but the docs suggest otherwise).
The code in the synchronous completion could then be changed as per the
attached patch.
Since this would change, slightly, the behaviour or contract of the API, I
would be inclined to suggest waiting until 4.0.0 to implement this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count groups correctly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-479: --- Status: Open (was: Patch Available) QuorumHierarchical does not count groups correctly -- Key: ZOOKEEPER-479 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479 Project: Zookeeper Issue Type: Bug Components: quorum Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.2.1, 3.3.0 Attachments: ZOOKEEPER-479.patch QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-457) Make ZookeeperMain public, support for HBase (and other) embedded clients
[ https://issues.apache.org/jira/browse/ZOOKEEPER-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-457: --- Status: Patch Available (was: Open) Make ZookeeperMain public, support for HBase (and other) embedded clients - Key: ZOOKEEPER-457 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-457 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.1 Reporter: ryan rawson Assignee: ryan rawson Fix For: 3.2.1, 3.3.0 Attachments: zk.patch hi folks, we have made some changes to zookeeper to facilitate providing an embedded zk client in our own hbase client. This will allow our users to use 1 shell to manipulate both hbase things and zookeeper things. It requires making a few things public, and in the process rearranging how some static things are initialized. It's fairly trivial refactoring, hopefully you guys approve! Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Need to finalize a 3.2.1 release soon.
As Mahadev mentioned recently, 3.2.0 has a serious issue: https://issues.apache.org/jira/browse/ZOOKEEPER-484 we need to get out an official 3.2.1 release asap. I'm hoping mid/late next week would be possible. There are currently 18 issues on 3.2.1 in jira. Approx 12 of these have patches. Hudson has finally been fixed and is now up, running, and chugging through the patches (hudsonqabot). Committers please review the patches, provide feedback, and contribs address these issues so that we can get the patches committed to svn. I'm hoping we can get the 3.2.1 issues finalized in the next few days, which means a release candidate probably late next week. If you have an issue or know of an issue that's not slated for 3.2.1 currently please speak up ASAP! Regards, Patrick
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count groups correctly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-479: - Status: Open (was: Patch Available) QuorumHierarchical does not count groups correctly -- Key: ZOOKEEPER-479 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479 Project: Zookeeper Issue Type: Bug Components: quorum Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.2.1, 3.3.0 Attachments: ZOOKEEPER-479.patch QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count groups correctly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-479: - Attachment: ZOOKEEPER-479.patch This patch will probably keep failing until we have ZOOKEEPER-481 in. Also, I'm adding support to get the weight of servers to QuorumVerifiers, which we'll need in ZOOKEEPER-491. QuorumHierarchical does not count groups correctly -- Key: ZOOKEEPER-479 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479 Project: Zookeeper Issue Type: Bug Components: quorum Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.2.1, 3.3.0 Attachments: ZOOKEEPER-479.patch, ZOOKEEPER-479.patch QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count groups correctly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-479: - Status: Patch Available (was: Open) QuorumHierarchical does not count groups correctly -- Key: ZOOKEEPER-479 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479 Project: Zookeeper Issue Type: Bug Components: quorum Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.2.1, 3.3.0 Attachments: ZOOKEEPER-479.patch, ZOOKEEPER-479.patch QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-466) crash on zookeeper_close() when using auth with empty cert
[ https://issues.apache.org/jira/browse/ZOOKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-466: Status: Patch Available (was: Open) crash on zookeeper_close() when using auth with empty cert -- Key: ZOOKEEPER-466 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-466 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.2.0 Reporter: Chris Darroch Assignee: Chris Darroch Fix For: 3.2.1, 3.3.0 Attachments: ZOOKEEPER-466.patch The free_auth_info() function calls deallocate_Buffer(auth-auth) on every element in the auth list; that function frees any memory pointed to by auth-auth.buff if that field is non-NULL. In zoo_add_auth(), when certLen is zero (or cert is NULL), auth.buff is set to 0, but then not assigned to authinfo-auth when auth.buff is NULL. The result is uninitialized data in auth-auth.buff in free_auth_info(), and potential crashes. The attached patch adds a test which attempts to duplicate this error; it works for me but may not always on all systems as it depends on the uninitialized data being non-zero; there's not really a simple way I can see to trigger this in the current test framework. The patch also fixes the problem, I believe. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-466) crash on zookeeper_close() when using auth with empty cert
[ https://issues.apache.org/jira/browse/ZOOKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-466: Status: Open (was: Patch Available) crash on zookeeper_close() when using auth with empty cert -- Key: ZOOKEEPER-466 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-466 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.2.0 Reporter: Chris Darroch Assignee: Chris Darroch Fix For: 3.2.1, 3.3.0 Attachments: ZOOKEEPER-466.patch The free_auth_info() function calls deallocate_Buffer(auth-auth) on every element in the auth list; that function frees any memory pointed to by auth-auth.buff if that field is non-NULL. In zoo_add_auth(), when certLen is zero (or cert is NULL), auth.buff is set to 0, but then not assigned to authinfo-auth when auth.buff is NULL. The result is uninitialized data in auth-auth.buff in free_auth_info(), and potential crashes. The attached patch adds a test which attempts to duplicate this error; it works for me but may not always on all systems as it depends on the uninitialized data being non-zero; there's not really a simple way I can see to trigger this in the current test framework. The patch also fixes the problem, I believe. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-482) ignore sigpipe in testRetry to avoid silent immediate failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737307#action_12737307 ] Hadoop QA commented on ZOOKEEPER-482: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12414276/ZOOKEEPER-482.patch against trunk revision 798038. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/161/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/161/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/161/console This message is automatically generated. ignore sigpipe in testRetry to avoid silent immediate failure - Key: ZOOKEEPER-482 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-482 Project: Zookeeper Issue Type: Bug Components: c client, tests Affects Versions: 3.2.0 Reporter: Chris Darroch Assignee: Chris Darroch Priority: Minor Fix For: 3.2.1, 3.3.0 Attachments: ZOOKEEPER-482.patch The testRetry test silently exits for me periodically, especially, it seems, on newer hardware. It also spits out from log messages clutter the test output. The silent exits turn out to be because SIGPIPE is sometimes delivered during the sleep(1) in createClient(), the second time createClient() is called. Since SIGPIPE is not being ignored and there is no signal handler, the process exists immediately. This leaves the test suite in a broken state, with the test ZooKeeper process still running because zkServer.sh stop is not run by tearDown(). You have to manually kill the ZK server and retry the tests; sometimes they succeed and sometimes they don't. I described SIGPIPE handling a little in ZOOKEEPER-320. The appropriate thing, I think, is for the client application to ignore or handle SIGPIPE. In this case, that falls to the test processes. The attached patch fixes the issue for me with testRetry. The patch uses sigaction() to ignore SIGPIPE in TestClientRetry.cc and, for good measure (although I never saw it actually fail for me), TestClient.cc, since that file also uses sleep() extensively. I also removed a couple of unused functions and a macro definition from TestClientRetry.cc, just to simply matters, and turned off log output, which makes the testRetry output much, much cleaner (otherwise you get a lot of log output spamming into the nice clean cppunit output :-). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-467) Change log level in BookieHandle
[ https://issues.apache.org/jira/browse/ZOOKEEPER-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-467: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) +1 to the patch. I just committed this. thanks flavio. Change log level in BookieHandle Key: ZOOKEEPER-467 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-467 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.2.1, 3.3.0 Attachments: ZOOKEEPER-467.patch I have accidentally left a log.warn in BookieHandle. This is a pretty simple patch, so I would appreciate if we could review it quickly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-481) Add lastMessageSent to QuorumCnxManager
[ https://issues.apache.org/jira/browse/ZOOKEEPER-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-481: - Attachment: ZOOKEEPER-481.patch Adding comment to the test as requested. Thanks, Ben. Add lastMessageSent to QuorumCnxManager --- Key: ZOOKEEPER-481 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-481 Project: Zookeeper Issue Type: Bug Components: leaderElection Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Attachments: ZOOKEEPER-481.patch, ZOOKEEPER-481.patch, ZOOKEEPER-481.patch Currently we rely on TCP for reliable delivery of FLE messages. However, as we concurrently drop and create new connections, it is possible that a message is sent but never received. With this patch, cnx manager keeps a list of last messages sent, and resends the last one sent. Receiving multiples copies is harmless. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-482) ignore sigpipe in testRetry to avoid silent immediate failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-482: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. thanks chris. ignore sigpipe in testRetry to avoid silent immediate failure - Key: ZOOKEEPER-482 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-482 Project: Zookeeper Issue Type: Bug Components: c client, tests Affects Versions: 3.2.0 Reporter: Chris Darroch Assignee: Chris Darroch Priority: Minor Fix For: 3.2.1, 3.3.0 Attachments: ZOOKEEPER-482.patch The testRetry test silently exits for me periodically, especially, it seems, on newer hardware. It also spits out from log messages clutter the test output. The silent exits turn out to be because SIGPIPE is sometimes delivered during the sleep(1) in createClient(), the second time createClient() is called. Since SIGPIPE is not being ignored and there is no signal handler, the process exists immediately. This leaves the test suite in a broken state, with the test ZooKeeper process still running because zkServer.sh stop is not run by tearDown(). You have to manually kill the ZK server and retry the tests; sometimes they succeed and sometimes they don't. I described SIGPIPE handling a little in ZOOKEEPER-320. The appropriate thing, I think, is for the client application to ignore or handle SIGPIPE. In this case, that falls to the test processes. The attached patch fixes the issue for me with testRetry. The patch uses sigaction() to ignore SIGPIPE in TestClientRetry.cc and, for good measure (although I never saw it actually fail for me), TestClient.cc, since that file also uses sleep() extensively. I also removed a couple of unused functions and a macro definition from TestClientRetry.cc, just to simply matters, and turned off log output, which makes the testRetry output much, much cleaner (otherwise you get a lot of log output spamming into the nice clean cppunit output :-). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-492) the tests should have their own log4j.properties
the tests should have their own log4j.properties Key: ZOOKEEPER-492 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-492 Project: Zookeeper Issue Type: Bug Components: tests Affects Versions: 3.2.0, 3.1.1 Reporter: Patrick Hunt Priority: Minor Fix For: 3.3.0 the tests currently rely (QuorumPeerMainTest in particular) on conf/log4j.properties. if the user changes this file and then runs the tests the tests may fail. the tests should have their own log4j.properties maintained w/in the test directory itself, separate from conf/log4j.properties -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
