[jira] Commented: (ZOOKEEPER-182) zookeeper_init accepts empty host-port string and returns valid pointer to zhandle_t.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12639800#action_12639800 ] Hudson commented on ZOOKEEPER-182: -- Integrated in ZooKeeper-trunk #114 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/114/]) . zookeeper_init accepts empty host-port string and returns valid pointer to zhandle_t zookeeper_init accepts empty host-port string and returns valid pointer to zhandle_t. - Key: ZOOKEEPER-182 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-182 Project: Zookeeper Issue Type: Bug Components: c client Environment: Linux Reporter: Maxim P. Dementiev Assignee: Maxim P. Dementiev Fix For: 3.0.0 Attachments: ZOOKEEPER-182-UnitTests-Init-AddressString.patch, ZOOKEEPER-182.patch Please, add this test to src/c/tests/TestZookeeperInit.cc to reproduce this: void testEmptyAddressString() { zh=zookeeper_init(,0,0,0,0,0); CPPUNIT_ASSERT(zh==0); } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-182) zookeeper_init accepts empty host-port string and returns valid pointer to zhandle_t.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12639521#action_12639521 ] Patrick Hunt commented on ZOOKEEPER-182: Looks good, tests and everything. ;-) Just wanted to point out that when you believe that your patch is ready to be committed, select the Submit Patch link on the issue's Jira. This lets the committers know that you feel your patch is ready, should get a final review and be committed to svn. See more detail in the contributing your work section of the following: http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute zookeeper_init accepts empty host-port string and returns valid pointer to zhandle_t. - Key: ZOOKEEPER-182 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-182 Project: Zookeeper Issue Type: Bug Components: c client Environment: Linux Reporter: Maxim P. Dementiev Assignee: Maxim P. Dementiev Attachments: ZOOKEEPER-182-UnitTests-Init-AddressString.patch, ZOOKEEPER-182.patch Please, add this test to src/c/tests/TestZookeeperInit.cc to reproduce this: void testEmptyAddressString() { zh=zookeeper_init(,0,0,0,0,0); CPPUNIT_ASSERT(zh==0); } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.