Re: [9fans] Fix sam regexp bug with metacharacters in classes

2021-12-24 Thread Conor Williams
are u getting confused between Runemax and Runemask... I'm going to have my christmas dinner now ;; and reckon this patch would break a few things... i'm working off a mounted iso at the minute... it's handier: as in i have "-t iso9660" in it.. laters... /c:2021 crimbo hay ps: the jury is out on

Re: [9fans] Fix sam regexp bug with metacharacters in classes

2021-12-24 Thread Conor Williams
hi Adr Can you send me both the files, please? Kind Reards Conor P. Williams (conor.willi...@gmail.com) ps: before I apply the patch... On Tue, Nov 23, 2021 at 8:27 PM adr wrote: > The code assumes runes are 16 bits long, not 21, creating faulting > code parsing classes. I.e. '/[\-]' will not

Re: [9fans] Fix sam regexp bug with metacharacters in classes

2021-11-23 Thread Conor Williams
sorry that s should have a k preceding _ /c:2021248pm On Wed, Nov 24, 2021 at 1:28 AM Conor Williams wrote: > why on Gaia do you not have a > Runemas_Incremented_By_One_To_Keep_A_Negative_Sub > variable? > apart from that, it looks okay... will tango it in later... > > /c:2022November!^N^M > >

Re: [9fans] Fix sam regexp bug with metacharacters in classes

2021-11-23 Thread Conor Williams
why on Gaia do you not have a Runemas_Incremented_By_One_To_Keep_A_Negative_Sub variable? apart from that, it looks okay... will tango it in later... /c:2022November!^N^M On Tue, Nov 23, 2021 at 8:27 PM adr wrote: > The code assumes runes are 16 bits long, not 21, creating faulting > code

[9fans] Fix sam regexp bug with metacharacters in classes

2021-11-23 Thread adr
The code assumes runes are 16 bits long, not 21, creating faulting code parsing classes. I.e. '/[\-]' will not match '-'. This is the same fix already in 9front. http://adr.freeshell.org/plan9/patches/sam_fix_metachars_on_classes.diff --- /sys/src/cmd/sam/regexp.c Tue Apr 23 19:06:01 2013