[clang-tools-extra] r299561 - Fix -Wmissing-field-initializer warnings to unbreak the -Werror build

Author: dblaikie Date: Wed Apr 5 11:50:19 2017 New Revision: 299561 URL: http://llvm.org/viewvc/llvm-project?rev=299561=rev Log: Fix -Wmissing-field-initializer warnings to unbreak the -Werror build Modified: clang-tools-extra/trunk/unittests/clang-rename/RenameClassTest.cpp Modified:

Re: [PATCH] D31153: Add the ability to use the children() range API in a const-correct manner

On Mon, Mar 27, 2017 at 10:20 AM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman added a comment. > > In https://reviews.llvm.org/D31153#711287, @dblaikie wrote: > > > As I mentioned to Craig Topper recently on another review, generally > when implementing const

Re: [PATCH] D30760: Record command lines in objects built by clang, Clang part

Yeah, I don't know/mind either way - I think there's a tidy simplicity to including exactly what the user wrote on the command line, so don't mind if it's not removed, but can see the argument to omit it. I'd probably leave it in for simplicity. On Fri, Mar 24, 2017 at 5:48 PM Eric Christopher

Re: [PATCH] D30760: Record command lines in objects built by clang, Clang part

As Adrian mentioned, this can probably be covered/added to an existing test case in clang/test/Driver On Fri, Mar 24, 2017 at 1:57 PM Zhizhou Yang via Phabricator < revi...@reviews.llvm.org> wrote: > zhizhouy updated this revision to Diff 93003. > zhizhouy marked 3 inline comments as done. >

Re: r297975 - Use arg_begin() instead of getArgumentList().begin(), the argument list is an implementation detail

On Mon, Mar 20, 2017 at 8:59 AM Reid Kleckner wrote: > I came across llvm/docs/HistoricalNotes/2002-06-25-MegaPatchInfo.txt, > which has this: > """ > * The Function class now has helper functions for accessing the Arguments > list. > Instead of having to go through

Re: r297975 - Use arg_begin() instead of getArgumentList().begin(), the argument list is an implementation detail

On Thu, Mar 16, 2017 at 12:07 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Thu Mar 16 13:55:46 2017 > New Revision: 297975 > > URL: http://llvm.org/viewvc/llvm-project?rev=297975=rev > Log: > Use arg_begin() instead of getArgumentList().begin(), the

r297322 - Defensively ensure that GetExternalDeclStmt protects itself from nested deserialization

Author: dblaikie Date: Wed Mar 8 17:57:08 2017 New Revision: 297322 URL: http://llvm.org/viewvc/llvm-project?rev=297322=rev Log: Defensively ensure that GetExternalDeclStmt protects itself from nested deserialization Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modified:

Re: r297140 - [clang-format] Support namespaces ending in semicolon

Looks to be failing existing tests? FAIL: Clang-Unit :: Format/FormatTests/FormatTest.BreaksLongDeclarations (12427 of 32080) TEST 'Clang-Unit :: Format/FormatTests/FormatTest.BreaksLongDeclarations' FAILED Note: Google Test filter =

r296386 - Remove unused variable

Author: dblaikie Date: Mon Feb 27 15:14:42 2017 New Revision: 296386 URL: http://llvm.org/viewvc/llvm-project?rev=296386=rev Log: Remove unused variable Modified: cfe/trunk/include/clang/Serialization/ASTReader.h Modified: cfe/trunk/include/clang/Serialization/ASTReader.h URL:

Re: [PATCH] D30315: [Driver] Move architecture-specific free helper functions to their own files.

On Thu, Feb 23, 2017 at 4:08 PM David L. Jones via Phabricator via cfe-commits wrote: > dlj created this revision. > Herald added subscribers: mgorny, nemanjai, jyknight, dschuff, srhines, > danalbert, aemerson. > Herald added a reviewer: javed.absar. > > This patch

Re: r296221 - [ODRHash] Move inherited visitor call to end of function.

An explanation as to why the code was moved (& possibly test cases, or "NFC" in the description) would be handy here. On Fri, Feb 24, 2017 at 5:41 PM Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Fri Feb 24 19:29:34 2017 > New Revision: 296221 > >

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

On Tue, Feb 14, 2017 at 4:21 PM Mehdi AMINI via Phabricator via cfe-commits wrote: > mehdi_amini added a comment. > > In https://reviews.llvm.org/D13330#582607, @rsmith wrote: > > > I think this attribute is poorly named. Explicit instantiation > definitions are

Re: [PATCH] D30035: Add const to function parameters

Adding const to pointed/referenced types doesn't usually help the compiler, since they don't guarantee that the underlying object is const (nor that any use can't involve const_casting away the constness and mutating the value anyway). On Fri, Feb 17, 2017 at 2:34 PM Aditya Kumar via Phabricator

r294904 - ASTReader: Refactor common code for writing function definitions, to match the writing code

Author: dblaikie Date: Sun Feb 12 12:45:31 2017 New Revision: 294904 URL: http://llvm.org/viewvc/llvm-project?rev=294904=rev Log: ASTReader: Refactor common code for writing function definitions, to match the writing code Modified: cfe/trunk/lib/Serialization/ASTReaderDecl.cpp Modified:

[clang-tools-extra] r294823 - Fix memory leak by using unique_ptr

Author: dblaikie Date: Fri Feb 10 23:25:21 2017 New Revision: 294823 URL: http://llvm.org/viewvc/llvm-project?rev=294823=rev Log: Fix memory leak by using unique_ptr Modified: clang-tools-extra/trunk/modularize/CoverageChecker.cpp clang-tools-extra/trunk/modularize/CoverageChecker.h

Re: [PATCH] D16135: Macro Debug Info support in Clang

r294676 On Thu, Feb 9, 2017 at 4:05 PM David L. Jones via Phabricator < revi...@reviews.llvm.org> wrote: > dlj added inline comments. > > > > Comment at: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp:125 > + switch (Status) { > + default: > +llvm_unreachable("Do not expect to

r294676 - Fix the -Werror build by removing an unused default in a fully covered switch

Author: dblaikie Date: Thu Feb 9 18:06:38 2017 New Revision: 294676 URL: http://llvm.org/viewvc/llvm-project?rev=294676=rev Log: Fix the -Werror build by removing an unused default in a fully covered switch Modified: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp Modified:

Re: [PATCH] D16135: Macro Debug Info support in Clang

On Wed, Feb 8, 2017 at 2:25 PM Amjad Aboud via Phabricator < revi...@reviews.llvm.org> wrote: > aaboud added a comment. > > > How much does the build directory grow? > > Is there any noticeable compile time regression? > > I build clang in release mode using GCC, then used that build to build >

r294512 - Initialize builtins during modular codegen

Author: dblaikie Date: Wed Feb 8 14:51:11 2017 New Revision: 294512 URL: http://llvm.org/viewvc/llvm-project?rev=294512=rev Log: Initialize builtins during modular codegen Added: cfe/trunk/test/Modules/Inputs/codegen-opt/ cfe/trunk/test/Modules/Inputs/codegen-opt/bar.h - copied,

Re: [PATCH] D16135: Macro Debug Info support in Clang

On Tue, Feb 7, 2017 at 11:01 AM Amjad Aboud via Phabricator < revi...@reviews.llvm.org> wrote: > aaboud added a comment. > > In https://reviews.llvm.org/D16135#669416, @aprantl wrote: > > > In https://reviews.llvm.org/D16135#669045, @aaboud wrote: > > > > > Addressed Adrian last comments. > > >

r293692 - Fix modules codegen to be compatible with modules-ts

Author: dblaikie Date: Tue Jan 31 15:28:19 2017 New Revision: 293692 URL: http://llvm.org/viewvc/llvm-project?rev=293692=rev Log: Fix modules codegen to be compatible with modules-ts The Module::WithCodegen flag was only being set when the module was parsed from a ModuleMap. Instead set it late,

Re: r293457 - Tidy up codegen modules test & make it x86 specific since it relies on Itanium name manglings

age- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of > > David Blaikie via cfe-commits > > Sent: Sunday, January 29, 2017 9:34 PM > > To: cfe-commits@lists.llvm.org > > Subject: r293457 - Tidy up codegen modules test & make it

Re: [PATCH] D28007: Switch TableGen to emit calls to ASTRecordReader for AttrPCHRead.

This review thread is missing on-list approval. I assume it happened on Phab & just wasn't reflected here (if the Phab approval has no text it doesn't send an email, which is unfortunate - not sure if anyone's planning to fix that/change the settings, but until then it's helpful to include "LGTM"

Re: r293395 - Modules: Clarify ownership of ModuleFile instances in ModuleManager, NFC

Thanks! Always love to see cleanup like this :) On Sat, Jan 28, 2017 at 2:35 PM Duncan P. N. Exon Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dexonsmith > Date: Sat Jan 28 16:24:01 2017 > New Revision: 293395 > > URL: http://llvm.org/viewvc/llvm-project?rev=293395=rev >

r293462 - Reapply "DebugInfo: Omit class definitions even in the presence of available_externally vtables"

Author: dblaikie Date: Mon Jan 30 00:36:08 2017 New Revision: 293462 URL: http://llvm.org/viewvc/llvm-project?rev=293462=rev Log: Reapply "DebugInfo: Omit class definitions even in the presence of available_externally vtables" Accounts for a case that caused an assertion failure by attempting

r293457 - Tidy up codegen modules test & make it x86 specific since it relies on Itanium name manglings

Author: dblaikie Date: Sun Jan 29 23:33:51 2017 New Revision: 293457 URL: http://llvm.org/viewvc/llvm-project?rev=293457=rev Log: Tidy up codegen modules test & make it x86 specific since it relies on Itanium name manglings Modified: cfe/trunk/test/Modules/codegen.test Modified:

Re: [PATCH] D28845: Prototype of modules codegen

On Sun, Jan 29, 2017 at 10:21 AM Richard Smith via Phabricator < revi...@reviews.llvm.org> wrote: > rsmith accepted this revision. > rsmith added inline comments. > This revision is now accepted and ready to land. > > > > Comment at: lib/AST/ExternalASTSource.cpp:33 >

r293456 - Prototype of modules codegen

Author: dblaikie Date: Sun Jan 29 23:00:26 2017 New Revision: 293456 URL: http://llvm.org/viewvc/llvm-project?rev=293456=rev Log: Prototype of modules codegen First pass at generating weak definitions of inline functions from module files (& skipping (-O0) or emitting available_externally

r293344 - Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

Author: dblaikie Date: Fri Jan 27 17:11:10 2017 New Revision: 293344 URL: http://llvm.org/viewvc/llvm-project?rev=293344=rev Log: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr As Mehdi put it, entities should either be

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

On Fri, Jan 27, 2017 at 2:51 PM Mehdi Amini wrote: > On Jan 27, 2017, at 2:43 PM, David Blaikie wrote: > > > > On Fri, Jan 27, 2017 at 2:13 PM Mehdi Amini wrote: > > CC Hans. > > This is not a regression (AFAICT), but this is a

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

On Fri, Jan 27, 2017 at 2:48 PM Mehdi Amini wrote: > On Jan 27, 2017, at 2:44 PM, David Blaikie wrote: > > > > On Fri, Jan 27, 2017 at 2:11 PM Mehdi AMINI via Phabricator < > revi...@reviews.llvm.org> wrote: > > mehdi_amini accepted this revision. >

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

Reid: Richard and I played around with this with MSVC on godbolt

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

On Fri, Jan 27, 2017 at 2:11 PM Mehdi AMINI via Phabricator < revi...@reviews.llvm.org> wrote: > mehdi_amini accepted this revision. > mehdi_amini added a comment. > This revision is now accepted and ready to land. > > LGTM. > > > > > Comment at: lib/AST/ASTContext.cpp:8909 > + >

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

On Fri, Jan 27, 2017 at 2:13 PM Mehdi Amini wrote: > CC Hans. > > This is not a regression (AFAICT), but this is a quality improvement, so > may be worth considering in the 4.0 branch? > Perhaps - I'd generally err on the "if it's not a regression, don't hold the boat".

Re: [PATCH] D28845: Prototype of modules codegen

Richard: This ought to be ready for another round of review at this point, I Think. Got test cases (showing opt and non-opt behavior, direct and indirect modular dependencies, unused modular code, etc - might need some more comments?), flag, moved the linkage code to GetGVALinkageForFunction.

r292801 - Revert "DebugInfo: Omit class definitions even in the presence of available_externally vtables"

Author: dblaikie Date: Mon Jan 23 10:57:14 2017 New Revision: 292801 URL: http://llvm.org/viewvc/llvm-project?rev=292801=rev Log: Revert "DebugInfo: Omit class definitions even in the presence of available_externally vtables" Patch crashing on a bootstrapping sanitizer bot:

Re: r292632 - Fix actually-reachable llvm_unreachable.

Should this test that some specific mangling comes out the other end (tests that amount to "test that this does anything other than crashing" always make me a bit suspicious that there's /some/ specific behavior that is intended/should be tested for) On Fri, Jan 20, 2017 at 11:01 AM Richard Smith

r292768 - DebugInfo: Omit class definitions even in the presence of available_externally vtables

Author: dblaikie Date: Sun Jan 22 20:24:03 2017 New Revision: 292768 URL: http://llvm.org/viewvc/llvm-project?rev=292768=rev Log: DebugInfo: Omit class definitions even in the presence of available_externally vtables To ensure optimization level doesn't pessimize the -fstandalone-debug vtable

r292439 - Remove now redundant code that ensured debug info for class definitions was emitted under certain circumstances

Author: dblaikie Date: Wed Jan 18 15:15:18 2017 New Revision: 292439 URL: http://llvm.org/viewvc/llvm-project?rev=292439=rev Log: Remove now redundant code that ensured debug info for class definitions was emitted under certain circumstances Introduced in r181561 - it may've been subsumed by

Re: [PATCH] D28845: Prototype of modules codegen

Oh, remembered I had one other question/idea: Tangentially related to the question about non-inline functions in headers: Currently .pcm files have the 'interesting decls' list. Are there any interesting decls once modules codegen is in use? It seems mostly the interesting decls are things like

Re: [PATCH] D28845: Prototype of modules codegen

On Wed, Jan 18, 2017 at 4:12 AM Hal Finkel via Phabricator < revi...@reviews.llvm.org> wrote: > hfinkel added a comment. > > Can you provide a high-level description of what you're trying to > accomplish and the usage model? > Oh, for sure - sorry for the assumption/missing info. Stuff that's

Re: [PATCH] D28548: Improve include fixer's ranking by taking the paths into account.

On Tue, Jan 17, 2017 at 12:57 AM Manuel Klimek wrote: > It's by design. Do we want to change this? I always had the impression > turning on the state changes for the list is a bit noisy, but I'm happy if > that's not the general sentiment. > For approval it's important that

Re: [PATCH] D28548: Improve include fixer's ranking by taking the paths into account.

Looks like Ben signed off on this on Phab - but the email didn't go to the list (making this look like code was sent for review, then committed, without review/approval happening) Ben: I think Phab doesn't send mail for an approval with no text, so at least as a workaround you can write something

r291953 - Fix shared library build after r291938 by adding missing dependency on libOption

Author: dblaikie Date: Fri Jan 13 13:47:55 2017 New Revision: 291953 URL: http://llvm.org/viewvc/llvm-project?rev=291953=rev Log: Fix shared library build after r291938 by adding missing dependency on libOption Thanks to Reid Kleckner for the help reproducing/fixing. Modified:

r291938 - unique_ptrify Driver::ToolChains

Author: dblaikie Date: Fri Jan 13 12:53:43 2017 New Revision: 291938 URL: http://llvm.org/viewvc/llvm-project?rev=291938=rev Log: unique_ptrify Driver::ToolChains Modified: cfe/trunk/include/clang/Driver/Driver.h cfe/trunk/lib/Driver/Driver.cpp Modified:

r291919 - unique_ptrify createDriverOptTable

Author: dblaikie Date: Fri Jan 13 11:34:15 2017 New Revision: 291919 URL: http://llvm.org/viewvc/llvm-project?rev=291919=rev Log: unique_ptrify createDriverOptTable Modified: cfe/trunk/include/clang/Driver/Driver.h cfe/trunk/include/clang/Driver/Options.h

Re: [PATCH] D25435: Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection

I started the llvm-dev thread for the instruction location tradeoffs (removing the location from instructions to improve profiling support - possibly at the cost of other debug info consumers). The motivation for this flag is different - for added functionality that's generally (imho/based on

Re: r291058 - [Sema] Mark undefined ctors as deleted. NFC.

Alternatively could make the bool ctor a template with some SFINAE to restrict it to only parameters of type bool - thus blocking all conversions there, if they're particularly problematic. On Wed, Jan 4, 2017 at 5:32 PM George Burgess IV via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

Re: [libcxx] r291275 - [libc++] Cleanup and document <__threading_support>

Thanks! On Fri, Jan 6, 2017 at 3:26 PM Eric Fiselier wrote: > Should be fixed in r291298. Sorry for the breakage. > > /Eric > > On Fri, Jan 6, 2017 at 4:18 PM, Eric Fiselier wrote: > > Hi David, > > Thanks for the information. Looking into it now. > > /Eric > > On

Re: [libcxx] r291275 - [libc++] Cleanup and document <__threading_support>

On Fri, Jan 6, 2017 at 12:16 PM Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Fri Jan 6 14:05:40 2017 > New Revision: 291275 > > URL: http://llvm.org/viewvc/llvm-project?rev=291275=rev > Log: > [libc++] Cleanup and document <__threading_support> > >

[clang-tools-extra] r291272 - Reapply "Fix for shared_ptrification in Clang"

Author: dblaikie Date: Fri Jan 6 13:49:09 2017 New Revision: 291272 URL: http://llvm.org/viewvc/llvm-project?rev=291272=rev Log: Reapply "Fix for shared_ptrification in Clang" Aleksey Shlyapnikov pointed out the memory leak I'd introduced, so recommitted the clang change with a fix for that.

r291270 - Reapply "IntrusiveRefCntPtr -> std::shared_ptr for CompilerInvocationBase and CodeCompleteConsumer"

Author: dblaikie Date: Fri Jan 6 13:49:01 2017 New Revision: 291270 URL: http://llvm.org/viewvc/llvm-project?rev=291270=rev Log: Reapply "IntrusiveRefCntPtr -> std::shared_ptr for CompilerInvocationBase and CodeCompleteConsumer" Aleksey Shlypanikov pointed out my mistake in migrating an

r291252 - Revert "Fix examples for recent shared_ptrification"

Author: dblaikie Date: Fri Jan 6 11:50:34 2017 New Revision: 291252 URL: http://llvm.org/viewvc/llvm-project?rev=291252=rev Log: Revert "Fix examples for recent shared_ptrification" (should've rolled in to this revert of the CompilerInstance change in the first place... anyway) This reverts

[clang-tools-extra] r291251 - Revert "Fix for shared_ptrification in Clang"

Author: dblaikie Date: Fri Jan 6 11:47:19 2017 New Revision: 291251 URL: http://llvm.org/viewvc/llvm-project?rev=291251=rev Log: Revert "Fix for shared_ptrification in Clang" The original commit caused an asan-detected memory leak in Clang. Reverting while I investigate. This reverts commit

r291249 - Revert "IntrusiveRefCntPtr -> std::shared_ptr for CompilerInvocationBase and CodeCompleteConsumer"

Author: dblaikie Date: Fri Jan 6 11:47:10 2017 New Revision: 291249 URL: http://llvm.org/viewvc/llvm-project?rev=291249=rev Log: Revert "IntrusiveRefCntPtr -> std::shared_ptr for CompilerInvocationBase and CodeCompleteConsumer" Caused a memory leak reported by asan. Reverting while I

[clang-tools-extra] r291203 - Fixes for Clang API change

Author: dblaikie Date: Thu Jan 5 19:09:06 2017 New Revision: 291203 URL: http://llvm.org/viewvc/llvm-project?rev=291203=rev Log: Fixes for Clang API change Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp clang-tools-extra/trunk/modularize/ModularizeUtilities.h

r291202 - shared_ptrify (from InclusiveRefCntPtr) HeaderSearchOptions

Author: dblaikie Date: Thu Jan 5 19:04:46 2017 New Revision: 291202 URL: http://llvm.org/viewvc/llvm-project?rev=291202=rev Log: shared_ptrify (from InclusiveRefCntPtr) HeaderSearchOptions Modified: cfe/trunk/include/clang/Frontend/ASTUnit.h

[clang-tools-extra] r291186 - Fix for shared_ptrification in Clang

Author: dblaikie Date: Thu Jan 5 16:44:07 2017 New Revision: 291186 URL: http://llvm.org/viewvc/llvm-project?rev=291186=rev Log: Fix for shared_ptrification in Clang Modified: clang-tools-extra/trunk/include-fixer/IncludeFixer.cpp clang-tools-extra/trunk/include-fixer/IncludeFixer.h

r291185 - Fix examples for recent shared_ptrification

Author: dblaikie Date: Thu Jan 5 16:36:44 2017 New Revision: 291185 URL: http://llvm.org/viewvc/llvm-project?rev=291185=rev Log: Fix examples for recent shared_ptrification Modified: cfe/trunk/examples/clang-interpreter/main.cpp Modified: cfe/trunk/examples/clang-interpreter/main.cpp URL:

r291184 - IntrusiveRefCntPtr -> std::shared_ptr for CompilerInvocationBase and CodeCompleteConsumer

Author: dblaikie Date: Thu Jan 5 16:19:11 2017 New Revision: 291184 URL: http://llvm.org/viewvc/llvm-project?rev=291184=rev Log: IntrusiveRefCntPtr -> std::shared_ptr for CompilerInvocationBase and CodeCompleteConsumer Modified: cfe/trunk/include/clang/Frontend/ASTUnit.h

r291167 - Move SerializedDiagnosticPrinter's SharedState to std::shared_ptr rather than IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 13:48:10 2017 New Revision: 291167 URL: http://llvm.org/viewvc/llvm-project?rev=291167=rev Log: Move SerializedDiagnosticPrinter's SharedState to std::shared_ptr rather than IntrusiveRefCntPtr Modified: cfe/trunk/lib/Frontend/SerializedDiagnosticPrinter.cpp

r291166 - Move Preprocessor over to std::shared_ptr rather than IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 13:48:07 2017 New Revision: 291166 URL: http://llvm.org/viewvc/llvm-project?rev=291166=rev Log: Move Preprocessor over to std::shared_ptr rather than IntrusiveRefCntPtr Modified: cfe/trunk/include/clang/Frontend/ASTUnit.h

r291159 - Move FailedModulesSet over to shared_ptr from IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 13:11:31 2017 New Revision: 291159 URL: http://llvm.org/viewvc/llvm-project?rev=291159=rev Log: Move FailedModulesSet over to shared_ptr from IntrusiveRefCntPtr Modified: cfe/trunk/include/clang/Lex/PreprocessorOptions.h

r291160 - Move PreprocessorOptions to std::shared_ptr from IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 13:11:36 2017 New Revision: 291160 URL: http://llvm.org/viewvc/llvm-project?rev=291160=rev Log: Move PreprocessorOptions to std::shared_ptr from IntrusiveRefCntPtr Modified: cfe/trunk/include/clang/Frontend/CompilerInvocation.h

r291156 - Move VariantMatcher's Payload to std::shared_ptr rather than IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 12:51:54 2017 New Revision: 291156 URL: http://llvm.org/viewvc/llvm-project?rev=291156=rev Log: Move VariantMatcher's Payload to std::shared_ptr rather than IntrusiveRefCntPtr Modified: cfe/trunk/include/clang/ASTMatchers/Dynamic/VariantValue.h

r291155 - Simplify ASTReader ctor by using in-class initializers for many member variables

Author: dblaikie Date: Thu Jan 5 12:45:45 2017 New Revision: 291155 URL: http://llvm.org/viewvc/llvm-project?rev=291155=rev Log: Simplify ASTReader ctor by using in-class initializers for many member variables Modified: cfe/trunk/include/clang/Serialization/ASTWriter.h

r291154 - Simplify ASTReader ctor by using in-class initializers (NSDMIs to the rest of you) for many member variables

Author: dblaikie Date: Thu Jan 5 12:45:43 2017 New Revision: 291154 URL: http://llvm.org/viewvc/llvm-project?rev=291154=rev Log: Simplify ASTReader ctor by using in-class initializers (NSDMIs to the rest of you) for many member variables Modified:

r291150 - Use shared_ptr instead of IntrusiveRefCntPtr for ModuleFileExtension

Author: dblaikie Date: Thu Jan 5 12:23:18 2017 New Revision: 291150 URL: http://llvm.org/viewvc/llvm-project?rev=291150=rev Log: Use shared_ptr instead of IntrusiveRefCntPtr for ModuleFileExtension The intrusiveness wasn't needed here, so this simplifies/clarifies the ownership model.

r291143 - Migrate PathDiagnosticPiece to std::shared_ptr

Author: dblaikie Date: Thu Jan 5 11:26:53 2017 New Revision: 291143 URL: http://llvm.org/viewvc/llvm-project?rev=291143=rev Log: Migrate PathDiagnosticPiece to std::shared_ptr Simplifies and makes explicit the memory ownership model rather than implicitly passing/acquiring ownership. Modified:

r291017 - Remove use of intrusive ref count ownership acquisition

Author: dblaikie Date: Wed Jan 4 16:36:39 2017 New Revision: 291017 URL: http://llvm.org/viewvc/llvm-project?rev=291017=rev Log: Remove use of intrusive ref count ownership acquisition The one use of CheckerManager (AnalysisConsumer, calling createCheckerManager) keeps a strong reference to the

r290631 - DebugInfo: Don't include size/alignment on class declarations

Author: dblaikie Date: Tue Dec 27 16:05:35 2016 New Revision: 290631 URL: http://llvm.org/viewvc/llvm-project?rev=290631=rev Log: DebugInfo: Don't include size/alignment on class declarations This seems like it must've been a leftover by accident - no tests were backing it up & it doesn't make

Re: [PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

On Mon, Dec 19, 2016 at 9:39 AM Sean Callanan wrote: > That would require making LLDB crash and collecting the relevant crash log > data out of the user's own logs. This isn't impossible – but additionally > the generation of that log is asynchronous and you don't quite

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

I don't know much about who owns this sort of code, nor Vassil's work/responsibility in this area - but if he's OK with it/feels able to sign off on it, that'd be sufficient/fine by me (& others closer to it can pipe up if he seems like not the right person to approve). Thanks! - Dave On Mon,

Re: [PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

Ah, sure - no worries. Good to mention/link to the other change, etc, in the future. (if the changes on the clang side are trivial enough to not need review, may not need to send them out for review either - or could include them as an addendum to the llvm change ("oh, and here's what it looks

Re: [PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

Test coverage? On Tue, Dec 13, 2016 at 2:39 PM Sean Callanan via Phabricator via cfe-commits wrote: > spyffe retitled this revision from "Fix the linkage for > __crashtracer_info__" to "Prepare PrettyStackTrace for LLDB adoption". > spyffe updated the summary for

Re: [PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

Was this change approved by anyone? Generally once it's sent for review, you should wait until it's approved before committing (the assumption being, if you sent it for review it's because it needed review) On Wed, Dec 14, 2016 at 12:49 PM Amjad Aboud via Phabricator via cfe-commits

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

On Thu, Dec 15, 2016 at 2:18 PM Sean Callanan via Phabricator via cfe-commits wrote: > spyffe updated this revision to Diff 81661. > spyffe marked 2 inline comments as done. > spyffe added a comment. > Herald added a subscriber: jgosnell. > > Applied Vassil and

Re: [PATCH] D27597: [DebugInfo] Restore test case for long double constants.

On Mon, Dec 12, 2016 at 1:11 PM David Gross wrote: > I looked at what's supported by "requires", and couldn't find anything > appropriate. > > The problem is that I want the test to be sensitive to the size of long > double -- either no greater than 64 bits, or greater than 64

Re: [PATCH] D27597: [DebugInfo] Restore test case for long double constants.

While it's possible to do arbitrary script things - we prefer nto to to ensure the tests are portable. (we have some custom implementations of common unix utilities for portability of those). In this case, can you xfail this on platforms that don't have the feature you want? rather than trying to

Re: r289285 - Fix unused variable warnings. NFCI.

On Fri, Dec 9, 2016 at 2:55 PM Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rksimon > Date: Fri Dec 9 16:45:21 2016 > New Revision: 289285 > > URL: http://llvm.org/viewvc/llvm-project?rev=289285=rev > Log: > Fix unused variable warnings. NFCI. > > Modified: >

Re: [PATCH] Warning for main returning a bool.

On Tue, Nov 15, 2016 at 4:50 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Nov 15, 2016 at 2:55 PM, Aaron Ballman via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > On Tue, Nov 15, 2016 at 5:44 PM, Hal Finkel wrote: > > - Original

Re: [PATCH] D26596: [RFC] Add _LIBCPP_NO_DISCARD and apply it to unique_ptr::release()

On Sun, Nov 13, 2016 at 1:30 PM Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > EricWF created this revision. > EricWF added reviewers: mclow.lists, chandlerc. > EricWF added a subscriber: cfe-commits. > > The title says it all. > > I just want to check that we agree on the

Re: r285946 - Using release to free memory is at best confusing -- one would expect

Ah, I see - your follow up in 285950 mentions that this unique_ptr was always null, so none of it really mattered/did anything. On Tue, Nov 8, 2016 at 11:42 AM David Blaikie wrote: > On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits < >

Re: r285946 - Using release to free memory is at best confusing -- one would expect

On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chandlerc > Date: Thu Nov 3 12:42:32 2016 > New Revision: 285946 > > URL: http://llvm.org/viewvc/llvm-project?rev=285946=rev > Log: > Using release to free memory is at best confusing

Re: r285289 - [Sema] -Wunused-variable warning for array variables should behave

On Tue, Nov 1, 2016 at 3:13 AM Alex L wrote: > On 31 October 2016 at 15:34, David Blaikie wrote: > > > > On Thu, Oct 27, 2016 at 6:40 AM Alex Lorenz via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > Author: arphaman > Date: Thu Oct 27 08:30:51

Re: [PATCH] D25990: Sema: do not warn about unused const vars if main file is a header

On Thu, Oct 27, 2016 at 6:02 AM Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > bkramer accepted this revision. > bkramer added a comment. > This revision is now accepted and ready to land. > > This makes sense. While variable definitions in a header are weird, the >

Re: r285289 - [Sema] -Wunused-variable warning for array variables should behave

On Thu, Oct 27, 2016 at 6:40 AM Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Thu Oct 27 08:30:51 2016 > New Revision: 285289 > > URL: http://llvm.org/viewvc/llvm-project?rev=285289=rev > Log: > [Sema] -Wunused-variable warning for array variables

Re: [PATCH] D26024: [Xray] Don't generate output for xray tests

How/what output are these producing if they're meant to fail ("not" in the test line) anyway? & these tests should probably check the diagnostic result to be more precise than "Clang exited with a non-zero exit code". On Thu, Oct 27, 2016 at 1:54 AM Dean Michael Berris via cfe-commits <

Re: [PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

Ah, right - thanks for reminding/explaining! On Mon, Oct 24, 2016 at 2:42 PM Tim Shen wrote: > On Mon, Oct 24, 2016 at 2:38 PM David Blaikie wrote: > > Simplify it further by replacing A() with just a function instead of a > class? Or does that break the

Re: [PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

Simplify it further by replacing A() with just a function instead of a class? Or does that break the repro? bool Foo(); void Bar(); void Baz() { if (False && Foo()) Bar(); } On Mon, Oct 24, 2016 at 1:38 PM Tim Shen wrote: > On Mon, Oct 24, 2016 at 10:33 AM David

Re: [PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

On Fri, Oct 21, 2016 at 3:16 AM Alex Lorenz wrote: > arphaman updated this revision to Diff 75403. > arphaman added a comment. > > The updated patch improves error handling and adds a test for the fixit. > > > If we issue a fixit we should recover as-if the code was written

Re: [PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

On Mon, Aug 29, 2016 at 3:45 PM Tim Shen via cfe-commits < cfe-commits@lists.llvm.org> wrote: > timshen created this revision. > timshen added reviewers: rsmith, pirama. > timshen added a subscriber: cfe-commits. > > https://reviews.llvm.org/D24010 > > Files: > clang/include/clang/AST/Stmt.h >

Re: [PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

If we issue a fixit we should recover as-if the code was written with the fixit in. Does this code do that? (can we test it? I know we test some fixits - not sure it's necessary/worthwhile to test them all, but maybe we have a good idiom for testing that the recovery is correct) On Thu, Oct 20,

[PATCH] D25793: Don't crash generating debug info for VLA in function prototype.

dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CGDebugInfo.cpp:2183-2185 + if (VAT->getSizeExpr()) { +llvm::APSInt V; +if (VAT->getSizeExpr()->EvaluateAsInt(V,

Re: r284187 - Fix bogus assert breaking modules self-host.

Not worth/reasonable to have a test case? On Thu, Oct 13, 2016 at 7:44 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Oct 13 21:35:11 2016 > New Revision: 284187 > > URL: http://llvm.org/viewvc/llvm-project?rev=284187=rev > Log: > Fix bogus

Re: [PATCH] D25621: DebugInfo: use DIAlignment type.

On Mon, Oct 17, 2016 at 4:37 AM Victor Leschuk wrote: > vleschuk marked an inline comment as done. > vleschuk added inline comments. > > > > Comment at: include/clang/AST/ASTContext.h:83 > uint64_t Width; > -unsigned Align; > +

Re: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

Could you explain how/why there's a null size expr? I would've thought it must have /some/ size for code generation purposes... On Fri, Oct 7, 2016 at 11:33 AM Erich Keane wrote: > erichkeane created this revision. > erichkeane added reviewers: cfe-commits, dblaikie,

Re: [PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

On Thu, Oct 6, 2016 at 6:16 AM Alex Lorenz wrote: > arphaman created this revision. > arphaman added reviewers: dblaikie, krememek. > arphaman added a subscriber: cfe-commits. > arphaman set the repository for this revision to rL LLVM. > > This patch fixes the issue of clang

[PATCH] D24998: Add a new optimization option -Og

dblaikie added inline comments. > debug-options.c:21-22 > > +// RUN: %clang -### -c -Og -g %s -target x86_64-linux-gnu 2>&1 \ > +// RUN: | FileCheck -check-prefix=G -check-prefix=G_GDB %s > + I don't think we need this test case: -Og doesn't actually have anything to do with -g

Re: [PATCH] D24861: [Sema] extend Wshift-op-parentheses so it warns for multiplicative operators

I'd still wonder if this meets the bar for false positives (generally we try to only add warnings that would be enabled by default, even in new codebases - where most of what they find in a newcodebase are latent bugs, not noise (so the cleanup is at least fairly justified as being beneficial in

<    4   5   6   7   8   9   10   11   12   13   >