[jira] [Commented] (SOLR-6405) ZooKeeper calls can easily not be retried enough on ConnectionLoss.

2023-02-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690629#comment-17690629 ] David Smiley commented on SOLR-6405: (8.5 years later) I think I'm missing an important concept here. 

[jira] [Updated] (SOLR-15787) FileSystemConfigSetService, support write operations and more

2023-02-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-15787: Summary: FileSystemConfigSetService, support write operations and more (was: Implement

[jira] [Commented] (SOLR-15787) Implement FileSystemConfigSetService

2023-02-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689987#comment-17689987 ] David Smiley commented on SOLR-15787: - FileSystemConfigSetService is used by Solr in standalone mode

[jira] [Commented] (SOLR-16488) Migrate ZookeeperReadAPI to JAX-RS

2023-02-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689512#comment-17689512 ] David Smiley commented on SOLR-16488: - Not trying to be heavily involved here but I thought I'd add

[jira] [Commented] (SOLR-16116) Refactor the Solr Zookeeper logic to use Apache Curator

2023-02-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689501#comment-17689501 ] David Smiley commented on SOLR-16116: - Is the move to Hadoop client libraries easy dependency

[jira] [Commented] (SOLR-13931) Decommission Analytics component/handler

2023-02-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689314#comment-17689314 ] David Smiley commented on SOLR-13931: - I like deprecating first because we auto-detect this and log a

[jira] [Commented] (SOLR-16116) Refactor the Solr Zookeeper logic to use Apache Curator

2023-02-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689269#comment-17689269 ] David Smiley commented on SOLR-16116: - No comment on the Hadoop stuff; not my area of interest.  But

[jira] [Commented] (SOLR-16116) Refactor the Solr Zookeeper logic to use Apache Curator

2023-02-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688688#comment-17688688 ] David Smiley commented on SOLR-16116: - This is exciting!  Any update? > Refactor the Solr Zookeeper

[jira] [Commented] (SOLR-15703) replace all SolrException.log usage in Solr to just call log.error(...) directly

2023-02-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688268#comment-17688268 ] David Smiley commented on SOLR-15703: - One thing I don't get is why so many calls here use an empty

[jira] [Updated] (SOLR-15703) replace all SolrException.log usage in Solr to just call log.error(...) directly

2023-02-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-15703: Labels: newdev (was: ) > replace all SolrException.log usage in Solr to just call log.error(...)

[jira] [Commented] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687518#comment-17687518 ] David Smiley commented on SOLR-16563: - See https://github.com/apache/solr/pull/1353 One challenge to

[jira] [Resolved] (SOLR-16573) SolrClientTestRule for EmbeddedSolrServer

2023-02-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16573. - Fix Version/s: 9.2 Resolution: Fixed > SolrClientTestRule for EmbeddedSolrServer >

[jira] [Commented] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686746#comment-17686746 ] David Smiley commented on SOLR-16563: - I looked hard but can't find a recent proposal I did in Jira--

[jira] [Comment Edited] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686649#comment-17686649 ] David Smiley edited comment on SOLR-16563 at 2/9/23 4:59 PM: - This is a

[jira] [Commented] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2023-02-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686649#comment-17686649 ] David Smiley commented on SOLR-16563: - This is a request to INFRA.  See INFRA-23707 as an example /

[jira] [Commented] (SOLR-16623) SolrClientTestRule for JettySolrRunner

2023-02-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684931#comment-17684931 ] David Smiley commented on SOLR-16623: - More comments: * Scope to SolrJettyTestBase without modifying

[jira] [Resolved] (SOLR-16629) Replace SolrSingleThreaded and SolrThreadSafe annotations with JCIP

2023-02-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16629. - Fix Version/s: 9.2 Resolution: Fixed > Replace SolrSingleThreaded and SolrThreadSafe

[jira] [Commented] (SOLR-13396) SolrCloud will delete the core data for any core that is not referenced in the clusterstate

2023-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682640#comment-17682640 ] David Smiley commented on SOLR-13396: - Just reviewed the description & conversation here.  It seems

[jira] [Commented] (SOLR-16629) Replace SolrSingleThreaded and SolrThreadSafe annotations with JCIP

2023-01-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681809#comment-17681809 ] David Smiley commented on SOLR-16629: - [~anshum] : this PR changes what you've done so I'm looking

[jira] [Commented] (SOLR-16634) "gradlew check" fails with OOM on fresh clone

2023-01-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680614#comment-17680614 ] David Smiley commented on SOLR-16634: - Fantastic summary Kevin.  I'm relying on your summary without

[jira] [Assigned] (SOLR-16629) Replace SolrSingleThreaded and SolrThreadSafe annotations with JCIP

2023-01-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-16629: --- Assignee: David Smiley > Replace SolrSingleThreaded and SolrThreadSafe annotations with

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679877#comment-17679877 ] David Smiley commented on SOLR-15616: - Ishan, if "gradlew check" or precommit isn't working for you

[jira] [Resolved] (SOLR-16591) Refactor transient cores to be a subclass of SolrCores

2023-01-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16591. - Fix Version/s: 9.2 Assignee: David Smiley Resolution: Fixed > Refactor transient

[jira] [Commented] (SOLR-16630) TestCoordinatorRole.testNRTRestart fails 100% of attempts on branch_9x

2023-01-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679603#comment-17679603 ] David Smiley commented on SOLR-16630: - I noticed "precommit" clearly fails here on 9x – in

[jira] [Updated] (SOLR-16591) Refactor transient cores to be a subclass of SolrCores

2023-01-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16591: Description: Very few Solr users use "transient cores" but the impact of the capability adds

[jira] [Updated] (SOLR-16629) Replace SolrSingleThreaded and SolrThreadSafe annotations with JCIP

2023-01-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16629: Labels: newdev (was: dev new) > Replace SolrSingleThreaded and SolrThreadSafe annotations with

[jira] [Created] (SOLR-16629) Replace SolrSingleThreaded and SolrThreadSafe annotations with JCIP

2023-01-19 Thread David Smiley (Jira)
David Smiley created SOLR-16629: --- Summary: Replace SolrSingleThreaded and SolrThreadSafe annotations with JCIP Key: SOLR-16629 URL: https://issues.apache.org/jira/browse/SOLR-16629 Project: Solr

[jira] [Commented] (SOLR-13998) Add thread safety annotation to classes

2023-01-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678839#comment-17678839 ] David Smiley commented on SOLR-13998: - Indeed, they are supported by RacerD inside FB Infer used by

[jira] [Commented] (SOLR-16628) Occasional resource leak around XmlConfigFile parsing

2023-01-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678415#comment-17678415 ] David Smiley commented on SOLR-16628: - Wow; I didn't expect such a quick turn-around on my finding!

[jira] [Commented] (SOLR-16336) avoid fetching solrconfig.xml & schema.xml for already cached schema and config

2023-01-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678323#comment-17678323 ] David Smiley commented on SOLR-16336: - I was looking at a failure from the smoke tester on my machine

[jira] [Created] (SOLR-16623) SolrClientTestRule for JettySolrRunner

2023-01-17 Thread David Smiley (Jira)
David Smiley created SOLR-16623: --- Summary: SolrClientTestRule for JettySolrRunner Key: SOLR-16623 URL: https://issues.apache.org/jira/browse/SOLR-16623 Project: Solr Issue Type: Sub-task

[jira] [Updated] (SOLR-15787) Implement FileSystemConfigSetService

2023-01-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-15787: Fix Version/s: 9.2 Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (SOLR-16609) Unable to set properties when creating config/collection in Solr Cloud environment

2023-01-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17656414#comment-17656414 ] David Smiley commented on SOLR-16609: - This issue feels more like it should be a user list email. FYI

[jira] [Commented] (SOLR-16603) Create a public constructor for SolrCore

2023-01-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17656412#comment-17656412 ] David Smiley commented on SOLR-16603: - I think EmbeddedSolrServer is "production ready" albeit

[jira] [Commented] (SOLR-16536) Replace OpenTracing instrumentation with OpenTelemetry

2023-01-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17656386#comment-17656386 ] David Smiley commented on SOLR-16536: - I haven't researched the state of things lately (and it seems

[jira] [Commented] (SOLR-6312) CloudSolrServer doesn't honor updatesToLeaders constructor argument

2023-01-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17656384#comment-17656384 ] David Smiley commented on SOLR-6312: Where is the PR? BTW it's discouraged to create feature/issue

[jira] [Commented] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2023-01-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17656277#comment-17656277 ] David Smiley commented on SOLR-16531: - The concern here is only for core level handlers; right?

[jira] [Commented] (SOLR-16615) Colocated cores with the same configset should share resources

2023-01-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17656275#comment-17656275 ] David Smiley commented on SOLR-16615: - Talking out loud here This will be a big change because

[jira] [Commented] (SOLR-15787) Implement FileSystemConfigSetService

2023-01-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17656262#comment-17656262 ] David Smiley commented on SOLR-15787: - Thanks for reminding me! After seeing tests pass tonight I'll

[jira] [Commented] (SOLR-16532) New OpenTelemetry module with OTLP trace exporter

2023-01-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17656259#comment-17656259 ] David Smiley commented on SOLR-16532: - TestDistributedTracing is something I really like;

[jira] [Commented] (SOLR-16532) New OpenTelemetry module with OTLP trace exporter

2023-01-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655876#comment-17655876 ] David Smiley commented on SOLR-16532: - I like OTEL_TRACES_EXPORTER=logging best. Are we using the

[jira] [Commented] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2023-01-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655640#comment-17655640 ] David Smiley commented on SOLR-16531: - What are the gaps with app-per-ConfigSet? > Performance

[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-01-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655158#comment-17655158 ] David Smiley commented on SOLR-10466: - These are compatible ideas provided that the collection in the

[jira] [Commented] (SOLR-16567) java.lang.StackOverflowError when combining KnnQParser and FunctionRangeQParser

2023-01-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655157#comment-17655157 ] David Smiley commented on SOLR-16567: - At the *very* least, run.  {{gw precommit}}   after a cherry

[jira] [Commented] (SOLR-16533) Add Jaeger exporter to the new otel module

2023-01-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654656#comment-17654656 ] David Smiley commented on SOLR-16533: - Agreed; users can add whatever JARs they need. > Add Jaeger

[jira] [Resolved] (SOLR-14988) CoreContainer.getCores should should return transient cores that are loaded

2023-01-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14988. - Resolution: Won't Fix > CoreContainer.getCores should should return transient cores that are

[jira] [Commented] (SOLR-14988) CoreContainer.getCores should should return transient cores that are loaded

2023-01-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654296#comment-17654296 ] David Smiley commented on SOLR-14988: - I recommend a "Won't Fix" on this issue and instead deprecate

[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-01-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654290#comment-17654290 ] David Smiley commented on SOLR-10466: - One idea I've had is a delegating SolrClient that merely holds

[jira] [Commented] (SOLR-16525) Periodic performance benchmarking

2023-01-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654081#comment-17654081 ] David Smiley commented on SOLR-16525: - Can you please use a PDF export? > Periodic performance

[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-01-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653634#comment-17653634 ] David Smiley commented on SOLR-10466: - bq. it basically feels like actually more of a convenience

[jira] [Resolved] (SOLR-16598) Patch/upgrade Protobuf to fix CVEs

2022-12-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16598. - Fix Version/s: 9.1.1 Resolution: Fixed > Patch/upgrade Protobuf to fix CVEs >

[jira] [Resolved] (SOLR-992) Add Ability To Use JNDI Keys In Configuration String Replacement Tags

2022-12-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-992. --- Resolution: Won't Do > Add Ability To Use JNDI Keys In Configuration String Replacement Tags >

[jira] [Resolved] (SOLR-646) Configuration properties enhancements in solr.xml

2022-12-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-646. --- Resolution: Won't Do > Configuration properties enhancements in solr.xml >

[jira] [Commented] (SOLR-10465) setIdField should be deprecated in favor of SolrClientBuilder methods

2022-12-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653199#comment-17653199 ] David Smiley commented on SOLR-10465: - BTW your concerns resonate with me but I think you misplaced

[jira] [Resolved] (SOLR-10465) setIdField should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-10465. - Resolution: Duplicate Right, Erick removed it years ago. > setIdField should be deprecated in

[jira] [Commented] (SOLR-10452) setQueryParams should be deprecated in favor of SolrClientBuilder methods

2022-12-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652604#comment-17652604 ] David Smiley commented on SOLR-10452: - All looks good to me Eric. 6 years ago now, [~anshum] said:

[jira] [Commented] (SOLR-10467) setZkConnectTimeout should be deprecated in favor of SolrClientBuilder methods

2022-12-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652291#comment-17652291 ] David Smiley commented on SOLR-10467: - Right; SOLR-10468 (setZkClientTimeout) is essentially the

[jira] [Updated] (SOLR-16568) Update woodstox-core to 6.4.0 to mitigate CVE-2022-40152

2022-12-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16568: Fix Version/s: 9.1.1 (was: 9.2) > Update woodstox-core to 6.4.0 to mitigate

[jira] [Updated] (SOLR-16443) Upgrade Jackson bom to 2.13.4.20221013

2022-12-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16443: Fix Version/s: 9.1.1 (was: 9.2) > Upgrade Jackson bom to 2.13.4.20221013 >

[jira] [Created] (SOLR-16598) Patch/upgrade Protobuf to fix CVEs

2022-12-26 Thread David Smiley (Jira)
David Smiley created SOLR-16598: --- Summary: Patch/upgrade Protobuf to fix CVEs Key: SOLR-16598 URL: https://issues.apache.org/jira/browse/SOLR-16598 Project: Solr Issue Type: Improvement

[jira] [Commented] (SOLR-16562) Upgrade to Caffeine 3.1.2

2022-12-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652114#comment-17652114 ] David Smiley commented on SOLR-16562: - It should be noted that this change also upgraded Protobuf

[jira] [Resolved] (SOLR-16333) CVE-2021-22569 | CVSS 7 | com.google.protobuf_protobuf-java

2022-12-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16333. - Fix Version/s: 9.1 Resolution: Fixed Fixed indirectly by SOLR-16421 which was released in

[jira] [Commented] (SOLR-16579) Upgrade Jackson to 2.14.1

2022-12-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652103#comment-17652103 ] David Smiley commented on SOLR-16579: - Nevermind, I'll do it for SOLR-16443 > Upgrade Jackson to

[jira] [Commented] (SOLR-16443) Upgrade Jackson bom to 2.13.4.20221013

2022-12-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652102#comment-17652102 ] David Smiley commented on SOLR-16443: - I'll move this to 9.1.1 which should be released soon. >

[jira] [Commented] (SOLR-16579) Upgrade Jackson to 2.14.1

2022-12-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652090#comment-17652090 ] David Smiley commented on SOLR-16579: - FYI this addresses some CVEs:

[jira] [Commented] (SOLR-10467) setZkConnectTimeout should be deprecated in favor of SolrClientBuilder methods

2022-12-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651899#comment-17651899 ] David Smiley commented on SOLR-10467: - I SOLR-16061 (9.0), this setter moved off from

[jira] [Commented] (SOLR-16590) Standardize Builder method names

2022-12-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651894#comment-17651894 ] David Smiley commented on SOLR-16590: - As you are moving methods into Builders, *that* is the time to

[jira] [Commented] (SOLR-10461) setAliveCheckInterval should be deprecated in favor of SolrClientBuilder methods

2022-12-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651346#comment-17651346 ] David Smiley commented on SOLR-10461: - Why is this marked as fixed for 9.1?  9.1 was released.  9.2?

[jira] [Commented] (SOLR-16567) java.lang.StackOverflowError when combining KnnQParser and FunctionRangeQParser

2022-12-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17650961#comment-17650961 ] David Smiley commented on SOLR-16567: - The above comment by ASF's git integration shows a commit was

[jira] [Created] (SOLR-16591) Refactor transient cores to be a subclass of SolrCores

2022-12-15 Thread David Smiley (Jira)
David Smiley created SOLR-16591: --- Summary: Refactor transient cores to be a subclass of SolrCores Key: SOLR-16591 URL: https://issues.apache.org/jira/browse/SOLR-16591 Project: Solr Issue

[jira] [Commented] (SOLR-14988) CoreContainer.getCores should should return transient cores that are loaded

2022-12-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648168#comment-17648168 ] David Smiley commented on SOLR-14988: - In retrospect, renaming the method isn't necessary; its name

[jira] [Commented] (SOLR-15787) Implement FileSystemConfigSetService

2022-12-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646344#comment-17646344 ] David Smiley commented on SOLR-15787: - Thanks for the notice Kevin! Can you look [~nazerke]? >

[jira] [Commented] (SOLR-16585) All docs query with any nonzero positive start value throws NPE with "this.docs is null"

2022-12-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645921#comment-17645921 ] David Smiley commented on SOLR-16585: - Woah! What an embarrassing regression; I wonder why our tests

[jira] [Resolved] (SOLR-6147) Rename SolrInfoMBean.Category.QUERYHANDLER to REQUESTHANDLER

2022-12-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-6147. Resolution: Abandoned It appears to have been renamed to QUERY. Any way, it's not anything I care

[jira] [Resolved] (SOLR-10558) Support unlimited limits on ChildDocTransformer

2022-12-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-10558. - Resolution: Duplicate > Support unlimited limits on ChildDocTransformer >

[jira] [Commented] (SOLR-10558) Support unlimited limits on ChildDocTransformer

2022-12-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645899#comment-17645899 ] David Smiley commented on SOLR-10558: - I think it makes sense for communication to stay on the

[jira] [Commented] (SOLR-15787) Implement FileSystemConfigSetService

2022-12-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645532#comment-17645532 ] David Smiley commented on SOLR-15787: - FileSystemConfigSetService already exists; you separated it

[jira] [Commented] (SOLR-16571) Add Java system property for ZooKeeper config watch

2022-12-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645086#comment-17645086 ] David Smiley commented on SOLR-16571: - How does the Config API depend on this? My experiment above

[jira] [Commented] (SOLR-16571) Add Java system property for ZooKeeper config watch

2022-12-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645072#comment-17645072 ] David Smiley commented on SOLR-16571: - As a side note, even though I also run Solr with tons of

[jira] [Commented] (SOLR-16571) Add Java system property for ZooKeeper config watch

2022-12-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645068#comment-17645068 ] David Smiley commented on SOLR-16571: - [~noblepaul], I didn't know there was such a watcher so I got

[jira] [Commented] (SOLR-15732) queries to missing collection are slow

2022-12-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17644150#comment-17644150 ] David Smiley commented on SOLR-15732: - It's a shame hot-fixes didn't go through a code-review

[jira] [Commented] (SOLR-15732) queries to missing collection are slow

2022-12-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643107#comment-17643107 ] David Smiley commented on SOLR-15732: - Updating Aliases and updating collections are independent but

[jira] [Created] (SOLR-16573) SolrClientTestRule for EmbeddedSolrServer

2022-12-02 Thread David Smiley (Jira)
David Smiley created SOLR-16573: --- Summary: SolrClientTestRule for EmbeddedSolrServer Key: SOLR-16573 URL: https://issues.apache.org/jira/browse/SOLR-16573 Project: Solr Issue Type: Sub-task

[jira] [Commented] (SOLR-15732) queries to missing collection are slow

2022-12-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642292#comment-17642292 ] David Smiley commented on SOLR-15732: - See the "work log" tab here in JIRA if you wish. It has my

[jira] [Commented] (SOLR-15732) queries to missing collection are slow

2022-12-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642285#comment-17642285 ] David Smiley commented on SOLR-15732: - Judging from the previous comment, this was just pushed to a

[jira] [Updated] (SOLR-16367) Umbrella: Migrate away from Apache HttpClient.

2022-11-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16367: Description: This is an umbrella issue to migrate away from using Apache HttpClient to

[jira] [Updated] (SOLR-16367) Umbrella: Migrate away from Apache HttpClient.

2022-11-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16367: Summary: Umbrella: Migrate away from Apache HttpClient. (was: Switch from CloudLegacySolrClient

[jira] [Commented] (SOLR-16498) Tests need the URL from a SolrClient; don't require legacy clients

2022-11-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640848#comment-17640848 ] David Smiley commented on SOLR-16498: - In SOLR-16158, JettySolrRunner is moving to the

[jira] [Created] (SOLR-16563) Http2SolrClient should have a defaultCollection setting

2022-11-28 Thread David Smiley (Jira)
David Smiley created SOLR-16563: --- Summary: Http2SolrClient should have a defaultCollection setting Key: SOLR-16563 URL: https://issues.apache.org/jira/browse/SOLR-16563 Project: Solr Issue

[jira] [Commented] (SOLR-16549) Solr core memory usage study

2022-11-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637421#comment-17637421 ] David Smiley commented on SOLR-16549: - See SOLR-6820 which resulted in changing a default of 256 to

[jira] [Commented] (SOLR-16549) Solr core memory usage study

2022-11-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636364#comment-17636364 ] David Smiley commented on SOLR-16549: - I believe the largest memory weight of each SolrCore is due to

[jira] [Commented] (SOLR-16546) Faceting puts an entry for each q into the filterCache

2022-11-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635538#comment-17635538 ] David Smiley commented on SOLR-16546: - This ought to be configurable. Of course Solr needs the

[jira] [Commented] (SOLR-16555) SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets repeatedly

2022-11-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635529#comment-17635529 ] David Smiley commented on SOLR-16555: - Here's an idea... Create a subclass of BitDocSet called

[jira] [Commented] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2022-11-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635037#comment-17635037 ] David Smiley commented on SOLR-16531: - A regression of a bug (failing tests) is a reason to revert.

[jira] [Resolved] (SOLR-15963) Refactor code to minimize access to SolrCore

2022-11-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15963. - Fix Version/s: 9.0 Resolution: Fixed > Refactor code to minimize access to SolrCore >

[jira] [Closed] (SOLR-15963) Refactor code to minimize access to SolrCore

2022-11-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed SOLR-15963. --- Assignee: Noble Paul > Refactor code to minimize access to SolrCore >

[jira] [Commented] (SOLR-16504) Convert CLI tools to Jetty HTTP 2 client.

2022-11-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631960#comment-17631960 ] David Smiley commented on SOLR-16504: - [~janhoy] I thought you might help contribute to this

[jira] [Updated] (SOLR-16496) provide option for Query Elevation Component to bypass filters

2022-11-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16496: Fix Version/s: 9.2 Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (SOLR-16528) Jaegertracer module must include okhttp3 dependency

2022-11-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631868#comment-17631868 ] David Smiley commented on SOLR-16528: - Oh, the SolrCloud aspect doesn't matter; I was trying both

[jira] [Commented] (SOLR-16528) Jaegertracer module must include okhttp3 dependency

2022-11-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631867#comment-17631867 ] David Smiley commented on SOLR-16528: - It does reproduce branch_9x sadly. Here's my bash history:

<    1   2   3   4   5   6   7   8   9   10   >