://git.reviewboard.kde.org/r/106636/diff/
Testing
---
Thanks,
Dawit Alemayehu
)
---
old restore dialog
http://git.reviewboard.kde.org/r/106503/s/729/
new restore dialog
http://git.reviewboard.kde.org/r/106503/s/731/
new restore dialog v2
http://git.reviewboard.kde.org/r/106503/s/739/
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106503/#review19192
---
On Sept. 28, 2012, 4:45 p.m., Dawit Alemayehu wrote
---
On Sept. 26, 2012, 12:53 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106569/
---
(Updated
/konqtabs.cpp 611659f
Diff: http://git.reviewboard.kde.org/r/106615/diff/
Testing
---
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/106618/s/736/
Thanks,
Dawit Alemayehu
/kcookiespolicyselectiondlg.ui c7ebb5d
Diff: http://git.reviewboard.kde.org/r/106619/diff/
Testing
---
Screenshots
---
New Cookie Config dialog
http://git.reviewboard.kde.org/r/106619/s/737/
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106569/#review19423
---
On Sept. 25, 2012, 3:38 p.m., Dawit Alemayehu wrote
://git.reviewboard.kde.org/r/106569/diff/
Testing
---
Thanks,
Dawit Alemayehu
https://bugs.kde.org/show_bug.cgi?id=245934
--- Comment #4 from Dawit Alemayehu ada...@kde.org ---
*** Bug 295362 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug
chain.
This addresses bug 302329.
http://bugs.kde.org/show_bug.cgi?id=302329
Diffs
-
dolphin/src/views/dolphinview.cpp 0584972
Diff: http://git.reviewboard.kde.org/r/106569/diff/
Testing
---
Thanks,
Dawit Alemayehu
be mounted and the mount
directory opened in a file manager.
Thanks,
Dawit Alemayehu
---
Thanks,
Dawit Alemayehu
---
On Sept. 5, 2012, 4:33 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106333/
---
(Updated Sept. 5
/106333/diff/
Testing
---
Thanks,
Dawit Alemayehu
/dolphinpart.h f9c0bbf
dolphin/src/dolphinpart.cpp bf3d2a5
dolphin/src/kitemviews/kfileitemmodel.h 958fa10
dolphin/src/views/dolphinview.h 3f08c44
Diff: http://git.reviewboard.kde.org/r/106333/diff/
Testing
---
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/106289/#review18542
---
On Sept. 4, 2012, 8:01 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org
/src/kitemviews/kfileitemmodel.h d9bebdf
dolphin/src/kitemviews/kfileitemmodel.cpp 6936af4
Diff: http://git.reviewboard.kde.org/r/106289/diff/
Testing
---
Thanks,
Dawit Alemayehu
/
Testing
---
Thanks,
Dawit Alemayehu
Diff: http://git.reviewboard.kde.org/r/106288/diff/
Testing
---
Thanks,
Dawit Alemayehu
/dolphinpart.cpp fff7dc0
Diff: http://git.reviewboard.kde.org/r/106289/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106289/#review18482
---
On Sept. 4, 2012, 8:01 p.m., Dawit Alemayehu wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106288/#review18523
---
On Sept. 4, 2012, 7:14 p.m., Dawit Alemayehu wrote
itemsInserted() and itemsRemoved(). Therefore, I think we should not add
these new signals unless there is a *very* good reason to have them.
Dawit Alemayehu wrote:
The breakage is not really the fault of the DolphinPart, but rather the
fact that access to crucial signals from KDirLister
Diff: http://git.reviewboard.kde.org/r/106289/diff/
Testing
---
Thanks,
Dawit Alemayehu
10f63c5
dolphin/src/views/dolphinview.cpp 8050415
Diff: http://git.reviewboard.kde.org/r/106289/diff/
Testing
---
Thanks,
Dawit Alemayehu
itemsInserted() and itemsRemoved(). Therefore, I think we should not add
these new signals unless there is a *very* good reason to have them.
Dawit Alemayehu wrote:
The breakage is not really the fault of the DolphinPart, but rather the
fact that access to crucial signals from KDirLister
://git.reviewboard.kde.org/r/105841/#review16843
---
On Aug. 3, 2012, 9:02 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org
db9ffd4
konqueror/src/konqviewmanager.cpp 5352eeb
Diff: http://git.reviewboard.kde.org/r/105984/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105984/#review17743
---
On Aug. 20, 2012, 2:22 a.m., Dawit Alemayehu wrote
10ed7cd
konqueror/src/konqview.cpp db9ffd4
konqueror/src/konqviewmanager.cpp 5352eeb
Diff: http://git.reviewboard.kde.org/r/105984/diff/
Testing
---
Thanks,
Dawit Alemayehu
.
http://bugs.kde.org/show_bug.cgi?id=304212
Diffs
-
kdecore/network/ktcpsocket.cpp 8da620a
Diff: http://git.reviewboard.kde.org/r/106087/diff/
Testing
---
Test site from the bug report: https://sni.velox.ch/
Thanks,
Dawit Alemayehu
---
On Aug. 11, 2012, 3:58 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105984
://bugs.kde.org/show_bug.cgi?id=173733
Diffs
-
kio/kio/kdirlister.cpp ec3d622
Diff: http://git.reviewboard.kde.org/r/103555/diff/
Testing
---
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/105749/s/646/
Thanks,
Dawit Alemayehu
,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105749/#review16512
---
On July 27, 2012, 8:52 a.m., Dawit Alemayehu wrote
history handling could create additional trouble.
I'm just not sure there is any point in preventing the user from typing
another url there, like in any other konqueror window.
Dawit Alemayehu wrote:
I made the combo box non-editable only because both Chromium and Firefox
do
history handling could create additional trouble.
I'm just not sure there is any point in preventing the user from typing
another url there, like in any other konqueror window.
Dawit Alemayehu wrote:
I made the combo box non-editable only because both Chromium and Firefox
do
by
adding the following configuration option to konquerorrc:
[DisableWindowOpenFeatures]
LocationBar=false
Diffs
-
konqueror/src/konqcombo.cpp cdf840a
konqueror/src/konqmainwindow.cpp 081509e
Diff: http://git.reviewboard.kde.org/r/105749/diff/
Testing
---
Thanks,
Dawit
/konqmainwindow.cpp 081509e
Diff: http://git.reviewboard.kde.org/r/105749/diff/
Testing
---
Screenshots (updated)
---
before the change
http://git.reviewboard.kde.org/r/105749/s/645/
after the change
http://git.reviewboard.kde.org/r/105749/s/646/
Thanks,
Dawit Alemayehu
.
http://bugs.kde.org/show_bug.cgi?id=279283
Diffs (updated)
-
dolphin/src/dolphinpart.h 0a8ce07
dolphin/src/dolphinpart.cpp b3b7cd0
Diff: http://git.reviewboard.kde.org/r/105607/diff/
Testing
---
Thanks,
Dawit Alemayehu
/diff/
Testing
---
Thanks,
Dawit Alemayehu
bug 279283.
http://bugs.kde.org/show_bug.cgi?id=279283
Diffs (updated)
-
dolphin/src/dolphinpart.cpp b3b7cd0
Diff: http://git.reviewboard.kde.org/r/105607/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
Thanks,
Dawit Alemayehu
---
On April 26, 2012, 3:42 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104642/
---
(Updated April
, visit:
http://git.reviewboard.kde.org/r/104982/#review14079
---
On May 18, 2012, 7:54 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit
/ktcpsocket.h 982e5b1
kdecore/network/ktcpsocket.cpp 57d54a9
Diff: http://git.reviewboard.kde.org/r/104958/diff/
Testing
---
Thanks,
Dawit Alemayehu
On April 26, 2012, 5:09 p.m., Albert Astals Cid wrote:
If i understand you correctly you are suggesting to create a bug (option
that does nothing)?
Doesn't make much sense.
Dawit Alemayehu wrote:
Huh ? I do not follow. By option that does nothing you mean this change
On May 21, 2012, 6:21 a.m., Dawit Alemayehu wrote:
src/sslinfodialog_p.h, line 45
http://git.reviewboard.kde.org/r/105002/diff/1/?file=65048#file65048line45
You can simply remove the KDE_EXPORT. I should have really removed that
before adding that header file. It is a private
/#comment11104
You can simply remove the KDE_EXPORT. I should have really removed that
before adding that header file. It is a private header file after all and is
only there to make it possible to compile the code.
- Dawit Alemayehu
On May 20, 2012, 10:07 p.m., Andrius da Costa Ribas
Diff: http://git.reviewboard.kde.org/r/103610/diff/
Testing
---
Visit the site listed in the bug report:
https://tim.rz.rwth-aachen.de/mail-lifecycle/
Thanks,
Dawit Alemayehu
On April 26, 2012, 5:09 p.m., Albert Astals Cid wrote:
If i understand you correctly you are suggesting to create a bug (option
that does nothing)?
Doesn't make much sense.
Dawit Alemayehu wrote:
Huh ? I do not follow. By option that does nothing you mean this change
/103610/diff/
Testing
---
Visit the site listed in the bug report:
https://tim.rz.rwth-aachen.de/mail-lifecycle/
Thanks,
Dawit Alemayehu
)
-
kio/kio/tcpslavebase.h fea2c08
kio/kio/tcpslavebase.cpp d0f92b4
Diff: http://git.reviewboard.kde.org/r/103610/diff/
Testing
---
Visit the site listed in the bug report:
https://tim.rz.rwth-aachen.de/mail-lifecycle/
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/103610/.
Diffs
-
kdecore/network/ktcpsocket.h 982e5b1
kdecore/network/ktcpsocket.cpp 57d54a9
Diff: http://git.reviewboard.kde.org/r/104958/diff/
Testing
---
Thanks,
Dawit Alemayehu
On April 21, 2012, 9:05 a.m., Andreas Schneider wrote:
Did you also test if keyboard-interactive still works correctly?
Dawit Alemayehu wrote:
No, because I do not even know how to enable that functionality in my ssh
config and was lazy to search and find out. Just looking
Git commit d7d9a5f97de9e4e078edccb5b36bad192d4aede2 by Dawit Alemayehu.
Committed on 09/05/2012 at 21:59.
Pushed by adawit into branch 'master'.
- Replaced all references of 'search' with 'web shortcuts' since web shortcuts
are not only for doing search.
- Replaced all the WhatsThis help text
generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104900/#review13653
---
On May 9, 2012, 8:35 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail
Git commit 0707b07d3afb14870d5c31149238e0f32e0d1187 by Dawit Alemayehu.
Committed on 07/05/2012 at 09:36.
Pushed by adawit into branch 'master'.
- Moved the checkbox used to select preferred shortcuts into its own column to
prevent user confusion.
- Allow the shortcut list to be filtered using
.
http://bugs.kde.org/show_bug.cgi?id=298744
Diffs
-
konqueror/src/konqmainwindow.cpp ea1678b
Diff: http://git.reviewboard.kde.org/r/104890/diff/
Testing
---
Made sure the bug reported in bug #298744 is gone after testing the patch.
Thanks,
Dawit Alemayehu
---
On May 9, 2012, 7:13 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104890/
---
(Updated May 9
---
Screenshots
---
Preferred selection column
http://git.reviewboard.kde.org/r/104900/s/563/
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104817/#review13442
---
On May 1, 2012, 10:36 p.m., Dawit Alemayehu wrote
kpasswdserver/kpasswdserver.cpp b2abbd4
kpasswdserver/tests/kpasswdservertest.cpp 38a579b
Diff: http://git.reviewboard.kde.org/r/104817/diff/
Testing
---
Added several additional unit tests to exercise all the changes. See patch.
Thanks,
Dawit Alemayehu
you need to explicitly add protocols by name if you also
have KIO in this list. You can just use KIO.
- Dawit Alemayehu
On May 3, 2012, 3:20 p.m., Sebastian Kügler wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104821/#review13369
---
Ship it!
Looks good to me.
- Dawit Alemayehu
On May 3
On May 1, 2012, 6:15 p.m., Lamarque Vieira Souza wrote:
kio/kfile/kurlrequesterdialog.cpp, line 133
http://git.reviewboard.kde.org/r/104802/diff/1/?file=61695#file61695line133
replace tab to spaces.
Dawit Alemayehu wrote:
For whomever wants to review these patches. Please
/#review13274
---
On May 1, 2012, 4:37 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104802
extension is .cc or .c++ or .cxx. I fixed that and it caught these as
well.
On May 1, 2012, 9:55 a.m., Dawit Alemayehu wrote:
I have made a few comments, mostly about code inconsistencies. Since it's a
matter of taste of the maintainer I didn't open issues, except when needed.
Though I
c89829d
kutils/kpluginselector.cpp 505e53f
nepomuk/ui/tagwidget.cpp 7c59922
nepomuk/utils/searchwidget.cpp f46e72a
Diff: http://git.reviewboard.kde.org/r/104802/diff/
Testing
---
Thanks,
Dawit Alemayehu
26, 2012, 3:48 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104631/
---
(Updated April 26, 2012, 3
://git.reviewboard.kde.org/r/104817/diff/
Testing
---
Added several additional unit tests to exercise all the changes. See patch.
Thanks,
Dawit Alemayehu
to it. ;)
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104351/#review13169
---
On March 20, 2012, 7:14 p.m., Dawit Alemayehu
/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
Thanks,
Dawit Alemayehu
kio/kio/kfilemetainfoitem.cpp 1cab458
kio/kio/ksambasharedata.cpp aebcb04
kio/misc/kpac/proxyscout.cpp 0068ce7
kio/misc/kpac/script.cpp a595301
nepomuk/core/resourcedata.cpp d6b0121
Diff: http://git.reviewboard.kde.org/r/104785/diff/
Testing
---
Thanks,
Dawit Alemayehu
0068ce7
kio/misc/kpac/script.cpp a595301
nepomuk/core/resourcedata.cpp d6b0121
Diff: http://git.reviewboard.kde.org/r/104785/diff/
Testing
---
Thanks,
Dawit Alemayehu
On April 21, 2012, 9:05 a.m., Andreas Schneider wrote:
Did you also test if keyboard-interactive still works correctly?
Dawit Alemayehu wrote:
No, because I do not even know how to enable that functionality in my ssh
config and was lazy to search and find out. Just looking
/settings/konqhtml/htmlopts.cpp e5d6deb
Diff: http://git.reviewboard.kde.org/r/104631/diff/
Testing
---
Screenshots (updated)
---
Option for disabling KWallet integration
http://git.reviewboard.kde.org/r/104631/s/544/
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104712/#review12884
---
Ship it!
Ship It!
- Dawit Alemayehu
On April 24, 2012, 5
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104642/#review12748
---
On April 17, 2012, 7:16 a.m., Dawit Alemayehu wrote
is pressed on the password dialog. That is continue onto the next
authentication method.
Thanks,
Dawit Alemayehu
On April 16, 2012, 11:34 p.m., Dawit Alemayehu wrote:
But your change now makes it possible to have a header without any spaces
after the colon as well. Despite that only affecting headers from the
cache, which what your patch does, I do not see the point here. Do you want
to support
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104625/#review12563
---
Ship it!
Ship It!
- Dawit Alemayehu
On April 16, 2012, 8
to KFileItemModel). Anyhow: Please just let me rebase the patch myself so
that I can catch all cases - I'll push the patch to master during the next
days.
Dawit Alemayehu wrote:
Ahh indeed. I forgot to update kde-baseapps before creating the patch. :(
As far as not being aware of resolving
/dolphinmainwindow.cpp 947db77
dolphin/src/views/dolphinview.cpp 78fd56d
Diff: http://git.reviewboard.kde.org/r/104614/diff/
Testing
---
Thanks,
Dawit Alemayehu
the port number as part of the
url.
Diffs
-
kioslave/sftp/kio_sftp.h ca2b4ac
kioslave/sftp/kio_sftp.cpp f8591f8
Diff: http://git.reviewboard.kde.org/r/104617/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104614/#review12509
---
On April 16, 2012, 1:26 p.m., Dawit Alemayehu wrote
/settings/konqhtml/htmlopts.h 69f36d8
konqueror/settings/konqhtml/htmlopts.cpp e5d6deb
Diff: http://git.reviewboard.kde.org/r/104631/diff/
Testing
---
Thanks,
Dawit Alemayehu
any spaces after
the colon as well. Despite that only affecting headers from the cache, which
what your patch does, I do not see the point here. Do you want to support cases
where there is no space between the ':' and the header content ?
- Dawit Alemayehu
On April 16, 2012, 8:30 p.m., Rolf
been addressed:
http://commits.kde.org/kdelibs/cd71839b04d7c754b9ec18f7b56522958b504006
http://commits.kde.org/kdelibs/d82f313500f9e4fe3a7e5ddef43650c31b59c8e3
- Dawit Alemayehu
On April 13, 2012, 8:07 p.m., Martin Gräßlin wrote
.
Thanks,
Dawit Alemayehu
-
kio/kio/scheduler.cpp 8d144bb
kio/kio/slaveinterface.h 3cdc2ae
kio/kio/slaveinterface.cpp d2f9f93
kio/kio/slaveinterface_p.h e2ccfe0
Diff: http://git.reviewboard.kde.org/r/104351/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104221/#review11293
---
Ship it!
Ship It!
- Dawit Alemayehu
On March 11, 2012, 11
---
On March 10, 2012, 3:39 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104179
b91f203
kparts/htmlextension.cpp 761c42c
Diff: http://git.reviewboard.kde.org/r/104179/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104176/#review11196
---
Ship it!
Ship It!
- Dawit Alemayehu
On March 6, 2012, 7:54
://git.reviewboard.kde.org/r/104120/#review11139
---
On March 3, 2012, 5:48 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r
::Scheduler correctly
processed the request one at a time:
[ftp.kde.org]
MaxConnections=1
Thanks,
Dawit Alemayehu
301 - 400 of 638 matches
Mail list logo
