.
This addresses bug 64647.
http://bugs.kde.org/show_bug.cgi?id=64647
Diffs (updated)
-
kio/kio/scheduler.cpp 6b4ed52
Diff: http://git.reviewboard.kde.org/r/104120/diff/
Testing
---
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/104071/diff/
Testing
---
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/104120/diff/
Testing
---
Thanks,
Dawit Alemayehu
convenience function.
This addresses bug 294321.
http://bugs.kde.org/show_bug.cgi?id=294321
Diffs
-
konqueror/src/konqframestatusbar.cpp 0142bd0
Diff: http://git.reviewboard.kde.org/r/104071/diff/
Testing
---
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/103973/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
On Feb. 18, 2012, 9:09 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103973
ced53a3
khtml/khtml_ext.cpp 6e8a846
kparts/htmlextension.h 9833d9a
Diff: http://git.reviewboard.kde.org/r/103973/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/103973/diff/
Testing
---
Thanks,
Dawit Alemayehu
/khtml_ext.cpp 6e8a846
khtml/khtml_part.cpp 24589e4
kparts/CMakeLists.txt 96fa31f
kparts/browsersettingsextension.h PRE-CREATION
kparts/browsersettingsextension.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103973/diff/
Testing
---
Thanks,
Dawit Alemayehu
,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103973/#review10609
---
On Feb. 13, 2012, 7 p.m., Dawit Alemayehu wrote
/bookmark_module.cpp 23b8e05
Diff: http://git.reviewboard.kde.org/r/103845/diff/diff
Testing
---
Follow the steps outlined in the bug report before and after the patch.
Thanks,
Dawit Alemayehu
d8a9cb7
kio/kio/fileundomanager.cpp f580c29
kio/kio/scheduler.cpp 6b36d9d
Diff: http://git.reviewboard.kde.org/r/100577/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
Git commit 2f63fe74e513580879cde3d4678d8268bd91da52 by Dawit Alemayehu.
Committed on 29/01/2012 at 07:09.
Pushed by adawit into branch 'KDE/4.8'.
Make sure the user's preference to show or hide the close buttons takes effect
as soon as the changes are applied. Not after restarting Konqueror.
BUG
Git commit e828d4e693ef9d3648de808be10901cf04a840b7 by Dawit Alemayehu.
Committed on 29/01/2012 at 07:09.
Pushed by adawit into branch 'master'.
Make sure the user's preference to show or hide the close buttons takes effect
as soon as the changes are applied. Not after restarting Konqueror.
BUG
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103740/#review10065
---
On Jan. 22, 2012, 6:18 p.m., Dawit Alemayehu wrote
, visit:
http://git.reviewboard.kde.org/r/103740/#review9993
---
On Jan. 19, 2012, 9:28 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit
,
Dawit Alemayehu
to the remote encoding and check what is selected.
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/103730/diff/diff
Testing
---
1.) Connect to a remote server.
2.) Change the remote charset encoding to Western European ( ISO-8859-1 ).
3.) Go back to the remote encoding and check what is selected.
Thanks,
Dawit Alemayehu
fbb0e48
Diff: http://git.reviewboard.kde.org/r/103691/diff/diff
Testing
---
Generate a link file to a URL location and see what KDE identifies the file as.
Thanks,
Dawit Alemayehu
Diffs
-
konqueror/src/konqmainwindow.cpp 7675e3a
Diff: http://git.reviewboard.kde.org/r/103663/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
ec3d622
Diff: http://git.reviewboard.kde.org/r/103555/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
/browseropenorsavequestion.cpp 092198f
Diff: http://git.reviewboard.kde.org/r/103617/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
)
-
kparts/browseropenorsavequestion.cpp 092198f
Diff: http://git.reviewboard.kde.org/r/103617/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
---
On Dec. 31, 2011, 5:23 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103594
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103579/#review9429
---
On Dec. 30, 2011, 6:39 a.m., Dawit Alemayehu wrote
after pressing Apply. IOW, the changes have already been applied.
Diffs (updated)
-
kdeui/dialogs/kedittoolbar.cpp ed572bf
Diff: http://git.reviewboard.kde.org/r/103579/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
/tcpslavebase.h fea2c08
kio/kio/tcpslavebase.cpp d0f92b4
Diff: http://git.reviewboard.kde.org/r/103610/diff/diff
Testing
---
Visit the site listed in the bug report:
https://tim.rz.rwth-aachen.de/mail-lifecycle/
Thanks,
Dawit Alemayehu
versions of strlen, strcmp and strncmp.
- Since there is no Qt version for atoi, make sure NULL pointers will not be
used in atoi calls.
Diffs
-
kioslave/ftp/ftp.cpp 41da792
Diff: http://git.reviewboard.kde.org/r/103616/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
/103617/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
---
Visit the site listed in the bug report:
https://tim.rz.rwth-aachen.de/mail-lifecycle/
Thanks,
Dawit Alemayehu
on demand by KFileItem.
Dawit Alemayehu wrote:
Yes, but changing permissions is only one case for ending up here. The
most common case is that KDirWatch (in Stat mode) notifies us that a
directory has changed because files have been created in it, or deleted,
etc. In that case we do
/r/103617/#review9484
---
On Jan. 2, 2012, 8:41 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103617
(updated)
-
kparts/browseropenorsavequestion.cpp 092198f
Diff: http://git.reviewboard.kde.org/r/103617/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
simply quoting
the user selected text in KOpenWithDialog::slotSelected not suffice ?
- Dawit Alemayehu
On Jan. 1, 2012, 9:49 p.m., Ingomar Wesp wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
in
filenmanagement mode.
Thanks,
Dawit Alemayehu
on the file listed and select Properties.
* Check the name of the file displayed before and after the patch.
* To verify the patch works, change the name of the file.
Thanks,
Dawit Alemayehu
/103579/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
not factorize this and call
that code for local files too? It would make the code shorter and easier to
maintain.
Dawit Alemayehu wrote:
Well that would be nice and that was my first choice, but unfortunately
that is not possible because KRun::init would need to be modified to use
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103555/#review9322
---
On Dec. 27, 2011, 6:26 p.m., Dawit Alemayehu wrote
not factorize this and call
that code for local files too? It would make the code shorter and easier to
maintain.
Dawit Alemayehu wrote:
Well that would be nice and that was my first choice, but unfortunately
that is not possible because KRun::init would need to be modified to use
the browser in the default application list to firefox and make sure
all of the following commands open the URL in firefox:
* kfmclient openURL http://www.kde.org
* kfmclient openURL /usr/share/doc/qt/html/index.html
* kfmclient openURL ftp://ftp.kde.org
Thanks,
Dawit Alemayehu
not been updated. This patch addresses that bug.
This addresses bug 173733.
http://bugs.kde.org/show_bug.cgi?id=173733
Diffs
-
kio/kio/kdirlister.cpp ec3d622
Diff: http://git.reviewboard.kde.org/r/103555/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
not factorize this and call
that code for local files too? It would make the code shorter and easier to
maintain.
Dawit Alemayehu wrote:
Well that would be nice and that was my first choice, but unfortunately
that is not possible because KRun::init would need to be modified to use
not factorize this and call
that code for local files too? It would make the code shorter and easier to
maintain.
Dawit Alemayehu wrote:
Well that would be nice and that was my first choice, but unfortunately
that is not possible because KRun::init would need to be modified to use
.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103524/#review9228
---
On Dec. 24, 2011, 4:14 a.m., Dawit Alemayehu wrote
:
* kfmclient openURL http://www.kde.org
* kfmclient openURL /usr/share/doc/qt/html/index.html
* kfmclient openURL ftp://ftp.kde.org
Thanks,
Dawit Alemayehu
https://bugs.kde.org/show_bug.cgi?id=245134
Dawit Alemayehu ada...@kde.org changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Version
that is attached disables the bogus debug message printed out
when closing Konqueror's configuration dialog.
Diffs
-
khtml/khtml_part.cpp 9a02248
Diff: http://git.reviewboard.kde.org/r/103500/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
://bugs.kde.org/show_bug.cgi?id=230959
Diffs (updated)
-
kioslave/info/kde-info2html 03ace75
Diff: http://git.reviewboard.kde.org/r/103426/diff/diff
Testing
---
Tested by displaying info:/make/Goals.
Thanks,
Dawit Alemayehu
230959.
http://bugs.kde.org/show_bug.cgi?id=230959
Diffs
-
kioslave/info/kde-info2html 03ace75
Diff: http://git.reviewboard.kde.org/r/103426/diff/diff
Testing
---
Tested by displaying info:/make/Goals.
Thanks,
Dawit Alemayehu
/103426/#review8994
---
On Dec. 16, 2011, 2:15 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103426
https://bugs.kde.org/show_bug.cgi?id=240516
Dawit Alemayehu ada...@kde.org changed:
What|Removed |Added
CC|ada...@kde.org |
AssignedTo|konq-b
by displaying info:/make/Goals.
Thanks,
Dawit Alemayehu
---
On Nov. 24, 2011, 3:16 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103226/
---
(Updated Nov
://git.reviewboard.kde.org/r/103226/diff/diff
Testing
---
Tested with the scenario outlined in the afforementioned bug report using a
publicly available demo webdav server, webdav://demo.sabredav.org.
Thanks,
Dawit Alemayehu
/show_bug.cgi?id=148171
Diffs
-
kpasswdserver/kpasswdserver.cpp cc8ded2
Diff: http://git.reviewboard.kde.org/r/103291/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
---
Attempt to log into two different sites from two different applications of two
different instances of the same application.
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/103245/diff/diff
Testing
---
Attempt to log into two different sites from two different applications of two
different instances of the same application.
Thanks,
Dawit Alemayehu
---
On Nov. 24, 2011, 7:37 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103226
., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103226/
---
(Updated Nov. 24, 2011, 7:37 a.m.)
Review
outlined in the afforementioned bug report using a
publicly available demo webdav server, webdav://demo.sabredav.org.
Thanks,
Dawit Alemayehu
://demo.sabredav.org.
Thanks,
Dawit Alemayehu
a
publicly available demo webdav server, webdav://demo.sabredav.org.
Thanks,
Dawit Alemayehu
https://bugs.kde.org/show_bug.cgi?id=245134
Dawit Alemayehu ada...@kde.org changed:
What|Removed |Added
CC||ada...@kde.org
https://bugs.kde.org/show_bug.cgi?id=199375
Dawit Alemayehu ada...@kde.org changed:
What|Removed |Added
CC||regna...@web.de
https://bugs.kde.org/show_bug.cgi?id=199375
Dawit Alemayehu ada...@kde.org changed:
What|Removed |Added
CC||ada...@kde.org
--- Comment
https://bugs.kde.org/show_bug.cgi?id=199375
--- Comment #102 from Dawit Alemayehu adawit kde org 2011-11-19 07:14:57 ---
*** Bug 209374 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail
/show_bug.cgi?id=285844
Diffs
-
konqueror/src/konqrun.cpp 9e9310c
konqueror/src/konqview.h 45c5bde
Diff: http://git.reviewboard.kde.org/r/103176/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103176/#review8281
---
On Nov. 17, 2011, 8:33 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e
of them. Please remove
anything that talks about default values from all and commit that. Thanks.
- Dawit Alemayehu
On Nov. 14, 2011, 10:24 a.m., Burkhard Lück wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
.
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103038/#review7939
---
On Nov. 3, 2011, 5:59 p.m., Dawit Alemayehu wrote
/deletejob.cpp 87c630a
Diff: http://git.reviewboard.kde.org/r/103038/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
https://bugs.kde.org/show_bug.cgi?id=145006
Dawit Alemayehu ada...@kde.org changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
CC
://git.reviewboard.kde.org/r/102938/diff/diff
Testing (updated)
---
Tested using http://www.mnot.net/javascript/xmlhttprequest/.
Thanks,
Dawit Alemayehu
://bugs.kde.org/show_bug.cgi?id=157753
Diffs (updated)
-
konqueror/src/konqmisc.cpp c46dc07
konqueror/src/konqtabs.cpp d627fad
Diff: http://git.reviewboard.kde.org/r/102931/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
)
-
kioslave/http/http.h 4c62841
kioslave/http/http.cpp 235ce7d
Diff: http://git.reviewboard.kde.org/r/102801/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
,
Dawit Alemayehu
d627fad
Diff: http://git.reviewboard.kde.org/r/102931/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
Git commit f90f318f2162df18a08b889d24ae8bbeab3b834c by Dawit Alemayehu.
Committed on 01/08/2011 at 07:44.
Pushed by adawit into branch 'master'.
Rewrote the proxy configuration dialog to include missing SOCKS
proxy entry and make it much simpler to use.
BUG:82352
BUG:115704
BUG:139789
BUG:147340
?
Dawit Alemayehu wrote:
I guess Port: can be added. I simply copied what was in the old
configuration dialog with very minor modifications. I do not have a
preference one way or the other. I will add the port labels to clarify the
interface and make sure users understand the purpose
visible
http://git.reviewboard.kde.org/r/102802/s/303/
Thanks,
Dawit Alemayehu
/s/301/
Alternate dialog with all options visible
http://git.reviewboard.kde.org/r/102802/s/303/
Thanks,
Dawit Alemayehu
., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102801/
---
(Updated Oct. 8, 2011, 5:16 a.m.)
Review
are for
different URLs.
Diffs
-
kio/kio/kprotocolmanager.cpp 92519e4
Diff: http://git.reviewboard.kde.org/r/102840/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
the iteratator function with the next
in HTTPTokenizer ; so as Andreas already indicated feel free to commit this.
- Dawit Alemayehu
On Oct. 13, 2011, 5:59 p.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply
.
Screenshots
---
No Proxy
http://git.reviewboard.kde.org/r/102802/s/296/
PAC Proxy
http://git.reviewboard.kde.org/r/102802/s/297/
System Proxy
http://git.reviewboard.kde.org/r/102802/s/298/
Manual Proxy
http://git.reviewboard.kde.org/r/102802/s/299/
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102802/#review7304
---
On Oct. 13, 2011, 9:13 p.m., Dawit Alemayehu wrote
/
System Proxy
http://git.reviewboard.kde.org/r/102802/s/298/
Manual Proxy
http://git.reviewboard.kde.org/r/102802/s/301/
Thanks,
Dawit Alemayehu
/#comment6307
This seems unnecessary to me since the parser produces a lower case token
to begin with.
- Dawit Alemayehu
On Oct. 10, 2011, 10:35 p.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply
: http://git.reviewboard.kde.org/r/102801/diff/diff
Testing
---
Thanks,
Dawit Alemayehu
/diff/diff
Testing
---
- Log into git.reviewboard.kde.org
- Create a sample review request.
- Attempt to change the People: assigned to it.
- If you do not get a server error message, then try to Discard your changes.
Thanks,
Dawit Alemayehu
On Sept. 29, 2011, 8:14 p.m., Dawit Alemayehu wrote:
Sorry, but this is simply wrong. There is a specific reason why passwords
are not blindly saved into the wallet before they are validated. The idea
of prompting the user for password and actually storing that password need
passwords are
not blindly saved into the wallet before they are validated. The idea of
prompting the user for password and actually storing that password need to be
two separate actions. So the question is from which application or ioslave are
you having this problem ?
- Dawit Alemayehu
;
return SOCKS 127.0.0.1:; DIRECT;
}
Thanks,
Dawit Alemayehu
Testing
---
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/102691/#review6796
---
On Sept. 25, 2011, 4:15 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
401 - 500 of 638 matches
Mail list logo
