Re: Review Request: Fix handling of FTP urls whose path name ends with a type code

2011-03-16 Thread Dawit Alemayehu
--- On March 16, 2011, 3:23 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100872/ --- (Updated March 16

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

2011-03-09 Thread Dawit Alemayehu
caching. - Dawit --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100814/#review1832 --- On March 8, 2011, 12:43 a.m., Dawit

Review Request: Fix for connecting to FTP sites through HTTP proxy

2011-03-07 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100814/ --- Review request for kdelibs. Summary --- The attached patch fixes

Review Request: Fix KIO::Scheduler::slotReparseSlaveConfiguration

2011-03-07 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100819/ --- Review request for kdelibs. Summary --- The dbus service check in

Re: Review Request: Fix DAV jobs bug

2011-02-20 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100694/#review1535 --- Except for the inconsistency of using int for the size value on

Re: Review Request: Fix DAV jobs bug

2011-02-20 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100694/#review1538 --- Ship it! Looks good, but make sure you fix the issue I pointed

Re: Review Request: Fix DAV jobs bug

2011-02-20 Thread Dawit Alemayehu
On Feb. 20, 2011, 10:20 p.m., Dawit Alemayehu wrote: kioslave/http/http.cpp, line 4059 http://git.reviewboard.kde.org/r/100694/diff/3/?file=9647#file9647line4059 The size variable here needs to be qint64. Oh, just in case you are not already aware, please use REVIEW:100684 in your

Review Request: New KIO::http_post and KIO::StoredHttpPost APIs that accept a QIODevice as input...

2011-02-11 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100516/ --- Review request for kdelibs. Changes --- Did some basic testing of

Re: Review Request: New KIO::http_post and KIO::StoredHttpPost APIs that accept a QIODevice as input...

2011-02-07 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100516/ --- (Updated Feb. 7, 2011, 6:46 p.m.) Review request for kdelibs. Changes

Re: Review Request: Prevent KHTML's adblock filter parser from incorrectly parsing rules with options...

2011-02-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100572/ --- (Updated Feb. 6, 2011, 4:07 p.m.) Review request for kdelibs. Summary

Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-02-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100577/ --- Review request for kdelibs. Summary --- As described in the bug

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-04 Thread Dawit Alemayehu
:11 a.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/ --- (Updated Feb. 4, 2011, 10:11 a.m

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/ --- (Updated Feb. 4, 2011, 3:52 p.m.) Review request for kdelibs and David

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-04 Thread Dawit Alemayehu
On Feb. 4, 2011, 8:02 a.m., Pino Toscano wrote: Please also add the { } around single line blocks (as per kdelibs coding style). Dawit Alemayehu wrote: Lets us forget about such nitpicks, okay... If such unnecessary coding styles were to be enforced, there would be so many lines

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/ --- (Updated Feb. 4, 2011, 6:22 p.m.) Review request for kdelibs and David

Review Request: Prevent KHTML's adblock filter parser from incorrectly parsing rules with options...

2011-02-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100572/ --- Review request for kdelibs. Summary --- This request is created

Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/ --- Review request for kdelibs and David Faure. Summary --- The attached

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/ --- (Updated Feb. 3, 2011, 11:23 p.m.) Review request for kdelibs and David

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/ --- (Updated Feb. 4, 2011, 12:07 a.m.) Review request for kdelibs and David

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/ --- (Updated Feb. 4, 2011, 12:11 a.m.) Review request for kdelibs and David

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/ --- (Updated Feb. 4, 2011, 1:29 a.m.) Review request for kdelibs and David

Review Request: New KIO::http_post and KIO::StoredHttpPost APIs that accept a QIODevice as input...

2011-02-02 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100516/ --- Review request for kdelibs. Summary --- The attached patch is the

Re: Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

2011-01-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6183/#review9527 --- On 2011-01-05 06:21:31, Dawit Alemayehu wrote

Re: Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

2011-01-05 Thread Dawit Alemayehu
(inline)...) I tested on rekonq code and it seems working. Dawit Alemayehu wrote: Nope. kio_http will always ignore the file name parameter if content-disposition header contains the inline parameter. Even if the content sent is not something that user-agent can render, the file

Re: Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

2011-01-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6183/ --- (Updated 2011-01-06 06:38:25.370927) Review request for kdelibs and Andrea

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves on hold...

2011-01-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/ --- (Updated 2011-01-04 21:46:47.110697) Review request for kdelibs. Changes

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves on hold...

2011-01-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/ --- (Updated 2011-01-04 21:47:25.243279) Review request for kdelibs. Summary

Re: Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

2011-01-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6183/ --- (Updated 2011-01-04 03:26:26.616485) Review request for kdelibs and Andrea

Re: Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

2011-01-03 Thread Dawit Alemayehu
://svn.reviewboard.kde.org/r/6183/#review9502 --- On 2011-01-03 03:49:54, Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http

Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves that have been put on hold...

2011-01-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/ --- Review request for kdelibs. Summary --- The patch attempts to fix the

Re: Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

2011-01-02 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6183/ --- (Updated 2011-01-03 03:49:54.352914) Review request for kdelibs and Andrea

[Kde-hardware-devel] Re: Review Request: Few minor improvments for UDisks solid backend manager...

2010-11-09 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5797/ --- (Updated 2010-11-09 17:02:31.081222) Review request for Solid. Changes

[Kde-hardware-devel] Re: Review Request: Few minor improvments for UDisks solid backend manager...

2010-11-08 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5797/#review8571 --- On 2010-11-08 07:39:06, Dawit Alemayehu wrote

[Kde-hardware-devel] Re: Review Request: Few minor improvments for UDisks solid backend manager...

2010-11-08 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5797/ --- (Updated 2010-11-08 22:55:15.157822) Review request for Solid. Changes

[Kde-hardware-devel] Re: Review Request: Few minor improvments for UDisks solid backend manager...

2010-11-07 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5797/ --- (Updated 2010-11-08 07:39:06.996343) Review request for Solid. Changes

[rekonq] KDE/kdelibs/kdewebkit

2010-05-18 Thread Dawit Alemayehu
muel...@kde.org * Copyright (C) 2008 Urs Wolfer uwolfer @ kde.org * Copyright (C) 2008 Michael Howell mhowell...@gmail.com - * Copyright (C) 2009 Dawit Alemayehu ada...@kde.org + * Copyright (C) 2009,2010 Dawit Alemayehu ada...@kde.org * * This library is free software; you can redistribute

Re: [rekonq] KDE/kdelibs/kio/kio

2010-02-02 Thread Dawit Alemayehu
On Monday 01 February 2010 13:57:05 Cédric Bellegarde wrote: Le Lundi 01 Février 2010 00:03:44, Dawit Alemayehu a écrit : SVN commit 1083276 by adawit: - Prevent all cache related header directives from being sent through the customHttpHeader meta-data sent to the http ioslave

Re: [rekonq] KDE/kdelibs/kio/kio

2010-02-02 Thread Dawit Alemayehu
On Tuesday 02 February 2010 12:27:45 Dawit Alemayehu wrote: On Monday 01 February 2010 13:57:05 Cédric Bellegarde wrote: Le Lundi 01 Février 2010 00:03:44, Dawit Alemayehu a écrit : SVN commit 1083276 by adawit: - Prevent all cache related header directives from being sent through

<    2   3   4   5   6   7