Also a direct acpi_lid_open() call seems a bit iffy. But I guess if
someone needs this to work on non-ACPI system they get to figure out
how to abstract it better. acpi_lid_open() does seem to return != 0
when ACPI is not supported, so at least it would err on the side
of enabling everything.
Also a direct acpi_lid_open() call seems a bit iffy. But I guess if
someone needs this to work on non-ACPI system they get to figure out
how to abstract it better. acpi_lid_open() does seem to return != 0
when ACPI is not supported, so at least it would err on the side
of enabling everything.
On 5/14/2024 4:28 PM, Alex Deucher wrote:
Add new config option and set proper dependencies for ISP.
v2: add missed guards, drop separate Kconfig
Signed-off-by: Alex Deucher
I have one optional remark regarding headers, but otherwise it looks
fine by me. Feel free to ignore it or
On 5/10/2024 4:24 AM, Jani Nikula wrote:
On Fri, 10 May 2024, "Lin, Wayne" wrote:
[Public]
-Original Message-----
From: Limonciello, Mario
Sent: Friday, May 10, 2024 3:18 AM
To: Linux regressions mailing list ; Wentland,
Harry
; Lin, Wayne
Cc: ly...@redhat.com; imre.d...
On 5/10/2024 4:24 AM, Jani Nikula wrote:
On Fri, 10 May 2024, "Lin, Wayne" wrote:
[Public]
-Original Message-----
From: Limonciello, Mario
Sent: Friday, May 10, 2024 3:18 AM
To: Linux regressions mailing list ; Wentland,
Harry
; Lin, Wayne
Cc: ly...@redhat.com; imre.d...
On 5/10/2024 4:24 AM, Jani Nikula wrote:
On Fri, 10 May 2024, "Lin, Wayne" wrote:
[Public]
-Original Message-----
From: Limonciello, Mario
Sent: Friday, May 10, 2024 3:18 AM
To: Linux regressions mailing list ; Wentland,
Harry
; Lin, Wayne
Cc: ly...@redhat.com; imre.d...
can use.
It's okay this time, but if you end up spinning again for a v3 do that.
> -Original Message-
> From: Nirujogi, Pratap
> Sent: Thursday, May 9, 2024 12:19
> To: Limonciello, Mario ; amd-
> g...@lists.freedesktop.org
> Cc: Deucher, Alexander ; Chan, Benjamin
> (Ko
[Public]
> -Original Message-
> From: Deucher, Alexander
> Sent: Monday, October 23, 2023 09:22
> To: Limonciello, Mario ; amd-
> g...@lists.freedesktop.org
> Cc: Limonciello, Mario ;
> paolo.gent...@canonical.com
> Subject: RE: [PATCH] drm/amd: Disable ASPM for
[AMD Official Use Only - General]
> From: Daniel Miess
>
> [Why]
> eDPs fail to light up with seamless boot enabled
>
> [How]
> When seamless boot is enabled don't configure dpms_off
> in disable_vbios_mode_if_required.
>
> Reviewed-by: Charlene Liu
> Cc: Mario Limonciello
> Cc: Alex Deucher
On 8/19/2023 5:50 AM, Greg KH wrote:
On Fri, Aug 18, 2023 at 05:49:14PM -0500, Limonciello, Mario wrote:
On 8/18/2023 4:24 PM, Greg KH wrote:
On Fri, Aug 18, 2023 at 11:26:11AM +0800, Evan Quan wrote:
drivers/base/Makefile | 1 +
drivers/base/wbrf.c
On 8/18/2023 4:24 PM, Greg KH wrote:
On Fri, Aug 18, 2023 at 11:26:11AM +0800, Evan Quan wrote:
drivers/base/Makefile | 1 +
drivers/base/wbrf.c | 280 ++
Why is a wifi-specific thing going into drivers/base/?
confused,
On 7/31/2023 11:15 AM, Hamza Mahfooz wrote:
On 7/31/23 12:08, Mario Limonciello wrote:
Some systems are only connected by HDMI or DP, so warning related to
missing eDP is unnecessary. Downgrade to debug instead.
Cc: Hamza Mahfooz
Fixes: 6d9b6dceaa51 ("drm/amd/display: only warn once in
On 7/31/2023 8:26 AM, Ruan Jinjie wrote:
Ther are many ternary operators, the true or false judgement
of which is unnecessary in C language semantics.
s/Ther/There/
Unnecessary; sure. But don't they improve the readability quite a bit?
Signed-off-by: Ruan Jinjie
---
On 7/31/2023 8:26 AM, Ruan Jinjie wrote:
Ther are many ternary operators, the true or false judgement
of which is unnecessary in C language semantics.
s/Ther/There/
Unnecessary; sure. But don't they improve the readability quite a bit?
Signed-off-by: Ruan Jinjie
---
On 7/24/2023 04:22, Andrew Lunn wrote:
@@ -1395,6 +1395,8 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
debugfs_hw_add(local);
rate_control_add_debugfs(local);
+ ieee80211_check_wbrf_support(local);
+
rtnl_lock();
wiphy_lock(hw->wiphy);
+void
On 7/24/2023 04:22, Andrew Lunn wrote:
@@ -1395,6 +1395,8 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
debugfs_hw_add(local);
rate_control_add_debugfs(local);
+ ieee80211_check_wbrf_support(local);
+
rtnl_lock();
wiphy_lock(hw->wiphy);
+void
[Public]
> -Original Message-
> From: Limonciello, Mario
> Sent: Thursday, July 13, 2023 00:15
> To: amd-gfx@lists.freedesktop.org
> Cc: Limonciello, Mario
> Subject: [PATCH] drm/amd: Fix an error handling mistake in psp_sw_init()
>
> If the second call to
On 7/14/2023 6:05 AM, Guchun Chen wrote:
Recent code set xcp_id stored from file private data when opening
device to amdgpu bo for accounting memory usage etc, but not all
VMs are attached to this fpriv structure like the vm cases in
amdgpu_mes_self_test, otherwise, KASAN will complain below
[AMD Official Use Only - General]
OK, will pick up 1/2/3 and continue to think about 4.
> -Original Message-
> From: Quan, Evan
> Sent: Sunday, July 9, 2023 20:54
> To: Limonciello, Mario ; amd-
> g...@lists.freedesktop.org
> Subject: RE: [PATCH
+regressions
On 7/10/2023 04:58, Thomas Zimmermann wrote:
Hi
Am 10.07.23 um 11:52 schrieb Javier Martinez Canillas:
Thomas Zimmermann writes:
Hello Thomas,
Generate a hotplug event after registering a client to allow the
client to configure its display. Remove the hotplug calls from the
+regressions
On 7/10/2023 04:58, Thomas Zimmermann wrote:
Hi
Am 10.07.23 um 11:52 schrieb Javier Martinez Canillas:
Thomas Zimmermann writes:
Hello Thomas,
Generate a hotplug event after registering a client to allow the
client to configure its display. Remove the hotplug calls from the
+regressions
On 7/10/2023 04:58, Thomas Zimmermann wrote:
Hi
Am 10.07.23 um 11:52 schrieb Javier Martinez Canillas:
Thomas Zimmermann writes:
Hello Thomas,
Generate a hotplug event after registering a client to allow the
client to configure its display. Remove the hotplug calls from the
[AMD Official Use Only - General]
Thanks. I'm going to leave this series as the backup option, have another idea
that I'll have Koba try first.
> -Original Message-
> From: Quan, Evan
> Sent: Wednesday, July 5, 2023 20:04
> To: Limonciello, Mario ; amd-
> g...@lists.
Nevertheless: thx for your report your help through this thread.
No problem. I am willing to try to do more, but right now I don't know
how to do what has been suggested.
Here is where to report Nouveau bugs:
https://gitlab.freedesktop.org/drm/nouveau/-/issues/
Nevertheless: thx for your report your help through this thread.
No problem. I am willing to try to do more, but right now I don't know
how to do what has been suggested.
Here is where to report Nouveau bugs:
https://gitlab.freedesktop.org/drm/nouveau/-/issues/
On 6/30/2023 05:32, Evan Quan wrote:
Due to electrical and mechanical constraints in certain platform designs
there may be likely interference of relatively high-powered harmonics of
the (G-)DDR memory clocks with local radio module frequency bands used
by Wifi 6/6e/7.
To mitigate this, AMD has
On 6/30/2023 05:32, Evan Quan wrote:
Due to electrical and mechanical constraints in certain platform designs
there may be likely interference of relatively high-powered harmonics of
the (G-)DDR memory clocks with local radio module frequency bands used
by Wifi 6/6e/7.
To mitigate this, AMD has
[AMD Official Use Only - General]
> -Original Message-
> From: Jerry Snitselaar
> Sent: Thursday, June 29, 2023 12:43 PM
> To: Limonciello, Mario
> Cc: Michael Ellerman ; Linux regressions mailing list
> ; Sachin Sant ; open
> list ; linuxppc-dev d...@l
eedesktop.org; Joonas Lahtinen
> ; dri-devel@lists.freedesktop.org; Chai,
> Thomas ; Limonciello, Mario
> ; Gao, Likun ; David
> Airlie ; Ville Syrjala ; Yi
> Liu
> ; k...@vger.kernel.org; amd-...@lists.freedesktop.org;
> Jason Gunthorpe ; Ben Skeggs ; linux-
> p..
eedesktop.org; Joonas Lahtinen
> ; dri-de...@lists.freedesktop.org; Chai,
> Thomas ; Limonciello, Mario
> ; Gao, Likun ; David
> Airlie ; Ville Syrjala ; Yi
> Liu
> ; k...@vger.kernel.org; amd-gfx@lists.freedesktop.org;
> Jason Gunthorpe ; Ben Skeggs ; linux-
> p..
eedesktop.org; Joonas Lahtinen
> ; dri-de...@lists.freedesktop.org; Chai,
> Thomas ; Limonciello, Mario
> ; Gao, Likun ; David
> Airlie ; Ville Syrjala ; Yi
> Liu
> ; k...@vger.kernel.org; amd-...@lists.freedesktop.org;
> Jason Gunthorpe ; Ben Skeggs ; linux-
> p..
eedesktop.org; Joonas Lahtinen
> ; dri-de...@lists.freedesktop.org; Chai,
> Thomas ; Limonciello, Mario
> ; Gao, Likun ; David
> Airlie ; Ville Syrjala ; Yi
> Liu
> ; k...@vger.kernel.org; amd-...@lists.freedesktop.org;
> Jason Gunthorpe ; Ben Skeggs ; linux-
> p..
[Public]
> -Original Message-
> From: Jerry Snitselaar
> Sent: Thursday, June 29, 2023 12:07 PM
> To: Limonciello, Mario
> Cc: Michael Ellerman ; Linux regressions mailing list
> ; Sachin Sant ; open
> list ; linuxppc-dev d...@lists.ozlabs.org>; jar...@
[Public]
> -Original Message-
> From: Limonciello, Mario
> Sent: Monday, June 26, 2023 12:45 PM
> To: Hersen Wu ; amd-gfx@lists.freedesktop.org;
> Wentland, Harry
> Cc: Wu, Hersen
> Subject: RE: [PATCH] Revert "drm/amd/display: edp do not add non-edid
> timi
[Public]
> This change causes regression when eDP and external display in mirror
> mode. When external display supports low resolution than eDP, use eDP
> timing to driver external display may cause corruption on external
> display.
>
> This reverts commit
On 6/26/2023 10:05 AM, Alex Deucher wrote:
On Mon, Jun 26, 2023 at 11:00 AM Mario Limonciello
wrote:
`pcie_index` and `pcie_data` aren't used by
amdgpu_device_indirect_wreg() since commit 65ba96e91b68
("drm/amdgpu: Move to common indirect reg access helper") but
the documentation wasn't
[AMD Official Use Only - General]
> -Original Message-
> From: Li, Sun peng (Leo)
> Sent: Friday, June 23, 2023 2:27 PM
> To: Limonciello, Mario ; amd-
> g...@lists.freedesktop.org
> Cc: Lin, Tsung-hua (Ryan) ; Rossi, Marc
> ; Wang, Sean ; Mahfooz,
> Hamza
> S
On 6/23/2023 11:28 AM, Rafael J. Wysocki wrote:
On Fri, Jun 23, 2023 at 5:57 PM Limonciello, Mario
wrote:
On 6/23/2023 9:52 AM, Rafael J. Wysocki wrote:
On Wed, Jun 21, 2023 at 7:47 AM Evan Quan wrote:
From: Mario Limonciello
Due to electrical and mechanical constraints in certain
On 6/23/2023 11:28 AM, Rafael J. Wysocki wrote:
On Fri, Jun 23, 2023 at 5:57 PM Limonciello, Mario
wrote:
On 6/23/2023 9:52 AM, Rafael J. Wysocki wrote:
On Wed, Jun 21, 2023 at 7:47 AM Evan Quan wrote:
From: Mario Limonciello
Due to electrical and mechanical constraints in certain
On 6/23/2023 9:52 AM, Rafael J. Wysocki wrote:
On Wed, Jun 21, 2023 at 7:47 AM Evan Quan wrote:
From: Mario Limonciello
Due to electrical and mechanical constraints in certain platform designs
there may be likely interference of relatively high-powered harmonics of
the (G-)DDR memory
On 6/23/2023 9:52 AM, Rafael J. Wysocki wrote:
On Wed, Jun 21, 2023 at 7:47 AM Evan Quan wrote:
From: Mario Limonciello
Due to electrical and mechanical constraints in certain platform designs
there may be likely interference of relatively high-powered harmonics of
the (G-)DDR memory
On 6/22/2023 7:36 AM, Michael Ellerman wrote:
"Linux regression tracking (Thorsten Leemhuis)"
writes:
Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
for once, to make this easily accessible to everyone.
As Linus will likely release 6.4 on this or the following Sunday
On 6/21/2023 8:55 PM, Andrew Lunn wrote:
Honestly I'm not sure though we need this complexity right now? I mean,
it'd be really easy to replace the calls in mac80211 with some other
more generalised calls in the future?
You need some really deep platform/hardware level knowledge and
On 6/21/2023 8:55 PM, Andrew Lunn wrote:
Honestly I'm not sure though we need this complexity right now? I mean,
it'd be really easy to replace the calls in mac80211 with some other
more generalised calls in the future?
You need some really deep platform/hardware level knowledge and
So if we go down this path of CONFIG_WBRF and CONFIG_WBRF_ACPI, another
question would be where should the new "wbrf.c" be stored? The ACPI only
version most certainly made sense in drivers/acpi/wbrf.c, but a generic
version that only has an ACPI implementation right now not so much.
On
So if we go down this path of CONFIG_WBRF and CONFIG_WBRF_ACPI, another
question would be where should the new "wbrf.c" be stored? The ACPI only
version most certainly made sense in drivers/acpi/wbrf.c, but a generic
version that only has an ACPI implementation right now not so much.
On
On 6/21/2023 12:26 PM, Andrew Lunn wrote:
I think what you're asking for is another layer of indirection
like CONFIG_WBRF in addition to CONFIG_ACPI_WBRF.
Producers would call functions like wbrf_supported_producer()
where the source file is not guarded behind CONFIG_ACPI_WBRF,
but instead by
On 6/21/2023 12:26 PM, Andrew Lunn wrote:
I think what you're asking for is another layer of indirection
like CONFIG_WBRF in addition to CONFIG_ACPI_WBRF.
Producers would call functions like wbrf_supported_producer()
where the source file is not guarded behind CONFIG_ACPI_WBRF,
but instead by
On 6/21/2023 11:52 AM, Andrew Lunn wrote:
On Wed, Jun 21, 2023 at 11:15:00AM -0500, Limonciello, Mario wrote:
On 6/21/2023 10:39 AM, Johannes Berg wrote:
On Wed, 2023-06-21 at 17:36 +0200, Andrew Lunn wrote:
On Wed, Jun 21, 2023 at 01:45:56PM +0800, Evan Quan wrote:
From: Mario Limonciello
On 6/21/2023 11:52 AM, Andrew Lunn wrote:
On Wed, Jun 21, 2023 at 11:15:00AM -0500, Limonciello, Mario wrote:
On 6/21/2023 10:39 AM, Johannes Berg wrote:
On Wed, 2023-06-21 at 17:36 +0200, Andrew Lunn wrote:
On Wed, Jun 21, 2023 at 01:45:56PM +0800, Evan Quan wrote:
From: Mario Limonciello
On 6/21/2023 11:31 AM, Andrew Lunn wrote:
I think there is enough details for this to happen. It's done
so that either the AML can natively behave as a consumer or a
driver can behave as a consumer.
+/**
+ * APIs needed by drivers/subsystems for contributing frequencies:
+ * During probe,
On 6/21/2023 11:31 AM, Andrew Lunn wrote:
I think there is enough details for this to happen. It's done
so that either the AML can natively behave as a consumer or a
driver can behave as a consumer.
+/**
+ * APIs needed by drivers/subsystems for contributing frequencies:
+ * During probe,
On 6/21/2023 11:14 AM, Andrew Lunn wrote:
Do only ACPI based systems have:
interference of relatively high-powered harmonics of the (G-)DDR
memory clocks with local radio module frequency bands used by
Wifi 6/6e/7."
Could Device Tree based systems not experience this problem?
On 6/21/2023 11:14 AM, Andrew Lunn wrote:
Do only ACPI based systems have:
interference of relatively high-powered harmonics of the (G-)DDR
memory clocks with local radio module frequency bands used by
Wifi 6/6e/7."
Could Device Tree based systems not experience this problem?
On 6/21/2023 10:39 AM, Johannes Berg wrote:
On Wed, 2023-06-21 at 17:36 +0200, Andrew Lunn wrote:
On Wed, Jun 21, 2023 at 01:45:56PM +0800, Evan Quan wrote:
From: Mario Limonciello
Due to electrical and mechanical constraints in certain platform designs
there may be likely interference of
On 6/21/2023 10:39 AM, Johannes Berg wrote:
On Wed, 2023-06-21 at 17:36 +0200, Andrew Lunn wrote:
On Wed, Jun 21, 2023 at 01:45:56PM +0800, Evan Quan wrote:
From: Mario Limonciello
Due to electrical and mechanical constraints in certain platform designs
there may be likely interference of
On 6/21/2023 5:22 AM, Johannes Berg wrote:
On Wed, 2023-06-21 at 13:45 +0800, Evan Quan wrote:
To support AMD's WBRF interference mitigation mechanism, Wifi adapters
utilized in the system must register the frequencies in use(or unregister
those frequencies no longer used) via the dedicated
On 6/21/2023 5:22 AM, Johannes Berg wrote:
On Wed, 2023-06-21 at 13:45 +0800, Evan Quan wrote:
To support AMD's WBRF interference mitigation mechanism, Wifi adapters
utilized in the system must register the frequencies in use(or unregister
those frequencies no longer used) via the dedicated
[Public]
You've got an A-b from Evan already on this. It looks fine to me too.
Reviewed-by: Mario Limonciello
> -Original Message-
> From: Yang, WenYou
> Sent: Sunday, June 11, 2023 12:53 AM
> To: Yang, WenYou ; Deucher, Alexander
> ; Limonciello, Mario
> ; Koenig,
[Public]
You've got an A-b from Evan already on this. It looks fine to me too.
Reviewed-by: Mario Limonciello
> -Original Message-
> From: Yang, WenYou
> Sent: Sunday, June 11, 2023 12:53 AM
> To: Yang, WenYou ; Deucher, Alexander
> ; Limonciello, Mario
> ; Koenig,
On 6/12/2023 2:25 PM, Sui Jingfeng wrote:
From: Sui Jingfeng
Deal only with the VGA devcie(pdev->class == 0x0300), so replace the
pci_get_subsys() function with pci_get_class(). Filter the non-PCI display
device(pdev->class != 0x0300) out. There no need to process the non-display
PCI device.
On 6/12/2023 2:25 PM, Sui Jingfeng wrote:
From: Sui Jingfeng
Deal only with the VGA devcie(pdev->class == 0x0300), so replace the
pci_get_subsys() function with pci_get_class(). Filter the non-PCI display
device(pdev->class != 0x0300) out. There no need to process the non-display
PCI device.
On 6/12/2023 2:25 PM, Sui Jingfeng wrote:
From: Sui Jingfeng
Deal only with the VGA devcie(pdev->class == 0x0300), so replace the
pci_get_subsys() function with pci_get_class(). Filter the non-PCI display
device(pdev->class != 0x0300) out. There no need to process the non-display
PCI device.
On 6/12/2023 2:25 PM, Sui Jingfeng wrote:
From: Sui Jingfeng
Deal only with the VGA devcie(pdev->class == 0x0300), so replace the
pci_get_subsys() function with pci_get_class(). Filter the non-PCI display
device(pdev->class != 0x0300) out. There no need to process the non-display
PCI device.
[AMD Official Use Only - General]
> -Original Message-
> From: Limonciello, Mario
> Sent: Wednesday, June 7, 2023 1:53 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Limonciello, Mario
> Subject: [PATCH 2/2] drm/amd: Tighten permissions on VBIOS flashing
> attribut
[Public]
> On 2023-06-02 08:18, Mario Limonciello wrote:
> > It's pointless on laptops to look for the SRAT table as these are not
> > NUMA. Check the number of possible nodes is > 1 to decide whether to
> > look for SRAT.
> >
> > Suggested-by: Felix Kuehling
> > Signed-off-by: Mario
On 6/5/2023 9:28 AM, Alex Deucher wrote:
Since there is overlap in supported devices, both
modules load, but only one will bind to a particular
device depending on the user's configuration. Drop
the message in the module init function as this can
be confusing to users.
Link:
[AMD Official Use Only - General]
> -Original Message-
> From: Nick Hastings
> Sent: Thursday, June 1, 2023 7:02 PM
> To: Karol Herbst
> Cc: Limonciello, Mario ; Lyude Paul
> ; Lukas Wunner ; Salvatore
> Bonaccorso ; 1036...@bugs.debian.org; Rafael J.
> Wys
[AMD Official Use Only - General]
> -Original Message-
> From: Nick Hastings
> Sent: Thursday, June 1, 2023 7:02 PM
> To: Karol Herbst
> Cc: Limonciello, Mario ; Lyude Paul
> ; Lukas Wunner ; Salvatore
> Bonaccorso ; 1036...@bugs.debian.org; Rafael J.
> Wys
[AMD Official Use Only - General]
> -Original Message-
> From: Alex Deucher
> Sent: Thursday, June 1, 2023 11:15 AM
> To: Limonciello, Mario
> Cc: amd-gfx@lists.freedesktop.org; Rafael Ávila de Espíndola
>
> Subject: Re: [PATCH v2 1/2] drm/amd: Disallow s0ix
[AMD Official Use Only - General]
> -Original Message-
> From: Karol Herbst
> Sent: Thursday, June 1, 2023 12:19 PM
> To: Limonciello, Mario
> Cc: Nick Hastings ; Lyude Paul
> ; Lukas Wunner ; Salvatore
> Bonaccorso ; 1036...@bugs.debian.org; Rafael J.
> Wys
[AMD Official Use Only - General]
> -Original Message-
> From: Karol Herbst
> Sent: Thursday, June 1, 2023 12:19 PM
> To: Limonciello, Mario
> Cc: Nick Hastings ; Lyude Paul
> ; Lukas Wunner ; Salvatore
> Bonaccorso ; 1036...@bugs.debian.org; Rafael J.
> Wys
[AMD Official Use Only - General]
> -Original Message-
> From: Karol Herbst
> Sent: Thursday, June 1, 2023 11:33 AM
> To: Limonciello, Mario
> Cc: Nick Hastings ; Lyude Paul
> ; Lukas Wunner ; Salvatore
> Bonaccorso ; 1036...@bugs.debian.org; Rafael J.
> Wys
[AMD Official Use Only - General]
> -Original Message-
> From: Karol Herbst
> Sent: Thursday, June 1, 2023 11:33 AM
> To: Limonciello, Mario
> Cc: Nick Hastings ; Lyude Paul
> ; Lukas Wunner ; Salvatore
> Bonaccorso ; 1036...@bugs.debian.org; Rafael J.
> Wys
+Lyude, Lukas, Karol
On 5/31/2023 6:40 PM, Nick Hastings wrote:
Hi,
* Nick Hastings [230530 16:01]:
* Mario Limonciello [230530 13:00]:
As you're actually loading nouveau, can you please try nouveau.runpm=0 on
the kernel command line?
I'm not intentionally loading it. This machine also
+Lyude, Lukas, Karol
On 5/31/2023 6:40 PM, Nick Hastings wrote:
Hi,
* Nick Hastings [230530 16:01]:
* Mario Limonciello [230530 13:00]:
As you're actually loading nouveau, can you please try nouveau.runpm=0 on
the kernel command line?
I'm not intentionally loading it. This machine also
[AMD Official Use Only - General]
> -Original Message-
> From: Alex Deucher
> Sent: Wednesday, May 31, 2023 10:22 PM
> To: Limonciello, Mario
> Cc: amd-gfx@lists.freedesktop.org; Rafael Ávila de Espíndola
>
> Subject: Re: [PATCH v2 1/2] drm/amd: Disallow s0ix
On 5/30/2023 4:34 PM, Alex Deucher wrote:
On Tue, May 30, 2023 at 2:19 PM Limonciello, Mario
wrote:
[AMD Official Use Only - General]
-Original Message-
From: Alex Deucher
Sent: Tuesday, May 30, 2023 1:16 PM
To: Limonciello, Mario
Cc: amd-gfx@lists.freedesktop.org; Rafael Ávila
[AMD Official Use Only - General]
> -Original Message-
> From: Limonciello, Mario
> Sent: Tuesday, May 30, 2023 1:38 PM
> To: Rafael Ávila de Espíndola ; Alex Deucher
>
> Cc: amd-gfx@lists.freedesktop.org
> Subject: RE: [PATCH 1/2] drm/amd: Disallow s0ix witho
ix on APUs older than Raven")
> Cheers,
> Rafael
>
> "Limonciello, Mario" writes:
>
> > [AMD Official Use Only - General]
> >
> >> -----Original Message-
> >> From: Alex Deucher
> >> Sent: Tuesday, May 30, 2023 1:16 PM
> >> To
[AMD Official Use Only - General]
> -Original Message-
> From: Alex Deucher
> Sent: Tuesday, May 30, 2023 1:16 PM
> To: Limonciello, Mario
> Cc: amd-gfx@lists.freedesktop.org; Rafael Ávila de Espíndola
>
> Subject: Re: [PATCH 1/2] drm/amd: Disallow s0ix witho
On 5/30/2023 1:22 AM, Felix Fietkau wrote:
On 30.05.23 04:42, Evan Quan wrote:
Due to electrical and mechanical constraints in certain platform
designs there may
be likely interference of relatively high-powered harmonics of the
(G-)DDR memory
clocks with local radio module frequency bands
On 5/30/2023 1:22 AM, Felix Fietkau wrote:
On 30.05.23 04:42, Evan Quan wrote:
Due to electrical and mechanical constraints in certain platform
designs there may
be likely interference of relatively high-powered harmonics of the
(G-)DDR memory
clocks with local radio module frequency bands
I think we replaced this with golden timestamp value which doesn't
require GFX register access.
Ah yes; through
5591a051b86b ("drm/amdgpu: refine get gpu clock counter method")
This wasn't part of the kernel this was originally reported on.
I suspect this would significantly decrease the
On 5/17/2023 12:26 AM, Lazar, Lijo wrote:
On 5/17/2023 10:46 AM, Limonciello, Mario wrote:
On 5/17/2023 12:07 AM, Lazar, Lijo wrote:
On 5/17/2023 10:25 AM, Limonciello, Mario wrote:
On 5/16/2023 11:43 PM, Lazar, Lijo wrote:
On 5/17/2023 5:04 AM, Mario Limonciello wrote:
DCN 3.1.4
On 5/17/2023 12:07 AM, Lazar, Lijo wrote:
On 5/17/2023 10:25 AM, Limonciello, Mario wrote:
On 5/16/2023 11:43 PM, Lazar, Lijo wrote:
On 5/17/2023 5:04 AM, Mario Limonciello wrote:
DCN 3.1.4 s2idle entry will hang
occasionally on s2idle entry, but only if running Wayland and only
when
On 5/16/2023 11:43 PM, Lazar, Lijo wrote:
On 5/17/2023 5:04 AM, Mario Limonciello wrote:
DCN 3.1.4 s2idle entry will hang
occasionally on s2idle entry, but only if running Wayland and only
when using `systemctl suspend`, not `echo mem | tee /sys/power/state`.
This happens because using
On 5/16/2023 4:57 PM, Alex Deucher wrote:
On Tue, May 16, 2023 at 5:50 PM Limonciello, Mario wrote:
On 5/16/2023 4:39 PM, Alex Deucher wrote:
On Tue, May 16, 2023 at 2:15 PM Mario Limonciello
wrote:
On GFX11 if RLC is stopped when not in GFXOFF the system will hang.
Prevent this case
On 5/16/2023 4:39 PM, Alex Deucher wrote:
On Tue, May 16, 2023 at 2:15 PM Mario Limonciello
wrote:
On GFX11 if RLC is stopped when not in GFXOFF the system will hang.
Prevent this case from ever happening.
Tested-by: Juan Martinez
Signed-off-by: Mario Limonciello
---
On 5/2/2023 11:51 AM, Hamza Mahfooz wrote:
As made mention of, in commit 9128e6babf10 ("drm/amdgpu: fix
amdgpu_irq_put call trace in gmc_v10_0_hw_fini") and commit c094b8923bdd
("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini"). It
is meaningless to call amdgpu_irq_put() for
On 5/2/2023 11:51 AM, Hamza Mahfooz wrote:
As made mention of, in commit 9128e6babf10 ("drm/amdgpu: fix
amdgpu_irq_put call trace in gmc_v10_0_hw_fini") and commit c094b8923bdd
("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini"). It
is meaningless to call amdgpu_irq_put() for
[Public]
There was a comment on #852167 that there are no non-systemd tools, but that's
simply not true.
All you need for a suspend is
echo mem | sudo tee /sys/power/state
BTW - there's a reason that systemd refuses to include a lot of hooks and
quirks.
The scripts/quirks/etc that pm-utils
[Public]
> -Original Message-
> From: Quan, Evan
> Sent: Friday, April 21, 2023 02:29
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Limonciello, Mario
> ; Quan, Evan
> Subject: [PATCH] drm/amd/pm: conditionally disable pcie lane switching for
On 4/5/2023 06:29, Aaron Liu wrote:
GFX is in gfxoff mode during s0ix so we shouldn't need to
actually execute kfd_iommu_suspend/kfd_iommu_resume operation.
Signed-off-by: Aaron Liu
Acked-by: Alex Deucher
Reviewed-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8
On 4/7/2023 00:38, Wenyou Yang wrote:
When the SMT changes on the fly, send the message to the PMFW
to notify the SMT status changed.
Changes in v6
1./ Update last_smt_active only when the return from
smu_set_cpu_smt_enable() successfully.
2./ Use smu->adev->pm.fw_version to check smu version,
On 4/6/2023 07:45, Wenyou Yang wrote:
Add a timer to poll the SMT state periodically, if the SMT state
is changed, invoke the interface to notify the PMFW.
Signed-off-by: Wenyou Yang
---
drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 8
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c|
On 4/6/2023 07:45, Wenyou Yang wrote:
When the SMT state is changed on the fly, sent the SMT enable
message to the PMFW to notify it that the SMT state changed.
Add the support to send PPSMC_MSG_SetCClkSMTEnable(0x58) message
to the PMFW for Vangogh.
Signed-off-by: Wenyou Yang
---
On 4/5/2023 06:29, Liu, Aaron wrote:
GFX is in gfxoff mode during s0ix so we shouldn't need to
actually execute kfd_iommu_suspend/kfd_iommu_resume operation.
Signed-off-by: Aaron Liu
---
Probably should add to this patch:
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2449
[Public]
> -Original Message-
> From: SHANMUGAM, SRINIVASAN
>
> Sent: Wednesday, April 5, 2023 10:24
> To: Koenig, Christian ; Deucher, Alexander
> ; Limonciello, Mario
> ; Russell, Kent
> Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN
>
> Subj
top.org
> Cc: Deucher, Alexander ; Limonciello, Mario
> ; Yuan, Perry ; Du,
> Xiaojian ; Ma, Li
> Subject: RE: [PATCH] drm/amdgpu: allow more APUs to do mode2 reset
> when go to S4
>
> [AMD Official Use Only - General]
>
> Please add a Fixes tag:
>
> Fixes: 2bedd3f21
1 - 100 of 413 matches
Mail list logo
