Re: [PATCH] drm/amd: force min_input_signal to 0 on Framework AMD 13/16

2024-06-10 Thread Mario Limonciello
On 6/10/2024 15:12, Thomas Weißschuh wrote: On 2024-06-10 14:58:02+, Mario Limonciello wrote: +Kieran On 6/10/2024 14:26, Thomas Weißschuh wrote: The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minim

Re: [PATCH] drm/amd: force min_input_signal to 0 on Framework AMD 13/16

2024-06-10 Thread Mario Limonciello
On 6/10/2024 15:12, Thomas Weißschuh wrote: On 2024-06-10 14:58:02+, Mario Limonciello wrote: +Kieran On 6/10/2024 14:26, Thomas Weißschuh wrote: The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minim

Re: [PATCH] drm/amd: force min_input_signal to 0 on Framework AMD 13/16

2024-06-10 Thread Mario Limonciello
+Kieran On 6/10/2024 14:26, Thomas Weißschuh wrote: The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minimum display backlight. Introduce a quirk to override "min_input_signal" to "0" which leads to a much lower minimum brightness,

Re: [PATCH] drm/amd: force min_input_signal to 0 on Framework AMD 13/16

2024-06-10 Thread Mario Limonciello
+Kieran On 6/10/2024 14:26, Thomas Weißschuh wrote: The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minimum display backlight. Introduce a quirk to override "min_input_signal" to "0" which leads to a much lower minimum brightness,

Re: [PATCH v2] drm/amd/display: Guard ACPI calls with CONFIG_ACPI

2024-06-10 Thread Mario Limonciello
evice *dev, enum amdgpu_ss ss_state) { return 0; } +static inline void amdgpu_acpi_get_backlight_caps(struct amdgpu_dm_backlight_caps *caps) { } #endif #if defined(CONFIG_ACPI) && defined(CONFIG_SUSPEND) Reviewed-by: Mario Limonciello

Re: [PATCH] drm/amd/display: Guard ACPI calls with CONFIG_ACPI

2024-06-10 Thread Mario Limonciello
On 6/10/2024 09:55, sunpeng...@amd.com wrote: From: Leo Li To fix CONFIG_ACPI disabled build error. Fixes: ec6f30c776ad ("drm/amd/display: Set default brightness according to ACPI") Signed-off-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++ 1 file changed, 6

[Bug 2068738] Re: Kernel update 5.15.0-112 might cause severe problems with specific AMD GPUs

2024-06-09 Thread Mario Limonciello
AFAIK It's a bad backport to 5.15 stable. If it's what I think, here's the fix (IIRC). https://lore.kernel.org/amd-gfx/20240523173031.4212-1-w_ar...@gmx.de/ Try applying that to your 5.15 kernel. -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 2068793] Re: Black screen on restart after update: fix "nomodeset"

2024-06-09 Thread Mario Limonciello
AFAIK It's a bad backport to 5.15 stable. If it's what I think, here's the fix (IIRC). https://lore.kernel.org/amd-gfx/20240523173031.4212-1-w_ar...@gmx.de/ Try applying that to your 5.15 kernel. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed

[PATCH] drm/amd/display: Set default brightness according to ACPI

2024-06-07 Thread Mario Limonciello
that should be used if the system is brought up in AC and DC respectively. Use these values to set up the default brightness when the backlight device is registered. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 drivers/gpu/drm/amd/display/amdgpu

Re: [PATCH v2] drm/amdgpu: Fix the BO release clear memory warning

2024-06-06 Thread Mario Limonciello
On 6/6/2024 15:04, Arunpravin Paneer Selvam wrote: This happens when the amdgpu_bo_release_notify running before amdgpu_ttm_set_buffer_funcs_status set the buffer funcs to enabled. check the buffer funcs enablement before calling the fill buffer memory. v2:(Christian) - Apply it only for

[Bug 2067997] Re: Lenovo T14 Gen3 AMD laptop freezes shortly after suspend resume

2024-06-06 Thread Mario Limonciello
*** This bug is a duplicate of bug 2064595 *** https://bugs.launchpad.net/bugs/2064595 ** This bug has been marked a duplicate of bug 2064595 S2idle regression -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

Re: [syzbot] [mm?] general protection fault in dequeue_hugetlb_folio_nodemask

2024-06-06 Thread Mario Limonciello
/8992fc8fe046/bzImage-0e1980c4.xz The issue was bisected to: commit cd94d1b182d2986378550c9087571991bfee01d4 Author: Mario Limonciello Date: Thu May 2 18:32:17 2024 + dm/amd/pm: Fix problems with reboot/shutdown for some SMU 13.0.4/13.0.11 users bisection log: https

Re: [syzbot] [mm?] general protection fault in dequeue_hugetlb_folio_nodemask

2024-06-06 Thread Mario Limonciello
/8992fc8fe046/bzImage-0e1980c4.xz The issue was bisected to: commit cd94d1b182d2986378550c9087571991bfee01d4 Author: Mario Limonciello Date: Thu May 2 18:32:17 2024 + dm/amd/pm: Fix problems with reboot/shutdown for some SMU 13.0.4/13.0.11 users bisection log: https

[Bug 2067997] Re: Lenovo T14 Gen3 AMD laptop freezes shortly after suspend resume

2024-06-05 Thread Mario Limonciello
Should be a duplicate of that. It was fixed in upstream 6.8.5, Ubuntu's 6.8.0-35 is still on 6.8.3. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2067997 Title: Lenovo T14 Gen3 AMD laptop freezes

[PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-05 Thread Mario Limonciello
d be disabled. When the property is restored to an empty bit mask the previous value of ABM and pSR will be restored. Signed-off-by: Mario Limonciello --- v2->v3: * Use `disallow_edp_enter_psr` instead * Drop case in dm_update_crtc_state() --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c |

[PATCH v3 0/2] Add support for 'power saving policy' property

2024-06-05 Thread Mario Limonciello
no requirements then the previous value that would have been programmed will be restored. v2->v3: * Updates from Leo's comments (see individual patches) The matching changes for the igt are here: https://lore.kernel.org/dri-devel/2024050849.33343-1-mario.limoncie...@amd.com/ Mario Limonciello (2)

[PATCH v3 0/2] Add support for 'power saving policy' property

2024-06-05 Thread Mario Limonciello
no requirements then the previous value that would have been programmed will be restored. v2->v3: * Updates from Leo's comments (see individual patches) The matching changes for the igt are here: https://lore.kernel.org/dri-devel/2024050849.33343-1-mario.limoncie...@amd.com/ Mario Limonciello (2)

[PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-05 Thread Mario Limonciello
d be disabled. When the property is restored to an empty bit mask the previous value of ABM and pSR will be restored. Signed-off-by: Mario Limonciello --- v2->v3: * Use `disallow_edp_enter_psr` instead * Drop case in dm_update_crtc_state() --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c |

[PATCH v3 1/2] drm: Introduce 'power saving policy' drm property

2024-06-05 Thread Mario Limonciello
-by: Leo Li Signed-off-by: Mario Limonciello --- v2->v3: * Add tag --- drivers/gpu/drm/drm_connector.c | 46 + include/drm/drm_connector.h | 2 ++ include/drm/drm_mode_config.h | 5 include/uapi/drm/drm_mode.h | 7 + 4 files changed, 60 inserti

[PATCH v3 1/2] drm: Introduce 'power saving policy' drm property

2024-06-05 Thread Mario Limonciello
-by: Leo Li Signed-off-by: Mario Limonciello --- v2->v3: * Add tag --- drivers/gpu/drm/drm_connector.c | 46 + include/drm/drm_connector.h | 2 ++ include/drm/drm_mode_config.h | 5 include/uapi/drm/drm_mode.h | 7 + 4 files changed, 60 inserti

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
If you don't hook into some lid notify event how is one supposed to get the display back to life after opening the lid? I guess in my mind it's a tangential to the "initial modeset". The DRM master can issue a modeset to enable the combination as desired. This code is run whenever

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
If you don't hook into some lid notify event how is one supposed to get the display back to life after opening the lid? I guess in my mind it's a tangential to the "initial modeset". The DRM master can issue a modeset to enable the combination as desired. This code is run whenever

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
On 5/29/2024 09:14, Ville Syrjälä wrote: On Tue, May 28, 2024 at 04:03:19PM -0500, Mario Limonciello wrote: If the lid on a laptop is closed when eDP connectors are populated then it remains enabled when the initial framebuffer configuration is built. When creating the initial framebuffer

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
On 5/29/2024 09:14, Ville Syrjälä wrote: On Tue, May 28, 2024 at 04:03:19PM -0500, Mario Limonciello wrote: If the lid on a laptop is closed when eDP connectors are populated then it remains enabled when the initial framebuffer configuration is built. When creating the initial framebuffer

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
On 5/29/2024 08:55, Alex Deucher wrote: On Wed, May 29, 2024 at 9:51 AM Jani Nikula wrote: On Wed, 29 May 2024, Alex Deucher wrote: On Tue, May 28, 2024 at 5:03 PM Mario Limonciello wrote: If the lid on a laptop is closed when eDP connectors are populated then it remains enabled when

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
On 5/29/2024 08:55, Alex Deucher wrote: On Wed, May 29, 2024 at 9:51 AM Jani Nikula wrote: On Wed, 29 May 2024, Alex Deucher wrote: On Tue, May 28, 2024 at 5:03 PM Mario Limonciello wrote: If the lid on a laptop is closed when eDP connectors are populated then it remains enabled when

[PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
Bainbridge Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3349 Signed-off-by: Mario Limonciello --- Cc: hughsi...@gmail.com v1->v2: * Match LVDS as well --- drivers/gpu/drm/drm_client_modeset.c | 30 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/

[PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-28 Thread Mario Limonciello
Bainbridge Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3349 Signed-off-by: Mario Limonciello --- Cc: hughsi...@gmail.com v1->v2: * Match LVDS as well --- drivers/gpu/drm/drm_client_modeset.c | 30 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/

[PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-28 Thread Mario Limonciello
Bainbridge Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3349 Signed-off-by: Mario Limonciello --- Cc: hughsi...@gmail.com v1->v2: * Match LVDS as well --- drivers/gpu/drm/drm_client_modeset.c | 30 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/

Re: Refine the firmware-updates exception

2024-05-28 Thread Mario Limonciello
Ping? From: Mario Limonciello Sent: Wednesday, May 1, 2024 10:32:49 AM To: Robie Basak ; Mario Limonciello Cc: ubuntu-release@lists.ubuntu.com ; Richard Hughes Subject: Re: Refine the firmware-updates exception Robie, My apologies; my email didn't get

Re: [PATCH] drm/amd/amdgpu: Fix 'snprintf' output truncation warning

2024-05-28 Thread Mario Limonciello
rted this you should add a "Reported-by:" tag for it. Otherwise LGTM (feel free to add that tag when committing). Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdg

[Bug 2063143] Re: sddm/simpledrm race conditions leads to frequent black display on bootup

2024-05-27 Thread Mario Limonciello
I posted some idea over to the systemd bug on a way to approach this from systemd instead of each greeter. https://github.com/systemd/systemd/issues/32509#issuecomment-2134152084 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 2063143] Re: sddm/simpledrm race conditions leads to frequent black display on bootup

2024-05-27 Thread Mario Limonciello
I posted some idea over to the systemd bug on a way to approach this from systemd instead of each greeter. https://github.com/systemd/systemd/issues/32509#issuecomment-2134152084 -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to sddm in

[Bug 2063983] Re: simpledrm / lightdm race condition leads to black screen

2024-05-27 Thread Mario Limonciello
The discussion upstream on dri-devel has mostly settled upon userspace greeters need to support hot-unplug. https://lore.kernel.org/dri-devel/ZkyZCmMU86nUV4TO@phenom.ffwll.local/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 2063983] Re: simpledrm / lightdm race condition leads to black screen

2024-05-27 Thread Mario Limonciello
Can someone with an affected system raise a bug report upstream to lightdm? There was a very similar bug that occurred in GDM last year: https://gitlab.gnome.org/GNOME/mutter/-/issues/2909 And there is a similar report opened with SDDM: https://github.com/sddm/sddm/issues/1917 ** Summary

[Bug 2063143] Re: sddm/lightdm race conditions leads to frequent black display on bootup

2024-05-27 Thread Mario Limonciello
** Summary changed: - Frequent boot to black display + sddm/lightdm race conditions leads to frequent black display on bootup ** Summary changed: - sddm/lightdm race conditions leads to frequent black display on bootup + sddm/simpledrm race conditions leads to frequent black display on bootup

[Bug 2063143] Re: sddm/lightdm race conditions leads to frequent black display on bootup

2024-05-27 Thread Mario Limonciello
** Summary changed: - Frequent boot to black display + sddm/lightdm race conditions leads to frequent black display on bootup ** Summary changed: - sddm/lightdm race conditions leads to frequent black display on bootup + sddm/simpledrm race conditions leads to frequent black display on bootup

[Bug 2063983] Re: 24.04 Upgrade/Fresh Install results in black screen on reboot on AMDGPU system

2024-05-27 Thread Mario Limonciello
** Package changed: linux (Ubuntu) => lightdm (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2063983 Title: 24.04 Upgrade/Fresh Install results in black screen on reboot on AMDGPU system

[PATCH] drm/client: Detect when ACPI lid is closed during initialization

2024-05-27 Thread Mario Limonciello
Reported-by: Chris Bainbridge Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3349 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/drm_client_modeset.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu

[PATCH] drm/client: Detect when ACPI lid is closed during initialization

2024-05-27 Thread Mario Limonciello
Reported-by: Chris Bainbridge Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3349 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/drm_client_modeset.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu

[PATCH] drm/client: Detect when ACPI lid is closed during initialization

2024-05-27 Thread Mario Limonciello
Reported-by: Chris Bainbridge Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3349 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/drm_client_modeset.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu

[Bug 2065321] Re: Kubuntu 24.04 Second boot always black screen

2024-05-27 Thread Mario Limonciello
*** This bug is a duplicate of bug 2063143 *** https://bugs.launchpad.net/bugs/2063143 ** This bug has been marked a duplicate of bug 2063143 Frequent boot to black display -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 2065321] Re: Kubuntu 24.04 Second boot always black screen

2024-05-27 Thread Mario Limonciello
*** This bug is a duplicate of bug 2063143 *** https://bugs.launchpad.net/bugs/2063143 ** This bug has been marked a duplicate of bug 2063143 Frequent boot to black display -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to the bug

[PATCH] drm/amd: Fix shutdown (again) on some SMU v13.0.4/11 platforms

2024-05-26 Thread Mario Limonciello
kages/issues/50417 Cc: sta...@vger.kernel.org Fixes: cd94d1b182d2 ("dm/amd/pm: Fix problems with reboot/shutdown for some SMU 13.0.4/13.0.11 users") Signed-off-by: Mario Limonciello --- Cc: regressi...@lists.linux.dev --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c | 20 ++-

[Bug 2066345] Re: Lenovo T14 Gen3 AMD laptop lid suspend freezes system

2024-05-22 Thread Mario Limonciello
This should be a duplicate of https://bugs.launchpad.net/ubuntu/+source/linux-oem-6.5/+bug/2064595 The fix is https://github.com/torvalds/linux/commit/ca299b4512d4b4f516732a48ce9aa19d91f4473e -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 2065838] Re: System crash on resume from sleep

2024-05-22 Thread Mario Limonciello
Do you have secure boot enabled? if so, turn it off and hopefully the kernel you built should be bootadble. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2065838 Title: System crash on resume from

[PATCH v2 3/4] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-05-22 Thread Mario Limonciello
From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has indicated that userspace prefers to have color accuracy and fidelity instead of power saving. Verify that the sysfs file behaves as expected in this situation. Signed-off-by: Mario L

[PATCH v2 4/4] tests/amdgpu/amd_psr: Add support for `power saving policy` property

2024-05-22 Thread Mario Limonciello
Verify that the property has disabled PSR --- tests/amdgpu/amd_psr.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.c index 9da161a09..a9f4a6aa5 100644 --- a/tests/amdgpu/amd_psr.c +++

[PATCH v2 3/4] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-05-22 Thread Mario Limonciello
From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has indicated that userspace prefers to have color accuracy and fidelity instead of power saving. Verify that the sysfs file behaves as expected in this situation. Signed-off-by: Mario L

[PATCH v2 2/4] tests/amdgpu/amd_abm: Make set_abm_level return type int

2024-05-22 Thread Mario Limonciello
From: Mario Limonciello In order to bubble of cases of expeted errors on set_abm_level() change the return type to int. Signed-off-by: Mario Limonciello --- tests/amdgpu/amd_abm.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/tests

[PATCH v2 2/4] tests/amdgpu/amd_abm: Make set_abm_level return type int

2024-05-22 Thread Mario Limonciello
From: Mario Limonciello In order to bubble of cases of expeted errors on set_abm_level() change the return type to int. Signed-off-by: Mario Limonciello --- tests/amdgpu/amd_abm.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/tests

[PATCH v2 4/4] tests/amdgpu/amd_psr: Add support for `power saving policy` property

2024-05-22 Thread Mario Limonciello
Verify that the property has disabled PSR --- tests/amdgpu/amd_psr.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.c index 9da161a09..a9f4a6aa5 100644 --- a/tests/amdgpu/amd_psr.c +++

[PATCH v2 0/4] Add support for testing power saving policy DRM property

2024-05-22 Thread Mario Limonciello
quirements. This set of IGT changes introduces a new subtest that will cover the expected kernel behavior when switching between requirements. Mario Limonciello (4): Add support for API for drivers to set power saving policy tests/amdgpu/amd_abm: Make set_abm_level return type int tests/amdgpu/am

[PATCH v2 1/4] Add support for API for drivers to set power saving policy

2024-05-22 Thread Mario Limonciello
--- lib/igt_kms.c | 26 ++ lib/igt_kms.h | 6 ++ 2 files changed, 32 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index af63d13b1..4ce5e4a95 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -6581,3 +6581,29 @@ int get_num_scalers(int drm_fd, enum pipe

[PATCH v2 1/4] Add support for API for drivers to set power saving policy

2024-05-22 Thread Mario Limonciello
--- lib/igt_kms.c | 26 ++ lib/igt_kms.h | 6 ++ 2 files changed, 32 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index af63d13b1..4ce5e4a95 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -6581,3 +6581,29 @@ int get_num_scalers(int drm_fd, enum pipe

[PATCH v2 0/4] Add support for testing power saving policy DRM property

2024-05-22 Thread Mario Limonciello
quirements. This set of IGT changes introduces a new subtest that will cover the expected kernel behavior when switching between requirements. Mario Limonciello (4): Add support for API for drivers to set power saving policy tests/amdgpu/amd_abm: Make set_abm_level return type int tests/amdgpu/am

[PATCH v2 1/2] drm: Introduce 'power saving policy' drm property

2024-05-22 Thread Mario Limonciello
-by: Mario Limonciello --- drivers/gpu/drm/drm_connector.c | 46 + include/drm/drm_connector.h | 2 ++ include/drm/drm_mode_config.h | 5 include/uapi/drm/drm_mode.h | 7 + 4 files changed, 60 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v2 0/2] Add support for 'power saving policy' property

2024-05-22 Thread Mario Limonciello
no requirements then the previous value that would have been programmed will be restored. --- v1->v2: * New property as a bitmask * Handle both ABM and PSR/PSR2 * Add documentation Mario Limonciello (2): drm: Introduce 'power saving policy' drm property drm/amd: Add power_saving_pol

[PATCH v2 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-05-22 Thread Mario Limonciello
d be disabled. When the property is restored to an empty bit mask the previous value of ABM and pSR will be restored. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 51 +-- .../gpu/drm/a

[PATCH v2 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-05-22 Thread Mario Limonciello
d be disabled. When the property is restored to an empty bit mask the previous value of ABM and pSR will be restored. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 51 +-- .../gpu/drm/a

[PATCH v2 1/2] drm: Introduce 'power saving policy' drm property

2024-05-22 Thread Mario Limonciello
-by: Mario Limonciello --- drivers/gpu/drm/drm_connector.c | 46 + include/drm/drm_connector.h | 2 ++ include/drm/drm_mode_config.h | 5 include/uapi/drm/drm_mode.h | 7 + 4 files changed, 60 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v2 0/2] Add support for 'power saving policy' property

2024-05-22 Thread Mario Limonciello
no requirements then the previous value that would have been programmed will be restored. --- v1->v2: * New property as a bitmask * Handle both ABM and PSR/PSR2 * Add documentation Mario Limonciello (2): drm: Introduce 'power saving policy' drm property drm/amd: Add power_saving_pol

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-22 Thread Mario Limonciello
is created: https://github.com/torvalds/linux/blob/v6.9/drivers/gpu/drm/drm_connector.c#L2147 I would expect you can make another property for the information you're looking for and then can get it from userspace using standard property APIs. Rino On Tue, May 21, 2024 at 10:55 PM Mario

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-22 Thread Mario Limonciello
is created: https://github.com/torvalds/linux/blob/v6.9/drivers/gpu/drm/drm_connector.c#L2147 I would expect you can make another property for the information you're looking for and then can get it from userspace using standard property APIs. Rino On Tue, May 21, 2024 at 10:55 PM Mario

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-21 Thread Mario Limonciello
On 5/21/2024 15:06, Rino André Johnsen wrote: What is already there in debugfs is 'bpc' and 'colorspace', but not the pixel encoding/format. I have searched high and low for that to be able to verify that my monitor and computer are using my preferred combination of all those three values. I do

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-21 Thread Mario Limonciello
On 5/21/2024 15:06, Rino André Johnsen wrote: What is already there in debugfs is 'bpc' and 'colorspace', but not the pixel encoding/format. I have searched high and low for that to be able to verify that my monitor and computer are using my preferred combination of all those three values. I do

[Bug 2063002] Re: Add support for DCN 3.5

2024-05-21 Thread Mario Limonciello
As the firmware is on it's own stable and by the time this hardware is in market that kernel fix should be picked up adding verification done tag. ** Tags added: verification-done-noble -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 2063002] Re: Add support for DCN 3.5

2024-05-21 Thread Mario Limonciello
Internal team tested this SRU against current generic and OEM kernel and it fails on both because they're missing the fix for https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2066233. After adding in that fix it works. -- You received this bug notification because you are a member of Ubuntu

[Bug 2065839] Re: UBSAN: array-index-out-of-bounds

2024-05-21 Thread Mario Limonciello
** Changed in: linux (Ubuntu) Status: New => Invalid ** No longer affects: linux (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2065839 Title: UBSAN: array-index-out-of-bounds To

Re: [PATCH 0/2] Add support for Panel Power Savings property

2024-05-21 Thread Mario Limonciello
On 5/21/2024 12:27, Leo Li wrote: On 2024-05-21 12:21, Mario Limonciello wrote: On 5/21/2024 11:14, Xaver Hugl wrote: Am Di., 21. Mai 2024 um 16:00 Uhr schrieb Mario Limonciello : On 5/21/2024 08:43, Simon Ser wrote: This makes sense to me in general. I like the fact that it's simple

Re: [PATCH 0/2] Add support for Panel Power Savings property

2024-05-21 Thread Mario Limonciello
On 5/21/2024 12:27, Leo Li wrote: On 2024-05-21 12:21, Mario Limonciello wrote: On 5/21/2024 11:14, Xaver Hugl wrote: Am Di., 21. Mai 2024 um 16:00 Uhr schrieb Mario Limonciello : On 5/21/2024 08:43, Simon Ser wrote: This makes sense to me in general. I like the fact that it's simple

Re: [PATCH v1 0/3] Add support for ISP interrupts and disable prefetch

2024-05-21 Thread Mario Limonciello
/gpu/drm/amd/amdgpu/isp_v4_1_1.c create mode 100644 drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.h create mode 100644 drivers/gpu/drm/amd/include/ivsrcid/isp/irqsrcs_isp_4_1.h Reviewed-by: Mario Limonciello

Re: [PATCH 0/2] Add support for Panel Power Savings property

2024-05-21 Thread Mario Limonciello
On 5/21/2024 11:14, Xaver Hugl wrote: Am Di., 21. Mai 2024 um 16:00 Uhr schrieb Mario Limonciello : On 5/21/2024 08:43, Simon Ser wrote: This makes sense to me in general. I like the fact that it's simple and vendor-neutral. Do we want to hardcode "panel" in the name? A

Re: [PATCH 0/2] Add support for Panel Power Savings property

2024-05-21 Thread Mario Limonciello
On 5/21/2024 11:14, Xaver Hugl wrote: Am Di., 21. Mai 2024 um 16:00 Uhr schrieb Mario Limonciello : On 5/21/2024 08:43, Simon Ser wrote: This makes sense to me in general. I like the fact that it's simple and vendor-neutral. Do we want to hardcode "panel" in the name? A

Re: [PATCH 0/2] Add support for Panel Power Savings property

2024-05-21 Thread Mario Limonciello
On 5/21/2024 08:43, Simon Ser wrote: This makes sense to me in general. I like the fact that it's simple and vendor-neutral. Do we want to hardcode "panel" in the name? Are we sure that this will ever only apply to panels? Do we want to use a name which reflects the intent, rather than the

Re: [PATCH 0/2] Add support for Panel Power Savings property

2024-05-21 Thread Mario Limonciello
On 5/21/2024 08:43, Simon Ser wrote: This makes sense to me in general. I like the fact that it's simple and vendor-neutral. Do we want to hardcode "panel" in the name? Are we sure that this will ever only apply to panels? Do we want to use a name which reflects the intent, rather than the

Re: [PATCH] drm/amd/display: Add pixel encoding info to debugfs

2024-05-20 Thread Mario Limonciello
On 5/20/2024 16:07, Rino Andre Johnsen wrote: [Why] For debugging and testing purposes. [How] Create amdgpu_current_pixelencoding debugfs entry. Usage: cat /sys/kernel/debug/dri/1/crtc-0/amdgpu_current_pixelencoding Signed-off-by: Rino Andre Johnsen ---

Re: [PATCH] drm/amd/display: Add pixel encoding info to debugfs

2024-05-20 Thread Mario Limonciello
On 5/20/2024 16:07, Rino Andre Johnsen wrote: [Why] For debugging and testing purposes. [How] Create amdgpu_current_pixelencoding debugfs entry. Usage: cat /sys/kernel/debug/dri/1/crtc-0/amdgpu_current_pixelencoding Signed-off-by: Rino Andre Johnsen ---

[Bug 2065838] Re: System crash on resume from sleep

2024-05-20 Thread Mario Limonciello
Save the below as a patch file and then apply using "patch -p1 < FILE". Build your kernel and see if it has helped. diff --git a/drivers/acpi/acpica/exregion.c b/drivers/acpi/acpica/exregion.c index 8907b8bf4267..ca060ec6936e 100644 --- a/drivers/acpi/acpica/exregion.c +++

[Bug 2065838] Re: System crash on resume from sleep

2024-05-19 Thread Mario Limonciello
Yes since you didn't clone using git you can't use git revert. Once you can successfully build and test that kernel I'll post you a revert patch' with explanation how to use it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 2065838] Re: System crash on resume from sleep

2024-05-19 Thread Mario Limonciello
Yeah I know they're different symptoms but the reason for that revert might have a similar root cause. I'm saying this because I've got a different system that fails to boot up that reverting that helps. In terms of specific instructions, I'd start with this:

[PATCH 2/2] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-05-19 Thread Mario Limonciello
From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has indicated that userspace prefers to have color accuracy and fidelity instead of power saving. Verify that the sysfs file behaves as expected in this situation. Signed-off-by: Mario L

[PATCH 2/2] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-05-19 Thread Mario Limonciello
From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has indicated that userspace prefers to have color accuracy and fidelity instead of power saving. Verify that the sysfs file behaves as expected in this situation. Signed-off-by: Mario L

[PATCH 0/2] Add support for testing panel power saving DRM property

2024-05-19 Thread Mario Limonciello
color fidelity. This set of IGT changes introduces a new subtest that will cover the expected kernel behavior when switching between Allowed and Forbidden. Mario Limonciello (2): tests/amdgpu/amd_abm: Make set_abm_level return type int tests/amdgpu/amd_abm: Add support for panel_power_savin

[PATCH 0/2] Add support for testing panel power saving DRM property

2024-05-19 Thread Mario Limonciello
color fidelity. This set of IGT changes introduces a new subtest that will cover the expected kernel behavior when switching between Allowed and Forbidden. Mario Limonciello (2): tests/amdgpu/amd_abm: Make set_abm_level return type int tests/amdgpu/amd_abm: Add support for panel_power_savin

[PATCH 1/2] tests/amdgpu/amd_abm: Make set_abm_level return type int

2024-05-19 Thread Mario Limonciello
From: Mario Limonciello In order to bubble of cases of expeted errors on set_abm_level() change the return type to int. Signed-off-by: Mario Limonciello --- tests/amdgpu/amd_abm.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/tests

[PATCH 1/2] tests/amdgpu/amd_abm: Make set_abm_level return type int

2024-05-19 Thread Mario Limonciello
From: Mario Limonciello In order to bubble of cases of expeted errors on set_abm_level() change the return type to int. Signed-off-by: Mario Limonciello --- tests/amdgpu/amd_abm.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/tests

[PATCH 0/2] Add support for Panel Power Savings property

2024-05-19 Thread Mario Limonciello
on will get an -EBUSY return code. When the compositor has restored the value back to "Allowed" then the previous value that would have been programmed will be restored. Mario Limonciello (2): drm: Introduce panel_power_saving drm property drm/amd: Add panel_power_saving drm property

[PATCH 2/2] drm/amd: Add panel_power_saving drm property to eDP connectors

2024-05-19 Thread Mario Limonciello
When the `panel_power_saving` property is set to "Forbidden" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the property is restored to "Allowed" the previous value of ABM will be restored. Signed-off-by: Mario Limon

[PATCH 1/2] drm: Introduce panel_power_saving drm property

2024-05-19 Thread Mario Limonciello
The `panel_power_saving` DRM property is an optional property that can be added to a connector by a driver. This property is for compositors to indicate intent of allowing policy for the driver to use power saving features that may compromise color fidelity. Signed-off-by: Mario Limonciello

[PATCH 1/2] drm: Introduce panel_power_saving drm property

2024-05-19 Thread Mario Limonciello
The `panel_power_saving` DRM property is an optional property that can be added to a connector by a driver. This property is for compositors to indicate intent of allowing policy for the driver to use power saving features that may compromise color fidelity. Signed-off-by: Mario Limonciello

[PATCH 2/2] drm/amd: Add panel_power_saving drm property to eDP connectors

2024-05-19 Thread Mario Limonciello
When the `panel_power_saving` property is set to "Forbidden" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the property is restored to "Allowed" the previous value of ABM will be restored. Signed-off-by: Mario Limon

[PATCH 0/2] Add support for Panel Power Savings property

2024-05-19 Thread Mario Limonciello
on will get an -EBUSY return code. When the compositor has restored the value back to "Allowed" then the previous value that would have been programmed will be restored. Mario Limonciello (2): drm: Introduce panel_power_saving drm property drm/amd: Add panel_power_saving drm property

[PATCH] drm/amd/display: Pass errors from amdgpu_dm_init() up

2024-05-19 Thread Mario Limonciello
Errors in amdgpu_dm_init() are silently ignored and dm_hw_init() will succeed. However often these are fatal errors and it would be better to pass them up. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +- 1 file changed, 5 insertions(+), 1

[Bug 2065838] Re: System crash on resume from sleep

2024-05-18 Thread Mario Limonciello
As a random guess; could this be the same as https://bugzilla.kernel.org/show_bug.cgi?id=218849? Try reverting d410ee5109a1 ("ACPICA: avoid "Info: mapping multiple BARs. Your kernel is fine."") ** Bug watch added: Linux Kernel Bug Tracker #218849

[Bug 2065948] Re: fwupdmgr enable/disable-remote auto-complete is buggy

2024-05-17 Thread Mario Limonciello
Fixed upstream. https://github.com/fwupd/fwupd/pull/7264 ** Changed in: fwupd (Ubuntu) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2065948 Title: fwupdmgr

[Bug 2065874] Re: Can't update firmware on TPM-backed FDE systems

2024-05-16 Thread Mario Limonciello
This is the original bug for deb fwupd: https://github.com/canonical/ubuntu-desktop-installer/issues/2371 This is the original bug for snap fwupd: https://github.com/fwupd/fwupd/issues/6264 The problem is that fwupd (both deb and snap) don't understand the layout that TPM FDE uses. As

[Bug 1942616] Re: Settings Power says high hardware temperature

2024-05-12 Thread Mario Limonciello
It's saying the same thing the GUI does. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942616 Title: Settings Power says high hardware temperature To manage notifications about this bug go to:

[Bug 1942616] Re: Settings Power says high hardware temperature

2024-05-12 Thread Mario Limonciello
How about the command line tool (powerprofilesctl)? Can you switch using that? If it really is a pure GCC bug then you can file it here: https://launchpad.net/ubuntu/+source/gnome-control-center for Ubuntu and here: https://gitlab.gnome.org/GNOME/gnome-control-center for upstream. -- You

[Bug 1942616] Re: Settings Power says high hardware temperature

2024-05-12 Thread Mario Limonciello
You can file it here: https://bugzilla.kernel.org/ Mention your reproduction using a mainline kernel and add your logs. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942616 Title: Settings Power

  1   2   3   4   5   6   7   8   9   10   >