Re: RFR: 8271515: Integration of JEP 417: Vector API (Third Incubator) [v2]

2021-10-14 Thread Paul Sandoz
On Thu, 14 Oct 2021 17:21:25 GMT, Paul Sandoz wrote: >> This PR improves the performance of vector operations that accept masks on >> architectures that support masking in hardware, specifically Intel AVX512 >> and ARM SVE. >> >> On architectures that do n

Re: RFR: 8271515: Integration of JEP 417: Vector API (Third Incubator) [v2]

2021-10-14 Thread Paul Sandoz
t; No API enhancements were required and only a few additional tests were needed. Paul Sandoz has updated the pull request incrementally with one additional commit since the last revision: Apply patch from https://github.com/openjdk/panama-vector/pull/152 - Changes: - all: h

RFR: 8271515: Integration of JEP 417: Vector API (Third Incubator)

2021-10-13 Thread Paul Sandoz
This PR improves the performance of vector operations that accept masks on architectures that support masking in hardware, specifically Intel AVX512 and ARM SVE. On architectures that do not support masking in hardware the same technique as before is applied to most operations, specifically

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v2]

2021-10-12 Thread Paul Sandoz
On Tue, 12 Oct 2021 20:51:02 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-419 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] -

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v2]

2021-10-12 Thread Paul Sandoz
On Tue, 12 Oct 2021 20:51:02 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-419 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] -

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v2]

2021-10-12 Thread Paul Sandoz
On Tue, 12 Oct 2021 20:51:02 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-419 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] -

Re: RFR: 8274412: Add a method to Stream API to consume and close the stream without using try-with-resources

2021-10-11 Thread Paul Sandoz
Hi Tagir, Do you mind if we slow down on this and let the idea bake somewhat, captured in this thread/issue/PR(draft). I am always a little wary of compact-only or fluent-only methods, as I find them harder to justify. In this case I think there might be something more with regards to a

Re: RFR: 8247980: Exclusive execution of java/util/stream tests slows down tier1

2021-09-17 Thread Paul Sandoz
On Wed, 25 Aug 2021 15:52:06 GMT, Igor Ignatyev wrote: >> See the bug report for more details. I would appreciate if people with their >> corporate testing systems would run this through their systems to avoid >> surprises. (ping @RealCLanger, @iignatev). > > the testing in our infra returned

Re: RFR: 8273681: Add Vector API vs Arrays.mismatch intrinsic benchmark [v2]

2021-09-16 Thread Paul Sandoz
On Thu, 16 Sep 2021 19:40:19 GMT, Kartik Ohri wrote: >> Hi all! >> >> Please review this PR to add a benchmark comparing the performance of >> Arrays.mismatch intrinsic in the JDK with that of the Vector API. Kindly >> refer to this [thread] on panama-dev regarding some initial discussion

Re: RFR: 8273711: Remove redundant stream() call before forEach in jdk.jlink

2021-09-14 Thread Paul Sandoz
On Mon, 13 Sep 2021 20:06:08 GMT, Andrey Turbanov wrote: > 8273711: Remove redundant stream() call before forEach in jdk.jlink In some cases you can use a method ref (no need for another review if you update those).

Re: RFR: 8273691: Missing comma after 2021 in GraphemeTestAccessor.java copyright notice

2021-09-13 Thread Paul Sandoz
On Tue, 14 Sep 2021 00:15:31 GMT, David Holmes wrote: > Please review this trivial fix to add the missing comma. > > Thanks, > David Marked as reviewed by psandoz (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5504

Re: RFR: 8273681: Add Vector API vs Arrays.mismatch intrinsic benchmark

2021-09-13 Thread Paul Sandoz
On Fri, 10 Sep 2021 08:32:02 GMT, Kartik Ohri wrote: > Hi all! > > Please review this PR to add a benchmark comparing the performance of > Arrays.mismatch intrinsic in the JDK with that of the Vector API. Kindly > refer to this [thread] on panama-dev regarding some initial discussion about

Re: RFR: 8273681: Add Vector API vs Arrays.mismatch intrinsic benchmark

2021-09-13 Thread Paul Sandoz
On Fri, 10 Sep 2021 08:32:02 GMT, Kartik Ohri wrote: > Hi all! > > Please review this PR to add a benchmark comparing the performance of > Arrays.mismatch intrinsic in the JDK with that of the Vector API. Kindly > refer to this [thread] on panama-dev regarding some initial discussion about

Re: RFR: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules

2021-09-13 Thread Paul Sandoz
On Mon, 23 Aug 2021 21:08:05 GMT, Andrey Turbanov wrote: > Collections.sort is just a wrapper, so it is better to use an instance method > directly. This looks a good change. Either as part of this PR or as a follow up I think it is worth reviewing the comparators passed to the sort method.

Re: RFR: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules

2021-09-13 Thread Paul Sandoz
On Mon, 23 Aug 2021 21:08:05 GMT, Andrey Turbanov wrote: > Collections.sort is just a wrapper, so it is better to use an instance method > directly. This looks a good change. Either as part of this PR or as a follow up I think it is worth reviewing the comparators passed to the sort method.

Re: RFR: 8273450: Fix the copyright header of SVML files

2021-09-07 Thread Paul Sandoz
On Tue, 7 Sep 2021 20:25:25 GMT, Sandhya Viswanathan wrote: > Fix the copyright header of SVML files to match others. > > This was brought up on jdk-dev mailing list: > https://mail.openjdk.java.net/pipermail/jdk-dev/2021-September/005992.html Marked as reviewed by psandoz (Reviewer).

Re: RFR: 8273000: Remove WeakReference-based class initialisation barrier implementation [v2]

2021-09-01 Thread Paul Sandoz
On Wed, 1 Sep 2021 16:16:38 GMT, Vladimir Ivanov wrote: >> Get rid of WeakReference-based logic in >> DirectMethodHandle::checkInitialized() and reimplement it with >> `Unsafe::ensureClassInitialized()`/`shouldBeInitialized()`. >> >> The key observation is that

Re: RFR: 8078641: MethodHandle.asTypeCache can retain classes from unloading

2021-08-26 Thread Paul Sandoz
On Wed, 25 Aug 2021 09:31:51 GMT, Vladimir Ivanov wrote: > `MethodHandle.asTypeCache` keeps a strong reference to adapted `MethodHandle` > and it can introduce a class loader leak through its `MethodType`. > > Proposed fix introduces a 2-level cache (1 element each) where 1st level can > only

Re: RFR: 8273000: Remove WeakReference-based class initialisation barrier implementation

2021-08-26 Thread Paul Sandoz
On Wed, 25 Aug 2021 22:05:24 GMT, Vladimir Ivanov wrote: > Get rid of WeakReference-based logic in > DirectMethodHandle::checkInitialized() and reimplement it with > `Unsafe::ensureClassInitialized()`/`shouldBeInitialized()`. > > The key observation is that `Unsafe::ensureClassInitialized()`

Re: RFR: 8272861: Add a micro benchmark for vector api [v3]

2021-08-26 Thread Paul Sandoz
On Tue, 24 Aug 2021 20:49:52 GMT, Sandhya Viswanathan wrote: >> This pull request adds a micro benchmark for Vector API. >> The Black Scholes algorithm is implemented with and without Vector API. >> We see about ~6x gain with Vector API for this micro benchmark using 256 bit >> vectors. > >

Re: [(Much) faster java.util.LinkedList]

2021-08-23 Thread Paul Sandoz
Hi, Thanks for sharing. I browsed through the code (not a review) and gave it a test drive, generally it looks of good quality. Over time, since LinkedList was added, there are less reasons to use it, thereby making such improvements you propose less impactful. CPU caches have got much

Re: RFR: 8247980: Exclusive execution of java/util/stream tests slows down tier1

2021-08-19 Thread Paul Sandoz
On Thu, 19 Aug 2021 15:15:31 GMT, Aleksey Shipilev wrote: > See the bug report for more details. I would appreciate if people with their > corporate testing systems would run this through their systems to avoid > surprises. (ping @RealCLanger, @iignatev). Struggling to recall all the details.

Re: RFR: 8272137: Make Collection and Optional classes streamable

2021-08-16 Thread Paul Sandoz
On Sun, 15 Aug 2021 01:43:32 GMT, Brian Goetz wrote: > To reiterate: These issues were explored in the JSR 335 EG and it was agreed > that this abstraction did not carry its weight. Yes, we explored this when the Stream API was being designed. It's hard, if not impossible, to capture all

Re: Integrated: 8271888: build error after JDK-8271599

2021-08-04 Thread Paul Sandoz
On Wed, 4 Aug 2021 18:42:08 GMT, Joe Darcy wrote: > Remove extraneous tag to fix build breakage. Marked as reviewed by psandoz (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5002

Re: RFR: 8266054: VectorAPI rotate operation optimization [v13]

2021-07-28 Thread Paul Sandoz
On Tue, 27 Jul 2021 18:31:20 GMT, Sandhya Viswanathan wrote: >> Jatin Bhateja has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 19 commits: >> >> - 8266054: Re-designing benchmark to remove noise. >> - Merge branch 'master' of

Re: [jdk17] RFR: 8268766: Desugaring of pattern matching enum switch should be improved [v6]

2021-06-30 Thread Paul Sandoz
On Wed, 30 Jun 2021 10:23:32 GMT, Jan Lahoda wrote: >> Currently, an enum switch with patterns is desugared in a very non-standard, >> and potentially slow, way. It would be better to use the standard >> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs >> to accept

Re: [jdk17] RFR: 8268766: Desugaring of pattern matching enum switch should be improved [v5]

2021-06-25 Thread Paul Sandoz
On Wed, 23 Jun 2021 11:58:06 GMT, Jan Lahoda wrote: >> Currently, an enum switch with patterns is desugared in a very non-standard, >> and potentially slow, way. It would be better to use the standard >> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs >> to accept

[jdk17] Integrated: 8269246: Scoped ByteBuffer vector access

2021-06-24 Thread Paul Sandoz
On Wed, 23 Jun 2021 19:10:41 GMT, Paul Sandoz wrote: > The Foreign Memory API supports viewing a `MemorySegment` as a `ByteBuffer`, > an instance of which can then be passed to the vector load/store access > methods. > > Such `ByteBuffer` access requires accesses are s

[jdk17] RFR: 8269246: Scoped ByteBuffer vector access

2021-06-23 Thread Paul Sandoz
The Foreign Memory API supports viewing a `MemorySegment` as a `ByteBuffer`, an instance of which can then be passed to the vector load/store access methods. Such `ByteBuffer` access requires accesses are scoped (a method annotated with `ScopedMemoryAccess.Scoped`) and the `ByteBuffer`'s scope

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v7]

2021-06-22 Thread Paul Sandoz
On Tue, 22 Jun 2021 02:58:28 GMT, Yi Yang wrote: > I found that after solving the problem that Preconditions cannot be used > during the VM startup, a series of functions such as > String.checkIndex/checkOffset/.. can also be harmlessly replaced, but this > changeset is somewhat large and may

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v7]

2021-06-22 Thread Paul Sandoz
On Tue, 22 Jun 2021 02:58:28 GMT, Yi Yang wrote: > I found that after solving the problem that Preconditions cannot be used > during the VM startup, a series of functions such as > String.checkIndex/checkOffset/.. can also be harmlessly replaced, but this > changeset is somewhat large and may

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v7]

2021-06-22 Thread Paul Sandoz
On Tue, 22 Jun 2021 02:58:28 GMT, Yi Yang wrote: > I found that after solving the problem that Preconditions cannot be used > during the VM startup, a series of functions such as > String.checkIndex/checkOffset/.. can also be harmlessly replaced, but this > changeset is somewhat large and may

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v6]

2021-06-21 Thread Paul Sandoz
On Mon, 21 Jun 2021 05:17:09 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v6]

2021-06-21 Thread Paul Sandoz
On Mon, 21 Jun 2021 05:17:09 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v6]

2021-06-21 Thread Paul Sandoz
On Mon, 21 Jun 2021 05:17:09 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v2]

2021-06-18 Thread Paul Sandoz
On Fri, 18 Jun 2021 05:54:01 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v2]

2021-06-18 Thread Paul Sandoz
On Fri, 18 Jun 2021 05:54:01 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v2]

2021-06-18 Thread Paul Sandoz
On Fri, 18 Jun 2021 05:54:01 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request

[jdk17] Integrated: 8266518: Refactor and expand scatter/gather tests

2021-06-18 Thread Paul Sandoz
On Mon, 14 Jun 2021 16:26:17 GMT, Paul Sandoz wrote: > Refactor scatter/gather tests to be included in the load/store test classes > and expand to support access between `ShortVector` and and `char[]`, and > access between `ByteVector` and `boolean[]`. > > Vector tests pass on

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible

2021-06-17 Thread Paul Sandoz
On Thu, 17 Jun 2021 10:21:35 GMT, Alan Bateman wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > >

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible

2021-06-17 Thread Paul Sandoz
On Thu, 17 Jun 2021 10:21:35 GMT, Alan Bateman wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > >

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible

2021-06-17 Thread Paul Sandoz
On Thu, 17 Jun 2021 10:21:35 GMT, Alan Bateman wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > >

Re: [jdk17] RFR: 8266518: Refactor and expand scatter/gather tests [v2]

2021-06-17 Thread Paul Sandoz
On Wed, 16 Jun 2021 20:42:56 GMT, Sandhya Viswanathan wrote: >> Paul Sandoz has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove redundatem data providers. > > test/jdk/jdk/incubator/vector/Byte128Vecto

Re: [jdk17] RFR: 8266518: Refactor and expand scatter/gather tests [v2]

2021-06-17 Thread Paul Sandoz
> Refactor scatter/gather tests to be included in the load/store test classes > and expand to support access between `ShortVector` and and `char[]`, and > access between `ByteVector` and `boolean[]`. > > Vector tests pass on linux-x64 linux-aarch64 macosx-x64, and windows-x64.

[jdk17] Integrated: 8268353: Test libsvml.so is and is not present in jdk image

2021-06-17 Thread Paul Sandoz
On Mon, 14 Jun 2021 16:06:04 GMT, Paul Sandoz wrote: > Test that when the jdk.incubator.vector module is present that libsvml.so is > present, and test the opposite case. This pull request has now been integrated. Changeset: 091bc4a1 Author: Paul Sandoz URL:

Re: [jdk17] RFR: 8268353: Test libsvml.so is and is not present in jdk image [v2]

2021-06-16 Thread Paul Sandoz
On Wed, 16 Jun 2021 01:20:39 GMT, Jie Fu wrote: >> Paul Sandoz has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Require C2. > > The test logic should be changed. > > If C2 is absent, libsvml.so woul

Re: [jdk17] RFR: 8268353: Test libsvml.so is and is not present in jdk image [v2]

2021-06-16 Thread Paul Sandoz
> Test that when the jdk.incubator.vector module is present that libsvml.so is > present, and test the opposite case. Paul Sandoz has updated the pull request incrementally with one additional commit since the last revision: Require C2. - Changes: - all:

Re: RFR: 8268768: idea.sh has been updated in surprising and incompatible ways

2021-06-15 Thread Paul Sandoz
On Tue, 15 Jun 2021 14:04:56 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix.

Re: RFR: 8268768: idea.sh has been updated in surprising and incompatible ways

2021-06-15 Thread Paul Sandoz
On Tue, 15 Jun 2021 14:04:56 GMT, Maurizio Cimadamore wrote: > As the title says (please also refer to the JBS issue which describes all the > issues in more details), the IDE support for IntelliJ has been updated with > many enhancements as part of a seemingly innocuous "path handling" fix.

[jdk17] RFR: 8266518: Refactor and expand scatter/gather tests

2021-06-14 Thread Paul Sandoz
Refactor scatter/gather tests to be included in the load/store test classes and expand to support access between `ShortVector` and and `char[]`, and access between `ByteVector` and `boolean[]`. Vector tests pass on linux-x64 linux-aarch64 macosx-x64, and windows-x64. - Commit

[jdk17] RFR: 8268353: Test libsvml.so is and is not present in jdk image

2021-06-14 Thread Paul Sandoz
Test that when the jdk.incubator.vector module is present that libsvml.so is present, and test the opposite case. - Commit messages: - 8268353: Test libsvml.so is and is not present in jdk image Changes: https://git.openjdk.java.net/jdk17/pull/47/files Webrev:

Withdrawn: 8268353: Test libsvml.so is and is not present in jdk image

2021-06-14 Thread Paul Sandoz
On Tue, 8 Jun 2021 23:27:52 GMT, Paul Sandoz wrote: > Test that when the jdk.incubator.vector module is present that libsvml.so is > present, and test the opposite case. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/4421

Re: RFR: 8268192: LambdaMetafactory with invokespecial causes VerificationError [v2]

2021-06-09 Thread Paul Sandoz
On Tue, 8 Jun 2021 15:30:33 GMT, Dan Smith wrote: >> Small bug fix. > > Dan Smith has updated the pull request incrementally with one additional > commit since the last revision: > > Clean up validation of implKind REF_invokeSpecial Marked as reviewed by psandoz (Reviewer). -

RFR: 8268353: Test libsvml.so is and is not present in jdk image

2021-06-08 Thread Paul Sandoz
Test that when the jdk.incubator.vector module is present that libsvml.so is present, and test the opposite case. - Commit messages: - Improve test. - Test for linux and windows - 8268353: Test libsvml.so is and is not present in jdk image Changes:

Re: RFR: 8268339: Upstream: 8267989: Exceptions thrown during upcalls should be handled (Pt. 2) [v5]

2021-06-08 Thread Paul Sandoz
On Tue, 8 Jun 2021 17:34:58 GMT, Jorn Vernee wrote: >> Hi, >> >> ~This is part 2 of a two part upstreaming process of the patch mentioned in >> the subject line. The patch was split into 2 in order to document 2 separate >> specification changes that arose from a change in the implementation,

Re: RFR: 8268339: Upstream: 8267989: Exceptions thrown during upcalls should be handled (Pt. 2) [v5]

2021-06-08 Thread Paul Sandoz
On Tue, 8 Jun 2021 17:34:58 GMT, Jorn Vernee wrote: >> Hi, >> >> ~This is part 2 of a two part upstreaming process of the patch mentioned in >> the subject line. The patch was split into 2 in order to document 2 separate >> specification changes that arose from a change in the implementation,

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v12]

2021-06-04 Thread Paul Sandoz
On Fri, 4 Jun 2021 09:46:31 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >>

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v12]

2021-06-04 Thread Paul Sandoz
On Fri, 4 Jun 2021 09:46:31 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >>

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v12]

2021-06-04 Thread Paul Sandoz
On Fri, 4 Jun 2021 09:46:31 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >>

Re: RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation [v2]

2021-06-03 Thread Paul Sandoz
On Thu, 3 Jun 2021 20:40:23 GMT, Dan Smith wrote: >> Standardizes and better specifies the errors thrown by LambdaMetafactory, >> including for inputs that would not be generated by javac. >> >> Does some renaming of core parameters/fields to better reflect their purpose. >> >> In the

Re: RFR: 8268151: Vector API toShuffle optimization [v2]

2021-06-03 Thread Paul Sandoz
On Thu, 3 Jun 2021 21:43:19 GMT, Sandhya Viswanathan wrote: >> The Vector API toShuffle method can be optimized using existing vector >> conversion intrinsic. >> >> The following changes are made: >> 1) vector.toShuffle java implementation is changed to call >> VectorSupport.convert. >> 2)

Integrated: 8267939: Clarify the specification of iterator and spliterator forEachRemaining

2021-06-03 Thread Paul Sandoz
On Tue, 1 Jun 2021 19:54:59 GMT, Paul Sandoz wrote: > The specification of `forEachRemaining`, accepting a primitive functional > interface, on the primitive iterators is updated to be the same as for > `Iterator.forEachRemaining`, specifically the following

Integrated: 8266317: Vector API enhancements

2021-06-03 Thread Paul Sandoz
On Thu, 29 Apr 2021 21:13:38 GMT, Paul Sandoz wrote: > This PR contains API and implementation changes for [JEP-414 Vector API > (Second Incubator)](https://openjdk.java.net/jeps/414), in preparation for > when targeted. > > Enhancements are made to the API for the suppor

Re: RFR: JDK-8268147: need to update reference to testng module for jtreg6

2021-06-02 Thread Paul Sandoz
On Wed, 2 Jun 2021 22:22:22 GMT, Jonathan Gibbons wrote: > Please review a test fix to refer to the new name of the TestNG module. Marked as reviewed by psandoz (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4325

Re: RFR: 8267939: Clarify the specification of iterator and spliterator forEachRemaining [v2]

2021-06-02 Thread Paul Sandoz
Subsequent behavior of a spliterator is unspecified if the action > throws > * an exception. Paul Sandoz has updated the pull request incrementally with one additional commit since the last revision: Use source of elements. - Changes: - all: https://git.openjdk.java.net/jdk/

Re: RFR: 8199318: add idempotent copy operation for Map.Entry [v2]

2021-06-02 Thread Paul Sandoz
On Wed, 2 Jun 2021 17:54:06 GMT, Stuart Marks wrote: >> I'm fixing this along with a couple intertwined issues. >> >> 1. Add Map.Entry::copyOf as an idempotent copy operation. >> >> 2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not >> really immutable) but that

Re: RFR: 8267939: Clarify the specification of iterator and spliterator forEachRemaining

2021-06-02 Thread Paul Sandoz
On Tue, 1 Jun 2021 23:37:10 GMT, Stuart Marks wrote: >> Yeah, well spotted. I agree it's awkward. How about we lean on the behavior >> of the boxed counterpart: >> >> /** >> * Performs the given action for each remaining element until all >> elements >> * have been processed or

RFR: 8267939: Clarify the specification of iterator and spliterator forEachRemaining

2021-06-02 Thread Paul Sandoz
The specification of `forEachRemaining`, accepting a primitive functional interface, on the primitive iterators is updated to be the same as for `Iterator.forEachRemaining`, specifically the following is added: * * Subsequent behavior of an iterator is unspecified if the action

Re: RFR: 8267939: Clarify the specification of iterator and spliterator forEachRemaining

2021-06-02 Thread Paul Sandoz
On Tue, 1 Jun 2021 21:34:10 GMT, Stuart Marks wrote: >> The specification of `forEachRemaining`, accepting a primitive functional >> interface, on the primitive iterators is updated to be the same as for >> `Iterator.forEachRemaining`, specifically the following is added: >> >> >> * >>

Re: Integrated: 8268146: fix for JDK-8266254 fails validate-source

2021-06-02 Thread Paul Sandoz
On Wed, 2 Jun 2021 21:39:15 GMT, Daniel D. Daugherty wrote: > A trivial copyright fix. Marked as reviewed by psandoz (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4323

Re: RFR: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries [v2]

2021-06-02 Thread Paul Sandoz
On Wed, 2 Jun 2021 20:17:20 GMT, Maurizio Cimadamore wrote: >> This patch overhauls the library loading mechanism used by the Foreign >> Linker API. We realized that, while handy, the *default* lookup abstraction >> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms. >>

Re: RFR: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries [v2]

2021-06-02 Thread Paul Sandoz
On Wed, 2 Jun 2021 20:17:20 GMT, Maurizio Cimadamore wrote: >> This patch overhauls the library loading mechanism used by the Foreign >> Linker API. We realized that, while handy, the *default* lookup abstraction >> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms. >>

Re: RFR: 8266317: Vector API enhancements [v5]

2021-06-02 Thread Paul Sandoz
e to do that work after integration of > the PR. Paul Sandoz has updated the pull request incrementally with one additional commit since the last revision: Check vlen in bytes for unsigned support - Changes: - all: https://git.openjdk.java.net/jdk/pull/3803/files - ne

Re: RFR: 8266317: Vector API enhancements [v4]

2021-06-01 Thread Paul Sandoz
e to do that work after integration of > the PR. Paul Sandoz has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge remote-tracking branch 'upstream/master' into JDK-8266317-vector-api-enhancements - JavaDoc refs

Re: RFR: 8267969: Add vectorized implementation for VectorMask.eq()

2021-06-01 Thread Paul Sandoz
On Mon, 31 May 2021 10:25:26 GMT, Xiaohong Gong wrote: > Currently `"VectorMask.eq()" `is not vectorized: > > public VectorMask eq(VectorMask m) { > // FIXME: Generate good code here. > return bOp(m, (i, a, b) -> a == b); > } > > This can be implemented by calling

Re: RFR: 8265029: Preserve SIZED characteristics on slice operations (skip, limit) [v8]

2021-05-27 Thread Paul Sandoz
On Thu, 27 May 2021 06:13:40 GMT, Tagir F. Valeev wrote: >> With the introduction of `toList()`, preserving the SIZED characteristics in >> more cases becomes more important. This patch preserves SIZED on `skip()` >> and `limit()` operations, so now every combination of >>

Re: RFR: 8267452: Delegate forEachRemaining in Spliterators.iterator() [v2]

2021-05-25 Thread Paul Sandoz
On Mon, 24 May 2021 07:15:34 GMT, Tagir F. Valeev wrote: >> Sometimes, `Spliterator::forEachRemaining` has much more optimized >> implementation, compared to `Spliterator::tryAdvance`. For example, if a >> `Stream::spliterator` called for a stream that has intermediate operations, >>

Re: RFR: 8265029: Preserve SIZED characteristics on slice operations (skip, limit) [v7]

2021-05-24 Thread Paul Sandoz
On Mon, 24 May 2021 04:35:42 GMT, Tagir F. Valeev wrote: >> With the introduction of `toList()`, preserving the SIZED characteristics in >> more cases becomes more important. This patch preserves SIZED on `skip()` >> and `limit()` operations, so now every combination of >>

Re: RFR: 8267614: Outline VarHandleGuards exact behavior checks

2021-05-24 Thread Paul Sandoz
On Mon, 24 May 2021 11:47:53 GMT, Claes Redestad wrote: > Extract some common behavior checks from the generated VarHandleGuards code > to a package-private VarHandle method. This reduces the code size (-5.2kb > lib/modules) and slightly improves startup, while being performance neutral > on

Re: RFR: 8267452: Delegate forEachRemaining in Spliterators.iterator() [v2]

2021-05-24 Thread Paul Sandoz
On Mon, 24 May 2021 07:15:34 GMT, Tagir F. Valeev wrote: >> Sometimes, `Spliterator::forEachRemaining` has much more optimized >> implementation, compared to `Spliterator::tryAdvance`. For example, if a >> `Stream::spliterator` called for a stream that has intermediate operations, >>

Re: RFR: 8267190: Optimize Vector API test operations [v2]

2021-05-20 Thread Paul Sandoz
On Thu, 20 May 2021 01:27:48 GMT, Sandhya Viswanathan wrote: >> Vector API test operations (IS_DEFAULT, IS_FINITE, IS_INFINITE, IS_NAN and >> IS_NEGATIVE) are computed in three steps: >> 1) reinterpreting the floating point vectors as integral vectors (int/long) >> 2) perform the test in

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v11]

2021-05-19 Thread Paul Sandoz
On Wed, 19 May 2021 22:16:18 GMT, Sandhya Viswanathan wrote: >> This PR contains Short Vector Math Library support related changes for >> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), >> in preparation for when targeted. >> >> Intel Short Vector Math Library

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v11]

2021-05-19 Thread Paul Sandoz
On Wed, 19 May 2021 22:16:18 GMT, Sandhya Viswanathan wrote: >> This PR contains Short Vector Math Library support related changes for >> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), >> in preparation for when targeted. >> >> Intel Short Vector Math Library

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v2]

2021-05-19 Thread Paul Sandoz
On Mon, 3 May 2021 21:41:26 GMT, Paul Sandoz wrote: >> Sandhya Viswanathan has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains six commits: >> >> - Merge master >> - remove whitespace >

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v2]

2021-05-19 Thread Paul Sandoz
On Mon, 3 May 2021 21:41:26 GMT, Paul Sandoz wrote: >> Sandhya Viswanathan has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains six commits: >> >> - Merge master >> - remove whitespace >

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v9]

2021-05-19 Thread Paul Sandoz
On Wed, 19 May 2021 03:37:11 GMT, Sandhya Viswanathan wrote: >> This PR contains Short Vector Math Library support related changes for >> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), >> in preparation for when targeted. >> >> Intel Short Vector Math Library

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v9]

2021-05-19 Thread Paul Sandoz
On Wed, 19 May 2021 03:37:11 GMT, Sandhya Viswanathan wrote: >> This PR contains Short Vector Math Library support related changes for >> [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), >> in preparation for when targeted. >> >> Intel Short Vector Math Library

Re: RFR: 8267190: Optimize Vector API test operations

2021-05-19 Thread Paul Sandoz
On Fri, 14 May 2021 23:58:38 GMT, Sandhya Viswanathan wrote: > Vector API test operations (IS_DEFAULT, IS_FINITE, IS_INFINITE, IS_NAN and > IS_NEGATIVE) are computed in three steps: > 1) reinterpreting the floating point vectors as integral vectors (int/long) > 2) perform the test in integer

Re: RFR: 8267190: Optimize Vector API test operations

2021-05-18 Thread Paul Sandoz
On Fri, 14 May 2021 23:58:38 GMT, Sandhya Viswanathan wrote: > Vector API test operations (IS_DEFAULT, IS_FINITE, IS_INFINITE, IS_NAN and > IS_NEGATIVE) are computed in three steps: > 1) reinterpreting the floating point vectors as integral vectors (int/long) > 2) perform the test in integer

Re: RFR: 8265029: Preserve SIZED characteristics on slice operations (skip, limit) [v3]

2021-05-17 Thread Paul Sandoz
On Sat, 17 Apr 2021 02:16:44 GMT, Tagir F. Valeev wrote: >> Tagir F. Valeev has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - More benchmarks >> - adjustSize -> exactOutputSize >>

Re: RFR: 8266317: Vector API enhancements [v3]

2021-05-10 Thread Paul Sandoz
e to do that work after integration of > the PR. Paul Sandoz has updated the pull request incrementally with one additional commit since the last revision: JavaDoc refs for unsigned operators. - Changes: - all: https://git.openjdk.java.net/jdk/pull/3803/files - new: https:

Re: RFR: 8266317: Vector API enhancements [v2]

2021-05-10 Thread Paul Sandoz
e to do that work after integration of > the PR. Paul Sandoz has updated the pull request incrementally with one additional commit since the last revision: Rename method. - Changes: - all: https://git.openjdk.java.net/jdk/pull/3803/files - new: https://git.openjdk.java.

Re: RFR: 8266317: Vector API enhancements [v2]

2021-05-10 Thread Paul Sandoz
On Mon, 10 May 2021 21:05:02 GMT, Vladimir Ivanov wrote: >> Paul Sandoz has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename method. > > src/hotspot/cpu/aarch64/aarch64.ad line 2440: > >>

Re: Review CSR JDK-8266760: Remove sun.misc.Unsafe::defineAnonymousClass

2021-05-10 Thread Paul Sandoz
Looks good, I took the liberty of making some minor edits, mostly fixing some typos. Paul. > On May 10, 2021, at 12:26 PM, Mandy Chung wrote: > > Hidden classes were added in Java SE 15. Class data support was added in 16. > `sun.misc.Unsafe::defineAnonymousClass` was deprecated in JDK 15

Re: RFR: 8265128: [REDO] Optimize Vector API slice and unslice operations [v4]

2021-05-10 Thread Paul Sandoz
On Mon, 10 May 2021 18:31:30 GMT, Sandhya Viswanathan wrote: >> All the slice and unslice variants that take more than one argument can >> benefit from already intrinsic methods on similar lines as slice(origin) and >> unslice(origin). >> >> Changes include: >> * Rewrite Vector API

Re: RFR: 8265518: C1: Intrinsic support for Preconditions.checkIndex [v6]

2021-05-08 Thread Paul Sandoz
On Sat, 8 May 2021 05:32:00 GMT, Yi Yang wrote: > It seems that Object.checkIndex can not meet our needs because it implicitly > passes null to Preconditions.checkIndex, but we want to customize exception > messages, so we might add extra APIs in Objects while doing the replacement. > It

Re: RFR: 8266054: VectorAPI rotate operation optimization [v5]

2021-05-08 Thread Paul Sandoz
On Sat, 8 May 2021 05:54:38 GMT, Jatin Bhateja wrote: >> Current VectorAPI Java side implementation expresses rotateLeft and >> rotateRight operation using following operations:- >> >> vec1 = lanewise(VectorOperators.LSHL, n) >> vec2 = lanewise(VectorOperators.LSHR, n) >> res =

Re: RFR: 8266054: VectorAPI rotate operation optimization [v4]

2021-05-07 Thread Paul Sandoz
On Fri, 7 May 2021 18:31:15 GMT, Jatin Bhateja wrote: >> Current VectorAPI Java side implementation expresses rotateLeft and >> rotateRight operation using following operations:- >> >> vec1 = lanewise(VectorOperators.LSHL, n) >> vec2 = lanewise(VectorOperators.LSHR, n) >> res =

Re: RFR: 8266317: Vector API enhancements

2021-05-04 Thread Paul Sandoz
On Thu, 29 Apr 2021 21:13:38 GMT, Paul Sandoz wrote: > This PR contains API and implementation changes for [JEP-414 Vector API > (Second Incubator)](https://openjdk.java.net/jeps/414), in preparation for > when targeted. > > Enhancements are made to the API for the suppor

RFR: 8266317: Vector API enhancements

2021-05-04 Thread Paul Sandoz
This PR contains API and implementation changes for [JEP-414 Vector API (Second Incubator)](https://openjdk.java.net/jeps/414), in preparation for when targeted. Enhancements are made to the API for the support of operations on characters, such as for UTF-8 character decoding. Specifically,

<    2   3   4   5   6   7   8   9   10   11   >