Re: [PATCH v2 6/7] gitlab: build the correct microblaze target

2023-12-04 Thread Thomas Huth
On 04/12/2023 13.48, Cédric Le Goater wrote: On 12/4/23 13:43, Thomas Huth wrote: On 04/12/2023 13.40, Alex Bennée wrote: Thomas Huth writes: On 01/12/2023 10.36, Alex Bennée wrote: We inadvertently built the LE target for BE tests. Fixes: 78ebc00b06 (gitlab: shuffle some targets

Re: [PATCH v2 6/7] gitlab: build the correct microblaze target

2023-12-04 Thread Thomas Huth
On 04/12/2023 13.40, Alex Bennée wrote: Thomas Huth writes: On 01/12/2023 10.36, Alex Bennée wrote: We inadvertently built the LE target for BE tests. Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado noise) Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest.yml | 2

Re: [RFC 1/3] scripts/checkpatch: Check common spelling be default

2023-12-04 Thread Thomas Huth
On 04/12/2023 09.29, Zhao Liu wrote: From: Zhao Liu Add the check for common spelling mistakes for QEMU, which stole selling.txt from Linux kernel and referenced the Linux kernel's You need to sellcheck^Wspellcheck the above line ;-) implementation in checkpatch.pl. This check covers

Re: [PATCH v2 6/7] gitlab: build the correct microblaze target

2023-12-03 Thread Thomas Huth
On 01/12/2023 10.36, Alex Bennée wrote: We inadvertently built the LE target for BE tests. Fixes: 78ebc00b06 (gitlab: shuffle some targets and reduce avocado noise) Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] sh4: Coding style: Remove tabs

2023-11-26 Thread Thomas Huth
e big, so I think it would be better to fix other coding style issues in separate patches. This way, you can also verify with "git show -b" that there are no other unwanted changes in here. I now also quickly skimmed through the changes and the patch looks fine to me, so: Reviewed-by: T

Re: [RFC PATCH-for-9.0 01/11] qom: Introduce the TypeInfo::can_register() handler

2023-11-23 Thread Thomas Huth
On 23/11/2023 17.03, Philippe Mathieu-Daudé wrote: On 23/11/23 16:09, Thomas Huth wrote: On 22/11/2023 19.30, Philippe Mathieu-Daudé wrote: Add a helper to decide at runtime whether a type can be registered to the QOM framework or not. Signed-off-by: Philippe Mathieu-Daudé ---   include/qom

Re: [RFC PATCH-for-9.0 01/11] qom: Introduce the TypeInfo::can_register() handler

2023-11-23 Thread Thomas Huth
On 22/11/2023 19.30, Philippe Mathieu-Daudé wrote: Add a helper to decide at runtime whether a type can be registered to the QOM framework or not. Signed-off-by: Philippe Mathieu-Daudé --- include/qom/object.h | 4 qom/object.c | 3 +++ 2 files changed, 7 insertions(+) diff

Re: [PATCH 2/3] chardev: report blocked write to chardev backend

2023-11-22 Thread Thomas Huth
On 21/11/2023 12.47, Marc-André Lureau wrote: Hi On Tue, Nov 21, 2023 at 1:45 PM Thomas Huth wrote: On 21/11/2023 10.39, Marc-André Lureau wrote: Hi On Mon, Nov 20, 2023 at 5:36 PM Nicholas Piggin wrote: On Mon Nov 20, 2023 at 10:06 PM AEST, Marc-André Lureau wrote: Hi On Thu, Nov 16

[PATCH v3] tests/qemu-iotests/149: Use more inclusive language in this test

2023-11-22 Thread Thomas Huth
Let's use 'unsupported_configs' and 'tested_configs' here instead of non-inclusive words. Signed-off-by: Thomas Huth --- v3: Rewording according to the suggestions of Daniel: - Replaced "cipher not supported" with "config not supported" - Replaced "not in LUKS_CONF

[PATCH v3] tests/qemu-iotests/149: Use more inclusive language in this test

2023-11-22 Thread Thomas Huth
Let's use 'unsupported_configs' and 'tested_configs' here instead of non-inclusive words. Signed-off-by: Thomas Huth --- v3: Rewording according to the suggestions of Daniel: - Replaced "cipher not supported" with "config not supported" - Replaced "not in LUKS_CONF

Re: [PATCH 3/3] tests/unit/test-qmp-event: Replace fixture by global variables

2023-11-22 Thread Thomas Huth
insertions(+), 61 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 2/3] tests/unit/test-qmp-event: Simplify event emission check

2023-11-22 Thread Thomas Huth
that is not worthwhile, but since the cost is negative... Signed-off-by: Markus Armbruster --- tests/unit/test-qmp-event.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) Good idea! Reviewed-by: Thomas Huth

Re: [PATCH 1/3] tests/unit/test-qmp-event: Drop superfluous mutex

2023-11-22 Thread Thomas Huth
-by: Markus Armbruster --- tests/unit/test-qmp-event.c | 5 - 1 file changed, 5 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH for-8.2 0/2] qdev array property fixes

2023-11-21 Thread Thomas Huth
files changed, 46 insertions(+), 11 deletions(-) Thanks, I can confirm that this series fixes the problem for me - both locally when compiling with CFI, and on Travis (where I observed the problem first): https://app.travis-ci.com/github/huth/qemu/jobs/613659935#L6580 Tested-by: Thomas Huth

[Qemu-commits] [qemu/qemu] 87bfff: vl: disable default serial when xen-console is ena...

2023-11-21 Thread Thomas Huth via Qemu-commits
fingerprint: BE07 D9FD 5480 9AB2 C4B0 FF5F 6376 2CDA 67E2 F359 * tag 'pull-xenfv-20231121' of git://git.infradead.org/users/dwmw2/qemu: hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive vl: disable default serial when xen-console is enabled Signed-off-by: Stefan Hajnoczi

[Qemu-commits] [qemu/qemu] 87bfff: vl: disable default serial when xen-console is ena...

2023-11-21 Thread Thomas Huth via Qemu-commits
fingerprint: BE07 D9FD 5480 9AB2 C4B0 FF5F 6376 2CDA 67E2 F359 * tag 'pull-xenfv-20231121' of git://git.infradead.org/users/dwmw2/qemu: hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive vl: disable default serial when xen-console is enabled Signed-off-by: Stefan Hajnoczi

[PATCH] Revert "tests/avocado: Enable reverse_debugging.py tests in gitlab CI"

2023-11-21 Thread Thomas Huth
This reverts commit c4d74ab24a02c90b7a3240510b3dd4e1bec536dd. The reverse debugging test is sometimes still failing. See: https://gitlab.com/qemu-project/qemu/-/issues/1992 Signed-off-by: Thomas Huth --- tests/avocado/reverse_debugging.py | 8 1 file changed, 8 insertions(+) diff

Re: [PATCH 2/3] chardev: report blocked write to chardev backend

2023-11-21 Thread Thomas Huth
On 21/11/2023 10.39, Marc-André Lureau wrote: Hi On Mon, Nov 20, 2023 at 5:36 PM Nicholas Piggin wrote: On Mon Nov 20, 2023 at 10:06 PM AEST, Marc-André Lureau wrote: Hi On Thu, Nov 16, 2023 at 3:54 PM Nicholas Piggin wrote: If a chardev socket is not read, it will eventually fill and

Re: [PATCH 3/3] tests/avocado: Enable reverse_debugging.py tests in gitlab CI

2023-11-21 Thread Thomas Huth
On 21/11/2023 10.14, Daniel P. Berrangé wrote: On Tue, Nov 21, 2023 at 09:56:24AM +0100, Thomas Huth wrote: On 17/11/2023 08.35, Nicholas Piggin wrote: On Fri Nov 17, 2023 at 4:11 AM AEST, Thomas Huth wrote: On 16/11/2023 12.53, Nicholas Piggin wrote: Let's try enable reverse_debugging.py

Re: [PATCH for-8.2 3/3] ui/console: fix default VC when there are no display

2023-11-21 Thread Thomas Huth
ing remote display and it used the TTY instead. Fixes: commit 1bec1cc0d ("ui/console: allow to override the default VC") Reported-by: German Maglione Signed-off-by: Marc-André Lureau --- ui/console.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) Acked-by: Thomas Huth

Re: [PATCH for-8.2 2/3] ui: use "vc" chardev for dbus, gtk & spice-app

2023-11-21 Thread Thomas Huth
c | 1 + ui/spice-app.c | 1 + 3 files changed, 3 insertions(+) FWIW, Acked-by: Thomas Huth

Re: [PATCH 3/3] tests/avocado: Enable reverse_debugging.py tests in gitlab CI

2023-11-21 Thread Thomas Huth
On 17/11/2023 08.35, Nicholas Piggin wrote: On Fri Nov 17, 2023 at 4:11 AM AEST, Thomas Huth wrote: On 16/11/2023 12.53, Nicholas Piggin wrote: Let's try enable reverse_debugging.py in gitlab CI. Signed-off-by: Nicholas Piggin --- Maybe we could try this again at some point? The bug might

Re: [PATCH] tests/qtest: check the return value

2023-11-21 Thread Thomas Huth
On 21/11/2023 09.08, Zhu Jun wrote: These variables "ret" are never referenced in the code, thus add check logic for the "ret" Signed-off-by: Zhu Jun Thanks! Reviewed-by: Thomas Huth I'll queue it for my next pull request.

Re: [PATCH] tests/qtest: check the return value

2023-11-20 Thread Thomas Huth
Thanks, patch looks better this way, but I'd still like to ask you to fix two small issues: On 21/11/2023 07.16, zhujun2 wrote: These variables "ret" are never referenced in the code, that s/, that/, thus/ add check logic for the "ret" Signed-off-by: zhujun2 Could you *please* fix

Re: [Stable-8.1.3 v2 00/59] Patch Round-up for stable 8.1.3, frozen on 2023-11-19

2023-11-20 Thread Thomas Huth
On 19/11/2023 19.19, Michael Tokarev wrote: The following patches are queued for QEMU stable v8.1.3: https://gitlab.com/qemu-project/qemu/-/commits/staging-8.1 Patch freeze is 2023-11-19 (frozen), and the release is planned for 2023-11-21: https://wiki.qemu.org/Planning/8.1 Please

[PATCH] tests/qtest/migration-test: Fix analyze-migration.py for s390x

2023-11-20 Thread Thomas Huth
The migration stream on s390x contains data for the storage_attributes which the analyze-migration.py cannot handle yet. Add the basic code for handling this, so we can re-enable the check in the migration-test. Signed-off-by: Thomas Huth --- tests/qtest/migration-test.c | 4 +--- scripts

Re: [PATCH for-9.0] hw: Add compat machines for 9.0

2023-11-20 Thread Thomas Huth
, 80 insertions(+), 9 deletions(-) For s390x part: Acked-by: Thomas Huth

Re: [PATCH v3 5/5] qom/object: Limit type names to alphanumerical and some few special characters

2023-11-17 Thread Thomas Huth
On 17/11/2023 13.25, Philippe Mathieu-Daudé wrote: On 17/11/23 12:44, Thomas Huth wrote: QOM names currently don't have any enforced naming rules. This can be problematic, e.g. when they are used on the command line for the "-device" option (where the comma is used to separate

[PATCH v3 1/5] docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl"

2023-11-17 Thread Thomas Huth
From: Markus Armbruster Fixes: b65b4b7ae3c8 (xlnx-bbram: hw/nvram: Use dot in device type name) Signed-off-by: Markus Armbruster [thuth: Use longhand syntax to avoid problems with the "." in the name] Reviewed-by: Peter Maydell Signed-off-by: Thomas Huth --- docs/system/arm/x

[PATCH v3 3/5] memory: Remove "qemu:" prefix from the "qemu:ram-discard-manager" type name

2023-11-17 Thread Thomas Huth
migration. Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- include/exec/memory.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 831f7c996d..f172e82ac9 100644 --- a/include/exe

[PATCH v3 2/5] hw: Replace anti-social QOM type names (again)

2023-11-17 Thread Thomas Huth
ry. "xlnx,efuse", "xlnx,versal-efuse", "xlnx,pmc-efuse-cache", "xlnx-zynqmp-efuse" are from v6.2.0, "xlnx,versal-crl" is from v7.1.0, and the remainder are new. Rename them all to "xlnx-FOO", like commit e178113ff64 did. Reported-by: T

[PATCH v3 4/5] tests/unit/test-io-task: Rename "qemu:dummy" to avoid colon in the name

2023-11-17 Thread Thomas Huth
Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/unit/test-io-task.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/test-io-task.c b/tests/unit/test-io-task.c index 953a50ae66..115dba8970 100644 --- a/tests/unit/test-io-task.c +++ b/tests/unit/test-io-task

[PATCH v3 5/5] qom/object: Limit type names to alphanumerical and some few special characters

2023-11-17 Thread Thomas Huth
" and "Sun-UltraSparc" CPUs). We also cannot enforce the rule that names must start with a letter yet, since there are lot of types that start with a digit. Still, at least limiting the first characters to the alphanumerical range should be way better than

[PATCH v3 0/5] Limit type names to alphanumerical and some few special characters

2023-11-17 Thread Thomas Huth
xlnx.bbram-ctrl" hw: Replace anti-social QOM type names (again) Thomas Huth (3): memory: Remove "qemu:" prefix from the "qemu:ram-discard-manager" type name tests/unit/test-io-task: Rename "qemu:dummy" to avoid colon in the name qom/object: Limit

Re: [PATCH-for-8.2] target/nios2: Deprecate the Nios II architecture

2023-11-17 Thread Thomas Huth
or so long in QEMU, I guess it makes sense to mark it as deprecated here now. We can still reconsider if a new maintainer shows up... Reviewed-by: Thomas Huth

Re: [PATCH-for-8.2] target/nios2: Deprecate the Nios II architecture

2023-11-17 Thread Thomas Huth
or so long in QEMU, I guess it makes sense to mark it as deprecated here now. We can still reconsider if a new maintainer shows up... Reviewed-by: Thomas Huth ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email t

Re: [PATCH] linux-headers: Synchronize linux headers from linux v6.7.0-rc1

2023-11-16 Thread Thomas Huth
://wiki.qemu.org/Planning/8.2 That means, only bug fixes now, no new features will be merged until 8.2 has been released. Thomas On 2023/11/16 下午9:19, Thomas Huth wrote: On 15/11/2023 11.07, gaosong wrote: Hi, Can this patch be merged in during the 8.2 cycle?   Hi! We normally do linux

Re: [PATCH 3/3] tests/avocado: Enable reverse_debugging.py tests in gitlab CI

2023-11-16 Thread Thomas Huth
On 16/11/2023 12.53, Nicholas Piggin wrote: Let's try enable reverse_debugging.py in gitlab CI. Signed-off-by: Nicholas Piggin --- Maybe we could try this again at some point? The bug might have been noticed sooner. They only take a couple of seconds to run so should not take too much

[PULL 07/10] tests/avocado/replay_kernel: Mark the test_x86_64_pc as flaky

2023-11-16 Thread Thomas Huth
It's failing very often, so don't run this by default anymore until it gets fixed. Message-ID: <20231114153019.295131-1-th...@redhat.com> Reviewed-by: Peter Maydell Signed-off-by: Thomas Huth --- tests/avocado/replay_kernel.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PULL 06/10] tests/avocado: Make fetch_asset() unconditionally require a crypto hash

2023-11-16 Thread Thomas Huth
: $ avocado run tests/avocado/multiprocess.py (1/2) tests/avocado/multiprocess.py:Multiprocess.test_multiprocess_x86_64: ERROR: QemuBaseTest.fetch_asset() missing 1 required positional argument: 'asset_hash' (0.19 s) Inspired-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed

[PULL 10/10] tests/avocado: Enable reverse_debugging.py tests in gitlab CI

2023-11-16 Thread Thomas Huth
From: Nicholas Piggin Let's try enable reverse_debugging.py in gitlab CI. Signed-off-by: Nicholas Piggin Message-ID: <20231116115354.228678-3-npig...@gmail.com> Signed-off-by: Thomas Huth --- tests/avocado/reverse_debugging.py | 7 --- 1 file changed, 7 deletions(-) diff --git a

[PULL 01/10] tests/avocado: Replace assertEquals() for Python 3.12 compatibility

2023-11-16 Thread Thomas Huth
assertEquals() has been removed in Python 3.12 and should be replaced by assertEqual(). See: https://docs.python.org/3.12/whatsnew/3.12.html#id3 Message-ID: <20231114134326.287242-1-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- docs/devel/testi

[PULL 03/10] tests/avocado/virtio-gpu: Fix test_vhost_user_vga_virgl for edid support

2023-11-16 Thread Thomas Huth
now! While we're at it, move the expected string to the preceeding exec_command_and_wait_for_pattern() instead (since waiting for empty string here does not make too much sense). Message-ID: <20231114203456.319093-1-th...@redhat.com> Reviewed-by: Antonio Caggiano Signed-off-by: Thomas Huth --- t

[PULL 04/10] tests/avocado/intel_iommu: Add asset hashes to avoid warnings

2023-11-16 Thread Thomas Huth
The intel_iommu test is currently succeeding with annoying warnings. Add the proper asset hashes to avoid those. Message-ID: <20231114143531.291820-1-th...@redhat.com> Reviewed-by: Eric Auger Signed-off-by: Thomas Huth --- tests/avocado/intel_iommu.py | 6 -- 1 file changed, 4 inse

[PULL 09/10] tests/avocado: reverse_debugging drain console to prevent hang

2023-11-16 Thread Thomas Huth
("python/machine: use socketpair() for console connections") Fixes: 761a13b23946 ("tests/avocado: ppc64 reverse debugging tests for pseries and powernv") Fixes: be52eca30978 ("tests/acceptance: add reverse debugging test") Tested-by: Thomas Huth Signed-off-b

[PULL 08/10] tests/avocado/mem-addr-space-check: Replace assertEquals() for Python 3.12

2023-11-16 Thread Thomas Huth
assertEquals() has been removed in Python 3.12 and should be replaced by assertEqual(). See: https://docs.python.org/3.12/whatsnew/3.12.html#id3 Message-ID: <20231116061956.14676-1-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Acked-by: Ani Sinha Signed-off-by: Thomas Huth ---

[PULL 05/10] tests/avocado/multiprocess: Add asset hashes to silence warnings

2023-11-16 Thread Thomas Huth
| No hash provided. Cannot check the asset file integrity. Add the proper asset hashes to avoid those warnings. Message-ID: <20231115145852.494052-1-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/avocado/multiprocess.py | 18 -- 1 file changed, 12 insertions

[PULL 02/10] tests/avocado: Replace assertRegexpMatches() for Python 3.12 compatibility

2023-11-16 Thread Thomas Huth
From: Philippe Mathieu-Daudé assertRegexpMatches() has been removed in Python 3.12 and should be replaced by assertRegex(). See: https://docs.python.org/3.12/whatsnew/3.12.html#id3 Inspired-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20231114144832.71612-1-

[PULL 00/10] Avocado test fixes

2023-11-16 Thread Thomas Huth
Mathieu-Daudé (2): tests/avocado: Replace assertRegexpMatches() for Python 3.12 compatibility tests/avocado: Make fetch_asset() unconditionally require a crypto hash Thomas Huth (6): tests/avocado: Replace assertEquals() for Python 3.12 compatibility tests/avocado/virtio

Re: [PATCH v2 5/5] qom/object: Limit type names to alphanumerical and some few special characters

2023-11-16 Thread Thomas Huth
On 16/11/2023 14.24, Daniel P. Berrangé wrote: On Thu, Nov 16, 2023 at 02:14:54PM +0100, Thomas Huth wrote: QOM names currently don't have any enforced naming rules. This can be problematic, e.g. when they are used on the command line for the "-device" option (where the com

Re: [PATCH] linux-headers: Synchronize linux headers from linux v6.7.0-rc1

2023-11-16 Thread Thomas Huth
On 15/11/2023 11.07, gaosong wrote: Hi, Can this patch be merged in during the 8.2 cycle? Hi! We normally do linux-headers updates along with the patches that need the new definitions ... so is there an urgent reason to push this stand-alone patch into 8.2 without any patches that require

[PATCH v2 1/5] docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl"

2023-11-16 Thread Thomas Huth
From: Markus Armbruster Fixes: b65b4b7ae3c8 (xlnx-bbram: hw/nvram: Use dot in device type name) Signed-off-by: Markus Armbruster [thuth: Use longhand syntax to avoid problems with the "." in the name] Signed-off-by: Thomas Huth --- docs/system/arm/xlnx-versal-virt.rst | 2 +- 1 fi

[PATCH v2 5/5] qom/object: Limit type names to alphanumerical and some few special characters

2023-11-16 Thread Thomas Huth
" and "Sun-UltraSparc" CPUs). We also cannot enforce the rule that names must start with a letter yet, since there are lot of types that start with a digit. Still, at least limiting the first characters to the alphanumerical range should be way better than

[PATCH v2 4/5] tests/unit/test-io-task: Rename "qemu:dummy" to avoid colon in the name

2023-11-16 Thread Thomas Huth
Type names should not contain special characters like ":" (so that they are easier to use with QAPI and other parts). We are going to forbid such names in an upcoming patch. Thus let's replace the ":" here with a "-". Signed-off-by: Thomas Huth --- tests/unit

[PATCH v2 2/5] hw: Replace anti-social QOM type names (again)

2023-11-16 Thread Thomas Huth
ry. "xlnx,efuse", "xlnx,versal-efuse", "xlnx,pmc-efuse-cache", "xlnx-zynqmp-efuse" are from v6.2.0, "xlnx,versal-crl" is from v7.1.0, and the remainder are new. Rename them all to "xlnx-FOO", like commit e178113ff64 did. Reported-by: T

[PATCH v2 0/5] Limit type names to alphanumerical and some few special characters

2023-11-16 Thread Thomas Huth
the check to type_register_internal() instead of type_new() so that we can disallow colons, too - Only allow '+' in legacy names Markus Armbruster (2): docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl" hw: Replace anti-social QOM type names (again) Thomas Huth (3): memory: Remove

[PATCH v2 3/5] memory: Remove "qemu:" prefix from the "qemu:ram-discard-manager" type name

2023-11-16 Thread Thomas Huth
n. Signed-off-by: Thomas Huth --- include/exec/memory.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 831f7c996d..f172e82ac9 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -43,7 +43,7 @@ type

Re: [PATCH 3/3] tests/avocado: Enable reverse_debugging.py tests in gitlab CI

2023-11-16 Thread Thomas Huth
On 16/11/2023 12.53, Nicholas Piggin wrote: Let's try enable reverse_debugging.py in gitlab CI. Signed-off-by: Nicholas Piggin --- Maybe we could try this again at some point? The bug might have been noticed sooner. They only take a couple of seconds to run so should not take too much

Re: [PATCH] qom/object: Limit type names to alphanumerical and some few special characters

2023-11-16 Thread Thomas Huth
On 14/11/2023 14.21, Peter Maydell wrote: On Tue, 14 Nov 2023 at 13:05, Thomas Huth wrote: QOM names currently don't have any enforced naming rules. This can be problematic, e.g. when they are used on the command line for the "-device" option (where the comma is used to separate

Re: [PATCH] tests/avocado/reverse_debugging: Disable the ppc64 tests by default

2023-11-15 Thread Thomas Huth
d('console'), +stop_check=(lambda : not vm.is_running())) +console_drainer.start() return vm @staticmethod Tested-by: Thomas Huth Could you please send this as a proper patch, with a S-o-b line, and a short comment in front of the newly added code explaining it? Thanks, Thomas

[PATCH] tests/avocado/mem-addr-space-check: Replace assertEquals() for Python 3.12

2023-11-15 Thread Thomas Huth
assertEquals() has been removed in Python 3.12 and should be replaced by assertEqual(). See: https://docs.python.org/3.12/whatsnew/3.12.html#id3 Signed-off-by: Thomas Huth --- Note: The test has just been merged, that's why I missed this file in my earlier patch that replaces the assertEquals

Re: [PATCH-for-8.2? v2] tests/avocado: Make fetch_asset() unconditionally require a crypto hash

2023-11-15 Thread Thomas Huth
artifacts produce: $ avocado run tests/avocado/multiprocess.py (1/2) tests/avocado/multiprocess.py:Multiprocess.test_multiprocess_x86_64: ERROR: QemuBaseTest.fetch_asset() missing 1 required positional argument: 'asset_hash' (0.19 s) Inspired-by: Thomas Huth Signed-off-by: Philippe

Re: [PATCH-for-8.2?] tests/avocado: Make fetch_asset() inconditionally require a crypto hash

2023-11-15 Thread Thomas Huth
artifacts produce: $ avocado run tests/avocado/multiprocess.py (1/2) tests/avocado/multiprocess.py:Multiprocess.test_multiprocess_x86_64: ERROR: QemuBaseTest.fetch_asset() missing 1 required positional argument: 'asset_hash' (0.19 s) Inspired-by: Thomas Huth Signed-off-by: Philippe

[PATCH] tests/avocado/multiprocess: Add asset hashes to silence warnings

2023-11-15 Thread Thomas Huth
| No hash provided. Cannot check the asset file integrity. Add the proper asset hashes to avoid those warnings. Signed-off-by: Thomas Huth --- tests/avocado/multiprocess.py | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tests/avocado/multiprocess.py b

Re: [PATCH] tests/qtest: remove unused variables

2023-11-15 Thread Thomas Huth
On 15/11/2023 09.00, zhujun2 wrote: These variables are never referenced in the code, just remove them Signed-off-by: zhujun2 --- tests/qtest/test-filter-mirror.c | 2 +- tests/qtest/test-filter-redirector.c | 4 ++-- tests/qtest/virtio-net-test.c| 2 +- 3 files changed, 4

Re: [PATCH trivial 17/21] target/riscv/cpu.h: spelling fix: separatly

2023-11-14 Thread Thomas Huth
[i] (mie[i]) and needs to be maintained separately. */ uint64_t vsie; Reviewed-by: Thomas Huth

Re: [PATCH trivial 16/21] include/hw/virtio/vhost.h: spelling fix: sate

2023-11-14 Thread Thomas Huth
led while the device and all its vrings are stopped * (`VHOST_TRANSFER_STATE_PHASE_STOPPED`). * - * @dev: The vhost device to which to send the sate + * @dev: The vhost device to which to send the state * @f: Migration stream from which to load the state * @errp: Potential error message *

Re: [PATCH trivial 14/21] include/block/ufs.h: spelling fix: setted

2023-11-14 Thread Thomas Huth
ter buffer lifetime has a limit set by vendor. * If it is over the limit, WriteBooster feature will be disabled. */ #define UFS_WB_EXCEED_LIFETIME 0x0B Reviewed-by: Thomas Huth

Re: [PATCH trivial 13/21] hw/net/cadence_gem.c: spelling fixes: Octects

2023-11-14 Thread Thomas Huth
Reviewed-by: Thomas Huth

Re: [PATCH trivial 12/21] hw/mem/memory-device.c: spelling fix: ontaining

2023-11-14 Thread Thomas Huth
} Reviewed-by: Thomas Huth

Re: [PATCH trivial 10/21] migration/rdma.c: spelling fix: asume

2023-11-14 Thread Thomas Huth
at all. I will asume that RDMA is magicaly and don't + * overhead at all. I will assume that RDMA is magicaly and don't * need to transfer (at least) the addresses where it wants to * write the pages. Here it looks like it should be something * like: Reviewed-by: Thomas Huth

Re: [PATCH trivial 04/21] gdbstub: spelling fix: respectivelly

2023-11-14 Thread Thomas Huth
ny CPUs we are going to * step or resume, and a pointer to the state structure of one of them, - * respectivelly + * respectively */ int target_count = 0; CPUState *last_target = NULL; Reviewed-by: Thomas Huth

Re: [PATCH trivial 03/21] hw/cxl: spelling fixes: limitaions, potentialy, intialized

2023-11-14 Thread Thomas Huth
o mailbox for switch cci." Cc: Jonathan Cameron Cc: Fan Ni Signed-off-by: Michael Tokarev --- hw/cxl/cxl-component-utils.c | 4 ++-- hw/cxl/cxl-mailbox-utils.c | 2 +- include/hw/cxl/cxl_device.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH trivial 02/21] linux-user: spelling fixes: othe, necesary

2023-11-14 Thread Thomas Huth
| 2 +- linux-user/syscall.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH trivial 06/21] docs/devel/migration.rst: spelling fix: doen't

2023-11-14 Thread Thomas Huth
On 15/11/2023 07.41, Michael Tokarev wrote: 14.11.2023 22:05, Thomas Huth wrote: On 14/11/2023 17.58, Michael Tokarev wrote: Fixes: 1aefe2ca1423 "migration/doc: Add documentation for backwards compatiblity" Cc: Juan Quintela Signed-off-by: Michael Tokarev ---   docs/devel/migrati

Re: [PATCH] tests/avocado/reverse_debugging: Disable the ppc64 tests by default

2023-11-14 Thread Thomas Huth
On 15/11/2023 02.15, Nicholas Piggin wrote: On Wed Nov 15, 2023 at 4:29 AM AEST, Thomas Huth wrote: On 14/11/2023 17.37, Philippe Mathieu-Daudé wrote: On 14/11/23 17:31, Thomas Huth wrote: The tests seem currently to be broken. Disable them by default until someone fixes them. Signed-off

Re: [PATCH] tests/avocado/intel_iommu: Add asset hashes to avoid warnings

2023-11-14 Thread Thomas Huth
On 14/11/2023 21.42, Eric Auger wrote: Hi Thomas, On 11/14/23 15:35, Thomas Huth wrote: The intel_iommu test is currently succeeding with annoying warnings. nit: you may have precised the nature of the warning or quotes The annoying warnings look like this (in the summary): (031/174

[PATCH] tests/avocado/virtio-gpu: Fix test_vhost_user_vga_virgl for edid support

2023-11-14 Thread Thomas Huth
now! While we're at it, move the expected string to the preceeding exec_command_and_wait_for_pattern() instead (since waiting for empty string here does not make too much sense). Signed-off-by: Thomas Huth --- tests/avocado/virtio-gpu.py | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff -

Re: [PATCH trivial 18/21] tests/qtest/migration-test.c: spelling fix: bandwith

2023-11-14 Thread Thomas Huth
imit_value = 50; Reviewed-by: Thomas Huth

Re: [PATCH trivial 19/21] tests/qtest/ufs-test.c: spelling fix: tranfer

2023-11-14 Thread Thomas Huth
nt request */ +/* Enable transfer request and task management request */ cap = ufs_rreg(ufs, A_CAP); nutrs = FIELD_EX32(cap, CAP, NUTRS) + 1; nutmrs = FIELD_EX32(cap, CAP, NUTMRS) + 1; Reviewed-by: Thomas Huth

Re: [PATCH trivial 07/21] docs/system/arm/emulation.rst: spelling fix: Enhacements

2023-11-14 Thread Thomas Huth
Reviewed-by: Thomas Huth

Re: [PATCH trivial 06/21] docs/devel/migration.rst: spelling fix: doen't

2023-11-14 Thread Thomas Huth
On 14/11/2023 17.58, Michael Tokarev wrote: Fixes: 1aefe2ca1423 "migration/doc: Add documentation for backwards compatiblity" Cc: Juan Quintela Signed-off-by: Michael Tokarev --- docs/devel/migration.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH trivial 05/21] docs/about/deprecated.rst: spelling fix: becase

2023-11-14 Thread Thomas Huth
r starters, migration-test -compression tests are disabled becase they fail randomly. If you need +compression tests are disabled because they fail randomly. If you need compression, use multifd compression methods. Reviewed-by: Thomas Huth

Re: [PATCH] tests/avocado/replay_kernel: Mark the test_x86_64_pc as flaky

2023-11-14 Thread Thomas Huth
On 14/11/2023 17.22, Peter Maydell wrote: On Tue, 14 Nov 2023 at 15:30, Thomas Huth wrote: It's failing very often, so don't run this by default anymore until it gets fixed. Signed-off-by: Thomas Huth --- tests/avocado/replay_kernel.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH] tests/avocado/replay_kernel: Mark the test_x86_64_pc as flaky

2023-11-14 Thread Thomas Huth
On 14/11/2023 17.36, Philippe Mathieu-Daudé wrote: On 14/11/23 16:30, Thomas Huth wrote: It's failing very often, so don't run this by default anymore until it gets fixed. Signed-off-by: Thomas Huth ---   tests/avocado/replay_kernel.py | 3 ++-   1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH] tests/avocado/reverse_debugging: Disable the ppc64 tests by default

2023-11-14 Thread Thomas Huth
On 14/11/2023 17.37, Philippe Mathieu-Daudé wrote: On 14/11/23 17:31, Thomas Huth wrote: The tests seem currently to be broken. Disable them by default until someone fixes them. Signed-off-by: Thomas Huth ---   tests/avocado/reverse_debugging.py | 7 ---   1 file changed, 4 insertions

[PATCH] tests/avocado/reverse_debugging: Disable the ppc64 tests by default

2023-11-14 Thread Thomas Huth
The tests seem currently to be broken. Disable them by default until someone fixes them. Signed-off-by: Thomas Huth --- tests/avocado/reverse_debugging.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/avocado/reverse_debugging.py b/tests/avocado

Re: [PATCH] tests/avocado: Replace assertRegexpMatches() for Python 3.12 compatibility

2023-11-14 Thread Thomas Huth
On 14/11/2023 15.48, Philippe Mathieu-Daudé wrote: assertRegexpMatches() has been removed in Python 3.12 and should be replaced by assertRegex(). See: https://docs.python.org/3.12/whatsnew/3.12.html#id3 Inspired-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- docs/devel

[PATCH] tests/avocado/replay_kernel: Mark the test_x86_64_pc as flaky

2023-11-14 Thread Thomas Huth
It's failing very often, so don't run this by default anymore until it gets fixed. Signed-off-by: Thomas Huth --- tests/avocado/replay_kernel.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/avocado/replay_kernel.py b/tests/avocado/replay_kernel.py index a18610542e

[PATCH] tests/avocado/intel_iommu: Add asset hashes to avoid warnings

2023-11-14 Thread Thomas Huth
The intel_iommu test is currently succeeding with annoying warnings. Add the proper asset hashes to avoid those. Signed-off-by: Thomas Huth --- tests/avocado/intel_iommu.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/avocado/intel_iommu.py b/tests/avocado

Re: [PATCH] tests/avocado: Replace assertEquals() for Python 3.12 compatibility

2023-11-14 Thread Thomas Huth
On 14/11/2023 15.10, Philippe Mathieu-Daudé wrote: Hi Thomas, On 14/11/23 14:43, Thomas Huth wrote: assertEquals() has been removed in Python 3.12 and should be replaced by assertEqual(). See: https://docs.python.org/3.12/whatsnew/3.12.html#id3 From this list I see assertEquals() has been

[PATCH] tests/avocado: Replace assertEquals() for Python 3.12 compatibility

2023-11-14 Thread Thomas Huth
assertEquals() has been removed in Python 3.12 and should be replaced by assertEqual(). See: https://docs.python.org/3.12/whatsnew/3.12.html#id3 Signed-off-by: Thomas Huth --- docs/devel/testing.rst | 2 +- tests/avocado/cpu_queries.py| 2 +- tests/avocado

[PATCH] qom/object: Limit type names to alphanumerical and some few special characters

2023-11-14 Thread Thomas Huth
t start with a letter yet. Still, having at least some rules enforced here should be way better than nothing. Signed-off-by: Thomas Huth --- qom/object.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/qom/object.c b/qom/object.c index 95c0dc8285..8ff85e0239 100644 --- a/q

[PULL 2/3] dump: Add arch cleanup function

2023-11-14 Thread Thomas Huth
From: Janosch Frank Some architectures (s390x) need to cleanup after a failed dump to be able to continue to run the vm. Add a cleanup function pointer and call it if it's set. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth Reviewed-by: Marc-André Lureau Message-ID

[PULL 1/3] target/s390x/dump: Remove unneeded dump info function pointer init

2023-11-14 Thread Thomas Huth
From: Janosch Frank dump_state_prepare() now sets the function pointers to NULL so we only need to touch them if we're going to use them. Signed-off-by: Janosch Frank Reviewed-by: Marc-André Lureau Reviewed-by: Thomas Huth Message-ID: <20231109120443.185979-2-fran...@linux.ibm.com>

[PULL 0/3] Fix s390x PV dumps in case of errors

2023-11-14 Thread Thomas Huth
The following changes since commit f78ea7ddb0e18766ece9fdfe02061744a7afc41b: Merge tag 'pull-request-2023-11-13' of https://gitlab.com/thuth/qemu into staging (2023-11-13 07:15:43 -0500) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2023-11-14

[PULL 3/3] target/s390x/arch_dump: Add arch cleanup function for PV dumps

2023-11-14 Thread Thomas Huth
a dump end. The dump completion data is discarded but there's no point in writing it to a file anyway if there's a possibility that other PV dump data is missing. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth Reviewed-by: Claudio Imbrenda Reviewed-by: Marc-André Lureau Message-ID

Re: [RFC PATCH] qom/object: Disallow comma in type names

2023-11-14 Thread Thomas Huth
Forgot to CC: qemu-devel (sorry) - thanks to Markus for the hint. So let's repeat it here: On 14/11/2023 10.31, Daniel P. Berrangé wrote: On Tue, Nov 14, 2023 at 10:05:37AM +0100, Thomas Huth wrote: QOM names currently don't have any enforced naming rules. This can be problematic, e.g. when

Re: [PATCH 0/2] Replace anti-social QOM type names (again)

2023-11-14 Thread Thomas Huth
On 14/11/2023 08.41, Markus Armbruster wrote: Cc: the other QOM maintainers Daniel P. Berrangé writes: On Mon, Nov 13, 2023 at 02:43:42PM +0100, Markus Armbruster wrote: We got rid of QOM type names containing ',' in 6.0, but some have crept back in. Replace them just like we did in 6.0.

Re: [PATCH v2] test/qtest: Add API functions to capture IRQ toggling

2023-11-13 Thread Thomas Huth
generated (indicating if the IRQ line was toggled). Signed-off-by: Gustavo Romero --- tests/qtest/libqtest.c | 24 tests/qtest/libqtest.h | 28 2 files changed, 52 insertions(+) Acked-by: Thomas Huth

<    9   10   11   12   13   14   15   16   17   18   >