/pc.c | 19 ---
2 files changed, 12 insertions(+), 11 deletions(-)
Reviewed-by: Thomas Huth
/pc.c | 19 ---
2 files changed, 12 insertions(+), 11 deletions(-)
Reviewed-by: Thomas Huth
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
X86CPU::kvm_no_smi_migration was only used by the
pc-i440fx-2.3 machine, which got removed. Remove it
and simplify kvm_put_vcpu_events().
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.h | 3 ---
target/i386/cpu.c | 2 --
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
X86CPU::kvm_no_smi_migration was only used by the
pc-i440fx-2.3 machine, which got removed. Remove it
and simplify kvm_put_vcpu_events().
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.h | 3 ---
target/i386/cpu.c | 2 --
Reviewed-by: Thomas Huth
Reviewed-by: Thomas Huth
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
AcpiBuildState::rsdp is always NULL, remove it,
simplifying acpi_build_update().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/acpi-build.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Thomas Huth
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
AcpiBuildState::rsdp is always NULL, remove it,
simplifying acpi_build_update().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/acpi-build.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Thomas Huth
-build.c | 35 ---
hw/i386/pc.c | 1 -
3 files changed, 4 insertions(+), 33 deletions(-)
Reviewed-by: Thomas Huth
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le
-build.c | 35 ---
hw/i386/pc.c | 1 -
3 files changed, 4 insertions(+), 33 deletions(-)
Reviewed-by: Thomas Huth
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
PCMachineClass::resizable_acpi_blob was only used by the
pc-i440fx-2.2 machine, which got removed. It is now always
true. Remove it, simplifying acpi_build().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 3 ---
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
PCMachineClass::resizable_acpi_blob was only used by the
pc-i440fx-2.2 machine, which got removed. It is now always
true. Remove it, simplifying acpi_build().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 3 ---
docs/about/deprecated.rst | 2 +-
docs/about/removed-features.rst | 2 +-
include/hw/i386/pc.h| 3 ---
hw/i386/pc.c| 7 ---
hw/i386/pc_piix.c | 23 ---
5 files changed, 2 insertions(+), 35 deletions(-)
Reviewed-by: Thomas Huth
docs/about/deprecated.rst | 2 +-
docs/about/removed-features.rst | 2 +-
include/hw/i386/pc.h| 3 ---
hw/i386/pc.c| 7 ---
hw/i386/pc_piix.c | 23 ---
5 files changed, 2 insertions(+), 35 deletions(-)
Reviewed-by: T
hw/mem/pc-dimm.c | 2 +-
hw/virtio/virtio-md-pci.c | 2 +-
5 files changed, 8 insertions(+), 13 deletions(-)
Reviewed-by: Thomas Huth
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email
hw/mem/pc-dimm.c | 2 +-
hw/virtio/virtio-md-pci.c | 2 +-
5 files changed, 8 insertions(+), 13 deletions(-)
Reviewed-by: Thomas Huth
| 6 ++
hw/ppc/spapr.c | 2 +-
6 files changed, 7 insertions(+), 10 deletions(-)
Reviewed-by: Thomas Huth
| 6 ++
hw/ppc/spapr.c | 2 +-
6 files changed, 7 insertions(+), 10 deletions(-)
Reviewed-by: Thomas Huth
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
PCMachineClass::enforce_aligned_dimm was only used by the
pc-i440fx-2.1 machine, which got removed. It is now always
true. Remove it, simplifying pc_get_device_memory_range().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h |
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
PCMachineClass::enforce_aligned_dimm was only used by the
pc-i440fx-2.1 machine, which got removed. It is now always
true. Remove it, simplifying pc_get_device_memory_range().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h |
/pc.c | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Thomas Huth
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
/pc.c | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Thomas Huth
now empty, remove it too.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/kvm/kvm-cpu.h | 41 ---
target/i386/kvm/kvm-cpu.c | 3 +--
2 files changed, 1 insertion(+), 43 deletions(-)
delete mode 100644 target/i386/kvm/kvm-cpu.h
Reviewed-by: Thomas Huth
now empty, remove it too.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/kvm/kvm-cpu.h | 41 ---
target/i386/kvm/kvm-cpu.c | 3 +--
2 files changed, 1 insertion(+), 43 deletions(-)
delete mode 100644 target/i386/kvm/kvm-cpu.h
Reviewed-by: T
ec-usb-xhci", "force-pcie-endcap", "on" },
-{ "pci-serial", "prog_if", "0" },
-{ "pci-serial-2x", "prog_if", "0" },
-{ "pci-serial-4x", "prog_if", "0" },
- { "virtio-net-pci", "guest_announce", "off" },
-{ "ICH9-LPC", "memory-hotplug-support", "off" },
I think you could clean up memory-hotplug-support for the ICH9-LPC device
now, too (in a separate patch).
For this patch here:
Reviewed-by: Thomas Huth
ec-usb-xhci", "force-pcie-endcap", "on" },
-{ "pci-serial", "prog_if", "0" },
-{ "pci-serial-2x", "prog_if", "0" },
-{ "pci-serial-4x", "prog_if", "0" },
-
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
PCMachineClass::legacy_acpi_table_size was only used by the
pc-i440fx-2.0 machine, which got removed. Remove it and simplify
acpi_build().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 1 -
hw/i386/acpi-build.c | 60
--
hw/usb/hcd-xhci-pci.c | 1 -
hw/usb/hcd-xhci.c | 42 --
4 files changed, 8 insertions(+), 38 deletions(-)
Reviewed-by: Thomas Huth
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
PCMachineClass::legacy_acpi_table_size was only used by the
pc-i440fx-2.0 machine, which got removed. Remove it and simplify
acpi_build().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i386/pc.h | 1 -
hw/i386/acpi-build.c | 60
--
hw/usb/hcd-xhci-pci.c | 1 -
hw/usb/hcd-xhci.c | 42 --
4 files changed, 8 insertions(+), 38 deletions(-)
Reviewed-by: Thomas Huth
--
hw/usb/hcd-xhci-pci.c | 3 +--
3 files changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Thomas Huth
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
--
hw/usb/hcd-xhci-pci.c | 3 +--
3 files changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Thomas Huth
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
The pc-i440fx-2.3 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
The pc-i440fx-2.3 machine was deprecated for the 8.2
release (see commit c7437f0ddb "docs/about: Mark the
old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
time to remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
On 04/03/2024 19.04, Daniel P. Berrangé wrote:
On Mon, Mar 04, 2024 at 06:11:58PM +0100, Thomas Huth wrote:
On 04/03/2024 17.56, Peter Maydell wrote:
On Mon, 4 Mar 2024 at 13:04, Thomas Huth wrote:
The macOS jobs in our CI recently started failing, complaining that
the distutils module
().
Cc: Nicholas Piggin
Cc: Harsh Prateek Bora
Cc: Halil Pasic
Cc: Thomas Huth
Cc: Eric Blake
Cc: Vladimir Sementsov-Ogievskiy
Cc: John Snow
Cc: Stefan Hajnoczi
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
Signed-off-by: Cédric Le Goater
---
Reviewed-by: Thomas Huth
On 04/03/2024 16.10, Jonathan Cameron wrote:
On Mon, 4 Mar 2024 11:44:06 +0100
Thomas Huth wrote:
When setting GLIB_VERSION_MAX_ALLOWED to GLIB_VERSION_2_58 or higher,
glib adds type safety checks to the g_steal_pointer() macro. This
triggers errors in the ct3_build_cdat_entries_for_mr
On 05/03/2024 07.29, Nicholas Piggin wrote:
On Tue Feb 27, 2024 at 6:50 PM AEST, Thomas Huth wrote:
On 26/02/2024 11.11, Nicholas Piggin wrote:
...
/* save DTB pointer */
- std r3, 56(r1)
+ SAVE_GPR(3,r1)
Isn't SAVE_GPR rather meant for the interrupt frame
On 05/03/2024 04.21, Xinying Yu wrote:
One more thing, I would ask how do I get the full series patch? Do I copy
the RFC line by line from this link[1]?
For getting patches that you might have missed on the mailing list, I
recommend lore.kernel.org :
On 05/03/2024 04.21, Xinying Yu wrote:
One more thing, I would ask how do I get the full series patch? Do I copy
the RFC line by line from this link[1]?
For getting patches that you might have missed on the mailing list, I
recommend lore.kernel.org :
On 05/03/2024 03.50, Nicholas Piggin wrote:
On Mon Mar 4, 2024 at 4:22 PM AEST, Thomas Huth wrote:
On 26/02/2024 10.38, Nicholas Piggin wrote:
This test stores to a bunch of pages and verifies previous stores,
while being continually migrated. This can fail due to a QEMU TCG
physical memory
On 05/03/2024 03.38, Nicholas Piggin wrote:
On Sat Mar 2, 2024 at 12:16 AM AEST, Thomas Huth wrote:
On 26/02/2024 10.38, Nicholas Piggin wrote:
The migration harness is complicated and easy to break so CI will
be helpful.
Signed-off-by: Nicholas Piggin
---
.gitlab-ci.yml | 18
On 05/03/2024 03.19, Nicholas Piggin wrote:
On Fri Mar 1, 2024 at 10:41 PM AEST, Thomas Huth wrote:
On 26/02/2024 11.12, Nicholas Piggin wrote:
Add basic testing of various kinds of interrupts, machine check,
page fault, illegal, decrementer, trace, syscall, etc.
This has a known failure
On 05/03/2024 03.30, Nicholas Piggin wrote:
On Fri Mar 1, 2024 at 11:45 PM AEST, Andrew Jones wrote:
On Fri, Mar 01, 2024 at 01:41:22PM +0100, Thomas Huth wrote:
On 26/02/2024 11.12, Nicholas Piggin wrote:
Add basic testing of various kinds of interrupts, machine check,
page fault, illegal
ph.h
+++ b/tests/qtest/libqos/qgraph.h
@@ -24,7 +24,7 @@
#include "libqos-malloc.h"
/* maximum path length */
-#define QOS_PATH_MAX_ELEMENT_SIZE 64
+#define QOS_PATH_MAX_ELEMENT_SIZE 128
Reviewed-by: Thomas Huth
On 04/03/2024 17.56, Peter Maydell wrote:
On Mon, 4 Mar 2024 at 13:04, Thomas Huth wrote:
The macOS jobs in our CI recently started failing, complaining that
the distutils module is not available anymore. And indeed, according to
https://peps.python.org/pep-0632/ it's been deprecated since
On 04/03/2024 14.04, Thomas Huth wrote:
The macOS jobs in our CI recently started failing, complaining that
the distutils module is not available anymore. And indeed, according to
https://peps.python.org/pep-0632/ it's been deprecated since a while
and now likely got removed in recent Python
, and that is using a newer version, too, according to our
pythondeps.toml file.
Thus we can simply drop the version check now to get rid of the
distutils dependency here.
Signed-off-by: Thomas Huth
---
v2: Updated the commit description (it's about sphinx-rtd-theme,
not the Sphinx program itself)
docs
On 04/03/2024 12.18, Peter Maydell wrote:
On Mon, 4 Mar 2024 at 11:10, Thomas Huth wrote:
Using my shell script to query repology, I get:
centos_stream_8: 0.3.1
centos_stream_9: 0.5.1
fedora_37: 1.0.0
fedora_38: 1.1.1
fedora_39: 1.2.2
fedora_rawhide: 2.0.0
freebsd: 1.0.0
haikuports_master
On 04/03/2024 11.56, Peter Maydell wrote:
On Mon, 4 Mar 2024 at 09:36, Thomas Huth wrote:
The macOS jobs in our CI recently started failing, complaining that
the distutils module is not available anymore. And indeed, according to
https://peps.python.org/pep-0632/ it's been deprecated since
*buf in CDATObject, i.e. a pointer of a different
type. Change the local variable to the same type as buf in CDATObject
to avoid the error.
Signed-off-by: Thomas Huth
---
hw/cxl/cxl-cdat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/cxl/cxl-cdat.c b/hw/cxl/cxl-cdat.c
now so we can switch to a newer version
of the glib in a future version of QEMU.
Thomas Huth (3):
hw/cxl/cxl-cdat: Fix type of buf in ct3_load_cdat()
hw/pci-bridge/cxl_upstream: Fix problem with g_steal_pointer()
hw/mem/cxl_type3: Fix problem with g_steal_pointer()
include/hw/cxl/cxl_cdat.h
-by: Thomas Huth
---
include/hw/cxl/cxl_cdat.h | 9 ++---
hw/mem/cxl_type3.c| 24
2 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/include/hw/cxl/cxl_cdat.h b/include/hw/cxl/cxl_cdat.h
index b44cefaad6..17a09066dc 100644
--- a/include/hw/cxl
and destination pointer might
have different alignment restrictions. Removing the QEMU_PACKED should
be fine here since the structs are already naturally aligned. Anyway,
add some QEMU_BUILD_BUG_ON() statements to make sure that we've got
the right sizes (without padding in the structs).
Signed-off-by: Thomas
it for a version check via LooseVersion here
which we don't really need anymore: All distros ship newer versions of
Sphinx now (see https://repology.org/project/python:sphinx/versions -
the oldest one is 0.6.6 on CentOS 6!), so we can simply drop the version
check now.
Signed-off-by: Thomas Huth
---
docs
On 26/02/2024 10.38, Nicholas Piggin wrote:
This test stores to a bunch of pages and verifies previous stores,
while being continually migrated. This can fail due to a QEMU TCG
physical memory dirty bitmap bug.
Good idea, but could we then please drop "continuous" test from
On 26/02/2024 10.38, Nicholas Piggin wrote:
The cooperative migration protocol is very good to control precise
pre and post conditions for a migration event. However in some cases
its intrusiveness to the test program, can mask problems and make
analysis more difficult.
For example to stress
| 5 +
scripts/arch-run.bash | 41 +
6 files changed, 73 insertions(+), 14 deletions(-)
Reviewed-by: Thomas Huth
gy (considered invalid): "
-"CPU topology parameters must be greater than zero");
+error_setg(errp, "Invalid CPU topology: "
+ "CPU topology parameters must be greater than zero");
+return;
}
Reviewed-by: Thomas Huth
gy (considered invalid): "
-"CPU topology parameters must be greater than zero");
+error_setg(errp, "Invalid CPU topology: "
+ "CPU topology parameters must be greater than zero");
+return;
}
Reviewed
Branch: refs/heads/staging-8.2
Home: https://github.com/qemu/qemu
Commit: 829bb27765afba34a54c49c47b5c658ac84bec3a
https://github.com/qemu/qemu/commit/829bb27765afba34a54c49c47b5c658ac84bec3a
Author: Thomas Huth
Date: 2024-03-01 (Fri, 01 Mar 2024)
Changed paths:
M hw
virtio_ccw_start_ioeventfd(dev);
}
sch->curr_status.scsw.count = ccw.count - sizeof(status);
Acked-by: Thomas Huth
ev, vq_idx);
return 0;
-
}
Acked-by: Thomas Huth
virtio_ccw_start_ioeventfd(dev);
}
sch->curr_status.scsw.count = ccw.count - sizeof(status);
Acked-by: Thomas Huth
ev, vq_idx);
return 0;
-
}
Acked-by: Thomas Huth
On 29/01/2024 09.18, Thomas Huth wrote:
We've got a switch to disable v7m code since a long time - but it
currently cannot be disabled since linking then fails due to missing
functions. But thanks to the clean-ups that have been done during the
past years, it's not that difficult anymore
On 01/03/2024 16.57, Michael Tokarev wrote:
17.02.2024 22:26, Daniel Henrique Barboza:
diff --git a/tests/qtest/libqos/virtio.c b/tests/qtest/libqos/virtio.c
index 410513225f..4f39124eba 100644
--- a/tests/qtest/libqos/virtio.c
+++ b/tests/qtest/libqos/virtio.c
@@ -280,14 +280,27 @@
On 26/02/2024 10.38, Nicholas Piggin wrote:
The migration harness is complicated and easy to break so CI will
be helpful.
Signed-off-by: Nicholas Piggin
---
.gitlab-ci.yml | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
100644 lib/powerpc/asm/time.h
create mode 100644 lib/ppc64/asm/time.h
Reviewed-by: Thomas Huth
On 01/03/2024 14.45, Andrew Jones wrote:
On Fri, Mar 01, 2024 at 01:41:22PM +0100, Thomas Huth wrote:
On 26/02/2024 11.12, Nicholas Piggin wrote:
Add basic testing of various kinds of interrupts, machine check,
page fault, illegal, decrementer, trace, syscall, etc.
This has a known failure
---
arm/gic.c | 21 -
s390x/migration-cmm.c | 8
s390x/migration-skey.c | 4 +++-
s390x/migration.c | 1 +
4 files changed, 20 insertions(+), 14 deletions(-)
Reviewed-by: Thomas Huth
fo}
- rm ${dst_infifo}
I assume it will not get deleted by the trap handler? ... sounds fine to me,
so I dare to say:
Reviewed-by: Thomas Huth
On 26/02/2024 11.12, Nicholas Piggin wrote:
Add basic testing of various kinds of interrupts, machine check,
page fault, illegal, decrementer, trace, syscall, etc.
This has a known failure on QEMU TCG pseries machines where MSR[ME]
can be incorrectly set to 0.
Two questions out of curiosity:
On 26/02/2024 11.11, Nicholas Piggin wrote:
Illegal instructions cause 0xe40 (HEAI) interrupts rather
than program interrupts.
Acked-by: Thomas Huth
Signed-off-by: Nicholas Piggin
---
lib/powerpc/asm/processor.h | 1 +
lib/powerpc/setup.c | 13 +
powerpc/emulator.c
| 4
powerpc/sprs.c| 17 +++--
2 files changed, 15 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth
mp;& !(after[i] >> 32))
I guess you could also squash this into the previous patch (to avoid
problems with bisecting later?) ...
Anyway:
Reviewed-by: Thomas Huth
changed, 44 insertions(+), 24 deletions(-)
create mode 100644 lib/powerpc/asm/reg.h
create mode 100644 lib/ppc64/asm/reg.h
Reviewed-by: Thomas Huth
On 01/03/2024 11.21, Peter Maydell wrote:
On Wed, 28 Feb 2024 at 12:06, Thomas Huth wrote:
On 28/02/2024 12.31, Inès Varhol wrote:
TLDR: how can I provide a test or an example?
I've tested the display by running custom executables and
comparing to the result on the real board, but I don't
On 26/02/2024 11.11, Nicholas Piggin wrote:
Add support for backtracing across interrupt stacks, and
add interrupt frame backtrace for unhandled interrupts.
Signed-off-by: Nicholas Piggin
---
lib/powerpc/processor.c | 4 ++-
lib/ppc64/asm/stack.h | 3 +++
lib/ppc64/stack.c | 55
On 27/02/2024 09.50, Thomas Huth wrote:
On 26/02/2024 11.11, Nicholas Piggin wrote:
The backtrace handler terminates when it sees a NULL caller address,
but the powerpc stack setup does not keep such a NULL caller frame
at the start of the stack.
This happens to work on pseries because
On 25/02/2024 20.49, benl...@fysnet.net wrote:
Since Windows text files use CRLFs for all \n, the Windows version of QEMU
inserts a CR in the PCAP stream when a LF is encountered when using USB PCAP
files. This is due to the fact that the PCAP file is opened as TEXT instead
of BINARY.
To show
823$ce1bbf80$6a533e80$@fysnet.net>
[thuth: Break long line to avoid checkpatch.pl error]
Signed-off-by: Thomas Huth
---
hw/usb/bus.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index 796769fadb..bfab2807d7 100644
--- a/hw/usb/bus.c
+++ b/
es
enabled in the --without-default-devices builds, too.
Message-ID: <20240221110059.152665-1-th...@redhat.com>
Tested-by: Fabiano Rosas
Signed-off-by: Thomas Huth
---
hw/intc/Kconfig | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/intc/Kconfig b/hw/in
d-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
tests/unit/test-util-sockets.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c
index 63909ccb2b..4c9dd0b271 100644
--- a/tests/unit/test-util
):
hw/usb/bus.c: PCAP adding 0xA in Windows version
Daniel Henrique Barboza (2):
libqos/virtio.c: init all elems in qvring_indirect_desc_setup()
libqos/virtio.c: fix 'avail_event' offset in qvring_init()
Thomas Huth (3):
hw/intc/Kconfig: Fix GIC settings when using "--wi
rg
Fixes: ffda5db65a ("io/channel-tls: fix handling of bigger read buffers")
Buglink: https://issues.redhat.com/browse/RHEL-24614
Reviewed-by: "Daniel P. Berrangé"
Message-ID: <20240229104339.42574-1-th...@redhat.com>
Reviewed-by: Antoine Damhet
Tested-by: Antoine Damhet
Re
ent) < 1)) {
d->bus->virtqueue_kick(d, vq);
}
As a result the virtqueue is never kicked and we'll timeout waiting for it.
Fixes: 1053587c3f ("libqos: Added EVENT_IDX support")
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Alistair Francis
Reviewed-by: Thomas Huth
Mes
ementation")
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Alistair Francis
Reviewed-by: Thomas Huth
Message-ID: <20240217192607.32565-2-dbarb...@ventanamicro.com>
Signed-off-by: Thomas Huth
---
tests/qtest/libqos/virtio.c | 25 +++--
1 file changed, 19 insertions
used when the machine has only 1 cluster
since there's only 1 cluster by default.
Add the check to cover this field.
Signed-off-by: Zhao Liu
---
tests/unit/test-smp-parse.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
Acked-by: Thomas Huth
levels). This also helps to avoid introducing new issues by
further expanding the CPU topology in the future.
Signed-off-by: Zhao Liu
---
tests/unit/test-smp-parse.c | 143
1 file changed, 143 insertions(+)
FWIW:
Acked-by: Thomas Huth
-by: Zhao Liu
---
tests/unit/test-smp-parse.c | 89 +
1 file changed, 89 insertions(+)
Reviewed-by: Thomas Huth
-by: Zhao Liu
---
tests/unit/test-smp-parse.c | 105
1 file changed, 105 insertions(+)
Reviewed-by: Thomas Huth
p.books == expect_topo->books) &&
(ms->smp.sockets == expect_topo->sockets) &&
(ms->smp.dies == expect_topo->dies) &&
(ms->smp.clusters == expect_topo->clusters) &&
@@ -564,6 +573,16 @@ static void unsupported_params_init(const MachineClass
*mc, SMPTestData *data)
data->expect_prefer_sockets.clusters = 1;
data->expect_prefer_cores.clusters = 1;
}
+
+if (!mc->smp_props.books_supported) {
+data->expect_prefer_sockets.books = 1;
+data->expect_prefer_cores.books = 1;
+}
+
+if (!mc->smp_props.drawers_supported) {
+data->expect_prefer_sockets.drawers = 1;
+data->expect_prefer_cores.drawers = 1;
+}
}
Reviewed-by: Thomas Huth
On 18/01/2024 15.48, Zhao Liu wrote:
From: Zhao Liu
PC mahine is trying to support up to 4096 vCPUs [1], so it's necessary
s/mahine/machine/
to bump max_cpus in test-smp-parse to 4096 to cover the topological
needs of future machines.
[1]:
On 18/01/2024 15.48, Zhao Liu wrote:
From: Zhao Liu
Use MAX_CPUS/MIN_CPUS micros in invalid topology case. This gives us the
s/micros/macros/
Apart from that typo, FWIW:
Reviewed-by: Thomas Huth
flexibility to change the maximum and minimum CPU limits.
Signed-off-by: Zhao Liu
r, ret = 1;
Reviewed-by: Thomas Huth
char *name,
NetClientState *peer, Error **errp)
{
+ERRP_GUARD();
const NetdevVhostVDPAOptions *opts;
uint64_t features;
int vdpa_device_fd;
Reviewed-by: Thomas Huth
iamson
Cc: "Cédric Le Goater"
Cc: Thomas Huth
Cc: Tony Krowiak
Cc: Halil Pasic
Cc: Jason Herne
Signed-off-by: Zhao Liu
---
hw/vfio/ap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index e157aa1ff79c..7c4caa593863 100644
--- a/hw/vfio/ap.
9,6 +719,7 @@ static void vfio_disconnect_container(VFIOGroup *group)
static VFIOGroup *vfio_get_group(int groupid, AddressSpace *as, Error **errp)
{
+ERRP_GUARD();
VFIOGroup *group;
char path[32];
struct vfio_group_status status = { .argsz = sizeof(status) };
Reviewed-by: Thomas Huth
@@ struct RemoteObject {
static void remote_object_set_fd(Object *obj, const char *str, Error **errp)
{
+ERRP_GUARD();
RemoteObject *o = REMOTE_OBJECT(obj);
int fd = -1;
Reviewed-by: Thomas Huth
601 - 700 of 20558 matches
Mail list logo
