Re: [pve-devel] [PATCH v2 common 1/1] fix #1454: meminfo: also return arcsize

2023-04-13 Thread Thomas Lamprecht
Am 28/03/2023 um 14:49 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > Changes from v1: > None > > src/PVE/ProcFSTools.pm | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/PVE/ProcFSTools.pm b/src/PVE/ProcFSTools.pm > index eb4b0f5..0686c34 100644 > ---

[pve-devel] applied: [PATCH widget-toolkit] form: combo grid: use correct method to initialize the picker

2023-04-12 Thread Thomas Lamprecht
Am 31/03/2023 um 12:04 schrieb Dominik Csapak: > 'createPicker' does create the picker, but not all necessary > initialization for the combobox (namely it does not set the owner field, > but that's only an implementation detail). Instead 'getPicker' should be > used for that, since that does all

[pve-devel] applied: [PATCH manager] fix #4627: ui: backup edit: don't deselect all vms on load

2023-04-12 Thread Thomas Lamprecht
Am 31/03/2023 um 12:03 schrieb Dominik Csapak: > 'selectPoolMembers' will be called when the poolid field changes. > (That can even happen when the mode is not even 'pool') > Due to how the fields are set, there is a race condition that this > will be called after the remaining fields were set up,

[pve-devel] applied: [PATCH manager] api: ceph: mon create: remove superfluous verification call

2023-04-12 Thread Thomas Lamprecht
Am 03/04/2023 um 11:35 schrieb Fiona Ebner: > The pve_verify_cidr{,v4,v6} functions were originally intended for > the /etc/network/interfaces API endpoints and thus are a bit > restrictive. For example, as reported in the community forum[0], > pve_verify_cidr() does not consider '0::/0' and

[pve-devel] applied: [PATCH manager] configs: blacklist: fix typo

2023-04-12 Thread Thomas Lamprecht
Am 31/03/2023 um 14:45 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > configs/pve-blacklist.conf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH http-server] multipart upload: properly parse file parts without Content-Type

2023-04-11 Thread Thomas Lamprecht
Am 11/04/2023 um 14:19 schrieb Friedrich Weber: > As reported in the forum, multipart requests are parsed incorrectly if > the file part header contains *only* Content-Disposition, but no other > fields (in particular, no Content-Type). As a result, uploaded files > are mangled: In most cases, an

[pve-devel] applied: [PATCH proxmox-offline-mirror 1/2] pool: drop redundant quote for paths..

2023-04-06 Thread Thomas Lamprecht
Am 04/04/2023 um 13:21 schrieb Fabian Grünbichler: > a Path(Buf)'s Debug formatting already contains double quotes, no need to > quote > it a second time.. > > Signed-off-by: Fabian Grünbichler > --- > src/pool.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied,

[pve-devel] applied: [PATCH proxmox-offline-mirror 2/2] fix #4261: allow GC for all configured mirrors

2023-04-06 Thread Thomas Lamprecht
Am 04/04/2023 um 13:21 schrieb Fabian Grünbichler: > by making the --id parameter optional, and structuring the output accordingly. > since pools are per base-dir, GC only needs to run once per base-dir instead > of > for each mirror entry. > > Signed-off-by: Fabian Grünbichler > --- >

Re: [pve-devel] [PATCH proxmox-offline-mirror 2/2] fix #4632: allow escape hatches for legacy repositories

2023-04-06 Thread Thomas Lamprecht
Am 04/04/2023 um 09:48 schrieb Fabian Grünbichler: > there are still repositories out there that are using things like DSA/RSA-1024 > and SHA1, so let's allow POM users to opt into accepting those insecure > cryptographic parameters, but keep the default settings secure. > > Signed-off-by: Fabian

[pve-devel] applied: [PATCH proxmox-offline-mirror 0/2] improve GPG verification

2023-04-06 Thread Thomas Lamprecht
Am 04/04/2023 um 09:48 schrieb Fabian Grünbichler: > this patch series improves the error messages when encountering an issue with > GPG verification, and offers an (opt-in) escape hatch for allowing weak > cryptographic algorithms if a repository still needs those. > > Fabian Grünbichler (2): >

[pve-devel] applied-series: [PATCH widget-toolkit 0/4] Proxmox Dark Theme Fix-ups - Round 5

2023-04-06 Thread Thomas Lamprecht
Am 05/04/2023 um 10:08 schrieb Stefan Sterz: > this series fixes some more icons (e.g., the maintenance mode icon in > pbs), sets appropriates styles for tabs in focus and focus-over > states, fixes focused states for grid elements and improves contrats > for the apt group headers. > > Stefan

[pve-devel] applied: [PATCH v2 edk2-firmware] fix #4625: restore SMBIOS type 0 table defaults

2023-04-04 Thread Thomas Lamprecht
Am 30/03/2023 um 13:01 schrieb Fiona Ebner: > Commit 4cb94f20b0 ("OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*") in > the edk2 submodule made the switch from hard coded values for the > SMBIOS type 0 table to using those defined in the PCD (Platform > Configuration Database). But this changed the

Re: [pve-devel] [PATCH pve_manager 1/1] Translate units

2023-04-04 Thread Thomas Lamprecht
The subject is very lacking, if I'd stuble over this when skimming through a git log --oneline or the like, which I find myself doing very often in repos, I'd have no idea what this is about – translation is used for a myriad of things in IT and units too; also no subsystem tag - so no idea if

[pve-devel] applied: [PATCH proxmox-i18n v2 0/4] translation fo available languages

2023-03-27 Thread Thomas Lamprecht
Am 27/03/2023 um 14:02 schrieb Noel Ullreich: > Translations of the language-select menu, which now uses the endonym as > well as a translation of the language into the currently selected > language. > > --- > Changes from v1: > * The Dutch translation had a missing " which has been fixed in a

[pve-devel] applied: update Japanese translation

2023-03-27 Thread Thomas Lamprecht
applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] pvereport: add `date -R` to general system info section

2023-03-27 Thread Thomas Lamprecht
Am 23/02/2023 um 16:25 schrieb Lukas Wagner: > Sometimes it can be quite useful to know when exactly a system report > was generated. Adds the following output quite prominently in the > general system info section: > > # date -R > Thu, 23 Feb 2023 16:21:12 +0100 > > Signed-off-by: Lukas

Re: [PVE-User] Host console access with realm different from PAM

2023-03-27 Thread Thomas Lamprecht
Hi, Am 23/03/2023 um 11:30 schrieb Mariusz Suchodolski: > Is custom realm <-> pam mapping in plans? Not sure what you mean here exactly.. > > We've setup Azure AD authentication but attempting to connect to one of the > virtualization hosts yields the following message when attempting to

[pve-devel] applied-series: [PATCH qemu-server 1/2] backup: prepare: fix format detection for disks without storage ID

2023-03-27 Thread Thomas Lamprecht
Am 27/03/2023 um 11:01 schrieb Fiona Ebner: > which is the case for passed-through disks. The qemu_img_format() > function cannot correctly handle those, and it's not safe to assume > they are raw (it's most likely, but not guaranteed), so just use the > storage method for the format like it was

[pve-devel] applied: [PATCH common] fix #4615: RESTEnvironment: correctly detect AnyEvent in SIGCHLD handler

2023-03-27 Thread Thomas Lamprecht
Am 27/03/2023 um 10:26 schrieb Dominik Csapak: > we assumed that the 'priv' and 'pub' RESTEnvironment types always We might push it a bit here ;-) https://lists.proxmox.com/pipermail/pve-devel/2023-March/056057.html > contained an AnyEvent eventloop, but this is actually not the case > in

Re: [pve-devel] [PATCH pve-widget-toolkit] Changed 'kr' to 'ko' in language list

2023-03-27 Thread Thomas Lamprecht
Am 27/03/2023 um 09:58 schrieb Fabian Grünbichler: > >> Thomas Lamprecht hat am 26.03.2023 16:51 CEST >> geschrieben: >> >> In widget-toolkit we do not depend on any i18n package as widget-toolkit is >> also used in more than one project; adding an OR'd `pve-i18

Bug#1033540: systemd: backport patch to fix a calendar spec calculation hang on DST change if TZ=Europe/Dublin

2023-03-27 Thread Thomas Lamprecht
Package: systemd Version: 247.3-7+deb11u1 Severity: important Dear Maintainer, We (Proxmox) got quite a few reports over the weekend of stuck systemd processes, seemingly hung on calendar spec calculations. After a investigation it stuck out the only the Europe/Dubline time zone seemed affected.

Bug#1033540: systemd: backport patch to fix a calendar spec calculation hang on DST change if TZ=Europe/Dublin

2023-03-27 Thread Thomas Lamprecht
Package: systemd Version: 247.3-7+deb11u1 Severity: important Dear Maintainer, We (Proxmox) got quite a few reports over the weekend of stuck systemd processes, seemingly hung on calendar spec calculations. After a investigation it stuck out the only the Europe/Dubline time zone seemed affected.

[pve-devel] applied: [PATCH widget-toolkit] fix #4612: mobile: avoid crash due to missing getProxy method

2023-03-26 Thread Thomas Lamprecht
Am 24/03/2023 um 10:02 schrieb Friedrich Weber: > A previous commit (51083ee) added an override of the internal ExtJS > method `Ext.data.Store.onProxyLoad` in order to fix a race condition. > This override calls `Operation.getProxy`. However, this method is not > available on Sencha Touch. As a

Re: [pve-devel] [PATCH pve-widget-toolkit] Changed 'kr' to 'ko' in language list

2023-03-26 Thread Thomas Lamprecht
Am 24/03/2023 um 15:41 schrieb Noel Ullreich: > the ISO 639-1 two letter abbreviation of Korean is 'ko', not 'kr' > great find, but without renaming the PO file this breaks the whole translation completely, which isn't ideal for users - as for them the underlying used two letter code was just an

[pve-devel] applied: [PATCH pve-widget-toolkit 2/2] increased language dropdown menu width

2023-03-24 Thread Thomas Lamprecht
Am 23/03/2023 um 15:44 schrieb Noel Ullreich: > With the new translations and layout, the width of the dropdown menu > needs to be increased so that the languages are all on the same line. > This width might need to increased in the future if translations were to > create a linebreak. > >

[pve-devel] applied: [PATCH pve-widget-toolkit 1/2] Translated language dropdown menu in web interface

2023-03-24 Thread Thomas Lamprecht
Am 23/03/2023 um 15:44 schrieb Noel Ullreich: > Translated the languages in the web interface dropdown menu. Languages > used to be in English, now they are in their native language and > writing system along with their translation in the currently selected > language. > > Signed-off-by: Noel

[pve-devel] applied: [PATCH docs 1/1] user management: ldap: specify space and number sign escaping

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 14:14 schrieb Dominik Csapak: > number sign at the beginning (was missing completely) > space only needs escaping at the start and end > > Signed-off-by: Dominik Csapak > --- > pveum.adoc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks!

[pve-devel] applied-series: [PATCH widget-toolkit 0/5] Proxmox Dark Theme Fixups - Round 4

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 16:26 schrieb Stefan Sterz: > this round of fixups improves the contrast ratios on several icons and > the mask message. it also fixes the background of boundlists which > appeared to brightly in certain contexts and fixes #4610. #4610 is > fixed by adding a white padding to the

[pve-devel] applied: [PATCH access-control 1/1] fix #4609: allow valid DN in ldap/ad realm config

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 14:14 schrieb Dominik Csapak: > we previously added support for ',' in the dns attribute by allowing a > quoted format. the regex was sadly too restrictive: > > in a quoted attribute we'd only allow \w (alphanumeric + _) and the > restricted characters. this patch now changes

Re: [pve-devel] [PATCH access-control 1/1] fix #4609: allow valid DN in ldap/ad realm config

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 14:14 schrieb Dominik Csapak: > we previously added support for ',' in the dns attribute by allowing a > quoted format. the regex was sadly too restrictive: > > in a quoted attribute we'd only allow \w (alphanumeric + _) and the > restricted characters. this patch now changes

[pve-devel] applied: [PATCH pve-installer] fix typo in error message

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 09:56 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > proxinstall | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [RFC edk2-firmware] d/rules: re-enable PVSCSI support

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 11:10 schrieb Fiona Ebner: > It is not maintained anymore and got disabled by default in upstream > commit 57783adfb5 ("OvmfPkg: Change default to disable MptScsi and > PvScsi"). Re-enable it to preserve backwards compatibility in Proxmox > VE. > > Signed-off-by: Fiona Ebner >

Re: [pve-devel] [PATCH v3 manager 1/3] fix #4552: certhelpers: check if custom cert and key match on change

2023-03-23 Thread Thomas Lamprecht
Am 22/03/2023 um 16:41 schrieb Max Carrara: > On 3/14/23 16:08, Max Carrara wrote: >> It is now checked whether the new custom SSL certificate actually >> matches the provided or existing custom key. >> >> Also, the new custom certificate and key pair is now validated >> *before* it is used or

[pve-devel] applied: [PATCH manager] ui: ceph: unmask container after we finished the ceph install

2023-03-22 Thread Thomas Lamprecht
Am 22/03/2023 um 15:28 schrieb Dominik Csapak: > otherwise the container stays masked and we cannot interact with it > > Signed-off-by: Dominik Csapak > --- > www/manager6/Utils.js | 3 +++ > 1 file changed, 3 insertions(+) > > applied, thanks!

[pve-devel] applied: [PATCH i18n] update french translation

2023-03-22 Thread Thomas Lamprecht
Am 22/03/2023 um 13:37 schrieb Alexandre Derumier: > --- > fr.po | 133 +++--- > 1 file changed, 44 insertions(+), 89 deletions(-) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH i18n] add/reword some italian translations

2023-03-22 Thread Thomas Lamprecht
Am 22/03/2023 um 12:54 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > it.po | 560 +++--- > 1 file changed, 219 insertions(+), 341 deletions(-) > > applied, thanks! ___

[pve-devel] applied-series: [PATCH widget-toolkit 1/3] dark-mode: fix highlighting of active elements in drop down menus

2023-03-22 Thread Thomas Lamprecht
Am 22/03/2023 um 12:07 schrieb Stefan Sterz: > e.g.,: the filter menu item in the backup job creation window > > Signed-off-by: Stefan Sterz > --- > src/proxmox-dark/scss/extjs/_menu.scss | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied all four patches, thanks!

[pve-devel] applied: [PATCH docs] qm: freeze-fs-on-backup: remove reference to GUI

2023-03-22 Thread Thomas Lamprecht
Am 22/03/2023 um 12:09 schrieb Friedrich Weber: > The config option is currently not exposed in the GUI. > > Signed-off-by: Friedrich Weber > --- > qm.adoc | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > applied, thanks! ___

[pve-devel] applied: [PATCH proxmox-resource-scheduling] pve static: add one to avoid boosting tiny relative differences

2023-03-22 Thread Thomas Lamprecht
Am 21/03/2023 um 17:44 schrieb Fiona Ebner: > Only the relative difference for values between different alternatives > is relevant, meaning 0.002 vs 0.004 and 0.2 vs 0.4 will influence the > scoring in the same way. This is not really desirable, because values > closer to 1.0 indicate higher load

[pve-devel] applied: [PATCH v3 manager 3/3] ui: cert upload: fix private key field sending empty string

2023-03-21 Thread Thomas Lamprecht
Am 14/03/2023 um 16:08 schrieb Max Carrara: > The private key's field is now excluded from the upload form's > JSON data if it's left empty. > > Prior to this change, the form still used an empty string for the > private key's field, even if no key was provided by the user. > Because the key's

[pve-devel] applied: [PATCH v3 manager 2/3] ui: cert upload: use inputpanel for certificate upload

2023-03-21 Thread Thomas Lamprecht
Am 14/03/2023 um 16:08 schrieb Max Carrara: > This change replaces the the certificate upload form's items with > a single inputpanel widget. The components for the key and cert fields > are preserved as-is. Hardcoded values are now explicitly set in > `onGetValues` instead of using hidden

[pve-devel] applied: [PATCH widget-toolkit] dark-mode: set the background mask to `background-darker` again

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 15:15 schrieb Stefan Sterz: > this removes an issue where the mask would look awkward and > inconsistent (e.g., in the quarantine view, the retention tab of a > zfs storage etc). also makes the shadow a big bigger to be closer to > crisp and also to improve contrast ratios > >

[pve-devel] applied-series: [PATCH-SERIES proxmox-{resource-scheduling, perl-rs}] fix scoring issue with overcommitted node

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 13:33 schrieb Fiona Ebner: > The current algorithm is blind in cases where the static node stats > are the same and there is (at least) one node that is overcommitted > when compared to the others. > > The problem is that using the linear average produces the same values > for

[pve-devel] applied: [PATCH manager] replication: fix uninitalized warning

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 13:43 schrieb Fabian Grünbichler: > if a job has no schedule and is executed via "Schedule now" but fails, the > following will be printed to journal/syslog: > > Mar 21 13:05:01 host02 pvescheduler[203343]: send/receive failed, cleaning up > snapshot(s).. > Mar 21 13:05:01

[pve-devel] applied: [PATCH manager] api: apt: versions: also list Proxmox libraries for interfacing with Rust

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 14:33 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > PVE/API2/APT.pm | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH storage] feature: enable 'content-dirs' property for cephfs

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 13:59 schrieb Leo Nunner: > Signed-off-by: Leo Nunner > --- > PVE/Storage/CephFSPlugin.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH 1/3] Revert "dark-theme: let the background "shine through" mask more"

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 11:04 schrieb Wolfgang Bumiller: > This looks horrible. > > A *much* *much* better way to improve readability is to > simply set the opacity down to 0.5. > > This reverts commit 2c837f5766b48629a835c62d4b7af6c3ae4dc1c0. > --- > I can't stand this. > Seriously. > >

[pve-devel] applied: [PATCH i18n] add some missing italian translations

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 13:04 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > it.po | 253 +++--- > 1 file changed, 134 insertions(+), 119 deletions(-) > > applied, thanks! FYI: the ones marked "fuzzy" are new/untranslated too and

[pve-devel] applied: [PATCH widget-toolkit] networkedit: Add tooltip to bridge ports inputs

2023-03-21 Thread Thomas Lamprecht
Am 06/02/2023 um 11:58 schrieb Christoph Heiss: > .. as the exact format it takes might not be immediately obvious to > users. > > Signed-off-by: Christoph Heiss > --- > Bumped into that myself recently, it just avoids having to seek out > documentation for that one thing. > >

Re: [pve-devel] [PATCH v2 manager 2/3] ui: qga: Add option to turn off QGA fs-freeze/-thaw on backup

2023-03-21 Thread Thomas Lamprecht
Am 23/02/2023 um 15:18 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > Changes v1 -> v2: > * Rename option from 'fsfreeze_thaw' to 'freeze-fs-on-backup' > * Adapt option descriptions as suggested > > www/manager6/Utils.js | 2 ++ >

[pve-devel] applied: [PATCH docs] remove storage view

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 11:28 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > pve-gui.adoc | 2 -- > 1 file changed, 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH storage] cifs: use empty string instead of / as default directory

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 12:12 schrieb Stoiko Ivanov: > this keeps the mount sources consistent with previous versions > without this patch there is a small regression, which leads to the > storage not being recognized as being mounted on upgrade: > * pvestatd in older version mount the storage with out

[pve-devel] applied: [PATCH i18n] fix minor typo in German translation

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 12:19 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > > First time using 'in-rely-to' in `git format-patch`. Let's hope this > works as expected :^) > > de.po | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks!

[pve-devel] applied: [PATCH i18n 2/2] add missing german translations

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 11:36 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > de.po | 40 +--- > 1 file changed, 21 insertions(+), 19 deletions(-) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH i18n 1/2] minor stylistic touch-ups for the German translations

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 11:36 schrieb Lukas Wagner: > Mostly related to 'Leerzeichen in Komposita' [1] > > [1] https://de.wikipedia.org/wiki/Leerzeichen_in_Komposita > > Signed-off-by: Lukas Wagner > --- > de.po | 76 +-- > 1 file changed, 38

[pve-devel] applied: [PATCH v2 docs] fix #2641: document subdir parameter for CIFS backend

2023-03-21 Thread Thomas Lamprecht
Am 08/02/2023 um 10:05 schrieb Leo Nunner: > Signed-off-by: Leo Nunner > --- > pve-storage-cifs.adoc | 5 + > 1 file changed, 5 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH v2 docs 3/3] qm: Add section explaining fs-freeze/-thaw QGA option

2023-03-21 Thread Thomas Lamprecht
Am 23/02/2023 um 15:18 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > Changes v1 -> v2: > * Incorporate suggestions made by Thomas > > qm.adoc | 22 ++ > 1 file changed, 22 insertions(+) > > applied, with a trivial merge conflict due to additions in the

[pve-devel] applied: [PATCH i18n] update Arabic translations

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 10:49 schrieb Moayad Almalat: > Signed-off-by: Moayad Almalat > > --- > ar.po | 661 +++--- > 1 file changed, 259 insertions(+), 402 deletions(-) > > applied, thanks! ___

[pve-devel] applied: [PATCH qemu-server] avoid list context for volume_size_info calls

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 10:17 schrieb Fiona Ebner: > With the recent pve-storage commit d70d814 ("api: fix get content call > response > type for RBD/ZFS/iSCSI volumes"), the volume_size_info call for RBD in > list context is much slower than before (from a quick test, about twice as > long > without

[pve-devel] applied: [PATCH manager 2/2] ui: lvmthin: fix not being able to edit the storage

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 10:16 schrieb Dominik Csapak: > the change handler of the edit config from a displayeditfield still > triggers, even if not shown/disabled. sadly this enabled another > editconfig part of a displayeditfield, which triggers an error > in the api > > to fix that, simply check if

[pve-devel] applied: [PATCH manager 1/2] ui: lvmthin: don't add nodeselector/enable multiple times in edit window

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 10:16 schrieb Dominik Csapak: > seemingly an empty array is special for extjs, and if we push into it, > we overwrite the class definition of that property > > this does not happen when something is already in the array, so > the other edit windows work as expected > > to fix it

[pve-devel] applied: [PATCH pve-docs] sdn: add rp_filter sysctl tuning when mulitple evpn nodes are used

2023-03-21 Thread Thomas Lamprecht
Am 21/03/2023 um 07:53 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > pvesdn.adoc | 13 + > 1 file changed, 13 insertions(+) > applied, with touching up format and language slightly in a follow up, thanks! > diff --git a/pvesdn.adoc b/pvesdn.adoc > index

Re: [pve-devel] [PATCH v2 manager] gui: expose content-dirs property in storage edit/create

2023-03-20 Thread Thomas Lamprecht
Am 14/03/2023 um 14:14 schrieb Leo Nunner: > Add a separate tab for the storage edit/create panels to set the > recently introduced "content-dirs" property which overrides the > default directory locations. Analogous to the API implementation, > the tab was added for Directory, CIFS and NFS

[pve-devel] applied: [PATCH docs 2/2] pveum: Document reserved characters and quoting of LDAP DNs

2023-03-20 Thread Thomas Lamprecht
Am 31/01/2023 um 13:50 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > pveum.adoc | 33 + > 1 file changed, 33 insertions(+) > > applied, dropped the extra newlines for the list and the backtick quoting on the whitespace character to play safe

[pve-devel] applied: [PATCH docs] pveum: add RFC reference for reserved characters

2023-03-20 Thread Thomas Lamprecht
Am 20/03/2023 um 15:22 schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > pveum.adoc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

Re: [pve-devel] [PATCH v3 storage] deprecate mkdir option for create-path and create-sub-dirs

2023-03-20 Thread Thomas Lamprecht
Am 09/02/2023 um 14:18 schrieb Aaron Lauterer: > The `mkdir` option has two meanings[0][1] which are split up in `create-path` > and `create-sub-dirs`. > > The `create-path` option decides if the path to the storage is > automatically created or not. > The `create-sub-dirs` options decides if the

[pve-devel] applied: [PATCH v3 storage] api: fix get content call for volumes

2023-03-20 Thread Thomas Lamprecht
Am 09/03/2023 um 10:41 schrieb Christian Ebner: > `pvesh get /nodes/{node}/storage/{storage}/content/{volume}` failed for > several storage types, because the respective storage plugins returned > only the volumes `size` on `volume_size_info` calls, while also the format > is required. > > This

[pve-devel] applied: [PATCH access-control 1/2] ldap: Allow quoted values for DN attribute values

2023-03-20 Thread Thomas Lamprecht
Am 15/03/2023 um 10:54 schrieb Dominik Csapak: > hi, > > so high level comment: > i'd write most of what you wrote in the cover letter here in the commit > message, > makes it much more convenient to find it only via git ;) > > also i'm missing a bit the rationale for how the regex was chosen,

[pve-devel] applied: [PATCH v2 manager 1/3] api: ceph: deprecate pools in favor of pool

2023-03-20 Thread Thomas Lamprecht
Am 20/03/2023 um 14:47 schrieb Dominik Csapak: > Reviewed-by: Dominik Csapak > Tested-by: Dominik Csapak With above: applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied-series: [PATCH v3 manager 0/2] rework ceph cfg api

2023-03-20 Thread Thomas Lamprecht
Am 20/03/2023 um 14:36 schrieb Dominik Csapak: > aside from the one nit (which can be fixed up) fixed up in a follow up > > Reviewed-By: Dominik Csapak > Tested-By: Dominik Csapak > with above: applied series, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH v2 storage] config: use relative paths for content overrides

2023-03-20 Thread Thomas Lamprecht
Am 14/03/2023 um 14:14 schrieb Leo Nunner: > Remove the requirement for paths to start with a /, as it might be > confusing to users. > > Signed-off-by: Leo Nunner > --- > RFC: I'm not really sure how much input validation we want to do here. > e.g., should we keep the user from appending or

[pve-devel] applied: [PATCH widget-toolkit 0/4] Dark Theme Fix-ups Round 3

2023-03-20 Thread Thomas Lamprecht
Am 20/03/2023 um 10:02 schrieb Stefan Sterz: > this series adds a few more fix-ups for the dark theme: > > * fix the contrast ratio of the focus state of help buttons > * make help buttons hovered/focused state brigther to be more > consistent with the rest of the theme > * dim warning and

[pve-devel] applied: Re: [PATCH qemu] cherry-pick TCG-related stable fixes for 7.2

2023-03-17 Thread Thomas Lamprecht
On 17/03/2023 13:47, Fiona Ebner wrote: > When turning off the "KVM hardware virtualization" checkbox in Proxmox > VE, the TCG accelerator is used, so these fixes are relevant then. > > The first patch is included to allow cherry-picking the others without > changes.

[pve-devel] applied: Re: [PATCH docs v2] conf: add support for a dark mode in the documentation

2023-03-17 Thread Thomas Lamprecht
On 16/03/2023 18:02, Stefan Sterz wrote: > this commit adds support for a dark theme that behaves similarly to > that one used by the api viewer. > > Signed-off-by: Stefan Sterz > --- > asciidoc/pve-docs.css | 168 + > asciidoc/pve-html.conf | 4 + > 2

[pve-devel] applied: Re: [PATCH qemu] add patch fixing ACPI CPU hotplug issue with TCG

2023-03-17 Thread Thomas Lamprecht
On 17/03/2023 11:39, Fiona Ebner wrote: > Required for the debian/edk2-vars-generator.py script in the > pve-edk2-firmware repository when building the edk2-stable202302 > release. Without this patch, the QEMU process spawned by the script > would hang indefinietly. spotted above

[pve-devel] applied: [PATCH v3 widget-toolkit 1/2] repo view: replace non-clickable checkbox with icons

2023-03-17 Thread Thomas Lamprecht
On 26/01/2023 11:47, Lukas Wagner wrote: > From a usability view, having a checkbox that is not clickable is pretty > misleading, especially if the visual style is exactly the same as in > other places in the UI where the checkbox is functional. > > Signed-off-by: Lukas Wagner > --- >

[pve-devel] applied: [PATCH v3 manager 2/2] ui: backup: replication: replace non-clickable checkbox with icons

2023-03-17 Thread Thomas Lamprecht
On 26/01/2023 11:47, Lukas Wagner wrote: > From a usability view, having a checkbox that is not clickable is pretty > misleading, especially if the visual style is exactly the same as in > other places in the UI where the checkbox is functional. > > Signed-off-by: Lukas Wagner > --- >

[pve-devel] applied: [PATCH v4 container/manager 0/3] fix #3413: Add `Disconnect` option for LXC networks

2023-03-16 Thread Thomas Lamprecht
Am 22/02/2023 um 13:49 schrieb Christoph Heiss: > Add a `Disconnect` option for network interfaces on LXC containers, much > like it already exists for VMs. This has been requested in #3413 [0] and > seems useful, especially considering we already support the same thing > for VMs. > > One thing

[pve-devel] applied: [PATCH v2 installer] fix #4430: add UTC timezone as option to installer

2023-03-16 Thread Thomas Lamprecht
Am 16/03/2023 um 11:01 schrieb Christoph Heiss: > Adds 'Etc/UTC' as option to the timezone selection, regardless of what > country is selected. > > The 'Etc/' prefix needs to be stripped for the installation, as this > value is written to /etc/timezone. PVE/PMG/PBS already use 'UTC' without > the

[pve-devel] applied: [PATCH guest-common] fix #4572: config: also update volume IDs in pending section

2023-03-16 Thread Thomas Lamprecht
Am 15/03/2023 um 15:44 schrieb Fiona Ebner: > The method is intended to be used in cases where the volumes actually > got renamed (e.g. migration). Thus, updating the volume IDs should of > course also be done for pending changes to avoid changes referring to > now non-existent volumes or even the

[pve-devel] applied: [PATCH manager] ui: resource tree: correctly reinsert item when name changes

2023-03-16 Thread Thomas Lamprecht
Am 16/03/2023 um 10:03 schrieb Dominik Csapak: > if the user has the tree sorted by name, we have to move the items > on a name change, otherwise they'll stay on the old position > > Signed-off-by: Dominik Csapak > --- > www/manager6/tree/ResourceTree.js | 3 ++- > 1 file changed, 2

[pve-devel] applied: [PATCH manager v5 0/3] Ceph OSD: add detail infos

2023-03-15 Thread Thomas Lamprecht
Am 12/12/2022 um 13:14 schrieb Aaron Lauterer: > This patch series adds 2 new API endpoints for OSDs to fetch more > detailed information about a single OSD. One for overall information and > one for a single volume (block, db, wal). > > More in the actual patches. > > Series got [0]: >

[pve-devel] applied-series: [PATCH-SERIES manager] improve bulk action permissions

2023-03-15 Thread Thomas Lamprecht
Am 01/03/2023 um 15:22 schrieb Fiona Ebner: > In the UI, fix the checks to use the same permission as the backend, > i.e. VM.PowerMgmt rather than Sys.PowerMgmt. > > In the backend, also allow the bulk action when the user has the > appropriate permission for each guest in the passed-in list. >

[pve-devel] applied: [PATCH manager] ui: don't show tags/lock column in pool member grid

2023-03-15 Thread Thomas Lamprecht
Am 15/03/2023 um 16:30 schrieb Dominik Csapak: > we use a different api call where we currently don't have the tags or > lock, so don't add the columns there > > Signed-off-by: Dominik Csapak > --- > we could also add these in the api call, or use the resource grid as > source for the grid (not

Re: [pve-devel] [PATCH installer] fix #4430: add UTC timezone as option to installer

2023-03-15 Thread Thomas Lamprecht
Am 15/03/2023 um 13:26 schrieb Christoph Heiss: > The 'Etc/UTC' timezone does not have a definite 2-letter country code > assigned. 'xx' was choosen on the basis that this hopefully will never > be assigned to any real country in the future, but a small collision > check won't hurt either. > >

Re: [pve-devel] [PATCH access-control 1/2] ldap: Allow quoted values for DN attribute values

2023-03-15 Thread Thomas Lamprecht
Am 15/03/2023 um 12:41 schrieb Dominik Csapak: > if my example and all that could have been configured but > would now be invalid are not valid ldap syntax anyway, i think > we can get more strict and "break" someones config > (as you said, shouldn't have worked anyway) > or how do you see that

[pve-devel] applied: [PATCH proxmox-login-manager] login: fix login for saved ipv6 addresses

2023-03-15 Thread Thomas Lamprecht
Am 01/12/2022 um 10:27 schrieb Dominik Csapak: > Since we only string concatenated the host + port, ipv6 addresses were > invalid because their missing [] around the ip. To fix that, use > 'Uri's 'toString' method but strip the 'https://' prefix when creating > an Uri object again > > This now

[pve-devel] applied: [PATCH v3 widget-toolkit 1/2] ui: SMART: fix eslint error / show correct value

2023-03-14 Thread Thomas Lamprecht
Am 24/02/2023 um 15:40 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > > Changes from v2: > Calculate the field in a different way... > > Thanks to dominik for simplifying/fixing the logic! > > src/window/DiskSmart.js | 4 ++-- > 1 file changed, 2 insertions(+), 2

[pve-devel] applied: [PATCH widget-toolkit v3 1/1] RealmComboBox: add custom store filters for callers

2023-03-14 Thread Thomas Lamprecht
Am 17/01/2023 um 12:46 schrieb Dominik Csapak: > so that a user can filter the underlying store, e.g. for type > > Signed-off-by: Dominik Csapak > --- > src/form/RealmComboBox.js | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH manager] pveproxy/template: switch to using the "auto" theme per default

2023-03-14 Thread Thomas Lamprecht
Am 14/03/2023 um 15:01 schrieb Stefan Sterz: > the auto theme uses media queries to detect a users preferred theme, > switch to using it per default instead of the light theme. > > Signed-off-by: Stefan Sterz > --- > PVE/Service/pveproxy.pm | 5 - > www/index.html.tpl | 8 > 2

[pve-devel] applied: [PATCH widget-toolkit 0/2] Proxmox Dark Theme Fix-ups Round 2

2023-03-14 Thread Thomas Lamprecht
Am 14/03/2023 um 15:01 schrieb Stefan Sterz: > this theme switches the default theme to the 'auto' theme for > all three producs (pve, pmg, pbs) in addition to two minor fix-ups > > * for the widget toolkit a bit of brightness is added to the check-box > icons > * in the pmg-gui the main logo

[pve-devel] applied: [PATCH manager] ui: fix not opening 'bulk action' windows

2023-03-14 Thread Thomas Lamprecht
Am 14/03/2023 um 11:20 schrieb Dominik Csapak: > we previously removed the 'filters' property from the store, but this > has the effect that the filter array is only ever initialized when > we try to access them via the specified api of extjs > > so instead of adding them manually to their array,

[pve-devel] applied: [PATCH manager 0/7] backup edit window improvements

2023-03-14 Thread Thomas Lamprecht
Am 06/03/2023 um 15:23 schrieb Dominik Csapak: > two bugfixes (the VMSelector changes are necessary for those) > and a refactor of the edit window (i put that patch at the end, because even > with simplifications, it's still ~30 lines more, and i was not sure if that's > worth it) > > Dominik

Re: [pve-devel] [PATCH qemu-server] qemu options: add memory_allocator

2023-03-13 Thread Thomas Lamprecht
Am 13/03/2023 um 11:16 schrieb Alexandre Derumier: > Add optional memory_allocator. > > Default is glibc malloc, tcmalloc is available to improve performance > of ceph librbd. Looks ok besides some config/api schema details I'd like to see changed. > > Signed-off-by: Alexandre Derumier > ---

[pve-devel] applied-series: [PATCH qemu] add patches to fix regression with LSI SCSI controller

2023-03-13 Thread Thomas Lamprecht
Am 13/03/2023 um 12:43 schrieb Fiona Ebner: > The patch 0008-memory-prevent-dma-reentracy-issues.patch introduced a > regression for the LSI SCSI controller leading to boot failures [0], > because, in its current form, it relies on reentrancy for a particular > ram_io region. > > [0]:

[pve-devel] applied-series: [PATCH qemu 1/2] fixup patch "ide: avoid potential deadlock when draining during trim"

2023-03-13 Thread Thomas Lamprecht
Am 09/03/2023 um 14:37 schrieb Fiona Ebner: > The patch was incomplete and (re-)introduced an issue with a potential > failing assertion upon cancelation of the DMA request. > > There is a patch on qemu-devel now[0], and it's the same as this one > code-wise (except for comments). But the

Re: [pve-devel] [PATCH manager 1/3] api: ceph: add endpoint to fetch config keys

2023-03-13 Thread Thomas Lamprecht
Am 13/03/2023 um 13:58 schrieb Aaron Lauterer: > On 3/11/23 18:07, Thomas Lamprecht wrote: >> We could add the full >> >> cfg/ >>     raw >>     db >>     value >> >> now already, re-mount the 'cfg/raw' one on the current 'config' (or just keep

Re: [pve-devel] [PATCH manager] ui: PBSEdit: cleanup iframe for paperkey

2023-03-13 Thread Thomas Lamprecht
Am 13/03/2023 um 09:30 schrieb Aaron Lauterer: > On 3/11/23 17:49, Thomas Lamprecht wrote: >> Am 10/03/2023 um 15:36 schrieb Aaron Lauterer: >>> @@ -181,6 +187,7 @@ ${prettifiedKey} >>>     printFrame.src = "data:text/html;base64," + btoa(html); >>&

Re: [pve-devel] [PATCH manager 4/7] ui: VMSelector: correctly change invalid class on en/disable

2023-03-11 Thread Thomas Lamprecht
Am 06/03/2023 um 15:23 schrieb Dominik Csapak: > since we manually handle the invalid class, we have to manually trigger > that on setDisabled > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/VMSelector.js | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff

[pve-devel] applied: [PATCH common] certificate: actually print openssl errors

2023-03-11 Thread Thomas Lamprecht
Am 07/03/2023 um 11:50 schrieb Fabian Grünbichler: > print_errs (which is also called internally by die_now) will only 'warn' the > collected error stack if the log level is set to tracing. otherwise, it will > just return the error message(s) corresponding to the error stack as string. > > while

<    6   7   8   9   10   11   12   13   14   15   >