Am 08/03/2023 um 07:53 schrieb Thomas Lamprecht:
> Am 17/01/2023 um 12:46 schrieb Dominik Csapak:
>> this is a pattern we have very often, so we can implement that here and
>> reuse it
>>
>> Signed-off-by: Dominik Csapak
>> ---
>> src/PVE/SectionConfig.pm
Am 07/03/2023 um 13:11 schrieb Leo Nunner:
> Introduce a cluster-wide vzdump.conf file which gets filled with the
> default vzdump configuration.
>
> Signed-off-by: Leo Nunner
> ---
> data/PVE/Cluster.pm | 1 +
> data/src/status.c | 1 +
> 2 files changed, 2 insertions(+)
>
>
applied, this
Am 08/03/2023 um 12:47 schrieb Fabian Grünbichler:
> otherwise, print/warn statements by the API endpoint are included in the
> output, which breaks JSON parsing in case of output-format == json*.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> technically a change that might
Am 08/03/2023 um 13:14 schrieb Dominik Csapak:
> high level:
>
> as you mentioned the path 'configkey' is not really optimal
>
> i recently mentioned off-list that we could clean this up on
> the next breaking major release with a breaking api change:
>
> have a 'config' dir and a
> 'file'
>
Am 09/03/2023 um 13:30 schrieb Friedrich Weber:
> If `pvecm add` is issued from /etc/pve (or any subdirectory), it
> prints some errors:
>
> [...]
> shell-init: error retrieving current directory: getcwd: cannot
> access parent directories: Transport endpoint is not connected
>
Am 10/03/2023 um 10:06 schrieb Fiona Ebner:
> It is rather unexpected and seems worth mentioning. Reported in the
> community forum [0] and the explanation found by Alwin [1].
>
> [0]: https://forum.proxmox.com/threads/123819/
> [1]:
>
Am 10/03/2023 um 14:08 schrieb Dominik Csapak:
> it was missing there. Without this, it will not show up during
> cli autocompletion and in the html debug view (/api2/html/).
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/API2/Nodes.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied,
Am 10/03/2023 um 14:08 schrieb Stefan Sterz:
> this series adds a couple of fix-ups to the recently introduced
> dark-theme. it first fixes summary rows again (they wore broken in a
> refactoring step), then darkens the background mask further, dims
> buttons more, removes thicker borders that are
Am 10/03/2023 um 15:36 schrieb Aaron Lauterer:
> Otherwise the iframe used to print the paperkey will remain even after
> the encryption key window is closed.
thanks for noticing!
> Additionally clean before creating a new one as otherwise we might end
> up with multiple iframes.
having to do
Am 10/03/2023 um 15:08 schrieb Dominik Csapak:
> since the ruleselector is not allowed to be empty, but the loading of
> the rules is not instant, the validity change will trigger before the
> load was finished. Since it is in the advanced section, it will be
> opened everytime instead of only
Am 10/03/2023 um 15:08 schrieb Dominik Csapak:
> instead of only checking the validity of the advanced items when
> the form validity changed as a whole, add a validitychange listener
> to each field in the advanced section.
>
> This improves the behaviour such that everytime an advanced field
Am 11/03/2023 um 14:02 schrieb Alexandre Derumier:
> JsonSchema is already ok:
> $CONFIGID_RE = qr/[a-z][a-z0-9_-]+/i;
>
> This is blocking creation of snapshot name with "-" in gui.
> (works fine command line)
>
> Signed-off-by: Alexandre Derumier
> ---
> src/Toolkit.js | 2 +-
> 1 file
Hi,
Am 10/03/2023 um 19:05 schrieb DERUMIER, Alexandre:
> I'm currently benching again qemu with librbd and memory allocator.
>
>
> It's seem that they are still performance problem with default glibc
> allocator, around 20-25% less iops and bigger latency.
Are those numbers compared to
hus actually uses the current result (unlike
we do in the store load listener).
Signed-off-by: Thomas Lamprecht
---
www/manager6/UIOptions.js | 4 +---
www/manager6/data/ResourceStore.js | 9 +
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/www/manager6/UIOptions.js b/
Am 09/03/2023 um 09:07 schrieb Stefan Sterz:
> On 3/8/23 18:05, Thomas Lamprecht wrote:
>> we might want to make auto default rather quickly ;-)
>
> yes that might make sense. my intention was to not "surprise" existing
> users with a potentially unwanted over
Am 08/03/2023 um 17:40 schrieb Stefan Sterz:
> From: Daniel Tschlatscher
>
> this requires a bump of the widget toolkit so the version includes the
> necessary widgets.
>
> Signed-off-by: Daniel Tschlatscher
> Signed-off-by: Stefan Sterz
> ---
> www/manager6/Workspace.js | 8
> 1
Am 08/03/2023 um 17:18 schrieb Stefan Sterz:
> this patch series aims to add support for a dark theme to all current
> proxmox products. including:
>
> * proxmox virtual environment web gui & api viewer
> * proxmox backup server gui & api viewer
> * proxmox mail gateway gui, api viewer & (mobile)
Am 08/03/2023 um 17:38 schrieb Aaron Lauterer:
>> That said, why not avoid the tooltip but inline the info by moving the
>> severity to
>> the right, dropping the info button completely and making the grid row
>> expandable,
>> i.e., like the PMG tracking center grid does?
>
> We thought about
Am 08/03/2023 um 13:09 schrieb Aaron Lauterer:
> The goal for this small series is to make it easier/more obvious to see
> that there are potentially more details for a warning ceph is showing
> by:
> * having a tooltip with the details (limited in length)
> * making the detail/info button more
Am 08/03/2023 um 12:51 schrieb Fiona Ebner:
> In particular, the deadlock can occur, together with unlucky timing
> between the QEMU threads, when the guest is issuing trim requests
> during the start of a backup operation.
>
> Signed-off-by: Fiona Ebner
> ---
>
Am 17/01/2023 um 12:46 schrieb Dominik Csapak:
> so that we can reuse it easily
>
> Signed-off-by: Dominik Csapak
> ---
> src/PVE/Auth/Plugin.pm | 42 +++---
> 1 file changed, 23 insertions(+), 19 deletions(-)
>
>
applied, thanks!
Am 17/01/2023 um 12:46 schrieb Dominik Csapak:
> this is a pattern we have very often, so we can implement that here and
> reuse it
>
> Signed-off-by: Dominik Csapak
> ---
> src/PVE/SectionConfig.pm | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git
Am 06/03/2023 um 15:03 schrieb Friedrich Weber:
> Some UI components use `Ext.data.Store.setProxy` to change their
> associated API endpoint URL in reaction to user input. One example is
> `BackupView`, which calls `setProxy` when the user switches from
> listing backups on storage A to listing
Am 07/03/2023 um 19:33 schrieb Thomas Lamprecht:
>> diff --git a/www/manager6/node/Certificates.js
>> b/www/manager6/node/Certificates.js
>> index 34013b44..84fc12ff 100644
>> --- a/www/manager6/node/Certificates.js
>> +++ b/www/manager6/node/Certificates.js
>
Am 06/03/2023 um 08:41 schrieb Fiona Ebner:
> A regression in 7.2 and easily reproduced.
>
> Signed-off-by: Fiona Ebner
> ---
> ...as-Internal-cdbs-have-16-byte-length.patch | 69 +++
> debian/patches/series | 1 +
> 2 files changed, 70 insertions(+)
>
Am 06/03/2023 um 15:03 schrieb Friedrich Weber:
> Some UI components use `Ext.data.Store.setProxy` to change their
> associated API endpoint URL in reaction to user input. One example is
> `BackupView`, which calls `setProxy` when the user switches from
> listing backups on storage A to listing
Am 07/03/2023 um 15:19 schrieb Fiona Ebner:
> Several people reported IO-related issues since kernel 6.1.6 [0].
> Things got better with 6.1.10, but apparently the issues are not fully
> resolved (e.g. [1]).
>
> I ran into an issue with PBS backup of a VM with passed-through disks
> (error with
Am 03/03/2023 um 18:57 schrieb Max Carrara:
> The private key's field is now excluded from the upload form's
> JSON data if it's considered empty by Ext.js.
nit: Ext JS
>
> Prior to this change, the form still sent an empty string if no
> private key was provided by the user, even though the
On 20/02/2023 11:08, Dominik Csapak wrote:
> when we're in an API server that uses AnyEvent, we must postpone
> the worker_reaper, since it calls 'active_workers' which might already
> be called and then we're inside the lock twice (flocks are per process
> for us, see PVE::Tools::lock_file)
>
>
Am 07/03/2023 um 11:52 schrieb Fabian Grünbichler:
> with an added 'check_' prefix for the sub name to indicate that this will die
> if
> the checked condition is not met.
please use assert_ for that in the future, check is hardly more telling
as it often indicates the booleaness of the return
Am 18/11/2022 um 02:39 schrieb John Hollowell:
> This fixes an issue where an upload request without a Content-Type in
> the file's multipart part would prevent the upload and throw
> missleading errors. This patch removes the requirement and ignores
> all multipart headers once the needed
Am 15/02/2023 um 10:44 schrieb Fabian Grünbichler:
> by switching to a tree-based in-memory structure, like we do in PBS.
>
> instead of parsing ACL entries into a hash using the full ACL path as key for
> each entry, parse them into a tree-like nested hash. when evaluating ACLs,
> iterating over
Am 09/02/2023 um 10:27 schrieb Leo Nunner:
> Introduce a cluster-wide vzdump.conf file which gets filled with the
> default vzdump configuration.
>
> Signed-off-by: Leo Nunner
> ---
>
> data/PVE/Cluster.pm | 1 +
> data/PVE/Cluster/Setup.pm | 32 +---
>
Am 16/02/2023 um 13:35 schrieb Fiona Ebner:
> Add a get_derived_property() method to AbstractConfig.pm, taking a
> (partial) config and the name for the derived property. The first two
> will be 'maxcpu' and 'maxmem' (should I use 'max-cpu' or different
> names?), because that's what HA manager
On 24/02/2023 12:06, Dominik Csapak wrote:
> Otherwise the created vlan bridge has the default MTU, which is
> unexpected when the original bridge has some other MTU configured.
>
> We already do this for the firewall bridges, so we should do so too for
> the vlan bridges.
>
> Signed-off-by:
On 17/02/2023 17:08, Fiona Ebner wrote:
> Also, updates the section for the SCSI controller to mention the
> current default.
>
> Fiona Ebner (4):
> qm: hard disk controllers: reword and update section
> qm: hard disk controllers: recommend VirtIO controllers
> qm: emulated devices: mention
Am 24/02/2023 um 08:37 schrieb Fiona Ebner:
> Respecting bandwidth limit for offline clone was implemented by commit
> 56d16f16 ("fix #4249: make image clone or conversion respect bandwidth
> limit"). It's still not respected for EFI disks, but those are small,
> so just ignore it.
>
>
Am 17/11/2022 um 14:18 schrieb Leo Nunner:
> Previously, cloning a stopped VM didn't respect bwlimit. Passing the -r
> (ratelimit) parameter to qemu-img convert fixes this issue.
>
> Signed-off-by: Leo Nunner
> ---
> Changes from v1:
> - Remove unneeded "undef"s, as to not unnecessarily
Am 26/11/2022 um 08:20 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier
> ---
> PVE/QemuServer.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
Am 23/02/2023 um 15:18 schrieb Christoph Heiss:
> Signed-off-by: Christoph Heiss
> ---
> Changes v1 -> v2:
> * Rename option from 'fsfreeze_thaw' to 'freeze-fs-on-backup'
> * Adapt option description as suggested
> * Fix option check in qga_fs_freeze()
>
> PVE/QemuServer.pm| 8
Am 30/01/2023 um 13:57 schrieb Matthias Heiserer:
> Required because there's one single efi for ARM, and
> the 2m/4m difference doesn't seem to apply.
>
> Signed-off-by: Matthias Heiserer
> ---
>
> Changes from v1:
> Rather than change the efi type in the GUI, ignore it
> in the API
>
>
Am 18/01/2023 um 13:21 schrieb Fiona Ebner:
> There was a recent failure when migrating a production VM
>> kvm: tpm-emulator: Setting the stateblob (type 1) failed with a TPM error
>> 0x3 a parameter is bad
>> kvm: error while loading state for instance 0x0 of device 'tpm-emulator'
>> kvm: load
Am 01/02/2023 um 13:59 schrieb Christoph Heiss:
> Signed-off-by: Christoph Heiss
> ---
> qm.adoc | 20
> 1 file changed, 20 insertions(+)
>
> diff --git a/qm.adoc b/qm.adoc
> index 8a49283..f029ceb 100644
> --- a/qm.adoc
> +++ b/qm.adoc
> @@ -1061,6 +1061,26 @@ operations
Am 01/02/2023 um 13:59 schrieb Christoph Heiss:
> Signed-off-by: Christoph Heiss
> ---
> PVE/QemuServer.pm| 8 +++-
> PVE/VZDump/QemuServer.pm | 5 +
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index
Am 23/02/2023 um 10:49 schrieb Fiona Ebner:
> The guest will be running, so it's misleading to fail the start task
> here. Also ensures that we clean up the hibernation state upon resume
> even if there is an error here, which did not happen previously[0].
>
> [0]:
Am 22/02/2023 um 08:51 schrieb Dominik Csapak:
> this series allows configuring the sorting of the resource tree
>
> options are the sort-field, if guest types are grouped and if templates
> are grouped seperately. it's configurable via browser local storage
>
> the first 2 patches are not
Am 21/02/2023 um 09:05 schrieb Christoph Heiss:
> If this network option is set, the host-side link will be forced down
> and the interface won't be connected to the bridge.
>
> Signed-off-by: Christoph Heiss
> ---
> Changes v1 -> v2:
> * Split trailing whitespace fix into separate patch
> *
Am 21/02/2023 um 09:05 schrieb Christoph Heiss:
> This pattern is used in multiple places, thus just extract it into a sub
> on its own.
>
> No functional changes.
>
> Signed-off-by: Christoph Heiss
> ---
> Might not be the best place for net_tap_plug(), putting this logic
> inside PVE::Network
Am 21/02/2023 um 09:05 schrieb Christoph Heiss:
> No functional changes.
>
> Signed-off-by: Christoph Heiss
> ---
> Changes v1 -> v2:
> * New patch, split out from patch 2
>
> Changes v2 -> v3:
> * Fix botched whitespace patch
>
> src/PVE/LXC.pm | 10 +-
> 1 file changed, 5
Am 21/02/2023 um 14:13 schrieb Stoiko Ivanov:
> I think I've seen similar reports a few times in our community-forum, but
> never followed through - or thought it was fixed by some other issue:
> https://forum.proxmox.com/threads/.122961/
>
> While fixing the concrete issue for dns_cf.sh I tried
Am 21/02/2023 um 11:23 schrieb Aaron Lauterer:
> This gives us more detailed infos about the problems Ceph currently has.
> It is the last command because if PGs have issues, the list can be quite
> long. Therefore, we want it at the end of the report.
>
> Signed-off-by: Aaron Lauterer
> ---
>
Am 21/02/2023 um 13:21 schrieb Fiona Ebner:
> Reported here[0] and here[1].
>
> [0]: https://gitlab.com/qemu-project/qemu/-/issues/1378
> [1]: https://forum.proxmox.com/threads/122776/
>
> Signed-off-by: Fiona Ebner
> ---
>
> Another reentrancy issue ;)
>
>
Am 21/02/2023 um 10:08 schrieb Fiona Ebner:
> that could lead to use-after-frees and stack overflows with a
> malicious (or buggy) guest. See [0] for a good summary:
>
> [0]:
> https://lore.kernel.org/qemu-devel/cafeaca_23vc7he3iam-jva6w38lk4hjowae5kcknhprd5fp...@mail.gmail.com
>
>
Am 30/01/2023 um 11:20 schrieb Fiona Ebner:
> di->size would only be set later. The errno is minus the return value
> from the function.
>
> Signed-off-by: Fiona Ebner
> ---
> .../0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch | 4 ++--
>
Am 26/01/2023 um 14:46 schrieb Fiona Ebner:
> when pend_postcopy is large. By definition, pend_postcopy won't
> decrease when iterating, so a value larger than the cutoff of 40
> would lead to essentially empty iterations, filling up the state file
> until only 30 MiB + pending_size remain and
Am 20/02/2023 um 13:33 schrieb Wolfgang Bumiller:
>>> I assumed that, that's why I asked if keeping it that way would help to
>>> reuse some
>>> code infra; not sure about how useful it is to keep it for API consumers to
>>> keep it
>>> the same as in a quite different API end point,
>> There
Am 17/02/2023 um 16:25 schrieb Max Carrara:
> This patch series refactors the request processing algorithm by
> separating its data and logic from one another in order to make future
> changes regarding requests more transparent and explicit.
>
> Patch 1: Introduce the refactored algorithm
>
Am 17/02/2023 um 15:51 schrieb Wolfgang Bumiller:
>> * Rename option to kebap-case
> Sorry I missed that when Thomas replied to the v1.
> This is a case where the property already exists in the VM api, so
> better reuse the snake_case version here. @Thomas?
>
I assumed that, that's why I asked
Am 14/02/2023 um 09:13 schrieb Aaron Lauterer:
> By switching from 'ceph osd tree' to the 'ceph osd df tree' mon API
> equivalent , we get the same data structure with more information per
> OSD. One of them is the number of PGs stored on that OSD.
>
> The number of PGs per OSD is an important
Am 15/02/2023 um 09:29 schrieb Friedrich Weber:
> Tested-by: Friedrich Weber
with above: applied, thanks to both of you!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Am 14/02/2023 um 17:14 schrieb Aaron Lauterer:
> Seems like the `osd df tree` call is about 25% slower, plus minus.
>
> Tested on our AMD test cluster that is currently set up with 3 nodes with 4
> OSDs each. 50k iterations.
>
> root@jura1:~# ./bench.pl
> Rate osd-df-tree
On 14/02/2023 09:13, Aaron Lauterer wrote:
> By switching from 'ceph osd tree' to the 'ceph osd df tree' mon API
> equivalent , we get the same data structure with more information per
the change looks almost too neat for using a completely different command,
a bit fishy, but hey, if it works
On 09/02/2023 11:29, Lukas Wagner wrote:
> Keycloak seems to have dropped the `auth` part at some point in the past.
from some other references it seems to have happened in 18.0, but I did not
find a clear releases/news list, so hard to tell for sure - anyhow, I got
my local instance I upgraded ~
On 14/02/2023 11:10, Christoph Heiss wrote:
>> besides from that, the patch here contains quite some unrelated whitespace
>> changes, please avoid that.
> That was intentional (as noted), since there are trailing whitespaces
> all over the file, which can be somewhat annoying if one's editor
>
On 09/02/2023 10:27, Leo Nunner wrote:
> + change the wording from "Global configuration" to "Node-wide
> configuration"
>
> Signed-off-by: Leo Nunner
> ---
> The wording was previously already changed by Fiona but hasn't been
> merged yet:
>
>
On 13/02/2023 14:56, Christoph Heiss wrote:
> +link_down => {
> + type => 'boolean',
> + description => 'Whether this interface should be disconnected (like
> pulling the plug).',
> + optional => 1,
> +},
I'd prefer using kebab-case over snake_case for new properties, or do
On 13/02/2023 12:12, Matthias Heiserer wrote:
> Signed-off-by: Matthias Heiserer
> ---
>
> Changes from v2:
> make expression more compact
>
>
> src/window/DiskSmart.js | 17 ++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
>
applied, thanks!
On 13/02/2023 11:24, Leo Nunner wrote:
> Adds a field to the "meta" config property which stores the user who
> created the VM.
Should also get this finally added to CTs, I know it's a bit unfair to
add the burden to this patch series, but otherwise we might never add
it..
>
> Signed-off-by:
On 13/02/2023 10:19, Max Carrara wrote:
> Includes the contents of /etc/pve/datacenter.cfg
> in the cluster section.
>
> Signed-off-by: Max Carrara
> ---
> Changes from v1:
> * Output of `/etc/pve/datacenter.cfg` is now in the cluster section,
>as discussed[1]
>
> [1]
On 12/02/2023 10:16, DERUMIER, Alexandre wrote:
>
> It seem than k8s finally support CRIU live migration
>
> https://fosdem.org/2023/schedule/event/container_kubernetes_criu/
>
interesting
>
> I don't known about lxc, but maybe is it finally working too ?
with a limited feature set maybe,
Hi,
On 11/02/2023 00:54, Roland via pve-devel wrote:
>
> syscmd("zpool set bootfs=$zfspoolname/ROOT/$zfsrootvolname
> $zfspoolname") == 0 ||
> die "zfs set bootfs failed\n";
>
> that should have been:
>
> die "zpool set boofs failed\n";
Thanks for the report, fixed but kept boofs as bootfs
On 10/02/2023 15:19, Fiona Ebner wrote:
> Previously, changing aio would be applied to the configuration, but
> the drive would still be using the old setting.
>
> Signed-off-by: Fiona Ebner
> ---
> PVE/QemuServer.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied
On 10/02/2023 10:39, Fiona Ebner wrote:
> Otherwise, they don't affect the build of QEMU at all.
>
> Signed-off-by: Fiona Ebner
> ---
> debian/rules | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
not sure how many use the `noopt`, on debugging - for what it's mostly useful,
On 08/02/2023 17:02, Lukas Wagner wrote:
> 'additionally' in this context is a bit misleading, as it suggests
> that e.g. 'VM.Allocate' AND 'Permissions.Modify' are needed, conflicting
> with the previous paragraph.
>
> Signed-off-by: Lukas Wagner
> ---
> The ambiguity popped up in a recent
On 02/02/2023 15:41, Dominik Csapak wrote:
> it is basically the 'Server View' but with less content, and has often
> times lead to confusion when uses accidentally selected it.
>
> Signed-off-by: Dominik Csapak
> ---
> www/manager6/form/ViewSelector.js | 7 ---
> 1 file changed, 7
On 09/02/2023 12:43, Stefan Sterz wrote:
> previously the upid would just be used without a file extension when
> downloading a task log. this lead to rather strange filenames that
> appeared unfamiliar to users as the upid is not very prevalent in the
> gui. set a proper file name based on the
Am 02/02/2023 um 10:57 schrieb Markus Frank:
> For this patch-series please update the mirror and the submodule.
done.
fwiw, you could already have updated the submdoules commit to point
at the v1.4.0 tag and sent it along in this series.
I now merged that, and dropping the format-patch
Am 07/02/2023 um 16:34 schrieb Max Carrara:
> Simply includes the contents of /etc/pve/datacenter.cfg
> in the general system info section.
Looks ok, albeit it could be slightly more fitting in the cluster section, but
no hard feelings from my side - maybe get the opinion of devs currently
Am 01/02/2023 um 12:52 schrieb Matthias Heiserer:
> Signed-off-by: Matthias Heiserer
> ---
>
> Sorry for the long delay!
> v1: https://lists.proxmox.com/pipermail/pve-devel/2022-July/053599.html
> Changes from v1:
> use Field.calculate as suggested by Dominik
>
> src/window/DiskSmart.js | 25
Am 01/12/2022 um 12:32 schrieb Leo Nunner:
> CIFS/SMB supports directly mounting subdirectories, so it makes sense to
> also allow the --subdir parameter for these storages. The subdir
> parameter was moved from CephFSPlugin.pm to Plugin.pm, because it isn't
> specific to CephFS anymore.
>
>
Am 02/02/2023 um 15:20 schrieb Leo Nunner:
> On 2022-12-01 12:32, Leo Nunner wrote:
>> CIFS supports mounting subdirectories inside a share, so it makes sense
>> to also have the 'subdir' parameter for the CIFS backend. I'm also
>> looking into allowing overrides for all the fixed directories, but
looks like going in the right direction and feasible, some comments inline
high level: subject is using module name 1:1, as mentioned a few times please
avoid that, for ~ 99.9% cases it's not useful, for sure not for d/changelog but
not really for other devs in `git log` (sorting trees can mean
Am 01/02/2023 um 16:49 schrieb Dominik Csapak:
> we'll need it elsewhere too, and it was rather hidden in the
> updateTagSettings call.
>
> Signed-off-by: Dominik Csapak
> ---
> www/manager6/Utils.js | 3 +++
> www/manager6/dc/OptionView.js | 1 +
> 2 files changed, 4 insertions(+)
>
>
Am 30/01/2023 um 11:59 schrieb Leo Nunner:
> This patch fixes the issue that when the user supplied any non-standard
> repositories, the changelogs often wouldn't load. For example, providing
> both pve-no-subscription and pbs-no-subscription broke the changelog
> API, since the URL built for
Am 30/01/2023 um 11:59 schrieb Leo Nunner:
> This patch fixes the issue that when the user supplied any non-standard
> repositories, the changelogs often wouldn't load. For example, providing
> both pve-no-subscription and pbs-no-subscription broke the changelog
> API, since the URL built for
Am 27/01/2023 um 11:14 schrieb Dominik Csapak:
> When clicking the toolbar of the ComboGrid, the combobox loses focus,
> and instantly hides the picker.
>
> To prevent that, we keep track of the mousedown event on the toolbar
> (which happily comes before the focusLeave event), and prevent the
>
Am 30/01/2023 um 14:27 schrieb Fabian Grünbichler:
> but allow discarding BTF information when loading modules, so that upgrades
> which are otherwise ABI compatible still work. this allows using BTF
> information when matching and available, while degrading gracefully if the
> currently running
Am 27/01/2023 um 11:14 schrieb Dominik Csapak:
> 'picker.hide()' hides the picker, but does not do everything to properly
> keep track of the picker state in the combobox class.
>
> This lead to a bug when we reselected an entry, we had to click the
> picker again twice to open it again.
>
> Use
Am 27/01/2023 um 11:41 schrieb Fabian Grünbichler:
> On January 18, 2023 2:54 pm, Leo Nunner wrote:
>> This patch fixes the issue that when the user supplied any non-standard
>> repositories, the changelogs often wouldn't load. For example, providing
>> both pve-no-subscription and
can you please add some context in the commit message to record since when the
API doesn't pass this along anymore, e.g. `since commit abcdef0123 ("foo bar")
in pve-firewall [...]`
As of now it sounds a bit like your series changed that behavior, which would
be a breaking change.
as you need to sent another revision anyway, for the subject please do
s/^docs/api schema/
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Am 26/01/2023 um 16:13 schrieb DERUMIER, Alexandre:
> It could be great to update the proxmox repo.
>
> (It have an important fix on pglogs bug that I have triggered multiple
> times)
FYI, 16.2.11-pve1 is now available on our pacific test repository:
Am 27/01/2023 um 09:13 schrieb Fiona Ebner:
> Affects Proxmox VE, when the discard disk setting is used for a
> VirtIO disk.
>
> Upstream bug report:
> https://gitlab.com/qemu-project/qemu/-/issues/1404
>
> Signed-off-by: Fiona Ebner
> ---
> ...-zeroes-with-BDRV_REQ_REGISTERED_BUF.patch | 36
Am 26/01/2023 um 16:13 schrieb DERUMIER, Alexandre:
> Hi,
>
> ceph 16.2.11 has been finally released after 6 months.
>
> (Their CI cluster was broken since 3 months, rhev + glusterfs ^_^)
yeah I also followed the 16.2.x release story relatively closesly.. x)
>
> It could be great to update
Am 25/01/2023 um 09:38 schrieb Wolfgang Bumiller:
> applied
>
> Though the whole commit message is actually the change log to v1 of the
> patch and should not have mentioned the `split_list` part at all, only
> what it actually does and the change list should go below the `---`,
> please separate
Am 23/01/2023 um 10:14 schrieb Fiona Ebner:
> by simply doing a ping with the expected port as a fallback when the
> rpcinfo command fails.
>
> The timeout was chosen to be 2 seconds, because that's what the
> existing callers of tcp_ping() in the iSCSI and GlusterFS plugins use.
>
>
Am 23/01/2023 um 10:46 schrieb Fiona Ebner:
> In the web UI, this was fixed years ago by pve-manager commit c11c4a40
> ("fix #1631: change units to binary prefix").
>
> Quickly checked with the 'query-memory-size-summary' QMP command that
> this is actually the case.
>
> Signed-off-by: Fiona
Am 23/01/2023 um 12:43 schrieb Fiona Ebner:
> which also makes it distinguishable from the other
> "qemu_savevm_state_iterate error" message.
>
> Signed-off-by: Fiona Ebner
> ---
> ...17-PVE-add-savevm-async-for-background-state-snapshots.patch | 2 +-
> 1 file changed, 1 insertion(+), 1
Am 24/01/2023 um 16:24 schrieb Thomas Lamprecht:
>> -dataIndex: 'Enabled',
>> -listeners: {
>> -beforecheckchange: () => false, // veto, we don't want to allow
>> inline change - to subtle
>> +dataindex: 'Ena
Am 23/01/2023 um 14:17 schrieb Lukas Wagner:
> From a usability view, having a checkbox that is not clickable is pretty
> misleading, especially if the visual style is exactly the same as in
> other places in the UI where the checkbox is functional.
>
> Signed-off-by: Lukas Wagner
> ---
>
1101 - 1200 of 9263 matches
Mail list logo
