Re: [pve-devel] [PATCH v2 manager] ui: backup: replication: replace non-clickable checkbox with icons

2023-01-24 Thread Thomas Lamprecht
Am 23/01/2023 um 14:17 schrieb Lukas Wagner: > From a usability view, having a checkbox that is not clickable is pretty > misleading, especially if the visual style is exactly the same as in > other places in the UI where the checkbox is functional. > > Signed-off-by: Lukas Wagner > --- >

Re: [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace non-clickable checkbox with icons

2023-01-24 Thread Thomas Lamprecht
Am 23/01/2023 um 14:17 schrieb Lukas Wagner: > From a usability view, having a checkbox that is not clickable is pretty > misleading, especially if the visual style is exactly the same as in > other places in the UI where the checkbox is functional. > > Signed-off-by: Lukas Wagner > --- >

[pve-devel] applied: [PATCH manager] ui: cluster info: fix displaying error

2023-01-24 Thread Thomas Lamprecht
Am 23/01/2023 um 14:45 schrieb Fiona Ebner: > The function to set the error mask expects the message as a string, > not the error object. > > Signed-off-by: Fiona Ebner > --- > www/manager6/dc/Cluster.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks!

[pve-devel] applied: [PATCH manager] ui: node options: make text for `wakeonlan` option a bit more descriptive

2023-01-24 Thread Thomas Lamprecht
Am 23/01/2023 um 14:59 schrieb Lukas Wagner: > If one is not familiar with the underlying configuration option, > one might think that one can enable Wake-On-Lan for a node with this > option. It was not really clear (at least without RTFM ;) ) that a > MAC address is supposed to be entered here.

Re: [pve-devel] [PATCH manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes with Yes/No text

2023-01-23 Thread Thomas Lamprecht
Am 23/01/2023 um 11:46 schrieb Lukas Wagner: > On 1/20/23 15:09, Thomas Lamprecht wrote: >>> While looking sleek, the problem with this is that from a user's >>> perspective, a checkbox generally implies that it is operable by >>> clicking on it (which we allow in ot

[pve-devel] applied: [PATCH qemu-server] Fixed spelling error

2023-01-23 Thread Thomas Lamprecht
Am 20/01/2023 um 12:14 schrieb Noel Ullreich: > fixed a small spelling and grammar error I stumbled over > > Signed-off-by: Noel Ullreich > --- > PVE/API2/Qemu.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___

Re: [pve-devel] [PATCH manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes with Yes/No text

2023-01-20 Thread Thomas Lamprecht
Am 20/01/2023 um 12:17 schrieb Lukas Wagner: > Consider this an RFC to maybe spark up a discussion about this. > > In our UI, we've been a bit inconsistent with the use of checkboxes/text > for `enabled` properties in table views. Looking through the UI, I've > found that the following UI

Re: [pve-devel] [PATCH manager 2/2] GUI: efi disk: cleanup - var to const

2023-01-20 Thread Thomas Lamprecht
Am 20/01/2023 um 12:16 schrieb Matthias Heiserer: >> >> I'm not that huge fan of applying JavaScript's const broadly to non-scalar  >> values, >> as it's only a shallow constant and immutable; so no effect on array/object  >> member. > > I quite like const, especially with `const me = this`,

Re: [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64

2023-01-20 Thread Thomas Lamprecht
Am 20/01/2023 um 13:56 schrieb Matthias Heiserer: > On 18.01.2023 15:07, Thomas Lamprecht wrote: >> for subject: s/GUI/ui/ to better match the predominantly used one. >> >> Am 17/01/2023 um 13:17 schrieb Matthias Heiserer: >>> Sets the EFI version to 2m when arch=aa

Re: [pve-devel] [RFC PATCH manager 4/5] ui: ScheduleSimulator: add rownumberer column

2023-01-20 Thread Thomas Lamprecht
Am 18/01/2023 um 15:35 schrieb Dominik Csapak: > so it's clear what the first time is, for that we have to disable > sorting, since the rownumberer will not sort with it > > Signed-off-by: Dominik Csapak > --- > not sure if it's worth losing the sorting... IMO it isn't, if we would need to

[pve-devel] applied: [PATCH manager] ui: fix search for 'Guests without Backup' window

2023-01-20 Thread Thomas Lamprecht
Am 20/01/2023 um 09:47 schrieb Lukas Wagner: > In JS, a `for (const a in <...>)` loop iterates over indices, not > over values. To iterate over values, `for (const a of <..>)` has > to be used. Furthermore, filtering by ID did not work properly, since > the property is called `vmid`, not `id`.

[pve-devel] applied: [PATCH manager v2] ui: storage backup view: Update remove button on protection change

2023-01-19 Thread Thomas Lamprecht
Am 19/01/2023 um 10:56 schrieb Christoph Heiss: > Currently this works in the backup view for containers/VMs, but not in > the storage backup view. Implement that for the latter part too. > > Uses the callback functionality of the load() method of the store to > properly update the UI as soon as

Re: [pve-devel] [RFC PATCH manager 5/5] ui: ScheduleSimulator: add UTC checkbox

2023-01-19 Thread Thomas Lamprecht
Am 18/01/2023 um 15:35 schrieb Dominik Csapak: > that displays the simulated times in UTC instead of the local timezone > Only takes effect on the next click of 'Simulate' > > Signed-off-by: Dominik Csapak > --- > wanted to make it clearer that the time is the Local timezone by default, > not

[pve-devel] applied: [PATCH manager 2/5] ui: BackupView: add scrolling overflow handler for the toolbar

2023-01-19 Thread Thomas Lamprecht
Am 18/01/2023 um 15:35 schrieb Dominik Csapak: > since we already have many elements here, and in our minimal resolution > of 1280x720 we don't see all elements any more. > > reported in the forum: > https://forum.proxmox.com/threads/web-forms-extend-beyond-web-page-window-in-some-cases.120714

[pve-devel] applied: [PATCH manager 3/5] ui: ScheduleSimulator: split date and time into two columns

2023-01-19 Thread Thomas Lamprecht
Am 18/01/2023 um 15:35 schrieb Dominik Csapak: > and align the time right. This makes it easier to compare times > > Signed-off-by: Dominik Csapak > --- > www/manager6/window/ScheduleSimulator.js | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > > applied,

[pve-devel] applied: [PATCH manager 1/5] ui: reduce default size of Backup detail window

2023-01-19 Thread Thomas Lamprecht
Am 18/01/2023 um 15:35 schrieb Dominik Csapak: > on our minimal display size (1280x720), using height 700 is too large > when considering that the browser + os also need some vertical space. > > For good measure, use a maximum of 600 pixels. Since the window is > resizable anyway, users with more

[pve-devel] applied-series: [PATCH widget-toolkit/pve-manager] move node selection into combogrid

2023-01-18 Thread Thomas Lamprecht
Am 18/01/2023 um 14:12 schrieb Dominik Csapak: > proxmox-widget-toolkit: > > Dominik Csapak (2): > ComboGrid: use the grids view for the error message > ComboGrid: make height for the error configurable > > src/form/ComboGrid.js | 14 +- > 1 file changed, 9 insertions(+), 5

Re: [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64

2023-01-18 Thread Thomas Lamprecht
for subject: s/GUI/ui/ to better match the predominantly used one. Am 17/01/2023 um 13:17 schrieb Matthias Heiserer: > Sets the EFI version to 2m when arch=aarch64. > > When the VM has arch=aarch64, creating an EFI disk failed with > "Can't use an undefined value as an ARRAY reference at >

Re: [pve-devel] [PATCH manager 2/2] GUI: efi disk: cleanup - var to const

2023-01-18 Thread Thomas Lamprecht
Am 17/01/2023 um 13:17 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > www/manager6/qemu/HDEfi.js | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/www/manager6/qemu/HDEfi.js b/www/manager6/qemu/HDEfi.js > index ef3092a6..f6b7fc26 100644

Re: [pve-devel] [PATCH manager] ui: storage backup view: Update remove button on protection change

2023-01-18 Thread Thomas Lamprecht
Looks ok (but did not tested it yet), few small nits inline Am 18/01/2023 um 14:01 schrieb Christoph Heiss: > Currently this works in the backup view for containers/VMs, but not in > the storage backup view. Implement that for the latter part too. > > Uses the callback functionality of the

[pve-devel] applied: [PATCH container] fix #4460: setup: centos: create /etc/hostname if it does not exist

2023-01-17 Thread Thomas Lamprecht
Am 16/01/2023 um 17:52 schrieb Friedrich Weber: > Previously, Setup/CentOS.pm only wrote to /etc/hostname if the file Nit: note that we prefer avoiding code file names in favor of module names or more general terms like "the CentOS setup module" - if one wants to know which file got altered they

[pve-devel] applied: [PATCH docs] cluster join: mention that storage config from cluster is inherited

2023-01-16 Thread Thomas Lamprecht
Am 30/11/2022 um 15:09 schrieb Fiona Ebner: > and what to do about it. It's a rather common topic in forum threads. > > Suggested in the community forum: > https://forum.proxmox.com/threads/118492/post-513743 > > Signed-off-by: Fiona Ebner > --- > > I just added it to the existing note, but

[pve-devel] applied: [PATCH pve-network] frr: add prefix-list support

2023-01-16 Thread Thomas Lamprecht
Am 30/11/2022 um 16:18 schrieb Alexandre Derumier: > parsing of prefix-list in frr.conf.local was missing > > reported on forum: > https://forum.proxmox.com/threads/using-the-proxmox-sdn-to-manage-host-connectivity-with-bgp.118553 > > Signed-off-by: Alexandre Derumier > --- >

[pve-devel] applied: [PATCH pve-docs] fixed grammar in qm manpage

2023-01-16 Thread Thomas Lamprecht
Am 02/12/2022 um 12:52 schrieb Noel Ullreich: > Fixed two small grammar errors in the qm manpage. Rephrased a as we generate more than the man pages out of this: s/manpage/chapter/ > sentence before the fixed sentence so that it would be more legible. > > Signed-off-by: Noel Ullreich > --- >

Re: [pve-devel] [PATCH access-control v2 2/6] added acls for Shared Filesystem Directories

2023-01-16 Thread Thomas Lamprecht
Am 23/12/2022 um 14:10 schrieb Markus Frank: > Signed-off-by: Markus Frank > --- > src/PVE/AccessControl.pm | 2 ++ > src/PVE/RPCEnvironment.pm | 12 +++- > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm > index

Re: [pve-devel] [PATCH common v4 1/6] VM start timeout config parameter in backend

2023-01-16 Thread Thomas Lamprecht
for anyone wanting to pick this up: high level: it should go into pve-guest-common Am 05/01/2023 um 11:08 schrieb Daniel Tschlatscher: > This allows setting the 'startoptions' property string in the config. > For now this only implements the 'timeout' parameter but should be > rather easily

[pve-devel] applied-series: [PATCH manager v2 0/2] Ceph API update return schemas

2023-01-16 Thread Thomas Lamprecht
Am 23/12/2022 um 10:59 schrieb Aaron Lauterer: > by adding more precise return definitions. > > Patch 3/3 from the last version [0] is split into two patches. > > The first handles a few small updates while the second one is a bit > larger, adding more infos for the cluster/ceph/metadata return

[pve-devel] applied: [PATCH pve-manager] fix #4393: ui: storage backup view: make pbs-specific columns sortable

2023-01-16 Thread Thomas Lamprecht
Am 16/12/2022 um 13:45 schrieb Stefan Hanreich: > The sort order is analogous to how it behaves in the datastore content > overview in pbs. > > This means sorting in ascending order behaves as follows: > > Verify State > * failed > * none > * ok > > Encryption > * no > * yes > > For the

[pve-devel] applied: [RFC qemu-server] migration: nbd export: switch away from deprecated QMP command

2023-01-16 Thread Thomas Lamprecht
Am 02/12/2022 um 13:54 schrieb Fiona Ebner: > The 'nbd-server-add' QMP command has been deprecated since QEMU 5.2 in > favor of a more general 'block-export-add'. > > When using 'nbd-server-add', QEMU internally converts the parameters > and calls blk_exp_add() which is also used by

[pve-devel] applied: [PATCH qemu-server v4 1/2] cd rom handling: return a clearer error when there is no cd rom drive

2023-01-13 Thread Thomas Lamprecht
n that no cd rom drive is available instead. > > note that the error was cosmetic as the vm would start just fine. > > forum thread: https://forum.proxmox.com/threads/119592/ > > Signed-off-by: Stefan Sterz > --- > changes from v3 (thanks @ Thomas Lamprecht): > > * use

Re: [pve-devel] [PATCH manager] API: ceph: fix typo in permissions

2023-01-13 Thread Thomas Lamprecht
Am 13/01/2023 um 11:56 schrieb Matthias Heiserer: > With Sys.Audit being spelled wrong, this call always failed for non-root you mean? ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu] add regression fix for migration with virtio-rng device

2023-01-12 Thread Thomas Lamprecht
Am 12/01/2023 um 11:09 schrieb Fiona Ebner: > between QEMU less than 7.2 and QEMU 7.2 without the fix (both > directions are affected). > > As mentioned in the patch message, this fix itself will break > migration between QEMU 7.2 and QEMU 7.2 with the fix (in both > directions, if a virtio-rng

[pve-devel] applied: [PATCH qemu-server] migration: log error from query-migrate upon migration failure

2023-01-12 Thread Thomas Lamprecht
Am 11/01/2023 um 15:54 schrieb Fiona Ebner: > if it is present. Should give more information for some failures and > even if it's not present, that fact helps to narrow things down. > > Signed-off-by: Fiona Ebner > --- > PVE/QemuMigrate.pm | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [pve-devel] [PATCH storage] plugin: file size info: use fallback for actual size

2023-01-11 Thread Thomas Lamprecht
Am 28/11/2022 um 16:55 schrieb Fiona Ebner: > The actual-size property is an optional property in the QAPI > definition for ImageInfo. If it's not set, simply use the information > from stat() as a fallback. This is essentially the same > raw_get_allocated_file_size() in QEMU does anyways. > >

[pve-devel] applied: [PATCH storage] fix #4390: rbd: snapshot delete: avoid early return to fix handling TPM drive

2023-01-11 Thread Thomas Lamprecht
Am 09/12/2022 um 11:30 schrieb Fiona Ebner: > The only caller where $running can even be truthy is QemuServer.pm's > qemu_volume_snapshot_delete(). But there, a check if snapshots should > be done with QEMU is already made and the storage function is only > called if snapshots should not be done

[pve-devel] applied: [PATCH qemu-server v2] fix #4358: destroy_vm: Ignore 'suspended' lock when destroying VM

2023-01-11 Thread Thomas Lamprecht
Am 05/01/2023 um 15:51 schrieb Stefan Hanreich: > Since we can now differentiate between 'suspended' and 'suspending', > it is possible to ignore the 'suspended' lock when destroying a VM. > It shouldn't matter whether the VM is locked because of hibernation > when you want to remove it. Therefore

[pve-devel] applied: [PATCH ja.po 1/1] patch for ja.po

2023-01-11 Thread Thomas Lamprecht
Am 09/01/2023 um 12:03 schrieb ribbon: > --- ja.po.org 2023-01-09 11:25:46.32378 +0900 > +++ ja.po 2023-01-09 15:19:22.759576276 +0900 applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH qemu-server] fix #4435: devices list: avoid error for undefined value

2023-01-11 Thread Thomas Lamprecht
Am 10/01/2023 um 14:41 schrieb Fiona Ebner: > When $d->{'pci_bridge'}->{devices} is undef, @-dereferencing it will > die with: >> Can't use an undefined value as an ARRAY reference > > This can happen (at least) when the VM is in 'prelaunch' state. The > QAPI definition for '@PciBridgeInfo' also

[pve-devel] applied: [PATCH qemu] add QAPI naming exceptions in patches introducing them

2023-01-11 Thread Thomas Lamprecht
Am 10/01/2023 um 09:40 schrieb Fiona Ebner: > Avoids a patch and is required to compile when not all patches are > applied. No functional change is intended. > > Signed-off-by: Fiona Ebner > --- > .../0007-PVE-Up-qmp-add-get_link_status.patch | 18 +++--- >

[pve-devel] applied: [PATCH qemu] cherry-pick stable fixes for 7.2

2023-01-11 Thread Thomas Lamprecht
Am 10/01/2023 um 10:34 schrieb Fiona Ebner: > Two for virtio-mem and one for vIOMMU. Both features are not yet > exposed in PVE's qemu-server, but planned to be added. > > Signed-off-by: Fiona Ebner > --- > > @Thomas: the migration optimization I mentioned off-list seems to be > just for

Bug#1027456: Fixed in 10.1

2023-01-10 Thread Thomas Lamprecht
On Tue, 10 Jan 2023 06:40:08 +0100 Matthias Klose wrote: > Version: 10.1.0-1 > > Fixed. > > As this happens with version 10.2.1-6 I'm confused about how 10.1.0-1 could contain the fix? FWIW, even though this is a GCC bug I bisected it in the Linux kernel with good=6.1.0 and bad=6.1.2 and

Bug#1027456: Fixed in 10.1

2023-01-10 Thread Thomas Lamprecht
On Tue, 10 Jan 2023 06:40:08 +0100 Matthias Klose wrote: > Version: 10.1.0-1 > > Fixed. > > As this happens with version 10.2.1-6 I'm confused about how 10.1.0-1 could contain the fix? FWIW, even though this is a GCC bug I bisected it in the Linux kernel with good=6.1.0 and bad=6.1.2 and

Re: [PVE-User] Trouble with LetsEncrypt/acme-dns in pve 7.3-4 - FIXED

2023-01-06 Thread Thomas Lamprecht
Hi! Am 03/01/2023 um 15:03 schrieb Martin Dziobek: > Ok - here is the fix: much thanks for your report and even proposing a fix, appreciated! > > in /usr/share/proxmox-acme/dns-challenge-schema.json: > > diff dns-challenge-schema.json dns-challenge-schema.json_save: fyi, using the -u and -p

Re: [pve-devel] [RFC firewall] api: Add optional parameters `since` and `until` for timestamp filter

2023-01-05 Thread Thomas Lamprecht
Am 05/01/2023 um 14:51 schrieb Fiona Ebner: >> +my($count, $lines) = >> PVE::Tools::dump_fw_logfile("/var/log/pve-firewall.log", >> +$param->{start}, $param->{limit}, undef, $param->{since}, >> $param->{until}); > Style nit: please use 1 line for each parameter if it gets too

Re: [pve-devel] [PATCH v2 storage] config: add overrides for default directory locations

2023-01-05 Thread Thomas Lamprecht
Am 02/01/2023 um 17:04 schrieb Leo Nunner: > Allowing overrides for the default directory locations seems to > integrate rather well into the existing system. Custom locations > are specified using the "dirs" parameter as a comma-separated list > of "vtype:/location" values. > > For now, the

Re: [pve-devel] [PATCH v2 storage docs] Allow overrides for default directories

2023-01-05 Thread Thomas Lamprecht
Am 05/01/2023 um 14:41 schrieb Wolfgang Bumiller: > Actually, I just realized that these are actually *relative* paths yeah that's the idea, relative paths from the storage MP. > written "as absolute" paths, and if not, the error will now actually say > that it is not an absolute path as well.

[pve-devel] applied: [PATCH manager/widget-toolkit v6] fix: #3971 Tasklog download button

2023-01-04 Thread Thomas Lamprecht
Am 04/01/2023 um 13:56 schrieb Daniel Tschlatscher: > pve-manager: > > Daniel Tschlatscher (1): > make task log downloadable in the PVE manager backend > proxmox-widget-toolkit: > > Daniel Tschlatscher (2): > Source file download call in central function > add task log download button in

Re: [pve-devel] [PATCH qemu-server] fix #4358: destroy_vm: Ignore 'suspended' lock when destroying VM

2023-01-03 Thread Thomas Lamprecht
Am 03/01/2023 um 16:52 schrieb Stefan Hanreich: > > Yes, I just (double-)checked. Both disk image and suspended state get removed. > >> >> Maybe a extra hint for such things in the web UI could be nice, but >> must not necessarily be tied to this patch (series). > > Should not be too hard to

Re: [pve-devel] [PATCH qemu-server] fix #4358: destroy_vm: Ignore 'suspended' lock when destroying VM

2023-01-03 Thread Thomas Lamprecht
Am 03/01/2023 um 15:45 schrieb Stefan Hanreich: > Since there is not really a reason why hibernated VMs shouldn't be IMO the key that this is safe is that there's now (well since quite a while) two locks so that going into suspension and being actually suspended can be differentiated via the

Re: [pve-devel] [PATCH pve-docs 1/3] Fixed inline code breaking in pdf docs

2023-01-03 Thread Thomas Lamprecht
Am 03/01/2023 um 14:31 schrieb Noel Ullreich: > Had to overwrite the `texttt` command to allow breaks in long strings > with no space. Now the line can be broken on specific chars as well. > any context/reference where you pulled this from or how you came up with it? > Signed-off-by: Noel

Re: [pve-devel] [PATCH pve-docs 2/3] Fixed the table in 3.11.8

2023-01-03 Thread Thomas Lamprecht
Am 03/01/2023 um 14:31 schrieb Noel Ullreich: > Fixed the table by manually replacing the characters latex could not > render with simpler characters. This will have to be done manually > again for any future tables of the same style for now. you don't remove the old one though...? > >

[pve-devel] applied: [PATCH widget-toolkit] parameter and return grid: allow text selection

2023-01-02 Thread Thomas Lamprecht
Am 02/01/2023 um 10:21 schrieb Aaron Lauterer: > Making it easier for people to copy & paste parameter and retrun value > names. > > Signed-off-by: Aaron Lauterer > --- > src/api-viewer/APIViewer.js | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks!

[pve-devel] applied: [PATCH zfsonlinux] fix #4440: cherry-pick patch for mountpoint=legacy on /

2023-01-02 Thread Thomas Lamprecht
Am 02/01/2023 um 15:25 schrieb Stoiko Ivanov: > As reported having set 'mountpoint=legacy' on the root dataset (for a > default install this would be 'rpool/ROOT/pve-1') for mounting through > e.g. /etc/fstab breaks booting in initramfs > > The cherry-picked patch is already applied to

[pve-devel] applied: [PATCH qemu-server v3] rollback: Only create start task with --start if VM is not running

2022-12-30 Thread Thomas Lamprecht
Am 21/12/2022 um 17:51 schrieb Stefan Hanreich: > When rolling back to the snapshot of a VM that includes RAM, the VM > gets started by the rollback task anyway, so no additional start task > is needed. Previously, when rolling back with the start parameter and > the VM snapshot included RAM, a

[pve-devel] applied: [PATCH pve-network] controllers: evpn : correctly limit the number of controllers to max 1

2022-12-30 Thread Thomas Lamprecht
Am 27/12/2022 um 08:17 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-30 Thread Thomas Lamprecht
Am 28/12/2022 um 15:18 schrieb Stefan Sterz: > maybe somewhat off-topic for the patch at hand, but it might be nice to > modularize the pve report. so that `pvereport` gives you a default set > of information, but you could also use `pvereport ha` to give you more > information specifically about

Re: [pve-devel] [PATCH manager 3/3] api: ceph: update return value definitions

2022-12-21 Thread Thomas Lamprecht
On 21/12/2022 14:30, Aaron Lauterer wrote: > to have at either a more accurate description or some description at > all. For objects returning a lot of data, for example individual Ceph > services, a full description has been omitted as I think that this would > be a bit much. > > Signed-off-by:

[pve-devel] applied: [PATCH manager 2/3] api: ceph: update index list

2022-12-21 Thread Thomas Lamprecht
On 21/12/2022 14:30, Aaron Lauterer wrote: > some items were missing and placing them in alphabetical order will make > it easier in the future > > Signed-off-by: Aaron Lauterer > --- > PVE/API2/Ceph.pm | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > applied,

[pve-devel] applied: [PATCH manager 1/3] ceph api: fix descriptions

2022-12-21 Thread Thomas Lamprecht
On 21/12/2022 14:30, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > PVE/API2/Ceph.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied-series: [PATCH v2 docs 1/2] qm: IO thread: be more precise about how QEMU handles IO

2022-12-21 Thread Thomas Lamprecht
On 20/12/2022 12:24, Fiona Ebner wrote: > Reported in the community forum[0]. > > The setting can already help with a single disk. Without the option, > there is not one IO thread as the old wording suggested, but IO is > handled in the main event loop or vCPU threads (see the kvm man page). > >

[pve-devel] applied-series: Re: [PATCH qemu 1/3] d/rules: enable slirp again

2022-12-21 Thread Thomas Lamprecht
On 20/12/2022 09:19, Fiona Ebner wrote: > Commit d03e1b3 ("update submodule and patches to 7.2.0") argued that > slirp is not explicitly supported in PVE, but that is not true. In > qemu-server, user networking is supported (via CLI/API) when no bridge > is set on a virtual NIC. So slirp needs to

Re: [pve-devel] [PATCH qemu-server v3] cd rom handling: return a clearer error when there is no cd rom drive

2022-12-19 Thread Thomas Lamprecht
On 19/12/2022 13:23, Stefan Sterz wrote: > when a vm is configured to use a physical cd rom drive but there is no > such drive a cryptic "uninitialized value" error is thrown. this is > due to `$path` not being defined in `sub > print_drive_commandline_full` in this case. warn that no cd rom drive

Re: [pve-devel] [PATCH qemu-server 09/10] tests: add virtio-mem tests

2022-12-19 Thread Thomas Lamprecht
On 16/12/2022 14:42, Fiona Ebner wrote: > It wasn't supported on QEMU 3.0  But it raises the question if we > should introduce version guards for the feature? Not sure what our > current policy is when it comes to actively-opt-in features. Especially > if it's still a technology preview. Yeah

Re: [pve-devel] [RFC qemu-server] migration: nbd export: switch away from deprecated QMP command

2022-12-16 Thread Thomas Lamprecht
On 02/12/2022 13:54, Fiona Ebner wrote: > The 'nbd-server-add' QMP command has been deprecated since QEMU 5.2 in > favor of a more general 'block-export-add'. > > When using 'nbd-server-add', QEMU internally converts the parameters > and calls blk_exp_add() which is also used by

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-16 Thread Thomas Lamprecht
On 15/12/2022 17:57, Mira Limbeck wrote: > Since some users keep their passwords in the VM/CT configs as comments > and those are most of the time unnecessary when looking through the > report, filter those. I'd rather have this optional, opt-out is fine, where the CLI gets a switch and the web

[pve-devel] applied: [PATCH access-control v2 1/2] realm: sync: allow 'none' for 'remove-vanished' option

2022-12-14 Thread Thomas Lamprecht
Am 06/12/2022 um 12:06 schrieb Dominik Csapak: > with that, the api call can now override the default option > that is set on the realm (if any) by providing 'none' > > it was not possible previously to override the realm default > when one wanted no properties to delete > > no other code

[pve-devel] applied: [RFC v2 container 1/1] print_ct_warn_log: use log_warn function from RESTEnvironment

2022-12-14 Thread Thomas Lamprecht
Am 29/10/2021 um 13:16 schrieb Fabian Ebner: > No functional change is intended. > > Signed-off-by: Fabian Ebner > --- > > No changes from v1. > > Dependency bump for pve-common is needed. > > src/PVE/LXC.pm | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > applied,

[pve-devel] applied: [PATCH manager v2 1/3] ui: realm: sync: don't use realm defaults for remove-vanished

2022-12-13 Thread Thomas Lamprecht
Am 06/12/2022 um 12:06 schrieb Dominik Csapak: > if we don't manually set it to the empty string, it will use the > realm default, which might be unexpected. this way, the sync always > does what the user saw in the sync window. > > Signed-off-by: Dominik Csapak > --- >

Re: [pve-devel] [PATCH access-control v2 2/2] add realmsync plugin for jobs and CRUD api for domainsync-jobs

2022-12-13 Thread Thomas Lamprecht
Some mostly API and slightly higher level or cosmetical comments, but also some issue with how you use the cfs domain locks at the end. Also, a patch-wide s/realmsync/realm-sync/ would be great. Am 06/12/2022 um 12:06 schrieb Dominik Csapak: > to be able to define automated jobs that sync

[pve-devel] applied: [PATCH v2 docs] storage: iscsi direct: update information about packages

2022-12-13 Thread Thomas Lamprecht
Am 12/12/2022 um 11:30 schrieb Fiona Ebner: > As reported in the community forum [0], libiscsi-bin is required. The > library package on Bullseye would be libiscsi7, but there is no real > need to mention the package explicitly, because it is a dependency of > both, libiscsi-bin and pve-qemu-kvm.

[pve-devel] applied: [PATCH storage] disk manage: pass full NVMe device path to smartctl

2022-12-13 Thread Thomas Lamprecht
Am 12/12/2022 um 13:33 schrieb Fiona Ebner: > This essentially reverts commit c9bd3d2 ("fix #1123: modify NVME > device path for SMART support"). > > The man page for smartctl states >> Use the forms "/dev/nvme[0-9]" (broadcast namespace) or >> "/dev/nvme[0-9]n[1-9]" (specific namespace 1-9) for

[pve-devel] applied-series: [PATCH v3 http-server 1/3] multipart upload: fix upload of files starting with newlines

2022-12-13 Thread Thomas Lamprecht
Am 12/12/2022 um 16:07 schrieb Matthias Heiserer: > Currently, if a file starts with a newline, it gets removed > and the uploda succeeds (provided no hash is given). > > Signed-off-by: Matthias Heiserer > --- > src/PVE/APIServer/AnyEvent.pm | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [pve-devel] [PATCH V6 pve-manager 0/2] fix #2822: add iscsi, lvm, lvmthin & zfs

2022-12-13 Thread Thomas Lamprecht
Am 21/10/2022 um 11:24 schrieb Dominik Csapak: > All in all LGTM, one small UX thing that i am not sure if we can improve > without > making it way more complicated: > > We now preselect the current node and leave the restriction out. > We then restrict when the node changes, but remove the

[pve-devel] applied: [PATCH qemu-server] cfg2cmd: factor out ovmf drives printing

2022-12-12 Thread Thomas Lamprecht
Am 02/12/2022 um 13:59 schrieb Fiona Ebner: > No functional change is intended. > > Signed-off-by: Fiona Ebner > --- > > Popped out while trying the other approach mentioned in: > https://lists.proxmox.com/pipermail/pve-devel/2022-December/055091.html > > Better viewed with >

Re: [pve-devel] [PATCH docs] storage: iscsi direct: update information about packages

2022-12-12 Thread Thomas Lamprecht
Am 12/12/2022 um 10:12 schrieb Fiona Ebner: > As reported in the community forum [0], libiscsi-bin is required. > Also, the library package on Bullseye would be libiscsi7. Just change > the mentioned version to a generic number to never be out of date. > we already depend on the current .so bump

Re: [pve-devel] [PATCH qemu-server] cfg2cmd: factor out ovmf drives printing

2022-12-06 Thread Thomas Lamprecht
Am 02/12/2022 um 13:59 schrieb Fiona Ebner: > No functional change is intended. > > Signed-off-by: Fiona Ebner > --- > > Popped out while trying the other approach mentioned in: > https://lists.proxmox.com/pipermail/pve-devel/2022-December/055091.html looks ok, having it in a separate method

[pve-devel] applied: [PATCH docs] install: update wiki link for debian bullseye guide

2022-12-06 Thread Thomas Lamprecht
Am 06/12/2022 um 14:14 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > pve-installation.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH zfsonlinux 0/3] update to 2.1.7

2022-12-06 Thread Thomas Lamprecht
Am 02/12/2022 um 17:32 schrieb Stoiko Ivanov: > ZFS 2.1.7 got released yesterday [0] > > the bulk of commits are fixes for issues discovered by static > code-analyzers - while the bugs don't seem to have been hit in the wild it > is still an improvment > > did some very superficial tests

[pve-devel] applied: [RFC v2 storage] Revert "Fix #2020: use /sys to map nvmeXnY to nvmeX"

2022-11-30 Thread Thomas Lamprecht
Am 28/11/2022 um 12:29 schrieb Fiona Ebner: > This reverts commit c3442aa5546b029a524928d10c7ecabe0024c137. > > Nowadays, relying on 'readlink /sys/block/nvmeXnY/device' won't always > lead to the correct device, as reported in the community forum[0], > where it results in '../../nvme-subsys0'

[pve-devel] applied: [PATCH qemu-server] fix #4372: fix vm_resume migration callback

2022-11-30 Thread Thomas Lamprecht
Am 29/11/2022 um 13:09 schrieb Fabian Grünbichler: > the fix for the recently introduced requirement of loading the VM config while > migrating was incomplete, since the vmlist node value could already be out of > date by the time load_config is called. > > extend the fallback behaviour even

[pve-devel] applied: [PATCH installer] create lvm: improve rounding/alignment for non-pve products

2022-11-28 Thread Thomas Lamprecht
Am 28/11/2022 um 21:41 schrieb Stoiko Ivanov: > This commit follows > 1a5fa7b0936381314f613e525255078093f7f258 > > for PMG and PBS installations. > without it installation fails due to one missing extent when creating > the root LV. > > minimally tested on a VM of mine > > Signed-off-by: Stoiko

[pve-devel] applied: [PATCH manager] fix #4370: ui: fix regression of preselecting tree element on login

2022-11-28 Thread Thomas Lamprecht
Am 28/11/2022 um 13:34 schrieb Dominik Csapak: > We want to select a tree element based on the fragment in the url after > a login. For which we must wait for the tree (ResourceStore) to load. > > Since we recently introduced the loading of '/cluster/options' to > load the overrides of tags, etc.

[pve-devel] applied: [pmg-devel] [PATCH v2 proxmox-backup 2/2] GUI: CSS: move action columns fix to widget-toolkit

2022-11-28 Thread Thomas Lamprecht
Am 07/10/2022 um 13:18 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > > Changes from v1: > remove both action column styles > > www/css/ext6-pbs.css | 12 > 1 file changed, 12 deletions(-) > > applied and bumped the versioned dependency for

Re: [pve-devel] [pbs-devel] [PATCH v2 proxmox-backup 1/2] GUI: CSS: remove redundant action column style

2022-11-27 Thread Thomas Lamprecht
Am 07/10/2022 um 13:18 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > > Changes from v1: > remove both action column styles > > www/css/ext6-pbs.css | 14 -- > 1 file changed, 14 deletions(-) > > diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css >

[pve-devel] applied: [PATCH common v4] return whole log file if limit is 0

2022-11-24 Thread Thomas Lamprecht
Am 23/11/2022 um 15:52 schrieb Daniel Tschlatscher: > The dump_logfile now returns the whole log file if the limit parameter > is set to 0. This must be done explicitely though, as in the case of > 'limit' being undefined, the default as before, 50 will be used. > > Signed-off-by: Daniel

Re: [pve-devel] last add_fdb patch fix for ovs not include in last pve-common package, user report migratiing

2022-11-24 Thread Thomas Lamprecht
Am 24/11/2022 um 16:57 schrieb DERUMIER, Alexandre: > https://forum.proxmox.com/threads/live-migration-bug-during-upgrade-to-pve-7-3.118514/ > > > the ovs fix > https://git.proxmox.com/?p=pve-common.git;a=commit;h=99fc81231e09febc4ed9bdbae8a87eca73b0dc3e > > is not in the last pve-common

[pve-devel] applied-series: [PATCH storage 1/2] test: bwlimit: fix test description

2022-11-23 Thread Thomas Lamprecht
Am 23/11/2022 um 12:40 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > test/run_bwlimit_tests.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied both patches, thanks! ___ pve-devel mailing list

Re: [pve-devel] Proxmox VE 7.3 released!

2022-11-23 Thread Thomas Lamprecht
Am 23/11/2022 um 17:32 schrieb Gilberto Ferreira via pve-devel: > Kernel 5.19? Why? It's already EOL! No it isn't EOL for neither us, nor Ubuntu (using it in their 23.04 release). We both backport stable fixes periodically. > Why not jump to 6 or remain to 5.15? 5.15 is still the default and

Re: [pve-devel] cluster resource scheduler question

2022-11-23 Thread Thomas Lamprecht
Am 23/11/2022 um 10:09 schrieb Fiona Ebner: >> I'm not sure to understand, but the video seem to say that vm is >> migrated to the least "loaded" node. > yes, the video is misleading there. The static node CPU and memory > values and the configured CPU and memory for guests will be used to >

[pve-devel] applied: [PATCH manager 1/6] api: vzdump: soften parameter permission checks

2022-11-21 Thread Thomas Lamprecht
anything new. > > Suggested-by: Thomas Lamprecht > Signed-off-by: Fiona Ebner > --- > PVE/API2/Backup.pm | 15 ++- > PVE/API2/VZDump.pm | 25 ++--- > 2 files changed, 28 insertions(+), 12 deletions(-) > > almost forgot: as talked of

[pve-devel] applied: [PATCH manager] ui: qemu disk: honor iothread setting from config

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 15:39 schrieb Dominik Csapak: > to have a iothread on by default in the wizard and on disk add, we > added a 'bind' for the value here. This also changes the value > for existing vm disks, and if one does not notice, modifies it > away again (since we don't have the controller

[pve-devel] applied: [PATCH qemu-server 1/2] vm_resume: fix nocheck/migrate handling

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 13:16 schrieb Fabian Grünbichler: > it's not deterministic whether the rename/move of the VM config > triggered on the source side of a migration is already visible on the > target side when vm_resume is executed. check the vmlist for the node > where the config is currently

[pve-devel] applied: [PATCH widget-toolkit 1/2] css: don't make full tags inline-block in the tree

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 08:53 schrieb Dominik Csapak: > when showing full tags in the tree as inline-block, the height is increased, > leading to unwanted 'wobble' when tags are added/removed > > Signed-off-by: Dominik Csapak > --- > src/css/ext6-pmx.css | 5 + > 1 file changed, 5 insertions(+) >

[pve-devel] applied: [PATCH docs 1/2] ha: crs: fix typo

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 09:31 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > ha-manager.adoc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied both patches, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH i18n] update german translation

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 11:57 schrieb Stefan Sterz: > Signed-off-by: Stefan Sterz > --- > thanks @ Daniel Tschlatscher and Dominik Csapak for the corrections! > > de.po | 28 > 1 file changed, 12 insertions(+), 16 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH pve-network] network: add|del_fdb: fix learning check

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 10:54 schrieb Alexandre Derumier: > ovs port don't have sysfs path > "/sys/class/net/$iface/brport/learning" > > We need to check if the value is undef too > > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [pve-devel] [PATCH manager] ui: fix minor typo in tag style gui

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 11:10 schrieb Stefan Sterz: > Signed-off-by: Stefan Sterz > --- > www/manager6/Utils.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js > index df2f9631..4dd3cb93 100644 > --- a/www/manager6/Utils.js > +++

[pve-devel] applied: [PATCH i18n] update german translation

2022-11-21 Thread Thomas Lamprecht
Am 21/11/2022 um 10:49 schrieb Stefan Sterz: > Signed-off-by: Stefan Sterz > --- > de.po | 185 +++--- > 1 file changed, 72 insertions(+), 113 deletions(-) > > applied, thanks! (sending a follow up for Daniel's comments may be simpler here

[pve-devel] applied: [PATCH i18n] Arabic translation update

2022-11-21 Thread Thomas Lamprecht
Am 18/11/2022 um 11:30 schrieb Moayad Almalat: > Signed-off-by: Moayad Almalat > --- > ar.po | 865 +++--- > 1 file changed, 337 insertions(+), 528 deletions(-) > > applied, thanks! ___ pve-devel

[pve-devel] applied: [PATCH docs] ha: crs: remove outdated comment about restarting service

2022-11-20 Thread Thomas Lamprecht
Am 21/11/2022 um 08:21 schrieb Fiona Ebner: > Commit 086f707 ("manager: update crs scheduling mode once per round") > in pve-ha-manager made it obsolete. Mention that a change will be > effective with the next round instead. > > Signed-off-by: Fiona Ebner > --- > ha-manager.adoc | 8 ++-- >

<    8   9   10   11   12   13   14   15   16   17   >