[pve-devel] applied: [PATCH stable-7 qemu] fix #2258: select correct device when removing drive snapshot via QEMU

2024-03-22 Thread Thomas Lamprecht
On 21/03/2024 13:29, Maximiliano Sandoval wrote: > The QMP command needs to be issued for the device where the disk is > currently attached, not for the device where the disk was attached at > the time the snapshot was taken. > > Fixes the following scenario with a disk image for which >

Re: [pve-devel] release a new pve-network package ? (evpn fix)

2024-03-22 Thread Thomas Lamprecht
Hi! On 21/03/2024 09:13, DERUMIER, Alexandre wrote: > a critical bug in evpn with multiple nodes is fixed in git, > https://git.proxmox.com/?p=pve-network.git;a=commit;h=e614da43f13e3c61f9b78ee9984364495eff91b6 > but package is still not released > > I see a lot of user bug report since 4

Re: [pve-devel] [PATCH manager] ui: storage: esxi: check 'skip certificate verification' by default

2024-03-22 Thread Thomas Lamprecht
On 22/03/2024 08:29, Dominik Csapak wrote: > On 3/21/24 18:07, Thomas Lamprecht wrote: >> On 20/03/2024 16:39, Dominik Csapak wrote: >>> needing one less step when adding the storage, assuming most esxi >>> certificates are self-signed. >> >> Well this mak

Re: [pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface

2024-03-21 Thread Thomas Lamprecht
On 05/03/2024 13:54, Christian Ebner wrote: > Allows to optionally configure a local interface name to which to > bind to when sending a wake on lan packet to wake a remote node. > > Default behaviour remains to send the packet via the interface for > the default gateway. > > Signed-off-by:

[pve-devel] applied: [PATCH v2 pve-manager 1/2] fix #5198: ceph: mon: fix mon existence check in mon removal assertion

2024-03-21 Thread Thomas Lamprecht
Am 14/03/2024 um 11:19 schrieb Max Carrara: > The Ceph monitor removal assertion contains a condition that checks > whether the given mon ID actually exists and thus may be removed. > > The first part of the condition checks whether the hash returned by > `get_services_info` [0] contains the key

Re: [pve-devel] [PATCH manager] ui: storage: esxi: check 'skip certificate verification' by default

2024-03-21 Thread Thomas Lamprecht
On 20/03/2024 16:39, Dominik Csapak wrote: > needing one less step when adding the storage, assuming most esxi > certificates are self-signed. Well this makes it insecure by default though? Which is not something I'd just not mention in such a commit message... As that was the original reason I

[pve-devel] applied: [PATCH manager] ui: agentipview: make text in grid selectable

2024-03-21 Thread Thomas Lamprecht
On 21/03/2024 10:25, Aaron Lauterer wrote: > This makes it possible to select any of the IP addresses listed in the > full view window to copy & paste it. > > Signed-off-by: Aaron Lauterer > --- > Becaue @Folke made a remark that this was a nuisance ;) > > www/manager6/qemu/AgentIPView.js | 3

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-21 Thread Thomas Lamprecht
(missed reply-all, so resending) On 20/03/2024 10:30, Fiona Ebner wrote: > Am 20.03.24 um 09:56 schrieb Aaron Lauterer: >> Signed-off-by: Aaron Lauterer >> --- >> pve-system-requirements.adoc | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/pve-system-requirements.adoc

[pve-devel] applied: [PATCH storage/manager] guest import improvements

2024-03-19 Thread Thomas Lamprecht
On 19/03/2024 14:00, Dominik Csapak wrote: > some sensible improvements for the guest import > > pve-storage: > > Dominik Csapak (2): > esxi: add warning for losing efi state > esxi: only add scsihw if it's defined > > src/PVE/Storage/ESXiPlugin.pm | 3 ++- > 1 file changed, 2

[pve-devel] applied: [PATCH manager] fix #5293: ceph status: fix division-by-zero when calculating usage

2024-03-19 Thread Thomas Lamprecht
On 12/03/2024 10:13, Christoph Heiss wrote: > Fixes #5293 [0]. This happens when no OSDs are created yet and thus the > total space is 0, which leads to a division-by-zero. > > Add a simple check if the total space is greater than 0. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5293 > >

[pve-devel] applied: [PATCH storage 2/2] esxi: only add scsihw if it's defined

2024-03-19 Thread Thomas Lamprecht
On 19/03/2024 14:00, Dominik Csapak wrote: > otherwise we get `scsihw: null` from the api, which is not a valid > value, so just omit it. > > Signed-off-by: Dominik Csapak > --- > src/PVE/Storage/ESXiPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks!

[pve-devel] applied: [PATCH storage 1/2] esxi: add warning for losing efi state

2024-03-19 Thread Thomas Lamprecht
On 19/03/2024 14:00, Dominik Csapak wrote: > we cannot import the state of the efivars (e.g. boot order) > so add a warning for that > > Signed-off-by: Dominik Csapak > --- > src/PVE/Storage/ESXiPlugin.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! but I squashed in adding

[pve-devel] applied: [PATCH widget-toolkit v2] utils: API2Request: defer masking after layout

2024-03-19 Thread Thomas Lamprecht
On 19/03/2024 09:51, Dominik Csapak wrote: > since recently (not sure when exactly), the 'load()' method of the edit > window did not correctly mask the window anymore > > the reason seems to be that the API2Request tries to mask the component > before it's rendered, and that did never work

Re: [pve-devel] [RFC PATCH widget-toolkit] utils: API2Request: defer masking after layout

2024-03-19 Thread Thomas Lamprecht
ation, so fine by me. On 19/03/2024 08:44, Dominik Csapak wrote: > On 3/18/24 16:50, Thomas Lamprecht wrote: >> On 18/03/2024 14:44, Dominik Csapak wrote: >>> the masking if this marker is still there. (thankfully javascript is >>> single threaded so this should not

Re: [pve-devel] [PATCH installer] unconfigured: move terminal size setting before starting debug shell

2024-03-18 Thread Thomas Lamprecht
On 12/03/2024 12:59, Christoph Heiss wrote: > Otherwise, when using the serial debug shell, the console size will be > 0x0. This in turn breaks the TUI installer, as it cannot detect the size > properly. That's ok, but... > > It also adjust the size to the proper 80x24 instead of 80x25, as >

Re: [pve-devel] [RFC PATCH widget-toolkit] utils: API2Request: defer masking after layout

2024-03-18 Thread Thomas Lamprecht
On 18/03/2024 14:44, Dominik Csapak wrote: > since some time (not sure when exactly), the 'load()' method of the edit > window did not correctly mask the window anymore > > the reason seems to be that the API2Request tries to mask the component > before it's rendered, and that did never work

[pve-devel] applied: [PATCH v2 qemu-server] cpu config: die on hotplug of non x86_64 CPUs

2024-03-14 Thread Thomas Lamprecht
Am 11/03/2024 um 11:13 schrieb Filip Schauer: > When attempting a CPU hotplug on an architecture other than x86_64, die > with a clean error instead of attempting a hotplug with a known > non-working device command line. Also move the corresponding FIXME up to > the error. > > Signed-off-by:

[pve-devel] applied: [PATCH qemu-server] disk import: warn when fallback is used instead of requested format

2024-03-14 Thread Thomas Lamprecht
Am 11/03/2024 um 10:46 schrieb Fiona Ebner: > Might avoid some confusion. Reported in the community forum: > https://forum.proxmox.com/threads/142988/ > > Signed-off-by: Fiona Ebner > --- > PVE/QemuServer/ImportDisk.pm | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks!

[pve-devel] applied-series: [PATCH qemu 1/2] patch cleanup: squash backup dump driver change into patch introducing the driver

2024-03-12 Thread Thomas Lamprecht
Am 09/01/2024 um 15:09 schrieb Fiona Ebner: > Makes it simpler and shorter. Still results in the same code after > applying both patches in question. > > Signed-off-by: Fiona Ebner > --- > ...-Backup-add-backup-dump-block-driver.patch | 22 ++--- > ...ckup-Proxmox-backup-patches-for-QEMU.patch

[pve-devel] applied: [PATCH qemu] fix patch for accepting NULL qiov when padding

2024-03-12 Thread Thomas Lamprecht
Am 12/03/2024 um 09:47 schrieb Fiona Ebner: > All callers of the function pass an address, so dereferencing once > before checking for NULL is required. It's also necessary to update > bytes and offset nevertheless, so the request will actually be aligned > later and not trigger an assertion

[pve-devel] partially-applied-series: [PATCH v4 ceph master, ceph quincy-stable-8, pve-storage, pve-manager 0/16] Fix #4759: Configure Permissions for ceph-crash.service

2024-03-11 Thread Thomas Lamprecht
Am 05/03/2024 um 16:07 schrieb Max Carrara: > ceph (master): > > Max Carrara (2): > debian: add patch to fix ceph crash dir permissions in postinst hook > patches: add patch that reorders clients used by ceph-crash > > ...ly-adjust-permissions-of-var-lib-cep.patch | 54 +++ >

[pve-devel] applied-series: [PATCH zfsonlinux v2 0/2] update ZFS to 2.2.3 and include a fix for udev-links for partitions

2024-03-11 Thread Thomas Lamprecht
Am 06/03/2024 um 14:24 schrieb Stoiko Ivanov: > changes from v1: > * add a fix for #5288 after Fiona managed to reproduce it and we saw it > was a known issue addressed by Fabian with a pull-request upstream > * add a bit more detail to the submodule-update commit-message > > minimally tested

[pve-devel] applied: [RFC kernel] cherry-pick scheduler fix to avoid temporary VM freezes on NUMA hosts

2024-03-11 Thread Thomas Lamprecht
Am 17/01/2024 um 15:45 schrieb Friedrich Weber: > Users have been reporting [1] that VMs occasionally become > unresponsive with high CPU usage for some time (varying between ~1 and > more than 60 seconds). After that time, the guests come back and > continue running. Windows VMs seem most

[pve-devel] applied-series: [PATCH-SERIES qemu-server] small improvements in QMP client module

2024-03-08 Thread Thomas Lamprecht
Am 09/02/2024 um 13:14 schrieb Fiona Ebner: > First patch is the only change in behavior, rest is cleanups. > > Fiona Ebner (4): > QMP client: increase default timeout for drive-mirror to 10 minutes > QMP client: remove unnecessary question mark from comment > QMP client: add missing use

Re: [pve-devel] [PATCH qemu-server 5/5] cpu config: die on hotplug of non x86_64 CPUs

2024-03-08 Thread Thomas Lamprecht
Am 21/02/2024 um 15:33 schrieb Filip Schauer: > When attempting a CPU hotplug on an architecture other than x86_64, die > with a clean error instead of attempting a hotplug with a known > non-working device command line. Also move the corresponding FIXME up to > the error. > > Signed-off-by:

[pve-devel] partially-applied-series: [PATCH-SERIES v8 qemu-server, common] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS

2024-03-08 Thread Thomas Lamprecht
Am 21/02/2024 um 15:33 schrieb Filip Schauer: > This patch series prevents starting a 32-bit VM using a 64-bit OVMF BIOS > and makes the default value for 'kvm' during CPU hotplug consistent with > the rest of the code. This is a breaking change for VMs with a different > CPU architecture running

[pve-devel] applied: [PATCH qemu-server] mediated devices: fix race condition in vm reboot

2024-03-08 Thread Thomas Lamprecht
Am 07/03/2024 um 10:33 schrieb Dominik Csapak: > when triggering a vm reboot from the host (via cli/api), the reboot code > is called under a guest lock, which creates a reboot request, shuts down > the vm and calls the regular cleanup code (which includes the mdev > cleanup). > > in parallel the

[pve-devel] applied: [PATCH qemu-server v2 1/1] fix 1734: clone VM: if deactivation fails demote error to warning

2024-03-08 Thread Thomas Lamprecht
Am 06/03/2024 um 15:08 schrieb Hannes Duerr: > When a template with disks on LVM is cloned to another node, the volumes > are first activated, then cloned and deactivated again after cloning. > > However, if clones of this template are now created in parallel to other > nodes, it can happen that

[pve-devel] applied: [PATCH widget-toolkit] certificates: don't display name if there is no name

2024-03-07 Thread Thomas Lamprecht
Am 18/01/2024 um 15:14 schrieb Maximiliano Sandoval: > The default certificate does not have a name. > > Reported-by: Dietmar Maurer > Signed-off-by: Maximiliano Sandoval > --- > src/panel/Certificates.js | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git

[pve-devel] applied: [PATCH docs 3/9] local-btrfs: unify casing for btrfs

2024-03-06 Thread Thomas Lamprecht
Am 04/03/2024 um 14:22 schrieb Christoph Heiss: > It's mostly spelled BTRFS anyway in our documentation (and also the > official casing AFAICS), so align a few instances where it spelled > lowercase. official spelling is really not consistent and includes at least btrfs, BTRFS and Btrfs – but

[pve-devel] applied: [PATCH docs 4/9] getting-help: forum: align wording with pmg-docs

2024-03-06 Thread Thomas Lamprecht
Am 04/03/2024 um 14:22 schrieb Christoph Heiss: > This paragraph as phrased in pmg-docs sounds better & reads easier, so > apply it here too. > > Signed-off-by: Christoph Heiss > --- > getting-help.adoc | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH docs 2/9] asciidoc: introduce `pricing-url` variable, much like pmg-docs

2024-03-06 Thread Thomas Lamprecht
Am 04/03/2024 um 14:22 schrieb Christoph Heiss: > Seems like a pretty sensible thing to do here too. > > Signed-off-by: Christoph Heiss > --- > asciidoc/asciidoc-pve.conf | 1 + > getting-help.adoc | 2 +- > pve-package-repos.adoc | 2 +- > 3 files changed, 3 insertions(+), 2

[pve-devel] applied: [PATCH docs 1/9] gitignore: add package build outputs

2024-03-06 Thread Thomas Lamprecht
Am 04/03/2024 um 14:22 schrieb Christoph Heiss: > .. much like it many other repos. > > Signed-off-by: Christoph Heiss > --- > .gitignore | 3 +++ > 1 file changed, 3 insertions(+) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH docs] storage: fix zfs over iscsi links

2024-03-06 Thread Thomas Lamprecht
Am 01/03/2024 um 09:21 schrieb Dominik Csapak: > The `_ZFS_over_iSCSI` wiki page is redirected to the legacy page > (for historical reasons), but we want to link to the reference docs > instead. > > for the wiki add the legacy link in a `see also` section, so users can > still reach that page

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-03-05 Thread Thomas Lamprecht
Am 23/02/2024 um 10:24 schrieb Roland Kammerer: > This passes the well known $scfg to parse_volname and bumps the API > versions accordingly. This allows plugins to access their configuration > if necessary. We discussed this another time here and effectively it can be fine, while the need for it

[pve-devel] applied: [PATCH pve-network] fix #5275: remove priority field from powerdns

2024-03-04 Thread Thomas Lamprecht
Am 04/03/2024 um 15:11 schrieb Stefan Hanreich: > Since v3.4.2 the priority field has been removed and since v4.9 they > are actively rejected by PowerDNS. Stop sending this field in order to > make the PowerDNS plugin work with versions >= 4.9 again. [1] > > [1]

[pve-devel] applied: [PATCH dab-pve-appliances] fix #4858: install libsasl2-modules for pmg

2024-03-04 Thread Thomas Lamprecht
Am 01/03/2024 um 17:41 schrieb Stoiko Ivanov: > the issue was already resolved for installations from ISO (short time > after PMG 8.0 was released), but I forgot to adapt the > container-template. > > Signed-off-by: Stoiko Ivanov > --- > quickly tested by building a template and checking dpkg -l

[pve-devel] applied: [PATCH dab-pve-appliances] pmg: update to 8.1

2024-03-01 Thread Thomas Lamprecht
Am 29/02/2024 um 12:40 schrieb Stoiko Ivanov: > Signed-off-by: Stoiko Ivanov > --- > tested with the packages from our internal repository yesterday evening > all looked ok. > > debian-12-bookworm-pmg-8-64/dab.conf | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > applied,

Re: [pve-devel] [PATCH ksm-control-daemon] ksmtuned: fix large number processing

2024-02-28 Thread Thomas Lamprecht
Hi, Am 28/02/2024 um 23:47 schrieb Roland: > any reason why this did not get a response ?  (i do not see rejection of > this  ,nor did it appear in > https://git.proxmox.com/?p=ksm-control-daemon.git;a=summary ) No reason, but even if this looks pretty straight forward, positive feedback would

[pve-devel] applied-series: fix #5254: add separate Sys.AccessNetwork privilege

2024-02-28 Thread Thomas Lamprecht
Am 19/02/2024 um 18:14 schrieb Thomas Lamprecht: > Adds a new Sys.AccessNetwork privilege that can be used to guard API > endpoints that can do outgoing network requests with (some) user control > over said requests, like e.g. the "download URL to storage" one. > > ## B

Re: [pve-devel] [PATCH v2 access-control] fix #5136: ldap: Decode non-ASCII characters in attributes

2024-02-28 Thread Thomas Lamprecht
Am 09/01/2024 um 14:35 schrieb Filip Schauer: > UTF8 decode non-ASCII characters when syncing user attributes, since > those will be encoded later on. Without this fix the attributes were > encoded twice, resulting in cases such as 'ü' turning into 'ü'. > > Signed-off-by: Filip Schauer > --- >

[pve-devel] applied: [PATCH manager] appliance index: fix precedence in size check for log rotation

2024-02-28 Thread Thomas Lamprecht
Am 28/02/2024 um 13:07 schrieb Fiona Ebner: > In Perl, > takes precedence over ||, see perldoc perlop, so currently > the check will trigger with any size. > > Fixes: 805cae93 ("appliance index: rotate update log if bigger than 256 KiB") > Signed-off-by: Fiona Ebner > --- > PVE/APLInfo.pm | 2

[pve-devel] applied: [PATCH widget-toolkit v4 11/18] utils: add extendable, translatable notifiction event descriptions

2024-02-28 Thread Thomas Lamprecht
Am 28/02/2024 um 11:00 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > src/Utils.js | 31 +++ > 1 file changed, 31 insertions(+) > > applied, with adding to the commit message that this is oriented on the existing task description add/override mechanism,

[pve-devel] applied: [PATCH widget-toolkit v4 10/18] combogrid: add 'showClearTrigger' config

2024-02-28 Thread Thomas Lamprecht
Am 28/02/2024 um 11:00 schrieb Lukas Wagner: > This allows one configure the clear trigger to be shown, even if > 'allowBlank' is set false. This can be useful if one has a > non-editable combogrid where the value is set to something not > present in the store. Example: Match rule editing, one

[pve-devel] applied: [PATCH proxmox-i18n] update Italian translations

2024-02-28 Thread Thomas Lamprecht
Am 27/02/2024 um 18:12 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > it.po | 1028 - > 1 file changed, 351 insertions(+), 677 deletions(-) > > applied, thanks! ___

Re: [pve-devel] [PATCH v2 firewall 6/6] simulator: use new bridge naming scheme

2024-02-28 Thread Thomas Lamprecht
Am 27/02/2024 um 13:35 schrieb Stefan Hanreich: > On Mon, Feb 26, 2024 at 04:36:59PM +0100, Thomas Lamprecht wrote: >> Am 26/02/2024 um 11:51 schrieb DERUMIER, Alexandre via pve-devel: >>> hi,I think you should limit to 8 characters like for sdn vnet,  >>> >>&

[pve-devel] applied: [PATCH proxmox-i18n] ja: Improve translation

2024-02-28 Thread Thomas Lamprecht
Am 24/01/2024 um 10:36 schrieb ribbon: > On Wed, Jan 24, 2024 at 04:13:47PM +0900, ribbon wrote: >> I have reviewed the whole Japanese translation. > > Attachment file deleted? Yes, the list never allowed attachements to avoid bloating up the mailing list ize and for security reasons. I

[pve-devel] applied: [PATCH installer] install: zfs: fix setting compression to 'off'

2024-02-27 Thread Thomas Lamprecht
Am 27/02/2024 um 10:17 schrieb Christoph Heiss: > The default for the `compression` property in ZFS got changed ~2 years > ago by > > 56fa4aa96 ("Default to ON for compression") [0] > > Support for setting this option originally got introduced into the > installer in 2016 by > >

[pve-devel] applied: [PATCH proxmox-i18n] es: update translations

2024-02-27 Thread Thomas Lamprecht
Am 27/02/2024 um 15:44 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > es.po | 36 ++-- > 1 file changed, 14 insertions(+), 22 deletions(-) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH installer] sys: command: wait for process exit with sub-second granularity

2024-02-27 Thread Thomas Lamprecht
Am 26/02/2024 um 17:50 schrieb Christoph Heiss: > Using full seconds as a granularity for sleeping between waitpid()'s is > way too much and unnecessarily slows down the installation a lot. Most > processes take a few moments after closing their stdin/stdout to > actually exit fully, which means

[pve-devel] applied: [pmg-devel] [PATCH widget-toolkit] datetimefield: fix changing date to end of month from short months

2024-02-27 Thread Thomas Lamprecht
Am 27/02/2024 um 14:23 schrieb Dominik Csapak: > When selecting a new date, we get a date object from the currently > selected date before the change. If that month has less days than what > was selected for the new month, `setDate` will wrap that to the > following month since the old month is

Re: [pve-devel] [PATCH v2 firewall 6/6] simulator: use new bridge naming scheme

2024-02-26 Thread Thomas Lamprecht
Am 26/02/2024 um 11:51 schrieb DERUMIER, Alexandre via pve-devel: > hi,I think you should limit to 8 characters like for sdn vnet,  > > as we need to space to  vlan tag for example (vmbrY.), or other sdn > construct. alternatively just show a hint in the UI if longer than 8 characters and,

[pve-devel] applied: [PATCH 1/2] run command: avoid using 1 as special value

2024-02-26 Thread Thomas Lamprecht
from log subroutine") Signed-off-by: Thomas Lamprecht --- Proxmox/Sys/Command.pm | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Proxmox/Sys/Command.pm b/Proxmox/Sys/Command.pm index cb5fe76..ac505c4 100644 --- a/Proxmox/Sys/Command.pm +++ b/Proxmox/Sys/

[pve-devel] applied: [PATCH 2/2] run command: use explicit return undef in closures on call sites

2024-02-26 Thread Thomas Lamprecht
To avoid a misinterpretation of the auto-return value: > In the absence of an explicit return, a subroutine, eval, or do FILE > automatically returns the value of the last expression evaluated. -- https://perldoc.perl.org/functions/return Signed-off-by: Thomas Lamprecht --- Proxmox/Inst

[pve-devel] applied-series: [PATCH installer 0/6] switch low-level installer protocol to json

2024-02-26 Thread Thomas Lamprecht
Am 06/12/2023 um 12:34 schrieb Christoph Heiss: > This switches the stdio-protocol for the low-level installer from > simple, line-based messages to JSON. > > This solves a number of problems, most prominently that messages can now > contain multiline text (or for that matter, any kind of data),

Re: [pve-devel] [PATCH installer 3/6] tui, ui: switch over to JSON-based protocol

2024-02-24 Thread Thomas Lamprecht
Am 06/12/2023 um 12:34 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > Proxmox/UI/StdIO.pm | 41 -- > .../src/views/install_progress.rs | 117 -- > 2 files changed, 83 insertions(+), 75 deletions(-) > > diff --git

[pve-devel] applied-series: [PATCH installer 0/5] proxinstall, tui: improve hostname/FQDN validation

2024-02-23 Thread Thomas Lamprecht
Am 15/02/2024 um 13:39 schrieb Christoph Heiss: > This series improves various aspects regarding FQDN handling and > validation across both the GUI and TUI installer. > > It (partially) addresses issue #5230 [0] in patch #5, by fixing the > regex through which we validate FQDNs in the GUI

Re: [pve-devel] [PATCH installer 5/5] fix #5230: sys: net: properly escape FQDN regex

2024-02-23 Thread Thomas Lamprecht
Am 15/02/2024 um 13:39 schrieb Christoph Heiss: > Due to interpolation, the \. sequence must be double-escaped. > Previously, this would result in a non-escaped dot, thus matching much > more liberally than it should. > OK, but... > diff --git a/proxmox-installer-common/src/utils.rs >

Re: [pve-devel] [PATCH installer 2/5] common: fqdn: implement case-insensitive comparison as per RFC 952

2024-02-23 Thread Thomas Lamprecht
Am 15/02/2024 um 13:39 schrieb Christoph Heiss: > +impl PartialEq for Fqdn { > +fn eq(, other: ) -> bool { > +// Case-insensitive comparison, as per RFC 952 "ASSUMPTIONS", > +// RFC 1035 sec. 2.3.3. "Character Case" and RFC 4343 as a whole > +let a = self > +

[pve-devel] applied-esries: [PATCH installer v2 0/6] fix #4872: properly timeout `traceroute` command in country detection

2024-02-23 Thread Thomas Lamprecht
Am 13/02/2024 um 16:13 schrieb Christoph Heiss: > For all the details, see patch #6. > > TL;DR: SIGALRM does not interrupt line reading using <>, causing the > installer to hang on country detection. Fix it by using > Proxmox::Sys::Command::run_command(), which properly interacts with > SIGALRM.

Re: [pve-devel] [PATCH manager v3 04/19] ui: dc: backup: show 'Job ID' column

2024-02-23 Thread Thomas Lamprecht
Am 20/02/2024 um 17:26 schrieb Thomas Lamprecht: > btw. are there any dependency bumps we should consider? > I.e., between the already bumped rust parts and e.g. manager, or between > widget-toolkit and manager? Just to be sure, as I saw none of such > requirements listed in the

[pve-devel] applied: [PATCH installer v2 0/7] gui: use gtk grids when possible

2024-02-23 Thread Thomas Lamprecht
Am 21/11/2023 um 16:10 schrieb Maximiliano Sandoval: > We replace the use of nested boxes with grids when possible to ensure correct > margins and alignment of widgets. > > At the end we also remove trailing spaces and colons from labels preceding an > input widget, e.g. we replace `DNS Server: `

Re: [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 0/2]

2024-02-22 Thread Thomas Lamprecht
Am 22/02/2024 um 09:00 schrieb DERUMIER, Alexandre: >>> It might make sense to check for any possible conflicts with the SDN >>> config (running & staged). > > Technically, ifupdown2 will try to merge config options, if the > interface is defined in both /etc/network/interfaces && >

[pve-devel] applied: [PATCH qemu] add patch to fix deadlock with VirtIO block and iothread during QMP stop

2024-02-21 Thread Thomas Lamprecht
Am 21/02/2024 um 14:01 schrieb Fiona Ebner: > Backported from commit bfa36802d1 ("virtio-blk: avoid using ioeventfd > state in irqfd conditional") because the rework/rename dataplane -> > ioeventfd didn't happen yet. > > Reported in the community forum [0] and reproduced doing a backup loop > to

Re: [pve-devel] [PATCH manager v3 04/19] ui: dc: backup: show 'Job ID' column

2024-02-20 Thread Thomas Lamprecht
Am 20/02/2024 um 16:38 schrieb Lukas Wagner: > On 2/20/24 16:23, Thomas Lamprecht wrote: >> I prefer just showing the ID in the advanced section of the General tab >> inside the edit window instead, like your next patch does. >> >> As I'd slightly prefer to avoid showin

Re: [pve-devel] [PATCH manager v3 04/19] ui: dc: backup: show 'Job ID' column

2024-02-20 Thread Thomas Lamprecht
Am 16/02/2024 um 10:15 schrieb Lukas Wagner: > This is useful for creating matchers based on the 'backup-job' > metadata field. > > Signed-off-by: Lukas Wagner > --- > www/manager6/dc/Backup.js | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/www/manager6/dc/Backup.js

[pve-devel] applied: [PATCH docs] vzdump: remove usage examples involving 'notification-{target, policy}'

2024-02-20 Thread Thomas Lamprecht
Am 14/02/2024 um 10:07 schrieb Lukas Wagner: > Also clarify in one example that using `--mailto` will bypass the > notification system (at least from the user's perspective). > > Signed-off-by: Lukas Wagner > --- > vzdump.adoc | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) >

[pve-devel] applied: [PATCH docs 2/2] partially fix #5139: document qnetd port requirement

2024-02-20 Thread Thomas Lamprecht
Am 21/12/2023 um 10:29 schrieb Fabian Grünbichler: > we could also add a check somewhere in pve-cluster for this. > > Signed-off-by: Fabian Grünbichler > --- > pvecm.adoc | 3 +++ > 1 file changed, 3 insertions(+) > > applied, with Fiona's proposed changes squashed in as they made sense to

[pve-devel] applied: [PATCH docs 1/2] fix #5140: qdevice SSH access documentation

2024-02-20 Thread Thomas Lamprecht
Am 21/12/2023 um 10:29 schrieb Fabian Grünbichler: > rephrase in order to not make it seem like password-based access is required. > > Signed-off-by: Fabian Grünbichler > --- > pvecm.adoc | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > applied, thanks!

[pve-devel] applied-series: [PATCH docs v2 0/5] installation and system improvements

2024-02-20 Thread Thomas Lamprecht
Am 25/01/2024 um 12:06 schrieb Christoph Heiss: > This mainly updates the installation section, to bring it up-to-date > with the latest available installer ISO. > > v1: https://lists.proxmox.com/pipermail/pve-devel/2023-November/060814.html > > Changes v1 -> v2: > * rebased on lastest master

Re: [pve-devel] [PATCH pve-network 1/1] Fixed Netbox API Path

2024-02-20 Thread Thomas Lamprecht
Am 20/01/2024 um 18:57 schrieb Jasper Yu: > --- > src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm > b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm > index 91010bb..666ea70 100644 > ---

[pve-devel] applied: [PATCH v2 pve-network 0/6] external ipams fixes

2024-02-20 Thread Thomas Lamprecht
Am 13/02/2024 um 09:48 schrieb Alexandre Derumier: > multiples ipam fixes > > v2: > add netbox ipam ip_is_gateway fix > > > > Alexandre Derumier (6): > ipams : add_next_freeip : return ip not cidr > sdn: add proxy support for api calls > ipam: phpipam: fix subnet create > ipam:

[pve-devel] applied: [PATCH pve-manager] qemu: bump max cores to 256 by socket

2024-02-20 Thread Thomas Lamprecht
Am 12/01/2024 um 21:08 schrieb Alexandre Derumier: > New epyc cpu already support 168 threads > > qemu 8.1 support 1024 cores with q35 > --- > www/manager6/qemu/ProcessorEdit.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, as even though removing the maximum here (or

[pve-devel] applied-series: [PATCH docs 1/3] qm: resource limits: revise section cpulimit

2024-02-20 Thread Thomas Lamprecht
Am 16/01/2024 um 14:22 schrieb Alexander Zeidler: > * precise statements > * increase compactness w/o complexity > * improve section-formatting > > Signed-off-by: Alexander Zeidler > --- > qm.adoc | 40 +--- > 1 file changed, 21 insertions(+), 19 deletions(-)

[pve-devel] applied: [PATCH docs] pvecm: correct network address

2024-02-20 Thread Thomas Lamprecht
Am 16/01/2024 um 14:10 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > pvecm.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH docs] ballooning: precise example

2024-02-20 Thread Thomas Lamprecht
Am 16/01/2024 um 16:04 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > qm.adoc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

Re: [pve-devel] fix #5254: add separate Sys.AccessNetwork privilege

2024-02-19 Thread Thomas Lamprecht
What I forgot to mention: - docs patch is still missing, but would just add an entry for this new priv in the list of existing privileges with a short description - there aren't really hard dependencies between the patches of the different packages, it just won't work, so I do not think we

[pve-devel] [PATCH manager 1/2] api: nodes: allow usage of query url metadata with Sys.AccessNetwork

2024-02-19 Thread Thomas Lamprecht
and size before downloading it to a storage). For backwards compatibility keep the old check and add the new privilege as alternative to fulfill the permission requirements of that API endpoint. [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5254 Signed-off-by: Thomas Lamprecht --- PVE/API2

[pve-devel] [PATCH storage:] fix #5254: api: allow usage of download-url with Sys.AccessNetwork

2024-02-19 Thread Thomas Lamprecht
://bugzilla.proxmox.com/show_bug.cgi?id=5254 Signed-off-by: Thomas Lamprecht --- src/PVE/API2/Storage/Status.pm | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm index b2336e6..bc67b81 100644 --- a/src/PVE/API2

[pve-devel] [PATCH manager 2/2] ui: storage: enable download-url button with Sys.AccessNetwork capability

2024-02-19 Thread Thomas Lamprecht
. Signed-off-by: Thomas Lamprecht --- www/manager6/storage/Browser.js | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js index 457816a6..c2ad01e9 100644 --- a/www/manager6/storage/Browser.js +++ b/www/manager6

[pve-devel] fix #5254: add separate Sys.AccessNetwork privilege

2024-02-19 Thread Thomas Lamprecht
ed) side channel too. access-control: Thomas Lamprecht (1): add Sys.AccessNetwork privilege src/PVE/AccessControl.pm | 1 + src/test/perm-test1.pl | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) storage: Thomas Lamprecht (1): fix #5254: api: allow usage of download-url wi

[pve-devel] [PATCH access-control] add Sys.AccessNetwork privilege

2024-02-19 Thread Thomas Lamprecht
://bugzilla.proxmox.com/show_bug.cgi?id=5254 Signed-off-by: Thomas Lamprecht --- src/PVE/AccessControl.pm | 1 + src/test/perm-test1.pl | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index 25fc0d9..faea70d 100644 --- a/src/PVE

Re: [pve-devel] applied: [PATCH manager v2] fix #5106: ui: ceph status: make column wrap the summary text on expand

2024-02-19 Thread Thomas Lamprecht
Am 19/02/2024 um 14:59 schrieb Dominik Csapak: > On 2/19/24 14:57, Thomas Lamprecht wrote: >> btw. I first tried `pve-eslint --fix .` inside the (clean) www/manager6 >> folder, but that just resulted in a truncated ceph/Status.js file, so while >> eslint seems to correct

[pve-devel] applied: [PATCH manager v2] fix #5106: ui: ceph status: make column wrap the summary text on expand

2024-02-19 Thread Thomas Lamprecht
Am 07/12/2023 um 14:35 schrieb Dominik Csapak: > with this the title is now completely visible when the column is > expanded, even if it's originally too narrow. > > Suggested-by: Thomas Lamprecht > Signed-off-by: Dominik Csapak > --- > changes from v1: > * wrap the tex

Re: [pve-devel] [PATCH qemu-server 1/1] fix #1905: Allow moving unused disks

2024-02-19 Thread Thomas Lamprecht
Am 19/02/2024 um 12:11 schrieb Filip Schauer: > Allow moving unused/detached disks to another storage. this is a repetition of the commit subject, while that is on it's own OK, I'd rather see a description about why this is OK to do, i.e., why was the original check added, what changed since

Re: [pve-devel] [PATCH ceph master 3/3] buildsys: add check for changed ceph-osd sysctl settings

2024-02-15 Thread Thomas Lamprecht
Am 15/02/2024 um 10:40 schrieb Friedrich Weber: > If the ceph-osd sysctl settings template (30-ceph-osd.conf.in) shipped > by upstream changes, our ceph-osd postinst patch will need to be > adapted to apply the new settings on package upgrade. To make sure we > do not forget, store the current

[pve-devel] applied: [PATCH ceph quincy-stable-8 2/3] fix #5213: ceph-osd postinst: add patch to avoid connection freezes

2024-02-15 Thread Thomas Lamprecht
Am 15/02/2024 um 10:40 schrieb Friedrich Weber: > Assume there is an open TCP connection to a VM, and ceph-osd is > installed/upgraded on the host on which the PVE firewall is active. > Currently, ceph-osd postinst reloads all sysctl settings. Thus, > installing/upgrading ceph-osd will set the

[pve-devel] applied: [PATCH ceph master 1/3] fix #5213: ceph-osd postinst: add patch to avoid connection freezes

2024-02-15 Thread Thomas Lamprecht
Am 15/02/2024 um 10:40 schrieb Friedrich Weber: > Assume there is an open TCP connection to a VM, and ceph-osd is > installed/upgraded on the host on which the PVE firewall is active. > Currently, ceph-osd postinst reloads all sysctl settings. Thus, > installing/upgrading ceph-osd will set the

Re: [pve-devel] [PATCH v2 quincy-stable-8 ceph 1/2] patches: include patches regarding RocksDB and dashboard from master

2024-02-15 Thread Thomas Lamprecht
Am 26/01/2024 um 16:44 schrieb Max Carrara: > This commit essentially contains all changes from the following > commits (most recent last): > * f35168f6713d5f3fa1aaa8c572d754b61c458d91 > * 86a553d66e69176940959530d4fedcbcbbab54d9 > * ab5c03b44d78c4e4b233ff5a310888592dbb9bb4 > > The series

Re: [pve-devel] [PATCH installer 2/4] sys: command: allow terminating the process early from log subroutine

2024-02-12 Thread Thomas Lamprecht
Am 09/02/2024 um 11:55 schrieb Christoph Heiss: > This is done in a entirely backwards-compatible way, i.e. existing > usages don't need any modification. can you actually describe here that you do so by checking the return value of the stdout parser closure, can be done in a short sentence and

[pve-devel] applied: [PATCH v2 acme] Fix EBA MAC key decoding

2024-02-12 Thread Thomas Lamprecht
Am 25/01/2024 um 09:28 schrieb YU Jincheng: > Accroding to RFC 8555: > >> The MAC key SHOULD be provided in base64url-encoded form... > > However, currently we are only decoding the MAC key as base64. > This patch chooses the correct function to decode the user provided > MAC key. This can fix

[pve-devel] applied: [PATCH container v2 2/2] pct: add keep-env option

2024-02-09 Thread Thomas Lamprecht
Am 02/02/2024 um 17:53 schrieb Thomas Lamprecht: > Am 29/01/2024 um 16:43 schrieb Folke Gleumes: >> The keep-env option allows the user to define if the current environment >> should be kept when running 'pct enter/exec'. pct will now always set >> '--keep-env' or '--discard-

[pve-devel] applied: [PATCH pve-access-control] fix #5190: access-control: openid acr format regex

2024-02-08 Thread Thomas Lamprecht
Am 06/02/2024 um 11:11 schrieb Gabriel Goller: > Restrict the acr-value regex a little bit so as to align the behavior > with PBS. The openid documentation says that the acr-value *should* be > an URI [0]. Added a regex that loosely disallows some of the reserved URI > characters specified in the

[pve-devel] applied: [PATCH v1 installer 04/18] Makefile: fix handling of multiple usr_bin files

2024-02-06 Thread Thomas Lamprecht
Am 23/01/2024 um 18:00 schrieb Aaron Lauterer: > Otherwise the build will fail once we define more than one USR_BIN > file. > > Signed-off-by: Aaron Lauterer > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied this one already, thanks!

Re: [pve-devel] [PATCH installer 0/2] expose zfs arc size setting for all products

2024-02-06 Thread Thomas Lamprecht
Am 06/02/2024 um 14:25 schrieb Christoph Heiss: > On Tue, Feb 06, 2024 at 01:49:36PM +0100, Thomas Lamprecht wrote: >> That way it would stay dynamic, e.g., if one increased the memory of >> a PBS or PMG instance, but one could also interpret that as bad thing, >> especia

Re: [pve-devel] [PATCH installer 0/2] expose zfs arc size setting for all products

2024-02-06 Thread Thomas Lamprecht
Am 30/11/2023 um 11:01 schrieb Christoph Heiss: > As suggested by Thomas, sets the default to 50% for all non-PVE > products. > > Quickly smoke-tested this, to see if all installer show the correct > value in the GUI/TUI. What I'm wondering if we should skip actively setting this as module

Re: [pve-devel] applied: [PATCH pmg_docs 1/1] Consistency of GB and GiB pmg

2024-02-06 Thread Thomas Lamprecht
Am 22/01/2024 um 18:58 schrieb Stoiko Ivanov: > applied this one to pmg-docs - huge thanks! > > > On Mon, Jul 10, 2023 at 03:49:49PM +0200, Noel Ullreich wrote: >> Since the actual system-checks are done in GiB and to stay consistent >> with the other docs, change all GB units to GiB >> >>

[pve-devel] applied: [RFC PATCH installer] proxinstall, common: remove deprecated fletcher2 as zfs checksum algorithm

2024-02-06 Thread Thomas Lamprecht
Am 22/12/2023 um 11:52 schrieb Christoph Heiss: > Fletcher-2 has long been deprecated and should not be used anymore > [0][1], so we probably should not offer it anymore too. It's been > deprecated since at least over 3 years, beyond that it's hard to find an > exact date. > > Signed-off-by:

Re: [pve-devel] [RFC kernel-meta] add proxmox-secure-boot-support package

2024-02-06 Thread Thomas Lamprecht
Am 05/02/2024 um 12:45 schrieb Fabian Grünbichler: > On February 2, 2024 7:23 pm, Thomas Lamprecht wrote: >> seems OK w.r.t. change, but do we want this to be either part of the shim, >> or a separate repo? So that we do not need to ship a new kernel meta package >> when the

[pve-devel] applied: [PATCH v2 qemu] fix #4507: add patch to automatically increase NOFILE soft limit

2024-02-06 Thread Thomas Lamprecht
Am 05/02/2024 um 14:13 schrieb Fiona Ebner: > In many configurations, e.g. multiple vNICs with multiple queues or > with many Ceph OSDs, the default soft limit of 1024 is not enough. > QEMU is supposed to work fine with file descriptors >= 1024 and does > not use select() on POSIX. Bump the soft

<    1   2   3   4   5   6   7   8   9   10   >