[pve-devel] applied: [PATCH manager 1/2] ui: factor out standalone node check

2023-11-13 Thread Thomas Lamprecht
Am 13/11/2023 um 09:59 schrieb Dominik Csapak: > into Utils and use it where we manually checked that > > Signed-off-by: Dominik Csapak > --- > I put it into utils since i did not find a better place. Could have put it > in the ResourceStore, but coupling those things seemed wrong to me. > >

Re: [pve-devel] [PATCH qemu-server 1/1] fix #5033: api: Add target-filename option to move_disk reassign

2023-11-13 Thread Thomas Lamprecht
Am 13/11/2023 um 10:38 schrieb Fabian Grünbichler: > On November 10, 2023 2:07 pm, Fiona Ebner wrote: >> I'd rather go with your current approach than a new endpoint. Having >> said that, another issue is that custom naming is not a first-class >> feature currently, e.g. live-migration of a local

[pve-devel] applied-series: [PATCH-SERIES docs/qemu-server] machine version information

2023-11-12 Thread Thomas Lamprecht
Am 10/11/2023 um 14:24 schrieb Fiona Ebner: > There are already some deprecated machine versions in QEMU currently, > namely 1.4-1.7 for i440fx and QEMU 8.2 will add some more. At some > point, support for these will be dropped completely, so start > informing and warning users about this. > > >

Re: [pve-devel] [PATCH pve-firewall 1/2] Manually construct guest config path

2023-11-12 Thread Thomas Lamprecht
Am 10/11/2023 um 14:26 schrieb Stefan Lendl: > Thomas Lamprecht writes: >> This won't work as now cfs_read_file only works by luck, if at all, as the >> cfs_read_file needs the cfs_register_file that happens in PVE::QemuServer >> so that the parser is actually available...

[pve-devel] applied-series: [PATCH manager v2 1/2] ceph: mark global pg bits setting as deprecated

2023-11-12 Thread Thomas Lamprecht
Am 22/09/2023 um 11:25 schrieb Maximiliano Sandoval: > This setting was removed in [1] as part of the v13.0.2 tag. Running > > ceph config set global osd_pg_bits 42 > > results in > > Error EINVAL: unrecognized config option 'osd_pg_bits' > > So we mark this api as deprecated and make

[pve-devel] applied-series: [PATCH manager 1/3] ui: resource tree: don't save the tooltip

2023-11-12 Thread Thomas Lamprecht
Am 10/11/2023 um 11:12 schrieb Dominik Csapak: > it shouldn't be called that often, and if we save it, it gets outdated, > e.g. when starting/stopping a guest > > Signed-off-by: Dominik Csapak > --- > www/manager6/tree/ResourceTree.js | 3 --- > 1 file changed, 3 deletions(-) > > applied all

Re: [pve-devel] [PATCH manager] ui: hide bulk migrate options on standalone nodes

2023-11-12 Thread Thomas Lamprecht
Am 10/11/2023 um 11:05 schrieb Dominik Csapak: > since there is nowhere to migrate to and we hide the regular migrate > buttons/options too. > > Signed-off-by: Dominik Csapak > --- > www/manager6/node/CmdMenu.js | 5 + > www/manager6/node/Config.js | 2 ++ > 2 files changed, 7

Re: [pve-devel] [PATCH manager v13 5/6] add clipboard checkbox to VM Options

2023-11-10 Thread Thomas Lamprecht
Am 10/11/2023 um 10:34 schrieb Dominik Csapak: >> +value: 'You cannot use the default SPICE >> clipboard' + >> +' if the VNC Clipboard is selected', > > nit: i'd maybe like an additional sentence here that says > the user has to install

Re: [pve-devel] [PATCH access-control 1/2] acl: allow more nesting for /mapping acl paths

2023-11-10 Thread Thomas Lamprecht
Am 07/11/2023 um 13:46 schrieb Lukas Wagner: > This will be needed for ACL paths for the notification system, > which will get separate namespaces for targets and matchers: > > /mapping/notification/targets/ > as well as > /mapping/notification/matchers/ Not that it matters much to this

[pve-devel] applied: [PATCH installer v3 0/2] fix #4856: tui: bootdisk: use correct defaults in advanced dialog

2023-11-09 Thread Thomas Lamprecht
Am 09/11/2023 um 10:40 schrieb Christoph Heiss: > Fixes #4856 [0]. > > Patch #1 is preparatory only, #2 the actual fix. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=4856 > > v1: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058400.html > v2:

[pve-devel] applied: [PATCH installer v2] low level: testmode: take path to disk image instead of using /dev/null

2023-11-09 Thread Thomas Lamprecht
Am 09/11/2023 um 10:47 schrieb Christoph Heiss: > .. in exactly the same way GUI and TUI installer do, streamlining them. > > Up until now, testing the TUI installer often involved hand-editing the > `run-env-info.json` to put some proper disk sizes > 0 in place. This > makes this process a lot

Re: [pve-devel] [PATCH v4 many 00/11] notifications: add SMTP endpoint

2023-11-09 Thread Thomas Lamprecht
Am 09/11/2023 um 13:34 schrieb Lukas Wagner: > On 11/9/23 13:16, Dietmar Maurer wrote: >>> On 11/8/23 16:52, Dietmar Maurer wrote: > This patch series adds support for a new notification endpoint type, > smtp. As the name suggests, this new endpoint allows PVE to talk > to SMTP server

[pve-devel] applied: [PATCH manager v2 1/2] ui: resource tree: limit tooltip to icon and text

2023-11-09 Thread Thomas Lamprecht
Am 09/11/2023 um 11:56 schrieb Dominik Csapak: > and exclude the tags for that, since we want the tags to have their own > tooltips > > we use the delegate function of the tooltips for that > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * instead of using a custom tree column

[pve-devel] applied-series: [PATCH manager v3 1/3] ui: bulk actions: reorder fields

2023-11-09 Thread Thomas Lamprecht
Am 09/11/2023 um 11:47 schrieb Dominik Csapak: > to use less vertical space > > also remove the local-storage warning since this is not that helpful > > Signed-off-by: Dominik Csapak > --- > no changes > www/manager6/window/BulkAction.js | 75 +-- > 1 file changed,

Re: [pve-devel] [PATCH manager v2 1/3] ui: bulk actions: reorder fields

2023-11-09 Thread Thomas Lamprecht
Am 08/11/2023 um 16:45 schrieb Dominik Csapak: > to use less vertical space > > also remove the local-storage warning since this is not that helpful > > Signed-off-by: Dominik Csapak > --- > new in v2 > www/manager6/window/BulkAction.js | 75 +-- > 1 file changed,

Re: [pve-devel] [PATCH v2 qemu-server] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-11-08 Thread Thomas Lamprecht
Am 08/11/2023 um 15:28 schrieb Hannes Dürr: > On 11/8/23 11:04, Fiona Ebner wrote: >> Am 08.11.23 um 09:51 schrieb Hannes Duerr: >>> + if ($opt =~ m/scsi/) { >>> + >>> PVE::QemuServer::check_scsi_feature_compatibility($opt, $created_opts, >>> $conf,

Re: [pve-devel] [PATCH pve-network 2/2] Create a cluster-wide firewall for SDN subnets

2023-11-08 Thread Thomas Lamprecht
Am 08/11/2023 um 12:35 schrieb Stefan Lendl: > Upon creation of a subnet, we create a cluster-wide firewall alias. > > Signed-off-by: Stefan Lendl > --- > > Notes: > Creates the alias directly when the Subnet is created. > > Other SDN objects are created upon 'Apply':

Re: [pve-devel] [PATCH pve-firewall 1/2] Manually construct guest config path

2023-11-08 Thread Thomas Lamprecht
Am 08/11/2023 um 12:35 schrieb Stefan Lendl: > Remove require QemuConfig from Firewall.pm > We only use it to construct the guest config paths. > Fixes circular include when accessing Firewall::Aliases from > pve-network. > This won't work as now cfs_read_file only works by luck, if at all, as

[pve-devel] applied: [PATCH i18n] german translation for the bulk action log messages

2023-11-08 Thread Thomas Lamprecht
Am 08/11/2023 um 14:51 schrieb Folke Gleumes: > --- > de.po | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > applied, but you obviously did not test this, as leaving the `# fuzzy` comments in will make gettext ignore those translations completely. I really expect some basic

Re: [pve-devel] [PATCH manager 1/2] ui: BulkActions: rework filters and include tags

2023-11-08 Thread Thomas Lamprecht
Am 08/11/2023 um 13:14 schrieb Dominik Csapak: > On 11/6/23 17:01, Thomas Lamprecht wrote: >> - the CT/VM ID filter is a bit odd, especially if tuned to match all, >>not only parts of the VMID (which would not be *that* much better >>either IMO), when I want to migrat

[pve-devel] applied: [PATCH access-control] acl: add missing SDN ACL paths to allowed list

2023-11-08 Thread Thomas Lamprecht
Am 08/11/2023 um 07:55 schrieb Fabian Grünbichler: > else it's not actually possible to define ACLs on them, which means they are > effectively root only instead of allowing their intended permission scheme. > > Signed-off-by: Fabian Grünbichler > --- > src/PVE/AccessControl.pm | 6 ++ > 1

[pve-devel] applied: [PATCH access-control] perms: fix wrong /pools entry in default set of ACL paths

2023-11-08 Thread Thomas Lamprecht
Am 08/11/2023 um 11:29 schrieb Fabian Grünbichler: > /pools is not an allowed ACL path, so this would add a bogus entry into the > effective permissions in case something got propagated from /. > > Signed-off-by: Fabian Grünbichler > --- > stumbled upon this while working on unrelated pool

[pve-devel] applied: [PATCH manager] fix #2336: ui: adjust message for bulk start/stop/migrate

2023-11-07 Thread Thomas Lamprecht
Am 07/11/2023 um 12:38 schrieb Folke Gleumes: > The message in the Task Log has been 'Start/Stop/Migrate all...', > which is misleading since not everything might be affected by bulk actions. > This also affects the messages send at a nodes startup and shutdown, but > since this just affects a

[pve-devel] applied: [PATCH installer v4 0/6] fix #4829: wire up `arc_max` ZFS option to GUI/TUI for PVE

2023-11-07 Thread Thomas Lamprecht
Am 07/11/2023 um 13:20 schrieb Christoph Heiss: > run env: remove debug print > install: use correct variable names in zfs_setup_module_conf() > proxinstall: expose `arc_max` ZFS option for PVE installations > test: add tests for zfs_arc_max calculations > common: add ZFS `arc_max`

[pve-devel] applied: [PATCH installer] tui: fix same "Administrator" typo in password and summary view

2023-11-07 Thread Thomas Lamprecht
Am 07/11/2023 um 13:23 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > proxmox-tui-installer/src/main.rs| 2 +- > proxmox-tui-installer/src/options.rs | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH v2 qemu] fix #4710: vma create: don't use O_DIRECT for tmpfs

2023-11-07 Thread Thomas Lamprecht
Am 07/11/2023 um 15:28 schrieb Fiona Ebner: > The implementation of the helper is_path_tmpfs() is similar to the > existing qemu_fd_getfs() function in util/mmap-alloc.c, which > unfortunately only takes an existing fd. > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > * rebase on

[Kernel-packages] [Bug 2037214] Re: evict_inodes inode xxx, i_count = 1, was skipped!

2023-11-07 Thread Thomas Lamprecht
This came indeed in via a cherry-pick made by Ubuntu [0], that was an early attempt to fix a bug that was actually present in the ceph layer, as confirmed by the original patch author[1], and fixed actually there now [2]. [0]: https://git.launchpad.net/~ubuntu-

Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

2023-11-06 Thread Thomas Lamprecht
Am 07/11/2023 um 08:50 schrieb Dominik Csapak: > On 11/6/23 17:31, Thomas Lamprecht wrote: >> just out of interest, could setting a flex+maxHeight for the extra-flags >> also have been an option? > > AFAICS there is no way to do that. The columns in an inputpanel > are a

[pve-devel] applied: [PATCH proxmox] apt: repositories: document status property for standard repository

2023-11-06 Thread Thomas Lamprecht
Am 29/09/2023 um 09:00 schrieb Fiona Ebner: > Suggested-by: Dietmar Maurer > Signed-off-by: Fiona Ebner > --- > proxmox-apt/src/repositories/standard.rs | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks! ___ pve-devel

[pve-devel] applied: [PATCH qemu-server 0/2] migration: fix sporadic nbd-server-stop timeout

2023-11-06 Thread Thomas Lamprecht
Am 29/09/2023 um 10:28 schrieb Alexandre Derumier: > We had some sporadic nbd-stop error when applied both patches, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-manager 2/2] ui: add bulk suspend support

2023-11-06 Thread Thomas Lamprecht
Am 18/10/2023 um 12:34 schrieb Hannes Laimer: > diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js > index d59847f2..ad0bfc03 100644 > --- a/www/manager6/form/VMSelector.js > +++ b/www/manager6/form/VMSelector.js > @@ -233,6 +233,10 @@ Ext.define('PVE.form.VMSelector',

Re: [pve-devel] [PATCH pve-manager 1/2] api: add suspendall endpoint

2023-11-06 Thread Thomas Lamprecht
Am 18/10/2023 um 12:34 schrieb Hannes Laimer: > Signed-off-by: Hannes Laimer > --- > > code is mostly taken from the already existing stopal endpoint, since > all checks are basically the same for both suspend and stop. > > PVE/API2/Nodes.pm | 118 ++

[pve-devel] applied: [PATCH common v2] fix #4162: added `Auto-Submitted` header to email body

2023-11-06 Thread Thomas Lamprecht
Am 19/09/2023 um 09:35 schrieb Gabriel Goller: > `Auto-Submitted` is defined in the rfc 5436 [1] and describes how > an automatic response (f.e. ooo replies, etc.) should behave on the > emails. When using `Auto-Submitted: auto-generated` (or any value > other than `none`) automatic replies won't

[pve-devel] applied: [PATCH common v3 1/1] PBSClient: add 'tar' parameter to file_restore_extract

2023-11-06 Thread Thomas Lamprecht
Am 19/10/2023 um 11:13 schrieb Dominik Csapak: > so that we can get a 'tar.zst' from proxmox-file-restore by giving > '--format tar --zstd' to the file-restore binary > > Signed-off-by: Dominik Csapak > --- > src/PVE/PBSClient.pm | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-)

[pve-devel] applied: [PATCH installer] install: install correct grub metapackage for the current boot-mode

2023-11-06 Thread Thomas Lamprecht
Am 28/09/2023 um 16:05 schrieb Stoiko Ivanov: > grub packages in debian split between: > * meta-packages, which handles (among other things) the reinstalling > grub to the actual device/ESP in case of a version upgrade (grub-pc, > grub-efi-amd64) > * bin-packages, which contain the actual

[pve-devel] applied: [PATCH manager v3] fix #4631: ceph: osd: create: add osds-per-device

2023-11-06 Thread Thomas Lamprecht
Am 23/08/2023 um 11:44 schrieb Aaron Lauterer: > Allows to automatically create multiple OSDs per physical device. The > main use case are fast NVME drives that would be bottlenecked by a > single OSD service. > > By using the 'ceph-volume lvm batch' command instead of the 'ceph-volume > lvm

[pve-devel] applied: applied: [PATCH proxmox-resource-scheduling] pve static: add one to avoid boosting tiny relative differences

2023-11-06 Thread Thomas Lamprecht
Am 05/10/2023 um 11:50 schrieb Fiona Ebner: > Seems like only this single patch was applied, I don't see > proxmox-perl-rs ones there (still apply cleanly). you're right, applied now, thanks (for the patch and the reminder)! ___ pve-devel mailing list

[pve-devel] applied: [PATCH proxmox-widget-toolkit] panel: sendmail edit: don't translate 'Proxmox VE' in author field

2023-11-06 Thread Thomas Lamprecht
Am 09/10/2023 um 16:15 schrieb Lukas Wagner: > The default value is determined by the backend and is never > translated (which does not make sense any way for a product name). > This was likely just a copy/paste mistake from other from fields. > > Signed-off-by: Lukas Wagner > --- >

[pve-devel] applied: [PATCH proxmox-widget-toolkit] schema: endpoint types: don't translate endpoint type names

2023-11-06 Thread Thomas Lamprecht
Am 09/10/2023 um 16:38 schrieb Lukas Wagner: > ... that are not really translatable. > > Signed-off-by: Lukas Wagner > --- > src/Schema.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH pve-manager 1/2] Refer to SDN subnets as 'Subnet' not as ID

2023-11-06 Thread Thomas Lamprecht
Am 10/10/2023 um 15:30 schrieb Stefan Lendl: > The Subnet's CIDR in the Edit view is called 'Subnet'. > Also refer to it as Subnet in the list view. > > Signed-off-by: Stefan Lendl > --- > www/manager6/sdn/SubnetView.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied both

[pve-devel] applied: [PATCH kernel-helper/manager v3] check for fitting grub-meta package on uefi systems

2023-11-06 Thread Thomas Lamprecht
Am 11/10/2023 um 15:23 schrieb Stoiko Ivanov: > v2->v3: > * adapted Friedrich's feedback (huge thanks for the patience and attention > to semantically important details!!) - so that the pve7to8 warning is > actually understandable > > v1->v2: > * adapted Friedrich's feedback (huge thanks!) >

[pve-devel] applied: [PATCH installer] Correct DNS IP check on management interface setup

2023-11-06 Thread Thomas Lamprecht
Am 16/10/2023 um 12:20 schrieb Filip Schauer: > Signed-off-by: Filip Schauer > --- > proxinstall | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

2023-11-06 Thread Thomas Lamprecht
Am 15/06/2023 um 10:08 schrieb Dominik Csapak: > this field has a fixed height, which is too tall for the create wizard, > and one cannot see the last entry when scrolling all the way down. > > to fix this, make it 20px shorter was still broken in the german translation, as that takes up more

[pve-devel] applied: [PATCH manager v2] ui: wizards: allow adding tags in the qemu/lxc create wizard

2023-11-06 Thread Thomas Lamprecht
Am 25/10/2023 um 13:09 schrieb Dominik Csapak: > in the general tab in the advanced section. > > For that to work, we introduce a new option for the TagEditContainer > named 'editOnly', which controls now the cancel/finish buttons, > automatically enter edit mode and disable enter/escape

Re: [pve-devel] [PATCH manager 1/2] ui: BulkActions: rework filters and include tags

2023-11-06 Thread Thomas Lamprecht
for the commit subject please: s/BulkActions/bulk actions/ Am 30/10/2023 um 13:58 schrieb Dominik Csapak: > This moves the filters out of the grid header for the BulkActions and > puts them into their own fieldset above the grid. With that, we can > easily include a tags filter (one include and

[pve-devel] partially-applied: [PATCH installer v3 0/8] fix #4829: set up lower default limit for ZFS ARC in installer

2023-11-06 Thread Thomas Lamprecht
Am 31/10/2023 um 13:10 schrieb Christoph Heiss: > Christoph Heiss (8): > run env: add comment for query_total_memory() > tui: views: add optional suffix label for `NumericEditView`s > tui: bootdisk: simplify product handling by passing the config > directly > fix #4829: install: add

Re: [pve-devel] [RFC manager 3/3] node console: lift root@pam restriction for commands

2023-11-06 Thread Thomas Lamprecht
Am 14/06/2023 um 12:42 schrieb Fabian Grünbichler: > instead, fallback to a plain login shell if the current user is not already > root. both current custom commands are effectively a root shell, so it's not > possible to allow them for regular users. > > note that the non-login commands via

[pve-devel] applied: [PATCH manager 1/3] node console: restrict all non-login commands to root@pam

2023-11-06 Thread Thomas Lamprecht
Am 14/06/2023 um 12:42 schrieb Fabian Grünbichler: > and not just upgrade. > > note that the only other non-login command (ceph_install) is restricted to > root@pam in the web UI anyway, and that the termproxy endpoint is lacking this > check and thus always falls back to a login prompt for

[pve-devel] applied: [PATCH manager 2/3] node console: allow usage for non-pam realms

2023-11-06 Thread Thomas Lamprecht
Am 14/06/2023 um 12:42 schrieb Fabian Grünbichler: > non-login commands are still restricted to root@pam if they where before. > > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Nodes.pm | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) > > applied, thanks!

Re: [pve-devel] [RFC PATCH cluster/guest-common/qemu-server/container/manager] add backend profile support

2023-11-06 Thread Thomas Lamprecht
Am 06/11/2023 um 09:17 schrieb Dominik Csapak: > On 11/4/23 09:34, Thomas Lamprecht wrote: >> On 03/11/2023 12:53, Dominik Csapak wrote: >>> Using a single section config for both VMs and CTs make handling the >>> properties a bit weird. For now i prefix the options with

Re: [pve-devel] [RFC PATCH cluster/guest-common/qemu-server/container/manager] add backend profile support

2023-11-04 Thread Thomas Lamprecht
On 03/11/2023 12:53, Dominik Csapak wrote: > This series aims to provide profile support when creating guests (ct/vm) > so that users can reuse options without having to specify them every > time. > > Sending as RFC because I don't quite like some things with the current > implementation and I'm

[pve-devel] applied: [PATCH installer 0/2] rustfmt & clippy warning fix

2023-11-03 Thread Thomas Lamprecht
On 03/11/2023 10:49, Christoph Heiss wrote: > First patch is just a mechanical rustfmt, which I apparently missed to > check during review - that's on me. Second patch fixes a longer-standing > clippy warning. > > Christoph Heiss (2): > tui, common: run rustfmt > tui: fix clippy warning > >

[pve-devel] applied: [PATCH manager 1/2] pvereport: dir2text: ignore special . and .. files

2023-11-02 Thread Thomas Lamprecht
On 03/10/2023 13:36, Aaron Lauterer wrote: > So far this hasn't been an issue as each user of dir2text wanted files > with a specific pattern. But if we want every file in the directory, we > need to skip the special files '.' and '..'. > > Signed-off-by: Aaron Lauterer > --- > PVE/Report.pm |

[pve-devel] aüüöoed: [PATCH docs] correct outdated info about gui header

2023-11-02 Thread Thomas Lamprecht
On 02/11/2023 16:08, Dominik Csapak wrote: > the header part of the gui did change, by moving the user name into a > button, which now contains more user specific actions. Update it to be > correct again. > applied, with some language follow-ups, thanks — keeping such things up-to-date is

[pve-devel] applied: [PATCH zfsonlinux] add patch for spurious warning on `zfs mount -a`

2023-11-02 Thread Thomas Lamprecht
On 02/11/2023 18:33, Stoiko Ivanov wrote: > reported in our community forum: > https://forum.proxmox.com/threads/.135635/post-60036 The dot isn't required, but it seems the anchor # really is, your link goes to an ancient post without that, switched it to:

[pve-devel] applied: [PATCH zfsonlinux] add patch for spurious warning on `zfs mount -a`

2023-11-02 Thread Thomas Lamprecht
On 02/11/2023 18:33, Stoiko Ivanov wrote: > reported in our community forum: > https://forum.proxmox.com/threads/.135635/post-60036 > > the small fix was merged upstream: > https://github.com/openzfs/zfs/pull/15468 > > minimally tested by building with this patch and running > `zfs mount -a` on

[pve-devel] applied-series: [PATCH 00/12] installer: add crate for common code

2023-11-02 Thread Thomas Lamprecht
On 25/10/2023 17:59, Aaron Lauterer wrote: > since work on the auto installer is happenning in parallel, now would be > a good point to move commonly used code into its own crate. Otherwise > the auto-installer will always have to play catch up with the ongoing > development of the tui installer.

[pve-devel] applied: [PATCH pve-ceph] fix compatibility with CPUs not supporting SSE 4.1 instructions

2023-10-31 Thread Thomas Lamprecht
On 18/09/2023 17:46, Stefan Hanreich wrote: > One of our users ran into issues with running Ceph on older CPU > architectures [1]. This is apparently due to a bug in gcc-12 that > leads to SSE 4.1 instructions always being executed rather than > dynamically dispatching functions using those

Re: [pve-devel] [PATCH v2 guest-common 1/1] Add foreach_passthrough_device

2023-10-31 Thread Thomas Lamprecht
On 30/10/2023 14:12, Wolfgang Bumiller wrote: > On Tue, Oct 24, 2023 at 02:55:54PM +0200, Filip Schauer wrote: >> + >> +$func->($key, "dev/bus/usb/$bus_id/$device_id", @param); > > So this will do... something :-) > But unfortunately it won't deal with the *interesting* bits. > > So

Re: [pve-devel] [PATCH qemu-server] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-10-30 Thread Thomas Lamprecht
I mean, the properties are relatively straight forward, but some commit message would be still nice to have – e.g., how did you check if the values propagate into the guest, can this On 25/10/2023 14:37, Hannes Duerr wrote: > Signed-off-by: Hannes Duerr > --- > PVE/QemuServer.pm | 12

[pve-devel] applied: [PATCH docs] sysadmin: revise firmware chapter, add firmware repo section

2023-10-30 Thread Thomas Lamprecht
Am 30/10/2023 um 13:10 schrieb Alexander Zeidler: > Chapter "Firmware Updates": > * improve the structure and clarity of information provided > * mention which update methods are when available/recommended > * add information about the already pre-installed pve-firmware package > * emphasise the

[pve-devel] applied: [PATCH docs] ha-manager, software updates: add useful BlockIds

2023-10-30 Thread Thomas Lamprecht
Am 30/10/2023 um 12:20 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > ha-manager.adoc | 5 + > system-software-updates.adoc | 1 + > 2 files changed, 6 insertions(+) > > applied, with s/BlockIds/anchors/ in the subject, easier to understand when copied

[pve-devel] applied: [PATCH docs] ha: Explicitly mention that migrations only affect HA guests

2023-10-27 Thread Thomas Lamprecht
Am 25/10/2023 um 11:55 schrieb Maximiliano Sandoval R: > Signed-off-by: Maximiliano Sandoval R > --- > ha-manager.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! But as talked off-list, I made a follow-up that reworked that whole paragraph, it had a few small

Re: [pve-devel] [RFC SDN DHCP] Add and Remove DHCP mappings on vNIC add/remove

2023-10-27 Thread Thomas Lamprecht
Am 27/10/2023 um 13:54 schrieb Stefan Lendl: > It is on top of Stefan Hanreich's patch series therefore I replied here > as I consider it a continuation of his efforts. Please state that the next time. Also, please avoid top posting on the mailing list and trim your replies!

Re: [pve-devel] [RFC SDN DHCP] Add and Remove DHCP mappings on vNIC add/remove

2023-10-27 Thread Thomas Lamprecht
Am 27/10/2023 um 13:52 schrieb Thomas Lamprecht: > Am 27/10/2023 um 13:29 schrieb Stefan Lendl: >> Sorry, Sending this again because I noticed that I messed up the subject >> prefixes for the patches. > > I'd also prefer having such series as separate thread, not in reply

Re: [pve-devel] [RFC SDN DHCP] Add and Remove DHCP mappings on vNIC add/remove

2023-10-27 Thread Thomas Lamprecht
Am 27/10/2023 um 13:29 schrieb Stefan Lendl: > Sorry, Sending this again because I noticed that I messed up the subject > prefixes for the patches. I'd also prefer having such series as separate thread, not in reply to another (already big) series.. Also, if I didn't overlook something, you

[pve-devel] applied: [PATCH v5 storage 1/1] fix #254: iscsi: add support for multipath iscsi targets

2023-10-27 Thread Thomas Lamprecht
Am 23/10/2023 um 19:45 schrieb Yuri Konotopov: > With this patch Proxmox now tries to login to all discovered portals in > case some of them are not logged yet. > In case of multipath configuration when initially configured portal is > missing for some reason Proxmox don't lose iscsi storage now

Re: [pve-devel] [WIP v2 cluster/network/manager/qemu-server/container 00/10] Add support for DHCP servers to SDN

2023-10-27 Thread Thomas Lamprecht
Am 23/10/2023 um 14:40 schrieb Stefan Lendl: > I am currently working on the SDN feature. This is an initial review of > the patch series and I am trying to make a strong case against ephemeral > DHCP IP reservation. Stefan Hanreich's reply to the cover letter already mentions upserts, those

Re: [pve-devel] [PATCH acme v2 1/5] fix #4497: add support for external account bindings

2023-10-27 Thread Thomas Lamprecht
Am 27/10/2023 um 08:58 schrieb Thomas Lamprecht: > Am 25/10/2023 um 15:07 schrieb Folke Gleumes: >> Changes v1 -> v2: >> Switched from including the eab credentials in the info hash, >> to passing them in their own variable. This still unfortunately still >&g

Re: [pve-devel] [PATCH acme v2 1/5] fix #4497: add support for external account bindings

2023-10-27 Thread Thomas Lamprecht
Am 25/10/2023 um 15:07 schrieb Folke Gleumes: > Changes v1 -> v2: > Switched from including the eab credentials in the info hash, > to passing them in their own variable. This still unfortunately still > breaks the api, but doesn't potentially expose secrets and is > cleaner then purging the

Re: [pve-devel] [PATCH acme 1/5] fix #4497: add support for external account bindings

2023-10-27 Thread Thomas Lamprecht
Am 24/10/2023 um 10:32 schrieb Fabian Grünbichler: >> # Optionally pass $tos_url to agree to the given Terms of Service >> # POST to newAccount endpoint >> # Expects a '201 Created' reply >> # Saves and returns the account data >> sub new_account { >> -my ($self, $tos_url, %info) = @_; >>

Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option

2023-10-25 Thread Thomas Lamprecht
Am 25/10/2023 um 10:28 schrieb Christoph Heiss: > On Tue, Oct 24, 2023 at 08:59:36AM -0300, Gilberto Ferreira via pve-devel > wrote: >> Date: Tue, 24 Oct 2023 08:59:36 -0300 >> From: Gilberto Ferreira >> To: Proxmox VE development discussion >> Subject: Re: [pve-devel] [PATCH installer v2 1/6]

[pve-devel] applied-series: [PATCH installer v2 0/3] tui: remove global, unsafe setup info

2023-10-25 Thread Thomas Lamprecht
Am 25/10/2023 um 10:56 schrieb Christoph Heiss: > Removes the `static mut` for holding a `SetupInfo` instance. > > This is done by either passing the needed info as parameter, or in some > cases, the needed information is already available through other means. > > Not only does it get rid of

[pve-devel] applied: [PATCH pve-xtermjs] xtermjs: try to detect hardware support for webgl2

2023-10-25 Thread Thomas Lamprecht
Am 25/10/2023 um 11:08 schrieb Dominik Csapak: > with the new webgl renderer, chrome/chromium has buggy software support for > emulating this (see [0]), so we have to detect that manually and prevent > loading the addon. This fixes the issue that on chrome without hw > support, it would not always

[pve-devel] applied: [PATCH manager] subscription: remove ceph APT auth if invalid

2023-10-25 Thread Thomas Lamprecht
Am 25/10/2023 um 15:34 schrieb Fabian Grünbichler: > like we do for the main APT auth file(s) in proxmox-subscription. > > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Subscription.pm | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > applied, thanks!

[pve-devel] applied-series: [PATCH-SERIES v3 qemu] update to QEMU 8.1.2

2023-10-25 Thread Thomas Lamprecht
Am 17/10/2023 um 14:10 schrieb Fiona Ebner: > Patch changes: > > For backup, opening the backup dump block driver needed to be adapted, > because of coroutine context changes. > > Block graph locking was disabled, because of deadlocks. > > Snapshot code has a huge performance regression which

Re: [pve-devel] [PATCH installer v2 0/6] fix #4829: set up lower default limit for ZFS ARC in installer

2023-10-24 Thread Thomas Lamprecht
Am 24/10/2023 um 13:55 schrieb Christoph Heiss: > Fixes #4829. Introduces a new ZFS install option `arc_max` (aptly named > after the corresponding module option `zfs_arc_max`). > > For PVE installations, this can be adjusted when creating a ZFS RAID > under "Advanced Options". The default value

Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option

2023-10-24 Thread Thomas Lamprecht
Am 24/10/2023 um 13:55 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > Changes v1 -> v2: > * No changes > > Proxmox/Install.pm| 4 > Proxmox/Install/Config.pm | 1 + > Proxmox/Install/RunEnv.pm | 38 ++ > 3 files changed, 43

[pve-devel] applied: [PATCH manager 1/3] ui: tags: fix focus for edit mode

2023-10-24 Thread Thomas Lamprecht
Am 19/10/2023 um 15:36 schrieb Dominik Csapak: > such that one can tab through the editable tag fields. > We have to handle that manually, since ExtJs does not expect > contenteditable html tags for focus handling. > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/Tag.js | 9 +

Re: [pve-devel] [PATCH manager 3/3] ui: wizards: allow adding tags in the qemu/lxc create wizard

2023-10-24 Thread Thomas Lamprecht
Am 19/10/2023 um 15:36 schrieb Dominik Csapak: > in the general tab in the advanced section. > > For that to work, we introduce a new option for the TagEditContainer > named 'editOnly', which controls now the cancel/finish buttons, > automatically enter edit mode and disable enter/escape

[pve-devel] applied: [PATCH widget-toolkit] text field: add trimValue config

2023-10-24 Thread Thomas Lamprecht
Inspired by a recent bug detected in the subscription key field, where a trailing white space caused verification issues. We might even enable the trimming by default, after checking call sites that is – most often one wants to trim the text to be submitted Signed-off-by: Thomas Lamprecht

Re: [pve-devel] [PATCH manager 2/3] ui: tags: prevent pasting non plain-text content

2023-10-24 Thread Thomas Lamprecht
Am 24/10/2023 um 12:51 schrieb Dominik Csapak: > On 10/24/23 12:07, Thomas Lamprecht wrote: >> OK, let's make "no special cases for browsers" a rule that should have as >> few as possible exceptions, that can only benefit users and devs reproducing >> issues.

Re: [pve-devel] [PATCH manager 2/3] ui: tags: prevent pasting non plain-text content

2023-10-24 Thread Thomas Lamprecht
Am 24/10/2023 um 11:57 schrieb Dominik Csapak: > On 10/24/23 11:53, Thomas Lamprecht wrote: >> Am 19/10/2023 um 15:59 schrieb Dominik Csapak: >>> sry disregard this patch only, that property value is not supported in >>> firefox :( >>> >> >>

Re: [pve-devel] [PATCH manager 2/3] ui: tags: prevent pasting non plain-text content

2023-10-24 Thread Thomas Lamprecht
Am 19/10/2023 um 15:59 schrieb Dominik Csapak: > sry disregard this patch only, that property value is not supported in > firefox :( > We could set it only to "plaintext-only" for non-firefox then though? ___ pve-devel mailing list

[pve-devel] applied: [PATCH qemu-server] Fix: cpu hotplug feature can't be changed online

2023-10-24 Thread Thomas Lamprecht
Am 10/10/2023 um 17:37 schrieb Alexandre Derumier: > The cpus are passed as devices with specific id only when cpu hotplug is > enable > at start. > We can't enable/disable it online or vcpu hotplug api will thrown errors > not finding core id. > > Signed-off-by: Alexandre Derumier > --- >

Re: [pve-devel] [PATCH acme 1/5] fix #4497: add support for external account bindings

2023-10-24 Thread Thomas Lamprecht
mostly stylistic nits inline, but also a comment w.r.t. FWICT needles ABI breakage. Am 23/10/2023 um 15:18 schrieb Folke Gleumes: > implementation acording to rfc855 section 7.3.4 s/acording/according/ > > Signed-off-by: Folke Gleumes > --- > src/PVE/ACME.pm | 43

Re: [pve-devel] [PATCH docs] faq: change to inline anchors to land on the actual questions

2023-10-23 Thread Thomas Lamprecht
Am 23/10/2023 um 17:31 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > pve-faq.adoc | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/pve-faq.adoc b/pve-faq.adoc > index 93fef32..2388673 100644 > --- a/pve-faq.adoc > +++ b/pve-faq.adoc > @@

[pve-devel] applied: [PATCH docs] installation: document UP indicator in network setup

2023-10-23 Thread Thomas Lamprecht
Am 23/10/2023 um 17:11 schrieb Maximiliano Sandoval R: > See > https://git.proxmox.com/?p=pve-installer.git;a=commit;h=124ca33f9fb3780a76f0b5fd57952e69823852c8. > > Signed-off-by: Maximiliano Sandoval R > --- > pve-installation.adoc | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-)

[pve-devel] applied-series: [PATCH font-logos/manager v2 0/5] fix #2435: lxc: show distro and privileged status in summary

2023-10-23 Thread Thomas Lamprecht
Am 20/10/2023 um 15:33 schrieb Dominik Csapak: > the series looks mostly fine to me, i wrote two small > comments in the relevant patches, but both > are not super important to fix IMO > > aside from that consider this series > > Reviewed-by: Dominik Csapak > Tested-by: Dominik Csapak With

[pve-devel] applied: [PATCH qemu-server] vzdump: assemble: improve error messages

2023-10-23 Thread Thomas Lamprecht
Am 23/10/2023 um 10:59 schrieb Fiona Ebner: > by including the errno. Might make it clearer what the issue is in > cases like: https://forum.proxmox.com/threads/135261/ > > Also add the missing newlines, the missing "to" in the second message, > switch to the more common "or die" and avoid line

[pve-devel] applied: [PATCH manager v2] pvesh: decode streamed responses

2023-10-21 Thread Thomas Lamprecht
Am 07/06/2023 um 16:15 schrieb Christoph Heiss: > This allows to use `pvesh` on endpoints like /nodes/{node}/journal, > which return streamed (and possibly gzip'd) responses. > > Currently, e.g. `pvesh get /nodes/localhost/journal --lastentries 10` > fails with: > > gzip: stdout: Broken pipe >

[pve-devel] applied: [PATCH pve-kernel] backport exposing FLUSHBYASID when running nested VMs on AMD CPUs

2023-10-21 Thread Thomas Lamprecht
Am 19/10/2023 um 16:59 schrieb Stefan Sterz: > this exposes the FLUSHBYASID CPU flag to nested VMs when running on an > AMD CPU. also reverts a made up check that would advertise > FLUSHBYASID as not supported. this enable certain modern hypervisors > such as VMWare ESXi 7 and Workstation 17 to

[pve-devel] applied: [PATCH v2 debcargo-conf 01/11] package mail-parser 0.8.2

2023-10-20 Thread Thomas Lamprecht
Am 02/10/2023 um 10:06 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > src/mail-parser/debian/changelog | 6 ++ > src/mail-parser/debian/copyright | 49 > .../debian/copyright.debcargo.hint| 77 +++ >

[pve-devel] applied-series: [PATCH installer 0/5] use hostname from DHCP lease if available

2023-10-20 Thread Thomas Lamprecht
Am 20/10/2023 um 11:46 schrieb Christoph Heiss: > DHCP servers can set option 12 ("host-name") for client leases [0], > telling them about their hostname. It's very much non-invasive and falls > back to the default values as done currently. > > This came up while talking to Aaron, which he

Re: [pve-devel] [PATCH RFC container] Add device passthrough

2023-10-20 Thread Thomas Lamprecht
Am 20/10/2023 um 09:51 schrieb Dominik Csapak: > On 10/20/23 09:08, Wolfgang Bumiller wrote: >> Also, Dominik recently added resource mappings for qemu for USB & PCI. >> PCI might be tricky, but for USB we may be able to use these mappings as >> well. >> That said, "raw" `/dev` node pass-through

[pve-devel] applied: [PATCH installer v3] fix #4869: Show state in management interface ComboBox

2023-10-19 Thread Thomas Lamprecht
Am 19/10/2023 um 10:35 schrieb Maximiliano Sandoval R: > From: Maximiliano Sandoval > > This is a continuation of > https://lists.proxmox.com/pipermail/pve-devel/2023-August/058639.html. > > Signed-off-by: Maximiliano Sandoval R > --- > v3 was tested only with `make check-pve`. v2 was properly

Re: [pve-devel] [PATCH ifupdown2] patch: fix bond mac address at boot.

2023-10-19 Thread Thomas Lamprecht
Am 01/09/2023 um 11:12 schrieb Alexandre Derumier: > since systemd v241, like for bridge, the bond mac is setup > randomly at boot, instead inherit from first slave. > > Then, on next ifreload, ifupdown2 was already fixing it, > but with an down/up of the bond (with potentials impact on the

[pve-devel] applied: [PATCH pve-installer v9] update the PCI(e) docs

2023-10-18 Thread Thomas Lamprecht
Am 20/07/2023 um 11:32 schrieb Noel Ullreich: > A little update to the PCI(e) docs. The PCI wiki article has been > reworked as well, in line with changes from this patch. > > Along some minor grammar fixes added: > * how to check if kernelmodules are being loaded > * how to check which drivers

Re: [pve-devel] [RFC] towards automated integration testing

2023-10-17 Thread Thomas Lamprecht
Am 17/10/2023 um 14:33 schrieb Lukas Wagner: > On 10/17/23 08:35, Thomas Lamprecht wrote: >>  From top of my head I'd rather do some attribute based dependency >> annotation, so that one can depend on single tests, or whole fixture >> on others single tests or whole fixt

Re: [pve-devel] [RFC] towards automated integration testing

2023-10-17 Thread Thomas Lamprecht
Am 16/10/2023 um 17:18 schrieb Lukas Wagner: > On 10/16/23 13:20, Stefan Hanreich wrote: >> I can imagine having to setup VMs inside the Test Setup as well for >> doing various tests. Doing this manually every time could be quite >> cumbersome / hard to automate. Do you have a mechanism in mind to

<    1   2   3   4   5   6   7   8   9   10   >